linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/15]  staging: wlang-ng: fix line style warnings in prism2sta.c
Date: Mon, 03 Oct 2016 09:16:06 -0700	[thread overview]
Message-ID: <1475511366.24781.1.camel@perches.com> (raw)
In-Reply-To: <1475510655-12729-15-git-send-email-sergio.paracuellos@gmail.com>

On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote:
> This patch fix the following checkpatch.pl warnings in prism2sta.c:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
[]
> @@ -1099,7 +1101,8 @@ static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev,
>  
>  	kfree(hw->scanresults);
>  
> -	hw->scanresults = kmemdup(inf, sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);
> +	hw->scanresults = kmemdup(inf,
> +				  sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);

Perhaps better as

	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);

  reply	other threads:[~2016-10-03 16:16 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 16:04 [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 02/15] staging: wlang-ng: fix block comment " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 04/15] staging: wlang-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 05/15] staging: wlang-ng: fix block comment " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 07/15] staging: wlang-ng: fix block comment warnings in p80211req.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 08/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 10/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 14/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:16   ` Joe Perches [this message]
2016-10-03 18:12     ` Sergio Paracuellos
2016-10-03 18:18       ` Joe Perches
2016-10-04  4:45         ` Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos
2016-10-09 14:31 ` [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files Greg KH
2016-10-09 15:10   ` [PATCH 00/15] staging: wlan-ng: " Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 02/15] staging: wlan-ng: fix block comment " Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 05/15] staging: wlan-ng: fix block comment " Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 06/15] staging: wlan-ng: do not return -ENOSYS Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 08/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 10/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 14/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:23       ` Greg KH
2016-10-09 15:43         ` Sergio Paracuellos
2016-10-09 15:10     ` [PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475511366.24781.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).