From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 06/15] staging: wlan-ng: do not return -ENOSYS
Date: Sun, 9 Oct 2016 17:10:23 +0200 [thread overview]
Message-ID: <1476025832-15174-7-git-send-email-sergio.paracuellos@gmail.com> (raw)
In-Reply-To: <1476025832-15174-1-git-send-email-sergio.paracuellos@gmail.com>
Fixed coding style issue by replacing ENOSYS with EINVAL.
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index fb28d8f..656033a 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -532,7 +532,7 @@ static int p80211netdev_ethtool(struct wlandevice *wlandev,
* -ETIME p80211 cmd timed out (MSD may have its own timers)
* -EFAULT memory fault copying msg from user buffer
* -ENOMEM unable to allocate kernel msg buffer
- * -ENOSYS bad magic, it the cmd really for us?
+ * -EINVAL bad magic, it the cmd really for us?
* -EintR sleeping on cmd, awakened by signal, cmd cancelled.
*
* Call Context:
@@ -560,7 +560,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
/* Test the magic, assume ifr is good if it's there */
if (req->magic != P80211_IOCTL_MAGIC) {
- result = -ENOSYS;
+ result = -EINVAL;
goto bail;
}
@@ -568,7 +568,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
result = 0;
goto bail;
} else if (cmd != P80211_IFREQ) {
- result = -ENOSYS;
+ result = -EINVAL;
goto bail;
}
--
1.9.1
next prev parent reply other threads:[~2016-10-09 15:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 16:04 [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 02/15] staging: wlang-ng: fix block comment " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 04/15] staging: wlang-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 05/15] staging: wlang-ng: fix block comment " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 07/15] staging: wlang-ng: fix block comment warnings in p80211req.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 08/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 10/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 14/15] staging: wlang-ng: fix line style " Sergio Paracuellos
2016-10-03 16:16 ` Joe Perches
2016-10-03 18:12 ` Sergio Paracuellos
2016-10-03 18:18 ` Joe Perches
2016-10-04 4:45 ` Sergio Paracuellos
2016-10-03 16:04 ` [PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos
2016-10-09 14:31 ` [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files Greg KH
2016-10-09 15:10 ` [PATCH 00/15] staging: wlan-ng: " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 02/15] staging: wlan-ng: fix block comment " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 05/15] staging: wlan-ng: fix block comment " Sergio Paracuellos
2016-10-09 15:10 ` Sergio Paracuellos [this message]
2016-10-09 15:10 ` [PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 08/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 10/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 14/15] staging: wlan-ng: fix line style " Sergio Paracuellos
2016-10-09 15:23 ` Greg KH
2016-10-09 15:43 ` Sergio Paracuellos
2016-10-09 15:10 ` [PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476025832-15174-7-git-send-email-sergio.paracuellos@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).