* [PATCH] char: tb0219: fix build failure
@ 2016-10-05 13:43 Sudip Mukherjee
2016-10-05 22:37 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-10-05 13:43 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: linux-kernel, Sudip Mukherjee, Al Viro
The build of mips tb0219_defconfig was failing with the error:
drivers/char/tb0219.c:188:2:
error: implicit declaration of function 'put_user'
drivers/char/tb0219.c:216:3:
error: implicit declaration of function 'get_user'
Quoting Al Viro - "another victim of indirect include chains"
Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it")
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/165143641
drivers/char/tb0219.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tb0219.c b/drivers/char/tb0219.c
index 480a777..7c19d9b 100644
--- a/drivers/char/tb0219.c
+++ b/drivers/char/tb0219.c
@@ -21,6 +21,7 @@
#include <linux/fs.h>
#include <linux/init.h>
#include <linux/module.h>
+#include <linux/uaccess.h>
#include <asm/io.h>
#include <asm/reboot.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] char: tb0219: fix build failure
2016-10-05 13:43 [PATCH] char: tb0219: fix build failure Sudip Mukherjee
@ 2016-10-05 22:37 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2016-10-05 22:37 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel
On Wed, Oct 05, 2016 at 07:13:22PM +0530, Sudip Mukherjee wrote:
> The build of mips tb0219_defconfig was failing with the error:
>
> drivers/char/tb0219.c:188:2:
> error: implicit declaration of function 'put_user'
> drivers/char/tb0219.c:216:3:
> error: implicit declaration of function 'get_user'
this one, OTOH, was not; fix folded, with credits to you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-05 22:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-05 13:43 [PATCH] char: tb0219: fix build failure Sudip Mukherjee
2016-10-05 22:37 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).