* [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
@ 2016-10-07 15:43 Nadim Almas
2016-10-07 17:07 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Nadim Almas @ 2016-10-07 15:43 UTC (permalink / raw)
To: thomas.petazzoni, gregkh; +Cc: devel, linux-kernel
style issue
Fixed coding style issue
Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
index 774b0ff..bc0c48f 100644
--- a/drivers/staging/fbtft/fb_s6d02a1.c
+++ b/drivers/staging/fbtft/fb_s6d02a1.c
@@ -30,20 +30,27 @@ static int default_init_sequence[] = {
-1, 0xfc, 0x5a, 0x5a,
- -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01,
+ -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A,
+ 0x3A, 0x3A, 0x3d, 0x02, 0x01,
- -1, 0xfb, 0x21, 0x00, 0x02, 0x04, 0x07, 0x0a, 0x0b, 0x0c, 0x0c, 0x16, 0x1e, 0x30, 0x3f, 0x01, 0x02,
+ -1, 0xfb, 0x21, 0x00, 0x02, 0x04, 0x07, 0x0a, 0x0b, 0x0c, 0x0c, 0x16,
+ 0x1e, 0x30, 0x3f, 0x01, 0x02,
/* power setting sequence */
- -1, 0xfd, 0x00, 0x00, 0x00, 0x17, 0x10, 0x00, 0x01, 0x01, 0x00, 0x1f, 0x1f,
+ -1, 0xfd, 0x00, 0x00, 0x00, 0x17, 0x10, 0x00, 0x01, 0x01, 0x00, 0x1f,
+ 0x1f,
- -1, 0xf4, 0x00, 0x00, 0x00, 0x00, 0x00, 0x3f, 0x3f, 0x07, 0x00, 0x3C, 0x36, 0x00, 0x3C, 0x36, 0x00,
+ -1, 0xf4, 0x00, 0x00, 0x00, 0x00, 0x00, 0x3f, 0x3f, 0x07, 0x00, 0x3C,
+ 0x36, 0x00, 0x3C, 0x36, 0x00,
- -1, 0xf5, 0x00, 0x70, 0x66, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x6d, 0x66, 0x06,
+ -1, 0xf5, 0x00, 0x70, 0x66, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x6d, 0x66, 0x06,
- -1, 0xf6, 0x02, 0x00, 0x3f, 0x00, 0x00, 0x00, 0x02, 0x00, 0x06, 0x01, 0x00,
+ -1, 0xf6, 0x02, 0x00, 0x3f, 0x00, 0x00, 0x00, 0x02, 0x00, 0x06, 0x01,
+ 0x00,
- -1, 0xf2, 0x00, 0x01, 0x03, 0x08, 0x08, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x04, 0x08, 0x08,
+ -1, 0xf2, 0x00, 0x01, 0x03, 0x08, 0x08, 0x04, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x01, 0x00, 0x00, 0x04, 0x08, 0x08,
-1, 0xf8, 0x11,
@@ -63,7 +70,8 @@ static int default_init_sequence[] = {
-1, 0xf3, 0x00, 0x0f,
-2, 50,
- -1, 0xf4, 0x00, 0x04, 0x00, 0x00, 0x00, 0x3f, 0x3f, 0x07, 0x00, 0x3C, 0x36, 0x00, 0x3C, 0x36, 0x00,
+ -1, 0xf4, 0x00, 0x04, 0x00, 0x00, 0x00, 0x3f, 0x3f, 0x07,
+ 0x00, 0x3C, 0x36, 0x00, 0x3C, 0x36, 0x00,
-2, 50,
-1, 0xf3, 0x00, 0x1f,
@@ -74,9 +82,11 @@ static int default_init_sequence[] = {
-1, 0xf3, 0x00, 0xff,
-2, 50,
- -1, 0xfd, 0x00, 0x00, 0x00, 0x17, 0x10, 0x00, 0x00, 0x01, 0x00, 0x16, 0x16,
+ -1, 0xfd, 0x00, 0x00, 0x00, 0x17, 0x10, 0x00, 0x00, 0x01,
+ 0x00, 0x16, 0x16,
- -1, 0xf4, 0x00, 0x09, 0x00, 0x00, 0x00, 0x3f, 0x3f, 0x07, 0x00, 0x3C, 0x36, 0x00, 0x3C, 0x36, 0x00,
+ -1, 0xf4, 0x00, 0x09, 0x00, 0x00, 0x00, 0x3f, 0x3f, 0x07, 0x00, 0x3C,
+ 0x36, 0x00, 0x3C, 0x36, 0x00,
/* initializing sequence */
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
2016-10-07 15:43 [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding Nadim Almas
@ 2016-10-07 17:07 ` Greg KH
2016-10-07 18:55 ` Nadim Almas
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-10-07 17:07 UTC (permalink / raw)
To: Nadim Almas; +Cc: thomas.petazzoni, devel, linux-kernel
On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote:
> style issue
>
> Fixed coding style issue
This does not seem like valid sentances that mean much to me. Do they
to you?
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
> drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
> index 774b0ff..bc0c48f 100644
> --- a/drivers/staging/fbtft/fb_s6d02a1.c
> +++ b/drivers/staging/fbtft/fb_s6d02a1.c
> @@ -30,20 +30,27 @@ static int default_init_sequence[] = {
>
> -1, 0xfc, 0x5a, 0x5a,
>
> - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01,
> + -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A,
> + 0x3A, 0x3A, 0x3d, 0x02, 0x01,
This looks worse to me now, remember, checkpatch.pl is a "hint", not a
hard-and-fast-rule. Use it wisely.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
2016-10-07 17:07 ` Greg KH
@ 2016-10-07 18:55 ` Nadim Almas
2016-10-07 20:00 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Nadim Almas @ 2016-10-07 18:55 UTC (permalink / raw)
To: Greg KH; +Cc: thomas.petazzoni, devel, linux-kernel
why its seems worst to you i am just removing "80 character line
limit coding style"
for the last 3 months I am trying to submit my first patch but patch
is not accepted by you by giving reason i can't able to understand
please help me
On Fri, Oct 7, 2016 at 10:37 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote:
>> style issue
>>
>> Fixed coding style issue
>
> This does not seem like valid sentances that mean much to me. Do they
> to you?
>
>>
>> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
>> ---
>> drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++----------
>> 1 file changed, 20 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
>> index 774b0ff..bc0c48f 100644
>> --- a/drivers/staging/fbtft/fb_s6d02a1.c
>> +++ b/drivers/staging/fbtft/fb_s6d02a1.c
>> @@ -30,20 +30,27 @@ static int default_init_sequence[] = {
>>
>> -1, 0xfc, 0x5a, 0x5a,
>>
>> - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01,
>> + -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A,
>> + 0x3A, 0x3A, 0x3d, 0x02, 0x01,
>
> This looks worse to me now, remember, checkpatch.pl is a "hint", not a
> hard-and-fast-rule. Use it wisely.
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
2016-10-07 18:55 ` Nadim Almas
@ 2016-10-07 20:00 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2016-10-07 20:00 UTC (permalink / raw)
To: Nadim Almas, Greg KH; +Cc: thomas.petazzoni, devel, linux-kernel
On Sat, 2016-10-08 at 00:25 +0530, Nadim Almas wrote:
> why its seems worst to you i am just removing "80 character line
> limit coding style"
> for the last 3 months I am trying to submit my first patch but patch
> is not accepted by you by giving reason i can't able to understand
> please help me
Taste in improving code is a difficult thing to acquire,
determine and utilize.
Keep on trying to improve the code and not just in ways
that shut-up brainless tools.
Please consider the difference between your initial patch
and this proposal: https://patchwork.kernel.org/patch/9367167/
Apologies for not cc'ing you as your patch was what caused me
to look at this code at all.
> On Fri, Oct 7, 2016 at 10:37 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote:
> > > style issue
> > >
> > > Fixed coding style issue
> >
> >
> > This does not seem like valid sentances that mean much to me. Do they
> > to you?
> >
> > >
> > > Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> > > ---
> > > drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++----------
> > > 1 file changed, 20 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
> > > index 774b0ff..bc0c48f 100644
> > > --- a/drivers/staging/fbtft/fb_s6d02a1.c
> > > +++ b/drivers/staging/fbtft/fb_s6d02a1.c
> > > @@ -30,20 +30,27 @@ static int default_init_sequence[] = {
> > >
> > > -1, 0xfc, 0x5a, 0x5a,
> > >
> > > - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01,
> > > + -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A,
> > > + 0x3A, 0x3A, 0x3d, 0x02, 0x01,
> >
> >
> > This looks worse to me now, remember, checkpatch.pl is a "hint", not a
> > hard-and-fast-rule. Use it wisely.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-07 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-07 15:43 [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding Nadim Almas
2016-10-07 17:07 ` Greg KH
2016-10-07 18:55 ` Nadim Almas
2016-10-07 20:00 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).