* [PATCH] rtc: asm9260: fix module autoload
@ 2016-10-14 13:15 Javier Martinez Canillas
2016-10-19 6:46 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-10-14 13:15 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Alexandre Belloni, rtc-linux, Alessandro Zummo
If the driver is built as a module, autoload won't work because the module
alias information is not filled so user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
$
After this patch:
$ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
alias: of:N*T*Calphascale,asm9260-rtcC*
alias: of:N*T*Calphascale,asm9260-rtc
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/rtc/rtc-asm9260.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c
index 18a93d3e3f93..d36534965635 100644
--- a/drivers/rtc/rtc-asm9260.c
+++ b/drivers/rtc/rtc-asm9260.c
@@ -327,6 +327,7 @@ static const struct of_device_id asm9260_dt_ids[] = {
{ .compatible = "alphascale,asm9260-rtc", },
{}
};
+MODULE_DEVICE_TABLE(of, asm9260_dt_ids);
static struct platform_driver asm9260_rtc_driver = {
.probe = asm9260_rtc_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: asm9260: fix module autoload
2016-10-14 13:15 [PATCH] rtc: asm9260: fix module autoload Javier Martinez Canillas
@ 2016-10-19 6:46 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-10-19 6:46 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, rtc-linux, Alessandro Zummo
On 14/10/2016 at 10:15:35 -0300, Javier Martinez Canillas wrote :
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled so user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
> alias: of:N*T*Calphascale,asm9260-rtcC*
> alias: of:N*T*Calphascale,asm9260-rtc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/rtc/rtc-asm9260.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-19 6:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-14 13:15 [PATCH] rtc: asm9260: fix module autoload Javier Martinez Canillas
2016-10-19 6:46 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).