* [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF
@ 2016-10-14 16:00 Javier Martinez Canillas
2016-10-14 16:00 ` [PATCH 2/2] Input: da9063 " Javier Martinez Canillas
2016-10-26 23:46 ` [PATCH 1/2] Input: fsl-imx25-tcq " Dmitry Torokhov
0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-14 16:00 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Juergen Borleis, linux-input,
Markus Pargmann, Dmitry Torokhov, Lee Jones, Denis Carikli
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
After this patch:
$ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
alias: of:N*T*Cfsl,imx25-tcqC*
alias: of:N*T*Cfsl,imx25-tcq
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/input/touchscreen/fsl-imx25-tcq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
index fe9877a6af9e..d50ee490c9cc 100644
--- a/drivers/input/touchscreen/fsl-imx25-tcq.c
+++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
@@ -55,6 +55,7 @@ static const struct of_device_id mx25_tcq_ids[] = {
{ .compatible = "fsl,imx25-tcq", },
{ /* Sentinel */ }
};
+MODULE_DEVICE_TABLE(of, mx25_tcq_ids);
#define TSC_4WIRE_PRE_INDEX 0
#define TSC_4WIRE_X_INDEX 1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] Input: da9063 - fix module autoload when registered via OF
2016-10-14 16:00 [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF Javier Martinez Canillas
@ 2016-10-14 16:00 ` Javier Martinez Canillas
2016-10-26 23:46 ` Dmitry Torokhov
2016-10-26 23:46 ` [PATCH 1/2] Input: fsl-imx25-tcq " Dmitry Torokhov
1 sibling, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-14 16:00 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Dmitry Torokhov, Support Opensource,
linux-input
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
alias: platform:da9063-onkey
After this patch:
$ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
alias: platform:da9063-onkey
alias: of:N*T*Cdlg,da9062-onkeyC*
alias: of:N*T*Cdlg,da9062-onkey
alias: of:N*T*Cdlg,da9063-onkeyC*
alias: of:N*T*Cdlg,da9063-onkey
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/input/misc/da9063_onkey.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index bb863e062b03..f0d0543562df 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -87,6 +87,7 @@ static const struct of_device_id da9063_compatible_reg_id_table[] = {
{ .compatible = "dlg,da9062-onkey", .data = &da9062_regs },
{ },
};
+MODULE_DEVICE_TABLE(of, da9063_compatible_reg_id_table);
static void da9063_poll_on(struct work_struct *work)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] Input: da9063 - fix module autoload when registered via OF
2016-10-14 16:00 ` [PATCH 2/2] Input: da9063 " Javier Martinez Canillas
@ 2016-10-26 23:46 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2016-10-26 23:46 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Support Opensource, linux-input
On Fri, Oct 14, 2016 at 01:00:19PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
> alias: platform:da9063-onkey
>
> After this patch:
>
> $ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
> alias: platform:da9063-onkey
> alias: of:N*T*Cdlg,da9062-onkeyC*
> alias: of:N*T*Cdlg,da9062-onkey
> alias: of:N*T*Cdlg,da9063-onkeyC*
> alias: of:N*T*Cdlg,da9063-onkey
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
> ---
>
> drivers/input/misc/da9063_onkey.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
> index bb863e062b03..f0d0543562df 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -87,6 +87,7 @@ static const struct of_device_id da9063_compatible_reg_id_table[] = {
> { .compatible = "dlg,da9062-onkey", .data = &da9062_regs },
> { },
> };
> +MODULE_DEVICE_TABLE(of, da9063_compatible_reg_id_table);
>
> static void da9063_poll_on(struct work_struct *work)
> {
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF
2016-10-14 16:00 [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 16:00 ` [PATCH 2/2] Input: da9063 " Javier Martinez Canillas
@ 2016-10-26 23:46 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2016-10-26 23:46 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Juergen Borleis, linux-input, Markus Pargmann,
Lee Jones, Denis Carikli
On Fri, Oct 14, 2016 at 01:00:18PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
>
> After this patch:
>
> $ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
> alias: of:N*T*Cfsl,imx25-tcqC*
> alias: of:N*T*Cfsl,imx25-tcq
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
> ---
>
> drivers/input/touchscreen/fsl-imx25-tcq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
> index fe9877a6af9e..d50ee490c9cc 100644
> --- a/drivers/input/touchscreen/fsl-imx25-tcq.c
> +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
> @@ -55,6 +55,7 @@ static const struct of_device_id mx25_tcq_ids[] = {
> { .compatible = "fsl,imx25-tcq", },
> { /* Sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, mx25_tcq_ids);
>
> #define TSC_4WIRE_PRE_INDEX 0
> #define TSC_4WIRE_X_INDEX 1
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-26 23:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-14 16:00 [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 16:00 ` [PATCH 2/2] Input: da9063 " Javier Martinez Canillas
2016-10-26 23:46 ` Dmitry Torokhov
2016-10-26 23:46 ` [PATCH 1/2] Input: fsl-imx25-tcq " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).