* [PATCH 2/2] drm/msm/adreno: move function declarations to header file
@ 2016-10-22 9:17 Baoyou Xie
2016-10-22 9:17 ` [PATCH 1/2] drm/msm: add missing header dependencies Baoyou Xie
0 siblings, 1 reply; 5+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:17 UTC (permalink / raw)
To: robdclark, airlied, architt, cstout
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, arnd,
baoyou.xie, xie.baoyou, han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/adreno/a3xx_gpu.c:535:17: warning: no previous prototype for 'a3xx_gpu_init' [-Wmissing-prototypes]
drivers/gpu/drm/msm/adreno/a4xx_gpu.c:624:17: warning: no previous prototype for 'a4xx_gpu_init' [-Wmissing-prototypes]
In fact, both functions are declared in
drivers/gpu/drm/msm/adreno/adreno_device.c, but should be declared
in a header file. So this patch moves both function declarations to
drivers/gpu/drm/msm/adreno/adreno_gpu.h.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/msm/adreno/adreno_device.c | 3 ---
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 5127b75..7250ffc 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -25,9 +25,6 @@ bool hang_debug = false;
MODULE_PARM_DESC(hang_debug, "Dump registers when hang is detected (can be slow!)");
module_param_named(hang_debug, hang_debug, bool, 0600);
-struct msm_gpu *a3xx_gpu_init(struct drm_device *dev);
-struct msm_gpu *a4xx_gpu_init(struct drm_device *dev);
-
static const struct adreno_info gpulist[] = {
{
.rev = ADRENO_REV(3, 0, 5, ANY_ID),
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index a54f6e0..07d99bd 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -311,4 +311,7 @@ static inline void adreno_gpu_write(struct adreno_gpu *gpu,
gpu_write(&gpu->base, reg - 1, data);
}
+struct msm_gpu *a3xx_gpu_init(struct drm_device *dev);
+struct msm_gpu *a4xx_gpu_init(struct drm_device *dev);
+
#endif /* __ADRENO_GPU_H__ */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] drm/msm: add missing header dependencies
2016-10-22 9:17 [PATCH 2/2] drm/msm/adreno: move function declarations to header file Baoyou Xie
@ 2016-10-22 9:17 ` Baoyou Xie
2016-10-24 10:13 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Baoyou Xie @ 2016-10-22 9:17 UTC (permalink / raw)
To: robdclark, airlied, architt, cstout
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, arnd,
baoyou.xie, xie.baoyou, han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/msm_debugfs.c:141:5: warning: no previous prototype for 'msm_debugfs_init' [-Wmissing-prototypes]
drivers/gpu/drm/msm/msm_debugfs.c:158:6: warning: no previous prototype for 'msm_debugfs_cleanup' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/msm/msm_debugfs.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/msm/msm_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c
index 663f2b6..3c85373 100644
--- a/drivers/gpu/drm/msm/msm_debugfs.c
+++ b/drivers/gpu/drm/msm/msm_debugfs.c
@@ -18,6 +18,7 @@
#ifdef CONFIG_DEBUG_FS
#include "msm_drv.h"
#include "msm_gpu.h"
+#include "msm_debugfs.h"
static int msm_gpu_show(struct drm_device *dev, struct seq_file *m)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/msm: add missing header dependencies
2016-10-22 9:17 ` [PATCH 1/2] drm/msm: add missing header dependencies Baoyou Xie
@ 2016-10-24 10:13 ` Arnd Bergmann
2016-10-24 14:31 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-10-24 10:13 UTC (permalink / raw)
To: Baoyou Xie
Cc: robdclark, airlied, architt, cstout, linux-arm-msm, dri-devel,
freedreno, linux-kernel, xie.baoyou, han.fei, tang.qiang007
On Saturday, October 22, 2016 5:17:45 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/msm/msm_debugfs.c:141:5: warning: no previous prototype for 'msm_debugfs_init' [-Wmissing-prototypes]
> drivers/gpu/drm/msm/msm_debugfs.c:158:6: warning: no previous prototype for 'msm_debugfs_cleanup' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/msm/msm_debugfs.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Both patches
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Strangely, something caused the second mail to show up as a reply to the
first. No idea how that happened, but you may want to check the procedure
you used for sending the mails.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/msm: add missing header dependencies
2016-10-24 10:13 ` Arnd Bergmann
@ 2016-10-24 14:31 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2016-10-24 14:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Baoyou Xie, cstout, linux-arm-msm, tang.qiang007, xie.baoyou,
linux-kernel, dri-devel, han.fei, freedreno
On Mon, Oct 24, 2016 at 12:13:40PM +0200, Arnd Bergmann wrote:
> On Saturday, October 22, 2016 5:17:45 PM CEST Baoyou Xie wrote:
> > We get 2 warnings when building kernel with W=1:
> > drivers/gpu/drm/msm/msm_debugfs.c:141:5: warning: no previous prototype for 'msm_debugfs_init' [-Wmissing-prototypes]
> > drivers/gpu/drm/msm/msm_debugfs.c:158:6: warning: no previous prototype for 'msm_debugfs_cleanup' [-Wmissing-prototypes]
> >
> > In fact, these functions are declared in
> > drivers/gpu/drm/msm/msm_debugfs.h.
> > So this patch adds missing header dependencies.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >
>
> Both patches
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Both applied to drm-misc, thanks.
> Strangely, something caused the second mail to show up as a reply to the
> first. No idea how that happened, but you may want to check the procedure
> you used for sending the mails.
Not generated as a series, but individual patches, but then send out using
just 1 invocation of git send-email? "add" sorts before "adreno", and git
format-patch changes every non-alphanumeric character to a '-'.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/msm/adreno: move function declarations to header file
2016-09-25 7:51 Baoyou Xie
@ 2016-09-25 7:51 ` Baoyou Xie
0 siblings, 0 replies; 5+ messages in thread
From: Baoyou Xie @ 2016-09-25 7:51 UTC (permalink / raw)
To: robdclark, airlied, architt, cstout
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, arnd,
baoyou.xie, xie.baoyou, han.fei, tang.qiang007
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/adreno/a3xx_gpu.c:535:17: warning: no previous prototype for 'a3xx_gpu_init' [-Wmissing-prototypes]
drivers/gpu/drm/msm/adreno/a4xx_gpu.c:624:17: warning: no previous prototype for 'a4xx_gpu_init' [-Wmissing-prototypes]
In fact, both functions are declared in
drivers/gpu/drm/msm/adreno/adreno_device.c, but should be declared in
a header file. So this patch moves both function declarations to
drivers/gpu/drm/msm/adreno/adreno_gpu.h.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/msm/adreno/adreno_device.c | 3 ---
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 5127b75..7250ffc 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -25,9 +25,6 @@ bool hang_debug = false;
MODULE_PARM_DESC(hang_debug, "Dump registers when hang is detected (can be slow!)");
module_param_named(hang_debug, hang_debug, bool, 0600);
-struct msm_gpu *a3xx_gpu_init(struct drm_device *dev);
-struct msm_gpu *a4xx_gpu_init(struct drm_device *dev);
-
static const struct adreno_info gpulist[] = {
{
.rev = ADRENO_REV(3, 0, 5, ANY_ID),
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index a54f6e0..07d99bd 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -311,4 +311,7 @@ static inline void adreno_gpu_write(struct adreno_gpu *gpu,
gpu_write(&gpu->base, reg - 1, data);
}
+struct msm_gpu *a3xx_gpu_init(struct drm_device *dev);
+struct msm_gpu *a4xx_gpu_init(struct drm_device *dev);
+
#endif /* __ADRENO_GPU_H__ */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-24 14:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-22 9:17 [PATCH 2/2] drm/msm/adreno: move function declarations to header file Baoyou Xie
2016-10-22 9:17 ` [PATCH 1/2] drm/msm: add missing header dependencies Baoyou Xie
2016-10-24 10:13 ` Arnd Bergmann
2016-10-24 14:31 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2016-09-25 7:51 Baoyou Xie
2016-09-25 7:51 ` [PATCH 2/2] drm/msm/adreno: move function declarations to header file Baoyou Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).