* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-10-27 20:40 Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 01/15] perf bench futex: Avoid worker cacheline bouncing Arnaldo Carvalho de Melo
` (14 more replies)
0 siblings, 15 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Dave Hansen, David Ahern, Davidlohr Bueso,
Frederic Weisbecker, Jiri Olsa, Josh Poimboeuf, Namhyung Kim,
Peter Zijlstra, Sebastian Andrzej Siewior, Thomas Gleixner,
Tom Zanussi, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Build and test stats at the end of the message.
The following changes since commit 76e2d2617d767c445498c4c4b1162eb2201cdd77:
Merge tag 'perf-core-for-mingo-20161024' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-10-24 20:42:42 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161027
for you to fetch changes up to 97321c8437977490432d470799faa3e5f1227806:
perf tools: Add missing object file to the python binding linkage list (2016-10-26 19:08:43 -0200)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Support matching by topic in 'perf list' (Andi Kleen)
User visible:
- Apply cpu color only when there was activity in 'perf sched map' (Namhyung Kim)
- Always show the task's COMM in 'perf sched map -v' (Namhyung Kim)
- Fix hierarchy column counts in the perf hist browser (top, report), avoiding
showing nothing after pressing the RIGHT key a number of times (Namhyung Kim)
Infrastructure:
- Support cascading options in libsubcmd and use it to share common options in
'perf sched' subcommands (Namhyung Kim)
- Avoid worker cacheline bouncing in 'perf bench futex' (Davidlohr Bueso)
- Sanitize numeric parameters in 'perf bench futex' (Davidlohr Bueso)
- Update copies of kernel files (Arnaldo Carvalho de Melo)
- Fix scripting (perl, python) setup to avoid leaks (Arnaldo Carvalho de Melo)
- Add missing object file to the python binding linkage list (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf list: Support matching by topic
Arnaldo Carvalho de Melo (6):
perf bench mem: Ignore export.h related changes to mem{cpy,set}.S
tools: Update asm-generic/mman-common.h copy from the kernel
perf tools: Update x86's syscall_64.tbl, adding pkey_(alloc,free,mprotect)
perf scripting: Avoid leaking the scripting_context variable
perf scripting: Don't die if scripting can't be setup, disable it
perf tools: Add missing object file to the python binding linkage list
Davidlohr Bueso (2):
perf bench futex: Avoid worker cacheline bouncing
perf bench futex: Sanitize numeric parameters
Namhyung Kim (6):
perf hist browser: Fix hierarchy column counts
tools lib subcmd: Suppport cascading options
perf sched: Make common options cascading
perf sched map: Apply cpu color when there's an activity
perf sched map: Always show task comm with -v
perf tools: Introduce timestamp_in_usec()
tools/include/uapi/asm-generic/mman-common.h | 5 +++
tools/lib/subcmd/parse-options.c | 14 ++++++++
tools/lib/subcmd/parse-options.h | 2 ++
tools/perf/Makefile.perf | 4 +--
tools/perf/arch/x86/entry/syscalls/syscall_64.tbl | 3 ++
tools/perf/bench/futex-hash.c | 15 +++++----
tools/perf/bench/futex-lock-pi.c | 7 +++-
tools/perf/bench/futex-requeue.c | 2 ++
tools/perf/bench/futex-wake-parallel.c | 4 +++
tools/perf/bench/futex-wake.c | 3 ++
tools/perf/bench/futex.h | 4 +++
tools/perf/builtin-sched.c | 37 +++++++++++----------
tools/perf/builtin-script.c | 9 ++++--
tools/perf/ui/browsers/hists.c | 15 ++++++++-
tools/perf/util/parse-branch-options.c | 2 +-
tools/perf/util/pmu.c | 4 ++-
tools/perf/util/python-ext-sources | 1 +
tools/perf/util/trace-event-scripting.c | 39 +++++++++++------------
tools/perf/util/util.c | 9 ++++++
tools/perf/util/util.h | 3 ++
20 files changed, 130 insertions(+), 52 deletions(-)
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: detect openat syscall event : Ok
3: detect openat syscall event on all cpus : Ok
4: read samples using the mmap interface : Ok
5: parse events tests : Ok
6: Validate PERF_RECORD_* events & perf_sample fields : Ok
7: Test perf pmu format parsing : Ok
8: Test dso data read : Ok
9: Test dso data cache : Ok
10: Test dso data reopen : Ok
11: roundtrip evsel->name check : Ok
12: Check parsing of sched tracepoints fields : Ok
13: Generate and check syscalls:sys_enter_openat event fields: Ok
14: struct perf_event_attr setup : Ok
15: Test matching and linking multiple hists : Ok
16: Try 'import perf' in python, checking link problems : Ok
17: Test breakpoint overflow signal handler : Ok
18: Test breakpoint overflow sampling : Ok
19: Test number of exit event of a simple workload : Ok
20: Test software clock events have valid period values : Ok
21: Test object code reading : Ok
22: Test sample parsing : Ok
23: Test using a dummy software event to keep tracking : Ok
24: Test parsing with no sample_id_all bit set : Ok
25: Test filtering hist entries : Ok
26: Test mmap thread lookup : Ok
27: Test thread mg sharing : Ok
28: Test output sorting of hist entries : Ok
29: Test cumulation of child hist entries : Ok
30: Test tracking with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: Test kmod_path__parse function : Ok
34: Test thread map : Ok
35: Test LLVM searching and compiling :
35.1: Basic BPF llvm compiling test : Ok
35.2: Test kbuild searching : Ok
35.3: Compile source for BPF prologue generation test : Ok
35.4: Compile source for BPF relocation test : Ok
36: Test topology in session : Ok
37: Test BPF filter :
37.1: Test basic BPF filtering : Ok
37.2: Test BPF prologue generation : Ok
37.3: Test BPF relocation checker : Ok
38: Test thread map synthesize : Ok
39: Test cpu map synthesize : Ok
40: Test stat config synthesize : Ok
41: Test stat synthesize : Ok
42: Test stat round synthesize : Ok
43: Test attr update synthesize : Ok
44: Test events times : Ok
45: Test backward reading from ring buffer : Ok
46: Test cpu map print : Ok
47: Test SDT event probing : Ok
48: Test is_printable_array function : Ok
49: Test bitmap print : Ok
50: x86 rdpmc test : Ok
51: Test converting perf time to TSC : Ok
52: Test dwarf unwind : Ok
53: Test x86 instruction decoder - new instructions : Ok
54: Test intel cqm nmi context read : Skip
#
# dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 fedora:20: Ok
11 fedora:21: Ok
12 fedora:22: Ok
13 fedora:23: Ok
14 fedora:24: Ok
15 fedora:24-x-ARC-uClibc: Ok
16 fedora:rawhide: Ok
17 mageia:5: Ok
18 opensuse:13.2: Ok
19 opensuse:42.1: Ok
20 opensuse:tumbleweed: Ok
21 ubuntu:12.04.5: Ok
22 ubuntu:14.04: Ok
23 ubuntu:14.04.4: Ok
24 ubuntu:15.10: Ok
25 ubuntu:16.04: Ok
26 ubuntu:16.04-x-arm: Ok
27 ubuntu:16.04-x-arm64: Ok
28 ubuntu:16.04-x-powerpc: Ok
29 ubuntu:16.04-x-powerpc64: Ok
30 ubuntu:16.04-x-powerpc64el: Ok
31 ubuntu:16.04-x-s390: Ok
32 ubuntu:16.10: Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_debug_O: make DEBUG=1
make_install_prefix_O: make install prefix=/tmp/krava
make_with_babeltrace_O: make LIBBABELTRACE=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1
make_tags_O: make tags
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_help_O: make help
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_newt_O: make NO_NEWT=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_util_map_o_O: make util/map.o
make_install_bin_O: make install-bin
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_demangle_O: make NO_DEMANGLE=1
make_doc_O: make doc
make_perf_o_O: make perf.o
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_slang_O: make NO_SLANG=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_clean_all_O: make clean all
make_no_libpython_O: make NO_LIBPYTHON=1
make_pure_O: make
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_O: make install
make_no_libelf_O: make NO_LIBELF=1
make_static_O: make LDFLAGS=-static
make_no_libbpf_O: make NO_LIBBPF=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 57+ messages in thread
* [PATCH 01/15] perf bench futex: Avoid worker cacheline bouncing
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 02/15] perf bench futex: Sanitize numeric parameters Arnaldo Carvalho de Melo
` (13 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Davidlohr Bueso, Davidlohr Bueso, Arnaldo Carvalho de Melo
From: Davidlohr Bueso <dave@stgolabs.net>
Sebastian noted that overhead for worker thread ops (throughput)
accounting was producing 'perf' to appear in the profiles, consuming a
non-trivial (i.e. 13%) amount of CPU.
This is due to cacheline bouncing due to the increment of w->ops.
We can easily fix this by just working on a local copy and updating the
actual worker once done running, and ready to show the program summary.
There is no danger of the worker being concurrent, so we can trust that
no stale value is being seen by another thread.
This also gets rid of the unnecessary cache alignment hack; its not
worth it.
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: http://lkml.kernel.org/r/1477342613-9938-2-git-send-email-dave@stgolabs.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/bench/futex-hash.c | 11 +++++------
tools/perf/bench/futex-lock-pi.c | 4 +++-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/tools/perf/bench/futex-hash.c b/tools/perf/bench/futex-hash.c
index d9e5e80bb4d0..da04b8c5568a 100644
--- a/tools/perf/bench/futex-hash.c
+++ b/tools/perf/bench/futex-hash.c
@@ -39,15 +39,12 @@ static unsigned int threads_starting;
static struct stats throughput_stats;
static pthread_cond_t thread_parent, thread_worker;
-#define SMP_CACHE_BYTES 256
-#define __cacheline_aligned __attribute__ ((aligned (SMP_CACHE_BYTES)))
-
struct worker {
int tid;
u_int32_t *futex;
pthread_t thread;
unsigned long ops;
-} __cacheline_aligned;
+};
static const struct option options[] = {
OPT_UINTEGER('t', "threads", &nthreads, "Specify amount of threads"),
@@ -66,8 +63,9 @@ static const char * const bench_futex_hash_usage[] = {
static void *workerfn(void *arg)
{
int ret;
- unsigned int i;
struct worker *w = (struct worker *) arg;
+ unsigned int i;
+ unsigned long ops = w->ops; /* avoid cacheline bouncing */
pthread_mutex_lock(&thread_lock);
threads_starting--;
@@ -77,7 +75,7 @@ static void *workerfn(void *arg)
pthread_mutex_unlock(&thread_lock);
do {
- for (i = 0; i < nfutexes; i++, w->ops++) {
+ for (i = 0; i < nfutexes; i++, ops++) {
/*
* We want the futex calls to fail in order to stress
* the hashing of uaddr and not measure other steps,
@@ -91,6 +89,7 @@ static void *workerfn(void *arg)
}
} while (!done);
+ w->ops = ops;
return NULL;
}
diff --git a/tools/perf/bench/futex-lock-pi.c b/tools/perf/bench/futex-lock-pi.c
index 936d89d30483..7032e4643c65 100644
--- a/tools/perf/bench/futex-lock-pi.c
+++ b/tools/perf/bench/futex-lock-pi.c
@@ -75,6 +75,7 @@ static void toggle_done(int sig __maybe_unused,
static void *workerfn(void *arg)
{
struct worker *w = (struct worker *) arg;
+ unsigned long ops = w->ops;
pthread_mutex_lock(&thread_lock);
threads_starting--;
@@ -103,9 +104,10 @@ static void *workerfn(void *arg)
if (ret && !silent)
warn("thread %d: Could not unlock pi-lock for %p (%d)",
w->tid, w->futex, ret);
- w->ops++; /* account for thread's share of work */
+ ops++; /* account for thread's share of work */
} while (!done);
+ w->ops = ops;
return NULL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 02/15] perf bench futex: Sanitize numeric parameters
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 01/15] perf bench futex: Avoid worker cacheline bouncing Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 03/15] perf hist browser: Fix hierarchy column counts Arnaldo Carvalho de Melo
` (12 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Davidlohr Bueso, Davidlohr Bueso, Arnaldo Carvalho de Melo
From: Davidlohr Bueso <dave@stgolabs.net>
This gets rid of oddities such as:
perf bench futex hash -t -4
perf: calloc: Cannot allocate memory
Runtime (and many more) are equally busted, i.e. run for bogus amounts of
time. Just use the abs, instead of, for example errorring out.
Committer note:
After the patch:
$ perf bench futex hash -t -4
# Running 'futex/hash' benchmark:
Run summary [PID 10178]: 4 threads, each operating on 1024 [private] futexes for 10 secs.
[thread 0] futexes: 0x34f9fa0 ... 0x34faf9c [ 4702208 ops/sec ]
[thread 1] futexes: 0x34fb140 ... 0x34fc13c [ 4707020 ops/sec ]
[thread 2] futexes: 0x34fc2e0 ... 0x34fd2dc [ 4711526 ops/sec ]
[thread 3] futexes: 0x34fd480 ... 0x34fe47c [ 4709683 ops/sec ]
Averaged 4707609 operations/sec (+- 0.04%), total secs = 10
$
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: http://lkml.kernel.org/r/1477342613-9938-3-git-send-email-dave@stgolabs.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/bench/futex-hash.c | 4 ++++
tools/perf/bench/futex-lock-pi.c | 3 +++
tools/perf/bench/futex-requeue.c | 2 ++
tools/perf/bench/futex-wake-parallel.c | 4 ++++
tools/perf/bench/futex-wake.c | 3 +++
tools/perf/bench/futex.h | 4 ++++
6 files changed, 20 insertions(+)
diff --git a/tools/perf/bench/futex-hash.c b/tools/perf/bench/futex-hash.c
index da04b8c5568a..bfbb6b5f609c 100644
--- a/tools/perf/bench/futex-hash.c
+++ b/tools/perf/bench/futex-hash.c
@@ -130,6 +130,8 @@ int bench_futex_hash(int argc, const char **argv,
}
ncpus = sysconf(_SC_NPROCESSORS_ONLN);
+ nsecs = futexbench_sanitize_numeric(nsecs);
+ nfutexes = futexbench_sanitize_numeric(nfutexes);
sigfillset(&act.sa_mask);
act.sa_sigaction = toggle_done;
@@ -137,6 +139,8 @@ int bench_futex_hash(int argc, const char **argv,
if (!nthreads) /* default to the number of CPUs */
nthreads = ncpus;
+ else
+ nthreads = futexbench_sanitize_numeric(nthreads);
worker = calloc(nthreads, sizeof(*worker));
if (!worker)
diff --git a/tools/perf/bench/futex-lock-pi.c b/tools/perf/bench/futex-lock-pi.c
index 7032e4643c65..465012b320ee 100644
--- a/tools/perf/bench/futex-lock-pi.c
+++ b/tools/perf/bench/futex-lock-pi.c
@@ -152,6 +152,7 @@ int bench_futex_lock_pi(int argc, const char **argv,
goto err;
ncpus = sysconf(_SC_NPROCESSORS_ONLN);
+ nsecs = futexbench_sanitize_numeric(nsecs);
sigfillset(&act.sa_mask);
act.sa_sigaction = toggle_done;
@@ -159,6 +160,8 @@ int bench_futex_lock_pi(int argc, const char **argv,
if (!nthreads)
nthreads = ncpus;
+ else
+ nthreads = futexbench_sanitize_numeric(nthreads);
worker = calloc(nthreads, sizeof(*worker));
if (!worker)
diff --git a/tools/perf/bench/futex-requeue.c b/tools/perf/bench/futex-requeue.c
index 2b9705a8734c..fd4ee95b689a 100644
--- a/tools/perf/bench/futex-requeue.c
+++ b/tools/perf/bench/futex-requeue.c
@@ -128,6 +128,8 @@ int bench_futex_requeue(int argc, const char **argv,
if (!nthreads)
nthreads = ncpus;
+ else
+ nthreads = futexbench_sanitize_numeric(nthreads);
worker = calloc(nthreads, sizeof(*worker));
if (!worker)
diff --git a/tools/perf/bench/futex-wake-parallel.c b/tools/perf/bench/futex-wake-parallel.c
index 2c8fa67ad537..beaa6c142477 100644
--- a/tools/perf/bench/futex-wake-parallel.c
+++ b/tools/perf/bench/futex-wake-parallel.c
@@ -217,8 +217,12 @@ int bench_futex_wake_parallel(int argc, const char **argv,
sigaction(SIGINT, &act, NULL);
ncpus = sysconf(_SC_NPROCESSORS_ONLN);
+ nwaking_threads = futexbench_sanitize_numeric(nwaking_threads);
+
if (!nblocked_threads)
nblocked_threads = ncpus;
+ else
+ nblocked_threads = futexbench_sanitize_numeric(nblocked_threads);
/* some sanity checks */
if (nwaking_threads > nblocked_threads || !nwaking_threads)
diff --git a/tools/perf/bench/futex-wake.c b/tools/perf/bench/futex-wake.c
index e246b1b8388a..46efcb98b5a4 100644
--- a/tools/perf/bench/futex-wake.c
+++ b/tools/perf/bench/futex-wake.c
@@ -129,6 +129,7 @@ int bench_futex_wake(int argc, const char **argv,
}
ncpus = sysconf(_SC_NPROCESSORS_ONLN);
+ nwakes = futexbench_sanitize_numeric(nwakes);
sigfillset(&act.sa_mask);
act.sa_sigaction = toggle_done;
@@ -136,6 +137,8 @@ int bench_futex_wake(int argc, const char **argv,
if (!nthreads)
nthreads = ncpus;
+ else
+ nthreads = futexbench_sanitize_numeric(nthreads);
worker = calloc(nthreads, sizeof(*worker));
if (!worker)
diff --git a/tools/perf/bench/futex.h b/tools/perf/bench/futex.h
index b2e06d1190d0..ba7c735c0c62 100644
--- a/tools/perf/bench/futex.h
+++ b/tools/perf/bench/futex.h
@@ -7,6 +7,7 @@
#ifndef _FUTEX_H
#define _FUTEX_H
+#include <stdlib.h>
#include <unistd.h>
#include <sys/syscall.h>
#include <sys/types.h>
@@ -99,4 +100,7 @@ static inline int pthread_attr_setaffinity_np(pthread_attr_t *attr,
}
#endif
+/* User input sanitation */
+#define futexbench_sanitize_numeric(__n) abs((__n))
+
#endif /* _FUTEX_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 03/15] perf hist browser: Fix hierarchy column counts
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 01/15] perf bench futex: Avoid worker cacheline bouncing Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 02/15] perf bench futex: Sanitize numeric parameters Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 04/15] tools lib subcmd: Suppport cascading options Arnaldo Carvalho de Melo
` (11 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, Jiri Olsa, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The perf report/top on TUI supports horizontal scrolling using LEFT and
RIGHT keys.
But it calculate the number of columns incorrectly when hierarchy mode
is enabled so that keep pressing RIGHT key can make the output
disappeared.
In the hierarchy mode, all sort keys are collapsed into a single column,
so it needs to be applied when calculating column numbers.
Reported-and-Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20161024162110.17918-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browsers/hists.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index ddc4c3e59cc1..84f5dd2fb59c 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2076,8 +2076,21 @@ void hist_browser__init(struct hist_browser *browser,
browser->b.use_navkeypressed = true;
browser->show_headers = symbol_conf.show_hist_headers;
- hists__for_each_format(hists, fmt)
+ if (symbol_conf.report_hierarchy) {
+ struct perf_hpp_list_node *fmt_node;
+
+ /* count overhead columns (in the first node) */
+ fmt_node = list_first_entry(&hists->hpp_formats,
+ struct perf_hpp_list_node, list);
+ perf_hpp_list__for_each_format(&fmt_node->hpp, fmt)
+ ++browser->b.columns;
+
+ /* add a single column for whole hierarchy sort keys*/
++browser->b.columns;
+ } else {
+ hists__for_each_format(hists, fmt)
+ ++browser->b.columns;
+ }
hists__reset_column_width(hists);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 04/15] tools lib subcmd: Suppport cascading options
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 03/15] perf hist browser: Fix hierarchy column counts Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 05/15] perf sched: Make common options cascading Arnaldo Carvalho de Melo
` (10 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, Andi Kleen, David Ahern,
Josh Poimboeuf, Peter Zijlstra, Wang Nan,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
Sometimes subcommand have common options and it can only handled in the
upper level command unless it duplicates the options.
This patch adds a parent field and fallback to the parent if the given
argument was not found in the current options.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20161024030003.28534-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/subcmd/parse-options.c | 14 ++++++++++++++
tools/lib/subcmd/parse-options.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/tools/lib/subcmd/parse-options.c b/tools/lib/subcmd/parse-options.c
index 981bb4481fd5..3284bb14ae78 100644
--- a/tools/lib/subcmd/parse-options.c
+++ b/tools/lib/subcmd/parse-options.c
@@ -314,12 +314,19 @@ static int get_value(struct parse_opt_ctx_t *p,
static int parse_short_opt(struct parse_opt_ctx_t *p, const struct option *options)
{
+retry:
for (; options->type != OPTION_END; options++) {
if (options->short_name == *p->opt) {
p->opt = p->opt[1] ? p->opt + 1 : NULL;
return get_value(p, options, OPT_SHORT);
}
}
+
+ if (options->parent) {
+ options = options->parent;
+ goto retry;
+ }
+
return -2;
}
@@ -333,6 +340,7 @@ static int parse_long_opt(struct parse_opt_ctx_t *p, const char *arg,
if (!arg_end)
arg_end = arg + strlen(arg);
+retry:
for (; options->type != OPTION_END; options++) {
const char *rest;
int flags = 0;
@@ -426,6 +434,12 @@ static int parse_long_opt(struct parse_opt_ctx_t *p, const char *arg,
}
if (abbrev_option)
return get_value(p, abbrev_option, abbrev_flags);
+
+ if (options->parent) {
+ options = options->parent;
+ goto retry;
+ }
+
return -2;
}
diff --git a/tools/lib/subcmd/parse-options.h b/tools/lib/subcmd/parse-options.h
index d60cab2726da..8866ac438b34 100644
--- a/tools/lib/subcmd/parse-options.h
+++ b/tools/lib/subcmd/parse-options.h
@@ -109,11 +109,13 @@ struct option {
intptr_t defval;
bool *set;
void *data;
+ const struct option *parent;
};
#define check_vtype(v, type) ( BUILD_BUG_ON_ZERO(!__builtin_types_compatible_p(typeof(v), type)) + v )
#define OPT_END() { .type = OPTION_END }
+#define OPT_PARENT(p) { .type = OPTION_END, .parent = (p) }
#define OPT_ARGUMENT(l, h) { .type = OPTION_ARGUMENT, .long_name = (l), .help = (h) }
#define OPT_GROUP(h) { .type = OPTION_GROUP, .help = (h) }
#define OPT_BIT(s, l, v, h, b) { .type = OPTION_BIT, .short_name = (s), .long_name = (l), .value = check_vtype(v, int *), .help = (h), .defval = (b) }
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 05/15] perf sched: Make common options cascading
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 04/15] tools lib subcmd: Suppport cascading options Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 06/15] perf sched map: Apply cpu color when there's an activity Arnaldo Carvalho de Melo
` (9 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, Andi Kleen, David Ahern,
Josh Poimboeuf, Peter Zijlstra, Wang Nan,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The -i and -v options can be used in subcommands so enable cascading the
sched_options. This fixes the following inconvenience in 'perf sched':
$ perf sched -i perf.data.sched map
... (it works well) ...
$ perf sched map -i perf.data.sched
Error: unknown switch `i'
Usage: perf sched map [<options>]
--color-cpus <cpus>
highlight given CPUs in map
--color-pids <pids>
highlight given pids in map
--compact map output in compact mode
--cpus <cpus> display given CPUs in map
With this patch, the second command line works with the perf.data.sched
data file.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20161024030003.28534-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-sched.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index f5503ca22e1c..8ca1b5409289 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1954,6 +1954,15 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
.next_shortname2 = '0',
.skip_merge = 0,
};
+ const struct option sched_options[] = {
+ OPT_STRING('i', "input", &input_name, "file",
+ "input file name"),
+ OPT_INCR('v', "verbose", &verbose,
+ "be more verbose (show symbol address, etc)"),
+ OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
+ "dump raw trace in ASCII"),
+ OPT_END()
+ };
const struct option latency_options[] = {
OPT_STRING('s', "sort", &sched.sort_order, "key[,key2...]",
"sort by key(s): runtime, switch, avg, max"),
@@ -1965,7 +1974,7 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
"dump raw trace in ASCII"),
OPT_BOOLEAN('p', "pids", &sched.skip_merge,
"latency stats per pid instead of per comm"),
- OPT_END()
+ OPT_PARENT(sched_options)
};
const struct option replay_options[] = {
OPT_UINTEGER('r', "repeat", &sched.replay_repeat,
@@ -1975,16 +1984,7 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
"dump raw trace in ASCII"),
OPT_BOOLEAN('f', "force", &sched.force, "don't complain, do it"),
- OPT_END()
- };
- const struct option sched_options[] = {
- OPT_STRING('i', "input", &input_name, "file",
- "input file name"),
- OPT_INCR('v', "verbose", &verbose,
- "be more verbose (show symbol address, etc)"),
- OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
- "dump raw trace in ASCII"),
- OPT_END()
+ OPT_PARENT(sched_options)
};
const struct option map_options[] = {
OPT_BOOLEAN(0, "compact", &sched.map.comp,
@@ -1995,7 +1995,7 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
"highlight given CPUs in map"),
OPT_STRING(0, "cpus", &sched.map.cpus_str, "cpus",
"display given CPUs in map"),
- OPT_END()
+ OPT_PARENT(sched_options)
};
const char * const latency_usage[] = {
"perf sched latency [<options>]",
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 06/15] perf sched map: Apply cpu color when there's an activity
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 05/15] perf sched: Make common options cascading Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 07/15] perf sched map: Always show task comm with -v Arnaldo Carvalho de Melo
` (8 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
Applying cpu color always doesn't help readability IMHO. Instead it
might be better to applying the color when there's an activity on those
CPUs.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20161024020246.14928-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 8ca1b5409289..a8ad85914466 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
cpu_color = COLOR_CPUS;
if (cpu != this_cpu)
- color_fprintf(stdout, cpu_color, " ");
+ color_fprintf(stdout, color, " ");
else
color_fprintf(stdout, cpu_color, "*");
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 07/15] perf sched map: Always show task comm with -v
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 06/15] perf sched map: Apply cpu color when there's an activity Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 08/15] perf tools: Introduce timestamp_in_usec() Arnaldo Carvalho de Melo
` (7 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
I'd like to see the name of tasks with perf sched map, but it only shows
name of new tasks and then use short names after all. This is not good
for long running tasks since it's hard for users to track the short
names. This patch makes it show the names (except the idle task) when
-v option is used. Probably we may make it as default behavior.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20161024020246.14928-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index a8ad85914466..1f33d15314a5 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1493,7 +1493,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
goto out;
color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
- if (new_shortname) {
+ if (new_shortname || (verbose && sched_in->tid)) {
const char *pid_color = color;
if (thread__has_color(sched_in))
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 07/15] perf sched map: Always show task comm with -v Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 23:14 ` Joonwoo Park
2016-10-27 20:40 ` [PATCH 09/15] perf list: Support matching by topic Arnaldo Carvalho de Melo
` (6 subsequent siblings)
14 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
Joonwoo reported that there's a mismatch between timestamps in script
and sched commands. This was because of difference in printing the
timestamp. Factor out the code and share it so that they can be in
sync. Also I found that sched map has similar problem, fix it too.
Reported-and-Acked-by: Joonwoo Park <joonwoop@codeaurora.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20161024020246.14928-3-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-sched.c | 9 ++++++---
tools/perf/builtin-script.c | 9 ++++++---
tools/perf/util/util.c | 9 +++++++++
tools/perf/util/util.h | 3 +++
4 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 1f33d15314a5..f0ab715b4923 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1191,6 +1191,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
int i;
int ret;
u64 avg;
+ char buf[32];
if (!work_list->nb_atoms)
return;
@@ -1213,11 +1214,11 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
avg = work_list->total_lat / work_list->nb_atoms;
- printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n",
+ printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13s s\n",
(double)work_list->total_runtime / NSEC_PER_MSEC,
work_list->nb_atoms, (double)avg / NSEC_PER_MSEC,
(double)work_list->max_lat / NSEC_PER_MSEC,
- (double)work_list->max_lat_at / NSEC_PER_SEC);
+ timestamp_in_usec(buf, sizeof(buf), work_list->max_lat));
}
static int pid_cmp(struct work_atoms *l, struct work_atoms *r)
@@ -1402,6 +1403,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
int cpus_nr;
bool new_cpu = false;
const char *color = PERF_COLOR_NORMAL;
+ char buf[32];
BUG_ON(this_cpu >= MAX_CPUS || this_cpu < 0);
@@ -1492,7 +1494,8 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
if (sched->map.cpus && !cpu_map__has(sched->map.cpus, this_cpu))
goto out;
- color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
+ color_fprintf(stdout, color, " %12s secs ",
+ timestamp_in_usec(buf, sizeof(buf), timestamp));
if (new_shortname || (verbose && sched_in->tid)) {
const char *pid_color = color;
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 412fb6e65ac0..dae4d1013c33 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -441,7 +441,6 @@ static void print_sample_start(struct perf_sample *sample,
{
struct perf_event_attr *attr = &evsel->attr;
unsigned long secs;
- unsigned long usecs;
unsigned long long nsecs;
if (PRINT_FIELD(COMM)) {
@@ -468,14 +467,18 @@ static void print_sample_start(struct perf_sample *sample,
}
if (PRINT_FIELD(TIME)) {
+ char buf[32];
+ size_t sz = sizeof(buf);
+
nsecs = sample->time;
secs = nsecs / NSEC_PER_SEC;
nsecs -= secs * NSEC_PER_SEC;
- usecs = nsecs / NSEC_PER_USEC;
+
if (nanosecs)
printf("%5lu.%09llu: ", secs, nsecs);
else
- printf("%5lu.%06lu: ", secs, usecs);
+ printf("%12s: ", timestamp_in_usec(buf, sz,
+ sample->time));
}
}
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 85c56800f17a..aa3e778989ce 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -433,6 +433,15 @@ int parse_nsec_time(const char *str, u64 *ptime)
return 0;
}
+char *timestamp_in_usec(char *buf, size_t sz, u64 timestamp)
+{
+ u64 sec = timestamp / NSEC_PER_SEC;
+ u64 usec = (timestamp % NSEC_PER_SEC) / NSEC_PER_USEC;
+
+ scnprintf(buf, sz, "%"PRIu64".%06"PRIu64, sec, usec);
+ return buf;
+}
+
unsigned long parse_tag_value(const char *str, struct parse_tag *tags)
{
struct parse_tag *i = tags;
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index 71b6992f1d98..ece974f1c538 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -362,4 +362,7 @@ extern int sched_getcpu(void);
#endif
int is_printable_array(char *p, unsigned int len);
+
+char *timestamp_in_usec(char *buf, size_t sz, u64 timestamp);
+
#endif /* GIT_COMPAT_UTIL_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 09/15] perf list: Support matching by topic
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 08/15] perf tools: Introduce timestamp_in_usec() Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 10/15] perf bench mem: Ignore export.h related changes to mem{cpy,set}.S Arnaldo Carvalho de Melo
` (5 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Andi Kleen, Jiri Olsa, Arnaldo Carvalho de Melo
From: Andi Kleen <ak@linux.intel.com>
Add support in perf list topic to only show events belonging to a
specific vendor events topic. For example the following works now:
% perf list frontend
List of pre-defined events (to be used in -e):
stalled-cycles-frontend OR idle-cycles-frontend [Hardware event]
stalled-cycles-frontend OR cpu/stalled-cycles-frontend/ [Kernel PMU event]
frontend:
dsb2mite_switches.count
[Decode Stream Buffer (DSB)-to-MITE switches]
dsb2mite_switches.penalty_cycles
[Decode Stream Buffer (DSB)-to-MITE switch true penalty cycles]
dsb_fill.exceed_dsb_lines
[Cycles when Decode Stream Buffer (DSB) fill encounter more than 3 Decode Stream Buffer (DSB)
lines]
icache.hit
[Number of Instruction Cache, Streaming Buffer and Victim Cache Reads. both cacheable and
noncacheable, including UC fetches]
...
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1476902724-9586-2-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/pmu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 31b845ec32e2..dc6ccaa4e927 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -1141,7 +1141,9 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag,
if (event_glob != NULL &&
!(strglobmatch_nocase(name, event_glob) ||
(!is_cpu && strglobmatch_nocase(alias->name,
- event_glob))))
+ event_glob)) ||
+ (alias->topic &&
+ strglobmatch_nocase(alias->topic, event_glob))))
continue;
if (is_cpu && !name_only && !alias->desc)
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 10/15] perf bench mem: Ignore export.h related changes to mem{cpy,set}.S
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (8 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 09/15] perf list: Support matching by topic Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 11/15] tools: Update asm-generic/mman-common.h copy from the kernel Arnaldo Carvalho de Melo
` (4 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Jiri Olsa, Namhyung Kim, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Ignore export.h and EXPORT_SYMBOL in:
784d5699eddc ("x86: move exports to actual definitions")
We're not dragging this stuff, not useful in tools/
This silences the following warnings while building perf:
Warning: tools/arch/x86/lib/memcpy_64.S differs from kernel
Warning: tools/arch/x86/lib/memset_64.S differs from kernel
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-h9vw3pe0fq79zmyqsfr0s0mo@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.perf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 982d6439bb07..7de14f470f3c 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -381,10 +381,10 @@ $(PERF_IN): prepare FORCE
(diff -B ../arch/x86/include/asm/cpufeatures.h ../../arch/x86/include/asm/cpufeatures.h >/dev/null) \
|| echo "Warning: tools/arch/x86/include/asm/cpufeatures.h differs from kernel" >&2 )) || true
@(test -f ../../arch/x86/lib/memcpy_64.S && ( \
- (diff -B ../arch/x86/lib/memcpy_64.S ../../arch/x86/lib/memcpy_64.S >/dev/null) \
+ (diff -B -I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>" ../arch/x86/lib/memcpy_64.S ../../arch/x86/lib/memcpy_64.S >/dev/null) \
|| echo "Warning: tools/arch/x86/lib/memcpy_64.S differs from kernel" >&2 )) || true
@(test -f ../../arch/x86/lib/memset_64.S && ( \
- (diff -B ../arch/x86/lib/memset_64.S ../../arch/x86/lib/memset_64.S >/dev/null) \
+ (diff -B -I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>" ../arch/x86/lib/memset_64.S ../../arch/x86/lib/memset_64.S >/dev/null) \
|| echo "Warning: tools/arch/x86/lib/memset_64.S differs from kernel" >&2 )) || true
@(test -f ../../arch/arm/include/uapi/asm/perf_regs.h && ( \
(diff -B ../arch/arm/include/uapi/asm/perf_regs.h ../../arch/arm/include/uapi/asm/perf_regs.h >/dev/null) \
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 11/15] tools: Update asm-generic/mman-common.h copy from the kernel
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (9 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 10/15] perf bench mem: Ignore export.h related changes to mem{cpy,set}.S Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 12/15] perf tools: Update x86's syscall_64.tbl, adding pkey_(alloc,free,mprotect) Arnaldo Carvalho de Melo
` (3 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Jiri Olsa, Namhyung Kim, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To get the defines introduced in the commit e8c24d3a23a4 ("x86/pkeys:
Allocation/free syscalls")
Silencing this perf build warning:
Warning: tools/include/uapi/asm-generic/mman-common.h differs from kernel
Need to change 'perf trace' to beautify those syscalls, as soon as
booting with a kernel with it.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-yev9rexu02cl7cjeozzmrl9t@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/include/uapi/asm-generic/mman-common.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/include/uapi/asm-generic/mman-common.h b/tools/include/uapi/asm-generic/mman-common.h
index 58274382a616..8c27db0c5c08 100644
--- a/tools/include/uapi/asm-generic/mman-common.h
+++ b/tools/include/uapi/asm-generic/mman-common.h
@@ -72,4 +72,9 @@
#define MAP_HUGE_SHIFT 26
#define MAP_HUGE_MASK 0x3f
+#define PKEY_DISABLE_ACCESS 0x1
+#define PKEY_DISABLE_WRITE 0x2
+#define PKEY_ACCESS_MASK (PKEY_DISABLE_ACCESS |\
+ PKEY_DISABLE_WRITE)
+
#endif /* __ASM_GENERIC_MMAN_COMMON_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 12/15] perf tools: Update x86's syscall_64.tbl, adding pkey_(alloc,free,mprotect)
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (10 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 11/15] tools: Update asm-generic/mman-common.h copy from the kernel Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 13/15] perf scripting: Avoid leaking the scripting_context variable Arnaldo Carvalho de Melo
` (2 subsequent siblings)
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Dave Hansen, David Ahern, Jiri Olsa, Namhyung Kim,
Thomas Gleixner, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Introduced in commit f9afc6197e9b ("x86: Wire up protection keys system
calls")
This will make 'perf trace' aware of them on x86_64.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-s1ta2ttv2xacecqogmd3a9p1@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/x86/entry/syscalls/syscall_64.tbl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl b/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl
index e9ce9c7c39b4..e93ef0b38db8 100644
--- a/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl
+++ b/tools/perf/arch/x86/entry/syscalls/syscall_64.tbl
@@ -335,6 +335,9 @@
326 common copy_file_range sys_copy_file_range
327 64 preadv2 sys_preadv2
328 64 pwritev2 sys_pwritev2
+329 common pkey_mprotect sys_pkey_mprotect
+330 common pkey_alloc sys_pkey_alloc
+331 common pkey_free sys_pkey_free
#
# x32-specific system call numbers start at 512 to avoid cache impact
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 13/15] perf scripting: Avoid leaking the scripting_context variable
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (11 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 12/15] perf tools: Update x86's syscall_64.tbl, adding pkey_(alloc,free,mprotect) Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 14/15] perf scripting: Don't die if scripting can't be setup, disable it Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 15/15] perf tools: Add missing object file to the python binding linkage list Arnaldo Carvalho de Melo
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Namhyung Kim,
Tom Zanussi, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Both register_perl_scripting() and register_python_scripting() allocate
this variable, fix it by checking if it already was.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: 7e4b21b84c43 ("perf/scripts: Add Python scripting engine")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/trace-event-scripting.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
index 9df61059a85d..a2fd6e79d5a5 100644
--- a/tools/perf/util/trace-event-scripting.c
+++ b/tools/perf/util/trace-event-scripting.c
@@ -95,7 +95,8 @@ static void register_python_scripting(struct scripting_ops *scripting_ops)
if (err)
die("error registering py script extension");
- scripting_context = malloc(sizeof(struct scripting_context));
+ if (scripting_context == NULL)
+ scripting_context = malloc(sizeof(*scripting_context));
}
#ifdef NO_LIBPYTHON
@@ -159,7 +160,8 @@ static void register_perl_scripting(struct scripting_ops *scripting_ops)
if (err)
die("error registering pl script extension");
- scripting_context = malloc(sizeof(struct scripting_context));
+ if (scripting_context == NULL)
+ scripting_context = malloc(sizeof(*scripting_context));
}
#ifdef NO_LIBPERL
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 14/15] perf scripting: Don't die if scripting can't be setup, disable it
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (12 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 13/15] perf scripting: Avoid leaking the scripting_context variable Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 15/15] perf tools: Add missing object file to the python binding linkage list Arnaldo Carvalho de Melo
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Jiri Olsa, Namhyung Kim, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Removing one more set of die() calls.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-6pyil685m5i2tugg56gcy0tg@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/trace-event-scripting.c | 33 +++++++++++++++------------------
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
index a2fd6e79d5a5..0ac9077f62a2 100644
--- a/tools/perf/util/trace-event-scripting.c
+++ b/tools/perf/util/trace-event-scripting.c
@@ -25,6 +25,7 @@
#include <errno.h>
#include "../perf.h"
+#include "debug.h"
#include "util.h"
#include "trace-event.h"
@@ -86,17 +87,15 @@ struct scripting_ops python_scripting_unsupported_ops = {
static void register_python_scripting(struct scripting_ops *scripting_ops)
{
- int err;
- err = script_spec_register("Python", scripting_ops);
- if (err)
- die("error registering Python script extension");
-
- err = script_spec_register("py", scripting_ops);
- if (err)
- die("error registering py script extension");
-
if (scripting_context == NULL)
scripting_context = malloc(sizeof(*scripting_context));
+
+ if (scripting_context == NULL ||
+ script_spec_register("Python", scripting_ops) ||
+ script_spec_register("py", scripting_ops)) {
+ pr_err("Error registering Python script extension: disabling it\n");
+ zfree(&scripting_context);
+ }
}
#ifdef NO_LIBPYTHON
@@ -151,17 +150,15 @@ struct scripting_ops perl_scripting_unsupported_ops = {
static void register_perl_scripting(struct scripting_ops *scripting_ops)
{
- int err;
- err = script_spec_register("Perl", scripting_ops);
- if (err)
- die("error registering Perl script extension");
-
- err = script_spec_register("pl", scripting_ops);
- if (err)
- die("error registering pl script extension");
-
if (scripting_context == NULL)
scripting_context = malloc(sizeof(*scripting_context));
+
+ if (scripting_context == NULL ||
+ script_spec_register("Perl", scripting_ops) ||
+ script_spec_register("pl", scripting_ops)) {
+ pr_err("Error registering Perl script extension: disabling it\n");
+ zfree(&scripting_context);
+ }
}
#ifdef NO_LIBPERL
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [PATCH 15/15] perf tools: Add missing object file to the python binding linkage list
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (13 preceding siblings ...)
2016-10-27 20:40 ` [PATCH 14/15] perf scripting: Don't die if scripting can't be setup, disable it Arnaldo Carvalho de Melo
@ 2016-10-27 20:40 ` Arnaldo Carvalho de Melo
14 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-27 20:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Jiri Olsa, Namhyung Kim, Wang Nan, Andi Kleen
From: Arnaldo Carvalho de Melo <acme@redhat.com>
In ac12f6764c50 ("perf tools: Implement branch_type event parameter") we
started using the parse_branch_str() function from one of the files used
in the python binding, which caused this entry in 'perf test' to fail:
# perf test -v python
16: Try 'import perf' in python, checking link problems :
--- start ---
test child forked, pid 16667
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: /tmp/build/perf/python/perf.so: undefined symbol:
parse_branch_str
test child finished with -1
---- end ----
Try 'import perf' in python, checking link problems: FAILED!
#
I must've commited some mistake when running 'perf test' to send the
pull request for the perf-core-for-mingo-20161024 tag, to have let this
regression to pass, sigh.
Just add tools/perf/util/parse-branch-options.c and switch from using
ui__warning(), that is not available in the python binding, use
pr_warning() instead, which is good enough for this case.
Now:
# perf test python
16: Try 'import perf' in python, checking link problems : Ok
#
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: Andi Kleen <ak@linux.intel.com>
Fixes: ac12f6764c50 ("perf tools: Implement branch_type event parameter")
Link: http://lkml.kernel.org/n/tip-9kn1ct1cx9ppwqlmzl6z0xhs@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/parse-branch-options.c | 2 +-
tools/perf/util/python-ext-sources | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-branch-options.c b/tools/perf/util/parse-branch-options.c
index 3634d6974300..38fd11504015 100644
--- a/tools/perf/util/parse-branch-options.c
+++ b/tools/perf/util/parse-branch-options.c
@@ -64,7 +64,7 @@ int parse_branch_str(const char *str, __u64 *mode)
}
if (!br->name) {
ret = -1;
- ui__warning("unknown branch filter %s,"
+ pr_warning("unknown branch filter %s,"
" check man page\n", s);
goto error;
}
diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
index b7d4f4aeee61..0546a4304347 100644
--- a/tools/perf/util/python-ext-sources
+++ b/tools/perf/util/python-ext-sources
@@ -18,6 +18,7 @@ util/thread_map.c
util/util.c
util/xyarray.c
util/cgroup.c
+util/parse-branch-options.c
util/rblist.c
util/counts.c
util/strlist.c
--
2.7.4
^ permalink raw reply related [flat|nested] 57+ messages in thread
* Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-27 20:40 ` [PATCH 08/15] perf tools: Introduce timestamp_in_usec() Arnaldo Carvalho de Melo
@ 2016-10-27 23:14 ` Joonwoo Park
2016-10-28 12:53 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 57+ messages in thread
From: Joonwoo Park @ 2016-10-27 23:14 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
On 10/27/2016 01:40 PM, Arnaldo Carvalho de Melo wrote:
> From: Namhyung Kim <namhyung@kernel.org>
>
> Joonwoo reported that there's a mismatch between timestamps in script
> and sched commands. This was because of difference in printing the
> timestamp. Factor out the code and share it so that they can be in
> sync. Also I found that sched map has similar problem, fix it too.
>
> Reported-and-Acked-by: Joonwoo Park <joonwoop@codeaurora.org>
Hmm.. I didn't ACK this patch because of bug I commented at
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
s/work_list->max_lat/work_list->max_lat_at/
Do we have fix for this?
Thanks,
Joonwoo
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Link: http://lkml.kernel.org/r/20161024020246.14928-3-namhyung@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/builtin-sched.c | 9 ++++++---
> tools/perf/builtin-script.c | 9 ++++++---
> tools/perf/util/util.c | 9 +++++++++
> tools/perf/util/util.h | 3 +++
> 4 files changed, 24 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 1f33d15314a5..f0ab715b4923 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1191,6 +1191,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
> int i;
> int ret;
> u64 avg;
> + char buf[32];
>
> if (!work_list->nb_atoms)
> return;
> @@ -1213,11 +1214,11 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
>
> avg = work_list->total_lat / work_list->nb_atoms;
>
> - printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n",
> + printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13s s\n",
> (double)work_list->total_runtime / NSEC_PER_MSEC,
> work_list->nb_atoms, (double)avg / NSEC_PER_MSEC,
> (double)work_list->max_lat / NSEC_PER_MSEC,
> - (double)work_list->max_lat_at / NSEC_PER_SEC);
> + timestamp_in_usec(buf, sizeof(buf), work_list->max_lat));
> }
>
> static int pid_cmp(struct work_atoms *l, struct work_atoms *r)
> @@ -1402,6 +1403,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> int cpus_nr;
> bool new_cpu = false;
> const char *color = PERF_COLOR_NORMAL;
> + char buf[32];
>
> BUG_ON(this_cpu >= MAX_CPUS || this_cpu < 0);
>
> @@ -1492,7 +1494,8 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> if (sched->map.cpus && !cpu_map__has(sched->map.cpus, this_cpu))
> goto out;
>
> - color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
> + color_fprintf(stdout, color, " %12s secs ",
> + timestamp_in_usec(buf, sizeof(buf), timestamp));
> if (new_shortname || (verbose && sched_in->tid)) {
> const char *pid_color = color;
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 412fb6e65ac0..dae4d1013c33 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -441,7 +441,6 @@ static void print_sample_start(struct perf_sample *sample,
> {
> struct perf_event_attr *attr = &evsel->attr;
> unsigned long secs;
> - unsigned long usecs;
> unsigned long long nsecs;
>
> if (PRINT_FIELD(COMM)) {
> @@ -468,14 +467,18 @@ static void print_sample_start(struct perf_sample *sample,
> }
>
> if (PRINT_FIELD(TIME)) {
> + char buf[32];
> + size_t sz = sizeof(buf);
> +
> nsecs = sample->time;
> secs = nsecs / NSEC_PER_SEC;
> nsecs -= secs * NSEC_PER_SEC;
> - usecs = nsecs / NSEC_PER_USEC;
> +
> if (nanosecs)
> printf("%5lu.%09llu: ", secs, nsecs);
> else
> - printf("%5lu.%06lu: ", secs, usecs);
> + printf("%12s: ", timestamp_in_usec(buf, sz,
> + sample->time));
> }
> }
>
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index 85c56800f17a..aa3e778989ce 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -433,6 +433,15 @@ int parse_nsec_time(const char *str, u64 *ptime)
> return 0;
> }
>
> +char *timestamp_in_usec(char *buf, size_t sz, u64 timestamp)
> +{
> + u64 sec = timestamp / NSEC_PER_SEC;
> + u64 usec = (timestamp % NSEC_PER_SEC) / NSEC_PER_USEC;
> +
> + scnprintf(buf, sz, "%"PRIu64".%06"PRIu64, sec, usec);
> + return buf;
> +}
> +
> unsigned long parse_tag_value(const char *str, struct parse_tag *tags)
> {
> struct parse_tag *i = tags;
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index 71b6992f1d98..ece974f1c538 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -362,4 +362,7 @@ extern int sched_getcpu(void);
> #endif
>
> int is_printable_array(char *p, unsigned int len);
> +
> +char *timestamp_in_usec(char *buf, size_t sz, u64 timestamp);
> +
> #endif /* GIT_COMPAT_UTIL_H */
>
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-27 23:14 ` Joonwoo Park
@ 2016-10-28 12:53 ` Arnaldo Carvalho de Melo
2016-10-28 13:30 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-28 12:53 UTC (permalink / raw)
To: Joonwoo Park
Cc: Ingo Molnar, linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
>
>
> On 10/27/2016 01:40 PM, Arnaldo Carvalho de Melo wrote:
> > From: Namhyung Kim <namhyung@kernel.org>
> >
> > Joonwoo reported that there's a mismatch between timestamps in script
> > and sched commands. This was because of difference in printing the
> > timestamp. Factor out the code and share it so that they can be in
> > sync. Also I found that sched map has similar problem, fix it too.
> >
> > Reported-and-Acked-by: Joonwoo Park <joonwoop@codeaurora.org>
>
> Hmm.. I didn't ACK this patch because of bug I commented at
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
>
> s/work_list->max_lat/work_list->max_lat_at/
Sorry about that, I took the "thanks for taking care of this" as an ack,
now that I re-read that message I saw your points later on in that
e-mail.
Since Ingo hasn't pulled this, I'll try fixing it, will check that other
naming issue,
- Arnaldo
> Do we have fix for this?
>
> Thanks,
> Joonwoo
>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Link: http://lkml.kernel.org/r/20161024020246.14928-3-namhyung@kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> > tools/perf/builtin-sched.c | 9 ++++++---
> > tools/perf/builtin-script.c | 9 ++++++---
> > tools/perf/util/util.c | 9 +++++++++
> > tools/perf/util/util.h | 3 +++
> > 4 files changed, 24 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index 1f33d15314a5..f0ab715b4923 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -1191,6 +1191,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
> > int i;
> > int ret;
> > u64 avg;
> > + char buf[32];
> >
> > if (!work_list->nb_atoms)
> > return;
> > @@ -1213,11 +1214,11 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
> >
> > avg = work_list->total_lat / work_list->nb_atoms;
> >
> > - printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n",
> > + printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13s s\n",
> > (double)work_list->total_runtime / NSEC_PER_MSEC,
> > work_list->nb_atoms, (double)avg / NSEC_PER_MSEC,
> > (double)work_list->max_lat / NSEC_PER_MSEC,
> > - (double)work_list->max_lat_at / NSEC_PER_SEC);
> > + timestamp_in_usec(buf, sizeof(buf), work_list->max_lat));
> > }
> >
> > static int pid_cmp(struct work_atoms *l, struct work_atoms *r)
> > @@ -1402,6 +1403,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> > int cpus_nr;
> > bool new_cpu = false;
> > const char *color = PERF_COLOR_NORMAL;
> > + char buf[32];
> >
> > BUG_ON(this_cpu >= MAX_CPUS || this_cpu < 0);
> >
> > @@ -1492,7 +1494,8 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> > if (sched->map.cpus && !cpu_map__has(sched->map.cpus, this_cpu))
> > goto out;
> >
> > - color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
> > + color_fprintf(stdout, color, " %12s secs ",
> > + timestamp_in_usec(buf, sizeof(buf), timestamp));
> > if (new_shortname || (verbose && sched_in->tid)) {
> > const char *pid_color = color;
> >
> > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> > index 412fb6e65ac0..dae4d1013c33 100644
> > --- a/tools/perf/builtin-script.c
> > +++ b/tools/perf/builtin-script.c
> > @@ -441,7 +441,6 @@ static void print_sample_start(struct perf_sample *sample,
> > {
> > struct perf_event_attr *attr = &evsel->attr;
> > unsigned long secs;
> > - unsigned long usecs;
> > unsigned long long nsecs;
> >
> > if (PRINT_FIELD(COMM)) {
> > @@ -468,14 +467,18 @@ static void print_sample_start(struct perf_sample *sample,
> > }
> >
> > if (PRINT_FIELD(TIME)) {
> > + char buf[32];
> > + size_t sz = sizeof(buf);
> > +
> > nsecs = sample->time;
> > secs = nsecs / NSEC_PER_SEC;
> > nsecs -= secs * NSEC_PER_SEC;
> > - usecs = nsecs / NSEC_PER_USEC;
> > +
> > if (nanosecs)
> > printf("%5lu.%09llu: ", secs, nsecs);
> > else
> > - printf("%5lu.%06lu: ", secs, usecs);
> > + printf("%12s: ", timestamp_in_usec(buf, sz,
> > + sample->time));
> > }
> > }
> >
> > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> > index 85c56800f17a..aa3e778989ce 100644
> > --- a/tools/perf/util/util.c
> > +++ b/tools/perf/util/util.c
> > @@ -433,6 +433,15 @@ int parse_nsec_time(const char *str, u64 *ptime)
> > return 0;
> > }
> >
> > +char *timestamp_in_usec(char *buf, size_t sz, u64 timestamp)
> > +{
> > + u64 sec = timestamp / NSEC_PER_SEC;
> > + u64 usec = (timestamp % NSEC_PER_SEC) / NSEC_PER_USEC;
> > +
> > + scnprintf(buf, sz, "%"PRIu64".%06"PRIu64, sec, usec);
> > + return buf;
> > +}
> > +
> > unsigned long parse_tag_value(const char *str, struct parse_tag *tags)
> > {
> > struct parse_tag *i = tags;
> > diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> > index 71b6992f1d98..ece974f1c538 100644
> > --- a/tools/perf/util/util.h
> > +++ b/tools/perf/util/util.h
> > @@ -362,4 +362,7 @@ extern int sched_getcpu(void);
> > #endif
> >
> > int is_printable_array(char *p, unsigned int len);
> > +
> > +char *timestamp_in_usec(char *buf, size_t sz, u64 timestamp);
> > +
> > #endif /* GIT_COMPAT_UTIL_H */
> >
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-28 12:53 ` Arnaldo Carvalho de Melo
@ 2016-10-28 13:30 ` Arnaldo Carvalho de Melo
2016-10-28 14:42 ` [GIT PULL] " Arnaldo Carvalho de Melo
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-28 13:30 UTC (permalink / raw)
To: Joonwoo Park
Cc: Ingo Molnar, linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
> >
> >
> > On 10/27/2016 01:40 PM, Arnaldo Carvalho de Melo wrote:
> > > From: Namhyung Kim <namhyung@kernel.org>
> > >
> > > Joonwoo reported that there's a mismatch between timestamps in script
> > > and sched commands. This was because of difference in printing the
> > > timestamp. Factor out the code and share it so that they can be in
> > > sync. Also I found that sched map has similar problem, fix it too.
> > >
> > > Reported-and-Acked-by: Joonwoo Park <joonwoop@codeaurora.org>
> >
> > Hmm.. I didn't ACK this patch because of bug I commented at
> > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
> >
> > s/work_list->max_lat/work_list->max_lat_at/
>
> Sorry about that, I took the "thanks for taking care of this" as an ack,
> now that I re-read that message I saw your points later on in that
> e-mail.
>
> Since Ingo hasn't pulled this, I'll try fixing it, will check that other
> naming issue,
So, here is how it ended up, it fixes the problem you pointed out and
renames the function to follow the scnprintf() convention, as used
elsewhere in tools/perf (tools/perf/util/annotate.h has several
examples).
commit 99620a5d0cc8e2dd9aedb629a6e81825f0db020e
Author: Namhyung Kim <namhyung@kernel.org>
Date: Mon Oct 24 11:02:45 2016 +0900
perf tools: Introduce timestamp__scnprintf_usec()
Joonwoo reported that there's a mismatch between timestamps in script
and sched commands. This was because of difference in printing the
timestamp. Factor out the code and share it so that they can be in
sync. Also I found that sched map has similar problem, fix it too.
Committer notes:
Fixed the max_lat_at bug introduced by Namhyung's original patch, as
pointed out by Joonwoo, and made it a function following the scnprintf()
model, i.e. returning the number of bytes formatted, and receiving as
the first parameter the object from where the data to the formatting is
obtained, renaming it from:
char *timestamp_in_usec(char *bf, size_t size, u64 timestamp)
to
int timestamp__scnprintf_usec(u64 timestamp, char *bf, size_t size)
Reported-by: Joonwoo Park <joonwoop@codeaurora.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20161024020246.14928-3-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 1f33d15314a5..fb3441211e4b 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1191,6 +1191,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
int i;
int ret;
u64 avg;
+ char max_lat_at[32];
if (!work_list->nb_atoms)
return;
@@ -1212,12 +1213,13 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
printf(" ");
avg = work_list->total_lat / work_list->nb_atoms;
+ timestamp__scnprintf_usec(work_list->max_lat_at, max_lat_at, sizeof(max_lat_at));
- printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n",
+ printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13s s\n",
(double)work_list->total_runtime / NSEC_PER_MSEC,
work_list->nb_atoms, (double)avg / NSEC_PER_MSEC,
(double)work_list->max_lat / NSEC_PER_MSEC,
- (double)work_list->max_lat_at / NSEC_PER_SEC);
+ max_lat_at);
}
static int pid_cmp(struct work_atoms *l, struct work_atoms *r)
@@ -1402,6 +1404,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
int cpus_nr;
bool new_cpu = false;
const char *color = PERF_COLOR_NORMAL;
+ char stimestamp[32];
BUG_ON(this_cpu >= MAX_CPUS || this_cpu < 0);
@@ -1492,7 +1495,8 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
if (sched->map.cpus && !cpu_map__has(sched->map.cpus, this_cpu))
goto out;
- color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
+ timestamp__scnprintf_usec(timestamp, stimestamp, sizeof(stimestamp));
+ color_fprintf(stdout, color, " %12s secs ", stimestamp);
if (new_shortname || (verbose && sched_in->tid)) {
const char *pid_color = color;
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 412fb6e65ac0..e1daff36d070 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -441,7 +441,6 @@ static void print_sample_start(struct perf_sample *sample,
{
struct perf_event_attr *attr = &evsel->attr;
unsigned long secs;
- unsigned long usecs;
unsigned long long nsecs;
if (PRINT_FIELD(COMM)) {
@@ -471,11 +470,14 @@ static void print_sample_start(struct perf_sample *sample,
nsecs = sample->time;
secs = nsecs / NSEC_PER_SEC;
nsecs -= secs * NSEC_PER_SEC;
- usecs = nsecs / NSEC_PER_USEC;
+
if (nanosecs)
printf("%5lu.%09llu: ", secs, nsecs);
- else
- printf("%5lu.%06lu: ", secs, usecs);
+ else {
+ char sample_time[32];
+ timestamp__scnprintf_usec(sample->time, sample_time, sizeof(sample_time));
+ printf("%12s: ", sample_time);
+ }
}
}
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 85c56800f17a..5bbd1f609f1f 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -433,6 +433,14 @@ int parse_nsec_time(const char *str, u64 *ptime)
return 0;
}
+int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz)
+{
+ u64 sec = timestamp / NSEC_PER_SEC;
+ u64 usec = (timestamp % NSEC_PER_SEC) / NSEC_PER_USEC;
+
+ return scnprintf(buf, sz, "%"PRIu64".%06"PRIu64, sec, usec);
+}
+
unsigned long parse_tag_value(const char *str, struct parse_tag *tags)
{
struct parse_tag *i = tags;
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index 71b6992f1d98..79662d67891e 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -362,4 +362,7 @@ extern int sched_getcpu(void);
#endif
int is_printable_array(char *p, unsigned int len);
+
+int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz);
+
#endif /* GIT_COMPAT_UTIL_H */
^ permalink raw reply related [flat|nested] 57+ messages in thread
* [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-28 13:30 ` Arnaldo Carvalho de Melo
@ 2016-10-28 14:42 ` Arnaldo Carvalho de Melo
2016-10-28 17:39 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-28 14:42 UTC (permalink / raw)
To: Ingo Molnar
Cc: Joonwoo Park, linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
> > > Hmm.. I didn't ACK this patch because of bug I commented at
> > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
> > > s/work_list->max_lat/work_list->max_lat_at/
> > Sorry about that, I took the "thanks for taking care of this" as an ack,
> > now that I re-read that message I saw your points later on in that
> > e-mail.
> > Since Ingo hasn't pulled this, I'll try fixing it, will check that other
> > naming issue,
> So, here is how it ended up, it fixes the problem you pointed out and
> renames the function to follow the scnprintf() convention, as used
> elsewhere in tools/perf (tools/perf/util/annotate.h has several
> examples).
Ingo, I've just signed a perf-core-for-mingo-20161028 with the only
change being the patch below, re-run my tests, I think this doesn't
introduce any bugs and addresses Joonwoo's concerns, please consider
pulling.
Thanks,
- Arnaldo
> commit 99620a5d0cc8e2dd9aedb629a6e81825f0db020e
> Author: Namhyung Kim <namhyung@kernel.org>
> Date: Mon Oct 24 11:02:45 2016 +0900
>
> perf tools: Introduce timestamp__scnprintf_usec()
>
> Joonwoo reported that there's a mismatch between timestamps in script
> and sched commands. This was because of difference in printing the
> timestamp. Factor out the code and share it so that they can be in
> sync. Also I found that sched map has similar problem, fix it too.
>
> Committer notes:
>
> Fixed the max_lat_at bug introduced by Namhyung's original patch, as
> pointed out by Joonwoo, and made it a function following the scnprintf()
> model, i.e. returning the number of bytes formatted, and receiving as
> the first parameter the object from where the data to the formatting is
> obtained, renaming it from:
>
> char *timestamp_in_usec(char *bf, size_t size, u64 timestamp)
>
> to
>
> int timestamp__scnprintf_usec(u64 timestamp, char *bf, size_t size)
>
> Reported-by: Joonwoo Park <joonwoop@codeaurora.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Link: http://lkml.kernel.org/r/20161024020246.14928-3-namhyung@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 1f33d15314a5..fb3441211e4b 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1191,6 +1191,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
> int i;
> int ret;
> u64 avg;
> + char max_lat_at[32];
>
> if (!work_list->nb_atoms)
> return;
> @@ -1212,12 +1213,13 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
> printf(" ");
>
> avg = work_list->total_lat / work_list->nb_atoms;
> + timestamp__scnprintf_usec(work_list->max_lat_at, max_lat_at, sizeof(max_lat_at));
>
> - printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n",
> + printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13s s\n",
> (double)work_list->total_runtime / NSEC_PER_MSEC,
> work_list->nb_atoms, (double)avg / NSEC_PER_MSEC,
> (double)work_list->max_lat / NSEC_PER_MSEC,
> - (double)work_list->max_lat_at / NSEC_PER_SEC);
> + max_lat_at);
> }
>
> static int pid_cmp(struct work_atoms *l, struct work_atoms *r)
> @@ -1402,6 +1404,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> int cpus_nr;
> bool new_cpu = false;
> const char *color = PERF_COLOR_NORMAL;
> + char stimestamp[32];
>
> BUG_ON(this_cpu >= MAX_CPUS || this_cpu < 0);
>
> @@ -1492,7 +1495,8 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
> if (sched->map.cpus && !cpu_map__has(sched->map.cpus, this_cpu))
> goto out;
>
> - color_fprintf(stdout, color, " %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
> + timestamp__scnprintf_usec(timestamp, stimestamp, sizeof(stimestamp));
> + color_fprintf(stdout, color, " %12s secs ", stimestamp);
> if (new_shortname || (verbose && sched_in->tid)) {
> const char *pid_color = color;
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 412fb6e65ac0..e1daff36d070 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -441,7 +441,6 @@ static void print_sample_start(struct perf_sample *sample,
> {
> struct perf_event_attr *attr = &evsel->attr;
> unsigned long secs;
> - unsigned long usecs;
> unsigned long long nsecs;
>
> if (PRINT_FIELD(COMM)) {
> @@ -471,11 +470,14 @@ static void print_sample_start(struct perf_sample *sample,
> nsecs = sample->time;
> secs = nsecs / NSEC_PER_SEC;
> nsecs -= secs * NSEC_PER_SEC;
> - usecs = nsecs / NSEC_PER_USEC;
> +
> if (nanosecs)
> printf("%5lu.%09llu: ", secs, nsecs);
> - else
> - printf("%5lu.%06lu: ", secs, usecs);
> + else {
> + char sample_time[32];
> + timestamp__scnprintf_usec(sample->time, sample_time, sizeof(sample_time));
> + printf("%12s: ", sample_time);
> + }
> }
> }
>
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index 85c56800f17a..5bbd1f609f1f 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -433,6 +433,14 @@ int parse_nsec_time(const char *str, u64 *ptime)
> return 0;
> }
>
> +int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz)
> +{
> + u64 sec = timestamp / NSEC_PER_SEC;
> + u64 usec = (timestamp % NSEC_PER_SEC) / NSEC_PER_USEC;
> +
> + return scnprintf(buf, sz, "%"PRIu64".%06"PRIu64, sec, usec);
> +}
> +
> unsigned long parse_tag_value(const char *str, struct parse_tag *tags)
> {
> struct parse_tag *i = tags;
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index 71b6992f1d98..79662d67891e 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -362,4 +362,7 @@ extern int sched_getcpu(void);
> #endif
>
> int is_printable_array(char *p, unsigned int len);
> +
> +int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz);
> +
> #endif /* GIT_COMPAT_UTIL_H */
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-28 14:42 ` [GIT PULL] " Arnaldo Carvalho de Melo
@ 2016-10-28 17:39 ` Ingo Molnar
2016-10-28 17:46 ` Joonwoo Park
0 siblings, 1 reply; 57+ messages in thread
From: Ingo Molnar @ 2016-10-28 17:39 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Joonwoo Park, linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
> > > Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
> > > > Hmm.. I didn't ACK this patch because of bug I commented at
> > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
>
> > > > s/work_list->max_lat/work_list->max_lat_at/
>
> > > Sorry about that, I took the "thanks for taking care of this" as an ack,
> > > now that I re-read that message I saw your points later on in that
> > > e-mail.
>
> > > Since Ingo hasn't pulled this, I'll try fixing it, will check that other
> > > naming issue,
>
> > So, here is how it ended up, it fixes the problem you pointed out and
> > renames the function to follow the scnprintf() convention, as used
> > elsewhere in tools/perf (tools/perf/util/annotate.h has several
> > examples).
>
> Ingo, I've just signed a perf-core-for-mingo-20161028 with the only
> change being the patch below, re-run my tests, I think this doesn't
> introduce any bugs and addresses Joonwoo's concerns, please consider
> pulling.
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()
2016-10-28 17:39 ` Ingo Molnar
@ 2016-10-28 17:46 ` Joonwoo Park
0 siblings, 0 replies; 57+ messages in thread
From: Joonwoo Park @ 2016-10-28 17:46 UTC (permalink / raw)
To: Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
On 10/28/2016 10:39 AM, Ingo Molnar wrote:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
>> Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu:
>>> Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
>>>> Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
>>>>> Hmm.. I didn't ACK this patch because of bug I commented at
>>>>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
>>
>>>>> s/work_list->max_lat/work_list->max_lat_at/
>>
>>>> Sorry about that, I took the "thanks for taking care of this" as an ack,
>>>> now that I re-read that message I saw your points later on in that
>>>> e-mail.
No worries. I think I could be more specific with the first part of
comment by mentioning about the bug.
>>
>>>> Since Ingo hasn't pulled this, I'll try fixing it, will check that other
>>>> naming issue,
>>
>>> So, here is how it ended up, it fixes the problem you pointed out and
>>> renames the function to follow the scnprintf() convention, as used
>>> elsewhere in tools/perf (tools/perf/util/annotate.h has several
>>> examples).
>>
>> Ingo, I've just signed a perf-core-for-mingo-20161028 with the only
>> change being the patch below, re-run my tests, I think this doesn't
>> introduce any bugs and addresses Joonwoo's concerns, please consider
>> pulling.
>
> Pulled, thanks a lot Arnaldo!
Thanks!
Joonwoo
>
> Ingo
>
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2017-08-23 19:35 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-08-23 19:35 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Alexander Shishkin, Andi Kleen, Borislav Petkov, Jiri Olsa,
Konstantin Khlebnikov, Peter Zijlstra, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit ba63f76e22ee723819c8cec86b31f7ea3182b2ed:
Merge tag 'perf-core-for-mingo-4.14-20170821' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-08-22 12:16:39 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170823
for you to fetch changes up to 60913e005c8d19ec5187a638eafdd088509dfb9e:
perf tools: Fix static linking with libunwind (2017-08-22 13:24:55 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Expression parser enhancements for metrics (Andi Kleen)
- Fix buffer overflow while freeing events in 'perf stat' (Andi Kleen)
- Fix static linking with elfutils's libdf and with libunwind
in Debian/Ubuntu (Konstantin Khlebnikov)
- Tighten detection of BPF events, avoiding matching some other PMU
events such as 'cpu/uops_executed.core,cmask=1/' as a .c source
file that ended up being considered a BPF event (Andi Kleen)
- Add Skylake server uncore JSON vendor events (Andi Kleen)
- Add support for printing new mem_info encodings, including
'perf test' checks (Andi Kleen)
- Really install manpages via 'make install-man' (Konstantin Khlebnikov)
- Fix documentation for perf_event_paranoid and perf_event_mlock_kb
sysctls (Konstantin Khlebnikov)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (11):
perf xyarray: Save max_x, max_y
perf evsel: Fix buffer overflow while freeing events
perf bpf: Tighten detection of BPF events
perf tools: Add utility function to detect SMT status
perf tools: Expression parser enhancements for metrics
perf tools: Increase maximum number of events in expressions
perf tools: Dedup events in expression parsing
perf vendor events: Add core event list for Skylake Server
perf vendor events: Add Skylake server uncore event list
perf tools: Add support for printing new mem_info encodings
perf test: Add test cases for new data source encoding
Konstantin Khlebnikov (4):
perf tools: Really install manpages via 'make install-man'
perf: Fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb
perf tools: Fix static linking with libdw from elfutils
perf tools: Fix static linking with libunwind
Documentation/sysctl/kernel.txt | 13 +-
tools/include/uapi/linux/perf_event.h | 30 +-
tools/perf/Documentation/Makefile | 2 +-
tools/perf/Makefile.config | 16 +-
tools/perf/pmu-events/arch/x86/mapfile.csv | 1 +
tools/perf/pmu-events/arch/x86/skylakex/cache.json | 1672 ++++++++++++++++++++
.../arch/x86/skylakex/floating-point.json | 88 ++
.../pmu-events/arch/x86/skylakex/frontend.json | 482 ++++++
.../perf/pmu-events/arch/x86/skylakex/memory.json | 1396 ++++++++++++++++
tools/perf/pmu-events/arch/x86/skylakex/other.json | 72 +
.../pmu-events/arch/x86/skylakex/pipeline.json | 950 +++++++++++
.../arch/x86/skylakex/uncore-memory.json | 172 ++
.../pmu-events/arch/x86/skylakex/uncore-other.json | 1156 ++++++++++++++
.../arch/x86/skylakex/virtual-memory.json | 284 ++++
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/expr.c | 5 +
tools/perf/tests/mem.c | 56 +
tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
tools/perf/tests/openat-syscall.c | 2 +-
tools/perf/tests/tests.h | 1 +
tools/perf/util/Build | 1 +
tools/perf/util/evlist.c | 12 +-
tools/perf/util/evsel.c | 41 +-
tools/perf/util/evsel.h | 7 +-
tools/perf/util/expr.h | 2 +-
tools/perf/util/expr.y | 74 +-
tools/perf/util/mem-events.c | 43 +-
tools/perf/util/parse-events.l | 23 +-
tools/perf/util/smt.c | 44 +
tools/perf/util/smt.h | 6 +
tools/perf/util/xyarray.c | 2 +
tools/perf/util/xyarray.h | 12 +
33 files changed, 6607 insertions(+), 65 deletions(-)
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/cache.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/floating-point.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/frontend.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/memory.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/other.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/pipeline.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/uncore-memory.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/virtual-memory.json
create mode 100644 tools/perf/tests/mem.c
create mode 100644 tools/perf/util/smt.c
create mode 100644 tools/perf/util/smt.h
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf
commands with a variety of command line event specifications to then
intercept the sys_perf_event syscall to check that the perf_event_attr
fields are set up as expected, among a variety of other unit tests.
The 'perf test' also runs shell scripts exercising the tools, checking
if they affect the system in certain ways, like setting up kprobes and
uprobes, request callchains for well known programs and check that they
are the expected ones, see if 'perf trace' beautifies system call
arguments correctly, etc.
Additionally, a new set of tests, script based, runs the tools in a live system,
setting probes in place that then gets used by 'perf trace', with its output
compared against expected results.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: Ok
27 mageia:5: Ok
28 opensuse:13.2: Ok
29 opensuse:42.1: Ok
30 opensuse:42.2: Ok
31 opensuse:tumbleweed: Ok
32 oraclelinux:6: Ok
33 oraclelinux:7: Ok
34 ubuntu:12.04.5: Ok
35 ubuntu:14.04.4: Ok
36 ubuntu:14.04.4-x-linaro-arm64: Ok
37 ubuntu:15.10: Ok
38 ubuntu:16.04: Ok
39 ubuntu:16.04-x-arm: Ok
40 ubuntu:16.04-x-arm64: Ok
41 ubuntu:16.04-x-powerpc: Ok
42 ubuntu:16.04-x-powerpc64: Ok
43 ubuntu:16.04-x-powerpc64el: Ok
44 ubuntu:16.04-x-s390: Ok
45 ubuntu:16.10: Ok
46 ubuntu:17.04: Ok
47 ubuntu:17.10: Ok
#
# uname -a
Linux jouet 4.13.0-rc4+ #2 SMP Fri Aug 11 12:39:09 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Intel cqm nmi context read : Skip
61: Use vfs_getname probe to get syscall args filenames : Ok
62: probe libc's inet_pton & backtrace it with ping : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_pure_O: make
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_tags_O: make tags
make_util_map_o_O: make util/map.o
make_no_libunwind_O: make NO_LIBUNWIND=1
make_clean_all_O: make clean all
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_perf_o_O: make perf.o
make_help_O: make help
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libperl_O: make NO_LIBPERL=1
make_doc_O: make doc
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_install_O: make install
make_no_newt_O: make NO_NEWT=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_bin_O: make install-bin
make_install_prefix_O: make install prefix=/tmp/krava
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_gtk2_O: make NO_GTK2=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libelf_O: make NO_LIBELF=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_debug_O: make DEBUG=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_slang_O: make NO_SLANG=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2017-07-28 20:00 Arnaldo Carvalho de Melo
@ 2017-07-30 9:31 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2017-07-30 9:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Andi Kleen, David Ahern,
David Carrillo-Cisneros, Francis Deslauriers,
Geneviève Bastien, Jiri Olsa, Julien Desfossez,
Martin Liška, Mathieu Desnoyers, Milian Wolff, Namhyung Kim,
Paul Turner, Peter Zijlstra, Simon Que, Stephane Eranian,
Taeung Song, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit ee438ec8f33c5af0d4a4ffb935c5b9272e8c2680:
>
> Merge tag 'perf-core-for-mingo-4.14-20170725' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-07-26 19:07:30 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170728
>
> for you to fetch changes up to 6b7007af728df7258bb60ed73099be3b59b3030e:
>
> perf data: Add doc when no conversion support compiled (2017-07-28 16:30:45 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes for 4.14:
>
> New features:
>
> - Add PERF_SAMPLE_CALLCHAIN and PERF_RECORD_MMAP[2] to 'perf data' CTF
> conversion, allowing CTF trace visualization tools to show callchains
> and to resolve symbols (Geneviève Bastien)
>
> Improvements:
>
> - Use group read for event groups in 'perf stat', reducing overhead when
> groups are defined in the event specification, i.e. when using {} to
> enclose a list of events, asking them to be read at the same time,
> e.g.: "perf stat -e '{cycles,instructions}'" (Jiri Olsa)
>
> Fixes:
>
> - Do not overwrite perf_sample->weight in 'perf annotate' when
> processing samples, use whatever came from the kernel when
> perf_event_attr.sample_type has PERF_SAMPLE_WEIGHT set or just handle
> its default value, 0, when that is not set and "weight" is one of the
> sort orders chosen (Arnaldo Carvalho de Melo)
>
> - 'perf annotate --show-total-period' fixes:
> - TUI should show period, not nr_samples
> - Set appropriate column width for period/percent
> - Fix the column header to show "Period" when when that is what
> is being asked for
> (Taeung Song, Arnaldo Carvalho de Melo)
>
> - Use default sort if evlist is empty, fixing pipe mode (David Carrillo-Cisneros)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (6):
> perf annotate: Do not overwrite perf_sample->weight
> perf annotate stdio: Set enough columns for --show-total-period
> perf annotate: Fix storing per line sym_hist_entry
> perf annotate TUI: Use sym_hist_entry in disasm_line_samples
> perf annotate TUI: Clarify calculation of column header widths
> perf annotate TUI: Set appropriate column width for period/percent
>
> David Carrillo-Cisneros (1):
> perf sort: Use default sort if evlist is empty
>
> Geneviève Bastien (3):
> perf data: Add callchain to CTF conversion
> perf data: Add mmap[2] events to CTF conversion
> perf data: Add doc when no conversion support compiled
>
> Jiri Olsa (3):
> perf tools: Add perf_evsel__read_size function
> perf evsel: Add read_counter()
> perf stat: Use group read for event groups
>
> Taeung Song (2):
> perf annotate TUI: Fix --show-total-period
> perf annotate TUI: Fix column header when toggling period/percent
>
> tools/perf/builtin-annotate.c | 2 -
> tools/perf/builtin-data.c | 2 +-
> tools/perf/builtin-stat.c | 30 +++++++-
> tools/perf/ui/browsers/annotate.c | 36 +++++-----
> tools/perf/util/annotate.c | 11 +--
> tools/perf/util/counts.h | 1 +
> tools/perf/util/data-convert-bt.c | 127 +++++++++++++++++++++++++++++++++-
> tools/perf/util/evlist.h | 5 ++
> tools/perf/util/evsel.c | 139 +++++++++++++++++++++++++++++++++++++-
> tools/perf/util/evsel.h | 2 +
> tools/perf/util/sort.c | 2 +-
> tools/perf/util/stat.c | 4 ++
> tools/perf/util/stat.h | 5 +-
> 13 files changed, 334 insertions(+), 32 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2017-07-28 20:00 Arnaldo Carvalho de Melo
2017-07-30 9:31 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-07-28 20:00 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Andi Kleen, David Ahern,
David Carrillo-Cisneros, Francis Deslauriers,
Geneviève Bastien, Jiri Olsa, Julien Desfossez,
Martin Liška, Mathieu Desnoyers, Milian Wolff, Namhyung Kim,
Paul Turner, Peter Zijlstra, Simon Que, Stephane Eranian,
Taeung Song, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit ee438ec8f33c5af0d4a4ffb935c5b9272e8c2680:
Merge tag 'perf-core-for-mingo-4.14-20170725' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-07-26 19:07:30 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170728
for you to fetch changes up to 6b7007af728df7258bb60ed73099be3b59b3030e:
perf data: Add doc when no conversion support compiled (2017-07-28 16:30:45 -0300)
----------------------------------------------------------------
perf/core improvements and fixes for 4.14:
New features:
- Add PERF_SAMPLE_CALLCHAIN and PERF_RECORD_MMAP[2] to 'perf data' CTF
conversion, allowing CTF trace visualization tools to show callchains
and to resolve symbols (Geneviève Bastien)
Improvements:
- Use group read for event groups in 'perf stat', reducing overhead when
groups are defined in the event specification, i.e. when using {} to
enclose a list of events, asking them to be read at the same time,
e.g.: "perf stat -e '{cycles,instructions}'" (Jiri Olsa)
Fixes:
- Do not overwrite perf_sample->weight in 'perf annotate' when
processing samples, use whatever came from the kernel when
perf_event_attr.sample_type has PERF_SAMPLE_WEIGHT set or just handle
its default value, 0, when that is not set and "weight" is one of the
sort orders chosen (Arnaldo Carvalho de Melo)
- 'perf annotate --show-total-period' fixes:
- TUI should show period, not nr_samples
- Set appropriate column width for period/percent
- Fix the column header to show "Period" when when that is what
is being asked for
(Taeung Song, Arnaldo Carvalho de Melo)
- Use default sort if evlist is empty, fixing pipe mode (David Carrillo-Cisneros)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (6):
perf annotate: Do not overwrite perf_sample->weight
perf annotate stdio: Set enough columns for --show-total-period
perf annotate: Fix storing per line sym_hist_entry
perf annotate TUI: Use sym_hist_entry in disasm_line_samples
perf annotate TUI: Clarify calculation of column header widths
perf annotate TUI: Set appropriate column width for period/percent
David Carrillo-Cisneros (1):
perf sort: Use default sort if evlist is empty
Geneviève Bastien (3):
perf data: Add callchain to CTF conversion
perf data: Add mmap[2] events to CTF conversion
perf data: Add doc when no conversion support compiled
Jiri Olsa (3):
perf tools: Add perf_evsel__read_size function
perf evsel: Add read_counter()
perf stat: Use group read for event groups
Taeung Song (2):
perf annotate TUI: Fix --show-total-period
perf annotate TUI: Fix column header when toggling period/percent
tools/perf/builtin-annotate.c | 2 -
tools/perf/builtin-data.c | 2 +-
tools/perf/builtin-stat.c | 30 +++++++-
tools/perf/ui/browsers/annotate.c | 36 +++++-----
tools/perf/util/annotate.c | 11 +--
tools/perf/util/counts.h | 1 +
tools/perf/util/data-convert-bt.c | 127 +++++++++++++++++++++++++++++++++-
tools/perf/util/evlist.h | 5 ++
tools/perf/util/evsel.c | 139 +++++++++++++++++++++++++++++++++++++-
tools/perf/util/evsel.h | 2 +
tools/perf/util/sort.c | 2 +-
tools/perf/util/stat.c | 4 ++
tools/perf/util/stat.h | 5 +-
13 files changed, 334 insertions(+), 32 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# uname -a
Linux jouet 4.12.0-rc6+ #3 SMP Tue Jun 27 15:12:38 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking: Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation: Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Ok
38.2: BPF pinning : Ok
38.3: BPF prologue generation : Ok
38.4: BPF relocation checker : Ok
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : Ok
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
#
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: FAIL
27 mageia:5: Ok
28 opensuse:13.2: Ok
29 opensuse:42.1: Ok
30 opensuse:42.2: Ok
31 opensuse:tumbleweed: Ok
32 oraclelinux:6: Ok
33 oraclelinux:7: Ok
34 ubuntu:12.04.5: Ok
35 ubuntu:14.04.4: Ok
36 ubuntu:14.04.4-x-linaro-arm64: Ok
37 ubuntu:15.10: Ok
38 ubuntu:16.04: Ok
39 ubuntu:16.04-x-arm: Ok
40 ubuntu:16.04-x-arm64: Ok
41 ubuntu:16.04-x-powerpc: Ok
42 ubuntu:16.04-x-powerpc64: Ok
43 ubuntu:16.04-x-powerpc64el: Ok
44 ubuntu:16.04-x-s390: Ok
45 ubuntu:16.10: Ok
46 ubuntu:17.04: Ok
47 ubuntu:17.10: Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_prefix_O: make install prefix=/tmp/krava
make_static_O: make LDFLAGS=-static
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_libelf_O: make NO_LIBELF=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_install_bin_O: make install-bin
make_no_backtrace_O: make NO_BACKTRACE=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_gtk2_O: make NO_GTK2=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_util_map_o_O: make util/map.o
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_slang_O: make NO_SLANG=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_perf_o_O: make perf.o
make_help_O: make help
make_no_libpython_O: make NO_LIBPYTHON=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_debug_O: make DEBUG=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_pure_O: make
make_no_demangle_O: make NO_DEMANGLE=1
make_no_newt_O: make NO_NEWT=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_clean_all_O: make clean all
make_doc_O: make doc
make_no_libaudit_O: make NO_LIBAUDIT=1
make_tags_O: make tags
make_install_O: make install
make_no_libbpf_O: make NO_LIBBPF=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2017-02-14 1:13 Arnaldo Carvalho de Melo
@ 2017-02-14 6:31 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2017-02-14 6:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Clark Williams,
Daniel Borkmann, David Ahern, David S . Miller, Jiri Olsa,
Joe Perches, Joe Stringer, Mickaël Salaün,
Namhyung Kim, netdev, Peter Zijlstra, Steven Rostedt,
Taeung Song, Wang Nan, Wang YanQing, linux-perf-users,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit f2029b1e47b607619d1dd2cb0bbb77f64ec6b7c2:
>
> perf/x86/intel: Add Kaby Lake support (2017-02-11 21:28:23 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.11-20170213
>
> for you to fetch changes up to a734fb5d60067a73dd7099a58756847c07f9cd68:
>
> samples/bpf: Reset global variables (2017-02-13 17:22:53 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New feature:
>
> - Introduce the 'delta-abs' 'perf diff' compute method, that orders the
> histogram entries by the absolute value of the percentage delta for a
> function in two perf.data files, i.e. the functions that changed the
> most (increase or decrease in samples) comes first (Namhyung Kim)
>
> User visible:
>
> - Improve message about tweaking the kernel.perf_event_paranoid setting,
> telling how to make the change permanent by editing /etc/sysctl.conf
> (Ingo Molnar)
>
> Infrastructure:
>
> - Introduce linux/compiler-gcc.h as a counterpart to the kernel's,
> initially containing the definition of __fallthrough, more to
> come (__maybe_unused, etc) (Arnaldo Carvalho de Melo)
>
> - Fixes for problems uncovered by building tools/perf with clang, such
> as always true tests of arrays against NULL and variables that sometimes
> were used without being initialized (Arnaldo Carvalho de Melo, Steven Rostedt)
>
> - Before loading a new ELF, clear global variables set by the
> samples/bpf loader (Mickaël Salaün)
>
> - Ignore already processed ELF sections in the samples/bpf
> loader (Mickaël Salaün)
>
> - Fix compile error in the scripting code with some perl5
> versions (Wang YanQing)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (6):
> tools include: Introduce linux/compiler-gcc.h
> tools lib traceevent plugin function: Initialize 'index' variable
> perf evsel: Inform how to make a sysctl setting permanent
> perf symbols: No need to check if sym->name is NULL
> perf tests record: No need to test an array against NULL
> perf symbols: dso->name is an array, no need to check it against NULL
>
> Mickaël Salaün (3):
> samples/bpf: Add missing header
> samples/bpf: Ignore already processed ELF sections
> samples/bpf: Reset global variables
>
> Namhyung Kim (4):
> perf diff: Add 'delta-abs' compute method
> perf diff: Add diff.order config option
> perf diff: Add diff.compute config option
> perf diff: Change default setting to "delta-abs"
>
> Steven Rostedt (VMware) (1):
> tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP
>
> Wang YanQing (1):
> perf scripting perl: Fix compile error with some perl5 versions
>
> samples/bpf/bpf_load.c | 7 ++
> samples/bpf/tracex5_kern.c | 1 +
> tools/include/linux/compiler-gcc.h | 14 ++++
> tools/include/linux/compiler.h | 10 +--
> tools/lib/traceevent/kbuffer-parse.c | 1 +
> tools/lib/traceevent/plugin_function.c | 2 +-
> tools/perf/Documentation/perf-config.txt | 12 ++++
> tools/perf/Documentation/perf-diff.txt | 15 ++++-
> tools/perf/MANIFEST | 1 +
> tools/perf/builtin-diff.c | 78 ++++++++++++++++++++--
> tools/perf/builtin-kmem.c | 4 +-
> tools/perf/builtin-record.c | 2 +-
> tools/perf/builtin-sched.c | 2 +-
> tools/perf/builtin-stat.c | 2 +-
> tools/perf/builtin-top.c | 2 +-
> tools/perf/tests/perf-record.c | 2 +-
> tools/perf/util/evsel.c | 4 +-
> tools/perf/util/evsel_fprintf.c | 1 -
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/map.c | 4 +-
> tools/perf/util/scripting-engines/Build | 2 +-
> .../perf/util/scripting-engines/trace-event-perl.c | 4 +-
> tools/perf/util/symbol_fprintf.c | 2 +-
> 23 files changed, 145 insertions(+), 29 deletions(-)
> create mode 100644 tools/include/linux/compiler-gcc.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2017-02-14 1:13 Arnaldo Carvalho de Melo
2017-02-14 6:31 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-02-14 1:13 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Clark Williams, Daniel Borkmann, David Ahern,
David S . Miller, Jiri Olsa, Joe Perches, Joe Stringer,
Mickaël Salaün, Namhyung Kim, netdev, Peter Zijlstra,
Steven Rostedt, Taeung Song, Wang Nan, Wang YanQing,
linux-perf-users, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit f2029b1e47b607619d1dd2cb0bbb77f64ec6b7c2:
perf/x86/intel: Add Kaby Lake support (2017-02-11 21:28:23 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.11-20170213
for you to fetch changes up to a734fb5d60067a73dd7099a58756847c07f9cd68:
samples/bpf: Reset global variables (2017-02-13 17:22:53 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New feature:
- Introduce the 'delta-abs' 'perf diff' compute method, that orders the
histogram entries by the absolute value of the percentage delta for a
function in two perf.data files, i.e. the functions that changed the
most (increase or decrease in samples) comes first (Namhyung Kim)
User visible:
- Improve message about tweaking the kernel.perf_event_paranoid setting,
telling how to make the change permanent by editing /etc/sysctl.conf
(Ingo Molnar)
Infrastructure:
- Introduce linux/compiler-gcc.h as a counterpart to the kernel's,
initially containing the definition of __fallthrough, more to
come (__maybe_unused, etc) (Arnaldo Carvalho de Melo)
- Fixes for problems uncovered by building tools/perf with clang, such
as always true tests of arrays against NULL and variables that sometimes
were used without being initialized (Arnaldo Carvalho de Melo, Steven Rostedt)
- Before loading a new ELF, clear global variables set by the
samples/bpf loader (Mickaël Salaün)
- Ignore already processed ELF sections in the samples/bpf
loader (Mickaël Salaün)
- Fix compile error in the scripting code with some perl5
versions (Wang YanQing)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (6):
tools include: Introduce linux/compiler-gcc.h
tools lib traceevent plugin function: Initialize 'index' variable
perf evsel: Inform how to make a sysctl setting permanent
perf symbols: No need to check if sym->name is NULL
perf tests record: No need to test an array against NULL
perf symbols: dso->name is an array, no need to check it against NULL
Mickaël Salaün (3):
samples/bpf: Add missing header
samples/bpf: Ignore already processed ELF sections
samples/bpf: Reset global variables
Namhyung Kim (4):
perf diff: Add 'delta-abs' compute method
perf diff: Add diff.order config option
perf diff: Add diff.compute config option
perf diff: Change default setting to "delta-abs"
Steven Rostedt (VMware) (1):
tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP
Wang YanQing (1):
perf scripting perl: Fix compile error with some perl5 versions
samples/bpf/bpf_load.c | 7 ++
samples/bpf/tracex5_kern.c | 1 +
tools/include/linux/compiler-gcc.h | 14 ++++
tools/include/linux/compiler.h | 10 +--
tools/lib/traceevent/kbuffer-parse.c | 1 +
tools/lib/traceevent/plugin_function.c | 2 +-
tools/perf/Documentation/perf-config.txt | 12 ++++
tools/perf/Documentation/perf-diff.txt | 15 ++++-
tools/perf/MANIFEST | 1 +
tools/perf/builtin-diff.c | 78 ++++++++++++++++++++--
tools/perf/builtin-kmem.c | 4 +-
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-sched.c | 2 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/tests/perf-record.c | 2 +-
tools/perf/util/evsel.c | 4 +-
tools/perf/util/evsel_fprintf.c | 1 -
tools/perf/util/machine.c | 2 +-
tools/perf/util/map.c | 4 +-
tools/perf/util/scripting-engines/Build | 2 +-
.../perf/util/scripting-engines/trace-event-perl.c | 4 +-
tools/perf/util/symbol_fprintf.c | 2 +-
23 files changed, 145 insertions(+), 29 deletions(-)
create mode 100644 tools/include/linux/compiler-gcc.h
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# time dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 debian:experimental-x-arm64: Ok
11 debian:experimental-x-mips: Ok
12 debian:experimental-x-mips64: Ok
13 debian:experimental-x-mipsel: Ok
14 fedora:20: Ok
15 fedora:21: Ok
16 fedora:22: Ok
17 fedora:23: Ok
18 fedora:24: Ok
19 fedora:24-x-ARC-uClibc: Ok
20 fedora:25: Ok
21 fedora:rawhide: Ok
22 mageia:5: Ok
23 opensuse:13.2: Ok
24 opensuse:42.1: Ok
25 opensuse:tumbleweed: Ok
26 ubuntu:12.04.5: Ok
27 ubuntu:14.04.4-x-linaro-arm64: Ok
28 ubuntu:15.10: Ok
29 ubuntu:16.04: Ok
30 ubuntu:16.04-x-arm: Ok
31 ubuntu:16.04-x-arm64: Ok
32 ubuntu:16.04-x-powerpc: Ok
33 ubuntu:16.04-x-powerpc64: Ok
34 ubuntu:16.04-x-powerpc64el: Ok
35 ubuntu:16.04-x-s390: Ok
36 ubuntu:16.10: Ok
#
# uname -a
Linux jouet 4.9.8-201.fc25.x86_64 #1 SMP Tue Feb 7 11:28:07 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: PERF_RECORD_* events & perf_sample fields : Ok
7: Parse perf pmu format : Ok
8: DSO data read : Ok
9: DSO data cache : Ok
10: DSO data reopen : Ok
11: Roundtrip evsel->name : Ok
12: Parse sched tracepoints fields : Ok
13: syscalls:sys_enter_openat event fields : Ok
14: Setup struct perf_event_attr : Ok
15: Match and link multiple hists : Ok
16: 'import perf' in python : Ok
17: Breakpoint overflow signal handler : Ok
18: Breakpoint overflow sampling : Ok
19: Number of exit events of a simple workload : Ok
20: Software clock events period values : Ok
21: Object code reading : Ok
22: Sample parsing : Ok
23: Use a dummy software event to keep tracking: Ok
24: Parse with no sample_id_all bit set : Ok
25: Filter hist entries : Ok
26: Lookup mmap thread : Ok
27: Share thread mg : Ok
28: Sort output of hist entries : Ok
29: Cumulate child hist entries : Ok
30: Track with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: kmod_path__parse : Ok
34: Thread map : Ok
35: LLVM search and compile :
35.1: Basic BPF llvm compile : Ok
35.2: kbuild searching : Ok
35.3: Compile source for BPF prologue generation: Ok
35.4: Compile source for BPF relocation : Ok
36: Session topology : Ok
37: BPF filter :
37.1: Basic BPF filtering : Ok
37.2: BPF pinning : Ok
37.3: BPF prologue generation : Ok
37.4: BPF relocation checker : Ok
38: Synthesize thread map : Ok
39: Remove thread map : Ok
40: Synthesize cpu map : Ok
41: Synthesize stat config : Ok
42: Synthesize stat : Ok
43: Synthesize stat round : Ok
44: Synthesize attr update : Ok
45: Event times : Ok
46: Read backward ring buffer : Ok
47: Print cpu map : Ok
48: Probe SDT events : Ok
49: is_printable_array : Ok
50: Print bitmap : Ok
51: perf hooks : Ok
52: builtin clang support : Skip (not compiled in)
53: unit_number__scnprintf : Ok
54: x86 rdpmc : Ok
55: Convert perf time to TSC : Ok
56: DWARF unwind : Ok
57: x86 instruction decoder - new instructions : Ok
58: Intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_install_O: make install
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_newt_O: make NO_NEWT=1
make_no_slang_O: make NO_SLANG=1
make_static_O: make LDFLAGS=-static
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_clean_all_O: make clean all
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_libnuma_O: make NO_LIBNUMA=1
make_tags_O: make tags
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_perf_o_O: make perf.o
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_help_O: make help
make_with_babeltrace_O: make LIBBABELTRACE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_debug_O: make DEBUG=1
make_no_libbpf_O: make NO_LIBBPF=1
make_util_map_o_O: make util/map.o
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_doc_O: make doc
make_no_libelf_O: make NO_LIBELF=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_install_bin_O: make install-bin
make_no_demangle_O: make NO_DEMANGLE=1
make_pure_O: make
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2016-11-15 1:38 Arnaldo Carvalho de Melo
@ 2016-11-15 8:47 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2016-11-15 8:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, David Ahern, He Kuang, Jiri Olsa, Kan Liang,
Nambong Ha, Namhyung Kim, Peter Zijlstra, Rabin Vincent,
Stephane Eranian, Taeung Song, Wang Nan, William Cohen,
Wookje Kwon, Yao Jin
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end.
>
> The following changes since commit 91a79e5fa696fa626bfbd47f827eaf3eb7d76dc5:
>
> Merge tag 'perf-core-for-mingo-20161028' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-10-28 19:37:34 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161114
>
> for you to fetch changes up to fef51ecd1056b5e090c9fb73e0833bd751389572:
>
> perf report: Show branch info in callchain entry for browser mode (2016-11-14 13:34:08 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Allow querying and setting .perfconfig variables (Taeung Song)
>
> - Show branch information in callchains (predicted, TSX aborts, loop
> iteractions, etc) (Jin Yao)
>
> Infrastructure:
>
> - Support kbuild's CFLAGS_REMOVE_ in tools/build (Jiri Olsa)
>
> - Plug building jvmti to the main perf Makefile (Jiri Olsa)
>
> Documentation:
>
> - Update Intel PT documentation about context switch events (Arnaldo Carvalho de Melo)
>
> - Fix 'perf record --call-graph dwarf' help/config in builds not linking
> with a unwind library, mentioning that is a possible record option (Rabin Vincent)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf intel-pt: Update documentation about context switch events
>
> Jin Yao (5):
> perf report: Add branch flag to callchain cursor node
> perf report: Create a symbol_conf flag for showing branch flag counting
> perf report: Calculate and return the branch flag counting
> perf report: Show branch info in callchain entry for stdio mode
> perf report: Show branch info in callchain entry for browser mode
>
> Jiri Olsa (4):
> tools build: Add CFLAGS_REMOVE_* support
> tools build: Add jvmti feature detection support
> perf jvmti: Plug compilation into perf build
> perf kvmti: Remove unused Makefile file
>
> Rabin Vincent (1):
> perf callchain: Fixup help/config for no-unwinding
>
> Taeung Song (4):
> perf config: Add support for getting config key-value pairs
> perf config: Validate config variable arguments before trying use them
> perf config: Add support setting variables in a config file
> perf config: Mark where are config items from (user or system)
>
> tools/build/Build.include | 4 +-
> tools/build/Documentation/Build.txt | 6 +-
> tools/build/feature/Makefile | 6 +-
> tools/build/feature/test-jvmti.c | 13 ++
> tools/perf/Documentation/intel-pt.txt | 19 ++-
> tools/perf/Documentation/perf-config.txt | 35 ++++++
> tools/perf/Makefile.config | 26 ++++
> tools/perf/Makefile.perf | 24 +++-
> tools/perf/builtin-config.c | 137 ++++++++++++++++++++-
> tools/perf/builtin-report.c | 3 +
> tools/perf/jvmti/Build | 8 ++
> tools/perf/jvmti/Makefile | 89 --------------
> tools/perf/tests/make | 2 +-
> tools/perf/ui/browsers/hists.c | 20 ++-
> tools/perf/ui/stdio/hist.c | 35 +++++-
> tools/perf/util/callchain.c | 205 ++++++++++++++++++++++++++++++-
> tools/perf/util/callchain.h | 26 +++-
> tools/perf/util/config.c | 20 +++
> tools/perf/util/config.h | 4 +
> tools/perf/util/machine.c | 82 ++++++++++---
> tools/perf/util/symbol.h | 1 +
> 21 files changed, 634 insertions(+), 131 deletions(-)
> create mode 100644 tools/build/feature/test-jvmti.c
> create mode 100644 tools/perf/jvmti/Build
> delete mode 100644 tools/perf/jvmti/Makefile
>
> [root@jouet ~]# perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: detect openat syscall event : Ok
> 3: detect openat syscall event on all cpus : Ok
> 4: read samples using the mmap interface : Ok
> 5: parse events tests : Ok
> 6: Validate PERF_RECORD_* events & perf_sample fields : Ok
> 7: Test perf pmu format parsing : Ok
> 8: Test dso data read : Ok
> 9: Test dso data cache : Ok
> 10: Test dso data reopen : Ok
> 11: roundtrip evsel->name check : Ok
> 12: Check parsing of sched tracepoints fields : Ok
> 13: Generate and check syscalls:sys_enter_openat event fields: Ok
> 14: struct perf_event_attr setup : Ok
> 15: Test matching and linking multiple hists : Ok
> 16: Try 'import perf' in python, checking link problems : Ok
> 17: Test breakpoint overflow signal handler : Ok
> 18: Test breakpoint overflow sampling : Ok
> 19: Test number of exit event of a simple workload : Ok
> 20: Test software clock events have valid period values : Ok
> 21: Test object code reading : Ok
> 22: Test sample parsing : Ok
> 23: Test using a dummy software event to keep tracking : Ok
> 24: Test parsing with no sample_id_all bit set : Ok
> 25: Test filtering hist entries : Ok
> 26: Test mmap thread lookup : Ok
> 27: Test thread mg sharing : Ok
> 28: Test output sorting of hist entries : Ok
> 29: Test cumulation of child hist entries : Ok
> 30: Test tracking with sched_switch : Ok
> 31: Filter fds with revents mask in a fdarray : Ok
> 32: Add fd to a fdarray, making it autogrow : Ok
> 33: Test kmod_path__parse function : Ok
> 34: Test thread map : Ok
> 35: Test LLVM searching and compiling :
> 35.1: Basic BPF llvm compiling test : Ok
> 35.2: Test kbuild searching : Ok
> 35.3: Compile source for BPF prologue generation test : Ok
> 35.4: Compile source for BPF relocation test : Ok
> 36: Test topology in session : Ok
> 37: Test BPF filter :
> 37.1: Test basic BPF filtering : Ok
> 37.2: Test BPF prologue generation : Ok
> 37.3: Test BPF relocation checker : Ok
> 38: Test thread map synthesize : Ok
> 39: Test cpu map synthesize : Ok
> 40: Test stat config synthesize : Ok
> 41: Test stat synthesize : Ok
> 42: Test stat round synthesize : Ok
> 43: Test attr update synthesize : Ok
> 44: Test events times : Ok
> 45: Test backward reading from ring buffer : Ok
> 46: Test cpu map print : Ok
> 47: Test SDT event probing : Ok
> 48: Test is_printable_array function : Ok
> 49: Test bitmap print : Ok
> 50: x86 rdpmc test : Ok
> 51: Test converting perf time to TSC : Ok
> 52: Test dwarf unwind : Ok
> 53: Test x86 instruction decoder - new instructions : Ok
> 54: Test intel cqm nmi context read : Skip
> [root@jouet ~]#
>
> [root@zoo ~]# time dm
> 1 alpine:3.4: Ok
> 2 android-ndk:r12b-arm: Ok
> 3 archlinux:latest: Ok
> 4 centos:5: Ok
> 5 centos:6: Ok
> 6 centos:7: Ok
> 7 debian:7: Ok
> 8 debian:8: Ok
> 9 debian:experimental: Ok
> 10 fedora:20: Ok
> 11 fedora:21: Ok
> 12 fedora:22: Ok
> 13 fedora:23: Ok
> 14 fedora:24: Ok
> 15 fedora:24-x-ARC-uClibc: Ok
> 16 fedora:rawhide: Ok
> 17 mageia:5: Ok
> 18 opensuse:13.2: Ok
> 19 opensuse:42.1: Ok
> 20 opensuse:tumbleweed: Ok
> 21 ubuntu:12.04.5: Ok
> 22 ubuntu:14.04: Ok
> 23 ubuntu:14.04.4: Ok
> 24 ubuntu:15.10: Ok
> 25 ubuntu:16.04: Ok
> 26 ubuntu:16.04-x-arm: Ok
> 27 ubuntu:16.04-x-arm64: Ok
> 28 ubuntu:16.04-x-powerpc: Ok
> 29 ubuntu:16.04-x-powerpc64: Ok
> 30 ubuntu:16.04-x-powerpc64el: Ok
> 31 ubuntu:16.04-x-s390: Ok
> 32 ubuntu:16.10: Ok
>
> real 61m29.498s
> user 0m3.969s
> sys 0m3.525s
> [root@zoo ~]#
>
> [acme@jouet linux]$ perf stat make -C tools/perf build-test
> make: Entering directory '/home/acme/git/linux/tools/perf'
> - tarpkg: ./tests/perf-targz-src-pkg .
> make_no_libbionic_O: make NO_LIBBIONIC=1
> make_no_libbpf_O: make NO_LIBBPF=1
> make_no_libunwind_O: make NO_LIBUNWIND=1
> make_install_O: make install
> make_no_libaudit_O: make NO_LIBAUDIT=1
> make_no_libperl_O: make NO_LIBPERL=1
> make_install_prefix_slash_O: make install prefix=/tmp/krava/
> make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
> make_clean_all_O: make clean all
> make_debug_O: make DEBUG=1
> make_no_newt_O: make NO_NEWT=1
> make_perf_o_O: make perf.o
> make_no_demangle_O: make NO_DEMANGLE=1
> make_doc_O: make doc
> make_install_bin_O: make install-bin
> make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
> make_install_prefix_O: make install prefix=/tmp/krava
> make_no_slang_O: make NO_SLANG=1
> make_no_libelf_O: make NO_LIBELF=1
> make_static_O: make LDFLAGS=-static
> make_util_map_o_O: make util/map.o
> make_with_babeltrace_O: make LIBBABELTRACE=1
> make_no_auxtrace_O: make NO_AUXTRACE=1
> make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
> make_no_libnuma_O: make NO_LIBNUMA=1
> make_pure_O: make
> make_help_O: make help
> make_no_gtk2_O: make NO_GTK2=1
> make_no_libpython_O: make NO_LIBPYTHON=1
> make_no_backtrace_O: make NO_BACKTRACE=1
> make_tags_O: make tags
> make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
> make_util_pmu_bison_o_O: make util/pmu-bison.o
> OK
> make: Leaving directory '/home/acme/git/linux/tools/perf'
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-11-15 1:38 Arnaldo Carvalho de Melo
2016-11-15 8:47 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-11-15 1:38 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Arnaldo Carvalho de Melo,
Adrian Hunter, Andi Kleen, David Ahern, He Kuang, Jiri Olsa,
Kan Liang, Linux-kernel, Nambong Ha, Namhyung Kim,
Peter Zijlstra, Rabin Vincent, Stephane Eranian, Taeung Song,
Wang Nan, William Cohen, Wookje Kwon, Yao Jin
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end.
The following changes since commit 91a79e5fa696fa626bfbd47f827eaf3eb7d76dc5:
Merge tag 'perf-core-for-mingo-20161028' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-10-28 19:37:34 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161114
for you to fetch changes up to fef51ecd1056b5e090c9fb73e0833bd751389572:
perf report: Show branch info in callchain entry for browser mode (2016-11-14 13:34:08 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Allow querying and setting .perfconfig variables (Taeung Song)
- Show branch information in callchains (predicted, TSX aborts, loop
iteractions, etc) (Jin Yao)
Infrastructure:
- Support kbuild's CFLAGS_REMOVE_ in tools/build (Jiri Olsa)
- Plug building jvmti to the main perf Makefile (Jiri Olsa)
Documentation:
- Update Intel PT documentation about context switch events (Arnaldo Carvalho de Melo)
- Fix 'perf record --call-graph dwarf' help/config in builds not linking
with a unwind library, mentioning that is a possible record option (Rabin Vincent)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf intel-pt: Update documentation about context switch events
Jin Yao (5):
perf report: Add branch flag to callchain cursor node
perf report: Create a symbol_conf flag for showing branch flag counting
perf report: Calculate and return the branch flag counting
perf report: Show branch info in callchain entry for stdio mode
perf report: Show branch info in callchain entry for browser mode
Jiri Olsa (4):
tools build: Add CFLAGS_REMOVE_* support
tools build: Add jvmti feature detection support
perf jvmti: Plug compilation into perf build
perf kvmti: Remove unused Makefile file
Rabin Vincent (1):
perf callchain: Fixup help/config for no-unwinding
Taeung Song (4):
perf config: Add support for getting config key-value pairs
perf config: Validate config variable arguments before trying use them
perf config: Add support setting variables in a config file
perf config: Mark where are config items from (user or system)
tools/build/Build.include | 4 +-
tools/build/Documentation/Build.txt | 6 +-
tools/build/feature/Makefile | 6 +-
tools/build/feature/test-jvmti.c | 13 ++
tools/perf/Documentation/intel-pt.txt | 19 ++-
tools/perf/Documentation/perf-config.txt | 35 ++++++
tools/perf/Makefile.config | 26 ++++
tools/perf/Makefile.perf | 24 +++-
tools/perf/builtin-config.c | 137 ++++++++++++++++++++-
tools/perf/builtin-report.c | 3 +
tools/perf/jvmti/Build | 8 ++
tools/perf/jvmti/Makefile | 89 --------------
tools/perf/tests/make | 2 +-
tools/perf/ui/browsers/hists.c | 20 ++-
tools/perf/ui/stdio/hist.c | 35 +++++-
tools/perf/util/callchain.c | 205 ++++++++++++++++++++++++++++++-
tools/perf/util/callchain.h | 26 +++-
tools/perf/util/config.c | 20 +++
tools/perf/util/config.h | 4 +
tools/perf/util/machine.c | 82 ++++++++++---
tools/perf/util/symbol.h | 1 +
21 files changed, 634 insertions(+), 131 deletions(-)
create mode 100644 tools/build/feature/test-jvmti.c
create mode 100644 tools/perf/jvmti/Build
delete mode 100644 tools/perf/jvmti/Makefile
[root@jouet ~]# perf test
1: vmlinux symtab matches kallsyms : Ok
2: detect openat syscall event : Ok
3: detect openat syscall event on all cpus : Ok
4: read samples using the mmap interface : Ok
5: parse events tests : Ok
6: Validate PERF_RECORD_* events & perf_sample fields : Ok
7: Test perf pmu format parsing : Ok
8: Test dso data read : Ok
9: Test dso data cache : Ok
10: Test dso data reopen : Ok
11: roundtrip evsel->name check : Ok
12: Check parsing of sched tracepoints fields : Ok
13: Generate and check syscalls:sys_enter_openat event fields: Ok
14: struct perf_event_attr setup : Ok
15: Test matching and linking multiple hists : Ok
16: Try 'import perf' in python, checking link problems : Ok
17: Test breakpoint overflow signal handler : Ok
18: Test breakpoint overflow sampling : Ok
19: Test number of exit event of a simple workload : Ok
20: Test software clock events have valid period values : Ok
21: Test object code reading : Ok
22: Test sample parsing : Ok
23: Test using a dummy software event to keep tracking : Ok
24: Test parsing with no sample_id_all bit set : Ok
25: Test filtering hist entries : Ok
26: Test mmap thread lookup : Ok
27: Test thread mg sharing : Ok
28: Test output sorting of hist entries : Ok
29: Test cumulation of child hist entries : Ok
30: Test tracking with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: Test kmod_path__parse function : Ok
34: Test thread map : Ok
35: Test LLVM searching and compiling :
35.1: Basic BPF llvm compiling test : Ok
35.2: Test kbuild searching : Ok
35.3: Compile source for BPF prologue generation test : Ok
35.4: Compile source for BPF relocation test : Ok
36: Test topology in session : Ok
37: Test BPF filter :
37.1: Test basic BPF filtering : Ok
37.2: Test BPF prologue generation : Ok
37.3: Test BPF relocation checker : Ok
38: Test thread map synthesize : Ok
39: Test cpu map synthesize : Ok
40: Test stat config synthesize : Ok
41: Test stat synthesize : Ok
42: Test stat round synthesize : Ok
43: Test attr update synthesize : Ok
44: Test events times : Ok
45: Test backward reading from ring buffer : Ok
46: Test cpu map print : Ok
47: Test SDT event probing : Ok
48: Test is_printable_array function : Ok
49: Test bitmap print : Ok
50: x86 rdpmc test : Ok
51: Test converting perf time to TSC : Ok
52: Test dwarf unwind : Ok
53: Test x86 instruction decoder - new instructions : Ok
54: Test intel cqm nmi context read : Skip
[root@jouet ~]#
[root@zoo ~]# time dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 fedora:20: Ok
11 fedora:21: Ok
12 fedora:22: Ok
13 fedora:23: Ok
14 fedora:24: Ok
15 fedora:24-x-ARC-uClibc: Ok
16 fedora:rawhide: Ok
17 mageia:5: Ok
18 opensuse:13.2: Ok
19 opensuse:42.1: Ok
20 opensuse:tumbleweed: Ok
21 ubuntu:12.04.5: Ok
22 ubuntu:14.04: Ok
23 ubuntu:14.04.4: Ok
24 ubuntu:15.10: Ok
25 ubuntu:16.04: Ok
26 ubuntu:16.04-x-arm: Ok
27 ubuntu:16.04-x-arm64: Ok
28 ubuntu:16.04-x-powerpc: Ok
29 ubuntu:16.04-x-powerpc64: Ok
30 ubuntu:16.04-x-powerpc64el: Ok
31 ubuntu:16.04-x-s390: Ok
32 ubuntu:16.10: Ok
real 61m29.498s
user 0m3.969s
sys 0m3.525s
[root@zoo ~]#
[acme@jouet linux]$ perf stat make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_O: make install
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libperl_O: make NO_LIBPERL=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_clean_all_O: make clean all
make_debug_O: make DEBUG=1
make_no_newt_O: make NO_NEWT=1
make_perf_o_O: make perf.o
make_no_demangle_O: make NO_DEMANGLE=1
make_doc_O: make doc
make_install_bin_O: make install-bin
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_prefix_O: make install prefix=/tmp/krava
make_no_slang_O: make NO_SLANG=1
make_no_libelf_O: make NO_LIBELF=1
make_static_O: make LDFLAGS=-static
make_util_map_o_O: make util/map.o
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_pure_O: make
make_help_O: make help
make_no_gtk2_O: make NO_GTK2=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_tags_O: make tags
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2016-09-22 21:12 Arnaldo Carvalho de Melo
@ 2016-09-23 5:22 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2016-09-23 5:22 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, David Ahern, Don Zickus,
Jiri Olsa, Joe Mario, linux-arm-kernel, Mathieu Poirier,
Namhyung Kim, Peter Zijlstra
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 89f1c2c59c4aef8e26edbc7db5175e6ffb0e9ec7:
>
> Merge tag 'perf-core-for-mingo-20160920' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-20 23:32:02 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160922
>
> for you to fetch changes up to 2d831454140f28fa643b78deede4511b9e2c9e5f:
>
> perf hists: Make hists__fprintf_headers function global (2016-09-22 13:08:59 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements:
>
> New features:
>
> - Add support for interacting with Coresight PMU ETMs/PTMs, that are IP blocks
> to perform hardware assisted tracing on a ARM CPU core (Mathieu Poirier)
>
> Infrastructure:
>
> - Histogram prep work for the upcoming c2c tool (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Jiri Olsa (9):
> perf evsel: Remove superfluous initialization of weight
> perf hists: Use bigger buffer for stdio headers
> perf hists: Add __hist_entry__snprintf function
> perf tools: Make reset_dimensions global
> perf tools: Make output_field_add and sort_dimension__add global
> perf tools: Make several sorting functions global
> perf tools: Make several display functions global
> perf hists: Make __hist_entry__snprintf function global
> perf hists: Make hists__fprintf_headers function global
>
> Mathieu Poirier (6):
> perf tools: Confine __get_cpuid() to x86 architecture
> perf tools: Make coresight PMU listable
> perf tools: Add coresight etm PMU record capabilities
> perf pmu: Push configuration down to PMU driver
> perf tools: Add PMU configuration to tools
> perf tools: Add sink configuration for cs_etm PMU
>
> MAINTAINERS | 5 +
> tools/perf/Makefile.config | 11 +-
> tools/perf/arch/arm/util/Build | 2 +
> tools/perf/arch/arm/util/auxtrace.c | 54 ++++
> tools/perf/arch/arm/util/cs-etm.c | 617 ++++++++++++++++++++++++++++++++++++
> tools/perf/arch/arm/util/cs-etm.h | 26 ++
> tools/perf/arch/arm/util/pmu.c | 36 +++
> tools/perf/arch/arm64/util/Build | 4 +
> tools/perf/builtin-record.c | 10 +
> tools/perf/builtin-stat.c | 9 +
> tools/perf/builtin-top.c | 13 +
> tools/perf/ui/browsers/hists.c | 2 +-
> tools/perf/ui/hist.c | 2 +-
> tools/perf/ui/stdio/hist.c | 14 +-
> tools/perf/util/Build | 1 +
> tools/perf/util/auxtrace.c | 1 +
> tools/perf/util/auxtrace.h | 1 +
> tools/perf/util/cs-etm.h | 74 +++++
> tools/perf/util/drv_configs.c | 77 +++++
> tools/perf/util/drv_configs.h | 26 ++
> tools/perf/util/evsel.c | 2 -
> tools/perf/util/hist.h | 5 +
> tools/perf/util/pmu.h | 2 +
> tools/perf/util/sort.c | 16 +-
> tools/perf/util/sort.h | 11 +
> 25 files changed, 1001 insertions(+), 20 deletions(-)
> create mode 100644 tools/perf/arch/arm/util/auxtrace.c
> create mode 100644 tools/perf/arch/arm/util/cs-etm.c
> create mode 100644 tools/perf/arch/arm/util/cs-etm.h
> create mode 100644 tools/perf/arch/arm/util/pmu.c
> create mode 100644 tools/perf/util/cs-etm.h
> create mode 100644 tools/perf/util/drv_configs.c
> create mode 100644 tools/perf/util/drv_configs.h
>
> [root@zoo ~]# time dm
> 1 73.911 alpine:3.4: Ok
> 2 26.890 android-ndk:r12b-arm: Ok
> 3 77.833 archlinux:latest: Ok
> 4 40.814 centos:5: Ok
> 5 64.151 centos:6: Ok
> 6 75.720 centos:7: Ok
> 7 68.960 debian:7: Ok
> 8 75.606 debian:8: Ok
> 9 75.127 fedora:20: Ok
> 10 80.186 fedora:21: Ok
> 11 80.157 fedora:22: Ok
> 12 83.273 fedora:23: Ok
> 13 91.566 fedora:24: Ok
> 14 37.720 fedora:24-x-ARC-uClibc: Ok
> 15 98.492 fedora:rawhide: Ok
> 16 100.555 mageia:5: Ok
> 17 94.140 opensuse:13.2: Ok
> 18 95.476 opensuse:42.1: Ok
> 19 106.037 opensuse:tumbleweed: Ok
> 20 75.951 ubuntu:12.04.5: Ok
> 21 52.138 ubuntu:14.04: Ok
> 22 94.814 ubuntu:14.04.4: Ok
> 23 100.525 ubuntu:15.10: Ok
> 24 93.813 ubuntu:16.04: Ok
> 25 85.214 ubuntu:16.04-x-arm: Ok
> 26 83.487 ubuntu:16.04-x-arm64: Ok
> 27 82.918 ubuntu:16.04-x-powerpc64: Ok
> 28 84.189 ubuntu:16.04-x-powerpc64el: Ok
> 29 93.162 ubuntu:16.10: Ok
>
> real 38m13.568s
> user 0m2.379s
> sys 0m2.402s
> [root@zoo ~]#
>
> [root@jouet ~]# perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: detect openat syscall event : Ok
> 3: detect openat syscall event on all cpus : Ok
> 4: read samples using the mmap interface : Ok
> 5: parse events tests : Ok
> 6: Validate PERF_RECORD_* events & perf_sample fields : Ok
> 7: Test perf pmu format parsing : Ok
> 8: Test dso data read : Ok
> 9: Test dso data cache : Ok
> 10: Test dso data reopen : Ok
> 11: roundtrip evsel->name check : Ok
> 12: Check parsing of sched tracepoints fields : Ok
> 13: Generate and check syscalls:sys_enter_openat event fields: Ok
> 14: struct perf_event_attr setup : Ok
> 15: Test matching and linking multiple hists : Ok
> 16: Try 'import perf' in python, checking link problems : Ok
> 17: Test breakpoint overflow signal handler : Ok
> 18: Test breakpoint overflow sampling : Ok
> 19: Test number of exit event of a simple workload : Ok
> 20: Test software clock events have valid period values : Ok
> 21: Test object code reading : Ok
> 22: Test sample parsing : Ok
> 23: Test using a dummy software event to keep tracking : Ok
> 24: Test parsing with no sample_id_all bit set : Ok
> 25: Test filtering hist entries : Ok
> 26: Test mmap thread lookup : Ok
> 27: Test thread mg sharing : Ok
> 28: Test output sorting of hist entries : Ok
> 29: Test cumulation of child hist entries : Ok
> 30: Test tracking with sched_switch : Ok
> 31: Filter fds with revents mask in a fdarray : Ok
> 32: Add fd to a fdarray, making it autogrow : Ok
> 33: Test kmod_path__parse function : Ok
> 34: Test thread map : Ok
> 35: Test LLVM searching and compiling :
> 35.1: Basic BPF llvm compiling test : Ok
> 35.2: Test kbuild searching : Ok
> 35.3: Compile source for BPF prologue generation test : Ok
> 35.4: Compile source for BPF relocation test : Ok
> 36: Test topology in session : Ok
> 37: Test BPF filter :
> 37.1: Test basic BPF filtering : Ok
> 37.2: Test BPF prologue generation : Ok
> 37.3: Test BPF relocation checker : Ok
> 38: Test thread map synthesize : Ok
> 39: Test cpu map synthesize : Ok
> 40: Test stat config synthesize : Ok
> 41: Test stat synthesize : Ok
> 42: Test stat round synthesize : Ok
> 43: Test attr update synthesize : Ok
> 44: Test events times : Ok
> 45: Test backward reading from ring buffer : Ok
> 46: Test cpu map print : Ok
> 47: Test SDT event probing : Ok
> 48: Test is_printable_array function : Ok
> 49: Test bitmap print : Ok
> 50: x86 rdpmc test : Ok
> 51: Test converting perf time to TSC : Ok
> 52: Test dwarf unwind : Ok
> 53: Test x86 instruction decoder - new instructions : Ok
> 54: Test intel cqm nmi context read : Skip
> [root@jouet ~]#
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-09-22 21:12 Arnaldo Carvalho de Melo
2016-09-23 5:22 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-09-22 21:12 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, David Ahern, Don Zickus,
Jiri Olsa, Joe Mario, linux-arm-kernel, Mathieu Poirier,
Namhyung Kim, Peter Zijlstra
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 89f1c2c59c4aef8e26edbc7db5175e6ffb0e9ec7:
Merge tag 'perf-core-for-mingo-20160920' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-20 23:32:02 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160922
for you to fetch changes up to 2d831454140f28fa643b78deede4511b9e2c9e5f:
perf hists: Make hists__fprintf_headers function global (2016-09-22 13:08:59 -0300)
----------------------------------------------------------------
perf/core improvements:
New features:
- Add support for interacting with Coresight PMU ETMs/PTMs, that are IP blocks
to perform hardware assisted tracing on a ARM CPU core (Mathieu Poirier)
Infrastructure:
- Histogram prep work for the upcoming c2c tool (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Jiri Olsa (9):
perf evsel: Remove superfluous initialization of weight
perf hists: Use bigger buffer for stdio headers
perf hists: Add __hist_entry__snprintf function
perf tools: Make reset_dimensions global
perf tools: Make output_field_add and sort_dimension__add global
perf tools: Make several sorting functions global
perf tools: Make several display functions global
perf hists: Make __hist_entry__snprintf function global
perf hists: Make hists__fprintf_headers function global
Mathieu Poirier (6):
perf tools: Confine __get_cpuid() to x86 architecture
perf tools: Make coresight PMU listable
perf tools: Add coresight etm PMU record capabilities
perf pmu: Push configuration down to PMU driver
perf tools: Add PMU configuration to tools
perf tools: Add sink configuration for cs_etm PMU
MAINTAINERS | 5 +
tools/perf/Makefile.config | 11 +-
tools/perf/arch/arm/util/Build | 2 +
tools/perf/arch/arm/util/auxtrace.c | 54 ++++
tools/perf/arch/arm/util/cs-etm.c | 617 ++++++++++++++++++++++++++++++++++++
tools/perf/arch/arm/util/cs-etm.h | 26 ++
tools/perf/arch/arm/util/pmu.c | 36 +++
tools/perf/arch/arm64/util/Build | 4 +
tools/perf/builtin-record.c | 10 +
tools/perf/builtin-stat.c | 9 +
tools/perf/builtin-top.c | 13 +
tools/perf/ui/browsers/hists.c | 2 +-
tools/perf/ui/hist.c | 2 +-
tools/perf/ui/stdio/hist.c | 14 +-
tools/perf/util/Build | 1 +
tools/perf/util/auxtrace.c | 1 +
tools/perf/util/auxtrace.h | 1 +
tools/perf/util/cs-etm.h | 74 +++++
tools/perf/util/drv_configs.c | 77 +++++
tools/perf/util/drv_configs.h | 26 ++
tools/perf/util/evsel.c | 2 -
tools/perf/util/hist.h | 5 +
tools/perf/util/pmu.h | 2 +
tools/perf/util/sort.c | 16 +-
tools/perf/util/sort.h | 11 +
25 files changed, 1001 insertions(+), 20 deletions(-)
create mode 100644 tools/perf/arch/arm/util/auxtrace.c
create mode 100644 tools/perf/arch/arm/util/cs-etm.c
create mode 100644 tools/perf/arch/arm/util/cs-etm.h
create mode 100644 tools/perf/arch/arm/util/pmu.c
create mode 100644 tools/perf/util/cs-etm.h
create mode 100644 tools/perf/util/drv_configs.c
create mode 100644 tools/perf/util/drv_configs.h
[root@zoo ~]# time dm
1 73.911 alpine:3.4: Ok
2 26.890 android-ndk:r12b-arm: Ok
3 77.833 archlinux:latest: Ok
4 40.814 centos:5: Ok
5 64.151 centos:6: Ok
6 75.720 centos:7: Ok
7 68.960 debian:7: Ok
8 75.606 debian:8: Ok
9 75.127 fedora:20: Ok
10 80.186 fedora:21: Ok
11 80.157 fedora:22: Ok
12 83.273 fedora:23: Ok
13 91.566 fedora:24: Ok
14 37.720 fedora:24-x-ARC-uClibc: Ok
15 98.492 fedora:rawhide: Ok
16 100.555 mageia:5: Ok
17 94.140 opensuse:13.2: Ok
18 95.476 opensuse:42.1: Ok
19 106.037 opensuse:tumbleweed: Ok
20 75.951 ubuntu:12.04.5: Ok
21 52.138 ubuntu:14.04: Ok
22 94.814 ubuntu:14.04.4: Ok
23 100.525 ubuntu:15.10: Ok
24 93.813 ubuntu:16.04: Ok
25 85.214 ubuntu:16.04-x-arm: Ok
26 83.487 ubuntu:16.04-x-arm64: Ok
27 82.918 ubuntu:16.04-x-powerpc64: Ok
28 84.189 ubuntu:16.04-x-powerpc64el: Ok
29 93.162 ubuntu:16.10: Ok
real 38m13.568s
user 0m2.379s
sys 0m2.402s
[root@zoo ~]#
[root@jouet ~]# perf test
1: vmlinux symtab matches kallsyms : Ok
2: detect openat syscall event : Ok
3: detect openat syscall event on all cpus : Ok
4: read samples using the mmap interface : Ok
5: parse events tests : Ok
6: Validate PERF_RECORD_* events & perf_sample fields : Ok
7: Test perf pmu format parsing : Ok
8: Test dso data read : Ok
9: Test dso data cache : Ok
10: Test dso data reopen : Ok
11: roundtrip evsel->name check : Ok
12: Check parsing of sched tracepoints fields : Ok
13: Generate and check syscalls:sys_enter_openat event fields: Ok
14: struct perf_event_attr setup : Ok
15: Test matching and linking multiple hists : Ok
16: Try 'import perf' in python, checking link problems : Ok
17: Test breakpoint overflow signal handler : Ok
18: Test breakpoint overflow sampling : Ok
19: Test number of exit event of a simple workload : Ok
20: Test software clock events have valid period values : Ok
21: Test object code reading : Ok
22: Test sample parsing : Ok
23: Test using a dummy software event to keep tracking : Ok
24: Test parsing with no sample_id_all bit set : Ok
25: Test filtering hist entries : Ok
26: Test mmap thread lookup : Ok
27: Test thread mg sharing : Ok
28: Test output sorting of hist entries : Ok
29: Test cumulation of child hist entries : Ok
30: Test tracking with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: Test kmod_path__parse function : Ok
34: Test thread map : Ok
35: Test LLVM searching and compiling :
35.1: Basic BPF llvm compiling test : Ok
35.2: Test kbuild searching : Ok
35.3: Compile source for BPF prologue generation test : Ok
35.4: Compile source for BPF relocation test : Ok
36: Test topology in session : Ok
37: Test BPF filter :
37.1: Test basic BPF filtering : Ok
37.2: Test BPF prologue generation : Ok
37.3: Test BPF relocation checker : Ok
38: Test thread map synthesize : Ok
39: Test cpu map synthesize : Ok
40: Test stat config synthesize : Ok
41: Test stat synthesize : Ok
42: Test stat round synthesize : Ok
43: Test attr update synthesize : Ok
44: Test events times : Ok
45: Test backward reading from ring buffer : Ok
46: Test cpu map print : Ok
47: Test SDT event probing : Ok
48: Test is_printable_array function : Ok
49: Test bitmap print : Ok
50: x86 rdpmc test : Ok
51: Test converting perf time to TSC : Ok
52: Test dwarf unwind : Ok
53: Test x86 instruction decoder - new instructions : Ok
54: Test intel cqm nmi context read : Skip
[root@jouet ~]#
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2016-07-18 23:33 Arnaldo Carvalho de Melo
@ 2016-07-19 6:46 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2016-07-19 6:46 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Dan Carpenter, David Ahern, He Kuang,
Jiri Olsa, Jiri Pirko, Josh Poimboeuf, Kan Liang, Mark Rutland,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, Wang Nan
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Build stats:
>
> [root@jouet 5]# perf stat dm
> alpine:3.4: Ok
> android-ndk:r12b: Ok
> centos:5: Ok
> centos:6: Ok
> centos:7: Ok
> debian:7: Ok
> debian:8: Ok
> debian:experimental: Ok
> fedora:21: Ok
> fedora:22: Ok
> fedora:23: Ok
> fedora:24: Ok
> fedora:rawhide: Ok
> mageia:5: Ok
> opensuse:13.2: Ok
> opensuse:42.1: Ok
> ubuntu:14.04.4: Ok
> ubuntu:15.10: Ok
> ubuntu:16.04: Ok
> ubuntu:16.04-x-armhf: Ok
>
> Performance counter stats for 'dm':
>
> 1896.227285 task-clock (msec) # 0.002 CPUs utilized
> 76,145 context-switches # 0.040 M/sec
> 9,323 cpu-migrations # 0.005 M/sec
> 53,894 page-faults # 0.028 M/sec
> 5,497,625,679 cycles # 2.899 GHz
> 5,110,226,458 instructions # 0.93 insn per cycle
> 950,036,839 branches # 501.014 M/sec
> 16,978,253 branch-misses # 1.79% of all branches
>
> 767.910393301 seconds time elapsed
>
> [root@jouet 5]#
>
> The following changes since commit 09211e2530ab4905ec16edecc27022d6b247419d:
>
> Merge tag 'perf-core-for-mingo-20160715' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-07-16 22:36:42 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160718
>
> for you to fetch changes up to 988dd774dcbd9151c2a643fc7284c5c3c4d0adb7:
>
> perf tests: Add is_printable_array test (2016-07-18 19:50:35 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Properly report when a function wildcard produces no matches in 'perf probe'
> (Masami Hiramatsu)
>
> - Balance opening and reading events in 'perf stat', which could cause
> it to get stuck trying to close invalid file descriptors (Mark Rutland)
>
> Infrastructure:
>
> - Copy more headers from the kernel, this time for headers that
> were just including the contents of its kernel counterparts, should
> help resolving the problems with linux-next, where some uapi related
> patches seem to be breaking tools/object/ build.
>
> Some more combing will be done, but at least it is possible to build
> perf out of tree, via a detached tarball (make help | grep perf)
> without including kernel files in its MANIFEST (Arnaldo Carvalho de Melo)
>
> - Fix smatch found errors that were not causing problems, but are
> mistakes nonetheless (Dan Carpenter)
>
> - Fix string vs byte array resolving in the python script code (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (7):
> perf tools: Add missing linux/compiler.h include to perf-sys.h
> perf tools: Remove tools/perf/util/include/asm/byteorder.h
> perf tools: Remove tools/perf/util/include/linux/const.h
> Remove: kernel unistd*h files from perf's MANIFEST, not used
> tools: Copy the bitops files accessed from the kernel and check for drift
> perf tools: Remove include/linux/list.h from perf's MANIFEST
> tools: Copy linux/{hash,poison}.h and check for drift
>
> Dan Carpenter (2):
> perf jit: Add missing curly braces
> perf jit: Remove some no-op error handling
>
> Jiri Olsa (3):
> perf script python: Fix string vs byte array resolving
> perf tools: Make is_printable_array global
> perf tests: Add is_printable_array test
>
> Mark Rutland (2):
> perf stat: Balance opening and reading events
> perf cpu_map: Add more helpers
>
> Masami Hiramatsu (1):
> perf probe: Warn unmatched function filter correctly
>
> tools/include/asm-generic/bitops/__fls.h | 44 ++++++++-
> tools/include/asm-generic/bitops/arch_hweight.h | 26 ++++-
> tools/include/asm-generic/bitops/const_hweight.h | 44 ++++++++-
> tools/include/asm-generic/bitops/fls.h | 42 ++++++++-
> tools/include/asm-generic/bitops/fls64.h | 37 +++++++-
> tools/include/linux/hash.h | 105 ++++++++++++++++++++-
> tools/include/linux/poison.h | 91 +++++++++++++++++-
> tools/perf/MANIFEST | 13 ---
> tools/perf/Makefile.perf | 18 ++++
> tools/perf/builtin-stat.c | 8 +-
> tools/perf/jvmti/jvmti_agent.c | 10 +-
> tools/perf/perf-sys.h | 1 +
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 4 +
> tools/perf/tests/is_printable_array.c | 36 +++++++
> tools/perf/tests/tests.h | 1 +
> tools/perf/util/cpumap.c | 14 ++-
> tools/perf/util/cpumap.h | 2 +
> tools/perf/util/include/asm/byteorder.h | 2 -
> tools/perf/util/include/linux/const.h | 1 -
> tools/perf/util/map.c | 3 +
> tools/perf/util/probe-event.c | 12 ++-
> tools/perf/util/python.c | 12 ---
> .../util/scripting-engines/trace-event-python.c | 25 +++--
> tools/perf/util/util.c | 16 ++++
> tools/perf/util/util.h | 1 +
> 26 files changed, 512 insertions(+), 57 deletions(-)
> create mode 100644 tools/perf/tests/is_printable_array.c
> delete mode 100644 tools/perf/util/include/asm/byteorder.h
> delete mode 100644 tools/perf/util/include/linux/const.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-07-18 23:33 Arnaldo Carvalho de Melo
2016-07-19 6:46 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-07-18 23:33 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Dan Carpenter, David Ahern, He Kuang,
Jiri Olsa, Jiri Pirko, Josh Poimboeuf, Kan Liang, Mark Rutland,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
Build stats:
[root@jouet 5]# perf stat dm
alpine:3.4: Ok
android-ndk:r12b: Ok
centos:5: Ok
centos:6: Ok
centos:7: Ok
debian:7: Ok
debian:8: Ok
debian:experimental: Ok
fedora:21: Ok
fedora:22: Ok
fedora:23: Ok
fedora:24: Ok
fedora:rawhide: Ok
mageia:5: Ok
opensuse:13.2: Ok
opensuse:42.1: Ok
ubuntu:14.04.4: Ok
ubuntu:15.10: Ok
ubuntu:16.04: Ok
ubuntu:16.04-x-armhf: Ok
Performance counter stats for 'dm':
1896.227285 task-clock (msec) # 0.002 CPUs utilized
76,145 context-switches # 0.040 M/sec
9,323 cpu-migrations # 0.005 M/sec
53,894 page-faults # 0.028 M/sec
5,497,625,679 cycles # 2.899 GHz
5,110,226,458 instructions # 0.93 insn per cycle
950,036,839 branches # 501.014 M/sec
16,978,253 branch-misses # 1.79% of all branches
767.910393301 seconds time elapsed
[root@jouet 5]#
The following changes since commit 09211e2530ab4905ec16edecc27022d6b247419d:
Merge tag 'perf-core-for-mingo-20160715' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-07-16 22:36:42 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160718
for you to fetch changes up to 988dd774dcbd9151c2a643fc7284c5c3c4d0adb7:
perf tests: Add is_printable_array test (2016-07-18 19:50:35 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Properly report when a function wildcard produces no matches in 'perf probe'
(Masami Hiramatsu)
- Balance opening and reading events in 'perf stat', which could cause
it to get stuck trying to close invalid file descriptors (Mark Rutland)
Infrastructure:
- Copy more headers from the kernel, this time for headers that
were just including the contents of its kernel counterparts, should
help resolving the problems with linux-next, where some uapi related
patches seem to be breaking tools/object/ build.
Some more combing will be done, but at least it is possible to build
perf out of tree, via a detached tarball (make help | grep perf)
without including kernel files in its MANIFEST (Arnaldo Carvalho de Melo)
- Fix smatch found errors that were not causing problems, but are
mistakes nonetheless (Dan Carpenter)
- Fix string vs byte array resolving in the python script code (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (7):
perf tools: Add missing linux/compiler.h include to perf-sys.h
perf tools: Remove tools/perf/util/include/asm/byteorder.h
perf tools: Remove tools/perf/util/include/linux/const.h
Remove: kernel unistd*h files from perf's MANIFEST, not used
tools: Copy the bitops files accessed from the kernel and check for drift
perf tools: Remove include/linux/list.h from perf's MANIFEST
tools: Copy linux/{hash,poison}.h and check for drift
Dan Carpenter (2):
perf jit: Add missing curly braces
perf jit: Remove some no-op error handling
Jiri Olsa (3):
perf script python: Fix string vs byte array resolving
perf tools: Make is_printable_array global
perf tests: Add is_printable_array test
Mark Rutland (2):
perf stat: Balance opening and reading events
perf cpu_map: Add more helpers
Masami Hiramatsu (1):
perf probe: Warn unmatched function filter correctly
tools/include/asm-generic/bitops/__fls.h | 44 ++++++++-
tools/include/asm-generic/bitops/arch_hweight.h | 26 ++++-
tools/include/asm-generic/bitops/const_hweight.h | 44 ++++++++-
tools/include/asm-generic/bitops/fls.h | 42 ++++++++-
tools/include/asm-generic/bitops/fls64.h | 37 +++++++-
tools/include/linux/hash.h | 105 ++++++++++++++++++++-
tools/include/linux/poison.h | 91 +++++++++++++++++-
tools/perf/MANIFEST | 13 ---
tools/perf/Makefile.perf | 18 ++++
tools/perf/builtin-stat.c | 8 +-
tools/perf/jvmti/jvmti_agent.c | 10 +-
tools/perf/perf-sys.h | 1 +
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/is_printable_array.c | 36 +++++++
tools/perf/tests/tests.h | 1 +
tools/perf/util/cpumap.c | 14 ++-
tools/perf/util/cpumap.h | 2 +
tools/perf/util/include/asm/byteorder.h | 2 -
tools/perf/util/include/linux/const.h | 1 -
tools/perf/util/map.c | 3 +
tools/perf/util/probe-event.c | 12 ++-
tools/perf/util/python.c | 12 ---
.../util/scripting-engines/trace-event-python.c | 25 +++--
tools/perf/util/util.c | 16 ++++
tools/perf/util/util.h | 1 +
26 files changed, 512 insertions(+), 57 deletions(-)
create mode 100644 tools/perf/tests/is_printable_array.c
delete mode 100644 tools/perf/util/include/asm/byteorder.h
delete mode 100644 tools/perf/util/include/linux/const.h
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2016-05-10 15:15 Arnaldo Carvalho de Melo
@ 2016-05-10 20:28 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2016-05-10 20:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Andi Kleen,
Chris Phlipot, David Ahern, Ekaterina Tumanova, He Kuang,
Jiri Olsa, Josh Poimboeuf, Kan Liang, Masami Hiramatsu,
Milian Wolff, Namhyung Kim, Pekka Enberg, Peter Zijlstra,
pi3orama, Stephane Eranian, Sukadev Bhattiprolu, Wang Nan,
Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit ea7c28518943b26a85d73cd76acd03b71962cb18:
>
> Merge tag 'perf-core-for-mingo-20160506' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-05-07 06:49:28 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160510
>
> for you to fetch changes up to 452e84012595d681f254a3a0d733fb0b18ffaf42:
>
> perf tools: Remove xrealloc and ALLOC_GROW (2016-05-10 11:58:27 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Recording 'dwarf' callchains do not need DWARF unwinding support (He Kuang)
>
> - Print recently added perf_event_attr.write_backward bit flag in -vv
> verbose mode (Arnaldo Carvalho de Melo)
>
> - Fix incorrect python db-export error message in 'perf script' (Chris Phlipot)
>
> - Fix handling of zero-length symbols (Chris Phlipot)
>
> Andi Kleen (1):
> perf stat: Scale values by unit before metrics
>
> Infrastructure:
>
> - Rewrite strbuf not to die(), making tools using it to check its
> return value instead (Masami Hiramatsu)
>
> - Support reading from backward ring buffer, add a 'perf test' entry
> for it (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf stat: Scale values by unit before metrics
>
> Arnaldo Carvalho de Melo (1):
> perf evsel: Print state of perf_event_attr.write_backward
>
> Chris Phlipot (2):
> perf script: Fix incorrect python db-export error message
> perf symbols: Fix handling of zero-length symbols.
>
> He Kuang (1):
> perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support
>
> Masami Hiramatsu (8):
> perf tools: Rewrite strbuf not to die()
> perf probe: Check the return value of strbuf APIs
> perf help: Make check_emacsclient_version to check strbuf APIs
> perf tools: Make alias handler to check return value of strbuf
> perf header: Make topology checkers to check return value of strbuf
> perf pmu: Make pmu_formats_string to check return value of strbuf
> perf help: Do not use ALLOC_GROW in add_cmd_list
> perf tools: Remove xrealloc and ALLOC_GROW
>
> Wang Nan (2):
> perf tools: Support reading from backward ring buffer
> perf tests: Add test to check backward ring buffer
>
> tools/perf/builtin-help.c | 18 +--
> tools/perf/perf.c | 8 +-
> tools/perf/tests/Build | 1 +
> tools/perf/tests/backward-ring-buffer.c | 151 +++++++++++++++++++++
> tools/perf/tests/builtin-test.c | 4 +
> tools/perf/tests/tests.h | 1 +
> tools/perf/util/Build | 1 -
> tools/perf/util/cache.h | 19 ---
> tools/perf/util/dwarf-aux.c | 52 ++++---
> tools/perf/util/evlist.c | 50 +++++++
> tools/perf/util/evlist.h | 4 +
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/header.c | 31 +++--
> tools/perf/util/help-unknown-cmd.c | 30 ++--
> tools/perf/util/pmu.c | 10 +-
> tools/perf/util/probe-event.c | 143 +++++++++++--------
> tools/perf/util/probe-finder.c | 30 ++--
> tools/perf/util/quote.c | 36 ++---
> tools/perf/util/quote.h | 2 +-
> .../util/scripting-engines/trace-event-python.c | 2 +-
> tools/perf/util/stat.c | 4 +-
> tools/perf/util/strbuf.c | 93 +++++++++----
> tools/perf/util/strbuf.h | 25 ++--
> tools/perf/util/symbol.c | 2 +-
> tools/perf/util/util.c | 2 -
> tools/perf/util/util.h | 6 -
> tools/perf/util/wrapper.c | 29 ----
> 27 files changed, 510 insertions(+), 245 deletions(-)
> create mode 100644 tools/perf/tests/backward-ring-buffer.c
> delete mode 100644 tools/perf/util/wrapper.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-05-10 15:15 Arnaldo Carvalho de Melo
2016-05-10 20:28 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-10 15:15 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Chris Phlipot, David Ahern,
Ekaterina Tumanova, He Kuang, Jiri Olsa, Josh Poimboeuf,
Kan Liang, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Pekka Enberg, Peter Zijlstra, pi3orama, Stephane Eranian,
Sukadev Bhattiprolu, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit ea7c28518943b26a85d73cd76acd03b71962cb18:
Merge tag 'perf-core-for-mingo-20160506' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-05-07 06:49:28 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160510
for you to fetch changes up to 452e84012595d681f254a3a0d733fb0b18ffaf42:
perf tools: Remove xrealloc and ALLOC_GROW (2016-05-10 11:58:27 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Recording 'dwarf' callchains do not need DWARF unwinding support (He Kuang)
- Print recently added perf_event_attr.write_backward bit flag in -vv
verbose mode (Arnaldo Carvalho de Melo)
- Fix incorrect python db-export error message in 'perf script' (Chris Phlipot)
- Fix handling of zero-length symbols (Chris Phlipot)
Andi Kleen (1):
perf stat: Scale values by unit before metrics
Infrastructure:
- Rewrite strbuf not to die(), making tools using it to check its
return value instead (Masami Hiramatsu)
- Support reading from backward ring buffer, add a 'perf test' entry
for it (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf stat: Scale values by unit before metrics
Arnaldo Carvalho de Melo (1):
perf evsel: Print state of perf_event_attr.write_backward
Chris Phlipot (2):
perf script: Fix incorrect python db-export error message
perf symbols: Fix handling of zero-length symbols.
He Kuang (1):
perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support
Masami Hiramatsu (8):
perf tools: Rewrite strbuf not to die()
perf probe: Check the return value of strbuf APIs
perf help: Make check_emacsclient_version to check strbuf APIs
perf tools: Make alias handler to check return value of strbuf
perf header: Make topology checkers to check return value of strbuf
perf pmu: Make pmu_formats_string to check return value of strbuf
perf help: Do not use ALLOC_GROW in add_cmd_list
perf tools: Remove xrealloc and ALLOC_GROW
Wang Nan (2):
perf tools: Support reading from backward ring buffer
perf tests: Add test to check backward ring buffer
tools/perf/builtin-help.c | 18 +--
tools/perf/perf.c | 8 +-
tools/perf/tests/Build | 1 +
tools/perf/tests/backward-ring-buffer.c | 151 +++++++++++++++++++++
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/tests.h | 1 +
tools/perf/util/Build | 1 -
tools/perf/util/cache.h | 19 ---
tools/perf/util/dwarf-aux.c | 52 ++++---
tools/perf/util/evlist.c | 50 +++++++
tools/perf/util/evlist.h | 4 +
tools/perf/util/evsel.c | 1 +
tools/perf/util/header.c | 31 +++--
tools/perf/util/help-unknown-cmd.c | 30 ++--
tools/perf/util/pmu.c | 10 +-
tools/perf/util/probe-event.c | 143 +++++++++++--------
tools/perf/util/probe-finder.c | 30 ++--
tools/perf/util/quote.c | 36 ++---
tools/perf/util/quote.h | 2 +-
.../util/scripting-engines/trace-event-python.c | 2 +-
tools/perf/util/stat.c | 4 +-
tools/perf/util/strbuf.c | 93 +++++++++----
tools/perf/util/strbuf.h | 25 ++--
tools/perf/util/symbol.c | 2 +-
tools/perf/util/util.c | 2 -
tools/perf/util/util.h | 6 -
tools/perf/util/wrapper.c | 29 ----
27 files changed, 510 insertions(+), 245 deletions(-)
create mode 100644 tools/perf/tests/backward-ring-buffer.c
delete mode 100644 tools/perf/util/wrapper.c
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-03-07 19:44 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-03-07 19:44 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Borislav Petkov, Colin Ian King,
David Ahern, Davidlohr Bueso, He Kuang, Jiri Olsa, Mel Gorman,
Namhyung Kim, Peter Zijlstra, Stephane Eranian, Steven Rostedt,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 009668520ae00d52026ccdb3884864e3473c6b65:
Merge tag 'perf-core-for-mingo-20160303' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-03-04 12:19:21 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160307
for you to fetch changes up to b03ae342d9bec460a6c9c327c3f5f758263b0932:
perf report: Use hierarchy hpp list on gtk (2016-03-07 15:10:41 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Allow grouping multiple sort keys per 'perf report/top --hierarchy'
level (Namhyung Kim)
- Document 'perf stat --detailed' option (Borislav Petkov)
Infrastructure:
- jitdump prep work for supporting it with Intel PT (Adrian Hunter)
- Use 64-bit shifts with (TSC) time conversion (Adrian Hunter)
Trivial:
- Explicitly declare inc_group_count as a void function (Colin Ian King)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (5):
perf inject: Hit all DSOs for AUX data in JIT and other cases
perf session: Simplify tool stubs
perf jit: Let jit_process() return errors
perf jit: Move clockid validation
perf tools: Use 64-bit shifts with (TSC) time conversion
Borislav Petkov (1):
perf stat: Document --detailed option
Colin Ian King (1):
perf tools: Explicitly declare inc_group_count as a void function
Namhyung Kim (8):
perf hists: Add level field to struct perf_hpp_fmt
perf hists: Introduce perf_hpp__setup_hists_formats()
perf hists: Use own hpp_list for hierarchy mode
perf hists: Support multiple sort keys in a hierarchy level
perf hists: Fix indent for multiple hierarchy sort key
perf report: Use hierarchy hpp list on stdio
perf hists browser: Use hierarchy hpp list
perf report: Use hierarchy hpp list on gtk
tools/perf/Documentation/perf-stat.txt | 8 ++
tools/perf/arch/x86/tests/rdpmc.c | 2 +-
tools/perf/builtin-inject.c | 52 ++++------
tools/perf/ui/browsers/hists.c | 147 +++++++++++++++-------------
tools/perf/ui/gtk/hists.c | 73 ++++++++------
tools/perf/ui/hist.c | 69 +++++++++++++
tools/perf/ui/stdio/hist.c | 171 +++++++++++++++++----------------
tools/perf/util/hist.c | 72 +++++++++-----
tools/perf/util/hist.h | 14 +++
tools/perf/util/jitdump.c | 29 +++++-
tools/perf/util/parse-events.y | 2 +-
tools/perf/util/session.c | 40 ++------
tools/perf/util/sort.c | 146 ++++++++++++++++++++--------
tools/perf/util/sort.h | 1 +
tools/perf/util/tsc.c | 2 +-
15 files changed, 514 insertions(+), 314 deletions(-)
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2016-02-22 18:02 Arnaldo Carvalho de Melo
@ 2016-02-24 7:21 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2016-02-24 7:21 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
Brendan Gregg, Cody P Schafer, David Ahern, He Kuang,
Jeremie Galarneau, Jiri Olsa, Kirill Smelkov, Li Zefan,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra, pi3orama,
Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 91e48b7df15196b8ce01f40455219d3ed7889988:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-02-20 11:52:16 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 03e0a7df3efd959e40cd7ff40b1fabddc234ec5a:
>
> perf tools: Introduce bpf-output event (2016-02-22 14:37:21 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Add API to set values of map entries in a BPF object, be it
> individual map slots or ranges (Wang Nan)
>
> - Introduce support for the 'bpf-output' event (Wang Nan)
>
> - Add glue to read perf events in a BPF program (Wang Nan)
>
> Fixes:
>
> - Sort key fixes: Alignment for srcline, file, trace; fix
> segfault for dynamic, trace events related sort keys (Namyung Kim)
>
> Build fixes:
>
> - Remove duplicate typedef config_term_func_t definition,
> fixing the build on older systems (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf tools: Fix build on older systems
> perf tools: Remove duplicate typedef config_term_func_t definition
>
> Namhyung Kim (5):
> perf tools: Fix segfault on dynamic entries
> perf tools: Update srcline/file if needed
> perf tools: Fix alignment on some sort keys
> perf tools: Fix column width setting on 'trace' sort key
> perf tools: Fix assertion failure on dynamic entry
>
> Wang Nan (8):
> perf bpf: Add API to set values to map entries in a bpf object
> perf tools: Enable BPF object configure syntax
> perf record: Apply config to BPF objects before recording
> perf tools: Enable passing event to BPF object
> perf tools: Support setting different slots in a BPF map separately
> perf tools: Enable indices setting syntax for BPF map
> perf tools: Apply tracepoint event definition options to BPF script
> perf tools: Introduce bpf-output event
>
> tools/perf/builtin-record.c | 11 +
> tools/perf/tests/bpf.c | 2 +-
> tools/perf/ui/hist.c | 3 +
> tools/perf/util/bpf-loader.c | 718 +++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/bpf-loader.h | 59 ++++
> tools/perf/util/evlist.c | 16 +
> tools/perf/util/evlist.h | 3 +
> tools/perf/util/evsel.c | 5 +
> tools/perf/util/evsel.h | 8 +
> tools/perf/util/hist.c | 3 +
> tools/perf/util/parse-events.c | 130 +++++++-
> tools/perf/util/parse-events.h | 17 +-
> tools/perf/util/parse-events.l | 16 +-
> tools/perf/util/parse-events.y | 95 +++++-
> tools/perf/util/sort.c | 90 +++---
> 15 files changed, 1112 insertions(+), 64 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2016-02-22 18:02 Arnaldo Carvalho de Melo
2016-02-24 7:21 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-22 18:02 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Brendan Gregg, Cody P Schafer,
David Ahern, He Kuang, Jeremie Galarneau, Jiri Olsa,
Kirill Smelkov, Li Zefan, Masami Hiramatsu, Namhyung Kim,
Peter Zijlstra, pi3orama, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 91e48b7df15196b8ce01f40455219d3ed7889988:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-02-20 11:52:16 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 03e0a7df3efd959e40cd7ff40b1fabddc234ec5a:
perf tools: Introduce bpf-output event (2016-02-22 14:37:21 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Add API to set values of map entries in a BPF object, be it
individual map slots or ranges (Wang Nan)
- Introduce support for the 'bpf-output' event (Wang Nan)
- Add glue to read perf events in a BPF program (Wang Nan)
Fixes:
- Sort key fixes: Alignment for srcline, file, trace; fix
segfault for dynamic, trace events related sort keys (Namyung Kim)
Build fixes:
- Remove duplicate typedef config_term_func_t definition,
fixing the build on older systems (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf tools: Fix build on older systems
perf tools: Remove duplicate typedef config_term_func_t definition
Namhyung Kim (5):
perf tools: Fix segfault on dynamic entries
perf tools: Update srcline/file if needed
perf tools: Fix alignment on some sort keys
perf tools: Fix column width setting on 'trace' sort key
perf tools: Fix assertion failure on dynamic entry
Wang Nan (8):
perf bpf: Add API to set values to map entries in a bpf object
perf tools: Enable BPF object configure syntax
perf record: Apply config to BPF objects before recording
perf tools: Enable passing event to BPF object
perf tools: Support setting different slots in a BPF map separately
perf tools: Enable indices setting syntax for BPF map
perf tools: Apply tracepoint event definition options to BPF script
perf tools: Introduce bpf-output event
tools/perf/builtin-record.c | 11 +
tools/perf/tests/bpf.c | 2 +-
tools/perf/ui/hist.c | 3 +
tools/perf/util/bpf-loader.c | 718 +++++++++++++++++++++++++++++++++++++++++
tools/perf/util/bpf-loader.h | 59 ++++
tools/perf/util/evlist.c | 16 +
tools/perf/util/evlist.h | 3 +
tools/perf/util/evsel.c | 5 +
tools/perf/util/evsel.h | 8 +
tools/perf/util/hist.c | 3 +
tools/perf/util/parse-events.c | 130 +++++++-
tools/perf/util/parse-events.h | 17 +-
tools/perf/util/parse-events.l | 16 +-
tools/perf/util/parse-events.y | 95 +++++-
tools/perf/util/sort.c | 90 +++---
15 files changed, 1112 insertions(+), 64 deletions(-)
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-09-14 8:41 ` Ingo Molnar
@ 2015-09-14 9:07 ` Wangnan (F)
0 siblings, 0 replies; 57+ messages in thread
From: Wangnan (F) @ 2015-09-14 9:07 UTC (permalink / raw)
To: Ingo Molnar, Arnaldo Carvalho de Melo
Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Jan Stancek, Jiri Olsa, Kan Liang, Matt Fleming, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Raphael Beamonte,
Stephane Eranian, Steven Rostedt
On 2015/9/14 16:41, Ingo Molnar wrote:
> * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
>> Em Tue, Sep 08, 2015 at 04:21:47PM +0200, Ingo Molnar escreveu:
>>> * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>>>
>>>> Em Fri, Sep 04, 2015 at 10:06:28PM -0300, Arnaldo Carvalho de Melo escreveu:
>>>>> Hi Ingo,
>>>>>
>>>>> Please consider pulling, this is on top of the previous pull request,
>>>>> perf-core-for-mingo.
>>>> Ingo, please do not pull this 'perf-core-for-mingo-2' tag, there were
>>>> some misunderstandings about the acks for "Move sw clock metrics
>>>> printout to stat-shadow" and Jiri and Andi are working that out.
>>>>
>>>> I'll remove those patches and get a new perf-core-for-mingo-2
>>>> tag in place, before continuing today's batch, which possibly will be
>>>> available as 'perf-core-for-mingo-3'
>>>>
>>>> What is in 'perf-core-for-mingo" should be Ok.
>>> Ok!
>> Thanks! I have already removed that problematic changeset and resigned
>> the 'perf-core-for-mingo-2' tag, same contents modulo that cset.
> Hm, so I pulled it (commit 1765d9b26f84), but with an old perf.data I'm getting
> this crash:
>
> triton:~/tip/tools/perf> perf report
> perf: Segmentation fault
> -------- backtrace --------
> perf[0x52bc0b]
> /lib/x86_64-linux-gnu/libc.so.6(+0x352f0)[0x7f51a583c2f0]
> perf[0x42ce95]
> perf[0x4bc6c3]
> perf[0x4bcfa1]
> perf[0x4bf939]
> perf(perf_session__process_events+0x390)[0x4be430]
> perf(cmd_report+0x1070)[0x42e2e0]
> perf[0x478e03]
> perf(main+0x60a)[0x41f1ba]
> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f51a5827a40]
> perf(_start+0x29)[0x41f2d9]
> [0x0]
>
> I also re-tested qand it still crashes.
>
> Bisected it to:
>
> e1e499aba570 perf tools: Add processor socket info to hist_entry and addr_location
>
> Running on Ubuntu, 1 socket box, 12 CPUs.
Hi Ingo,
It seems you met a bug we are discussing these days. Please have a look at
the following discussions:
http://lkml.kernel.org/r/1441630315-189525-1-git-send-email-wangnan0@huawei.com
http://lkml.kernel.org/r/1441828225-667-1-git-send-email-acme@kernel.org
Thank you.
> I went back to perf/core 8f3e5684d3fb and it doesn't crash anymore - so I unpulled
> your tree for now. (Will send you the perf.data privately.)
>
> Thanks,
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-09-08 14:30 ` Arnaldo Carvalho de Melo
@ 2015-09-14 8:41 ` Ingo Molnar
2015-09-14 9:07 ` Wangnan (F)
0 siblings, 1 reply; 57+ messages in thread
From: Ingo Molnar @ 2015-09-14 8:41 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Jan Stancek, Jiri Olsa, Kan Liang, Matt Fleming, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Raphael Beamonte,
Stephane Eranian, Steven Rostedt
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Em Tue, Sep 08, 2015 at 04:21:47PM +0200, Ingo Molnar escreveu:
> >
> > * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> >
> > > Em Fri, Sep 04, 2015 at 10:06:28PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Hi Ingo,
> > > >
> > > > Please consider pulling, this is on top of the previous pull request,
> > > > perf-core-for-mingo.
> > >
> > > Ingo, please do not pull this 'perf-core-for-mingo-2' tag, there were
> > > some misunderstandings about the acks for "Move sw clock metrics
> > > printout to stat-shadow" and Jiri and Andi are working that out.
> > >
> > > I'll remove those patches and get a new perf-core-for-mingo-2
> > > tag in place, before continuing today's batch, which possibly will be
> > > available as 'perf-core-for-mingo-3'
> > >
> > > What is in 'perf-core-for-mingo" should be Ok.
> >
> > Ok!
>
> Thanks! I have already removed that problematic changeset and resigned
> the 'perf-core-for-mingo-2' tag, same contents modulo that cset.
Hm, so I pulled it (commit 1765d9b26f84), but with an old perf.data I'm getting
this crash:
triton:~/tip/tools/perf> perf report
perf: Segmentation fault
-------- backtrace --------
perf[0x52bc0b]
/lib/x86_64-linux-gnu/libc.so.6(+0x352f0)[0x7f51a583c2f0]
perf[0x42ce95]
perf[0x4bc6c3]
perf[0x4bcfa1]
perf[0x4bf939]
perf(perf_session__process_events+0x390)[0x4be430]
perf(cmd_report+0x1070)[0x42e2e0]
perf[0x478e03]
perf(main+0x60a)[0x41f1ba]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f51a5827a40]
perf(_start+0x29)[0x41f2d9]
[0x0]
I also re-tested 1765d9b26f84 and it still crashes.
Bisected it to:
e1e499aba570 perf tools: Add processor socket info to hist_entry and addr_location
Running on Ubuntu, 1 socket box, 12 CPUs.
I went back to perf/core 8f3e5684d3fb and it doesn't crash anymore - so I unpulled
your tree for now. (Will send you the perf.data privately.)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-09-08 14:21 ` Ingo Molnar
@ 2015-09-08 14:30 ` Arnaldo Carvalho de Melo
2015-09-14 8:41 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-08 14:30 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Jan Stancek, Jiri Olsa, Kan Liang, Matt Fleming, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Raphael Beamonte,
Stephane Eranian, Steven Rostedt
Em Tue, Sep 08, 2015 at 04:21:47PM +0200, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
> > Em Fri, Sep 04, 2015 at 10:06:28PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Hi Ingo,
> > >
> > > Please consider pulling, this is on top of the previous pull request,
> > > perf-core-for-mingo.
> >
> > Ingo, please do not pull this 'perf-core-for-mingo-2' tag, there were
> > some misunderstandings about the acks for "Move sw clock metrics
> > printout to stat-shadow" and Jiri and Andi are working that out.
> >
> > I'll remove those patches and get a new perf-core-for-mingo-2
> > tag in place, before continuing today's batch, which possibly will be
> > available as 'perf-core-for-mingo-3'
> >
> > What is in 'perf-core-for-mingo" should be Ok.
>
> Ok!
Thanks! I have already removed that problematic changeset and resigned
the 'perf-core-for-mingo-2' tag, same contents modulo that cset.
- Arnaldo
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-09-08 14:09 ` Arnaldo Carvalho de Melo
@ 2015-09-08 14:21 ` Ingo Molnar
2015-09-08 14:30 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 57+ messages in thread
From: Ingo Molnar @ 2015-09-08 14:21 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Jan Stancek, Jiri Olsa, Kan Liang, Matt Fleming, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Raphael Beamonte,
Stephane Eranian, Steven Rostedt
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Em Fri, Sep 04, 2015 at 10:06:28PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Hi Ingo,
> >
> > Please consider pulling, this is on top of the previous pull request,
> > perf-core-for-mingo.
>
> Ingo, please do not pull this 'perf-core-for-mingo-2' tag, there were
> some misunderstandings about the acks for "Move sw clock metrics
> printout to stat-shadow" and Jiri and Andi are working that out.
>
> I'll remove those patches and get a new perf-core-for-mingo-2
> tag in place, before continuing today's batch, which possibly will be
> available as 'perf-core-for-mingo-3'
>
> What is in 'perf-core-for-mingo" should be Ok.
Ok!
Thanks,
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-09-05 1:06 Arnaldo Carvalho de Melo
@ 2015-09-08 14:09 ` Arnaldo Carvalho de Melo
2015-09-08 14:21 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-08 14:09 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, linux-kernel, Adrian Hunter, Andi Kleen,
Corey Ashford, David Ahern, Frederic Weisbecker, Jan Stancek,
Jiri Olsa, Kan Liang, Matt Fleming, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Raphael Beamonte, Stephane Eranian,
Steven Rostedt
Em Fri, Sep 04, 2015 at 10:06:28PM -0300, Arnaldo Carvalho de Melo escreveu:
> Hi Ingo,
>
> Please consider pulling, this is on top of the previous pull request,
> perf-core-for-mingo.
Ingo, please do not pull this 'perf-core-for-mingo-2' tag, there were
some misunderstandings about the acks for "Move sw clock metrics
printout to stat-shadow" and Jiri and Andi are working that out.
I'll remove those patches and get a new perf-core-for-mingo-2
tag in place, before continuing today's batch, which possibly will be
available as 'perf-core-for-mingo-3'
What is in 'perf-core-for-mingo" should be Ok.
- Arnaldo
> - Arnaldo
>
> The following changes since commit cf2f33a4e54096f90652cca3511fd6a456ea5abe:
>
> perf trace: Add read/write to the file group (2015-09-04 13:22:06 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
>
> for you to fetch changes up to 0959e527b1593e662cb99639a587eac39ea1232d:
>
> perf stat: Move sw clock metrics printout to stat-shadow (2015-09-04 20:30:01 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Add 'socket' sort entry, to sort by the processor socket in
> 'perf top' and 'perf report' (Kan Liang)
>
> - Introduce --socket-filter to 'perf report', for filtering by
> processor socket (Kan Liang)
>
> - Add new "Zoom into Processor Socket" operation in the perf hists browser,
> used in 'perf top' and 'perf report' (Kan Liang)
>
> Infrastructure:
>
> - 'perf test' fixes for the object code reading entry (Jan Stancek)
>
> - Add processor socket and cpu topology 'perf test' entries (Kan Liang)
>
> - Move sw clock metrics printout to stat-shadow (Andi Kleen)
>
> - Switch to tracing_patch interface (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf stat: Move sw clock metrics printout to stat-shadow
>
> Jan Stancek (4):
> perf tests: Take into account address of each objdump line
> perf tests: Make objdump disassemble zero blocks
> perf tests: Stop reading if objdump output crossed sections
> perf tests: Print objdump/dso buffers if they don't match
>
> Jiri Olsa (4):
> tools lib api fs: Make tracing_path_strerror_open message generic
> tools lib api fs: Replace debugfs/tracefs objects interface with fs.c
> tools lib api fs: Remove debugfs, tracefs and findfs objects
> perf tools: Switch to tracing_path interface on appropriate places
>
> Kan Liang (6):
> perf test: Add entry to test cpu topology
> perf tools: Add processor socket info to hist_entry and addr_location
> perf tools: Introduce new sort type "socket" for the processor socket
> perf report: Introduce --socket-filter option
> perf hists browser: Zoom in/out for processor socket
> perf test: Add entry for hists socket filter
>
> tools/lib/api/fs/Build | 3 -
> tools/lib/api/fs/debugfs.c | 77 -------------------
> tools/lib/api/fs/debugfs.h | 23 ------
> tools/lib/api/fs/findfs.c | 63 ----------------
> tools/lib/api/fs/findfs.h | 23 ------
> tools/lib/api/fs/fs.c | 1 -
> tools/lib/api/fs/tracefs.c | 78 -------------------
> tools/lib/api/fs/tracefs.h | 21 ------
> tools/lib/api/fs/tracing_path.c | 35 +++++----
> tools/perf/Documentation/perf-report.txt | 6 +-
> tools/perf/builtin-kvm.c | 1 -
> tools/perf/builtin-probe.c | 1 -
> tools/perf/builtin-report.c | 15 ++++
> tools/perf/builtin-stat.c | 9 ---
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 4 +
> tools/perf/tests/code-reading.c | 74 +++++++++++++++----
> tools/perf/tests/hists_filter.c | 55 +++++++++++---
> tools/perf/tests/openat-syscall-all-cpus.c | 10 +--
> tools/perf/tests/openat-syscall.c | 10 +--
> tools/perf/tests/parse-events.c | 19 +----
> tools/perf/tests/tests.h | 1 +
> tools/perf/tests/topology.c | 115 +++++++++++++++++++++++++++++
> tools/perf/ui/browsers/hists.c | 59 ++++++++++++++-
> tools/perf/util/event.c | 1 +
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/hist.c | 37 ++++++++++
> tools/perf/util/hist.h | 6 +-
> tools/perf/util/probe-event.c | 5 +-
> tools/perf/util/probe-file.c | 15 +---
> tools/perf/util/sort.c | 22 ++++++
> tools/perf/util/sort.h | 2 +
> tools/perf/util/stat-shadow.c | 3 +
> tools/perf/util/symbol.h | 1 +
> tools/perf/util/util.h | 3 +-
> 35 files changed, 409 insertions(+), 392 deletions(-)
> delete mode 100644 tools/lib/api/fs/debugfs.c
> delete mode 100644 tools/lib/api/fs/debugfs.h
> delete mode 100644 tools/lib/api/fs/findfs.c
> delete mode 100644 tools/lib/api/fs/findfs.h
> delete mode 100644 tools/lib/api/fs/tracefs.c
> delete mode 100644 tools/lib/api/fs/tracefs.h
> create mode 100644 tools/perf/tests/topology.c
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2015-09-05 1:06 Arnaldo Carvalho de Melo
2015-09-08 14:09 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-05 1:06 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Jan Stancek, Jiri Olsa, Kan Liang, Matt Fleming, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Raphael Beamonte,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, this is on top of the previous pull request,
perf-core-for-mingo.
- Arnaldo
The following changes since commit cf2f33a4e54096f90652cca3511fd6a456ea5abe:
perf trace: Add read/write to the file group (2015-09-04 13:22:06 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
for you to fetch changes up to 0959e527b1593e662cb99639a587eac39ea1232d:
perf stat: Move sw clock metrics printout to stat-shadow (2015-09-04 20:30:01 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Add 'socket' sort entry, to sort by the processor socket in
'perf top' and 'perf report' (Kan Liang)
- Introduce --socket-filter to 'perf report', for filtering by
processor socket (Kan Liang)
- Add new "Zoom into Processor Socket" operation in the perf hists browser,
used in 'perf top' and 'perf report' (Kan Liang)
Infrastructure:
- 'perf test' fixes for the object code reading entry (Jan Stancek)
- Add processor socket and cpu topology 'perf test' entries (Kan Liang)
- Move sw clock metrics printout to stat-shadow (Andi Kleen)
- Switch to tracing_patch interface (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf stat: Move sw clock metrics printout to stat-shadow
Jan Stancek (4):
perf tests: Take into account address of each objdump line
perf tests: Make objdump disassemble zero blocks
perf tests: Stop reading if objdump output crossed sections
perf tests: Print objdump/dso buffers if they don't match
Jiri Olsa (4):
tools lib api fs: Make tracing_path_strerror_open message generic
tools lib api fs: Replace debugfs/tracefs objects interface with fs.c
tools lib api fs: Remove debugfs, tracefs and findfs objects
perf tools: Switch to tracing_path interface on appropriate places
Kan Liang (6):
perf test: Add entry to test cpu topology
perf tools: Add processor socket info to hist_entry and addr_location
perf tools: Introduce new sort type "socket" for the processor socket
perf report: Introduce --socket-filter option
perf hists browser: Zoom in/out for processor socket
perf test: Add entry for hists socket filter
tools/lib/api/fs/Build | 3 -
tools/lib/api/fs/debugfs.c | 77 -------------------
tools/lib/api/fs/debugfs.h | 23 ------
tools/lib/api/fs/findfs.c | 63 ----------------
tools/lib/api/fs/findfs.h | 23 ------
tools/lib/api/fs/fs.c | 1 -
tools/lib/api/fs/tracefs.c | 78 -------------------
tools/lib/api/fs/tracefs.h | 21 ------
tools/lib/api/fs/tracing_path.c | 35 +++++----
tools/perf/Documentation/perf-report.txt | 6 +-
tools/perf/builtin-kvm.c | 1 -
tools/perf/builtin-probe.c | 1 -
tools/perf/builtin-report.c | 15 ++++
tools/perf/builtin-stat.c | 9 ---
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/code-reading.c | 74 +++++++++++++++----
tools/perf/tests/hists_filter.c | 55 +++++++++++---
tools/perf/tests/openat-syscall-all-cpus.c | 10 +--
tools/perf/tests/openat-syscall.c | 10 +--
tools/perf/tests/parse-events.c | 19 +----
tools/perf/tests/tests.h | 1 +
tools/perf/tests/topology.c | 115 +++++++++++++++++++++++++++++
tools/perf/ui/browsers/hists.c | 59 ++++++++++++++-
tools/perf/util/event.c | 1 +
tools/perf/util/evsel.c | 2 +-
tools/perf/util/hist.c | 37 ++++++++++
tools/perf/util/hist.h | 6 +-
tools/perf/util/probe-event.c | 5 +-
tools/perf/util/probe-file.c | 15 +---
tools/perf/util/sort.c | 22 ++++++
tools/perf/util/sort.h | 2 +
tools/perf/util/stat-shadow.c | 3 +
tools/perf/util/symbol.h | 1 +
tools/perf/util/util.h | 3 +-
35 files changed, 409 insertions(+), 392 deletions(-)
delete mode 100644 tools/lib/api/fs/debugfs.c
delete mode 100644 tools/lib/api/fs/debugfs.h
delete mode 100644 tools/lib/api/fs/findfs.c
delete mode 100644 tools/lib/api/fs/findfs.h
delete mode 100644 tools/lib/api/fs/tracefs.c
delete mode 100644 tools/lib/api/fs/tracefs.h
create mode 100644 tools/perf/tests/topology.c
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-06-08 14:17 Arnaldo Carvalho de Melo
@ 2015-06-09 9:47 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2015-06-09 9:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern, He Kuang,
Jiri Olsa, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling, more to come,
>
> - Arnaldo
>
> The following changes since commit a3d86542de8850be52e8589da22b24002941dfb7:
>
> perf/x86/intel/pebs: Add PEBSv3 decoding (2015-06-07 16:09:16 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to d3a7c489c7fd2463e3b2c3a2179c7be879dd9cb4:
>
> perf tools: Reference count struct dso (2015-06-08 10:31:40 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix perf.data size reporting in 'perf record' in no-buildid mode (He Kuang)
>
> Infrastructure:
>
> - Protect accesses the dso rbtrees/lists with a rw lock and reference
> count struct dso instances (Arnaldo Carvalho de Melo)
>
> - Export dynamic symbols used by traceevent plugins (He Kuang)
>
> - Add libtrace-dynamic-list file to libtraceevent's .gitignore (He Kuang)
>
> - Refactor shadow stats code in 'perf stat', prep work for further
> patchkits (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf machine: Fix up some more method names
> perf tools: Protect accesses the dso rbtrees/lists with a rw lock
> perf tools: Reference count struct dso
>
> He Kuang (3):
> tools lib traceevent: Export dynamic symbols used by traceevent plugins
> tools lib traceevent: Ignore libtrace-dynamic-list file
> perf record: Fix perf.data size in no-buildid mode
>
> Jiri Olsa (9):
> perf stat: Add id into perf_stat struct
> perf stat: Replace transaction event possition check with id check
> perf stat: Remove setup_events function
> perf stat: Remove transaction_run from shadow update/print code
> perf stat: Introduce reset_shadow_stats function
> perf stat: Introduce print_shadow_stats function
> perf stat: Add output file argument to print_shadow_stats function
> perf stat: Add aggr_mode argument to print_shadow_stats function
> perf stat: Move shadow stat counters into separate object
>
> tools/lib/traceevent/.gitignore | 1 +
> tools/lib/traceevent/Makefile | 14 +-
> tools/perf/Makefile.perf | 14 +-
> tools/perf/builtin-record.c | 6 +-
> tools/perf/builtin-stat.c | 506 ++--------------------------------------
> tools/perf/tests/dso-data.c | 4 +-
> tools/perf/tests/hists_common.c | 6 +-
> tools/perf/util/Build | 1 +
> tools/perf/util/dso.c | 87 +++++--
> tools/perf/util/dso.h | 24 +-
> tools/perf/util/header.c | 1 +
> tools/perf/util/machine.c | 58 +++--
> tools/perf/util/machine.h | 4 +-
> tools/perf/util/map.c | 11 +-
> tools/perf/util/probe-event.c | 2 +-
> tools/perf/util/probe-finder.c | 2 +-
> tools/perf/util/stat-shadow.c | 434 ++++++++++++++++++++++++++++++++++
> tools/perf/util/stat.c | 35 ++-
> tools/perf/util/stat.h | 40 ++++
> tools/perf/util/symbol-elf.c | 2 +-
> tools/perf/util/symbol.c | 4 +-
> tools/perf/util/vdso.c | 54 +++--
> 22 files changed, 737 insertions(+), 573 deletions(-)
> create mode 100644 tools/perf/util/stat-shadow.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2015-06-08 14:17 Arnaldo Carvalho de Melo
2015-06-09 9:47 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-06-08 14:17 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, David Ahern, He Kuang, Jiri Olsa, Namhyung Kim,
Peter Zijlstra, Stephane Eranian, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, more to come,
- Arnaldo
The following changes since commit a3d86542de8850be52e8589da22b24002941dfb7:
perf/x86/intel/pebs: Add PEBSv3 decoding (2015-06-07 16:09:16 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to d3a7c489c7fd2463e3b2c3a2179c7be879dd9cb4:
perf tools: Reference count struct dso (2015-06-08 10:31:40 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix perf.data size reporting in 'perf record' in no-buildid mode (He Kuang)
Infrastructure:
- Protect accesses the dso rbtrees/lists with a rw lock and reference
count struct dso instances (Arnaldo Carvalho de Melo)
- Export dynamic symbols used by traceevent plugins (He Kuang)
- Add libtrace-dynamic-list file to libtraceevent's .gitignore (He Kuang)
- Refactor shadow stats code in 'perf stat', prep work for further
patchkits (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf machine: Fix up some more method names
perf tools: Protect accesses the dso rbtrees/lists with a rw lock
perf tools: Reference count struct dso
He Kuang (3):
tools lib traceevent: Export dynamic symbols used by traceevent plugins
tools lib traceevent: Ignore libtrace-dynamic-list file
perf record: Fix perf.data size in no-buildid mode
Jiri Olsa (9):
perf stat: Add id into perf_stat struct
perf stat: Replace transaction event possition check with id check
perf stat: Remove setup_events function
perf stat: Remove transaction_run from shadow update/print code
perf stat: Introduce reset_shadow_stats function
perf stat: Introduce print_shadow_stats function
perf stat: Add output file argument to print_shadow_stats function
perf stat: Add aggr_mode argument to print_shadow_stats function
perf stat: Move shadow stat counters into separate object
tools/lib/traceevent/.gitignore | 1 +
tools/lib/traceevent/Makefile | 14 +-
tools/perf/Makefile.perf | 14 +-
tools/perf/builtin-record.c | 6 +-
tools/perf/builtin-stat.c | 506 ++--------------------------------------
tools/perf/tests/dso-data.c | 4 +-
tools/perf/tests/hists_common.c | 6 +-
tools/perf/util/Build | 1 +
tools/perf/util/dso.c | 87 +++++--
tools/perf/util/dso.h | 24 +-
tools/perf/util/header.c | 1 +
tools/perf/util/machine.c | 58 +++--
tools/perf/util/machine.h | 4 +-
tools/perf/util/map.c | 11 +-
tools/perf/util/probe-event.c | 2 +-
tools/perf/util/probe-finder.c | 2 +-
tools/perf/util/stat-shadow.c | 434 ++++++++++++++++++++++++++++++++++
tools/perf/util/stat.c | 35 ++-
tools/perf/util/stat.h | 40 ++++
tools/perf/util/symbol-elf.c | 2 +-
tools/perf/util/symbol.c | 4 +-
tools/perf/util/vdso.c | 54 +++--
22 files changed, 737 insertions(+), 573 deletions(-)
create mode 100644 tools/perf/util/stat-shadow.c
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2015-04-02 22:28 Arnaldo Carvalho de Melo
@ 2015-04-03 5:02 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2015-04-03 5:02 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, David Ahern,
Don Zickus, Frederic Weisbecker, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Wang Nan, Yunlong Song, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit e1abf2cc8d5d80b41c4419368ec743ccadbb131e:
>
> bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable (2015-04-02 16:28:06 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to bd05954bfa17f03a7bd4454178ba09786b35e383:
>
> perf data: Support using -f to override perf.data file ownership for 'convert' (2015-04-02 13:18:52 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Support unnamed union/structure members data collection in 'perf probe' (Masami Hiramatsu)
>
> - Support missing -f to override perf.data file ownership (Yunlong Song)
>
> Infrastructure:
>
> - No need to lookup thread twice when processing samples in 'perf script' (Arnaldo Carvalho de Melo)
>
> - No need to pass thread twice to the scripting callbacks (Arnaldo Carvalho de Melo)
>
> - No need to pass thread twice to the db-export facility (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> perf script: No need to lookup thread twice
> perf scripting: No need to pass thread twice to the scripting callbacks
> perf db-export: No need to pass thread twice to db_export__sample
> perf db-export: No need to have ->thread twice in struct export_sample
>
> Masami Hiramatsu (1):
> perf probe: Fix to track down unnamed union/structure members
>
> Yunlong Song (10):
> perf evlist: Support using -f to override perf.data file ownership
> perf inject: Support using -f to override perf.data file ownership
> perf kmem: Support using -f to override perf.data file ownership
> perf kvm: Support using -f to override perf.data.guest file ownership
> perf lock: Support using -f to override perf.data file ownership
> perf mem: Support using -f to override perf.data file ownership
> perf script: Support using -f to override perf.data file ownership
> perf timechart: Support using -f to override perf.data file ownership
> perf trace: Support using -f to override perf.data file ownership
> perf data: Support using -f to override perf.data file ownership for 'convert'
>
> tools/perf/builtin-data.c | 4 +++-
> tools/perf/builtin-evlist.c | 2 ++
> tools/perf/builtin-inject.c | 1 +
> tools/perf/builtin-kmem.c | 9 +++++----
> tools/perf/builtin-kvm.c | 2 ++
> tools/perf/builtin-lock.c | 5 +++++
> tools/perf/builtin-mem.c | 3 +++
> tools/perf/builtin-script.c | 23 ++++++++--------------
> tools/perf/builtin-timechart.c | 3 +++
> tools/perf/builtin-trace.c | 3 +++
> tools/perf/util/data-convert-bt.c | 3 ++-
> tools/perf/util/data-convert-bt.h | 2 +-
> tools/perf/util/db-export.c | 4 ++--
> tools/perf/util/db-export.h | 3 +--
> tools/perf/util/dwarf-aux.c | 14 +++++++++----
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/kvm-stat.h | 1 +
> tools/perf/util/probe-finder.c | 8 +++++++-
> .../perf/util/scripting-engines/trace-event-perl.c | 5 ++---
> .../util/scripting-engines/trace-event-python.c | 16 ++++++---------
> tools/perf/util/trace-event-scripting.c | 1 -
> tools/perf/util/trace-event.h | 3 +--
> 22 files changed, 69 insertions(+), 47 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2015-04-02 22:28 Arnaldo Carvalho de Melo
2015-04-03 5:02 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-04-02 22:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Borislav Petkov, David Ahern, Don Zickus, Frederic Weisbecker,
Jiri Olsa, Masami Hiramatsu, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Wang Nan, Yunlong Song,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit e1abf2cc8d5d80b41c4419368ec743ccadbb131e:
bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable (2015-04-02 16:28:06 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to bd05954bfa17f03a7bd4454178ba09786b35e383:
perf data: Support using -f to override perf.data file ownership for 'convert' (2015-04-02 13:18:52 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Support unnamed union/structure members data collection in 'perf probe' (Masami Hiramatsu)
- Support missing -f to override perf.data file ownership (Yunlong Song)
Infrastructure:
- No need to lookup thread twice when processing samples in 'perf script' (Arnaldo Carvalho de Melo)
- No need to pass thread twice to the scripting callbacks (Arnaldo Carvalho de Melo)
- No need to pass thread twice to the db-export facility (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf script: No need to lookup thread twice
perf scripting: No need to pass thread twice to the scripting callbacks
perf db-export: No need to pass thread twice to db_export__sample
perf db-export: No need to have ->thread twice in struct export_sample
Masami Hiramatsu (1):
perf probe: Fix to track down unnamed union/structure members
Yunlong Song (10):
perf evlist: Support using -f to override perf.data file ownership
perf inject: Support using -f to override perf.data file ownership
perf kmem: Support using -f to override perf.data file ownership
perf kvm: Support using -f to override perf.data.guest file ownership
perf lock: Support using -f to override perf.data file ownership
perf mem: Support using -f to override perf.data file ownership
perf script: Support using -f to override perf.data file ownership
perf timechart: Support using -f to override perf.data file ownership
perf trace: Support using -f to override perf.data file ownership
perf data: Support using -f to override perf.data file ownership for 'convert'
tools/perf/builtin-data.c | 4 +++-
tools/perf/builtin-evlist.c | 2 ++
tools/perf/builtin-inject.c | 1 +
tools/perf/builtin-kmem.c | 9 +++++----
tools/perf/builtin-kvm.c | 2 ++
tools/perf/builtin-lock.c | 5 +++++
tools/perf/builtin-mem.c | 3 +++
tools/perf/builtin-script.c | 23 ++++++++--------------
tools/perf/builtin-timechart.c | 3 +++
tools/perf/builtin-trace.c | 3 +++
tools/perf/util/data-convert-bt.c | 3 ++-
tools/perf/util/data-convert-bt.h | 2 +-
tools/perf/util/db-export.c | 4 ++--
tools/perf/util/db-export.h | 3 +--
tools/perf/util/dwarf-aux.c | 14 +++++++++----
tools/perf/util/evsel.h | 1 +
tools/perf/util/kvm-stat.h | 1 +
tools/perf/util/probe-finder.c | 8 +++++++-
.../perf/util/scripting-engines/trace-event-perl.c | 5 ++---
.../util/scripting-engines/trace-event-python.c | 16 ++++++---------
tools/perf/util/trace-event-scripting.c | 1 -
tools/perf/util/trace-event.h | 3 +--
22 files changed, 69 insertions(+), 47 deletions(-)
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2014-10-15 20:52 Arnaldo Carvalho de Melo
@ 2014-10-16 5:18 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2014-10-16 5:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Alexander Yarygin, Andi Kleen, Anshuman Khandual,
Arun Sharma, Christian Borntraeger, Cody P Schafer, David Ahern,
Frederic Weisbecker, Haren Myneni, Jean Pihet, Jiri Olsa,
Kan Liang, linuxppc-dev, Masanari Iida, Michael Ellerman,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Randy Dunlap, Stephane Eranian, Sukadev Bhattiprolu, Taeung Song,
Yasser Shalabi, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling, I guess the changes are minor of affect just some
> non-core feature, so it is you call if you prefer to pull it into perf/urgent instead.
>
> Best Regards,
>
> - Arnaldo
>
> The following changes since commit ec4212d88a77eb6caec10777ddd629b702a5ebbd:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-10-15 11:54:14 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 673d659f5c5918b7ddbafebf1f129c9eb82973b4:
>
> perf kvm stat live: Enable events copying (2014-10-15 17:39:03 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> * Add a visual cue for toggle zeroing of samples in 'perf top' (Taeung Song)
>
> * Fix for double free in 'perf stat' when using some specific invalid
> command line combo (Yasser Shalabi)
>
> Infrastructure:
>
> * Add option to copy events when queuing for sorting across cpu buffers
> and enable it for 'perf kvm stat live', to avoid having events left
> in the queue pointing to the ring buffer be rewritten in high volume
> sessions. (Alexander Yarygin, improving work done by David Ahern):
>
> * Document sysfs events/ interfaces (Cody P Schafer)
>
> * Add support to new style format of kernel PMU event. (Kan Liang)
>
> * Fix typos in perf/Documentation (Masanari Iida)
>
> * Improve callchains when using libunwind (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Lines starting with '#' will be ignored.
>
> ----------------------------------------------------------------
> Alexander Yarygin (2):
> perf session: Add option to copy events when queueing
> perf kvm stat live: Enable events copying
>
> Cody P Schafer (2):
> perf Documentation: sysfs events/ interfaces
> perf Documentation: Remove Ruplicated docs for powerpc cpu specific events
>
> Kan Liang (4):
> Revert "perf tools: Default to cpu// for events v5"
> perf tools: Parse the pmu event prefix and suffix
> perf tools: Add support to new style format of kernel PMU event
> perf test: Add test case for pmu event new style format
>
> Masanari Iida (1):
> perf Documentation: Fix typos in perf/Documentation
>
> Namhyung Kim (4):
> perf report: Set callchain_param.record_mode for future use
> perf callchain: Create an address space per thread
> perf kvm: Use thread_{,_set}_priv helpers
> perf trace: Use thread_{,_set}_priv helpers
>
> Taeung Song (1):
> perf top: Add a visual cue for toggle zeroing of samples
>
> Yasser Shalabi (1):
> perf evlist: Fix for double free in tools/perf stat
>
> .../testing/sysfs-bus-event_source-devices-events | 611 ++-------------------
> tools/perf/Documentation/perf-diff.txt | 6 +-
> tools/perf/Documentation/perf-kvm.txt | 4 +-
> tools/perf/Documentation/perf-list.txt | 2 +-
> tools/perf/Documentation/perf-record.txt | 2 +-
> tools/perf/Documentation/perf-script-perl.txt | 4 +-
> tools/perf/Documentation/perf-script-python.txt | 6 +-
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/Documentation/perf-test.txt | 2 +-
> tools/perf/Documentation/perf-trace.txt | 2 +-
> tools/perf/builtin-kvm.c | 7 +-
> tools/perf/builtin-report.c | 7 +
> tools/perf/builtin-trace.c | 16 +-
> tools/perf/tests/dwarf-unwind.c | 3 +
> tools/perf/tests/parse-events.c | 36 ++
> tools/perf/ui/browsers/hists.c | 32 +-
> tools/perf/util/evlist.c | 1 +
> tools/perf/util/include/linux/string.h | 1 -
> tools/perf/util/ordered-events.c | 49 +-
> tools/perf/util/ordered-events.h | 10 +-
> tools/perf/util/parse-events.c | 133 ++++-
> tools/perf/util/parse-events.h | 14 +
> tools/perf/util/parse-events.l | 30 +-
> tools/perf/util/parse-events.y | 40 ++
> tools/perf/util/pmu.c | 10 -
> tools/perf/util/pmu.h | 10 +
> tools/perf/util/session.c | 5 +-
> tools/perf/util/string.c | 24 -
> tools/perf/util/thread.c | 6 +
> tools/perf/util/unwind-libunwind.c | 37 +-
> tools/perf/util/unwind.h | 17 +
> 31 files changed, 460 insertions(+), 669 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2014-10-15 20:52 Arnaldo Carvalho de Melo
2014-10-16 5:18 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-10-15 20:52 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Alexander Yarygin,
Andi Kleen, Anshuman Khandual, Arun Sharma,
Christian Borntraeger, Cody P Schafer, David Ahern,
Frederic Weisbecker, Haren Myneni, Jean Pihet, Jiri Olsa,
Kan Liang, linuxppc-dev, Masanari Iida, Michael Ellerman,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Randy Dunlap, Stephane Eranian, Sukadev Bhattiprolu, Taeung Song,
Yasser Shalabi, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, I guess the changes are minor of affect just some
non-core feature, so it is you call if you prefer to pull it into perf/urgent instead.
Best Regards,
- Arnaldo
The following changes since commit ec4212d88a77eb6caec10777ddd629b702a5ebbd:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-10-15 11:54:14 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 673d659f5c5918b7ddbafebf1f129c9eb82973b4:
perf kvm stat live: Enable events copying (2014-10-15 17:39:03 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
* Add a visual cue for toggle zeroing of samples in 'perf top' (Taeung Song)
* Fix for double free in 'perf stat' when using some specific invalid
command line combo (Yasser Shalabi)
Infrastructure:
* Add option to copy events when queuing for sorting across cpu buffers
and enable it for 'perf kvm stat live', to avoid having events left
in the queue pointing to the ring buffer be rewritten in high volume
sessions. (Alexander Yarygin, improving work done by David Ahern):
* Document sysfs events/ interfaces (Cody P Schafer)
* Add support to new style format of kernel PMU event. (Kan Liang)
* Fix typos in perf/Documentation (Masanari Iida)
* Improve callchains when using libunwind (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Lines starting with '#' will be ignored.
----------------------------------------------------------------
Alexander Yarygin (2):
perf session: Add option to copy events when queueing
perf kvm stat live: Enable events copying
Cody P Schafer (2):
perf Documentation: sysfs events/ interfaces
perf Documentation: Remove Ruplicated docs for powerpc cpu specific events
Kan Liang (4):
Revert "perf tools: Default to cpu// for events v5"
perf tools: Parse the pmu event prefix and suffix
perf tools: Add support to new style format of kernel PMU event
perf test: Add test case for pmu event new style format
Masanari Iida (1):
perf Documentation: Fix typos in perf/Documentation
Namhyung Kim (4):
perf report: Set callchain_param.record_mode for future use
perf callchain: Create an address space per thread
perf kvm: Use thread_{,_set}_priv helpers
perf trace: Use thread_{,_set}_priv helpers
Taeung Song (1):
perf top: Add a visual cue for toggle zeroing of samples
Yasser Shalabi (1):
perf evlist: Fix for double free in tools/perf stat
.../testing/sysfs-bus-event_source-devices-events | 611 ++-------------------
tools/perf/Documentation/perf-diff.txt | 6 +-
tools/perf/Documentation/perf-kvm.txt | 4 +-
tools/perf/Documentation/perf-list.txt | 2 +-
tools/perf/Documentation/perf-record.txt | 2 +-
tools/perf/Documentation/perf-script-perl.txt | 4 +-
tools/perf/Documentation/perf-script-python.txt | 6 +-
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/Documentation/perf-test.txt | 2 +-
tools/perf/Documentation/perf-trace.txt | 2 +-
tools/perf/builtin-kvm.c | 7 +-
tools/perf/builtin-report.c | 7 +
tools/perf/builtin-trace.c | 16 +-
tools/perf/tests/dwarf-unwind.c | 3 +
tools/perf/tests/parse-events.c | 36 ++
tools/perf/ui/browsers/hists.c | 32 +-
tools/perf/util/evlist.c | 1 +
tools/perf/util/include/linux/string.h | 1 -
tools/perf/util/ordered-events.c | 49 +-
tools/perf/util/ordered-events.h | 10 +-
tools/perf/util/parse-events.c | 133 ++++-
tools/perf/util/parse-events.h | 14 +
tools/perf/util/parse-events.l | 30 +-
tools/perf/util/parse-events.y | 40 ++
tools/perf/util/pmu.c | 10 -
tools/perf/util/pmu.h | 10 +
tools/perf/util/session.c | 5 +-
tools/perf/util/string.c | 24 -
tools/perf/util/thread.c | 6 +
tools/perf/util/unwind-libunwind.c | 37 +-
tools/perf/util/unwind.h | 17 +
31 files changed, 460 insertions(+), 669 deletions(-)
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2014-06-09 20:02 Jiri Olsa
@ 2014-06-12 11:54 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2014-06-12 11:54 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Andi Kleen, Arnaldo Carvalho de Melo,
Corey Ashford, David Ahern, Don Zickus, Frederic Weisbecker,
Javi Merino, Jean Pihet, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt
* Jiri Olsa <jolsa@kernel.org> wrote:
>
> hi Ingo,
> please consider pulling
>
> thanks,
> jirka
>
>
> The following changes since commit 82b897782d10fcc4930c9d4a15b175348fdd2871:
>
> perf: Differentiate exec() and non-exec() comm events (2014-06-06 07:56:22 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
>
> for you to fetch changes up to a2609f3b0c582d6aaa8f69a61a0eea6c7a98d291:
>
> perf tools: Support spark lines in perf stat (2014-06-09 13:34:50 +0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Bitmask handling and plugin updates (Steven Rostedt)
>
> . Fix pipe check regression in attr event callback (Jiri Olsa)
>
> . Prettify the tags/TAGS/cscope targets output (Jiri Olsa)
>
> . Print array argument as string (Namhyung Kim)
>
> . Pass protection and flags bits through mmap2 interface (Peter Zijlstra)
>
> . Update perf tool mmap2 interface with protection and flag bits (Don Zickus)
>
> . Re-enable mmap interface (Don Zickus)
>
> . Add mem-mode documentation to report command (Don Zickus)
>
> . Add sort on dcacheline (Don Zickus)
>
> . Support spark lines in perf stat (Andi Kleen)
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf tools: Support spark lines in perf stat
>
> Don Zickus (6):
> perf tools: Update mmap2 interface with protection and flag bits
> Revert "perf: Disable PERF_RECORD_MMAP2 support"
> perf report: Add mem-mode documentation to report command
> perf tools: Add cpumode to struct hist_entry
> perf tools: Add support to dynamically get cacheline size
> perf tools: Add dcacheline sort
>
> Jiri Olsa (2):
> perf tools: Fix pipe check regression in attr event callback
> perf tools: Prettify the tags/TAGS/cscope targets output
>
> Namhyung Kim (1):
> perf script/python: Print array argument as string
>
> Peter Zijlstra (1):
> perf: Pass protection and flags bits through mmap2 interface
>
> Steven Rostedt (1):
> tools lib traceevent: Add options to plugins
>
> Steven Rostedt (Red Hat) (3):
> tools lib traceevent: Add flag to not load event plugins
> tools lib traceevent: Add options to function plugin
> tools lib traceevent: Added support for __get_bitmask() macro
>
> include/uapi/linux/perf_event.h | 1 +
> kernel/events/core.c | 37 +++-
> tools/lib/traceevent/event-parse.c | 113 ++++++++++++
> tools/lib/traceevent/event-parse.h | 25 ++-
> tools/lib/traceevent/event-plugin.c | 203 ++++++++++++++++++++-
> tools/lib/traceevent/plugin_function.c | 43 ++++-
> tools/perf/Documentation/perf-report.txt | 23 +++
> tools/perf/Documentation/perf-stat.txt | 4 +
> tools/perf/Makefile.perf | 7 +-
> tools/perf/builtin-inject.c | 2 +-
> tools/perf/builtin-stat.c | 12 ++
> tools/perf/perf.c | 1 +
> tools/perf/tests/dwarf-unwind.c | 2 +-
> tools/perf/util/event.c | 57 ++++--
> tools/perf/util/event.h | 2 +
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/hist.c | 9 +-
> tools/perf/util/hist.h | 1 +
> tools/perf/util/machine.c | 4 +-
> tools/perf/util/map.c | 4 +-
> tools/perf/util/map.h | 4 +-
> .../perf/util/scripting-engines/trace-event-perl.c | 1 +
> .../util/scripting-engines/trace-event-python.c | 2 +
> tools/perf/util/sort.c | 107 +++++++++++
> tools/perf/util/sort.h | 2 +
> tools/perf/util/spark.c | 31 ++++
> tools/perf/util/spark.h | 4 +
> tools/perf/util/stat.c | 34 ++++
> tools/perf/util/stat.h | 10 +
> tools/perf/util/util.c | 1 +
> tools/perf/util/util.h | 1 +
> 31 files changed, 707 insertions(+), 41 deletions(-)
> create mode 100644 tools/perf/util/spark.c
> create mode 100644 tools/perf/util/spark.h
Pulled, thanks a lot Jiri!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2014-06-09 20:02 Jiri Olsa
2014-06-12 11:54 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Jiri Olsa @ 2014-06-09 20:02 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Andi Kleen, Arnaldo Carvalho de Melo,
Corey Ashford, David Ahern, Don Zickus, Frederic Weisbecker,
Javi Merino, Jean Pihet, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 82b897782d10fcc4930c9d4a15b175348fdd2871:
perf: Differentiate exec() and non-exec() comm events (2014-06-06 07:56:22 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to a2609f3b0c582d6aaa8f69a61a0eea6c7a98d291:
perf tools: Support spark lines in perf stat (2014-06-09 13:34:50 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Bitmask handling and plugin updates (Steven Rostedt)
. Fix pipe check regression in attr event callback (Jiri Olsa)
. Prettify the tags/TAGS/cscope targets output (Jiri Olsa)
. Print array argument as string (Namhyung Kim)
. Pass protection and flags bits through mmap2 interface (Peter Zijlstra)
. Update perf tool mmap2 interface with protection and flag bits (Don Zickus)
. Re-enable mmap interface (Don Zickus)
. Add mem-mode documentation to report command (Don Zickus)
. Add sort on dcacheline (Don Zickus)
. Support spark lines in perf stat (Andi Kleen)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Andi Kleen (1):
perf tools: Support spark lines in perf stat
Don Zickus (6):
perf tools: Update mmap2 interface with protection and flag bits
Revert "perf: Disable PERF_RECORD_MMAP2 support"
perf report: Add mem-mode documentation to report command
perf tools: Add cpumode to struct hist_entry
perf tools: Add support to dynamically get cacheline size
perf tools: Add dcacheline sort
Jiri Olsa (2):
perf tools: Fix pipe check regression in attr event callback
perf tools: Prettify the tags/TAGS/cscope targets output
Namhyung Kim (1):
perf script/python: Print array argument as string
Peter Zijlstra (1):
perf: Pass protection and flags bits through mmap2 interface
Steven Rostedt (1):
tools lib traceevent: Add options to plugins
Steven Rostedt (Red Hat) (3):
tools lib traceevent: Add flag to not load event plugins
tools lib traceevent: Add options to function plugin
tools lib traceevent: Added support for __get_bitmask() macro
include/uapi/linux/perf_event.h | 1 +
kernel/events/core.c | 37 +++-
tools/lib/traceevent/event-parse.c | 113 ++++++++++++
tools/lib/traceevent/event-parse.h | 25 ++-
tools/lib/traceevent/event-plugin.c | 203 ++++++++++++++++++++-
tools/lib/traceevent/plugin_function.c | 43 ++++-
tools/perf/Documentation/perf-report.txt | 23 +++
tools/perf/Documentation/perf-stat.txt | 4 +
tools/perf/Makefile.perf | 7 +-
tools/perf/builtin-inject.c | 2 +-
tools/perf/builtin-stat.c | 12 ++
tools/perf/perf.c | 1 +
tools/perf/tests/dwarf-unwind.c | 2 +-
tools/perf/util/event.c | 57 ++++--
tools/perf/util/event.h | 2 +
tools/perf/util/evsel.c | 1 +
tools/perf/util/hist.c | 9 +-
tools/perf/util/hist.h | 1 +
tools/perf/util/machine.c | 4 +-
tools/perf/util/map.c | 4 +-
tools/perf/util/map.h | 4 +-
.../perf/util/scripting-engines/trace-event-perl.c | 1 +
.../util/scripting-engines/trace-event-python.c | 2 +
tools/perf/util/sort.c | 107 +++++++++++
tools/perf/util/sort.h | 2 +
tools/perf/util/spark.c | 31 ++++
tools/perf/util/spark.h | 4 +
tools/perf/util/stat.c | 34 ++++
tools/perf/util/stat.h | 10 +
tools/perf/util/util.c | 1 +
tools/perf/util/util.h | 1 +
31 files changed, 707 insertions(+), 41 deletions(-)
create mode 100644 tools/perf/util/spark.c
create mode 100644 tools/perf/util/spark.h
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2013-08-30 18:58 Arnaldo Carvalho de Melo
@ 2013-08-31 8:08 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2013-08-31 8:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 00e4cb1ced1b17c35465defafe86d156cbd7544e:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-08-29 12:02:34 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to f2935f3e585226b8203ec3861907e1cb16ad3d6a:
>
> perf trace: Handle missing HUGEPAGE defines (2013-08-30 15:43:28 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Tidy up sample parsing validation, from Adrian Hunter.
>
> . Make events stream always parsable by adding a new sample_type bit:
> PERF_SAMPLE_IDENTIFIER, that when requested will be always aat a fixed
> position in all PERF_RECORD_ records, from Adrian Hunter.
>
> . Add a sample parsing test, from Adrian Hunter.
>
> . Add option to 'perf trace' to analyze events in a file versus live,
> so that one can do:
>
> [root@zoo ~]# perf record -a -e raw_syscalls:* sleep 1
> [ perf record: Woken up 0 times to write data ]
> [ perf record: Captured and wrote 25.150 MB perf.data (~1098836 samples) ]
> [root@zoo ~]# perf trace -i perf.data -e futex --duration 1
> 17.799 ( 1.020 ms): 7127 futex(uaddr: 0x7fff3f6c6674, op: 393, val: 1, utime: 0x7fff3f6c6470, ua
> 113.344 (95.429 ms): 7127 futex(uaddr: 0x7fff3f6c6674, op: 393, val: 1, utime: 0x7fff3f6c6470, uaddr2: 0x7fff3f6c6648, val3: 4294967
> 133.778 ( 1.042 ms): 18004 futex(uaddr: 0x7fff3f6c6674, op: 393, val: 1, utime: 0x7fff3f6c6470, uaddr2: 0x7fff3f6c6648, val3: 429496
> [root@zoo ~]#
>
> From David Ahern.
>
> . Honor target pid / tid options in 'perf trace' when analyzing a file,
> from David Ahern.
>
> . Handle missing HUGEPAGE defines in the mmap beautifier in 'perf trace',
> from David Ahern.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (11):
> perf tools: change machine__findnew_thread() to set thread pid
> perf evsel: Tidy up sample parsing overflow checking
> perf callchain: Remove unnecessary validation
> perf tools: Remove references to struct ip_event
> perf: make events stream always parsable
> perf evlist: Move perf_evlist__config() to a new source file
> perf tools: Add support for PERF_SAMPLE_IDENTIFIER
> perf tools: Add missing 'abi' member to 'struct regs_dump'
> perf tools: Expand perf_event__synthesize_sample()
> perf tools: Add a function to calculate sample event size
> perf tests: Add a sample parsing test
>
> David Ahern (4):
> perf evlist: Add tracepoint lookup by name
> perf trace: Add option to analyze events in a file versus live
> perf trace: Honor target pid / tid options when analyzing a file
> perf trace: Handle missing HUGEPAGE defines
>
> include/uapi/linux/perf_event.h | 27 ++-
> kernel/events/core.c | 11 +-
> tools/perf/Documentation/perf-trace.txt | 4 +
> tools/perf/Makefile | 2 +
> tools/perf/builtin-inject.c | 8 +-
> tools/perf/builtin-kmem.c | 3 +-
> tools/perf/builtin-kvm.c | 2 +-
> tools/perf/builtin-lock.c | 3 +-
> tools/perf/builtin-mem.c | 2 +-
> tools/perf/builtin-report.c | 2 +-
> tools/perf/builtin-sched.c | 20 +-
> tools/perf/builtin-script.c | 3 +-
> tools/perf/builtin-top.c | 11 +-
> tools/perf/builtin-trace.c | 157 ++++++++++++-
> tools/perf/tests/builtin-test.c | 4 +
> tools/perf/tests/code-reading.c | 4 +-
> tools/perf/tests/hists_link.c | 23 +-
> tools/perf/tests/mmap-basic.c | 2 +-
> tools/perf/tests/sample-parsing.c | 316 +++++++++++++++++++++++++
> tools/perf/tests/tests.h | 1 +
> tools/perf/util/build-id.c | 11 +-
> tools/perf/util/callchain.c | 8 -
> tools/perf/util/callchain.h | 5 -
> tools/perf/util/event.c | 5 +-
> tools/perf/util/event.h | 18 +-
> tools/perf/util/evlist.c | 140 +++++++++--
> tools/perf/util/evlist.h | 12 +-
> tools/perf/util/evsel.c | 405 ++++++++++++++++++++++++++++----
> tools/perf/util/evsel.h | 14 +-
> tools/perf/util/machine.c | 22 +-
> tools/perf/util/machine.h | 3 +-
> tools/perf/util/record.c | 108 +++++++++
> tools/perf/util/session.c | 32 +--
> 33 files changed, 1193 insertions(+), 195 deletions(-)
> create mode 100644 tools/perf/tests/sample-parsing.c
> create mode 100644 tools/perf/util/record.c
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2013-08-30 18:58 Arnaldo Carvalho de Melo
2013-08-31 8:08 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-08-30 18:58 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 00e4cb1ced1b17c35465defafe86d156cbd7544e:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-08-29 12:02:34 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to f2935f3e585226b8203ec3861907e1cb16ad3d6a:
perf trace: Handle missing HUGEPAGE defines (2013-08-30 15:43:28 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
. Tidy up sample parsing validation, from Adrian Hunter.
. Make events stream always parsable by adding a new sample_type bit:
PERF_SAMPLE_IDENTIFIER, that when requested will be always aat a fixed
position in all PERF_RECORD_ records, from Adrian Hunter.
. Add a sample parsing test, from Adrian Hunter.
. Add option to 'perf trace' to analyze events in a file versus live,
so that one can do:
[root@zoo ~]# perf record -a -e raw_syscalls:* sleep 1
[ perf record: Woken up 0 times to write data ]
[ perf record: Captured and wrote 25.150 MB perf.data (~1098836 samples) ]
[root@zoo ~]# perf trace -i perf.data -e futex --duration 1
17.799 ( 1.020 ms): 7127 futex(uaddr: 0x7fff3f6c6674, op: 393, val: 1, utime: 0x7fff3f6c6470, ua
113.344 (95.429 ms): 7127 futex(uaddr: 0x7fff3f6c6674, op: 393, val: 1, utime: 0x7fff3f6c6470, uaddr2: 0x7fff3f6c6648, val3: 4294967
133.778 ( 1.042 ms): 18004 futex(uaddr: 0x7fff3f6c6674, op: 393, val: 1, utime: 0x7fff3f6c6470, uaddr2: 0x7fff3f6c6648, val3: 429496
[root@zoo ~]#
From David Ahern.
. Honor target pid / tid options in 'perf trace' when analyzing a file,
from David Ahern.
. Handle missing HUGEPAGE defines in the mmap beautifier in 'perf trace',
from David Ahern.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (11):
perf tools: change machine__findnew_thread() to set thread pid
perf evsel: Tidy up sample parsing overflow checking
perf callchain: Remove unnecessary validation
perf tools: Remove references to struct ip_event
perf: make events stream always parsable
perf evlist: Move perf_evlist__config() to a new source file
perf tools: Add support for PERF_SAMPLE_IDENTIFIER
perf tools: Add missing 'abi' member to 'struct regs_dump'
perf tools: Expand perf_event__synthesize_sample()
perf tools: Add a function to calculate sample event size
perf tests: Add a sample parsing test
David Ahern (4):
perf evlist: Add tracepoint lookup by name
perf trace: Add option to analyze events in a file versus live
perf trace: Honor target pid / tid options when analyzing a file
perf trace: Handle missing HUGEPAGE defines
include/uapi/linux/perf_event.h | 27 ++-
kernel/events/core.c | 11 +-
tools/perf/Documentation/perf-trace.txt | 4 +
tools/perf/Makefile | 2 +
tools/perf/builtin-inject.c | 8 +-
tools/perf/builtin-kmem.c | 3 +-
tools/perf/builtin-kvm.c | 2 +-
tools/perf/builtin-lock.c | 3 +-
tools/perf/builtin-mem.c | 2 +-
tools/perf/builtin-report.c | 2 +-
tools/perf/builtin-sched.c | 20 +-
tools/perf/builtin-script.c | 3 +-
tools/perf/builtin-top.c | 11 +-
tools/perf/builtin-trace.c | 157 ++++++++++++-
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/code-reading.c | 4 +-
tools/perf/tests/hists_link.c | 23 +-
tools/perf/tests/mmap-basic.c | 2 +-
tools/perf/tests/sample-parsing.c | 316 +++++++++++++++++++++++++
tools/perf/tests/tests.h | 1 +
tools/perf/util/build-id.c | 11 +-
tools/perf/util/callchain.c | 8 -
tools/perf/util/callchain.h | 5 -
tools/perf/util/event.c | 5 +-
tools/perf/util/event.h | 18 +-
tools/perf/util/evlist.c | 140 +++++++++--
tools/perf/util/evlist.h | 12 +-
tools/perf/util/evsel.c | 405 ++++++++++++++++++++++++++++----
tools/perf/util/evsel.h | 14 +-
tools/perf/util/machine.c | 22 +-
tools/perf/util/machine.h | 3 +-
tools/perf/util/record.c | 108 +++++++++
tools/perf/util/session.c | 32 +--
33 files changed, 1193 insertions(+), 195 deletions(-)
create mode 100644 tools/perf/tests/sample-parsing.c
create mode 100644 tools/perf/util/record.c
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2013-02-28 21:05 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-02-28 21:05 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Borislav Petkov,
Corey Ashford, David Ahern, Feng Tang, Frederic Weisbecker,
Ingo Molnar, Ingo Molnar, Jiri Olsa, liguang, Marcin Slusarz,
Michael Ellerman, Namhyung Kim, Namhyung Kim, Oleg Nesterov,
Paul Mackerras, Pekka Enberg, Peter Zijlstra, Steven Rostedt,
Wu Fengguang, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit e259514eef764a5286873618e34c560ecb6cff13:
perf/x86/amd: Enable northbridge performance counters on AMD family 15h (2013-02-16 09:37:27 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 0e0c6670a333aa884d11799f38a435bdf4c408ed:
perf report: Fix build with NO_NEWT=1 (2013-02-28 16:51:01 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
. Honor parallel jobs, fix from Borislav Petkov
. Introduce tools/lib/lk library, initially with just debugfs handling routines
shared with tools/vm, more to come, from Borislav Petkov
. Fix handling of -C (cpus) in perf record, from Jiri Olsa
. Add perf_event_attr entries in 'perf test' to check -C handling in 'record'
and 'stat', from Jiri Olsa.
. Check if -DFORTIFY_SOURCE=2 is allowed, fix from Marcin Slusarz.
. Fix build with NO_NEWT=1, from Michael Ellerman.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Borislav Petkov (6):
perf tools: Remove a write-only variable in the debugfs code
perf tools: Honor parallel jobs
perf tools: Correct Makefile.include
perf tools: Introduce tools/lib/lk library
perf tools: Extract perf-specific stuff from debugfs.c
tools/vm: Switch to liblk library
Jiri Olsa (5):
perf tests: Make attr script verbose friendly
perf tests: Make attr script test event cpu
perf tests: Add attr record -C cpu test
perf tests: Add attr stat -C cpu test
perf record: Fix -C option
Marcin Slusarz (1):
perf tools: check if -DFORTIFY_SOURCE=2 is allowed
Michael Ellerman (2):
perf annotate: Fix build with NO_NEWT=1
perf report: Fix build with NO_NEWT=1
liguang (1):
perf tools: Sort command-list.txt alphabetically
Makefile | 4 +-
tools/Makefile | 16 ++++++-
tools/lib/lk/Makefile | 35 +++++++++++++++
tools/{perf/util => lib/lk}/debugfs.c | 49 ++++++++------------
tools/lib/lk/debugfs.h | 29 ++++++++++++
tools/perf/MANIFEST | 1 +
tools/perf/Makefile | 42 +++++++++++++----
tools/perf/builtin-kvm.c | 2 +-
tools/perf/builtin-probe.c | 2 +-
tools/perf/builtin-record.c | 6 ++-
tools/perf/command-list.txt | 14 +++---
tools/perf/perf.c | 8 ++--
tools/perf/tests/attr.c | 9 +++-
tools/perf/tests/attr.py | 5 ++-
tools/perf/tests/attr/base-record | 1 +
tools/perf/tests/attr/base-stat | 1 +
tools/perf/tests/attr/test-record-C0 | 13 ++++++
tools/perf/tests/attr/test-stat-C0 | 9 ++++
tools/perf/tests/parse-events.c | 2 +-
tools/perf/util/debugfs.h | 12 -----
tools/perf/util/evlist.c | 2 +-
tools/perf/util/evsel.c | 2 +-
tools/perf/util/hist.h | 5 ++-
tools/perf/util/parse-events.c | 2 +-
tools/perf/util/probe-event.c | 2 +-
tools/perf/util/python-ext-sources | 1 -
tools/perf/util/setup.py | 3 +-
tools/perf/util/trace-event-info.c | 4 +-
tools/perf/util/util.c | 27 +++++++++++
tools/perf/util/util.h | 7 ++-
tools/scripts/Makefile.include | 6 ++-
tools/vm/Makefile | 17 +++++--
tools/vm/page-types.c | 85 +++--------------------------------
33 files changed, 253 insertions(+), 170 deletions(-)
create mode 100644 tools/lib/lk/Makefile
rename tools/{perf/util => lib/lk}/debugfs.c (68%)
create mode 100644 tools/lib/lk/debugfs.h
create mode 100644 tools/perf/tests/attr/test-record-C0
create mode 100644 tools/perf/tests/attr/test-stat-C0
delete mode 100644 tools/perf/util/debugfs.h
^ permalink raw reply [flat|nested] 57+ messages in thread
* Re: [GIT PULL 00/15] perf/core improvements and fixes
2011-12-23 21:53 Arnaldo Carvalho de Melo
@ 2011-12-29 20:28 ` Ingo Molnar
0 siblings, 0 replies; 57+ messages in thread
From: Ingo Molnar @ 2011-12-29 20:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, David Ahern, Frederic Weisbecker, Namhyung Kim,
Nelson Elhage, Paul Mackerras, Peter Zijlstra, Robert Richter,
Stephane Eranian, arnaldo.melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling from:
>
> git://github.com/acmel/linux.git perf/core
>
> Regards,
>
> - Arnaldo
>
> David Ahern (3):
> perf tools: Fix comm for processes with named threads
> perf tools: Look up thread names for system wide profiling
> perf script: look up thread using tid instead of pid
>
> Ingo Molnar (1):
> perf tools: Fix truncated annotation
>
> Namhyung Kim (1):
> perf report: Fix usage string
>
> Nelson Elhage (2):
> perf: builtin-record: Provide advice if mmap'ing fails with EPERM.
> perf: builtin-record: Document and check that mmap_pages must be a power of two.
>
> Robert Richter (8):
> perf tools: Improve macros for struct feature_ops
> perf tools: Continue processing header on unknown features
> perf tools: Fix out-of-bound access to struct perf_session
> perf tools: Moving code in some files
> perf report: Accept fifos as input file
> perf tools: Unify handling of features when writing feature section
> perf tools: Use for_each_set_bit() to iterate over feature flags
> perf script: Add generic perl handler to process events
>
> tools/perf/Documentation/perf-annotate.txt | 2 +-
> tools/perf/Documentation/perf-buildid-list.txt | 2 +-
> tools/perf/Documentation/perf-evlist.txt | 2 +-
> tools/perf/Documentation/perf-kmem.txt | 2 +-
> tools/perf/Documentation/perf-lock.txt | 2 +-
> tools/perf/Documentation/perf-record.txt | 2 +-
> tools/perf/Documentation/perf-report.txt | 2 +-
> tools/perf/Documentation/perf-sched.txt | 2 +-
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/Documentation/perf-timechart.txt | 2 +-
> tools/perf/builtin-annotate.c | 3 +-
> tools/perf/builtin-buildid-list.c | 53 +-
> tools/perf/builtin-evlist.c | 2 +-
> tools/perf/builtin-kmem.c | 2 +-
> tools/perf/builtin-lock.c | 2 +-
> tools/perf/builtin-record.c | 19 +-
> tools/perf/builtin-report.c | 15 +-
> tools/perf/builtin-sched.c | 2 +-
> tools/perf/builtin-script.c | 6 +-
> tools/perf/builtin-timechart.c | 4 +-
> tools/perf/util/annotate.c | 2 +-
> tools/perf/util/event.c | 112 +++-
> tools/perf/util/evlist.c | 2 +
> tools/perf/util/header.c | 663 +++++++++-----------
> tools/perf/util/header.h | 6 +-
> tools/perf/util/include/linux/bitops.h | 118 ++++
> .../perf/util/scripting-engines/trace-event-perl.c | 73 ++-
> tools/perf/util/session.c | 15 +-
> tools/perf/util/session.h | 2 +-
> tools/perf/util/util.h | 11 +
> 30 files changed, 676 insertions(+), 456 deletions(-)
Pulled, thanks a lot Arnaldo!
FYI, i fixed a trivial build failure, in:
f2328062726d: perf tools: Fix feature-bits rework fallout, remove unused variable
Thanks,
Ingo
^ permalink raw reply [flat|nested] 57+ messages in thread
* [GIT PULL 00/15] perf/core improvements and fixes
@ 2011-12-23 21:53 Arnaldo Carvalho de Melo
2011-12-29 20:28 ` Ingo Molnar
0 siblings, 1 reply; 57+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-12-23 21:53 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Namhyung Kim, Nelson Elhage, Paul Mackerras,
Peter Zijlstra, Robert Richter, Stephane Eranian, arnaldo.melo
Hi Ingo,
Please consider pulling from:
git://github.com/acmel/linux.git perf/core
Regards,
- Arnaldo
David Ahern (3):
perf tools: Fix comm for processes with named threads
perf tools: Look up thread names for system wide profiling
perf script: look up thread using tid instead of pid
Ingo Molnar (1):
perf tools: Fix truncated annotation
Namhyung Kim (1):
perf report: Fix usage string
Nelson Elhage (2):
perf: builtin-record: Provide advice if mmap'ing fails with EPERM.
perf: builtin-record: Document and check that mmap_pages must be a power of two.
Robert Richter (8):
perf tools: Improve macros for struct feature_ops
perf tools: Continue processing header on unknown features
perf tools: Fix out-of-bound access to struct perf_session
perf tools: Moving code in some files
perf report: Accept fifos as input file
perf tools: Unify handling of features when writing feature section
perf tools: Use for_each_set_bit() to iterate over feature flags
perf script: Add generic perl handler to process events
tools/perf/Documentation/perf-annotate.txt | 2 +-
tools/perf/Documentation/perf-buildid-list.txt | 2 +-
tools/perf/Documentation/perf-evlist.txt | 2 +-
tools/perf/Documentation/perf-kmem.txt | 2 +-
tools/perf/Documentation/perf-lock.txt | 2 +-
tools/perf/Documentation/perf-record.txt | 2 +-
tools/perf/Documentation/perf-report.txt | 2 +-
tools/perf/Documentation/perf-sched.txt | 2 +-
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/Documentation/perf-timechart.txt | 2 +-
tools/perf/builtin-annotate.c | 3 +-
tools/perf/builtin-buildid-list.c | 53 +-
tools/perf/builtin-evlist.c | 2 +-
tools/perf/builtin-kmem.c | 2 +-
tools/perf/builtin-lock.c | 2 +-
tools/perf/builtin-record.c | 19 +-
tools/perf/builtin-report.c | 15 +-
tools/perf/builtin-sched.c | 2 +-
tools/perf/builtin-script.c | 6 +-
tools/perf/builtin-timechart.c | 4 +-
tools/perf/util/annotate.c | 2 +-
tools/perf/util/event.c | 112 +++-
tools/perf/util/evlist.c | 2 +
tools/perf/util/header.c | 663 +++++++++-----------
tools/perf/util/header.h | 6 +-
tools/perf/util/include/linux/bitops.h | 118 ++++
.../perf/util/scripting-engines/trace-event-perl.c | 73 ++-
tools/perf/util/session.c | 15 +-
tools/perf/util/session.h | 2 +-
tools/perf/util/util.h | 11 +
30 files changed, 676 insertions(+), 456 deletions(-)
--
1.7.8.rc0.35.gee6df
^ permalink raw reply [flat|nested] 57+ messages in thread
end of thread, other threads:[~2017-08-23 19:36 UTC | newest]
Thread overview: 57+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-27 20:40 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 01/15] perf bench futex: Avoid worker cacheline bouncing Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 02/15] perf bench futex: Sanitize numeric parameters Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 03/15] perf hist browser: Fix hierarchy column counts Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 04/15] tools lib subcmd: Suppport cascading options Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 05/15] perf sched: Make common options cascading Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 06/15] perf sched map: Apply cpu color when there's an activity Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 07/15] perf sched map: Always show task comm with -v Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 08/15] perf tools: Introduce timestamp_in_usec() Arnaldo Carvalho de Melo
2016-10-27 23:14 ` Joonwoo Park
2016-10-28 12:53 ` Arnaldo Carvalho de Melo
2016-10-28 13:30 ` Arnaldo Carvalho de Melo
2016-10-28 14:42 ` [GIT PULL] " Arnaldo Carvalho de Melo
2016-10-28 17:39 ` Ingo Molnar
2016-10-28 17:46 ` Joonwoo Park
2016-10-27 20:40 ` [PATCH 09/15] perf list: Support matching by topic Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 10/15] perf bench mem: Ignore export.h related changes to mem{cpy,set}.S Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 11/15] tools: Update asm-generic/mman-common.h copy from the kernel Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 12/15] perf tools: Update x86's syscall_64.tbl, adding pkey_(alloc,free,mprotect) Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 13/15] perf scripting: Avoid leaking the scripting_context variable Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 14/15] perf scripting: Don't die if scripting can't be setup, disable it Arnaldo Carvalho de Melo
2016-10-27 20:40 ` [PATCH 15/15] perf tools: Add missing object file to the python binding linkage list Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2017-08-23 19:35 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2017-07-28 20:00 Arnaldo Carvalho de Melo
2017-07-30 9:31 ` Ingo Molnar
2017-02-14 1:13 Arnaldo Carvalho de Melo
2017-02-14 6:31 ` Ingo Molnar
2016-11-15 1:38 Arnaldo Carvalho de Melo
2016-11-15 8:47 ` Ingo Molnar
2016-09-22 21:12 Arnaldo Carvalho de Melo
2016-09-23 5:22 ` Ingo Molnar
2016-07-18 23:33 Arnaldo Carvalho de Melo
2016-07-19 6:46 ` Ingo Molnar
2016-05-10 15:15 Arnaldo Carvalho de Melo
2016-05-10 20:28 ` Ingo Molnar
2016-03-07 19:44 Arnaldo Carvalho de Melo
2016-02-22 18:02 Arnaldo Carvalho de Melo
2016-02-24 7:21 ` Ingo Molnar
2015-09-05 1:06 Arnaldo Carvalho de Melo
2015-09-08 14:09 ` Arnaldo Carvalho de Melo
2015-09-08 14:21 ` Ingo Molnar
2015-09-08 14:30 ` Arnaldo Carvalho de Melo
2015-09-14 8:41 ` Ingo Molnar
2015-09-14 9:07 ` Wangnan (F)
2015-06-08 14:17 Arnaldo Carvalho de Melo
2015-06-09 9:47 ` Ingo Molnar
2015-04-02 22:28 Arnaldo Carvalho de Melo
2015-04-03 5:02 ` Ingo Molnar
2014-10-15 20:52 Arnaldo Carvalho de Melo
2014-10-16 5:18 ` Ingo Molnar
2014-06-09 20:02 Jiri Olsa
2014-06-12 11:54 ` Ingo Molnar
2013-08-30 18:58 Arnaldo Carvalho de Melo
2013-08-31 8:08 ` Ingo Molnar
2013-02-28 21:05 Arnaldo Carvalho de Melo
2011-12-23 21:53 Arnaldo Carvalho de Melo
2011-12-29 20:28 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).