* [PATCH 1/2] i2c: uniphier: rename jump label to follow coding style guideline
@ 2016-11-04 10:49 Masahiro Yamada
2016-11-04 10:49 ` [PATCH 2/2] i2c: uniphier-f: " Masahiro Yamada
2016-11-18 1:22 ` [1/2] i2c: uniphier: " Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2016-11-04 10:49 UTC (permalink / raw)
To: linux-i2c; +Cc: Masahiro Yamada, linux-arm-kernel, linux-kernel, Wolfram Sang
Documentation/CodingStyle recommends to use label names which say
what the goto does or why the goto exists.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/i2c/busses/i2c-uniphier.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c
index cc80bb2..abc6770 100644
--- a/drivers/i2c/busses/i2c-uniphier.c
+++ b/drivers/i2c/busses/i2c-uniphier.c
@@ -373,7 +373,7 @@ static int uniphier_i2c_probe(struct platform_device *pdev)
if (!clk_rate) {
dev_err(dev, "input clock rate should not be zero\n");
ret = -EINVAL;
- goto err;
+ goto disable_clk;
}
init_completion(&priv->comp);
@@ -392,11 +392,11 @@ static int uniphier_i2c_probe(struct platform_device *pdev)
priv);
if (ret) {
dev_err(dev, "failed to request irq %d\n", irq);
- goto err;
+ goto disable_clk;
}
ret = i2c_add_adapter(&priv->adap);
-err:
+disable_clk:
if (ret)
clk_disable_unprepare(priv->clk);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] i2c: uniphier-f: rename jump label to follow coding style guideline
2016-11-04 10:49 [PATCH 1/2] i2c: uniphier: rename jump label to follow coding style guideline Masahiro Yamada
@ 2016-11-04 10:49 ` Masahiro Yamada
2016-11-18 1:23 ` [2/2] " Wolfram Sang
2016-11-18 1:22 ` [1/2] i2c: uniphier: " Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2016-11-04 10:49 UTC (permalink / raw)
To: linux-i2c; +Cc: Masahiro Yamada, linux-arm-kernel, linux-kernel, Wolfram Sang
Documentation/CodingStyle recommends to use label names which say
what the goto does or why the goto exists.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/i2c/busses/i2c-uniphier-f.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c
index b54448e..a154cc9 100644
--- a/drivers/i2c/busses/i2c-uniphier-f.c
+++ b/drivers/i2c/busses/i2c-uniphier-f.c
@@ -528,7 +528,7 @@ static int uniphier_fi2c_probe(struct platform_device *pdev)
if (!clk_rate) {
dev_err(dev, "input clock rate should not be zero\n");
ret = -EINVAL;
- goto err;
+ goto disable_clk;
}
init_completion(&priv->comp);
@@ -547,11 +547,11 @@ static int uniphier_fi2c_probe(struct platform_device *pdev)
pdev->name, priv);
if (ret) {
dev_err(dev, "failed to request irq %d\n", irq);
- goto err;
+ goto disable_clk;
}
ret = i2c_add_adapter(&priv->adap);
-err:
+disable_clk:
if (ret)
clk_disable_unprepare(priv->clk);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [1/2] i2c: uniphier: rename jump label to follow coding style guideline
2016-11-04 10:49 [PATCH 1/2] i2c: uniphier: rename jump label to follow coding style guideline Masahiro Yamada
2016-11-04 10:49 ` [PATCH 2/2] i2c: uniphier-f: " Masahiro Yamada
@ 2016-11-18 1:22 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2016-11-18 1:22 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-i2c, linux-arm-kernel, linux-kernel, Wolfram Sang
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
On Fri, Nov 04, 2016 at 07:49:20PM +0900, Masahiro Yamada wrote:
> Documentation/CodingStyle recommends to use label names which say
> what the goto does or why the goto exists.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2/2] i2c: uniphier-f: rename jump label to follow coding style guideline
2016-11-04 10:49 ` [PATCH 2/2] i2c: uniphier-f: " Masahiro Yamada
@ 2016-11-18 1:23 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2016-11-18 1:23 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-i2c, linux-arm-kernel, linux-kernel, Wolfram Sang
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
On Fri, Nov 04, 2016 at 07:49:21PM +0900, Masahiro Yamada wrote:
> Documentation/CodingStyle recommends to use label names which say
> what the goto does or why the goto exists.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-18 1:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 10:49 [PATCH 1/2] i2c: uniphier: rename jump label to follow coding style guideline Masahiro Yamada
2016-11-04 10:49 ` [PATCH 2/2] i2c: uniphier-f: " Masahiro Yamada
2016-11-18 1:23 ` [2/2] " Wolfram Sang
2016-11-18 1:22 ` [1/2] i2c: uniphier: " Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).