linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk
@ 2016-11-08  0:02 Marcos Paulo de Souza
  2016-11-14  9:32 ` Marcos Paulo de Souza
  0 siblings, 1 reply; 4+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-08  0:02 UTC (permalink / raw)
  To: dvhart
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable, Marcos Paulo de Souza

Without this patch, the Asus X45U wireless card can't be turned
on (hard-blocked), but after a suspend/resume it just starts working.

Following this bug report[1], there are other cases like this one, but
this Asus is the only model that I can test.

[1] https://ubuntuforums.org/showthread.php?t=2181558

Cc: stable@vger.kernel.org # 4.4.x-
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

---
v2 -> v3:
 Add stable version in the CC line of stable email address
v1 -> v2:
 Add stable copy and specify the stable version to apply this patch

 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 26e4cbc..6032b70 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X45U",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. X456UA",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-08  0:02 [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza
@ 2016-11-14  9:32 ` Marcos Paulo de Souza
  2016-11-14 22:05   ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-14  9:32 UTC (permalink / raw)
  To: dvhart
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

ping?

On Mon, Nov 07, 2016 at 10:02:32PM -0200, Marcos Paulo de Souza wrote:
> Without this patch, the Asus X45U wireless card can't be turned
> on (hard-blocked), but after a suspend/resume it just starts working.
> 
> Following this bug report[1], there are other cases like this one, but
> this Asus is the only model that I can test.
> 
> [1] https://ubuntuforums.org/showthread.php?t=2181558
> 
> Cc: stable@vger.kernel.org # 4.4.x-
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> 
> ---
> v2 -> v3:
>  Add stable version in the CC line of stable email address
> v1 -> v2:
>  Add stable copy and specify the stable version to apply this patch
> 
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 26e4cbc..6032b70 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
>  	},
>  	{
>  		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X45U",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
> +		},
> +		.driver_data = &quirk_asus_wapf4,
> +	},
> +	{
> +		.callback = dmi_matched,
>  		.ident = "ASUSTeK COMPUTER INC. X456UA",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-14  9:32 ` Marcos Paulo de Souza
@ 2016-11-14 22:05   ` Andy Shevchenko
  2016-11-14 23:12     ` Marcos Paulo de Souza
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2016-11-14 22:05 UTC (permalink / raw)
  To: Marcos Paulo de Souza
  Cc: dvhart, Corentin Chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

On Mon, Nov 14, 2016 at 11:32 AM, Marcos Paulo de Souza
<marcos.souza.org@gmail.com> wrote:
> ping?

Please, don't do empty pings especially in top posting.
I will look at this as soon as I can.

>
> On Mon, Nov 07, 2016 at 10:02:32PM -0200, Marcos Paulo de Souza wrote:
>> Without this patch, the Asus X45U wireless card can't be turned
>> on (hard-blocked), but after a suspend/resume it just starts working.
>>
>> Following this bug report[1], there are other cases like this one, but
>> this Asus is the only model that I can test.
>>
>> [1] https://ubuntuforums.org/showthread.php?t=2181558
>>
>> Cc: stable@vger.kernel.org # 4.4.x-
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>>
>> ---
>> v2 -> v3:
>>  Add stable version in the CC line of stable email address
>> v1 -> v2:
>>  Add stable copy and specify the stable version to apply this patch
>>
>>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index 26e4cbc..6032b70 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
>>       },
>>       {
>>               .callback = dmi_matched,
>> +             .ident = "ASUSTeK COMPUTER INC. X45U",
>> +             .matches = {
>> +                     DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
>> +             },
>> +             .driver_data = &quirk_asus_wapf4,
>> +     },
>> +     {
>> +             .callback = dmi_matched,
>>               .ident = "ASUSTeK COMPUTER INC. X456UA",
>>               .matches = {
>>                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> --
>> 2.7.4



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-14 22:05   ` Andy Shevchenko
@ 2016-11-14 23:12     ` Marcos Paulo de Souza
  0 siblings, 0 replies; 4+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-14 23:12 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: dvhart, Corentin Chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

On Tue, Nov 15, 2016 at 12:05:30AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 14, 2016 at 11:32 AM, Marcos Paulo de Souza
> <marcos.souza.org@gmail.com> wrote:
> > ping?
> 
> Please, don't do empty pings especially in top posting.
> I will look at this as soon as I can.

Hi Andy, my apologies. Thanks a lot for checking my patch.

> 
> >
> > On Mon, Nov 07, 2016 at 10:02:32PM -0200, Marcos Paulo de Souza wrote:
> >> Without this patch, the Asus X45U wireless card can't be turned
> >> on (hard-blocked), but after a suspend/resume it just starts working.
> >>
> >> Following this bug report[1], there are other cases like this one, but
> >> this Asus is the only model that I can test.
> >>
> >> [1] https://ubuntuforums.org/showthread.php?t=2181558
> >>
> >> Cc: stable@vger.kernel.org # 4.4.x-
> >> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> >>
> >> ---
> >> v2 -> v3:
> >>  Add stable version in the CC line of stable email address
> >> v1 -> v2:
> >>  Add stable copy and specify the stable version to apply this patch
> >>
> >>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> >> index 26e4cbc..6032b70 100644
> >> --- a/drivers/platform/x86/asus-nb-wmi.c
> >> +++ b/drivers/platform/x86/asus-nb-wmi.c
> >> @@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
> >>       },
> >>       {
> >>               .callback = dmi_matched,
> >> +             .ident = "ASUSTeK COMPUTER INC. X45U",
> >> +             .matches = {
> >> +                     DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> +                     DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
> >> +             },
> >> +             .driver_data = &quirk_asus_wapf4,
> >> +     },
> >> +     {
> >> +             .callback = dmi_matched,
> >>               .ident = "ASUSTeK COMPUTER INC. X456UA",
> >>               .matches = {
> >>                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> --
> >> 2.7.4
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-14 23:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-08  0:02 [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza
2016-11-14  9:32 ` Marcos Paulo de Souza
2016-11-14 22:05   ` Andy Shevchenko
2016-11-14 23:12     ` Marcos Paulo de Souza

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).