* [PATCH] writeback: remove redundant if check
@ 2016-11-08 7:47 Tahsin Erdogan
0 siblings, 0 replies; only message in thread
From: Tahsin Erdogan @ 2016-11-08 7:47 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel; +Cc: linux-kernel, Tahsin Erdogan
b_more_io non-empty check is already preceded by an opposite check.
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
---
fs/fs-writeback.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 05713a5da083..ef600591d96f 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1769,15 +1769,13 @@ static long wb_writeback(struct bdi_writeback *wb,
* become available for writeback. Otherwise
* we'll just busyloop.
*/
- if (!list_empty(&wb->b_more_io)) {
- trace_writeback_wait(wb, work);
- inode = wb_inode(wb->b_more_io.prev);
- spin_lock(&inode->i_lock);
- spin_unlock(&wb->list_lock);
- /* This function drops i_lock... */
- inode_sleep_on_writeback(inode);
- spin_lock(&wb->list_lock);
- }
+ trace_writeback_wait(wb, work);
+ inode = wb_inode(wb->b_more_io.prev);
+ spin_lock(&inode->i_lock);
+ spin_unlock(&wb->list_lock);
+ /* This function drops i_lock... */
+ inode_sleep_on_writeback(inode);
+ spin_lock(&wb->list_lock);
}
spin_unlock(&wb->list_lock);
blk_finish_plug(&plug);
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-08 8:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-08 7:47 [PATCH] writeback: remove redundant if check Tahsin Erdogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).