From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-rt-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
Andy Lutomirski <luto@kernel.org>,
"Joel Fernandes" <joelaf@google.com>,
Jisheng Zhang <jszhang@marvell.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
John Dias <joaodias@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>
Subject: [PATCH 3/3] x86/ldt: use vfree_atomic() to free ldt entries
Date: Tue, 8 Nov 2016 18:05:45 +0300 [thread overview]
Message-ID: <1478617545-8443-3-git-send-email-aryabinin@virtuozzo.com> (raw)
In-Reply-To: <1478617545-8443-1-git-send-email-aryabinin@virtuozzo.com>
vfree() is going to use sleeping lock. free_ldt_struct()
may be called with disabled preemption, therefore we must
use vfree_atomic() here.
E.g. call trace:
vfree()
free_ldt_struct()
destroy_context_ldt()
__mmdrop()
finish_task_switch()
schedule_tail()
ret_from_fork()
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jisheng Zhang <jszhang@marvell.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: John Dias <joaodias@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
---
arch/x86/kernel/ldt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/ldt.c b/arch/x86/kernel/ldt.c
index 6707039..4d12cdf 100644
--- a/arch/x86/kernel/ldt.c
+++ b/arch/x86/kernel/ldt.c
@@ -93,7 +93,7 @@ static void free_ldt_struct(struct ldt_struct *ldt)
paravirt_free_ldt(ldt->entries, ldt->size);
if (ldt->size * LDT_ENTRY_SIZE > PAGE_SIZE)
- vfree(ldt->entries);
+ vfree_atomic(ldt->entries);
else
free_page((unsigned long)ldt->entries);
kfree(ldt);
--
2.7.3
next prev parent reply other threads:[~2016-11-08 15:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 15:17 reduce latency in __purge_vmap_area_lazy Christoph Hellwig
2016-10-22 15:17 ` [PATCH 1/7] mm: remove free_unmap_vmap_area_noflush Christoph Hellwig
2016-10-22 15:17 ` [PATCH 2/7] mm: remove free_unmap_vmap_area_addr Christoph Hellwig
2016-10-22 15:17 ` [PATCH 3/7] mm: refactor __purge_vmap_area_lazy Christoph Hellwig
2016-10-22 15:17 ` [PATCH 4/7] mm: defer vmalloc from atomic context Christoph Hellwig
2016-10-24 15:44 ` Andrey Ryabinin
2016-11-05 3:43 ` Joel Fernandes
2016-11-07 15:01 ` Andrey Ryabinin
2016-11-07 15:09 ` Christoph Hellwig
2016-11-08 15:03 ` Andrey Ryabinin
2016-11-08 15:05 ` [PATCH 1/3] mm/vmalloc: add vfree_atomic() Andrey Ryabinin
2016-11-08 15:05 ` [PATCH 2/3] kernel/fork: use vfree_atomic() to free thread stack Andrey Ryabinin
2016-11-08 15:05 ` Andrey Ryabinin [this message]
2016-11-07 16:50 ` [PATCH 4/7] mm: defer vmalloc from atomic context Joel Fernandes
2016-10-22 15:17 ` [PATCH 5/7] mm: mark all calls into the vmalloc subsystem as potentially sleeping Christoph Hellwig
2016-10-22 15:17 ` [PATCH 6/7] mm: turn vmap_purge_lock into a mutex Christoph Hellwig
2016-10-22 15:17 ` [PATCH 7/7] mm: add preempt points into __purge_vmap_area_lazy Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478617545-8443-3-git-send-email-aryabinin@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=joaodias@google.com \
--cc=joelaf@google.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).