linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: ethernet: Fix SGMII unable to switch speed and autonego failure
@ 2016-11-14  9:06 ho.jia.jie
  2016-11-15 17:06 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: ho.jia.jie @ 2016-11-14  9:06 UTC (permalink / raw)
  To: peppe.cavallaro, alexandre.torgue, netdev, linux-kernel; +Cc: Jia Jie Ho

From: Jia Jie Ho <ho.jia.jie@intel.com>

TSE PCS SGMII ethernet has an issue where switching speed doesn't work
caused by a faulty register macro offset. This fixes the issue.

Signed-off-by: Jia Jie Ho <ho.jia.jie@intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c b/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
index 2920e2e..489ef14 100644
--- a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c
@@ -63,8 +63,8 @@
 #define TSE_PCS_SGMII_LINK_TIMER_0			0x0D40
 #define TSE_PCS_SGMII_LINK_TIMER_1			0x0003
 #define TSE_PCS_SW_RESET_TIMEOUT			100
-#define TSE_PCS_USE_SGMII_AN_MASK			BIT(2)
-#define TSE_PCS_USE_SGMII_ENA				BIT(1)
+#define TSE_PCS_USE_SGMII_AN_MASK			BIT(1)
+#define TSE_PCS_USE_SGMII_ENA				BIT(0)
 
 #define SGMII_ADAPTER_CTRL_REG				0x00
 #define SGMII_ADAPTER_DISABLE				0x0001
-- 
1.8.2.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ethernet: Fix SGMII unable to switch speed and autonego failure
  2016-11-14  9:06 [PATCH] net: ethernet: Fix SGMII unable to switch speed and autonego failure ho.jia.jie
@ 2016-11-15 17:06 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-15 17:06 UTC (permalink / raw)
  To: ho.jia.jie; +Cc: peppe.cavallaro, alexandre.torgue, netdev, linux-kernel

From: ho.jia.jie@intel.com
Date: Mon, 14 Nov 2016 17:06:49 +0800

> From: Jia Jie Ho <ho.jia.jie@intel.com>
> 
> TSE PCS SGMII ethernet has an issue where switching speed doesn't work
> caused by a faulty register macro offset. This fixes the issue.
> 
> Signed-off-by: Jia Jie Ho <ho.jia.jie@intel.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-15 17:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14  9:06 [PATCH] net: ethernet: Fix SGMII unable to switch speed and autonego failure ho.jia.jie
2016-11-15 17:06 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).