From: Jerome Brunet <jbrunet@baylibre.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andre Roth <neolynx@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options
Date: Wed, 16 Nov 2016 15:51:30 +0100 [thread overview]
Message-ID: <1479307890.17538.40.camel@baylibre.com> (raw)
In-Reply-To: <20161116132337.GD19962@lunn.ch>
On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote:
> >
> > There two kind of PHYs supporting eee, the one advertising eee by
> > default (like realtek) and the one not advertising it (like
> > micrel).
This is just the default register value.
>
> I don't know too much about EEE. So maybe a dumb question. Does the
> MAC need to be involved? Or is it just the PHY?
>
> If the MAC needs to be involved, the PHY should not be advertising
> EEE
> unless the MAC asks for it by calling phy_init_eee(). If this is
> true,
> maybe we need to change the realtek driver, and others in that class.
As far I understand, the advertised capabilities are exchanged during
the auto-negotiation.
At this stage, if the advertisement is disabled (regarless of the
actual support) on either side of the link, there will be no low power
idle state on the Tx nor the Rx path.
If the advertisement is enabled on both side but we don't call
phy_init_eee, I suppose Tx won't enter LPI, but Rx could.
>
> Andrew
next prev parent reply other threads:[~2016-11-16 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:29 [PATCH net 0/3] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet
2016-11-15 14:29 ` [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options Jerome Brunet
2016-11-15 16:30 ` Andrew Lunn
2016-11-15 17:03 ` Florian Fainelli
2016-11-16 9:56 ` Jerome Brunet
2016-11-16 13:23 ` Andrew Lunn
2016-11-16 14:51 ` Jerome Brunet [this message]
2016-11-16 15:06 ` Andrew Lunn
2016-11-16 15:38 ` Jerome Brunet
2016-11-16 17:01 ` Florian Fainelli
2016-11-16 17:06 ` Anand Moon
2016-11-17 10:20 ` Jerome Brunet
2016-11-17 18:00 ` Anand Moon
2016-11-17 21:48 ` Jerome Brunet
2016-11-15 14:29 ` [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek phys Jerome Brunet
2016-11-16 15:11 ` Rob Herring
2016-11-16 15:20 ` Jerome Brunet
2016-11-15 14:29 ` [PATCH net 3/3] ARM64: dts: meson: odroidc2: disable 1000t-eee advertisement Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479307890.17538.40.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=neolynx@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).