From: Andrew Lunn <andrew@lunn.ch>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andre Roth <neolynx@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options
Date: Tue, 15 Nov 2016 17:30:36 +0100 [thread overview]
Message-ID: <20161115163036.GB23231@lunn.ch> (raw)
In-Reply-To: <1479220154-25851-2-git-send-email-jbrunet@baylibre.com>
On Tue, Nov 15, 2016 at 03:29:12PM +0100, Jerome Brunet wrote:
> On some platforms, energy efficient ethernet with rtl8211 devices is
> causing issue, like throughput drop or broken link.
>
> This was reported on the OdroidC2 (DWMAC + RTL8211F). While the issue root
> cause is not fully understood yet, disabling EEE advertisement prevent auto
> negotiation from enabling EEE.
>
> This patch provides options to disable 1000T and 100TX EEE advertisement
> individually for the realtek phys supporting this feature.
Looking at the code, i don't see anything specific to RealTek
here. This all seems generic. So should it be in phy.c and made a
generic OF property which can be applied to any PHY which supports
EEE.
Andrew
next prev parent reply other threads:[~2016-11-15 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:29 [PATCH net 0/3] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet
2016-11-15 14:29 ` [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options Jerome Brunet
2016-11-15 16:30 ` Andrew Lunn [this message]
2016-11-15 17:03 ` Florian Fainelli
2016-11-16 9:56 ` Jerome Brunet
2016-11-16 13:23 ` Andrew Lunn
2016-11-16 14:51 ` Jerome Brunet
2016-11-16 15:06 ` Andrew Lunn
2016-11-16 15:38 ` Jerome Brunet
2016-11-16 17:01 ` Florian Fainelli
2016-11-16 17:06 ` Anand Moon
2016-11-17 10:20 ` Jerome Brunet
2016-11-17 18:00 ` Anand Moon
2016-11-17 21:48 ` Jerome Brunet
2016-11-15 14:29 ` [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek phys Jerome Brunet
2016-11-16 15:11 ` Rob Herring
2016-11-16 15:20 ` Jerome Brunet
2016-11-15 14:29 ` [PATCH net 3/3] ARM64: dts: meson: odroidc2: disable 1000t-eee advertisement Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115163036.GB23231@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=neolynx@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).