From: Lubomir Rintel <lkundrak@v3.sk>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scr24x_cs: include linux/io.h
Date: Wed, 16 Nov 2016 17:10:34 +0100 [thread overview]
Message-ID: <1479312634.14443.2.camel@v3.sk> (raw)
In-Reply-To: <20161116152342.3414667-1-arnd@arndb.de>
On Wed, 2016-11-16 at 16:23 +0100, Arnd Bergmann wrote:
> The newly added scr24x_cs driver doesn't build in some
> configurations:
>
> drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready':
> drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of
> function 'ioread8' [-Werror=implicit-function-declaration]
>
> Adding in explicit include for the right header makes it work.
>
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/char/pcmcia/scr24x_cs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce1a3be..a1de354a89a7 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -27,6 +27,7 @@
> #include <linux/cdev.h>
> #include <linux/slab.h>
> #include <linux/fs.h>
> +#include <linux/io.h>
> #include <linux/uaccess.h>
>
> #include <pcmcia/cistpl.h>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thanks
prev parent reply other threads:[~2016-11-16 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 15:23 [PATCH] scr24x_cs: include linux/io.h Arnd Bergmann
2016-11-16 16:10 ` Lubomir Rintel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479312634.14443.2.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).