* [PATCH] scr24x_cs: include linux/io.h
@ 2016-11-16 15:23 Arnd Bergmann
2016-11-16 16:10 ` Lubomir Rintel
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-11-16 15:23 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Arnd Bergmann, Lubomir Rintel, linux-kernel
The newly added scr24x_cs driver doesn't build in some configurations:
drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready':
drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
Adding in explicit include for the right header makes it work.
Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/char/pcmcia/scr24x_cs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
index 4f215ce1a3be..a1de354a89a7 100644
--- a/drivers/char/pcmcia/scr24x_cs.c
+++ b/drivers/char/pcmcia/scr24x_cs.c
@@ -27,6 +27,7 @@
#include <linux/cdev.h>
#include <linux/slab.h>
#include <linux/fs.h>
+#include <linux/io.h>
#include <linux/uaccess.h>
#include <pcmcia/cistpl.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scr24x_cs: include linux/io.h
2016-11-16 15:23 [PATCH] scr24x_cs: include linux/io.h Arnd Bergmann
@ 2016-11-16 16:10 ` Lubomir Rintel
0 siblings, 0 replies; 2+ messages in thread
From: Lubomir Rintel @ 2016-11-16 16:10 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: linux-kernel
On Wed, 2016-11-16 at 16:23 +0100, Arnd Bergmann wrote:
> The newly added scr24x_cs driver doesn't build in some
> configurations:
>
> drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready':
> drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of
> function 'ioread8' [-Werror=implicit-function-declaration]
>
> Adding in explicit include for the right header makes it work.
>
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/char/pcmcia/scr24x_cs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce1a3be..a1de354a89a7 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -27,6 +27,7 @@
> #include <linux/cdev.h>
> #include <linux/slab.h>
> #include <linux/fs.h>
> +#include <linux/io.h>
> #include <linux/uaccess.h>
>
> #include <pcmcia/cistpl.h>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-16 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-16 15:23 [PATCH] scr24x_cs: include linux/io.h Arnd Bergmann
2016-11-16 16:10 ` Lubomir Rintel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).