* [PATCH v2 0/2] staging: speakup: spk_types.h checkpatch modifications
@ 2016-11-21 15:11 Walt Feasel
2016-11-21 15:11 ` [PATCH v2 1/2] staging: speakup: spk_types.h Comment modifications Walt Feasel
2016-11-21 15:11 ` [PATCH v2 2/2] staging: speakup: spk_types.h Align parenthesis Walt Feasel
0 siblings, 2 replies; 3+ messages in thread
From: Walt Feasel @ 2016-11-21 15:11 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, kirk, samuel.thibault, speakup, gregkh, devel,
linux-kernel, Walt Feasel
Make Linux kernel style modifications to spk_types.h to include:
Comment modifications
Align parenthesis
Walt Feasel (2):
staging: speakup: spk_types.h Comment modifications
staging: speakup: spk_types.h Align parenthesis
drivers/staging/speakup/spk_types.h | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
--
v2 makes changes to correct for email format patch submission
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] staging: speakup: spk_types.h Comment modifications
2016-11-21 15:11 [PATCH v2 0/2] staging: speakup: spk_types.h checkpatch modifications Walt Feasel
@ 2016-11-21 15:11 ` Walt Feasel
2016-11-21 15:11 ` [PATCH v2 2/2] staging: speakup: spk_types.h Align parenthesis Walt Feasel
1 sibling, 0 replies; 3+ messages in thread
From: Walt Feasel @ 2016-11-21 15:11 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, kirk, samuel.thibault, speakup, gregkh, devel,
linux-kernel, Walt Feasel
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/spk_types.h | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
index e8ff5d7..5552b48 100644
--- a/drivers/staging/speakup/spk_types.h
+++ b/drivers/staging/speakup/spk_types.h
@@ -1,16 +1,14 @@
#ifndef SPEAKUP_TYPES_H
#define SPEAKUP_TYPES_H
-/*
- * This file includes all of the typedefs and structs used in speakup.
- */
+/* This file includes all of the typedefs and structs used in speakup. */
#include <linux/types.h>
#include <linux/fs.h>
#include <linux/errno.h>
#include <linux/delay.h>
#include <linux/wait.h> /* for wait_queue */
-#include <linux/init.h> /* for __init */
+#include <linux/init.h> /* for __init */
#include <linux/module.h>
#include <linux/vt_kern.h>
#include <linux/spinlock.h>
@@ -105,7 +103,7 @@ struct st_var_header {
enum var_id_t var_id;
enum var_type_t var_type;
void *p_val; /* ptr to programs variable to store value */
- void *data; /* ptr to the vars data */
+ void *data; /* ptr to the vars data */
};
struct num_var_t {
@@ -114,8 +112,8 @@ struct num_var_t {
int low;
int high;
short offset, multiplier; /* for fiddling rates etc. */
- char *out_str; /* if synth needs char representation of number */
- int value; /* current value */
+ char *out_str; /* if synth needs char representation of number */
+ int value; /* current value */
};
struct punc_var_t {
@@ -181,7 +179,7 @@ struct spk_synth {
struct attribute_group attributes;
};
-/**
+/*
* module_spk_synth() - Helper macro for registering a speakup driver
* @__spk_synth: spk_synth struct
* Helper macro for speakup drivers which do not do anything special in module
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] staging: speakup: spk_types.h Align parenthesis
2016-11-21 15:11 [PATCH v2 0/2] staging: speakup: spk_types.h checkpatch modifications Walt Feasel
2016-11-21 15:11 ` [PATCH v2 1/2] staging: speakup: spk_types.h Comment modifications Walt Feasel
@ 2016-11-21 15:11 ` Walt Feasel
1 sibling, 0 replies; 3+ messages in thread
From: Walt Feasel @ 2016-11-21 15:11 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, kirk, samuel.thibault, speakup, gregkh, devel,
linux-kernel, Walt Feasel
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/spk_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
index 5552b48..b07f6cc 100644
--- a/drivers/staging/speakup/spk_types.h
+++ b/drivers/staging/speakup/spk_types.h
@@ -167,7 +167,7 @@ struct spk_synth {
int (*probe)(struct spk_synth *synth);
void (*release)(void);
const char *(*synth_immediate)(struct spk_synth *synth,
- const char *buff);
+ const char *buff);
void (*catch_up)(struct spk_synth *synth);
void (*flush)(struct spk_synth *synth);
int (*is_alive)(struct spk_synth *synth);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-21 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-21 15:11 [PATCH v2 0/2] staging: speakup: spk_types.h checkpatch modifications Walt Feasel
2016-11-21 15:11 ` [PATCH v2 1/2] staging: speakup: spk_types.h Comment modifications Walt Feasel
2016-11-21 15:11 ` [PATCH v2 2/2] staging: speakup: spk_types.h Align parenthesis Walt Feasel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).