* [PATCH] powerpc: Fix build failure
@ 2014-08-21 13:04 Pranith Kumar
2014-09-16 4:12 ` Alistair Popple
0 siblings, 1 reply; 2+ messages in thread
From: Pranith Kumar @ 2014-08-21 13:04 UTC (permalink / raw)
To: Alistair Popple, Matt Porter, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, open list:LINUX FOR POWERPC...,
open list
Fix the following build failure
drivers/built-in.o: In function `nhi_init':
nhi.c:(.init.text+0x63390): undefined reference to `ehci_init_driver'
by adding a dependency on USB_EHCI_HCD which supplies the ehci_init_driver().
Also we need to depend on USB_OHCI_HCD similarly
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
arch/powerpc/platforms/44x/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 4d88f6a..3e7deb2 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -216,8 +216,8 @@ config AKEBONO
select IBM_EMAC_EMAC4
select IBM_EMAC_RGMII_WOL
select USB
- select USB_OHCI_HCD_PLATFORM
- select USB_EHCI_HCD_PLATFORM
+ select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
+ select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
select MMC_SDHCI
select MMC_SDHCI_PLTFM
select MMC_SDHCI_OF_476GTR
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Fix build failure
2014-08-21 13:04 [PATCH] powerpc: Fix build failure Pranith Kumar
@ 2014-09-16 4:12 ` Alistair Popple
0 siblings, 0 replies; 2+ messages in thread
From: Alistair Popple @ 2014-09-16 4:12 UTC (permalink / raw)
To: Pranith Kumar
Cc: Matt Porter, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, open list:LINUX FOR POWERPC...,
open list
Thanks for fixing these!
Acked-by: Alistair Popple <alistair@popple.id.au>
On Thu, 21 Aug 2014 09:04:31 Pranith Kumar wrote:
> Fix the following build failure
>
> drivers/built-in.o: In function `nhi_init':
> nhi.c:(.init.text+0x63390): undefined reference to `ehci_init_driver'
>
> by adding a dependency on USB_EHCI_HCD which supplies the
> ehci_init_driver().
>
> Also we need to depend on USB_OHCI_HCD similarly
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/powerpc/platforms/44x/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig
> b/arch/powerpc/platforms/44x/Kconfig index 4d88f6a..3e7deb2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -216,8 +216,8 @@ config AKEBONO
> select IBM_EMAC_EMAC4
> select IBM_EMAC_RGMII_WOL
> select USB
> - select USB_OHCI_HCD_PLATFORM
> - select USB_EHCI_HCD_PLATFORM
> + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> + select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
> select MMC_SDHCI
> select MMC_SDHCI_PLTFM
> select MMC_SDHCI_OF_476GTR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-16 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-21 13:04 [PATCH] powerpc: Fix build failure Pranith Kumar
2014-09-16 4:12 ` Alistair Popple
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).