* [PATCH 1/1] clk: clk-wm831x: fix a logic error
@ 2016-12-01 6:25 Pan Bian
2016-12-01 9:32 ` Charles Keepax
2016-12-08 0:23 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Pan Bian @ 2016-12-01 6:25 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: patches, linux-clk, linux-kernel, Pan Bian
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/clk/clk-wm831x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c
index f4fdac5..0621fbf 100644
--- a/drivers/clk/clk-wm831x.c
+++ b/drivers/clk/clk-wm831x.c
@@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw)
if (ret < 0) {
dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
ret);
- return true;
+ return false;
}
return (ret & WM831X_CLKOUT_ENA) != 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error
2016-12-01 6:25 [PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian
@ 2016-12-01 9:32 ` Charles Keepax
2016-12-08 0:23 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2016-12-01 9:32 UTC (permalink / raw)
To: Pan Bian
Cc: Michael Turquette, Stephen Boyd, patches, linux-clk, linux-kernel
On Thu, Dec 01, 2016 at 02:25:44PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
> wm831x_clkout_is_prepared() returns "true" when it fails to read
> CLOCK_CONTROL_1. "true" means the device is already prepared. So
> return "true" on the read failure seems improper.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
Looks good to me:
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error
2016-12-01 6:25 [PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian
2016-12-01 9:32 ` Charles Keepax
@ 2016-12-08 0:23 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-12-08 0:23 UTC (permalink / raw)
To: Pan Bian; +Cc: Michael Turquette, patches, linux-clk, linux-kernel
On 12/01, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
> wm831x_clkout_is_prepared() returns "true" when it fails to read
> CLOCK_CONTROL_1. "true" means the device is already prepared. So
> return "true" on the read failure seems improper.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-08 0:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-01 6:25 [PATCH 1/1] clk: clk-wm831x: fix a logic error Pan Bian
2016-12-01 9:32 ` Charles Keepax
2016-12-08 0:23 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).