* [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read
@ 2016-12-03 2:05 Ivan Khoronzhuk
2016-12-05 18:47 ` Grygorii Strashko
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Khoronzhuk @ 2016-12-03 2:05 UTC (permalink / raw)
To: mugunthanvnm, grygorii.strashko
Cc: linux-omap, netdev, linux-kernel, Ivan Khoronzhuk
There is desc_read() macros to read desc fields, so no need to
use __raw_readl();
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net-next/master
drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index c776e45..d96dca5 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
}
desc_dma = desc_phys(pool, desc);
- status = __raw_readl(&desc->hw_mode);
+ status = desc_read(desc, hw_mode);
outlen = status & 0x7ff;
if (status & CPDMA_DESC_OWNER) {
chan->stats.busy_dequeue++;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read
2016-12-03 2:05 [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read Ivan Khoronzhuk
@ 2016-12-05 18:47 ` Grygorii Strashko
2016-12-05 19:47 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Grygorii Strashko @ 2016-12-05 18:47 UTC (permalink / raw)
To: Ivan Khoronzhuk, mugunthanvnm; +Cc: linux-omap, netdev, linux-kernel
On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
> There is desc_read() macros to read desc fields, so no need to
> use __raw_readl();
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
I'm going to update it all at once as part of [1].
[1] https://lkml.org/lkml/2016/12/1/781
> ---
> Based on net-next/master
>
> drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index c776e45..d96dca5 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
> }
> desc_dma = desc_phys(pool, desc);
>
> - status = __raw_readl(&desc->hw_mode);
> + status = desc_read(desc, hw_mode);
> outlen = status & 0x7ff;
> if (status & CPDMA_DESC_OWNER) {
> chan->stats.busy_dequeue++;
>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read
2016-12-05 18:47 ` Grygorii Strashko
@ 2016-12-05 19:47 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-05 19:47 UTC (permalink / raw)
To: grygorii.strashko
Cc: ivan.khoronzhuk, mugunthanvnm, linux-omap, netdev, linux-kernel
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Mon, 5 Dec 2016 12:47:16 -0600
>
>
> On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
>> There is desc_read() macros to read desc fields, so no need to
>> use __raw_readl();
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>
>
> I'm going to update it all at once as part of [1].
>
> [1] https://lkml.org/lkml/2016/12/1/781
Ok.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-05 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-03 2:05 [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read Ivan Khoronzhuk
2016-12-05 18:47 ` Grygorii Strashko
2016-12-05 19:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).