* [PATCH 1/1] scsi: csiostor: fix improper return value
@ 2016-12-03 10:34 Pan Bian
0 siblings, 0 replies; only message in thread
From: Pan Bian @ 2016-12-03 10:34 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen, linux-scsi
Cc: linux-kernel, Pan Bian
Function csio_hw_flash_erase_sectors() will always return 0, even on
failures. Thus, its callers will not detect the errors, and may produce
unexpected behavior. To avoid bugs, this patch replaces "return 0;" with
"return ret;".
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188681
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/scsi/csiostor/csio_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
index 622bdab..8970df2 100644
--- a/drivers/scsi/csiostor/csio_hw.c
+++ b/drivers/scsi/csiostor/csio_hw.c
@@ -613,7 +613,7 @@ struct t4_vpd_hdr {
csio_err(hw, "erase of flash sector %d failed, error %d\n",
start, ret);
csio_wr_reg32(hw, 0, SF_OP_A); /* unlock SF */
- return 0;
+ return ret;
}
static void
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-12-03 10:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-03 10:34 [PATCH 1/1] scsi: csiostor: fix improper return value Pan Bian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).