* [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails
@ 2016-12-03 11:24 Pan Bian
2016-12-05 16:20 ` Woojung.Huh
2016-12-05 18:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Pan Bian @ 2016-12-03 11:24 UTC (permalink / raw)
To: Woojung Huh, Microchip Linux Driver Support, netdev, linux-usb
Cc: linux-kernel, Pan Bian
In function lan78xx_probe(), variable ret takes the errno code on
failures. However, when the call to usb_alloc_urb() fails, its value
will keeps 0. 0 indicates success in the context, which is inconsistent
with the execution result. This patch fixes the bug, assigning
"-ENOMEM" to ret when usb_alloc_urb() returns a NULL pointer.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188771
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/net/usb/lan78xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index db558b8..f33460c 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -3395,6 +3395,7 @@ static int lan78xx_probe(struct usb_interface *intf,
if (buf) {
dev->urb_intr = usb_alloc_urb(0, GFP_KERNEL);
if (!dev->urb_intr) {
+ ret = -ENOMEM;
kfree(buf);
goto out3;
} else {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails
2016-12-03 11:24 [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails Pan Bian
@ 2016-12-05 16:20 ` Woojung.Huh
2016-12-05 18:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Woojung.Huh @ 2016-12-05 16:20 UTC (permalink / raw)
To: bianpan2016, UNGLinuxDriver, netdev, linux-usb; +Cc: linux-kernel
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/net/usb/lan78xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index db558b8..f33460c 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -3395,6 +3395,7 @@ static int lan78xx_probe(struct usb_interface *intf,
> if (buf) {
> dev->urb_intr = usb_alloc_urb(0, GFP_KERNEL);
> if (!dev->urb_intr) {
> + ret = -ENOMEM;
> kfree(buf);
> goto out3;
> } else {
> --
> 1.9.1
>
Acked-by: Woojung Huh <woojung.huh@microchip.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails
2016-12-03 11:24 [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails Pan Bian
2016-12-05 16:20 ` Woojung.Huh
@ 2016-12-05 18:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-05 18:27 UTC (permalink / raw)
To: bianpan2016; +Cc: woojung.huh, UNGLinuxDriver, netdev, linux-usb, linux-kernel
From: Pan Bian <bianpan2016@163.com>
Date: Sat, 3 Dec 2016 19:24:48 +0800
> In function lan78xx_probe(), variable ret takes the errno code on
> failures. However, when the call to usb_alloc_urb() fails, its value
> will keeps 0. 0 indicates success in the context, which is inconsistent
> with the execution result. This patch fixes the bug, assigning
> "-ENOMEM" to ret when usb_alloc_urb() returns a NULL pointer.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188771
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-05 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-03 11:24 [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails Pan Bian
2016-12-05 16:20 ` Woojung.Huh
2016-12-05 18:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).