From: Pan Bian <bianpan201602@163.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Eremin <dmitry.eremin@intel.com>,
Frank Zago <fzago@cray.com>
Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Pan Bian <bianpan2016@163.com>
Subject: [PATCH 1/1] staging: lustre: lnet: fix improper return value
Date: Sat, 3 Dec 2016 20:52:55 +0800 [thread overview]
Message-ID: <1480769575-6074-1-git-send-email-bianpan201602@163.com> (raw)
From: Pan Bian <bianpan2016@163.com>
At the end of function lstcon_group_info(), "return 0" seems improper.
It may be better to return the value of rc.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/staging/lustre/lnet/selftest/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
index a0fcbf3..9a7c41a 100644
--- a/drivers/staging/lustre/lnet/selftest/console.c
+++ b/drivers/staging/lustre/lnet/selftest/console.c
@@ -820,7 +820,7 @@
lstcon_group_decref(grp);
- return 0;
+ return rc;
}
static int
--
1.9.1
next reply other threads:[~2016-12-03 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 12:52 Pan Bian [this message]
2016-12-05 22:44 ` [PATCH 1/1] staging: lustre: lnet: fix improper return value Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480769575-6074-1-git-send-email-bianpan201602@163.com \
--to=bianpan201602@163.com \
--cc=andreas.dilger@intel.com \
--cc=bianpan2016@163.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=fzago@cray.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).