* [PATCH 1/1] staging: lustre: lnet: fix improper return value
@ 2016-12-03 12:52 Pan Bian
2016-12-05 22:44 ` Oleg Drokin
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2016-12-03 12:52 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman,
Dmitry Eremin, Frank Zago
Cc: lustre-devel, devel, linux-kernel, Pan Bian
From: Pan Bian <bianpan2016@163.com>
At the end of function lstcon_group_info(), "return 0" seems improper.
It may be better to return the value of rc.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/staging/lustre/lnet/selftest/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
index a0fcbf3..9a7c41a 100644
--- a/drivers/staging/lustre/lnet/selftest/console.c
+++ b/drivers/staging/lustre/lnet/selftest/console.c
@@ -820,7 +820,7 @@
lstcon_group_decref(grp);
- return 0;
+ return rc;
}
static int
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value
2016-12-03 12:52 [PATCH 1/1] staging: lustre: lnet: fix improper return value Pan Bian
@ 2016-12-05 22:44 ` Oleg Drokin
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Drokin @ 2016-12-05 22:44 UTC (permalink / raw)
To: Pan Bian
Cc: Andreas Dilger, James Simmons, Greg Kroah-Hartman,
Lustre Development List, devel@driverdev.osuosl.org SUBSYSTEM,
Linux Kernel Mailing List, Pan Bian
On Dec 3, 2016, at 7:52 AM, Pan Bian wrote:
> From: Pan Bian <bianpan2016@163.com>
>
> At the end of function lstcon_group_info(), "return 0" seems improper.
> It may be better to return the value of rc.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
> ---
> drivers/staging/lustre/lnet/selftest/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index a0fcbf3..9a7c41a 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -820,7 +820,7 @@
>
> lstcon_group_decref(grp);
>
> - return 0;
> + return rc;
> }
>
> static int
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-05 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-03 12:52 [PATCH 1/1] staging: lustre: lnet: fix improper return value Pan Bian
2016-12-05 22:44 ` Oleg Drokin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).