* [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-08 15:17 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran
` (10 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers
V4: Removed the not supported PCI Device Ids
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 8 +++++++-
drivers/scsi/megaraid/megaraid_sas_base.c | 14 +++++++++++++-
drivers/scsi/megaraid/megaraid_sas_fusion.c | 30 ++++++++++++++++++++++-------
3 files changed, 43 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 0d2625b..72e16c2 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -56,6 +56,11 @@
#define PCI_DEVICE_ID_LSI_INTRUDER_24 0x00cf
#define PCI_DEVICE_ID_LSI_CUTLASS_52 0x0052
#define PCI_DEVICE_ID_LSI_CUTLASS_53 0x0053
+#define PCI_DEVICE_ID_LSI_VENTURA 0x0014
+#define PCI_DEVICE_ID_LSI_HARPOON 0x0016
+#define PCI_DEVICE_ID_LSI_TOMCAT 0x0017
+#define PCI_DEVICE_ID_LSI_VENTURA_4PORT 0x001B
+#define PCI_DEVICE_ID_LSI_CRUSADER_4PORT 0x001C
/*
* Intel HBA SSDIDs
@@ -1478,7 +1483,7 @@ struct megasas_register_set {
u32 inbound_high_queue_port ; /*00C4h*/
- u32 reserved_5; /*00C8h*/
+ u32 inbound_single_queue_port; /*00C8h*/
u32 res_6[11]; /*CCh*/
u32 host_diag;
u32 seq_offset;
@@ -2143,6 +2148,7 @@ struct megasas_instance {
u8 is_rdpq;
bool dev_handle;
bool fw_sync_cache_support;
+ bool is_ventura;
};
struct MR_LD_VF_MAP {
u32 size;
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 5462676..efccf98 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -155,6 +155,12 @@ static int megasas_register_aen(struct megasas_instance *instance,
/* Intruder 24 port*/
{PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_CUTLASS_52)},
{PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_CUTLASS_53)},
+ /* VENTURA */
+ {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_VENTURA)},
+ {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_HARPOON)},
+ {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_TOMCAT)},
+ {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_VENTURA_4PORT)},
+ {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_CRUSADER_4PORT)},
{}
};
@@ -5723,6 +5729,12 @@ static int megasas_probe_one(struct pci_dev *pdev,
instance->pdev = pdev;
switch (instance->pdev->device) {
+ case PCI_DEVICE_ID_LSI_VENTURA:
+ case PCI_DEVICE_ID_LSI_HARPOON:
+ case PCI_DEVICE_ID_LSI_TOMCAT:
+ case PCI_DEVICE_ID_LSI_VENTURA_4PORT:
+ case PCI_DEVICE_ID_LSI_CRUSADER_4PORT:
+ instance->is_ventura = true;
case PCI_DEVICE_ID_LSI_FUSION:
case PCI_DEVICE_ID_LSI_PLASMA:
case PCI_DEVICE_ID_LSI_INVADER:
@@ -5747,7 +5759,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
if ((instance->pdev->device == PCI_DEVICE_ID_LSI_FUSION) ||
(instance->pdev->device == PCI_DEVICE_ID_LSI_PLASMA))
fusion->adapter_type = THUNDERBOLT_SERIES;
- else
+ else if (!instance->is_ventura)
fusion->adapter_type = INVADER_SERIES;
}
break;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 24778ba..8d7a397 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -189,15 +189,29 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
*/
static void
megasas_fire_cmd_fusion(struct megasas_instance *instance,
- union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc)
+ union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc, bool is_32bit)
{
+ struct megasas_register_set __iomem *regs = instance->reg_set;
+ unsigned long flags;
+
+ if (is_32bit)
+ writel(le32_to_cpu(req_desc->u.low),
+ &(regs)->inbound_single_queue_port);
+ else if (instance->is_ventura) {
+ spin_lock_irqsave(&instance->hba_lock, flags);
+ writel(le32_to_cpu(req_desc->u.low),
+ &(regs)->inbound_low_queue_port);
+ writel(le32_to_cpu(req_desc->u.high),
+ &(regs)->inbound_high_queue_port);
+ mmiowb();
+ spin_unlock_irqrestore(&instance->hba_lock, flags);
+ } else {
#if defined(writeq) && defined(CONFIG_64BIT)
u64 req_data = (((u64)le32_to_cpu(req_desc->u.high) << 32) |
le32_to_cpu(req_desc->u.low));
writeq(req_data, &instance->reg_set->inbound_low_queue_port);
#else
- unsigned long flags;
spin_lock_irqsave(&instance->hba_lock, flags);
writel(le32_to_cpu(req_desc->u.low),
@@ -207,6 +221,7 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
mmiowb();
spin_unlock_irqrestore(&instance->hba_lock, flags);
#endif
+ }
}
/**
@@ -850,7 +865,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
break;
}
- megasas_fire_cmd_fusion(instance, &req_desc);
+ megasas_fire_cmd_fusion(instance, &req_desc, false);
wait_and_poll(instance, cmd, MFI_POLL_TIMEOUT_SECS);
@@ -2224,7 +2239,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
*/
atomic_inc(&instance->fw_outstanding);
- megasas_fire_cmd_fusion(instance, req_desc);
+ megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
return 0;
}
@@ -2595,7 +2610,7 @@ irqreturn_t megasas_isr_fusion(int irq, void *devp)
return DCMD_NOT_FIRED;
}
- megasas_fire_cmd_fusion(instance, req_desc);
+ megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
return DCMD_SUCCESS;
}
@@ -2888,7 +2903,8 @@ void megasas_refire_mgmt_cmd(struct megasas_instance *instance)
cpu_to_le32(MR_DCMD_SYSTEM_PD_MAP_GET_INFO)))
&& !(cmd_mfi->flags & DRV_DCMD_SKIP_REFIRE);
if (refire_cmd)
- megasas_fire_cmd_fusion(instance, req_desc);
+ megasas_fire_cmd_fusion(instance, req_desc,
+ instance->is_ventura);
else
megasas_return_cmd(instance, cmd_mfi);
}
@@ -3067,7 +3083,7 @@ static int megasas_track_scsiio(struct megasas_instance *instance,
mr_request->tmReqFlags.isTMForLD = 1;
init_completion(&cmd_fusion->done);
- megasas_fire_cmd_fusion(instance, req_desc);
+ megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
timeleft = wait_for_completion_timeout(&cmd_fusion->done, 50 * HZ);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
2016-12-06 23:00 ` [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-08 15:34 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
` (9 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X vectors,
resulting in the need to support 128 reply queues
This patch is depending on patch 1
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 1 +
drivers/scsi/megaraid/megaraid_sas_base.c | 24 +++++++++++++++++-------
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
3 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 72e16c2..9d4ca8d 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -2149,6 +2149,7 @@ struct megasas_instance {
bool dev_handle;
bool fw_sync_cache_support;
bool is_ventura;
+ bool msix_combined;
};
struct MR_LD_VF_MAP {
u32 size;
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index efccf98..c583e0b 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5086,13 +5086,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
goto fail_ready_state;
}
- /*
- * MSI-X host index 0 is common for all adapter.
- * It is used for all MPT based Adapters.
- */
- instance->reply_post_host_index_addr[0] =
- (u32 __iomem *)((u8 __iomem *)instance->reg_set +
- MPI2_REPLY_POST_HOST_INDEX_OFFSET);
+
/* Check if MSI-X is supported while in ready state */
msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
@@ -5110,6 +5104,9 @@ static int megasas_init_fw(struct megasas_instance *instance)
instance->msix_vectors = ((scratch_pad_2
& MR_MAX_REPLY_QUEUES_EXT_OFFSET)
>> MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT) + 1;
+ if (instance->msix_vectors > 16)
+ instance->msix_combined = true;
+
if (rdpq_enable)
instance->is_rdpq = (scratch_pad_2 & MR_RDPQ_MODE_OFFSET) ?
1 : 0;
@@ -5143,6 +5140,19 @@ static int megasas_init_fw(struct megasas_instance *instance)
else
instance->msix_vectors = 0;
}
+ /*
+ * MSI-X host index 0 is common for all adapter.
+ * It is used for all MPT based Adapters.
+ */
+ if (instance->msix_combined) {
+ instance->reply_post_host_index_addr[0] =
+ (u32 *)((u8 *)instance->reg_set +
+ MPI2_SUP_REPLY_POST_HOST_INDEX_OFFSET);
+ } else {
+ instance->reply_post_host_index_addr[0] =
+ (u32 *)((u8 *)instance->reg_set +
+ MPI2_REPLY_POST_HOST_INDEX_OFFSET);
+ }
dev_info(&instance->pdev->dev,
"firmware supports msix\t: (%d)", fw_msix_count);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 8d7a397..413e2030 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2391,7 +2391,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
* pending to be completed
*/
if (threshold_reply_count >= THRESHOLD_REPLY_COUNT) {
- if (fusion->adapter_type == INVADER_SERIES)
+ if (instance->msix_combined)
writel(((MSIxIndex & 0x7) << 24) |
fusion->last_reply_idx[MSIxIndex],
instance->reply_post_host_index_addr[MSIxIndex/8]);
@@ -2407,7 +2407,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
return IRQ_NONE;
wmb();
- if (fusion->adapter_type == INVADER_SERIES)
+ if (instance->msix_combined)
writel(((MSIxIndex & 0x7) << 24) |
fusion->last_reply_idx[MSIxIndex],
instance->reply_post_host_index_addr[MSIxIndex/8]);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
2016-12-06 23:00 ` [PATCH V4 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran
@ 2016-12-08 15:34 ` Tomas Henzl
2016-12-14 21:43 ` Sasikumar PC
2016-12-20 1:50 ` Sasikumar PC
0 siblings, 2 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-08 15:34 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X vectors,
> resulting in the need to support 128 reply queues
>
> This patch is depending on patch 1
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 1 +
> drivers/scsi/megaraid/megaraid_sas_base.c | 24 +++++++++++++++++-------
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
> 3 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index 72e16c2..9d4ca8d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -2149,6 +2149,7 @@ struct megasas_instance {
> bool dev_handle;
> bool fw_sync_cache_support;
> bool is_ventura;
> + bool msix_combined;
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index efccf98..c583e0b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5086,13 +5086,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
> goto fail_ready_state;
> }
>
> - /*
> - * MSI-X host index 0 is common for all adapter.
> - * It is used for all MPT based Adapters.
> - */
> - instance->reply_post_host_index_addr[0] =
> - (u32 __iomem *)((u8 __iomem *)instance->reg_set +
> - MPI2_REPLY_POST_HOST_INDEX_OFFSET);
> +
>
> /* Check if MSI-X is supported while in ready state */
> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
> @@ -5110,6 +5104,9 @@ static int megasas_init_fw(struct megasas_instance *instance)
> instance->msix_vectors = ((scratch_pad_2
> & MR_MAX_REPLY_QUEUES_EXT_OFFSET)
> >> MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT) + 1;
> + if (instance->msix_vectors > 16)
> + instance->msix_combined = true;
> +
> if (rdpq_enable)
> instance->is_rdpq = (scratch_pad_2 & MR_RDPQ_MODE_OFFSET) ?
> 1 : 0;
> @@ -5143,6 +5140,19 @@ static int megasas_init_fw(struct megasas_instance *instance)
> else
> instance->msix_vectors = 0;
> }
Have you tested this patch with the pci=nomsi kernel option?
is it safe when msix_combined is true and pci_enable_msix_range
fails so instance->msix_vectors is zero?
tomash
> + /*
> + * MSI-X host index 0 is common for all adapter.
> + * It is used for all MPT based Adapters.
> + */
> + if (instance->msix_combined) {
> + instance->reply_post_host_index_addr[0] =
> + (u32 *)((u8 *)instance->reg_set +
> + MPI2_SUP_REPLY_POST_HOST_INDEX_OFFSET);
> + } else {
> + instance->reply_post_host_index_addr[0] =
> + (u32 *)((u8 *)instance->reg_set +
> + MPI2_REPLY_POST_HOST_INDEX_OFFSET);
> + }
>
> dev_info(&instance->pdev->dev,
> "firmware supports msix\t: (%d)", fw_msix_count);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 8d7a397..413e2030 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -2391,7 +2391,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> * pending to be completed
> */
> if (threshold_reply_count >= THRESHOLD_REPLY_COUNT) {
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (instance->msix_combined)
> writel(((MSIxIndex & 0x7) << 24) |
> fusion->last_reply_idx[MSIxIndex],
> instance->reply_post_host_index_addr[MSIxIndex/8]);
> @@ -2407,7 +2407,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> return IRQ_NONE;
>
> wmb();
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (instance->msix_combined)
> writel(((MSIxIndex & 0x7) << 24) |
> fusion->last_reply_idx[MSIxIndex],
> instance->reply_post_host_index_addr[MSIxIndex/8]);
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
2016-12-08 15:34 ` Tomas Henzl
@ 2016-12-14 21:43 ` Sasikumar PC
2016-12-20 1:50 ` Sasikumar PC
1 sibling, 0 replies; 40+ messages in thread
From: Sasikumar PC @ 2016-12-14 21:43 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Thursday, December 08, 2016 10:35 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> SAS3.5 Generic Megaraid based Controllers will have the support for
> 128 MSI-X vectors, resulting in the need to support 128 reply queues
>
> This patch is depending on patch 1
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 1 +
> drivers/scsi/megaraid/megaraid_sas_base.c | 24
+++++++++++++++++-------
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
> 3 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
> index 72e16c2..9d4ca8d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -2149,6 +2149,7 @@ struct megasas_instance {
> bool dev_handle;
> bool fw_sync_cache_support;
> bool is_ventura;
> + bool msix_combined;
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index efccf98..c583e0b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5086,13 +5086,7 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> goto fail_ready_state;
> }
>
> - /*
> - * MSI-X host index 0 is common for all adapter.
> - * It is used for all MPT based Adapters.
> - */
> - instance->reply_post_host_index_addr[0] =
> - (u32 __iomem *)((u8 __iomem *)instance->reg_set +
> - MPI2_REPLY_POST_HOST_INDEX_OFFSET);
> +
>
> /* Check if MSI-X is supported while in ready state */
> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
@@
> -5110,6 +5104,9 @@ static int megasas_init_fw(struct megasas_instance
*instance)
> instance->msix_vectors = ((scratch_pad_2
> & MR_MAX_REPLY_QUEUES_EXT_OFFSET)
> >>
MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT) + 1;
> + if (instance->msix_vectors > 16)
> + instance->msix_combined = true;
> +
> if (rdpq_enable)
> instance->is_rdpq = (scratch_pad_2
& MR_RDPQ_MODE_OFFSET) ?
> 1 : 0;
> @@ -5143,6 +5140,19 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> else
> instance->msix_vectors = 0;
> }
Have you tested this patch with the pci=nomsi kernel option?
Sasi - Driver is tested with pci=nomsi option and looking good
is it safe when msix_combined is true and pci_enable_msix_range fails so
instance->msix_vectors is zero?
Sasi - I am working on this and will be posting the update soon
tomash
> + /*
> + * MSI-X host index 0 is common for all adapter.
> + * It is used for all MPT based Adapters.
> + */
> + if (instance->msix_combined) {
> + instance->reply_post_host_index_addr[0] =
> + (u32 *)((u8 *)instance->reg_set +
> + MPI2_SUP_REPLY_POST_HOST_INDEX_OFFSET);
> + } else {
> + instance->reply_post_host_index_addr[0] =
> + (u32 *)((u8 *)instance->reg_set +
> + MPI2_REPLY_POST_HOST_INDEX_OFFSET);
> + }
>
> dev_info(&instance->pdev->dev,
> "firmware supports msix\t: (%d)", fw_msix_count); diff
--git
> a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 8d7a397..413e2030 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -2391,7 +2391,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> * pending to be completed
> */
> if (threshold_reply_count >= THRESHOLD_REPLY_COUNT) {
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (instance->msix_combined)
> writel(((MSIxIndex & 0x7) << 24) |
> fusion->last_reply_idx[MSIxIndex],
>
instance->reply_post_host_index_addr[MSIxIndex/8]);
> @@ -2407,7 +2407,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> return IRQ_NONE;
>
> wmb();
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (instance->msix_combined)
> writel(((MSIxIndex & 0x7) << 24) |
> fusion->last_reply_idx[MSIxIndex],
>
instance->reply_post_host_index_addr[MSIxIndex/8]);
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
2016-12-08 15:34 ` Tomas Henzl
2016-12-14 21:43 ` Sasikumar PC
@ 2016-12-20 1:50 ` Sasikumar PC
2016-12-20 14:16 ` Tomas Henzl
1 sibling, 1 reply; 40+ messages in thread
From: Sasikumar PC @ 2016-12-20 1:50 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Sasikumar PC [mailto:sasikumar.pc@broadcom.com]
Sent: Wednesday, December 14, 2016 4:43 PM
To: 'Tomas Henzl'; 'jejb@kernel.org'; 'hch@infradead.org'
Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;
'linux-kernel@vger.kernel.org'; Christopher Owens; Kiran Kumar Kasturi
Subject: RE: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Thursday, December 08, 2016 10:35 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> SAS3.5 Generic Megaraid based Controllers will have the support for
> 128 MSI-X vectors, resulting in the need to support 128 reply queues
>
> This patch is depending on patch 1
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 1 +
> drivers/scsi/megaraid/megaraid_sas_base.c | 24
+++++++++++++++++-------
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
> 3 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
> index 72e16c2..9d4ca8d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -2149,6 +2149,7 @@ struct megasas_instance {
> bool dev_handle;
> bool fw_sync_cache_support;
> bool is_ventura;
> + bool msix_combined;
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index efccf98..c583e0b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5086,13 +5086,7 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> goto fail_ready_state;
> }
>
> - /*
> - * MSI-X host index 0 is common for all adapter.
> - * It is used for all MPT based Adapters.
> - */
> - instance->reply_post_host_index_addr[0] =
> - (u32 __iomem *)((u8 __iomem *)instance->reg_set +
> - MPI2_REPLY_POST_HOST_INDEX_OFFSET);
> +
>
> /* Check if MSI-X is supported while in ready state */
> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
@@
> -5110,6 +5104,9 @@ static int megasas_init_fw(struct megasas_instance
*instance)
> instance->msix_vectors = ((scratch_pad_2
> & MR_MAX_REPLY_QUEUES_EXT_OFFSET)
> >>
MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT) + 1;
> + if (instance->msix_vectors > 16)
> + instance->msix_combined = true;
> +
> if (rdpq_enable)
> instance->is_rdpq = (scratch_pad_2
& MR_RDPQ_MODE_OFFSET) ?
> 1 : 0;
> @@ -5143,6 +5140,19 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> else
> instance->msix_vectors = 0;
> }
Have you tested this patch with the pci=nomsi kernel option?
Sasi - Driver is tested with pci=nomsi option and looking good
is it safe when msix_combined is true and pci_enable_msix_range fails so
instance->msix_vectors is zero?
msix_combined mode is dependent on how many vectors adapter supports, not
the actual vectors used.
It is correct to be in combined mode even if actual number of msix_vectors
used are fewer than 16, if hardware is in combined mode
Sasi
tomash
> + /*
> + * MSI-X host index 0 is common for all adapter.
> + * It is used for all MPT based Adapters.
> + */
> + if (instance->msix_combined) {
> + instance->reply_post_host_index_addr[0] =
> + (u32 *)((u8 *)instance->reg_set +
> + MPI2_SUP_REPLY_POST_HOST_INDEX_OFFSET);
> + } else {
> + instance->reply_post_host_index_addr[0] =
> + (u32 *)((u8 *)instance->reg_set +
> + MPI2_REPLY_POST_HOST_INDEX_OFFSET);
> + }
>
> dev_info(&instance->pdev->dev,
> "firmware supports msix\t: (%d)", fw_msix_count); diff
--git
> a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 8d7a397..413e2030 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -2391,7 +2391,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> * pending to be completed
> */
> if (threshold_reply_count >= THRESHOLD_REPLY_COUNT) {
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (instance->msix_combined)
> writel(((MSIxIndex & 0x7) << 24) |
> fusion->last_reply_idx[MSIxIndex],
>
instance->reply_post_host_index_addr[MSIxIndex/8]);
> @@ -2407,7 +2407,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> return IRQ_NONE;
>
> wmb();
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (instance->msix_combined)
> writel(((MSIxIndex & 0x7) << 24) |
> fusion->last_reply_idx[MSIxIndex],
>
instance->reply_post_host_index_addr[MSIxIndex/8]);
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
2016-12-20 1:50 ` Sasikumar PC
@ 2016-12-20 14:16 ` Tomas Henzl
0 siblings, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-20 14:16 UTC (permalink / raw)
To: Sasikumar PC, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
On 20.12.2016 02:50, Sasikumar PC wrote:
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Sasikumar PC [mailto:sasikumar.pc@broadcom.com]
> Sent: Wednesday, December 14, 2016 4:43 PM
> To: 'Tomas Henzl'; 'jejb@kernel.org'; 'hch@infradead.org'
> Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;
> 'linux-kernel@vger.kernel.org'; Christopher Owens; Kiran Kumar Kasturi
> Subject: RE: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
>
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Thursday, December 08, 2016 10:35 AM
> To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
> Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
> linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
> kiran-kumar.kasturi@broadcom.com
> Subject: Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support
>
> On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
>> SAS3.5 Generic Megaraid based Controllers will have the support for
>> 128 MSI-X vectors, resulting in the need to support 128 reply queues
>>
>> This patch is depending on patch 1
>>
>> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
>> ---
>> drivers/scsi/megaraid/megaraid_sas.h | 1 +
>> drivers/scsi/megaraid/megaraid_sas_base.c | 24
> +++++++++++++++++-------
>> drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
>> 3 files changed, 20 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
>> b/drivers/scsi/megaraid/megaraid_sas.h
>> index 72e16c2..9d4ca8d 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>> @@ -2149,6 +2149,7 @@ struct megasas_instance {
>> bool dev_handle;
>> bool fw_sync_cache_support;
>> bool is_ventura;
>> + bool msix_combined;
>> };
>> struct MR_LD_VF_MAP {
>> u32 size;
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>> b/drivers/scsi/megaraid/megaraid_sas_base.c
>> index efccf98..c583e0b 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>> @@ -5086,13 +5086,7 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>> goto fail_ready_state;
>> }
>>
>> - /*
>> - * MSI-X host index 0 is common for all adapter.
>> - * It is used for all MPT based Adapters.
>> - */
>> - instance->reply_post_host_index_addr[0] =
>> - (u32 __iomem *)((u8 __iomem *)instance->reg_set +
>> - MPI2_REPLY_POST_HOST_INDEX_OFFSET);
>> +
>>
>> /* Check if MSI-X is supported while in ready state */
>> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
> @@
>> -5110,6 +5104,9 @@ static int megasas_init_fw(struct megasas_instance
> *instance)
>> instance->msix_vectors = ((scratch_pad_2
>> & MR_MAX_REPLY_QUEUES_EXT_OFFSET)
>> >>
> MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT) + 1;
>> + if (instance->msix_vectors > 16)
>> + instance->msix_combined = true;
>> +
>> if (rdpq_enable)
>> instance->is_rdpq = (scratch_pad_2
> & MR_RDPQ_MODE_OFFSET) ?
>> 1 : 0;
>> @@ -5143,6 +5140,19 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>> else
>> instance->msix_vectors = 0;
>> }
> Have you tested this patch with the pci=nomsi kernel option?
> Sasi - Driver is tested with pci=nomsi option and looking good
>
> is it safe when msix_combined is true and pci_enable_msix_range fails so
> instance->msix_vectors is zero?
>
> msix_combined mode is dependent on how many vectors adapter supports, not
> the actual vectors used.
> It is correct to be in combined mode even if actual number of msix_vectors
> used are fewer than 16, if hardware is in combined mode
Ok, thanks for explanation.
>
> Sasi
>
>
> tomash
>
>> + /*
>> + * MSI-X host index 0 is common for all adapter.
>> + * It is used for all MPT based Adapters.
>> + */
>> + if (instance->msix_combined) {
>> + instance->reply_post_host_index_addr[0] =
>> + (u32 *)((u8 *)instance->reg_set +
>> + MPI2_SUP_REPLY_POST_HOST_INDEX_OFFSET);
>> + } else {
>> + instance->reply_post_host_index_addr[0] =
>> + (u32 *)((u8 *)instance->reg_set +
>> + MPI2_REPLY_POST_HOST_INDEX_OFFSET);
>> + }
>>
>> dev_info(&instance->pdev->dev,
>> "firmware supports msix\t: (%d)", fw_msix_count); diff
> --git
>> a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> index 8d7a397..413e2030 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> @@ -2391,7 +2391,7 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> * pending to be completed
>> */
>> if (threshold_reply_count >= THRESHOLD_REPLY_COUNT) {
>> - if (fusion->adapter_type == INVADER_SERIES)
>> + if (instance->msix_combined)
>> writel(((MSIxIndex & 0x7) << 24) |
>> fusion->last_reply_idx[MSIxIndex],
>>
> instance->reply_post_host_index_addr[MSIxIndex/8]);
>> @@ -2407,7 +2407,7 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> return IRQ_NONE;
>>
>> wmb();
>> - if (fusion->adapter_type == INVADER_SERIES)
>> + if (instance->msix_combined)
>> writel(((MSIxIndex & 0x7) << 24) |
>> fusion->last_reply_idx[MSIxIndex],
>>
> instance->reply_post_host_index_addr[MSIxIndex/8]);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
2016-12-06 23:00 ` [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-06 23:00 ` [PATCH V4 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-08 15:35 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
` (8 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
An UNMAP command on a PI formatted device will leave the Logical Block Application
Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped).
To avoid IO errors if those LBAs are subsequently read before they are written with
valid tag fields, the MPI SCSI IO requests need to set the EEDPFlags element EEDP
Escape Mode field, Bits [7:6] appropriately. A value of 2 should be set to disable
all PI checks if the Logical Block Application Tag is 0xFFFF for PI types 1 and 2.
A value of 3 should be set to disable all PI checks if the Logical Block Application
Tag is 0xFFFF and the Logical Block Reference Tag is 0xFFFFFFFF for PI type 3.
This patch is depending on patch 2
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 413e2030..fe69c4a 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1589,6 +1589,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
MPI2_SCSIIO_EEDPFLAGS_CHECK_REFTAG |
MPI2_SCSIIO_EEDPFLAGS_CHECK_REMOVE_OP |
MPI2_SCSIIO_EEDPFLAGS_CHECK_APPTAG |
+ MPI25_SCSIIO_EEDPFLAGS_DO_NOT_DISABLE_MODE |
MPI2_SCSIIO_EEDPFLAGS_CHECK_GUARD);
} else {
io_request->EEDPFlags = cpu_to_le16(
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index e3bee04..9d22ade 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -175,6 +175,8 @@ enum REGION_TYPE {
#define MPI2_SCSIIO_EEDPFLAGS_CHECK_APPTAG (0x0200)
#define MPI2_SCSIIO_EEDPFLAGS_CHECK_GUARD (0x0100)
#define MPI2_SCSIIO_EEDPFLAGS_INSERT_OP (0x0004)
+/* EEDP escape mode */
+#define MPI25_SCSIIO_EEDPFLAGS_DO_NOT_DISABLE_MODE (0x0040)
#define MPI2_FUNCTION_SCSI_IO_REQUEST (0x00) /* SCSI IO */
#define MPI2_FUNCTION_SCSI_TASK_MGMT (0x01)
#define MPI2_REQ_DESCRIPT_FLAGS_HIGH_PRIORITY (0x03)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers
2016-12-06 23:00 ` [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
@ 2016-12-08 15:35 ` Tomas Henzl
0 siblings, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-08 15:35 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> An UNMAP command on a PI formatted device will leave the Logical Block Application
> Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped).
> To avoid IO errors if those LBAs are subsequently read before they are written with
> valid tag fields, the MPI SCSI IO requests need to set the EEDPFlags element EEDP
> Escape Mode field, Bits [7:6] appropriately. A value of 2 should be set to disable
> all PI checks if the Logical Block Application Tag is 0xFFFF for PI types 1 and 2.
> A value of 3 should be set to disable all PI checks if the Logical Block Application
> Tag is 0xFFFF and the Logical Block Reference Tag is 0xFFFFFFFF for PI type 3.
>
> This patch is depending on patch 2
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (2 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-08 16:00 ` Tomas Henzl
2016-12-12 16:38 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran
` (7 subsequent siblings)
11 siblings, 2 replies; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
Detect sequential IO streams and pass those IOs directly to FW.
This patch is depending on patch 3
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 5 +-
drivers/scsi/megaraid/megaraid_sas_base.c | 43 +++++++-
drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +
drivers/scsi/megaraid/megaraid_sas_fusion.c | 164 +++++++++++++++++++++++-----
drivers/scsi/megaraid/megaraid_sas_fusion.h | 117 +++++++++++++++++++-
5 files changed, 298 insertions(+), 33 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 9d4ca8d..d07b3e1 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -105,7 +105,7 @@
*/
/*
- * MFI stands for MegaRAID SAS FW Interface. This is just a moniker for
+ * MFI stands for MegaRAID SAS FW Interface. This is just a moniker for
* protocol between the software and firmware. Commands are issued using
* "message frames"
*/
@@ -1440,7 +1440,7 @@ enum FW_BOOT_CONTEXT {
* register set for both 1068 and 1078 controllers
* structure extended for 1078 registers
*/
-
+
struct megasas_register_set {
u32 doorbell; /*0000h*/
u32 fusion_seq_offset; /*0004h*/
@@ -2070,6 +2070,7 @@ struct megasas_instance {
/* used to sync fire the cmd to fw */
spinlock_t hba_lock;
/* used to synch producer, consumer ptrs in dpc */
+ spinlock_t stream_lock;
spinlock_t completion_lock;
struct dma_pool *frame_dma_pool;
struct dma_pool *sense_dma_pool;
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index c583e0b..c52f7be 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5015,7 +5015,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
struct megasas_register_set __iomem *reg_set;
struct megasas_ctrl_info *ctrl_info = NULL;
unsigned long bar_list;
- int i, loop, fw_msix_count = 0;
+ int i, j, loop, fw_msix_count = 0;
struct IOV_111 *iovPtr;
struct fusion_context *fusion;
@@ -5202,6 +5202,36 @@ static int megasas_init_fw(struct megasas_instance *instance)
}
memset(instance->ld_ids, 0xff, MEGASAS_MAX_LD_IDS);
+
+ /* stream detection initialization */
+ if (instance->is_ventura) {
+ fusion->stream_detect_by_ld =
+ kzalloc(sizeof(struct LD_STREAM_DETECT *)
+ * MAX_LOGICAL_DRIVES_EXT,
+ GFP_KERNEL);
+ if (!fusion->stream_detect_by_ld) {
+ dev_err(&instance->pdev->dev,
+ "unable to allocate stream detection for pool of LDs\n");
+ goto fail_get_ld_pd_list;
+ }
+ for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i) {
+ fusion->stream_detect_by_ld[i] =
+ kmalloc(sizeof(struct LD_STREAM_DETECT),
+ GFP_KERNEL);
+ if (!fusion->stream_detect_by_ld[i]) {
+ dev_err(&instance->pdev->dev,
+ "unable to allocate stream detect by LD\n ");
+ for (j = 0; j < i; ++j)
+ kfree(fusion->stream_detect_by_ld[j]);
+ kfree(fusion->stream_detect_by_ld);
+ fusion->stream_detect_by_ld = NULL;
+ goto fail_get_ld_pd_list;
+ }
+ fusion->stream_detect_by_ld[i]->mru_bit_map
+ = MR_STREAM_BITMAP;
+ }
+ }
+
if (megasas_ld_list_query(instance,
MR_LD_QUERY_TYPE_EXPOSED_TO_HOST))
megasas_get_ld_list(instance);
@@ -5321,6 +5351,8 @@ static int megasas_init_fw(struct megasas_instance *instance)
return 0;
+fail_get_ld_pd_list:
+ instance->instancet->disable_intr(instance);
fail_get_pd_list:
instance->instancet->disable_intr(instance);
megasas_destroy_irqs(instance);
@@ -5854,6 +5886,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
spin_lock_init(&instance->mfi_pool_lock);
spin_lock_init(&instance->hba_lock);
+ spin_lock_init(&instance->stream_lock);
spin_lock_init(&instance->completion_lock);
mutex_init(&instance->reset_mutex);
@@ -6354,6 +6387,14 @@ static void megasas_detach_one(struct pci_dev *pdev)
if (instance->msix_vectors)
pci_disable_msix(instance->pdev);
+ if (instance->is_ventura) {
+ for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i)
+ kfree(fusion->stream_detect_by_ld[i]);
+ kfree(fusion->stream_detect_by_ld);
+ fusion->stream_detect_by_ld = NULL;
+ }
+
+
if (instance->ctrl_context) {
megasas_release_fusion(instance);
pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
index f237d00..a4e213b 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
@@ -935,6 +935,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
ld = MR_TargetIdToLdGet(ldTgtId, map);
raid = MR_LdRaidGet(ld, map);
+ /*check read ahead bit*/
+ io_info->ra_capable = raid->capability.ra_capable;
/*
* if rowDataSize @RAID map and spanRowDataSize @SPAN INFO are zero
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index fe69c4a..39dad6d 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1704,6 +1704,89 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
}
/**
+ * megasas_stream_detect - stream detection on read and and write IOs
+ * @instance: Adapter soft state
+ * @cmd: Command to be prepared
+ * @io_info: IO Request info
+ *
+ */
+
+/** stream detection on read and and write IOs */
+static void megasas_stream_detect(struct megasas_instance *instance,
+ struct megasas_cmd_fusion *cmd,
+ struct IO_REQUEST_INFO *io_info)
+{
+ struct fusion_context *fusion = instance->ctrl_context;
+ u32 device_id = io_info->ldTgtId;
+ struct LD_STREAM_DETECT *current_ld_sd
+ = fusion->stream_detect_by_ld[device_id];
+ u32 *track_stream = ¤t_ld_sd->mru_bit_map, stream_num;
+ u32 shifted_values, unshifted_values;
+ u32 index_value_mask, shifted_values_mask;
+ int i;
+ bool is_read_ahead = false;
+ struct STREAM_DETECT *current_sd;
+ /* find possible stream */
+ for (i = 0; i < MAX_STREAMS_TRACKED; ++i) {
+ stream_num =
+ (*track_stream >> (i * BITS_PER_INDEX_STREAM)) &
+ STREAM_MASK;
+ current_sd = ¤t_ld_sd->stream_track[stream_num];
+ /* if we found a stream, update the raid
+ * context and also update the mruBitMap
+ */
+ /* boundary condition */
+ if (current_sd->next_seq_lba &&
+ io_info->ldStartBlock >= current_sd->next_seq_lba &&
+ (io_info->ldStartBlock <= (current_sd->next_seq_lba+32)) &&
+ (current_sd->is_read == io_info->isRead)) {
+ if ((io_info->ldStartBlock != current_sd->next_seq_lba) &&
+ ((!io_info->isRead) || (!is_read_ahead)))
+ /*
+ * Once the API availible we need to change this.
+ * At this point we are not allowing any gap
+ */
+ continue;
+ cmd->io_request->RaidContext.raid_context_g35.stream_detected
+ = true;
+ current_sd->next_seq_lba =
+ io_info->ldStartBlock + io_info->numBlocks;
+ /*
+ * update the mruBitMap LRU
+ */
+ shifted_values_mask =
+ (1 << i * BITS_PER_INDEX_STREAM) - 1;
+ shifted_values = ((*track_stream & shifted_values_mask)
+ << BITS_PER_INDEX_STREAM);
+ index_value_mask =
+ STREAM_MASK << i * BITS_PER_INDEX_STREAM;
+ unshifted_values =
+ *track_stream & ~(shifted_values_mask |
+ index_value_mask);
+ *track_stream =
+ unshifted_values | shifted_values | stream_num;
+ return;
+
+ }
+
+ }
+ /*
+ * if we did not find any stream, create a new one
+ * from the least recently used
+ */
+ stream_num =
+ (*track_stream >> ((MAX_STREAMS_TRACKED - 1) * BITS_PER_INDEX_STREAM)) &
+ STREAM_MASK;
+ current_sd = ¤t_ld_sd->stream_track[stream_num];
+ current_sd->is_read = io_info->isRead;
+ current_sd->next_seq_lba = io_info->ldStartBlock + io_info->numBlocks;
+ *track_stream =
+ (((*track_stream & ZERO_LAST_STREAM) << 4) | stream_num);
+ return;
+
+}
+
+/**
* megasas_build_ldio_fusion - Prepares IOs to devices
* @instance: Adapter soft state
* @scp: SCSI command
@@ -1725,15 +1808,17 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
struct fusion_context *fusion;
struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
u8 *raidLUN;
+ unsigned long spinlock_flags;
device_id = MEGASAS_DEV_INDEX(scp);
fusion = instance->ctrl_context;
io_request = cmd->io_request;
- io_request->RaidContext.VirtualDiskTgtId = cpu_to_le16(device_id);
- io_request->RaidContext.status = 0;
- io_request->RaidContext.exStatus = 0;
+ io_request->RaidContext.raid_context.VirtualDiskTgtId =
+ cpu_to_le16(device_id);
+ io_request->RaidContext.raid_context.status = 0;
+ io_request->RaidContext.raid_context.exStatus = 0;
req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION *)cmd->request_desc;
@@ -1804,11 +1889,11 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
instance->fw_supported_vd_count) || (!fusion->fast_path_io)) {
- io_request->RaidContext.regLockFlags = 0;
+ io_request->RaidContext.raid_context.regLockFlags = 0;
fp_possible = 0;
} else {
if (MR_BuildRaidContext(instance, &io_info,
- &io_request->RaidContext,
+ &io_request->RaidContext.raid_context,
local_map_ptr, &raidLUN))
fp_possible = io_info.fpOkForIo;
}
@@ -1819,6 +1904,18 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
cmd->request_desc->SCSIIO.MSIxIndex = instance->msix_vectors ?
raw_smp_processor_id() % instance->msix_vectors : 0;
+ if (instance->is_ventura) {
+ spin_lock_irqsave(&instance->stream_lock, spinlock_flags);
+ megasas_stream_detect(instance, cmd, &io_info);
+ spin_unlock_irqrestore(&instance->stream_lock, spinlock_flags);
+ /* In ventura if stream detected for a read and it is read ahead
+ * capable make this IO as LDIO
+ */
+ if (io_request->RaidContext.raid_context_g35.stream_detected &&
+ io_info.isRead && io_info.ra_capable)
+ fp_possible = false;
+ }
+
if (fp_possible) {
megasas_set_pd_lba(io_request, scp->cmd_len, &io_info, scp,
local_map_ptr, start_lba_lo);
@@ -1827,15 +1924,16 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
(MPI2_REQ_DESCRIPT_FLAGS_FP_IO
<< MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
if (fusion->adapter_type == INVADER_SERIES) {
- if (io_request->RaidContext.regLockFlags ==
+ if (io_request->RaidContext.raid_context.regLockFlags ==
REGION_TYPE_UNUSED)
cmd->request_desc->SCSIIO.RequestFlags =
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
- io_request->RaidContext.Type = MPI2_TYPE_CUDA;
- io_request->RaidContext.nseg = 0x1;
+ io_request->RaidContext.raid_context.Type
+ = MPI2_TYPE_CUDA;
+ io_request->RaidContext.raid_context.nseg = 0x1;
io_request->IoFlags |= cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
- io_request->RaidContext.regLockFlags |=
+ io_request->RaidContext.raid_context.regLockFlags |=
(MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
MR_RL_FLAGS_SEQ_NUM_ENABLE);
}
@@ -1862,22 +1960,24 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
/* populate the LUN field */
memcpy(io_request->LUN, raidLUN, 8);
} else {
- io_request->RaidContext.timeoutValue =
+ io_request->RaidContext.raid_context.timeoutValue =
cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
cmd->request_desc->SCSIIO.RequestFlags =
(MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
<< MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
if (fusion->adapter_type == INVADER_SERIES) {
if (io_info.do_fp_rlbypass ||
- (io_request->RaidContext.regLockFlags == REGION_TYPE_UNUSED))
+ (io_request->RaidContext.raid_context.regLockFlags
+ == REGION_TYPE_UNUSED))
cmd->request_desc->SCSIIO.RequestFlags =
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
- io_request->RaidContext.Type = MPI2_TYPE_CUDA;
- io_request->RaidContext.regLockFlags |=
+ io_request->RaidContext.raid_context.Type
+ = MPI2_TYPE_CUDA;
+ io_request->RaidContext.raid_context.regLockFlags |=
(MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
MR_RL_FLAGS_SEQ_NUM_ENABLE);
- io_request->RaidContext.nseg = 0x1;
+ io_request->RaidContext.raid_context.nseg = 0x1;
}
io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
io_request->DevHandle = cpu_to_le16(device_id);
@@ -1913,7 +2013,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
/* get RAID_Context pointer */
- pRAID_Context = &io_request->RaidContext;
+ pRAID_Context = &io_request->RaidContext.raid_context;
/* Check with FW team */
pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
pRAID_Context->regLockRowLBA = 0;
@@ -2000,7 +2100,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
io_request = cmd->io_request;
/* get RAID_Context pointer */
- pRAID_Context = &io_request->RaidContext;
+ pRAID_Context = &io_request->RaidContext.raid_context;
pRAID_Context->regLockFlags = 0;
pRAID_Context->regLockRowLBA = 0;
pRAID_Context->regLockLength = 0;
@@ -2094,9 +2194,9 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
io_request->Control = 0;
io_request->EEDPBlockSize = 0;
io_request->ChainOffset = 0;
- io_request->RaidContext.RAIDFlags = 0;
- io_request->RaidContext.Type = 0;
- io_request->RaidContext.nseg = 0;
+ io_request->RaidContext.raid_context.RAIDFlags = 0;
+ io_request->RaidContext.raid_context.Type = 0;
+ io_request->RaidContext.raid_context.nseg = 0;
memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
/*
@@ -2143,8 +2243,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
/* numSGE store lower 8 bit of sge_count.
* numSGEExt store higher 8 bit of sge_count
*/
- io_request->RaidContext.numSGE = sge_count;
- io_request->RaidContext.numSGEExt = (u8)(sge_count >> 8);
+ io_request->RaidContext.raid_context.numSGE = sge_count;
+ io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >> 8);
io_request->SGLFlags = cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
@@ -2303,8 +2403,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
cmd_fusion->scmd->SCp.ptr = NULL;
scmd_local = cmd_fusion->scmd;
- status = scsi_io_req->RaidContext.status;
- extStatus = scsi_io_req->RaidContext.exStatus;
+ status = scsi_io_req->RaidContext.raid_context.status;
+ extStatus = scsi_io_req->RaidContext.raid_context.exStatus;
switch (scsi_io_req->Function) {
case MPI2_FUNCTION_SCSI_TASK_MGMT:
@@ -2337,8 +2437,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
case MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST: /* LD-IO Path */
/* Map the FW Cmd Status */
map_cmd_status(cmd_fusion, status, extStatus);
- scsi_io_req->RaidContext.status = 0;
- scsi_io_req->RaidContext.exStatus = 0;
+ scsi_io_req->RaidContext.raid_context.status = 0;
+ scsi_io_req->RaidContext.raid_context.exStatus = 0;
if (megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
atomic_dec(&instance->ldio_outstanding);
megasas_return_cmd_fusion(instance, cmd_fusion);
@@ -2905,7 +3005,7 @@ void megasas_refire_mgmt_cmd(struct megasas_instance *instance)
&& !(cmd_mfi->flags & DRV_DCMD_SKIP_REFIRE);
if (refire_cmd)
megasas_fire_cmd_fusion(instance, req_desc,
- instance->is_ventura);
+ instance->is_ventura);
else
megasas_return_cmd(instance, cmd_mfi);
}
@@ -3394,7 +3494,7 @@ int megasas_check_mpio_paths(struct megasas_instance *instance,
/* Core fusion reset function */
int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
{
- int retval = SUCCESS, i, convert = 0;
+ int retval = SUCCESS, i, j, convert = 0;
struct megasas_instance *instance;
struct megasas_cmd_fusion *cmd_fusion;
struct fusion_context *fusion;
@@ -3559,6 +3659,16 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
shost_for_each_device(sdev, shost)
megasas_update_sdev_properties(sdev);
+ /* reset stream detection array */
+ if (instance->is_ventura) {
+ for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
+ memset(fusion->stream_detect_by_ld[j],
+ 0, sizeof(struct LD_STREAM_DETECT));
+ fusion->stream_detect_by_ld[j]->mru_bit_map
+ = MR_STREAM_BITMAP;
+ }
+ }
+
clear_bit(MEGASAS_FUSION_IN_RESET,
&instance->reset_flags);
instance->instancet->enable_intr(instance);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index 9d22ade..ad90a98 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -133,12 +133,95 @@ struct RAID_CONTEXT {
u8 resvd2;
};
+/*
+* Raid Context structure which describes ventura MegaRAID specific
+* IO Paramenters ,This resides at offset 0x60 where the SGL normally
+* starts in MPT IO Frames
+*/
+struct RAID_CONTEXT_G35 {
+#if defined(__BIG_ENDIAN_BITFIELD)
+ u16 resvd0:8;
+ u16 nseg:4;
+ u16 type:4;
+#else
+ u16 type:4; /* 0x00 */
+ u16 nseg:4; /* 0x00 */
+ u16 resvd0:8;
+#endif
+ u16 timeout_value; /* 0x02 -0x03 */
+ union {
+ struct {
+#if defined(__BIG_ENDIAN_BITFIELD)
+ u16 set_divert:4;
+ u16 cpu_sel:4;
+ u16 log:1;
+ u16 rw:1;
+ u16 sbs:1;
+ u16 sqn:1;
+ u16 fwn:1;
+ u16 c2f:1;
+ u16 sld:1;
+ u16 reserved:1;
+#else
+ u16 reserved:1;
+ u16 sld:1;
+ u16 c2f:1;
+ u16 fwn:1;
+ u16 sqn:1;
+ u16 sbs:1;
+ u16 rw:1;
+ u16 log:1;
+ u16 cpu_sel:4;
+ u16 set_divert:4;
+#endif
+ } bits;
+ u16 s;
+ } routing_flags; /* 0x04 -0x05 routing flags */
+ u16 virtual_disk_tgt_id; /* 0x06 -0x07 */
+ u64 reg_lock_row_lba; /* 0x08 - 0x0F */
+ u32 reg_lock_length; /* 0x10 - 0x13 */
+ union {
+ u16 next_lmid; /* 0x14 - 0x15 */
+ u16 peer_smid; /* used for the raid 1/10 fp writes */
+ } smid;
+ u8 ex_status; /* 0x16 : OUT */
+ u8 status; /* 0x17 status */
+ u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
+ * resvd[3:1], preferredCpu[0]
+ */
+ u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
+ u16 config_seq_num; /* 0x1A -0x1B */
+#if defined(__BIG_ENDIAN_BITFIELD) /* 0x1C – 0x1D */
+ u16 stream_detected:1;
+ u16 reserved:3;
+ u16 num_sge:12;
+#else
+ u16 num_sge:12;
+ u16 reserved:3;
+ u16 stream_detected:1;
+#endif
+ u8 resvd2[2]; /* 0x1E-0x1F */
+};
+
+union RAID_CONTEXT_UNION {
+ struct RAID_CONTEXT raid_context;
+ struct RAID_CONTEXT_G35 raid_context_g35;
+};
+
#define RAID_CTX_SPANARM_ARM_SHIFT (0)
#define RAID_CTX_SPANARM_ARM_MASK (0x1f)
#define RAID_CTX_SPANARM_SPAN_SHIFT (5)
#define RAID_CTX_SPANARM_SPAN_MASK (0xE0)
+/* number of bits per index in U32 TrackStream */
+#define BITS_PER_INDEX_STREAM 4
+#define INVALID_STREAM_NUM 16
+#define MR_STREAM_BITMAP 0x76543210
+#define STREAM_MASK ((1 << BITS_PER_INDEX_STREAM) - 1)
+#define ZERO_LAST_STREAM 0x0fffffff
+#define MAX_STREAMS_TRACKED 8
+
/*
* define region lock types
*/
@@ -409,7 +492,7 @@ struct MPI2_RAID_SCSI_IO_REQUEST {
u8 LUN[8]; /* 0x34 */
__le32 Control; /* 0x3C */
union MPI2_SCSI_IO_CDB_UNION CDB; /* 0x40 */
- struct RAID_CONTEXT RaidContext; /* 0x60 */
+ union RAID_CONTEXT_UNION RaidContext; /* 0x60 */
union MPI2_SGE_IO_UNION SGL; /* 0x80 */
};
@@ -656,11 +739,13 @@ struct MR_LD_RAID {
u32 encryptionType:8;
u32 pdPiMode:4;
u32 ldPiMode:4;
- u32 reserved5:3;
+ u32 reserved5:2;
+ u32 ra_capable:1;
u32 fpCapable:1;
#else
u32 fpCapable:1;
- u32 reserved5:3;
+ u32 ra_capable:1;
+ u32 reserved5:2;
u32 ldPiMode:4;
u32 pdPiMode:4;
u32 encryptionType:8;
@@ -745,6 +830,7 @@ struct IO_REQUEST_INFO {
u64 start_row;
u8 span_arm; /* span[7:5], arm[4:0] */
u8 pd_after_lb;
+ bool ra_capable;
};
struct MR_LD_TARGET_SYNC {
@@ -930,6 +1016,30 @@ struct MR_PD_CFG_SEQ_NUM_SYNC {
struct MR_PD_CFG_SEQ seq[1];
} __packed;
+/* stream detection */
+struct STREAM_DETECT {
+ u64 next_seq_lba; /* next LBA to match sequential access */
+ struct megasas_cmd_fusion *first_cmd_fusion; /* first cmd in group */
+ struct megasas_cmd_fusion *last_cmd_fusion; /* last cmd in group */
+ u32 count_cmds_in_stream; /* count of host commands in this stream */
+ u16 num_sges_in_group; /* total number of SGEs in grouped IOs */
+ u8 is_read; /* SCSI OpCode for this stream */
+ u8 group_depth; /* total number of host commands in group */
+ /* TRUE if cannot add any more commands to this group */
+ bool group_flush;
+ u8 reserved[7]; /* pad to 64-bit alignment */
+};
+
+struct LD_STREAM_DETECT {
+ bool write_back; /* TRUE if WB, FALSE if WT */
+ bool fp_write_enabled;
+ bool members_ssds;
+ bool fp_cache_bypass_capable;
+ u32 mru_bit_map; /* bitmap used to track MRU and LRU stream indicies */
+ /* this is the array of stream detect structures (one per stream) */
+ struct STREAM_DETECT stream_track[MAX_STREAMS_TRACKED];
+};
+
struct MPI2_IOC_INIT_RDPQ_ARRAY_ENTRY {
u64 RDPQBaseAddress;
u32 Reserved1;
@@ -983,6 +1093,7 @@ struct fusion_context {
struct LD_LOAD_BALANCE_INFO load_balance_info[MAX_LOGICAL_DRIVES_EXT];
LD_SPAN_INFO log_to_span[MAX_LOGICAL_DRIVES_EXT];
u8 adapter_type;
+ struct LD_STREAM_DETECT **stream_detect_by_ld;
};
union desc_value {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing
2016-12-06 23:00 ` [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
@ 2016-12-08 16:00 ` Tomas Henzl
2016-12-12 16:38 ` Tomas Henzl
1 sibling, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-08 16:00 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> Detect sequential IO streams and pass those IOs directly to FW.
>
> This patch is depending on patch 3
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
Indentation in megasas_stream_detect is wrong on several places,
but ok for now.
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing
2016-12-06 23:00 ` [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
2016-12-08 16:00 ` Tomas Henzl
@ 2016-12-12 16:38 ` Tomas Henzl
2016-12-14 22:07 ` Sasikumar PC
1 sibling, 1 reply; 40+ messages in thread
From: Tomas Henzl @ 2016-12-12 16:38 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> Detect sequential IO streams and pass those IOs directly to FW.
>
> This patch is depending on patch 3
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 5 +-
> drivers/scsi/megaraid/megaraid_sas_base.c | 43 +++++++-
> drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 164 +++++++++++++++++++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 117 +++++++++++++++++++-
> 5 files changed, 298 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index 9d4ca8d..d07b3e1 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -105,7 +105,7 @@
> */
>
> /*
> - * MFI stands for MegaRAID SAS FW Interface. This is just a moniker for
> + * MFI stands for MegaRAID SAS FW Interface. This is just a moniker for
> * protocol between the software and firmware. Commands are issued using
> * "message frames"
> */
> @@ -1440,7 +1440,7 @@ enum FW_BOOT_CONTEXT {
> * register set for both 1068 and 1078 controllers
> * structure extended for 1078 registers
> */
> -
> +
> struct megasas_register_set {
> u32 doorbell; /*0000h*/
> u32 fusion_seq_offset; /*0004h*/
> @@ -2070,6 +2070,7 @@ struct megasas_instance {
> /* used to sync fire the cmd to fw */
> spinlock_t hba_lock;
> /* used to synch producer, consumer ptrs in dpc */
> + spinlock_t stream_lock;
> spinlock_t completion_lock;
> struct dma_pool *frame_dma_pool;
> struct dma_pool *sense_dma_pool;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index c583e0b..c52f7be 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5015,7 +5015,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
> struct megasas_register_set __iomem *reg_set;
> struct megasas_ctrl_info *ctrl_info = NULL;
> unsigned long bar_list;
> - int i, loop, fw_msix_count = 0;
> + int i, j, loop, fw_msix_count = 0;
> struct IOV_111 *iovPtr;
> struct fusion_context *fusion;
>
> @@ -5202,6 +5202,36 @@ static int megasas_init_fw(struct megasas_instance *instance)
> }
>
> memset(instance->ld_ids, 0xff, MEGASAS_MAX_LD_IDS);
> +
> + /* stream detection initialization */
> + if (instance->is_ventura) {
> + fusion->stream_detect_by_ld =
> + kzalloc(sizeof(struct LD_STREAM_DETECT *)
> + * MAX_LOGICAL_DRIVES_EXT,
> + GFP_KERNEL);
> + if (!fusion->stream_detect_by_ld) {
> + dev_err(&instance->pdev->dev,
> + "unable to allocate stream detection for pool of LDs\n");
> + goto fail_get_ld_pd_list;
> + }
> + for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i) {
> + fusion->stream_detect_by_ld[i] =
> + kmalloc(sizeof(struct LD_STREAM_DETECT),
> + GFP_KERNEL);
> + if (!fusion->stream_detect_by_ld[i]) {
> + dev_err(&instance->pdev->dev,
> + "unable to allocate stream detect by LD\n ");
> + for (j = 0; j < i; ++j)
> + kfree(fusion->stream_detect_by_ld[j]);
> + kfree(fusion->stream_detect_by_ld);
> + fusion->stream_detect_by_ld = NULL;
> + goto fail_get_ld_pd_list;
> + }
> + fusion->stream_detect_by_ld[i]->mru_bit_map
> + = MR_STREAM_BITMAP;
> + }
> + }
> +
> if (megasas_ld_list_query(instance,
> MR_LD_QUERY_TYPE_EXPOSED_TO_HOST))
> megasas_get_ld_list(instance);
> @@ -5321,6 +5351,8 @@ static int megasas_init_fw(struct megasas_instance *instance)
>
> return 0;
>
> +fail_get_ld_pd_list:
> + instance->instancet->disable_intr(instance);
> fail_get_pd_list:
> instance->instancet->disable_intr(instance);
> megasas_destroy_irqs(instance);
> @@ -5854,6 +5886,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
>
> spin_lock_init(&instance->mfi_pool_lock);
> spin_lock_init(&instance->hba_lock);
> + spin_lock_init(&instance->stream_lock);
> spin_lock_init(&instance->completion_lock);
>
> mutex_init(&instance->reset_mutex);
> @@ -6354,6 +6387,14 @@ static void megasas_detach_one(struct pci_dev *pdev)
> if (instance->msix_vectors)
> pci_disable_msix(instance->pdev);
>
> + if (instance->is_ventura) {
> + for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i)
> + kfree(fusion->stream_detect_by_ld[i]);
> + kfree(fusion->stream_detect_by_ld);
> + fusion->stream_detect_by_ld = NULL;
> + }
> +
> +
> if (instance->ctrl_context) {
> megasas_release_fusion(instance);
> pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index f237d00..a4e213b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -935,6 +935,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
>
> ld = MR_TargetIdToLdGet(ldTgtId, map);
> raid = MR_LdRaidGet(ld, map);
> + /*check read ahead bit*/
> + io_info->ra_capable = raid->capability.ra_capable;
>
> /*
> * if rowDataSize @RAID map and spanRowDataSize @SPAN INFO are zero
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index fe69c4a..39dad6d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -1704,6 +1704,89 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> }
>
> /**
> + * megasas_stream_detect - stream detection on read and and write IOs
> + * @instance: Adapter soft state
> + * @cmd: Command to be prepared
> + * @io_info: IO Request info
> + *
> + */
> +
> +/** stream detection on read and and write IOs */
> +static void megasas_stream_detect(struct megasas_instance *instance,
> + struct megasas_cmd_fusion *cmd,
> + struct IO_REQUEST_INFO *io_info)
> +{
> + struct fusion_context *fusion = instance->ctrl_context;
> + u32 device_id = io_info->ldTgtId;
> + struct LD_STREAM_DETECT *current_ld_sd
> + = fusion->stream_detect_by_ld[device_id];
> + u32 *track_stream = ¤t_ld_sd->mru_bit_map, stream_num;
> + u32 shifted_values, unshifted_values;
> + u32 index_value_mask, shifted_values_mask;
> + int i;
> + bool is_read_ahead = false;
> + struct STREAM_DETECT *current_sd;
> + /* find possible stream */
> + for (i = 0; i < MAX_STREAMS_TRACKED; ++i) {
> + stream_num =
> + (*track_stream >> (i * BITS_PER_INDEX_STREAM)) &
> + STREAM_MASK;
> + current_sd = ¤t_ld_sd->stream_track[stream_num];
> + /* if we found a stream, update the raid
> + * context and also update the mruBitMap
> + */
> + /* boundary condition */
> + if (current_sd->next_seq_lba &&
> + io_info->ldStartBlock >= current_sd->next_seq_lba &&
> + (io_info->ldStartBlock <= (current_sd->next_seq_lba+32)) &&
> + (current_sd->is_read == io_info->isRead)) {
> + if ((io_info->ldStartBlock != current_sd->next_seq_lba) &&
> + ((!io_info->isRead) || (!is_read_ahead)))
> + /*
> + * Once the API availible we need to change this.
> + * At this point we are not allowing any gap
> + */
> + continue;
> + cmd->io_request->RaidContext.raid_context_g35.stream_detected
> + = true;
> + current_sd->next_seq_lba =
> + io_info->ldStartBlock + io_info->numBlocks;
> + /*
> + * update the mruBitMap LRU
> + */
> + shifted_values_mask =
> + (1 << i * BITS_PER_INDEX_STREAM) - 1;
> + shifted_values = ((*track_stream & shifted_values_mask)
> + << BITS_PER_INDEX_STREAM);
> + index_value_mask =
> + STREAM_MASK << i * BITS_PER_INDEX_STREAM;
> + unshifted_values =
> + *track_stream & ~(shifted_values_mask |
> + index_value_mask);
> + *track_stream =
> + unshifted_values | shifted_values | stream_num;
> + return;
> +
> + }
> +
> + }
> + /*
> + * if we did not find any stream, create a new one
> + * from the least recently used
> + */
> + stream_num =
> + (*track_stream >> ((MAX_STREAMS_TRACKED - 1) * BITS_PER_INDEX_STREAM)) &
> + STREAM_MASK;
> + current_sd = ¤t_ld_sd->stream_track[stream_num];
> + current_sd->is_read = io_info->isRead;
> + current_sd->next_seq_lba = io_info->ldStartBlock + io_info->numBlocks;
> + *track_stream =
> + (((*track_stream & ZERO_LAST_STREAM) << 4) | stream_num);
> + return;
> +
> +}
> +
> +/**
> * megasas_build_ldio_fusion - Prepares IOs to devices
> * @instance: Adapter soft state
> * @scp: SCSI command
> @@ -1725,15 +1808,17 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> struct fusion_context *fusion;
> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> u8 *raidLUN;
> + unsigned long spinlock_flags;
>
> device_id = MEGASAS_DEV_INDEX(scp);
>
> fusion = instance->ctrl_context;
>
> io_request = cmd->io_request;
> - io_request->RaidContext.VirtualDiskTgtId = cpu_to_le16(device_id);
> - io_request->RaidContext.status = 0;
> - io_request->RaidContext.exStatus = 0;
> + io_request->RaidContext.raid_context.VirtualDiskTgtId =
> + cpu_to_le16(device_id);
> + io_request->RaidContext.raid_context.status = 0;
> + io_request->RaidContext.raid_context.exStatus = 0;
>
> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION *)cmd->request_desc;
>
> @@ -1804,11 +1889,11 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
>
> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
> instance->fw_supported_vd_count) || (!fusion->fast_path_io)) {
> - io_request->RaidContext.regLockFlags = 0;
> + io_request->RaidContext.raid_context.regLockFlags = 0;
> fp_possible = 0;
> } else {
> if (MR_BuildRaidContext(instance, &io_info,
> - &io_request->RaidContext,
> + &io_request->RaidContext.raid_context,
> local_map_ptr, &raidLUN))
> fp_possible = io_info.fpOkForIo;
> }
> @@ -1819,6 +1904,18 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> cmd->request_desc->SCSIIO.MSIxIndex = instance->msix_vectors ?
> raw_smp_processor_id() % instance->msix_vectors : 0;
>
> + if (instance->is_ventura) {
> + spin_lock_irqsave(&instance->stream_lock, spinlock_flags);
> + megasas_stream_detect(instance, cmd, &io_info);
> + spin_unlock_irqrestore(&instance->stream_lock, spinlock_flags);
> + /* In ventura if stream detected for a read and it is read ahead
> + * capable make this IO as LDIO
> + */
> + if (io_request->RaidContext.raid_context_g35.stream_detected &&
> + io_info.isRead && io_info.ra_capable)
> + fp_possible = false;
> + }
> +
> if (fp_possible) {
> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info, scp,
> local_map_ptr, start_lba_lo);
> @@ -1827,15 +1924,16 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> - if (io_request->RaidContext.regLockFlags ==
> + if (io_request->RaidContext.raid_context.regLockFlags ==
> REGION_TYPE_UNUSED)
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.Type = MPI2_TYPE_CUDA;
> - io_request->RaidContext.nseg = 0x1;
> + io_request->RaidContext.raid_context.Type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context.nseg = 0x1;
> io_request->IoFlags |= cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> - io_request->RaidContext.regLockFlags |=
> + io_request->RaidContext.raid_context.regLockFlags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> }
> @@ -1862,22 +1960,24 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> /* populate the LUN field */
> memcpy(io_request->LUN, raidLUN, 8);
> } else {
> - io_request->RaidContext.timeoutValue =
> + io_request->RaidContext.raid_context.timeoutValue =
> cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> if (io_info.do_fp_rlbypass ||
> - (io_request->RaidContext.regLockFlags == REGION_TYPE_UNUSED))
> + (io_request->RaidContext.raid_context.regLockFlags
> + == REGION_TYPE_UNUSED))
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.Type = MPI2_TYPE_CUDA;
> - io_request->RaidContext.regLockFlags |=
> + io_request->RaidContext.raid_context.Type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context.regLockFlags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> - io_request->RaidContext.nseg = 0x1;
> + io_request->RaidContext.raid_context.nseg = 0x1;
> }
> io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> @@ -1913,7 +2013,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
> /* get RAID_Context pointer */
> - pRAID_Context = &io_request->RaidContext;
> + pRAID_Context = &io_request->RaidContext.raid_context;
> /* Check with FW team */
> pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> pRAID_Context->regLockRowLBA = 0;
> @@ -2000,7 +2100,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
>
> io_request = cmd->io_request;
> /* get RAID_Context pointer */
> - pRAID_Context = &io_request->RaidContext;
> + pRAID_Context = &io_request->RaidContext.raid_context;
> pRAID_Context->regLockFlags = 0;
> pRAID_Context->regLockRowLBA = 0;
> pRAID_Context->regLockLength = 0;
> @@ -2094,9 +2194,9 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> io_request->Control = 0;
> io_request->EEDPBlockSize = 0;
> io_request->ChainOffset = 0;
> - io_request->RaidContext.RAIDFlags = 0;
> - io_request->RaidContext.Type = 0;
> - io_request->RaidContext.nseg = 0;
> + io_request->RaidContext.raid_context.RAIDFlags = 0;
> + io_request->RaidContext.raid_context.Type = 0;
> + io_request->RaidContext.raid_context.nseg = 0;
>
> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
> /*
> @@ -2143,8 +2243,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> /* numSGE store lower 8 bit of sge_count.
> * numSGEExt store higher 8 bit of sge_count
> */
> - io_request->RaidContext.numSGE = sge_count;
> - io_request->RaidContext.numSGEExt = (u8)(sge_count >> 8);
> + io_request->RaidContext.raid_context.numSGE = sge_count;
> + io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >> 8);
>
> io_request->SGLFlags = cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>
> @@ -2303,8 +2403,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> cmd_fusion->scmd->SCp.ptr = NULL;
>
> scmd_local = cmd_fusion->scmd;
> - status = scsi_io_req->RaidContext.status;
> - extStatus = scsi_io_req->RaidContext.exStatus;
> + status = scsi_io_req->RaidContext.raid_context.status;
> + extStatus = scsi_io_req->RaidContext.raid_context.exStatus;
>
> switch (scsi_io_req->Function) {
> case MPI2_FUNCTION_SCSI_TASK_MGMT:
> @@ -2337,8 +2437,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> case MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST: /* LD-IO Path */
> /* Map the FW Cmd Status */
> map_cmd_status(cmd_fusion, status, extStatus);
> - scsi_io_req->RaidContext.status = 0;
> - scsi_io_req->RaidContext.exStatus = 0;
> + scsi_io_req->RaidContext.raid_context.status = 0;
> + scsi_io_req->RaidContext.raid_context.exStatus = 0;
> if (megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
> atomic_dec(&instance->ldio_outstanding);
> megasas_return_cmd_fusion(instance, cmd_fusion);
> @@ -2905,7 +3005,7 @@ void megasas_refire_mgmt_cmd(struct megasas_instance *instance)
> && !(cmd_mfi->flags & DRV_DCMD_SKIP_REFIRE);
> if (refire_cmd)
> megasas_fire_cmd_fusion(instance, req_desc,
> - instance->is_ventura);
> + instance->is_ventura);
> else
> megasas_return_cmd(instance, cmd_mfi);
> }
> @@ -3394,7 +3494,7 @@ int megasas_check_mpio_paths(struct megasas_instance *instance,
> /* Core fusion reset function */
> int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
> {
> - int retval = SUCCESS, i, convert = 0;
> + int retval = SUCCESS, i, j, convert = 0;
> struct megasas_instance *instance;
> struct megasas_cmd_fusion *cmd_fusion;
> struct fusion_context *fusion;
> @@ -3559,6 +3659,16 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
> shost_for_each_device(sdev, shost)
> megasas_update_sdev_properties(sdev);
>
> + /* reset stream detection array */
> + if (instance->is_ventura) {
> + for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
> + memset(fusion->stream_detect_by_ld[j],
> + 0, sizeof(struct LD_STREAM_DETECT));
> + fusion->stream_detect_by_ld[j]->mru_bit_map
> + = MR_STREAM_BITMAP;
> + }
> + }
> +
> clear_bit(MEGASAS_FUSION_IN_RESET,
> &instance->reset_flags);
> instance->instancet->enable_intr(instance);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index 9d22ade..ad90a98 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -133,12 +133,95 @@ struct RAID_CONTEXT {
> u8 resvd2;
> };
>
> +/*
> +* Raid Context structure which describes ventura MegaRAID specific
> +* IO Paramenters ,This resides at offset 0x60 where the SGL normally
> +* starts in MPT IO Frames
> +*/
> +struct RAID_CONTEXT_G35 {
> +#if defined(__BIG_ENDIAN_BITFIELD)
> + u16 resvd0:8;
> + u16 nseg:4;
> + u16 type:4;
> +#else
> + u16 type:4; /* 0x00 */
> + u16 nseg:4; /* 0x00 */
> + u16 resvd0:8;
> +#endif
> + u16 timeout_value; /* 0x02 -0x03 */
> + union {
> + struct {
> +#if defined(__BIG_ENDIAN_BITFIELD)
> + u16 set_divert:4;
> + u16 cpu_sel:4;
> + u16 log:1;
> + u16 rw:1;
> + u16 sbs:1;
> + u16 sqn:1;
> + u16 fwn:1;
> + u16 c2f:1;
> + u16 sld:1;
> + u16 reserved:1;
> +#else
> + u16 reserved:1;
> + u16 sld:1;
> + u16 c2f:1;
> + u16 fwn:1;
> + u16 sqn:1;
> + u16 sbs:1;
> + u16 rw:1;
> + u16 log:1;
> + u16 cpu_sel:4;
> + u16 set_divert:4;
> +#endif
> + } bits;
> + u16 s;
> + } routing_flags; /* 0x04 -0x05 routing flags */
> + u16 virtual_disk_tgt_id; /* 0x06 -0x07 */
> + u64 reg_lock_row_lba; /* 0x08 - 0x0F */
> + u32 reg_lock_length; /* 0x10 - 0x13 */
> + union {
> + u16 next_lmid; /* 0x14 - 0x15 */
> + u16 peer_smid; /* used for the raid 1/10 fp writes */
> + } smid;
> + u8 ex_status; /* 0x16 : OUT */
> + u8 status; /* 0x17 status */
> + u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
> + * resvd[3:1], preferredCpu[0]
> + */
> + u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
> + u16 config_seq_num; /* 0x1A -0x1B */
> +#if defined(__BIG_ENDIAN_BITFIELD) /* 0x1C – 0x1D */
Please remove that non-ascii char on the previous line.
Also there is still plenty of warnings from checkpatch, fix it please
when you rebase the series. The warnings about more than 80 chars on
a line may be ignored in certain cases when it makes the code more readable.
tomash
+ u16 stream_detected:1;
+ u16 reserved:3;
+ u16 num_sge:12;
+#else
+ u16 num_sge:12;
+ u16 reserved:3;
+ u16 stream_detected:1;
+#endif
+ u8 resvd2[2]; /* 0x1E-0x1F */
+};
+
+union RAID_CONTEXT_UNION {
+ struct RAID_CONTEXT raid_context;
+ struct RAID_CONTEXT_G35 raid_context_g35;
+};
+
#define RAID_CTX_SPANARM_ARM_SHIFT (0)
#define RAID_CTX_SPANARM_ARM_MASK (0x1f)
#define RAID_CTX_SPANARM_SPAN_SHIFT (5)
#define RAID_CTX_SPANARM_SPAN_MASK (0xE0)
+/* number of bits per index in U32 TrackStream */
+#define BITS_PER_INDEX_STREAM 4
+#define INVALID_STREAM_NUM 16
+#define MR_STREAM_BITMAP 0x76543210
+#define STREAM_MASK ((1 << BITS_PER_INDEX_STREAM) - 1)
+#define ZERO_LAST_STREAM 0x0fffffff
+#define MAX_STREAMS_TRACKED 8
+
/*
* define region lock types
*/
@@ -409,7 +492,7 @@ struct MPI2_RAID_SCSI_IO_REQUEST {
u8 LUN[8]; /* 0x34 */
__le32 Control; /* 0x3C */
union MPI2_SCSI_IO_CDB_UNION CDB; /* 0x40 */
- struct RAID_CONTEXT RaidContext; /* 0x60 */
+ union RAID_CONTEXT_UNION RaidContext; /* 0x60 */
union MPI2_SGE_IO_UNION SGL; /* 0x80 */
};
@@ -656,11 +739,13 @@ struct MR_LD_RAID {
u32 encryptionType:8;
u32 pdPiMode:4;
u32 ldPiMode:4;
- u32 reserved5:3;
+ u32 reserved5:2;
+ u32 ra_capable:1;
u32 fpCapable:1;
#else
u32 fpCapable:1;
- u32 reserved5:3;
+ u32 ra_capable:1;
+ u32 reserved5:2;
u32 ldPiMode:4;
u32 pdPiMode:4;
u32 encryptionType:8;
@@ -745,6 +830,7 @@ struct IO_REQUEST_INFO {
u64 start_row;
u8 span_arm; /* span[7:5], arm[4:0] */
u8 pd_after_lb;
+ bool ra_capable;
};
struct MR_LD_TARGET_SYNC {
@@ -930,6 +1016,30 @@ struct MR_PD_CFG_SEQ_NUM_SYNC {
struct MR_PD_CFG_SEQ seq[1];
} __packed;
+/* stream detection */
+struct STREAM_DETECT {
+ u64 next_seq_lba; /* next LBA to match sequential access */
+ struct megasas_cmd_fusion *first_cmd_fusion; /* first cmd in group */
+ struct megasas_cmd_fusion *last_cmd_fusion; /* last cmd in group */
+ u32 count_cmds_in_stream; /* count of host commands in this stream */
+ u16 num_sges_in_group; /* total number of SGEs in grouped IOs */
+ u8 is_read; /* SCSI OpCode for this stream */
+ u8 group_depth; /* total number of host commands in group */
+ /* TRUE if cannot add any more commands to this group */
+ bool group_flush;
+ u8 reserved[7]; /* pad to 64-bit alignment */
+};
+
+struct LD_STREAM_DETECT {
+ bool write_back; /* TRUE if WB, FALSE if WT */
+ bool fp_write_enabled;
+ bool members_ssds;
+ bool fp_cache_bypass_capable;
+ u32 mru_bit_map; /* bitmap used to track MRU and LRU stream indicies */
+ /* this is the array of stream detect structures (one per stream) */
+ struct STREAM_DETECT stream_track[MAX_STREAMS_TRACKED];
+};
+
struct MPI2_IOC_INIT_RDPQ_ARRAY_ENTRY {
u64 RDPQBaseAddress;
u32 Reserved1;
@@ -983,6 +1093,7 @@ struct fusion_context {
struct LD_LOAD_BALANCE_INFO load_balance_info[MAX_LOGICAL_DRIVES_EXT];
LD_SPAN_INFO log_to_span[MAX_LOGICAL_DRIVES_EXT];
u8 adapter_type;
+ struct LD_STREAM_DETECT **stream_detect_by_ld;
};
union desc_value {
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing
2016-12-12 16:38 ` Tomas Henzl
@ 2016-12-14 22:07 ` Sasikumar PC
0 siblings, 0 replies; 40+ messages in thread
From: Sasikumar PC @ 2016-12-14 22:07 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Monday, December 12, 2016 11:39 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid
Controllers Stream Detection and IO Coalescing
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> Detect sequential IO streams and pass those IOs directly to FW.
>
> This patch is depending on patch 3
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 5 +-
> drivers/scsi/megaraid/megaraid_sas_base.c | 43 +++++++-
> drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 164
> +++++++++++++++++++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 117 +++++++++++++++++++-
> 5 files changed, 298 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
> index 9d4ca8d..d07b3e1 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -105,7 +105,7 @@
> */
>
> /*
> - * MFI stands for MegaRAID SAS FW Interface. This is just a moniker
> for
> + * MFI stands for MegaRAID SAS FW Interface. This is just a moniker
> + for
> * protocol between the software and firmware. Commands are issued using
> * "message frames"
> */
> @@ -1440,7 +1440,7 @@ enum FW_BOOT_CONTEXT {
> * register set for both 1068 and 1078 controllers
> * structure extended for 1078 registers */
> -
> +
> struct megasas_register_set {
> u32 doorbell; /*0000h*/
> u32 fusion_seq_offset; /*0004h*/
> @@ -2070,6 +2070,7 @@ struct megasas_instance {
> /* used to sync fire the cmd to fw */
> spinlock_t hba_lock;
> /* used to synch producer, consumer ptrs in dpc */
> + spinlock_t stream_lock;
> spinlock_t completion_lock;
> struct dma_pool *frame_dma_pool;
> struct dma_pool *sense_dma_pool;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index c583e0b..c52f7be 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5015,7 +5015,7 @@ static int megasas_init_fw(struct megasas_instance
> *instance)
> struct megasas_register_set __iomem *reg_set;
> struct megasas_ctrl_info *ctrl_info = NULL;
> unsigned long bar_list;
> - int i, loop, fw_msix_count = 0;
> + int i, j, loop, fw_msix_count = 0;
> struct IOV_111 *iovPtr;
> struct fusion_context *fusion;
>
> @@ -5202,6 +5202,36 @@ static int megasas_init_fw(struct megasas_instance
> *instance)
> }
>
> memset(instance->ld_ids, 0xff, MEGASAS_MAX_LD_IDS);
> +
> + /* stream detection initialization */
> + if (instance->is_ventura) {
> + fusion->stream_detect_by_ld =
> + kzalloc(sizeof(struct LD_STREAM_DETECT *)
> + * MAX_LOGICAL_DRIVES_EXT,
> + GFP_KERNEL);
> + if (!fusion->stream_detect_by_ld) {
> + dev_err(&instance->pdev->dev,
> + "unable to allocate stream detection for pool of LDs\n");
> + goto fail_get_ld_pd_list;
> + }
> + for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i) {
> + fusion->stream_detect_by_ld[i] =
> + kmalloc(sizeof(struct LD_STREAM_DETECT),
> + GFP_KERNEL);
> + if (!fusion->stream_detect_by_ld[i]) {
> + dev_err(&instance->pdev->dev,
> + "unable to allocate stream detect by LD\n ");
> + for (j = 0; j < i; ++j)
> + kfree(fusion->stream_detect_by_ld[j]);
> + kfree(fusion->stream_detect_by_ld);
> + fusion->stream_detect_by_ld = NULL;
> + goto fail_get_ld_pd_list;
> + }
> + fusion->stream_detect_by_ld[i]->mru_bit_map
> + = MR_STREAM_BITMAP;
> + }
> + }
> +
> if (megasas_ld_list_query(instance,
> MR_LD_QUERY_TYPE_EXPOSED_TO_HOST))
> megasas_get_ld_list(instance);
> @@ -5321,6 +5351,8 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>
> return 0;
>
> +fail_get_ld_pd_list:
> + instance->instancet->disable_intr(instance);
> fail_get_pd_list:
> instance->instancet->disable_intr(instance);
> megasas_destroy_irqs(instance);
> @@ -5854,6 +5886,7 @@ static int megasas_probe_one(struct pci_dev
> *pdev,
>
> spin_lock_init(&instance->mfi_pool_lock);
> spin_lock_init(&instance->hba_lock);
> + spin_lock_init(&instance->stream_lock);
> spin_lock_init(&instance->completion_lock);
>
> mutex_init(&instance->reset_mutex);
> @@ -6354,6 +6387,14 @@ static void megasas_detach_one(struct pci_dev
> *pdev)
> if (instance->msix_vectors)
> pci_disable_msix(instance->pdev);
>
> + if (instance->is_ventura) {
> + for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i)
> + kfree(fusion->stream_detect_by_ld[i]);
> + kfree(fusion->stream_detect_by_ld);
> + fusion->stream_detect_by_ld = NULL;
> + }
> +
> +
> if (instance->ctrl_context) {
> megasas_release_fusion(instance);
> pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) + diff --git
> a/drivers/scsi/megaraid/megaraid_sas_fp.c
> b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index f237d00..a4e213b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -935,6 +935,8 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>
> ld = MR_TargetIdToLdGet(ldTgtId, map);
> raid = MR_LdRaidGet(ld, map);
> + /*check read ahead bit*/
> + io_info->ra_capable = raid->capability.ra_capable;
>
> /*
> * if rowDataSize @RAID map and spanRowDataSize @SPAN INFO are zero
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index fe69c4a..39dad6d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -1704,6 +1704,89 @@ static int
> megasas_create_sg_sense_fusion(struct megasas_instance *instance) }
>
> /**
> + * megasas_stream_detect - stream detection on read and and write IOs
> + * @instance: Adapter soft state
> + * @cmd: Command to be prepared
> + * @io_info: IO Request info
> + *
> + */
> +
> +/** stream detection on read and and write IOs */ static void
> +megasas_stream_detect(struct megasas_instance *instance,
> + struct megasas_cmd_fusion *cmd,
> + struct IO_REQUEST_INFO *io_info)
> +{
> + struct fusion_context *fusion = instance->ctrl_context;
> + u32 device_id = io_info->ldTgtId;
> + struct LD_STREAM_DETECT *current_ld_sd
> + = fusion->stream_detect_by_ld[device_id];
> + u32 *track_stream = ¤t_ld_sd->mru_bit_map, stream_num;
> + u32 shifted_values, unshifted_values;
> + u32 index_value_mask, shifted_values_mask;
> + int i;
> + bool is_read_ahead = false;
> + struct STREAM_DETECT *current_sd;
> + /* find possible stream */
> + for (i = 0; i < MAX_STREAMS_TRACKED; ++i) {
> + stream_num =
> + (*track_stream >> (i * BITS_PER_INDEX_STREAM)) &
> + STREAM_MASK;
> + current_sd = ¤t_ld_sd->stream_track[stream_num];
> + /* if we found a stream, update the raid
> + * context and also update the mruBitMap
> + */
> + /* boundary condition */
> + if (current_sd->next_seq_lba &&
> + io_info->ldStartBlock >= current_sd->next_seq_lba &&
> + (io_info->ldStartBlock <= (current_sd->next_seq_lba+32)) &&
> + (current_sd->is_read == io_info->isRead)) {
> + if ((io_info->ldStartBlock != current_sd->next_seq_lba) &&
> + ((!io_info->isRead) || (!is_read_ahead)))
> + /*
> + * Once the API availible we need to change this.
> + * At this point we are not allowing any gap
> + */
> + continue;
> + cmd->io_request->RaidContext.raid_context_g35.stream_detected
> + = true;
> + current_sd->next_seq_lba =
> + io_info->ldStartBlock + io_info->numBlocks;
> + /*
> + * update the mruBitMap LRU
> + */
> + shifted_values_mask =
> + (1 << i * BITS_PER_INDEX_STREAM) - 1;
> + shifted_values = ((*track_stream & shifted_values_mask)
> + << BITS_PER_INDEX_STREAM);
> + index_value_mask =
> + STREAM_MASK << i * BITS_PER_INDEX_STREAM;
> + unshifted_values =
> + *track_stream & ~(shifted_values_mask |
> + index_value_mask);
> + *track_stream =
> + unshifted_values | shifted_values | stream_num;
> + return;
> +
> + }
> +
> + }
> + /*
> + * if we did not find any stream, create a new one
> + * from the least recently used
> + */
> + stream_num =
> + (*track_stream >> ((MAX_STREAMS_TRACKED - 1) * BITS_PER_INDEX_STREAM)) &
> + STREAM_MASK;
> + current_sd = ¤t_ld_sd->stream_track[stream_num];
> + current_sd->is_read = io_info->isRead;
> + current_sd->next_seq_lba = io_info->ldStartBlock + io_info->numBlocks;
> + *track_stream =
> + (((*track_stream & ZERO_LAST_STREAM) << 4) | stream_num);
> + return;
> +
> +}
> +
> +/**
> * megasas_build_ldio_fusion - Prepares IOs to devices
> * @instance: Adapter soft state
> * @scp: SCSI command
> @@ -1725,15 +1808,17 @@ static int megasas_create_sg_sense_fusion(struct
> megasas_instance *instance)
> struct fusion_context *fusion;
> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> u8 *raidLUN;
> + unsigned long spinlock_flags;
>
> device_id = MEGASAS_DEV_INDEX(scp);
>
> fusion = instance->ctrl_context;
>
> io_request = cmd->io_request;
> - io_request->RaidContext.VirtualDiskTgtId = cpu_to_le16(device_id);
> - io_request->RaidContext.status = 0;
> - io_request->RaidContext.exStatus = 0;
> + io_request->RaidContext.raid_context.VirtualDiskTgtId =
> + cpu_to_le16(device_id);
> + io_request->RaidContext.raid_context.status = 0;
> + io_request->RaidContext.raid_context.exStatus = 0;
>
> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION
> *)cmd->request_desc;
>
> @@ -1804,11 +1889,11 @@ static int
> megasas_create_sg_sense_fusion(struct megasas_instance *instance)
>
> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
> instance->fw_supported_vd_count) || (!fusion->fast_path_io)) {
> - io_request->RaidContext.regLockFlags = 0;
> + io_request->RaidContext.raid_context.regLockFlags = 0;
> fp_possible = 0;
> } else {
> if (MR_BuildRaidContext(instance, &io_info,
> - &io_request->RaidContext,
> + &io_request->RaidContext.raid_context,
> local_map_ptr, &raidLUN))
> fp_possible = io_info.fpOkForIo;
> }
> @@ -1819,6 +1904,18 @@ static int megasas_create_sg_sense_fusion(struct
> megasas_instance *instance)
> cmd->request_desc->SCSIIO.MSIxIndex = instance->msix_vectors ?
> raw_smp_processor_id() % instance->msix_vectors : 0;
>
> + if (instance->is_ventura) {
> + spin_lock_irqsave(&instance->stream_lock, spinlock_flags);
> + megasas_stream_detect(instance, cmd, &io_info);
> + spin_unlock_irqrestore(&instance->stream_lock, spinlock_flags);
> + /* In ventura if stream detected for a read and it is read ahead
> + * capable make this IO as LDIO
> + */
> + if (io_request->RaidContext.raid_context_g35.stream_detected &&
> + io_info.isRead && io_info.ra_capable)
> + fp_possible = false;
> + }
> +
> if (fp_possible) {
> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info, scp,
> local_map_ptr, start_lba_lo);
> @@ -1827,15 +1924,16 @@ static int megasas_create_sg_sense_fusion(struct
> megasas_instance *instance)
> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> - if (io_request->RaidContext.regLockFlags ==
> + if (io_request->RaidContext.raid_context.regLockFlags ==
> REGION_TYPE_UNUSED)
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.Type = MPI2_TYPE_CUDA;
> - io_request->RaidContext.nseg = 0x1;
> + io_request->RaidContext.raid_context.Type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context.nseg = 0x1;
> io_request->IoFlags |=
> cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> - io_request->RaidContext.regLockFlags |=
> + io_request->RaidContext.raid_context.regLockFlags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> }
> @@ -1862,22 +1960,24 @@ static int megasas_create_sg_sense_fusion(struct
> megasas_instance *instance)
> /* populate the LUN field */
> memcpy(io_request->LUN, raidLUN, 8);
> } else {
> - io_request->RaidContext.timeoutValue =
> + io_request->RaidContext.raid_context.timeoutValue =
> cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> if (io_info.do_fp_rlbypass ||
> - (io_request->RaidContext.regLockFlags == REGION_TYPE_UNUSED))
> + (io_request->RaidContext.raid_context.regLockFlags
> + == REGION_TYPE_UNUSED))
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.Type = MPI2_TYPE_CUDA;
> - io_request->RaidContext.regLockFlags |=
> + io_request->RaidContext.raid_context.Type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context.regLockFlags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> - io_request->RaidContext.nseg = 0x1;
> + io_request->RaidContext.raid_context.nseg = 0x1;
> }
> io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id); @@ -1913,7 +2013,7
> @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance
> *instance,
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
> /* get RAID_Context pointer */
> - pRAID_Context = &io_request->RaidContext;
> + pRAID_Context = &io_request->RaidContext.raid_context;
> /* Check with FW team */
> pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> pRAID_Context->regLockRowLBA = 0;
> @@ -2000,7 +2100,7 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>
> io_request = cmd->io_request;
> /* get RAID_Context pointer */
> - pRAID_Context = &io_request->RaidContext;
> + pRAID_Context = &io_request->RaidContext.raid_context;
> pRAID_Context->regLockFlags = 0;
> pRAID_Context->regLockRowLBA = 0;
> pRAID_Context->regLockLength = 0;
> @@ -2094,9 +2194,9 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
> io_request->Control = 0;
> io_request->EEDPBlockSize = 0;
> io_request->ChainOffset = 0;
> - io_request->RaidContext.RAIDFlags = 0;
> - io_request->RaidContext.Type = 0;
> - io_request->RaidContext.nseg = 0;
> + io_request->RaidContext.raid_context.RAIDFlags = 0;
> + io_request->RaidContext.raid_context.Type = 0;
> + io_request->RaidContext.raid_context.nseg = 0;
>
> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
> /*
> @@ -2143,8 +2243,8 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
> /* numSGE store lower 8 bit of sge_count.
> * numSGEExt store higher 8 bit of sge_count
> */
> - io_request->RaidContext.numSGE = sge_count;
> - io_request->RaidContext.numSGEExt = (u8)(sge_count >> 8);
> + io_request->RaidContext.raid_context.numSGE = sge_count;
> + io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >>
> +8);
>
> io_request->SGLFlags =
> cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>
> @@ -2303,8 +2403,8 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
> cmd_fusion->scmd->SCp.ptr = NULL;
>
> scmd_local = cmd_fusion->scmd;
> - status = scsi_io_req->RaidContext.status;
> - extStatus = scsi_io_req->RaidContext.exStatus;
> + status = scsi_io_req->RaidContext.raid_context.status;
> + extStatus = scsi_io_req->RaidContext.raid_context.exStatus;
>
> switch (scsi_io_req->Function) {
> case MPI2_FUNCTION_SCSI_TASK_MGMT:
> @@ -2337,8 +2437,8 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
> case MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST: /* LD-IO Path */
> /* Map the FW Cmd Status */
> map_cmd_status(cmd_fusion, status, extStatus);
> - scsi_io_req->RaidContext.status = 0;
> - scsi_io_req->RaidContext.exStatus = 0;
> + scsi_io_req->RaidContext.raid_context.status = 0;
> + scsi_io_req->RaidContext.raid_context.exStatus = 0;
> if (megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
> atomic_dec(&instance->ldio_outstanding);
> megasas_return_cmd_fusion(instance, cmd_fusion); @@ -2905,7
> +3005,7 @@ void megasas_refire_mgmt_cmd(struct megasas_instance *instance)
> && !(cmd_mfi->flags & DRV_DCMD_SKIP_REFIRE);
> if (refire_cmd)
> megasas_fire_cmd_fusion(instance, req_desc,
> - instance->is_ventura);
> + instance->is_ventura);
> else
> megasas_return_cmd(instance, cmd_mfi);
> }
> @@ -3394,7 +3494,7 @@ int megasas_check_mpio_paths(struct
> megasas_instance *instance,
> /* Core fusion reset function */
> int megasas_reset_fusion(struct Scsi_Host *shost, int reason) {
> - int retval = SUCCESS, i, convert = 0;
> + int retval = SUCCESS, i, j, convert = 0;
> struct megasas_instance *instance;
> struct megasas_cmd_fusion *cmd_fusion;
> struct fusion_context *fusion;
> @@ -3559,6 +3659,16 @@ int megasas_reset_fusion(struct Scsi_Host *shost,
> int reason)
> shost_for_each_device(sdev, shost)
> megasas_update_sdev_properties(sdev);
>
> + /* reset stream detection array */
> + if (instance->is_ventura) {
> + for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
> + memset(fusion->stream_detect_by_ld[j],
> + 0, sizeof(struct LD_STREAM_DETECT));
> + fusion->stream_detect_by_ld[j]->mru_bit_map
> + = MR_STREAM_BITMAP;
> + }
> + }
> +
> clear_bit(MEGASAS_FUSION_IN_RESET,
> &instance->reset_flags);
> instance->instancet->enable_intr(instance);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index 9d22ade..ad90a98 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -133,12 +133,95 @@ struct RAID_CONTEXT {
> u8 resvd2;
> };
>
> +/*
> +* Raid Context structure which describes ventura MegaRAID specific
> +* IO Paramenters ,This resides at offset 0x60 where the SGL normally
> +* starts in MPT IO Frames
> +*/
> +struct RAID_CONTEXT_G35 {
> +#if defined(__BIG_ENDIAN_BITFIELD)
> + u16 resvd0:8;
> + u16 nseg:4;
> + u16 type:4;
> +#else
> + u16 type:4; /* 0x00 */
> + u16 nseg:4; /* 0x00 */
> + u16 resvd0:8;
> +#endif
> + u16 timeout_value; /* 0x02 -0x03 */
> + union {
> + struct {
> +#if defined(__BIG_ENDIAN_BITFIELD)
> + u16 set_divert:4;
> + u16 cpu_sel:4;
> + u16 log:1;
> + u16 rw:1;
> + u16 sbs:1;
> + u16 sqn:1;
> + u16 fwn:1;
> + u16 c2f:1;
> + u16 sld:1;
> + u16 reserved:1;
> +#else
> + u16 reserved:1;
> + u16 sld:1;
> + u16 c2f:1;
> + u16 fwn:1;
> + u16 sqn:1;
> + u16 sbs:1;
> + u16 rw:1;
> + u16 log:1;
> + u16 cpu_sel:4;
> + u16 set_divert:4;
> +#endif
> + } bits;
> + u16 s;
> + } routing_flags; /* 0x04 -0x05 routing flags */
> + u16 virtual_disk_tgt_id; /* 0x06 -0x07 */
> + u64 reg_lock_row_lba; /* 0x08 - 0x0F */
> + u32 reg_lock_length; /* 0x10 - 0x13 */
> + union {
> + u16 next_lmid; /* 0x14 - 0x15 */
> + u16 peer_smid; /* used for the raid 1/10 fp writes */
> + } smid;
> + u8 ex_status; /* 0x16 : OUT */
> + u8 status; /* 0x17 status */
> + u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
> + * resvd[3:1], preferredCpu[0]
> + */
> + u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
> + u16 config_seq_num; /* 0x1A -0x1B */
> +#if defined(__BIG_ENDIAN_BITFIELD) /* 0x1C – 0x1D */
Please remove that non-ascii char on the previous line.
Also there is still plenty of warnings from checkpatch, fix it please when
you rebase the series. The warnings about more than 80 chars on a line may
be ignored in certain cases when it makes the code more readable.
Sasi - This shall be fixed in V5 patch
tomash
+ u16 stream_detected:1;
+ u16 reserved:3;
+ u16 num_sge:12;
+#else
+ u16 num_sge:12;
+ u16 reserved:3;
+ u16 stream_detected:1;
+#endif
+ u8 resvd2[2]; /* 0x1E-0x1F */
+};
+
+union RAID_CONTEXT_UNION {
+ struct RAID_CONTEXT raid_context;
+ struct RAID_CONTEXT_G35 raid_context_g35; };
+
#define RAID_CTX_SPANARM_ARM_SHIFT (0)
#define RAID_CTX_SPANARM_ARM_MASK (0x1f)
#define RAID_CTX_SPANARM_SPAN_SHIFT (5)
#define RAID_CTX_SPANARM_SPAN_MASK (0xE0)
+/* number of bits per index in U32 TrackStream */
+#define BITS_PER_INDEX_STREAM 4
+#define INVALID_STREAM_NUM 16
+#define MR_STREAM_BITMAP 0x76543210
+#define STREAM_MASK ((1 << BITS_PER_INDEX_STREAM) - 1)
+#define ZERO_LAST_STREAM 0x0fffffff
+#define MAX_STREAMS_TRACKED 8
+
/*
* define region lock types
*/
@@ -409,7 +492,7 @@ struct MPI2_RAID_SCSI_IO_REQUEST {
u8 LUN[8]; /* 0x34 */
__le32 Control; /* 0x3C */
union MPI2_SCSI_IO_CDB_UNION CDB; /* 0x40 */
- struct RAID_CONTEXT RaidContext; /* 0x60 */
+ union RAID_CONTEXT_UNION RaidContext; /* 0x60 */
union MPI2_SGE_IO_UNION SGL; /* 0x80 */
};
@@ -656,11 +739,13 @@ struct MR_LD_RAID {
u32 encryptionType:8;
u32 pdPiMode:4;
u32 ldPiMode:4;
- u32 reserved5:3;
+ u32 reserved5:2;
+ u32 ra_capable:1;
u32 fpCapable:1;
#else
u32 fpCapable:1;
- u32 reserved5:3;
+ u32 ra_capable:1;
+ u32 reserved5:2;
u32 ldPiMode:4;
u32 pdPiMode:4;
u32 encryptionType:8;
@@ -745,6 +830,7 @@ struct IO_REQUEST_INFO {
u64 start_row;
u8 span_arm; /* span[7:5], arm[4:0] */
u8 pd_after_lb;
+ bool ra_capable;
};
struct MR_LD_TARGET_SYNC {
@@ -930,6 +1016,30 @@ struct MR_PD_CFG_SEQ_NUM_SYNC {
struct MR_PD_CFG_SEQ seq[1];
} __packed;
+/* stream detection */
+struct STREAM_DETECT {
+ u64 next_seq_lba; /* next LBA to match sequential access */
+ struct megasas_cmd_fusion *first_cmd_fusion; /* first cmd in group */
+ struct megasas_cmd_fusion *last_cmd_fusion; /* last cmd in group */
+ u32 count_cmds_in_stream; /* count of host commands in this stream */
+ u16 num_sges_in_group; /* total number of SGEs in grouped IOs */
+ u8 is_read; /* SCSI OpCode for this stream */
+ u8 group_depth; /* total number of host commands in group */
+ /* TRUE if cannot add any more commands to this group */
+ bool group_flush;
+ u8 reserved[7]; /* pad to 64-bit alignment */ };
+
+struct LD_STREAM_DETECT {
+ bool write_back; /* TRUE if WB, FALSE if WT */
+ bool fp_write_enabled;
+ bool members_ssds;
+ bool fp_cache_bypass_capable;
+ u32 mru_bit_map; /* bitmap used to track MRU and LRU stream indicies */
+ /* this is the array of stream detect structures (one per stream) */
+ struct STREAM_DETECT stream_track[MAX_STREAMS_TRACKED];
+};
+
struct MPI2_IOC_INIT_RDPQ_ARRAY_ENTRY {
u64 RDPQBaseAddress;
u32 Reserved1;
@@ -983,6 +1093,7 @@ struct fusion_context {
struct LD_LOAD_BALANCE_INFO load_balance_info[MAX_LOGICAL_DRIVES_EXT];
LD_SPAN_INFO log_to_span[MAX_LOGICAL_DRIVES_EXT];
u8 adapter_type;
+ struct LD_STREAM_DETECT **stream_detect_by_ld;
};
union desc_value {
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (3 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 10:54 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
` (6 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
To improve RAID 1/10 Write performance, OS drivers need to issue the required Write
IOs as Fast Path IOs (after the appropriate checks allowing Fast Path to be used)
to the appropriate physical drives (translated from the OS logical IO) and wait for
all Write IOs to complete. If any of the Write IOs fail or time out, the IO will be
re issued to FW as an LD IO so FW can perform the error handling.
This patch is depending on patch 4
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 1 +
drivers/scsi/megaraid/megaraid_sas_fp.c | 31 ++-
drivers/scsi/megaraid/megaraid_sas_fusion.c | 341 ++++++++++++++++++++++++----
drivers/scsi/megaraid/megaraid_sas_fusion.h | 15 +-
4 files changed, 334 insertions(+), 54 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index d07b3e1..f4d6a94 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -2056,6 +2056,7 @@ struct megasas_instance {
u16 max_num_sge;
u16 max_fw_cmds;
+ u16 max_mpt_cmds;
u16 max_mfi_cmds;
u16 max_scsi_cmds;
u16 ldio_threshold;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
index a4e213b..eb9ff44 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
@@ -737,7 +737,7 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
struct MR_DRV_RAID_MAP_ALL *map)
{
struct MR_LD_RAID *raid = MR_LdRaidGet(ld, map);
- u32 pd, arRef;
+ u32 pd, arRef, r1_alt_pd;
u8 physArm, span;
u64 row;
u8 retval = TRUE;
@@ -772,9 +772,16 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
arRef = MR_LdSpanArrayGet(ld, span, map);
pd = MR_ArPdGet(arRef, physArm, map);
- if (pd != MR_PD_INVALID)
+ if (pd != MR_PD_INVALID) {
*pDevHandle = MR_PdDevHandleGet(pd, map);
- else {
+ /* get second pd also for raid 1/10 fast path writes*/
+ if (raid->level == 1) {
+ r1_alt_pd = MR_ArPdGet(arRef, physArm + 1, map);
+ if (r1_alt_pd != MR_PD_INVALID)
+ io_info->r1_alt_dev_handle =
+ MR_PdDevHandleGet(r1_alt_pd, map);
+ }
+ } else {
*pDevHandle = cpu_to_le16(MR_PD_INVALID);
if ((raid->level >= 5) &&
((fusion->adapter_type == THUNDERBOLT_SERIES) ||
@@ -819,7 +826,7 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
struct MR_DRV_RAID_MAP_ALL *map)
{
struct MR_LD_RAID *raid = MR_LdRaidGet(ld, map);
- u32 pd, arRef;
+ u32 pd, arRef, r1_alt_pd;
u8 physArm, span;
u64 row;
u8 retval = TRUE;
@@ -867,10 +874,17 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
arRef = MR_LdSpanArrayGet(ld, span, map);
pd = MR_ArPdGet(arRef, physArm, map); /* Get the pd */
- if (pd != MR_PD_INVALID)
+ if (pd != MR_PD_INVALID) {
/* Get dev handle from Pd. */
*pDevHandle = MR_PdDevHandleGet(pd, map);
- else {
+ /* get second pd also for raid 1/10 fast path writes*/
+ if (raid->level == 1) {
+ r1_alt_pd = MR_ArPdGet(arRef, physArm + 1, map);
+ if (r1_alt_pd != MR_PD_INVALID)
+ io_info->r1_alt_dev_handle =
+ MR_PdDevHandleGet(r1_alt_pd, map);
+ }
+ } else {
/* set dev handle as invalid. */
*pDevHandle = cpu_to_le16(MR_PD_INVALID);
if ((raid->level >= 5) &&
@@ -1126,6 +1140,11 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
/* If IO on an invalid Pd, then FP is not possible.*/
if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
io_info->fpOkForIo = FALSE;
+ /* set raid 1/10 fast path write capable bit in io_info */
+ if (io_info->fpOkForIo &&
+ (io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
+ (raid->level == 1) && !isRead)
+ io_info->is_raid_1_fp_write = 1;
return retval;
} else if (isRead) {
uint stripIdx;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 39dad6d..2fcd5cd 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -269,8 +269,15 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
instance->max_fw_cmds = cur_max_fw_cmds;
instance->ldio_threshold = ldio_threshold;
- if (!instance->is_rdpq)
- instance->max_fw_cmds = min_t(u16, instance->max_fw_cmds, 1024);
+ /*
+ * Do not lower Queue Depth for Ventura because RDPQ is not
+ * supported. Also NOTE that the driver will fail to load for
+ * more than 64 CPUs under Ventura because the maximum
+ * contiguous allocation is 4MB, which is only enough for 64
+ * MSIx vectors.
+ */
+
+ instance->max_fw_cmds = min_t(u16, instance->max_fw_cmds, 1024);
if (reset_devices)
instance->max_fw_cmds = min(instance->max_fw_cmds,
@@ -286,7 +293,14 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
(MEGASAS_FUSION_INTERNAL_CMDS +
MEGASAS_FUSION_IOCTL_CMDS);
instance->cur_can_queue = instance->max_scsi_cmds;
+ instance->host->can_queue = instance->cur_can_queue;
}
+
+ if (instance->is_ventura)
+ instance->max_mpt_cmds =
+ instance->max_fw_cmds * RAID_1_10_RMW_CMDS;
+ else
+ instance->max_mpt_cmds = instance->max_fw_cmds;
}
/**
* megasas_free_cmds_fusion - Free all the cmds in the free cmd pool
@@ -300,7 +314,7 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
struct megasas_cmd_fusion *cmd;
/* SG, Sense */
- for (i = 0; i < instance->max_fw_cmds; i++) {
+ for (i = 0; i < instance->max_mpt_cmds; i++) {
cmd = fusion->cmd_list[i];
if (cmd) {
if (cmd->sg_frame)
@@ -344,7 +358,7 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
/* cmd_list */
- for (i = 0; i < instance->max_fw_cmds; i++)
+ for (i = 0; i < instance->max_mpt_cmds; i++)
kfree(fusion->cmd_list[i]);
kfree(fusion->cmd_list);
@@ -396,33 +410,49 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
return -ENOMEM;
}
}
+
+ /* create sense buffer for the raid 1/10 fp */
+ for (i = max_cmd; i < instance->max_mpt_cmds; i++) {
+ cmd = fusion->cmd_list[i];
+ cmd->sense = pci_pool_alloc(fusion->sense_dma_pool,
+ GFP_KERNEL, &cmd->sense_phys_addr);
+ if (!cmd->sense) {
+ dev_err(&instance->pdev->dev,
+ "Failed from %s %d\n", __func__, __LINE__);
+ return -ENOMEM;
+ }
+ }
+
return 0;
}
int
megasas_alloc_cmdlist_fusion(struct megasas_instance *instance)
{
- u32 max_cmd, i;
+ u32 max_mpt_cmd, i;
struct fusion_context *fusion;
fusion = instance->ctrl_context;
- max_cmd = instance->max_fw_cmds;
+ max_mpt_cmd = instance->max_mpt_cmds;
/*
* fusion->cmd_list is an array of struct megasas_cmd_fusion pointers.
* Allocate the dynamic array first and then allocate individual
* commands.
*/
- fusion->cmd_list = kzalloc(sizeof(struct megasas_cmd_fusion *) * max_cmd,
- GFP_KERNEL);
+ fusion->cmd_list =
+ kzalloc(sizeof(struct megasas_cmd_fusion *) * max_mpt_cmd,
+ GFP_KERNEL);
if (!fusion->cmd_list) {
dev_err(&instance->pdev->dev,
"Failed from %s %d\n", __func__, __LINE__);
return -ENOMEM;
}
- for (i = 0; i < max_cmd; i++) {
+
+
+ for (i = 0; i < max_mpt_cmd; i++) {
fusion->cmd_list[i] = kzalloc(sizeof(struct megasas_cmd_fusion),
GFP_KERNEL);
if (!fusion->cmd_list[i]) {
@@ -657,13 +687,14 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
*/
/* SMID 0 is reserved. Set SMID/index from 1 */
- for (i = 0; i < instance->max_fw_cmds; i++) {
+ for (i = 0; i < instance->max_mpt_cmds; i++) {
cmd = fusion->cmd_list[i];
offset = MEGA_MPI2_RAID_DEFAULT_IO_FRAME_SIZE * i;
memset(cmd, 0, sizeof(struct megasas_cmd_fusion));
cmd->index = i + 1;
cmd->scmd = NULL;
- cmd->sync_cmd_idx = (i >= instance->max_scsi_cmds) ?
+ cmd->sync_cmd_idx =
+ (i >= instance->max_scsi_cmds && i < instance->max_fw_cmds) ?
(i - instance->max_scsi_cmds) :
(u32)ULONG_MAX; /* Set to Invalid */
cmd->instance = instance;
@@ -673,6 +704,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
memset(cmd->io_request, 0,
sizeof(struct MPI2_RAID_SCSI_IO_REQUEST));
cmd->io_request_phys_addr = io_req_base_phys + offset;
+ cmd->is_raid_1_fp_write = 0;
}
if (megasas_create_sg_sense_fusion(instance))
@@ -1262,12 +1294,12 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
fusion->reply_q_depth = 2 * (((max_cmd + 1 + 15)/16)*16);
fusion->request_alloc_sz =
- sizeof(union MEGASAS_REQUEST_DESCRIPTOR_UNION) *max_cmd;
+ sizeof(union MEGASAS_REQUEST_DESCRIPTOR_UNION) * instance->max_mpt_cmds;
fusion->reply_alloc_sz = sizeof(union MPI2_REPLY_DESCRIPTORS_UNION)
*(fusion->reply_q_depth);
fusion->io_frames_alloc_sz = MEGA_MPI2_RAID_DEFAULT_IO_FRAME_SIZE +
- (MEGA_MPI2_RAID_DEFAULT_IO_FRAME_SIZE *
- (max_cmd + 1)); /* Extra 1 for SMID 0 */
+ (MEGA_MPI2_RAID_DEFAULT_IO_FRAME_SIZE
+ * (instance->max_mpt_cmds + 1)); /* Extra 1 for SMID 0 */
scratch_pad_2 = readl(&instance->reg_set->outbound_scratch_pad_2);
/* If scratch_pad_2 & MEGASAS_MAX_CHAIN_SIZE_UNITS_MASK is set,
@@ -1403,42 +1435,43 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
*/
void
-map_cmd_status(struct megasas_cmd_fusion *cmd, u8 status, u8 ext_status)
+map_cmd_status(struct fusion_context *fusion,
+ struct scsi_cmnd *scmd, u8 status, u8 ext_status,
+ u32 data_length, u8 *sense)
{
switch (status) {
case MFI_STAT_OK:
- cmd->scmd->result = DID_OK << 16;
+ scmd->result = DID_OK << 16;
break;
case MFI_STAT_SCSI_IO_FAILED:
case MFI_STAT_LD_INIT_IN_PROGRESS:
- cmd->scmd->result = (DID_ERROR << 16) | ext_status;
+ scmd->result = (DID_ERROR << 16) | ext_status;
break;
case MFI_STAT_SCSI_DONE_WITH_ERROR:
- cmd->scmd->result = (DID_OK << 16) | ext_status;
+ scmd->result = (DID_OK << 16) | ext_status;
if (ext_status == SAM_STAT_CHECK_CONDITION) {
- memset(cmd->scmd->sense_buffer, 0,
+ memset(scmd->sense_buffer, 0,
SCSI_SENSE_BUFFERSIZE);
- memcpy(cmd->scmd->sense_buffer, cmd->sense,
+ memcpy(scmd->sense_buffer, sense,
SCSI_SENSE_BUFFERSIZE);
- cmd->scmd->result |= DRIVER_SENSE << 24;
+ scmd->result |= DRIVER_SENSE << 24;
}
break;
case MFI_STAT_LD_OFFLINE:
case MFI_STAT_DEVICE_NOT_FOUND:
- cmd->scmd->result = DID_BAD_TARGET << 16;
+ scmd->result = DID_BAD_TARGET << 16;
break;
case MFI_STAT_CONFIG_SEQ_MISMATCH:
- cmd->scmd->result = DID_IMM_RETRY << 16;
+ scmd->result = DID_IMM_RETRY << 16;
break;
default:
- dev_printk(KERN_DEBUG, &cmd->instance->pdev->dev, "FW status %#x\n", status);
- cmd->scmd->result = DID_ERROR << 16;
+ scmd->result = DID_ERROR << 16;
break;
}
}
@@ -1880,6 +1913,7 @@ static void megasas_stream_detect(struct megasas_instance *instance,
io_info.ldStartBlock = ((u64)start_lba_hi << 32) | start_lba_lo;
io_info.numBlocks = datalength;
io_info.ldTgtId = device_id;
+ io_info.r1_alt_dev_handle = MR_PD_INVALID;
io_request->DataLength = cpu_to_le32(scsi_bufflen(scp));
if (scp->sc_data_direction == PCI_DMA_FROMDEVICE)
@@ -1948,6 +1982,10 @@ static void megasas_stream_detect(struct megasas_instance *instance,
} else
scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
+ cmd->is_raid_1_fp_write = io_info.is_raid_1_fp_write;
+ if (io_info.is_raid_1_fp_write)
+ cmd->r1_alt_dev_handle = io_info.r1_alt_dev_handle;
+
if ((raidLUN[0] == 1) &&
(local_map_ptr->raidMap.devHndlInfo[io_info.pd_after_lb].validHandles > 1)) {
instance->dev_handle = !(instance->dev_handle);
@@ -2271,19 +2309,116 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
u8 *p;
struct fusion_context *fusion;
- if (index >= instance->max_fw_cmds) {
+ if (index >= instance->max_mpt_cmds) {
dev_err(&instance->pdev->dev, "Invalid SMID (0x%x)request for "
"descriptor for scsi%d\n", index,
instance->host->host_no);
return NULL;
}
fusion = instance->ctrl_context;
- p = fusion->req_frames_desc
- +sizeof(union MEGASAS_REQUEST_DESCRIPTOR_UNION) *index;
+ p = fusion->req_frames_desc +
+ sizeof(union MEGASAS_REQUEST_DESCRIPTOR_UNION) * index;
return (union MEGASAS_REQUEST_DESCRIPTOR_UNION *)p;
}
+/*
+ * megasas_fpio_to_ldio-
+ * This function converts an fp io to ldio
+*/
+
+void megasas_fpio_to_ldio(struct megasas_instance *instance,
+ struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
+{
+ struct fusion_context *fusion;
+ fusion = instance->ctrl_context;
+
+ cmd->request_desc->SCSIIO.RequestFlags =
+ (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
+ << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
+ cmd->io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
+ cmd->io_request->DevHandle = cpu_to_le16(MEGASAS_DEV_INDEX(scmd));
+
+ /*remove FAST PATH ENABLE bit in IoFlags */
+ cmd->io_request->IoFlags &=
+ cpu_to_le16(~MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
+
+ /* if the numSGE > max_sge_in_main_sge set the chain offset*/
+ if (cmd->io_request->RaidContext.raid_context_g35.num_sge >
+ fusion->max_sge_in_main_msg)
+ cmd->io_request->ChainOffset = fusion->chain_offset_io_request;
+ memcpy(cmd->io_request->CDB.CDB32, scmd->cmnd, scmd->cmd_len);
+ cmd->io_request->CDB.EEDP32.PrimaryReferenceTag = 0;
+ cmd->io_request->CDB.EEDP32.PrimaryApplicationTagMask = 0;
+ cmd->io_request->EEDPFlags = 0;
+ cmd->io_request->Control = 0;
+ cmd->io_request->EEDPBlockSize = 0;
+ cmd->is_raid_1_fp_write = 0;
+}
+/*megasas_prepate_secondRaid1_IO
+ * It prepares the raid 1 second IO
+ * */
+void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
+ struct megasas_cmd_fusion *cmd,
+ struct megasas_cmd_fusion *r1_cmd)
+{
+ union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc, *req_desc2 = NULL;
+ struct fusion_context *fusion;
+ fusion = instance->ctrl_context;
+ req_desc = cmd->request_desc;
+ if (r1_cmd) {
+ /* copy the io request frame as well
+ * as 8 SGEs data for r1 command
+ */
+ memcpy(r1_cmd->io_request, cmd->io_request,
+ sizeof(struct MPI2_RAID_SCSI_IO_REQUEST));
+ memcpy(&r1_cmd->io_request->SGL, &cmd->io_request->SGL,
+ (fusion->max_sge_in_main_msg *
+ sizeof(union MPI2_SGE_IO_UNION)));
+ /*sense buffer is different for r1 command*/
+ r1_cmd->io_request->SenseBufferLowAddress =
+ cpu_to_le32(r1_cmd->sense_phys_addr);
+ r1_cmd->scmd = cmd->scmd;
+ req_desc2 =
+ megasas_get_request_descriptor(instance, r1_cmd->index-1);
+ if (req_desc2) {
+ req_desc2->Words = 0;
+ r1_cmd->request_desc = req_desc2;
+ req_desc2->SCSIIO.SMID =
+ cpu_to_le16(r1_cmd->index);
+ req_desc2->SCSIIO.RequestFlags =
+ req_desc->SCSIIO.RequestFlags;
+ r1_cmd->is_raid_1_fp_write = 1;
+ r1_cmd->request_desc->SCSIIO.DevHandle =
+ cmd->r1_alt_dev_handle;
+ r1_cmd->io_request->DevHandle = cmd->r1_alt_dev_handle;
+ cmd->io_request->RaidContext.raid_context_g35.smid.peer_smid =
+ cpu_to_le16(r1_cmd->index);
+ r1_cmd->io_request->RaidContext.raid_context_g35.smid.peer_smid =
+ cpu_to_le16(cmd->index);
+ /*MSIxIndex of both commands request
+ * descriptors should be same
+ */
+ r1_cmd->request_desc->SCSIIO.MSIxIndex =
+ cmd->request_desc->SCSIIO.MSIxIndex;
+ /*span arm is different for r1 cmd*/
+ r1_cmd->io_request->RaidContext.raid_context_g35.span_arm =
+ cmd->io_request->RaidContext.raid_context_g35.span_arm + 1;
+ } else {
+ megasas_return_cmd_fusion(instance, r1_cmd);
+ dev_info(&instance->pdev->dev,
+ "unable to get request descriptor, firing as normal IO\n");
+ atomic_dec(&instance->fw_outstanding);
+ megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
+ }
+ } else {
+ dev_info(&instance->pdev->dev,
+ "unable to get command, firing as normal IO\n");
+ atomic_dec(&instance->fw_outstanding);
+ megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
+ }
+}
+
/**
* megasas_build_and_issue_cmd_fusion -Main routine for building and
* issuing non IOCTL cmd
@@ -2294,7 +2429,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
megasas_build_and_issue_cmd_fusion(struct megasas_instance *instance,
struct scsi_cmnd *scmd)
{
- struct megasas_cmd_fusion *cmd;
+ struct megasas_cmd_fusion *cmd, *r1_cmd = NULL;
union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
u32 index;
struct fusion_context *fusion;
@@ -2309,13 +2444,27 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
return SCSI_MLQUEUE_DEVICE_BUSY;
}
+ if (atomic_inc_return(&instance->fw_outstanding) >
+ instance->host->can_queue) {
+ dev_err(&instance->pdev->dev, "Throttle IOs beyond Controller queue depth\n");
+ atomic_dec(&instance->fw_outstanding);
+ return SCSI_MLQUEUE_HOST_BUSY;
+ }
+
cmd = megasas_get_cmd_fusion(instance, scmd->request->tag);
+ if (!cmd) {
+ atomic_dec(&instance->fw_outstanding);
+ return SCSI_MLQUEUE_HOST_BUSY;
+ }
+
index = cmd->index;
req_desc = megasas_get_request_descriptor(instance, index-1);
- if (!req_desc)
+ if (!req_desc) {
+ atomic_dec(&instance->fw_outstanding);
return SCSI_MLQUEUE_HOST_BUSY;
+ }
req_desc->Words = 0;
cmd->request_desc = req_desc;
@@ -2324,6 +2473,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
megasas_return_cmd_fusion(instance, cmd);
dev_err(&instance->pdev->dev, "Error building command\n");
cmd->request_desc = NULL;
+ atomic_dec(&instance->fw_outstanding);
return SCSI_MLQUEUE_HOST_BUSY;
}
@@ -2334,14 +2484,39 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
cmd->io_request->ChainOffset != 0xF)
dev_err(&instance->pdev->dev, "The chain offset value is not "
"correct : %x\n", cmd->io_request->ChainOffset);
+ /*
+ * if it is raid 1/10 fp write capable.
+ * try to get second command from pool and construct it.
+ * From FW, it has confirmed that lba values of two PDs
+ * corresponds to single R1/10 LD are always same
+ *
+ */
+ /* driver side count always should be less than max_fw_cmds
+ * to get new command
+ */
+ if (cmd->is_raid_1_fp_write &&
+ atomic_inc_return(&instance->fw_outstanding) >
+ (instance->host->can_queue)) {
+ megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
+ atomic_dec(&instance->fw_outstanding);
+ } else if (cmd->is_raid_1_fp_write) {
+ r1_cmd = megasas_get_cmd_fusion(instance,
+ (scmd->request->tag + instance->max_fw_cmds));
+ megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
+ }
+
/*
* Issue the command to the FW
*/
- atomic_inc(&instance->fw_outstanding);
megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
+ if (r1_cmd)
+ megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
+ instance->is_ventura);
+
+
return 0;
}
@@ -2358,10 +2533,10 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
struct MPI2_RAID_SCSI_IO_REQUEST *scsi_io_req;
struct fusion_context *fusion;
struct megasas_cmd *cmd_mfi;
- struct megasas_cmd_fusion *cmd_fusion;
+ struct megasas_cmd_fusion *cmd_fusion, *r1_cmd = NULL;
u16 smid, num_completed;
- u8 reply_descript_type;
- u32 status, extStatus, device_id;
+ u8 reply_descript_type, *sense;
+ u32 status, extStatus, device_id, data_length;
union desc_value d_val;
struct LD_LOAD_BALANCE_INFO *lbinfo;
int threshold_reply_count = 0;
@@ -2391,6 +2566,15 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
while (d_val.u.low != cpu_to_le32(UINT_MAX) &&
d_val.u.high != cpu_to_le32(UINT_MAX)) {
+ /*
+ * Ensure that the peer command is NULL here in case a
+ * command has completed but the R1 FP Write peer has
+ * not completed yet.If not null, it's possible that
+ * another thread will complete the peer
+ * command and should not.
+ */
+ r1_cmd = NULL;
+
smid = le16_to_cpu(reply_desc->SMID);
cmd_fusion = fusion->cmd_list[smid - 1];
@@ -2405,6 +2589,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
scmd_local = cmd_fusion->scmd;
status = scsi_io_req->RaidContext.raid_context.status;
extStatus = scsi_io_req->RaidContext.raid_context.exStatus;
+ sense = cmd_fusion->sense;
+ data_length = scsi_io_req->DataLength;
switch (scsi_io_req->Function) {
case MPI2_FUNCTION_SCSI_TASK_MGMT:
@@ -2421,12 +2607,28 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
/* Update load balancing info */
device_id = MEGASAS_DEV_INDEX(scmd_local);
lbinfo = &fusion->load_balance_info[device_id];
- if (cmd_fusion->scmd->SCp.Status &
- MEGASAS_LOAD_BALANCE_FLAG) {
+ /*
+ * check for the raid 1/10 fast path writes
+ */
+ if (!cmd_fusion->is_raid_1_fp_write &&
+ (cmd_fusion->scmd->SCp.Status &
+ MEGASAS_LOAD_BALANCE_FLAG)) {
atomic_dec(&lbinfo->scsi_pending_cmds[cmd_fusion->pd_r1_lb]);
cmd_fusion->scmd->SCp.Status &=
~MEGASAS_LOAD_BALANCE_FLAG;
+ } else if (cmd_fusion->is_raid_1_fp_write) {
+ /* get peer command */
+ if (cmd_fusion->index < instance->max_fw_cmds)
+ r1_cmd = fusion->cmd_list[(cmd_fusion->index +
+ instance->max_fw_cmds)-1];
+ else {
+ r1_cmd =
+ fusion->cmd_list[(cmd_fusion->index -
+ instance->max_fw_cmds)-1];
+ }
+ cmd_fusion->cmd_completed = true;
}
+
if (reply_descript_type ==
MPI2_RPY_DESCRIPT_FLAGS_SCSI_IO_SUCCESS) {
if (megasas_dbg_lvl == 5)
@@ -2436,14 +2638,48 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
/* Fall thru and complete IO */
case MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST: /* LD-IO Path */
/* Map the FW Cmd Status */
- map_cmd_status(cmd_fusion, status, extStatus);
- scsi_io_req->RaidContext.raid_context.status = 0;
- scsi_io_req->RaidContext.raid_context.exStatus = 0;
- if (megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
- atomic_dec(&instance->ldio_outstanding);
- megasas_return_cmd_fusion(instance, cmd_fusion);
- scsi_dma_unmap(scmd_local);
- scmd_local->scsi_done(scmd_local);
+ /*
+ * check for the raid 1/10 fast path writes
+ */
+ if (r1_cmd && r1_cmd->is_raid_1_fp_write
+ && r1_cmd->cmd_completed) {
+ /*
+ * if the peer Raid 1/10 fast path failed,
+ * mark IO as failed to the scsi layer.
+ * over write the current status by the failed
+ * status makes sure that if any one of
+ * command fails,return fail status to
+ * scsi layer
+ */
+ if (r1_cmd->io_request->RaidContext.raid_context.status !=
+ MFI_STAT_OK) {
+ status =
+ r1_cmd->io_request->RaidContext.raid_context.status;
+ extStatus =
+ r1_cmd->io_request->RaidContext.raid_context.exStatus;
+ data_length =
+ r1_cmd->io_request->DataLength;
+ sense = r1_cmd->sense;
+ }
+ r1_cmd->io_request->RaidContext.raid_context.status = 0;
+ r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
+ cmd_fusion->is_raid_1_fp_write = 0;
+ r1_cmd->is_raid_1_fp_write = 0;
+ r1_cmd->cmd_completed = false;
+ cmd_fusion->cmd_completed = false;
+ megasas_return_cmd_fusion(instance, r1_cmd);
+ }
+ if (!cmd_fusion->is_raid_1_fp_write) {
+ map_cmd_status(fusion, scmd_local, status,
+ extStatus, data_length, sense);
+ scsi_io_req->RaidContext.raid_context.status
+ = 0;
+ scsi_io_req->RaidContext.raid_context.exStatus
+ = 0;
+ megasas_return_cmd_fusion(instance, cmd_fusion);
+ scsi_dma_unmap(scmd_local);
+ scmd_local->scsi_done(scmd_local);
+ }
atomic_dec(&instance->fw_outstanding);
break;
@@ -3496,7 +3732,7 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
{
int retval = SUCCESS, i, j, convert = 0;
struct megasas_instance *instance;
- struct megasas_cmd_fusion *cmd_fusion;
+ struct megasas_cmd_fusion *cmd_fusion, *mpt_cmd_fusion;
struct fusion_context *fusion;
u32 abs_state, status_reg, reset_adapter;
u32 io_timeout_in_crash_mode = 0;
@@ -3571,6 +3807,18 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
/* Now return commands back to the OS */
for (i = 0 ; i < instance->max_scsi_cmds; i++) {
cmd_fusion = fusion->cmd_list[i];
+ /*check for extra commands issued by driver*/
+ if (instance->is_ventura) {
+ cmd_fusion->is_raid_1_fp_write = 0;
+ cmd_fusion->cmd_completed = false;
+ mpt_cmd_fusion =
+ fusion->cmd_list[i + instance->max_fw_cmds];
+ mpt_cmd_fusion->is_raid_1_fp_write = 0;
+ mpt_cmd_fusion->cmd_completed = false;
+ if (mpt_cmd_fusion->scmd)
+ megasas_return_cmd_fusion(instance,
+ mpt_cmd_fusion);
+ }
scmd_local = cmd_fusion->scmd;
if (cmd_fusion->scmd) {
scmd_local->result =
@@ -3581,10 +3829,11 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
megasas_return_cmd_fusion(instance, cmd_fusion);
scsi_dma_unmap(scmd_local);
scmd_local->scsi_done(scmd_local);
- atomic_dec(&instance->fw_outstanding);
}
}
+ atomic_set(&instance->fw_outstanding, 0);
+
status_reg = instance->instancet->read_fw_status_reg(
instance->reg_set);
abs_state = status_reg & MFI_STATE_MASK;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index ad90a98..5590c1d 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -94,6 +94,7 @@ enum MR_RAID_FLAGS_IO_SUB_TYPE {
#define MEGASAS_FP_CMD_LEN 16
#define MEGASAS_FUSION_IN_RESET 0
#define THRESHOLD_REPLY_COUNT 50
+#define RAID_1_10_RMW_CMDS 3
#define JBOD_MAPS_COUNT 2
enum MR_FUSION_ADAPTER_TYPE {
@@ -728,7 +729,9 @@ struct MR_SPAN_BLOCK_INFO {
struct MR_LD_RAID {
struct {
#if defined(__BIG_ENDIAN_BITFIELD)
- u32 reserved4:5;
+ u32 reserved4:3;
+ u32 fp_cache_bypass_capable:1;
+ u32 fp_rmw_capable:1;
u32 fpBypassRegionLock:1;
u32 tmCapable:1;
u32 fpNonRWCapable:1;
@@ -756,7 +759,9 @@ struct MR_LD_RAID {
u32 fpNonRWCapable:1;
u32 tmCapable:1;
u32 fpBypassRegionLock:1;
- u32 reserved4:5;
+ u32 fp_rmw_capable:1;
+ u32 fp_cache_bypass_capable:1;
+ u32 reserved4:3;
#endif
} capability;
__le32 reserved6;
@@ -830,6 +835,8 @@ struct IO_REQUEST_INFO {
u64 start_row;
u8 span_arm; /* span[7:5], arm[4:0] */
u8 pd_after_lb;
+ u16 r1_alt_dev_handle; /* raid 1/10 only */
+ bool is_raid_1_fp_write;
bool ra_capable;
};
@@ -883,6 +890,10 @@ struct megasas_cmd_fusion {
u32 index;
u8 pd_r1_lb;
struct completion done;
+ bool is_raid_1_fp_write;
+ u16 r1_alt_dev_handle; /* raid 1/10 only*/
+ bool cmd_completed; /* raid 1/10 fp writes status holder */
+
};
struct LD_LOAD_BALANCE_INFO {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes
2016-12-06 23:00 ` [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran
@ 2016-12-09 10:54 ` Tomas Henzl
0 siblings, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-09 10:54 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> To improve RAID 1/10 Write performance, OS drivers need to issue the required Write
> IOs as Fast Path IOs (after the appropriate checks allowing Fast Path to be used)
> to the appropriate physical drives (translated from the OS logical IO) and wait for
> all Write IOs to complete. If any of the Write IOs fail or time out, the IO will be
> re issued to FW as an LD IO so FW can perform the error handling.
>
> This patch is depending on patch 4
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (4 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 12:55 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
` (5 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to have different
sizes for different number of supported VDs.
This patch is depending on patch 5
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 7 +
drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++++--
drivers/scsi/megaraid/megaraid_sas_fp.c | 303 ++++++++++++++++++++++++----
drivers/scsi/megaraid/megaraid_sas_fusion.c | 223 ++++++++++++++++----
drivers/scsi/megaraid/megaraid_sas_fusion.h | 240 ++++++++++++++++++----
5 files changed, 699 insertions(+), 135 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index f4d6a94..3e087ab 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -1434,6 +1434,12 @@ enum FW_BOOT_CONTEXT {
#define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
#define MR_MAX_MSIX_REG_ARRAY 16
#define MR_RDPQ_MODE_OFFSET 0X00800000
+
+#define MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT 16
+#define MR_MAX_RAID_MAP_SIZE_MASK 0x1FF
+#define MR_MIN_MAP_SIZE 0x10000
+/* 64k */
+
#define MR_CAN_HANDLE_SYNC_CACHE_OFFSET 0X01000000
/*
@@ -2152,6 +2158,7 @@ struct megasas_instance {
bool fw_sync_cache_support;
bool is_ventura;
bool msix_combined;
+ u16 max_raid_mapsize;
};
struct MR_LD_VF_MAP {
u32 size;
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index c52f7be..3f06b57 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4424,8 +4424,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
static void megasas_update_ext_vd_details(struct megasas_instance *instance)
{
struct fusion_context *fusion;
- u32 old_map_sz;
- u32 new_map_sz;
+ u32 ventura_map_sz = 0;
fusion = instance->ctrl_context;
/* For MFI based controllers return dummy success */
@@ -4455,21 +4454,39 @@ static void megasas_update_ext_vd_details(struct megasas_instance *instance)
instance->supportmax256vd ? "Extended VD(240 VD)firmware" :
"Legacy(64 VD) firmware");
- old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
- (sizeof(struct MR_LD_SPAN_MAP) *
- (instance->fw_supported_vd_count - 1));
- new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
- fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
- (sizeof(struct MR_LD_SPAN_MAP) *
- (instance->drv_supported_vd_count - 1));
-
- fusion->max_map_sz = max(old_map_sz, new_map_sz);
+ if (instance->max_raid_mapsize) {
+ ventura_map_sz = instance->max_raid_mapsize *
+ MR_MIN_MAP_SIZE; /* 64k */
+ fusion->current_map_sz = ventura_map_sz;
+ fusion->max_map_sz = ventura_map_sz;
+ } else {
+ fusion->old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
+ (sizeof(struct MR_LD_SPAN_MAP) *
+ (instance->fw_supported_vd_count - 1));
+ fusion->new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
+ fusion->max_map_sz =
+ max(fusion->old_map_sz, fusion->new_map_sz);
- if (instance->supportmax256vd)
- fusion->current_map_sz = new_map_sz;
- else
- fusion->current_map_sz = old_map_sz;
+ if (instance->supportmax256vd)
+ fusion->current_map_sz = fusion->new_map_sz;
+ else
+ fusion->current_map_sz = fusion->old_map_sz;
+ }
+ /* irrespective of FW raid maps, driver raid map is constant */
+ fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP_ALL);
+#if VD_EXT_DEBUG
+ dev_info(&instance->pdev->dev, "instance->max_raid_mapsize 0x%x \n ",
+ instance->max_raid_mapsize);
+ dev_info(&instance->pdev->dev,
+ "new_map_sz = 0x%x, old_map_sz = 0x%x, "
+ "ventura_map_sz = 0x%x, current_map_sz = 0x%x "
+ "fusion->drv_map_sz =0x%x, size of driver raid map 0x%lx\n",
+ fusion->new_map_sz, fusion->old_map_sz,
+ ventura_map_sz, fusion->current_map_sz,
+ fusion->drv_map_sz,
+ sizeof(struct MR_DRV_RAID_MAP_ALL));
+#endif
}
/**
@@ -5010,7 +5027,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
{
u32 max_sectors_1;
u32 max_sectors_2;
- u32 tmp_sectors, msix_enable, scratch_pad_2;
+ u32 tmp_sectors, msix_enable, scratch_pad_2, scratch_pad_3;
resource_size_t base_addr;
struct megasas_register_set __iomem *reg_set;
struct megasas_ctrl_info *ctrl_info = NULL;
@@ -5086,7 +5103,17 @@ static int megasas_init_fw(struct megasas_instance *instance)
goto fail_ready_state;
}
-
+ if (instance->is_ventura) {
+ scratch_pad_3 =
+ readl(&instance->reg_set->outbound_scratch_pad_3);
+#if VD_EXT_DEBUG
+ dev_info(&instance->pdev->dev, "scratch_pad3 0x%x\n",
+ scratch_pad_3);
+#endif
+ instance->max_raid_mapsize = ((scratch_pad_3 >>
+ MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT) &
+ MR_MAX_RAID_MAP_SIZE_MASK);
+ }
/* Check if MSI-X is supported while in ready state */
msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
index eb9ff44..a6957a3 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
@@ -179,18 +179,204 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
struct fusion_context *fusion = instance->ctrl_context;
struct MR_FW_RAID_MAP_ALL *fw_map_old = NULL;
struct MR_FW_RAID_MAP *pFwRaidMap = NULL;
- int i;
+ int i, j;
u16 ld_count;
+ struct MR_FW_RAID_MAP_DYNAMIC *fw_map_dyn;
+ struct MR_FW_RAID_MAP_EXT *fw_map_ext;
+ struct MR_RAID_MAP_DESC_TABLE *desc_table;
struct MR_DRV_RAID_MAP_ALL *drv_map =
fusion->ld_drv_map[(instance->map_id & 1)];
struct MR_DRV_RAID_MAP *pDrvRaidMap = &drv_map->raidMap;
+ void *raid_map_data = NULL;
+
+ memset(drv_map, 0, fusion->drv_map_sz);
+ memset(pDrvRaidMap->ldTgtIdToLd,
+ 0xff, (sizeof(u16) * MAX_LOGICAL_DRIVES_DYN));
+
+ if (instance->max_raid_mapsize) {
+ fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
+#if VD_EXT_DEBUG
+ dev_dbg(&instance->pdev->dev,
+ " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
+ " descTableSize 0x%x descTableNumElements 0x%x\n",
+ le32_to_cpu(fw_map_dyn->raid_map_size),
+ le32_to_cpu(fw_map_dyn->desc_table_offset),
+ le32_to_cpu(fw_map_dyn->desc_table_size),
+ le32_to_cpu(fw_map_dyn->desc_table_num_elements));
+ dev_dbg(&instance->pdev->dev,
+ "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
+#endif
+ desc_table =
+ (struct MR_RAID_MAP_DESC_TABLE *)((void *)fw_map_dyn +
+ le32_to_cpu(fw_map_dyn->desc_table_offset));
+ if (desc_table != fw_map_dyn->raid_map_desc_table) {
+ dev_err(&instance->pdev->dev,
+ "offsets of desc table are not matching returning "
+ " FW raid map has been changed: desc %p original %p\n",
+ desc_table, fw_map_dyn->raid_map_desc_table);
+ }
+ ld_count = (u16)le16_to_cpu(fw_map_dyn->ld_count);
+ pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
+ pDrvRaidMap->fpPdIoTimeoutSec = fw_map_dyn->fp_pd_io_timeout_sec;
+ pDrvRaidMap->totalSize = sizeof(struct MR_DRV_RAID_MAP_ALL);
+ /* point to actual data starting point*/
+ raid_map_data = (void *)fw_map_dyn +
+ le32_to_cpu(fw_map_dyn->desc_table_offset) +
+ le32_to_cpu(fw_map_dyn->desc_table_size);
+
+ for (i = 0; i < le32_to_cpu(fw_map_dyn->desc_table_num_elements); ++i) {
+ if (!desc_table) {
+ dev_err(&instance->pdev->dev,
+ "desc table is null, coming out %p \n", desc_table);
+ return;
+ }
+#if VD_EXT_DEBUG
+ dev_err(&instance->pdev->dev,
+ "desc table %p \n", desc_table);
+ dev_err(&instance->pdev->dev,
+ "raidmap type %d, raidmapOffset 0x%x, "
+ " raid map number of elements 0%x, raidmapsize 0x%x\n",
+ desc_table->raid_map_desc_type,
+ desc_table->raid_map_desc_offset,
+ desc_table->raid_map_desc_elements,
+ desc_table->raid_map_desc_buffer_size);
+#endif
+ switch (le32_to_cpu(desc_table->raid_map_desc_type)) {
+ case RAID_MAP_DESC_TYPE_DEVHDL_INFO:
+ fw_map_dyn->dev_hndl_info = (struct MR_DEV_HANDLE_INFO *)
+ (raid_map_data +
+ le32_to_cpu(desc_table->raid_map_desc_offset));
+#if VD_EXT_DEBUG
+ dev_err(&instance->pdev->dev,
+ "devHndlInfo address %p\n",
+ fw_map_dyn->dev_hndl_info);
+#endif
+ memcpy(pDrvRaidMap->devHndlInfo, fw_map_dyn->dev_hndl_info,
+ sizeof(struct MR_DEV_HANDLE_INFO) *
+ le32_to_cpu(desc_table->raid_map_desc_elements));
+ break;
+ case RAID_MAP_DESC_TYPE_TGTID_INFO:
+ fw_map_dyn->ld_tgt_id_to_ld = (u16 *) (raid_map_data +
+ le32_to_cpu(desc_table->raid_map_desc_offset));
+#if VD_EXT_DEBUG
+ dev_err(&instance->pdev->dev,
+ "ldTgtIdToLd address %p\n",
+ fw_map_dyn->ld_tgt_id_to_ld);
+#endif
+ for (j = 0; j < le32_to_cpu(desc_table->raid_map_desc_elements); j++) {
+ pDrvRaidMap->ldTgtIdToLd[j] =
+ fw_map_dyn->ld_tgt_id_to_ld[j];
+#if VD_EXT_DEBUG
+ dev_err(&instance->pdev->dev,
+ " %d drv ldTgtIdToLd %d\n",
+ j, pDrvRaidMap->ldTgtIdToLd[j]);
+#endif
+ }
+ break;
+ case RAID_MAP_DESC_TYPE_ARRAY_INFO:
+ fw_map_dyn->ar_map_info = (struct MR_ARRAY_INFO *)
+ (raid_map_data + le32_to_cpu(desc_table->raid_map_desc_offset));
+#if VD_EXT_DEBUG
+ dev_err(&instance->pdev->dev,
+ "arMapInfo address %p\n",
+ fw_map_dyn->ar_map_info);
+#endif
+
+ memcpy(pDrvRaidMap->arMapInfo,
+ fw_map_dyn->ar_map_info,
+ sizeof(struct MR_ARRAY_INFO) *
+ le32_to_cpu(desc_table->raid_map_desc_elements));
+ break;
+ case RAID_MAP_DESC_TYPE_SPAN_INFO:
+ fw_map_dyn->ld_span_map = (struct MR_LD_SPAN_MAP *)
+ (raid_map_data + le32_to_cpu(desc_table->raid_map_desc_offset));
+ memcpy(pDrvRaidMap->ldSpanMap,
+ fw_map_dyn->ld_span_map,
+ sizeof(struct MR_LD_SPAN_MAP) *
+ le32_to_cpu(desc_table->raid_map_desc_elements));
+#if VD_EXT_DEBUG
+ dev_err(&instance->pdev->dev,
+ "ldSpanMap address %p\n",
+ fw_map_dyn->ld_span_map);
+ dev_err(&instance->pdev->dev,
+ "MR_LD_SPAN_MAP size 0x%lx\n", sizeof(struct MR_LD_SPAN_MAP));
+ for (j = 0; j < ld_count; j++) {
+ printk(KERN_DEBUG "megaraid_sas(%d) : fw_map_dyn->ldSpanMap[%d].ldRaid.targetId 0x%x fw_map_dyn->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
+ j, j, fw_map_dyn->ld_span_map[j].ldRaid.targetId, j,
+ fw_map_dyn->ld_span_map[j].ldRaid.seqNum,
+ (u32)fw_map_dyn->ld_span_map[j].ldRaid.rowSize);
+ printk(KERN_DEBUG "megaraid_sas(%d) :pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
+ j, j, pDrvRaidMap->ldSpanMap[j].ldRaid.targetId, j,
+ pDrvRaidMap->ldSpanMap[j].ldRaid.seqNum,
+ (u32)pDrvRaidMap->ldSpanMap[j].ldRaid.rowSize);
+ printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p/%p\n",
+ instance->unique_id, drv_map, pDrvRaidMap,
+ &fw_map_dyn->ld_span_map[j].ldRaid,
+ &pDrvRaidMap->ldSpanMap[j].ldRaid);
+ }
+#endif
+ break;
+ default:
+ dev_err(&instance->pdev->dev,
+ "wrong number of desctableElements %d\n",
+ fw_map_dyn->desc_table_num_elements);
+ }
+ ++desc_table;
+ }
+
+ } else if (instance->supportmax256vd) {
+ fw_map_ext =
+ (struct MR_FW_RAID_MAP_EXT *) fusion->ld_map[(instance->map_id & 1)];
+ ld_count = (u16)le16_to_cpu(fw_map_ext->ldCount);
+ if (ld_count > MAX_LOGICAL_DRIVES_EXT) {
+ printk(KERN_DEBUG "megaraid_sas: LD count exposed in RAID map in not valid\n");
+ return;
+ }
+#if VD_EXT_DEBUG
+ for (i = 0; i < ld_count; i++) {
+ printk(KERN_DEBUG "megaraid_sas(%d) :Index 0x%x Target Id 0x%x Seq Num 0x%x Size 0/%llx\n",
+ instance->unique_id,
+ i, fw_map_ext->ldSpanMap[i].ldRaid.targetId,
+ fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
+ fw_map_ext->ldSpanMap[i].ldRaid.size);
+ }
+#endif
+
+ pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
+ pDrvRaidMap->fpPdIoTimeoutSec =
+ fw_map_ext->fpPdIoTimeoutSec;
+ for (i = 0; i < (MAX_LOGICAL_DRIVES_EXT); i++)
+ pDrvRaidMap->ldTgtIdToLd[i] =
+ (u16)fw_map_ext->ldTgtIdToLd[i];
+ memcpy(pDrvRaidMap->ldSpanMap,
+ fw_map_ext->ldSpanMap,
+ sizeof(struct MR_LD_SPAN_MAP) *
+ ld_count);
+#if VD_EXT_DEBUG
+ for (i = 0; i < ld_count; i++) {
+ printk(KERN_DEBUG "megaraid_sas(%d) : fw_map_ext->ldSpanMap[%d].ldRaid.targetId 0x%x fw_map_ext->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
+ i, i, fw_map_ext->ldSpanMap[i].ldRaid.targetId, i,
+ fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
+ (u32)fw_map_ext->ldSpanMap[i].ldRaid.rowSize);
+ printk(KERN_DEBUG "megaraid_sas(%d) : pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x"
+ "pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
+ i, i, pDrvRaidMap->ldSpanMap[i].ldRaid.targetId, i,
+ pDrvRaidMap->ldSpanMap[i].ldRaid.seqNum,
+ (u32)pDrvRaidMap->ldSpanMap[i].ldRaid.rowSize);
+ printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p %p\n",
+ instance->unique_id, drv_map, pDrvRaidMap,
+ &fw_map_ext->ldSpanMap[i].ldRaid,
+ &pDrvRaidMap->ldSpanMap[i].ldRaid);
+ }
+#endif
+ memcpy(pDrvRaidMap->arMapInfo, fw_map_ext->arMapInfo,
+ sizeof(struct MR_ARRAY_INFO) * MAX_API_ARRAYS_EXT);
+ memcpy(pDrvRaidMap->devHndlInfo, fw_map_ext->devHndlInfo,
+ sizeof(struct MR_DEV_HANDLE_INFO) *
+ MAX_RAIDMAP_PHYSICAL_DEVICES);
- if (instance->supportmax256vd) {
- memcpy(fusion->ld_drv_map[instance->map_id & 1],
- fusion->ld_map[instance->map_id & 1],
- fusion->current_map_sz);
/* New Raid map will not set totalSize, so keep expected value
* for legacy code in ValidateMapInfo
*/
@@ -213,16 +399,12 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
}
#endif
- memset(drv_map, 0, fusion->drv_map_sz);
pDrvRaidMap->totalSize = pFwRaidMap->totalSize;
pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
pDrvRaidMap->fpPdIoTimeoutSec = pFwRaidMap->fpPdIoTimeoutSec;
for (i = 0; i < MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS; i++)
pDrvRaidMap->ldTgtIdToLd[i] =
(u8)pFwRaidMap->ldTgtIdToLd[i];
- for (i = (MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS);
- i < MAX_LOGICAL_DRIVES_EXT; i++)
- pDrvRaidMap->ldTgtIdToLd[i] = 0xff;
for (i = 0; i < ld_count; i++) {
pDrvRaidMap->ldSpanMap[i] = pFwRaidMap->ldSpanMap[i];
#if VD_EXT_DEBUG
@@ -279,7 +461,9 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance)
lbInfo = fusion->load_balance_info;
ldSpanInfo = fusion->log_to_span;
- if (instance->supportmax256vd)
+ if (instance->max_raid_mapsize)
+ expected_size = sizeof(struct MR_DRV_RAID_MAP_ALL);
+ else if (instance->supportmax256vd)
expected_size = sizeof(struct MR_FW_RAID_MAP_EXT);
else
expected_size =
@@ -287,8 +471,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance)
(sizeof(struct MR_LD_SPAN_MAP) * le16_to_cpu(pDrvRaidMap->ldCount)));
if (le32_to_cpu(pDrvRaidMap->totalSize) != expected_size) {
- dev_err(&instance->pdev->dev, "map info structure size 0x%x is not matching with ld count\n",
- (unsigned int) expected_size);
+ dev_err(&instance->pdev->dev, "megasas: map info structure"
+ " size 0x%x is not matching expected size 0x%x\n",
+ le32_to_cpu(pDrvRaidMap->totalSize),
+ (unsigned int) expected_size);
dev_err(&instance->pdev->dev, "megasas: span map %x, pDrvRaidMap->totalSize : %x\n",
(unsigned int)sizeof(struct MR_LD_SPAN_MAP),
le32_to_cpu(pDrvRaidMap->totalSize));
@@ -787,7 +973,7 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
((fusion->adapter_type == THUNDERBOLT_SERIES) ||
((fusion->adapter_type == INVADER_SERIES) &&
(raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
- pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
+ pRAID_Context->reg_lock_flags = REGION_TYPE_EXCLUSIVE;
else if (raid->level == 1) {
physArm = physArm + 1;
pd = MR_ArPdGet(arRef, physArm, map);
@@ -797,9 +983,16 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
}
*pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span, map)->startBlk);
- pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
- physArm;
- io_info->span_arm = pRAID_Context->spanArm;
+ if (instance->is_ventura) {
+ ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
+ io_info->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
+ } else {
+ pRAID_Context->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
+ io_info->span_arm = pRAID_Context->span_arm;
+ }
return retval;
}
@@ -891,7 +1084,7 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
((fusion->adapter_type == THUNDERBOLT_SERIES) ||
((fusion->adapter_type == INVADER_SERIES) &&
(raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
- pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
+ pRAID_Context->reg_lock_flags = REGION_TYPE_EXCLUSIVE;
else if (raid->level == 1) {
/* Get alternate Pd. */
physArm = physArm + 1;
@@ -903,9 +1096,16 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
}
*pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span, map)->startBlk);
- pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
- physArm;
- io_info->span_arm = pRAID_Context->spanArm;
+ if (instance->is_ventura) {
+ ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
+ io_info->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
+ } else {
+ pRAID_Context->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
+ io_info->span_arm = pRAID_Context->span_arm;
+ }
return retval;
}
@@ -1109,20 +1309,20 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
regSize += stripSize;
}
- pRAID_Context->timeoutValue =
+ pRAID_Context->timeout_value =
cpu_to_le16(raid->fpIoTimeoutForLd ?
raid->fpIoTimeoutForLd :
map->raidMap.fpPdIoTimeoutSec);
if (fusion->adapter_type == INVADER_SERIES)
- pRAID_Context->regLockFlags = (isRead) ?
+ pRAID_Context->reg_lock_flags = (isRead) ?
raid->regTypeReqOnRead : raid->regTypeReqOnWrite;
- else
- pRAID_Context->regLockFlags = (isRead) ?
+ else if (!instance->is_ventura)
+ pRAID_Context->reg_lock_flags = (isRead) ?
REGION_TYPE_SHARED_READ : raid->regTypeReqOnWrite;
- pRAID_Context->VirtualDiskTgtId = raid->targetId;
- pRAID_Context->regLockRowLBA = cpu_to_le64(regStart);
- pRAID_Context->regLockLength = cpu_to_le32(regSize);
- pRAID_Context->configSeqNum = raid->seqNum;
+ pRAID_Context->virtual_disk_tgt_id = raid->targetId;
+ pRAID_Context->reg_lock_row_lba = cpu_to_le64(regStart);
+ pRAID_Context->reg_lock_length = cpu_to_le32(regSize);
+ pRAID_Context->config_seq_num = raid->seqNum;
/* save pointer to raid->LUN array */
*raidLUN = raid->LUN;
@@ -1140,6 +1340,14 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
/* If IO on an invalid Pd, then FP is not possible.*/
if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
io_info->fpOkForIo = FALSE;
+ /* if FP possible, set the SLUD bit in
+ * regLockFlags for ventura
+ */
+ else if ((instance->is_ventura) && !isRead &&
+ (raid->writeMode == MR_RL_WRITE_BACK_MODE) &&
+ raid->capability.fp_cache_bypass_capable)
+ ((struct RAID_CONTEXT_G35 *) pRAID_Context)->routing_flags.bits.sld
+ = 1;
/* set raid 1/10 fast path write capable bit in io_info */
if (io_info->fpOkForIo &&
(io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
@@ -1319,6 +1527,7 @@ u8 megasas_get_best_arm_pd(struct megasas_instance *instance,
struct fusion_context *fusion;
struct MR_LD_RAID *raid;
struct MR_DRV_RAID_MAP_ALL *drv_map;
+ u16 pd1_dev_handle;
u16 pend0, pend1, ld;
u64 diff0, diff1;
u8 bestArm, pd0, pd1, span, arm;
@@ -1344,23 +1553,37 @@ u8 megasas_get_best_arm_pd(struct megasas_instance *instance,
pd1 = MR_ArPdGet(arRef, (arm + 1) >= span_row_size ?
(arm + 1 - span_row_size) : arm + 1, drv_map);
- /* get the pending cmds for the data and mirror arms */
- pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
- pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
+ /* Get PD1 Dev Handle */
- /* Determine the disk whose head is nearer to the req. block */
- diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
- diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
- bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
+ pd1_dev_handle = MR_PdDevHandleGet(pd1, drv_map);
- if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
+ if (pd1_dev_handle == MR_PD_INVALID) {
+ bestArm = arm;
+ } else {
+ /* get the pending cmds for the data and mirror arms */
+ pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
+ pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
+
+ /* Determine the disk whose head is nearer to the req. block */
+ diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
+ diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
+ /*bestArm = diff0<=diff1 ? arm : arm ^ 1;*/
+ bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
+
+ /* Make balance count from 16 to 4 to
+ * keep driver in sync with Firmware
+ */
+ if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
(bestArm != arm && pend1 > pend0 + lb_pending_cmds))
- bestArm ^= 1;
+ bestArm ^= 1;
+
+ /* Update the last accessed block on the correct pd */
+ io_info->span_arm =
+ (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
+ io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
+ }
- /* Update the last accessed block on the correct pd */
- io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
lbInfo->last_accessed_block[io_info->pd_after_lb] = block + count - 1;
- io_info->span_arm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
#if SPAN_DEBUG
if (arm != bestArm)
dev_dbg(&instance->pdev->dev, "LSI Debug R1 Load balance "
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 2fcd5cd..58f86aa 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1834,7 +1834,7 @@ static void megasas_stream_detect(struct megasas_instance *instance,
struct megasas_cmd_fusion *cmd)
{
u8 fp_possible;
- u32 start_lba_lo, start_lba_hi, device_id, datalength = 0;
+ u32 start_lba_lo, start_lba_hi, device_id, datalength = 0, ld;
struct MPI2_RAID_SCSI_IO_REQUEST *io_request;
union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
struct IO_REQUEST_INFO io_info;
@@ -1842,16 +1842,18 @@ static void megasas_stream_detect(struct megasas_instance *instance,
struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
u8 *raidLUN;
unsigned long spinlock_flags;
+ union RAID_CONTEXT_UNION *praid_context;
+ struct MR_LD_RAID *raid;
device_id = MEGASAS_DEV_INDEX(scp);
fusion = instance->ctrl_context;
io_request = cmd->io_request;
- io_request->RaidContext.raid_context.VirtualDiskTgtId =
+ io_request->RaidContext.raid_context.virtual_disk_tgt_id =
cpu_to_le16(device_id);
io_request->RaidContext.raid_context.status = 0;
- io_request->RaidContext.raid_context.exStatus = 0;
+ io_request->RaidContext.raid_context.ex_status = 0;
req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION *)cmd->request_desc;
@@ -1920,10 +1922,12 @@ static void megasas_stream_detect(struct megasas_instance *instance,
io_info.isRead = 1;
local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
+ ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
+ raid = MR_LdRaidGet(ld, local_map_ptr);
if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
instance->fw_supported_vd_count) || (!fusion->fast_path_io)) {
- io_request->RaidContext.raid_context.regLockFlags = 0;
+ io_request->RaidContext.raid_context.reg_lock_flags = 0;
fp_possible = 0;
} else {
if (MR_BuildRaidContext(instance, &io_info,
@@ -1950,6 +1954,8 @@ static void megasas_stream_detect(struct megasas_instance *instance,
fp_possible = false;
}
+ praid_context = &io_request->RaidContext;
+
if (fp_possible) {
megasas_set_pd_lba(io_request, scp->cmd_len, &io_info, scp,
local_map_ptr, start_lba_lo);
@@ -1958,18 +1964,26 @@ static void megasas_stream_detect(struct megasas_instance *instance,
(MPI2_REQ_DESCRIPT_FLAGS_FP_IO
<< MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
if (fusion->adapter_type == INVADER_SERIES) {
- if (io_request->RaidContext.raid_context.regLockFlags ==
+ if (io_request->RaidContext.raid_context.reg_lock_flags ==
REGION_TYPE_UNUSED)
cmd->request_desc->SCSIIO.RequestFlags =
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
- io_request->RaidContext.raid_context.Type
+ io_request->RaidContext.raid_context.type
= MPI2_TYPE_CUDA;
io_request->RaidContext.raid_context.nseg = 0x1;
io_request->IoFlags |= cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
- io_request->RaidContext.raid_context.regLockFlags |=
+ io_request->RaidContext.raid_context.reg_lock_flags |=
(MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
MR_RL_FLAGS_SEQ_NUM_ENABLE);
+ } else if (instance->is_ventura) {
+ io_request->RaidContext.raid_context_g35.type
+ = MPI2_TYPE_CUDA;
+ io_request->RaidContext.raid_context_g35.nseg = 0x1;
+ io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
+ = 1;
+ io_request->IoFlags |=
+ cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
}
if ((fusion->load_balance_info[device_id].loadBalanceFlag) &&
(io_info.isRead)) {
@@ -1979,6 +1993,13 @@ static void megasas_stream_detect(struct megasas_instance *instance,
&io_info);
scp->SCp.Status |= MEGASAS_LOAD_BALANCE_FLAG;
cmd->pd_r1_lb = io_info.pd_after_lb;
+ if (instance->is_ventura)
+ io_request->RaidContext.raid_context_g35.span_arm
+ = io_info.span_arm;
+ else
+ io_request->RaidContext.raid_context.span_arm
+ = io_info.span_arm;
+
} else
scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
@@ -1997,28 +2018,98 @@ static void megasas_stream_detect(struct megasas_instance *instance,
io_request->DevHandle = io_info.devHandle;
/* populate the LUN field */
memcpy(io_request->LUN, raidLUN, 8);
+ if (instance->is_ventura) {
+ if (io_info.isRead) {
+ if ((raid->cpuAffinity.pdRead.cpu0) &&
+ (raid->cpuAffinity.pdRead.cpu1))
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_FCFS;
+ else if (raid->cpuAffinity.pdRead.cpu1)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_1;
+ else
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+ } else {
+ if ((raid->cpuAffinity.pdWrite.cpu0)
+ && (raid->cpuAffinity.pdWrite.cpu1))
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_FCFS;
+ else if (raid->cpuAffinity.pdWrite.cpu1)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_1;
+ else
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+ if (praid_context->raid_context_g35.routing_flags.bits.sld) {
+ praid_context->raid_context_g35.raid_flags
+ = (MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
+ << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
+ }
+ }
+ }
} else {
- io_request->RaidContext.raid_context.timeoutValue =
+ io_request->RaidContext.raid_context.timeout_value =
cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
cmd->request_desc->SCSIIO.RequestFlags =
(MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
<< MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
if (fusion->adapter_type == INVADER_SERIES) {
if (io_info.do_fp_rlbypass ||
- (io_request->RaidContext.raid_context.regLockFlags
+ (io_request->RaidContext.raid_context.reg_lock_flags
== REGION_TYPE_UNUSED))
cmd->request_desc->SCSIIO.RequestFlags =
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
- io_request->RaidContext.raid_context.Type
+ io_request->RaidContext.raid_context.type
= MPI2_TYPE_CUDA;
- io_request->RaidContext.raid_context.regLockFlags |=
+ io_request->RaidContext.raid_context.reg_lock_flags |=
(MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
MR_RL_FLAGS_SEQ_NUM_ENABLE);
io_request->RaidContext.raid_context.nseg = 0x1;
+ } else if (instance->is_ventura) {
+ io_request->RaidContext.raid_context_g35.type
+ = MPI2_TYPE_CUDA;
+ io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
+ = 1;
+ io_request->RaidContext.raid_context_g35.nseg = 0x1;
}
io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
io_request->DevHandle = cpu_to_le16(device_id);
+
+ if (instance->is_ventura) {
+ if (io_info.isRead) {
+ if ((raid->cpuAffinity.ldRead.cpu0)
+ && (raid->cpuAffinity.ldRead.cpu1))
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_FCFS;
+ else if (raid->cpuAffinity.ldRead.cpu1)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_1;
+ else
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+ } else {
+ if ((raid->cpuAffinity.ldWrite.cpu0) &&
+ (raid->cpuAffinity.ldWrite.cpu1))
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_FCFS;
+ else if (raid->cpuAffinity.ldWrite.cpu1)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_1;
+ else
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+
+ if (io_request->RaidContext.raid_context_g35.stream_detected
+ && (raid->level == 5)
+ && (raid->writeMode == MR_RL_WRITE_THROUGH_MODE)) {
+ if (praid_context->raid_context_g35.routing_flags.bits.cpu_sel == MR_RAID_CTX_CPUSEL_FCFS)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+ }
+ }
+ }
} /* Not FP */
}
@@ -2053,9 +2144,9 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
/* get RAID_Context pointer */
pRAID_Context = &io_request->RaidContext.raid_context;
/* Check with FW team */
- pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
- pRAID_Context->regLockRowLBA = 0;
- pRAID_Context->regLockLength = 0;
+ pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
+ pRAID_Context->reg_lock_row_lba = 0;
+ pRAID_Context->reg_lock_length = 0;
if (fusion->fast_path_io && (
device_id < instance->fw_supported_vd_count)) {
@@ -2074,7 +2165,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
io_request->DevHandle = cpu_to_le16(device_id);
io_request->LUN[1] = scmd->device->lun;
- pRAID_Context->timeoutValue =
+ pRAID_Context->timeout_value =
cpu_to_le16 (scmd->request->timeout / HZ);
cmd->request_desc->SCSIIO.RequestFlags =
(MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
@@ -2082,9 +2173,10 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
} else {
/* set RAID context values */
- pRAID_Context->configSeqNum = raid->seqNum;
- pRAID_Context->regLockFlags = REGION_TYPE_SHARED_READ;
- pRAID_Context->timeoutValue = cpu_to_le16(raid->fpIoTimeoutForLd);
+ pRAID_Context->config_seq_num = raid->seqNum;
+ if (!instance->is_ventura)
+ pRAID_Context->reg_lock_flags = REGION_TYPE_SHARED_READ;
+ pRAID_Context->timeout_value = cpu_to_le16(raid->fpIoTimeoutForLd);
/* get the DevHandle for the PD (since this is
fpNonRWCapable, this is a single disk RAID0) */
@@ -2139,12 +2231,12 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
io_request = cmd->io_request;
/* get RAID_Context pointer */
pRAID_Context = &io_request->RaidContext.raid_context;
- pRAID_Context->regLockFlags = 0;
- pRAID_Context->regLockRowLBA = 0;
- pRAID_Context->regLockLength = 0;
+ pRAID_Context->reg_lock_flags = 0;
+ pRAID_Context->reg_lock_row_lba = 0;
+ pRAID_Context->reg_lock_length = 0;
io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
io_request->LUN[1] = scmd->device->lun;
- pRAID_Context->RAIDFlags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
+ pRAID_Context->raid_flags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
<< MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
/* If FW supports PD sequence number */
@@ -2153,24 +2245,28 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
/* TgtId must be incremented by 255 as jbod seq number is index
* below raid map
*/
- pRAID_Context->VirtualDiskTgtId =
+ pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id + (MAX_PHYSICAL_DEVICES - 1));
- pRAID_Context->configSeqNum = pd_sync->seq[pd_index].seqNum;
+ pRAID_Context->config_seq_num = pd_sync->seq[pd_index].seqNum;
io_request->DevHandle = pd_sync->seq[pd_index].devHandle;
- pRAID_Context->regLockFlags |=
+ if (instance->is_ventura)
+ io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
+ = 1;
+ else
+ pRAID_Context->reg_lock_flags |=
(MR_RL_FLAGS_SEQ_NUM_ENABLE|MR_RL_FLAGS_GRANT_DESTINATION_CUDA);
- pRAID_Context->Type = MPI2_TYPE_CUDA;
+ pRAID_Context->type = MPI2_TYPE_CUDA;
pRAID_Context->nseg = 0x1;
} else if (fusion->fast_path_io) {
- pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
- pRAID_Context->configSeqNum = 0;
+ pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
+ pRAID_Context->config_seq_num = 0;
local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
io_request->DevHandle =
local_map_ptr->raidMap.devHndlInfo[device_id].curDevHdl;
} else {
/* Want to send all IO via FW path */
- pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
- pRAID_Context->configSeqNum = 0;
+ pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
+ pRAID_Context->config_seq_num = 0;
io_request->DevHandle = cpu_to_le16(0xFFFF);
}
@@ -2186,14 +2282,14 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
cmd->request_desc->SCSIIO.RequestFlags =
(MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
- pRAID_Context->timeoutValue = cpu_to_le16(os_timeout_value);
- pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
+ pRAID_Context->timeout_value = cpu_to_le16(os_timeout_value);
+ pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
} else {
/* system pd Fast Path */
io_request->Function = MPI2_FUNCTION_SCSI_IO_REQUEST;
timeout_limit = (scmd->device->type == TYPE_DISK) ?
255 : 0xFFFF;
- pRAID_Context->timeoutValue =
+ pRAID_Context->timeout_value =
cpu_to_le16((os_timeout_value > timeout_limit) ?
timeout_limit : os_timeout_value);
if (fusion->adapter_type == INVADER_SERIES)
@@ -2232,8 +2328,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
io_request->Control = 0;
io_request->EEDPBlockSize = 0;
io_request->ChainOffset = 0;
- io_request->RaidContext.raid_context.RAIDFlags = 0;
- io_request->RaidContext.raid_context.Type = 0;
+ io_request->RaidContext.raid_context.raid_flags = 0;
+ io_request->RaidContext.raid_context.type = 0;
io_request->RaidContext.raid_context.nseg = 0;
memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
@@ -2278,11 +2374,16 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
return 1;
}
- /* numSGE store lower 8 bit of sge_count.
- * numSGEExt store higher 8 bit of sge_count
- */
- io_request->RaidContext.raid_context.numSGE = sge_count;
- io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >> 8);
+ if (instance->is_ventura)
+ io_request->RaidContext.raid_context_g35.num_sge = sge_count;
+ else {
+ /* numSGE store lower 8 bit of sge_count.
+ * numSGEExt store higher 8 bit of sge_count
+ */
+ io_request->RaidContext.raid_context.num_sge = sge_count;
+ io_request->RaidContext.raid_context.num_sge_ext =
+ (u8)(sge_count >> 8);
+ }
io_request->SGLFlags = cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
@@ -2331,6 +2432,10 @@ void megasas_fpio_to_ldio(struct megasas_instance *instance,
struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
{
struct fusion_context *fusion;
+ union RAID_CONTEXT_UNION *praid_context;
+ struct MR_LD_RAID *raid;
+ struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
+ u32 device_id, ld;
fusion = instance->ctrl_context;
cmd->request_desc->SCSIIO.RequestFlags =
@@ -2354,6 +2459,35 @@ void megasas_fpio_to_ldio(struct megasas_instance *instance,
cmd->io_request->Control = 0;
cmd->io_request->EEDPBlockSize = 0;
cmd->is_raid_1_fp_write = 0;
+
+ device_id = MEGASAS_DEV_INDEX(cmd->scmd);
+ local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
+ ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
+ raid = MR_LdRaidGet(ld, local_map_ptr);
+ praid_context = &cmd->io_request->RaidContext;
+ if (cmd->scmd->sc_data_direction == PCI_DMA_FROMDEVICE) {
+ if ((raid->cpuAffinity.ldRead.cpu0)
+ && (raid->cpuAffinity.ldRead.cpu1))
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_FCFS;
+ else if (raid->cpuAffinity.ldRead.cpu1)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_1;
+ else
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+ } else {
+ if ((raid->cpuAffinity.ldWrite.cpu0)
+ && (raid->cpuAffinity.ldWrite.cpu1))
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_FCFS;
+ else if (raid->cpuAffinity.ldWrite.cpu1)
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_1;
+ else
+ praid_context->raid_context_g35.routing_flags.bits.cpu_sel
+ = MR_RAID_CTX_CPUSEL_0;
+ }
}
/*megasas_prepate_secondRaid1_IO
* It prepares the raid 1 second IO
@@ -2491,6 +2625,7 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
* corresponds to single R1/10 LD are always same
*
*/
+
/* driver side count always should be less than max_fw_cmds
* to get new command
*/
@@ -2588,7 +2723,7 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
scmd_local = cmd_fusion->scmd;
status = scsi_io_req->RaidContext.raid_context.status;
- extStatus = scsi_io_req->RaidContext.raid_context.exStatus;
+ extStatus = scsi_io_req->RaidContext.raid_context.ex_status;
sense = cmd_fusion->sense;
data_length = scsi_io_req->DataLength;
@@ -2656,13 +2791,13 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
status =
r1_cmd->io_request->RaidContext.raid_context.status;
extStatus =
- r1_cmd->io_request->RaidContext.raid_context.exStatus;
+ r1_cmd->io_request->RaidContext.raid_context.ex_status;
data_length =
r1_cmd->io_request->DataLength;
sense = r1_cmd->sense;
}
r1_cmd->io_request->RaidContext.raid_context.status = 0;
- r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
+ r1_cmd->io_request->RaidContext.raid_context.ex_status = 0;
cmd_fusion->is_raid_1_fp_write = 0;
r1_cmd->is_raid_1_fp_write = 0;
r1_cmd->cmd_completed = false;
@@ -2674,7 +2809,7 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
extStatus, data_length, sense);
scsi_io_req->RaidContext.raid_context.status
= 0;
- scsi_io_req->RaidContext.raid_context.exStatus
+ scsi_io_req->RaidContext.raid_context.ex_status
= 0;
megasas_return_cmd_fusion(instance, cmd_fusion);
scsi_dma_unmap(scmd_local);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index 5590c1d..cb42655 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -59,6 +59,8 @@
#define MR_RL_FLAGS_GRANT_DESTINATION_CPU1 0x10
#define MR_RL_FLAGS_GRANT_DESTINATION_CUDA 0x80
#define MR_RL_FLAGS_SEQ_NUM_ENABLE 0x8
+#define MR_RL_WRITE_THROUGH_MODE 0x00
+#define MR_RL_WRITE_BACK_MODE 0x01
/* T10 PI defines */
#define MR_PROT_INFO_TYPE_CONTROLLER 0x8
@@ -81,6 +83,11 @@
enum MR_RAID_FLAGS_IO_SUB_TYPE {
MR_RAID_FLAGS_IO_SUB_TYPE_NONE = 0,
MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD = 1,
+ MR_RAID_FLAGS_IO_SUB_TYPE_RMW_DATA = 2,
+ MR_RAID_FLAGS_IO_SUB_TYPE_RMW_P = 3,
+ MR_RAID_FLAGS_IO_SUB_TYPE_RMW_Q = 4,
+ MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS = 6,
+ MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT = 7
};
/*
@@ -109,29 +116,29 @@ enum MR_FUSION_ADAPTER_TYPE {
struct RAID_CONTEXT {
#if defined(__BIG_ENDIAN_BITFIELD)
- u8 nseg:4;
- u8 Type:4;
+ u8 nseg:4;
+ u8 type:4;
#else
- u8 Type:4;
- u8 nseg:4;
+ u8 type:4;
+ u8 nseg:4;
#endif
- u8 resvd0;
- __le16 timeoutValue;
- u8 regLockFlags;
- u8 resvd1;
- __le16 VirtualDiskTgtId;
- __le64 regLockRowLBA;
- __le32 regLockLength;
- __le16 nextLMId;
- u8 exStatus;
- u8 status;
- u8 RAIDFlags;
- u8 numSGE;
- __le16 configSeqNum;
- u8 spanArm;
- u8 priority;
- u8 numSGEExt;
- u8 resvd2;
+ u8 resvd0;
+ __le16 timeout_value;
+ u8 reg_lock_flags;
+ u8 resvd1;
+ __le16 virtual_disk_tgt_id;
+ __le64 reg_lock_row_lba;
+ __le32 reg_lock_length;
+ __le16 next_lmid;
+ u8 ex_status;
+ u8 status;
+ u8 raid_flags;
+ u8 num_sge;
+ __le16 config_seq_num;
+ u8 span_arm;
+ u8 priority;
+ u8 num_sge_ext;
+ u8 resvd2;
};
/*
@@ -187,7 +194,7 @@ struct RAID_CONTEXT_G35 {
} smid;
u8 ex_status; /* 0x16 : OUT */
u8 status; /* 0x17 status */
- u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
+ u8 raid_flags; /* 0x18 resvd[7:6], ioSubType[5:4],
* resvd[3:1], preferredCpu[0]
*/
u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
@@ -672,14 +679,17 @@ struct MPI2_IOC_INIT_REQUEST {
#define MAX_RAIDMAP_ROW_SIZE (MAX_ROW_SIZE)
#define MAX_LOGICAL_DRIVES 64
#define MAX_LOGICAL_DRIVES_EXT 256
+#define MAX_LOGICAL_DRIVES_DYN 512
#define MAX_RAIDMAP_LOGICAL_DRIVES (MAX_LOGICAL_DRIVES)
#define MAX_RAIDMAP_VIEWS (MAX_LOGICAL_DRIVES)
#define MAX_ARRAYS 128
#define MAX_RAIDMAP_ARRAYS (MAX_ARRAYS)
#define MAX_ARRAYS_EXT 256
#define MAX_API_ARRAYS_EXT (MAX_ARRAYS_EXT)
+#define MAX_API_ARRAYS_DYN 512
#define MAX_PHYSICAL_DEVICES 256
#define MAX_RAIDMAP_PHYSICAL_DEVICES (MAX_PHYSICAL_DEVICES)
+#define MAX_RAIDMAP_PHYSICAL_DEVICES_DYN 512
#define MR_DCMD_LD_MAP_GET_INFO 0x0300e101
#define MR_DCMD_SYSTEM_PD_MAP_GET_INFO 0x0200e102
#define MR_DCMD_CTRL_SHARED_HOST_MEM_ALLOC 0x010e8485 /* SR-IOV HB alloc*/
@@ -726,12 +736,56 @@ struct MR_SPAN_BLOCK_INFO {
struct MR_SPAN_INFO block_span_info;
};
+#define MR_RAID_CTX_CPUSEL_0 0
+#define MR_RAID_CTX_CPUSEL_1 1
+#define MR_RAID_CTX_CPUSEL_2 2
+#define MR_RAID_CTX_CPUSEL_3 3
+#define MR_RAID_CTX_CPUSEL_FCFS 0xF
+
+struct MR_CPU_AFFINITY_MASK {
+ union {
+ struct {
+#ifndef MFI_BIG_ENDIAN
+ u8 hw_path:1;
+ u8 cpu0:1;
+ u8 cpu1:1;
+ u8 cpu2:1;
+ u8 cpu3:1;
+ u8 reserved:3;
+#else
+ u8 reserved:3;
+ u8 cpu3:1;
+ u8 cpu2:1;
+ u8 cpu1:1;
+ u8 cpu0:1;
+ u8 hw_path:1;
+#endif
+ };
+ u8 core_mask;
+ };
+};
+
+struct MR_IO_AFFINITY {
+ union {
+ struct {
+ struct MR_CPU_AFFINITY_MASK pdRead;
+ struct MR_CPU_AFFINITY_MASK pdWrite;
+ struct MR_CPU_AFFINITY_MASK ldRead;
+ struct MR_CPU_AFFINITY_MASK ldWrite;
+ };
+ u32 word;
+ };
+ u8 maxCores; /* Total cores + HW Path in ROC */
+ u8 reserved[3];
+};
+
struct MR_LD_RAID {
struct {
#if defined(__BIG_ENDIAN_BITFIELD)
- u32 reserved4:3;
- u32 fp_cache_bypass_capable:1;
- u32 fp_rmw_capable:1;
+ u32 reserved4:2;
+ u32 fp_cache_bypass_capable:1;
+ u32 fp_rmw_capable:1;
+ u32 disable_coalescing:1;
u32 fpBypassRegionLock:1;
u32 tmCapable:1;
u32 fpNonRWCapable:1;
@@ -759,9 +813,10 @@ struct MR_LD_RAID {
u32 fpNonRWCapable:1;
u32 tmCapable:1;
u32 fpBypassRegionLock:1;
- u32 fp_rmw_capable:1;
- u32 fp_cache_bypass_capable:1;
- u32 reserved4:3;
+ u32 disable_coalescing:1;
+ u32 fp_rmw_capable:1;
+ u32 fp_cache_bypass_capable:1;
+ u32 reserved4:2;
#endif
} capability;
__le32 reserved6;
@@ -788,7 +843,36 @@ struct MR_LD_RAID {
u8 LUN[8]; /* 0x24 8 byte LUN field used for SCSI IO's */
u8 fpIoTimeoutForLd;/*0x2C timeout value used by driver in FP IO*/
- u8 reserved3[0x80-0x2D]; /* 0x2D */
+ /* Ox2D This LD accept priority boost of this type */
+ u8 ld_accept_priority_type;
+ u8 reserved2[2]; /* 0x2E - 0x2F */
+ /* 0x30 - 0x33, Logical block size for the LD */
+ u32 logical_block_length;
+ struct {
+#ifndef MFI_BIG_ENDIAN
+ /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
+ u32 ld_pi_exp:4;
+ /* 0x34, LOGICAL BLOCKS PER PHYSICAL
+ * BLOCK EXPONENT from READ CAPACITY 16
+ */
+ u32 ld_logical_block_exp:4;
+ u32 reserved1:24; /* 0x34 */
+#else
+ u32 reserved1:24; /* 0x34 */
+ /* 0x34, LOGICAL BLOCKS PER PHYSICAL
+ * BLOCK EXPONENT from READ CAPACITY 16
+ */
+ u32 ld_logical_block_exp:4;
+ /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
+ u32 ld_pi_exp:4;
+#endif
+ }; /* 0x34 - 0x37 */
+ /* 0x38 - 0x3f, This will determine which
+ * core will process LD IO and PD IO.
+ */
+ struct MR_IO_AFFINITY cpuAffinity;
+ /* Bit definiations are specified by MR_IO_AFFINITY */
+ u8 reserved3[0x80-0x40]; /* 0x40 - 0x7f */
};
struct MR_LD_SPAN_MAP {
@@ -846,6 +930,91 @@ struct MR_LD_TARGET_SYNC {
__le16 seqNum;
};
+/*
+* RAID Map descriptor Types.
+* Each element should uniquely idetify one data structure in the RAID map
+*/
+enum MR_RAID_MAP_DESC_TYPE {
+ /* MR_DEV_HANDLE_INFO data */
+ RAID_MAP_DESC_TYPE_DEVHDL_INFO = 0x0,
+ /* target to Ld num Index map */
+ RAID_MAP_DESC_TYPE_TGTID_INFO = 0x1,
+ /* MR_ARRAY_INFO data */
+ RAID_MAP_DESC_TYPE_ARRAY_INFO = 0x2,
+ /* MR_LD_SPAN_MAP data */
+ RAID_MAP_DESC_TYPE_SPAN_INFO = 0x3,
+ RAID_MAP_DESC_TYPE_COUNT,
+};
+
+/*
+* This table defines the offset, size and num elements of each descriptor
+* type in the RAID Map buffer
+*/
+struct MR_RAID_MAP_DESC_TABLE {
+ /* Raid map descriptor type */
+ u32 raid_map_desc_type;
+ /* Offset into the RAID map buffer where
+ * descriptor data is saved
+ */
+ u32 raid_map_desc_offset;
+ /* total size of the
+ * descriptor buffer
+ */
+ u32 raid_map_desc_buffer_size;
+ /* Number of elements contained in the
+ * descriptor buffer
+ */
+ u32 raid_map_desc_elements;
+};
+
+/*
+* Dynamic Raid Map Structure.
+*/
+struct MR_FW_RAID_MAP_DYNAMIC {
+ u32 raid_map_size; /* total size of RAID Map structure */
+ u32 desc_table_offset;/* Offset of desc table into RAID map*/
+ u32 desc_table_size; /* Total Size of desc table */
+ /* Total Number of elements in the desc table */
+ u32 desc_table_num_elements;
+ u64 reserved1;
+ u32 reserved2[3]; /*future use */
+ /* timeout value used by driver in FP IOs */
+ u8 fp_pd_io_timeout_sec;
+ u8 reserved3[3];
+ /* when this seqNum increments, driver needs to
+ * release RMW buffers asap
+ */
+ u32 rmw_fp_seq_num;
+ u16 ld_count; /* count of lds. */
+ u16 ar_count; /* count of arrays */
+ u16 span_count; /* count of spans */
+ u16 reserved4[3];
+/*
+* The below structure of pointers is only to be used by the driver.
+* This is added in the ,API to reduce the amount of code changes
+* needed in the driver to support dynamic RAID map Firmware should
+* not update these pointers while preparing the raid map
+*/
+ union {
+ struct {
+ struct MR_DEV_HANDLE_INFO *dev_hndl_info;
+ u16 *ld_tgt_id_to_ld;
+ struct MR_ARRAY_INFO *ar_map_info;
+ struct MR_LD_SPAN_MAP *ld_span_map;
+ };
+ u64 ptr_structure_size[RAID_MAP_DESC_TYPE_COUNT];
+ };
+/*
+* RAID Map descriptor table defines the layout of data in the RAID Map.
+* The size of the descriptor table itself could change.
+*/
+ /* Variable Size descriptor Table. */
+ struct MR_RAID_MAP_DESC_TABLE
+ raid_map_desc_table[RAID_MAP_DESC_TYPE_COUNT];
+ /* Variable Size buffer containing all data */
+ u32 raid_map_desc_data[1];
+}; /* Dynamicaly sized RAID MAp structure */
+
#define IEEE_SGE_FLAGS_ADDR_MASK (0x03)
#define IEEE_SGE_FLAGS_SYSTEM_ADDR (0x00)
#define IEEE_SGE_FLAGS_IOCDDR_ADDR (0x01)
@@ -955,9 +1124,10 @@ struct MR_DRV_RAID_MAP {
__le16 spanCount;
__le16 reserve3;
- struct MR_DEV_HANDLE_INFO devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES];
- u8 ldTgtIdToLd[MAX_LOGICAL_DRIVES_EXT];
- struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_EXT];
+ struct MR_DEV_HANDLE_INFO
+ devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES_DYN];
+ u16 ldTgtIdToLd[MAX_LOGICAL_DRIVES_DYN];
+ struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_DYN];
struct MR_LD_SPAN_MAP ldSpanMap[1];
};
@@ -969,7 +1139,7 @@ struct MR_DRV_RAID_MAP {
struct MR_DRV_RAID_MAP_ALL {
struct MR_DRV_RAID_MAP raidMap;
- struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_EXT - 1];
+ struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_DYN - 1];
} __packed;
@@ -1088,7 +1258,7 @@ struct fusion_context {
u8 chain_offset_io_request;
u8 chain_offset_mfi_pthru;
- struct MR_FW_RAID_MAP_ALL *ld_map[2];
+ struct MR_FW_RAID_MAP_DYNAMIC *ld_map[2];
dma_addr_t ld_map_phys[2];
/*Non dma-able memory. Driver local copy.*/
@@ -1096,6 +1266,8 @@ struct fusion_context {
u32 max_map_sz;
u32 current_map_sz;
+ u32 old_map_sz;
+ u32 new_map_sz;
u32 drv_map_sz;
u32 drv_map_pages;
struct MR_PD_CFG_SEQ_NUM_SYNC *pd_seq_sync[JBOD_MAPS_COUNT];
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
2016-12-06 23:00 ` [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
@ 2016-12-09 12:55 ` Tomas Henzl
2016-12-14 21:49 ` Sasikumar PC
2016-12-20 1:51 ` Sasikumar PC
0 siblings, 2 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-09 12:55 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to have different
> sizes for different number of supported VDs.
>
> This patch is depending on patch 5
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 7 +
> drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++++--
> drivers/scsi/megaraid/megaraid_sas_fp.c | 303 ++++++++++++++++++++++++----
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 223 ++++++++++++++++----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 240 ++++++++++++++++++----
> 5 files changed, 699 insertions(+), 135 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index f4d6a94..3e087ab 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -1434,6 +1434,12 @@ enum FW_BOOT_CONTEXT {
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
> #define MR_MAX_MSIX_REG_ARRAY 16
> #define MR_RDPQ_MODE_OFFSET 0X00800000
> +
> +#define MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT 16
> +#define MR_MAX_RAID_MAP_SIZE_MASK 0x1FF
> +#define MR_MIN_MAP_SIZE 0x10000
> +/* 64k */
> +
> #define MR_CAN_HANDLE_SYNC_CACHE_OFFSET 0X01000000
>
> /*
> @@ -2152,6 +2158,7 @@ struct megasas_instance {
> bool fw_sync_cache_support;
> bool is_ventura;
> bool msix_combined;
> + u16 max_raid_mapsize;
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index c52f7be..3f06b57 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -4424,8 +4424,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
> static void megasas_update_ext_vd_details(struct megasas_instance *instance)
> {
> struct fusion_context *fusion;
> - u32 old_map_sz;
> - u32 new_map_sz;
> + u32 ventura_map_sz = 0;
>
> fusion = instance->ctrl_context;
> /* For MFI based controllers return dummy success */
> @@ -4455,21 +4454,39 @@ static void megasas_update_ext_vd_details(struct megasas_instance *instance)
> instance->supportmax256vd ? "Extended VD(240 VD)firmware" :
> "Legacy(64 VD) firmware");
>
> - old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
> - (sizeof(struct MR_LD_SPAN_MAP) *
> - (instance->fw_supported_vd_count - 1));
> - new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
> - fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
> - (sizeof(struct MR_LD_SPAN_MAP) *
> - (instance->drv_supported_vd_count - 1));
> -
> - fusion->max_map_sz = max(old_map_sz, new_map_sz);
> + if (instance->max_raid_mapsize) {
> + ventura_map_sz = instance->max_raid_mapsize *
> + MR_MIN_MAP_SIZE; /* 64k */
> + fusion->current_map_sz = ventura_map_sz;
> + fusion->max_map_sz = ventura_map_sz;
> + } else {
> + fusion->old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
> + (sizeof(struct MR_LD_SPAN_MAP) *
> + (instance->fw_supported_vd_count - 1));
> + fusion->new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>
> + fusion->max_map_sz =
> + max(fusion->old_map_sz, fusion->new_map_sz);
>
> - if (instance->supportmax256vd)
> - fusion->current_map_sz = new_map_sz;
> - else
> - fusion->current_map_sz = old_map_sz;
> + if (instance->supportmax256vd)
> + fusion->current_map_sz = fusion->new_map_sz;
> + else
> + fusion->current_map_sz = fusion->old_map_sz;
> + }
> + /* irrespective of FW raid maps, driver raid map is constant */
> + fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP_ALL);
> +#if VD_EXT_DEBUG
> + dev_info(&instance->pdev->dev, "instance->max_raid_mapsize 0x%x \n ",
> + instance->max_raid_mapsize);
> + dev_info(&instance->pdev->dev,
> + "new_map_sz = 0x%x, old_map_sz = 0x%x, "
> + "ventura_map_sz = 0x%x, current_map_sz = 0x%x "
> + "fusion->drv_map_sz =0x%x, size of driver raid map 0x%lx\n",
> + fusion->new_map_sz, fusion->old_map_sz,
> + ventura_map_sz, fusion->current_map_sz,
> + fusion->drv_map_sz,
> + sizeof(struct MR_DRV_RAID_MAP_ALL));
> +#endif
> }
>
> /**
> @@ -5010,7 +5027,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
> {
> u32 max_sectors_1;
> u32 max_sectors_2;
> - u32 tmp_sectors, msix_enable, scratch_pad_2;
> + u32 tmp_sectors, msix_enable, scratch_pad_2, scratch_pad_3;
> resource_size_t base_addr;
> struct megasas_register_set __iomem *reg_set;
> struct megasas_ctrl_info *ctrl_info = NULL;
> @@ -5086,7 +5103,17 @@ static int megasas_init_fw(struct megasas_instance *instance)
> goto fail_ready_state;
> }
>
> -
> + if (instance->is_ventura) {
> + scratch_pad_3 =
> + readl(&instance->reg_set->outbound_scratch_pad_3);
> +#if VD_EXT_DEBUG
> + dev_info(&instance->pdev->dev, "scratch_pad3 0x%x\n",
> + scratch_pad_3);
> +#endif
> + instance->max_raid_mapsize = ((scratch_pad_3 >>
> + MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT) &
> + MR_MAX_RAID_MAP_SIZE_MASK);
> + }
>
> /* Check if MSI-X is supported while in ready state */
> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index eb9ff44..a6957a3 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -179,18 +179,204 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
> struct fusion_context *fusion = instance->ctrl_context;
> struct MR_FW_RAID_MAP_ALL *fw_map_old = NULL;
> struct MR_FW_RAID_MAP *pFwRaidMap = NULL;
> - int i;
> + int i, j;
> u16 ld_count;
> + struct MR_FW_RAID_MAP_DYNAMIC *fw_map_dyn;
> + struct MR_FW_RAID_MAP_EXT *fw_map_ext;
> + struct MR_RAID_MAP_DESC_TABLE *desc_table;
>
>
> struct MR_DRV_RAID_MAP_ALL *drv_map =
> fusion->ld_drv_map[(instance->map_id & 1)];
> struct MR_DRV_RAID_MAP *pDrvRaidMap = &drv_map->raidMap;
> + void *raid_map_data = NULL;
> +
> + memset(drv_map, 0, fusion->drv_map_sz);
> + memset(pDrvRaidMap->ldTgtIdToLd,
> + 0xff, (sizeof(u16) * MAX_LOGICAL_DRIVES_DYN));
> +
> + if (instance->max_raid_mapsize) {
> + fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
> +#if VD_EXT_DEBUG
> + dev_dbg(&instance->pdev->dev,
> + " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
> + " descTableSize 0x%x descTableNumElements 0x%x\n",
> + le32_to_cpu(fw_map_dyn->raid_map_size),
> + le32_to_cpu(fw_map_dyn->desc_table_offset),
> + le32_to_cpu(fw_map_dyn->desc_table_size),
> + le32_to_cpu(fw_map_dyn->desc_table_num_elements));
> + dev_dbg(&instance->pdev->dev,
> + "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
> +#endif
> + desc_table =
> + (struct MR_RAID_MAP_DESC_TABLE *)((void *)fw_map_dyn +
> + le32_to_cpu(fw_map_dyn->desc_table_offset));
> + if (desc_table != fw_map_dyn->raid_map_desc_table) {
> + dev_err(&instance->pdev->dev,
> + "offsets of desc table are not matching returning "
> + " FW raid map has been changed: desc %p original %p\n",
> + desc_table, fw_map_dyn->raid_map_desc_table);
> + }
> + ld_count = (u16)le16_to_cpu(fw_map_dyn->ld_count);
> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> + pDrvRaidMap->fpPdIoTimeoutSec = fw_map_dyn->fp_pd_io_timeout_sec;
> + pDrvRaidMap->totalSize = sizeof(struct MR_DRV_RAID_MAP_ALL);
> + /* point to actual data starting point*/
> + raid_map_data = (void *)fw_map_dyn +
> + le32_to_cpu(fw_map_dyn->desc_table_offset) +
> + le32_to_cpu(fw_map_dyn->desc_table_size);
> +
> + for (i = 0; i < le32_to_cpu(fw_map_dyn->desc_table_num_elements); ++i) {
> + if (!desc_table) {
> + dev_err(&instance->pdev->dev,
> + "desc table is null, coming out %p \n", desc_table);
> + return;
> + }
Is it possible that desc_table ever happens to NULL? It looks
like a test something else was intended here ?
Also all the VD_EXT_DEBUG macros make with bad indentation added
make the code hard to read. Please fix it later in a follow up patch.
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "desc table %p \n", desc_table);
> + dev_err(&instance->pdev->dev,
> + "raidmap type %d, raidmapOffset 0x%x, "
> + " raid map number of elements 0%x, raidmapsize 0x%x\n",
> + desc_table->raid_map_desc_type,
> + desc_table->raid_map_desc_offset,
> + desc_table->raid_map_desc_elements,
> + desc_table->raid_map_desc_buffer_size);
> +#endif
> + switch (le32_to_cpu(desc_table->raid_map_desc_type)) {
> + case RAID_MAP_DESC_TYPE_DEVHDL_INFO:
> + fw_map_dyn->dev_hndl_info = (struct MR_DEV_HANDLE_INFO *)
> + (raid_map_data +
> + le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "devHndlInfo address %p\n",
> + fw_map_dyn->dev_hndl_info);
> +#endif
> + memcpy(pDrvRaidMap->devHndlInfo, fw_map_dyn->dev_hndl_info,
> + sizeof(struct MR_DEV_HANDLE_INFO) *
> + le32_to_cpu(desc_table->raid_map_desc_elements));
> + break;
> + case RAID_MAP_DESC_TYPE_TGTID_INFO:
> + fw_map_dyn->ld_tgt_id_to_ld = (u16 *) (raid_map_data +
> + le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "ldTgtIdToLd address %p\n",
> + fw_map_dyn->ld_tgt_id_to_ld);
> +#endif
> + for (j = 0; j < le32_to_cpu(desc_table->raid_map_desc_elements); j++) {
> + pDrvRaidMap->ldTgtIdToLd[j] =
> + fw_map_dyn->ld_tgt_id_to_ld[j];
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + " %d drv ldTgtIdToLd %d\n",
> + j, pDrvRaidMap->ldTgtIdToLd[j]);
> +#endif
> + }
> + break;
> + case RAID_MAP_DESC_TYPE_ARRAY_INFO:
> + fw_map_dyn->ar_map_info = (struct MR_ARRAY_INFO *)
> + (raid_map_data + le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "arMapInfo address %p\n",
> + fw_map_dyn->ar_map_info);
> +#endif
> +
> + memcpy(pDrvRaidMap->arMapInfo,
> + fw_map_dyn->ar_map_info,
> + sizeof(struct MR_ARRAY_INFO) *
> + le32_to_cpu(desc_table->raid_map_desc_elements));
> + break;
> + case RAID_MAP_DESC_TYPE_SPAN_INFO:
> + fw_map_dyn->ld_span_map = (struct MR_LD_SPAN_MAP *)
> + (raid_map_data + le32_to_cpu(desc_table->raid_map_desc_offset));
> + memcpy(pDrvRaidMap->ldSpanMap,
> + fw_map_dyn->ld_span_map,
> + sizeof(struct MR_LD_SPAN_MAP) *
> + le32_to_cpu(desc_table->raid_map_desc_elements));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "ldSpanMap address %p\n",
> + fw_map_dyn->ld_span_map);
> + dev_err(&instance->pdev->dev,
> + "MR_LD_SPAN_MAP size 0x%lx\n", sizeof(struct MR_LD_SPAN_MAP));
> + for (j = 0; j < ld_count; j++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) : fw_map_dyn->ldSpanMap[%d].ldRaid.targetId 0x%x fw_map_dyn->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + j, j, fw_map_dyn->ld_span_map[j].ldRaid.targetId, j,
> + fw_map_dyn->ld_span_map[j].ldRaid.seqNum,
> + (u32)fw_map_dyn->ld_span_map[j].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) :pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + j, j, pDrvRaidMap->ldSpanMap[j].ldRaid.targetId, j,
> + pDrvRaidMap->ldSpanMap[j].ldRaid.seqNum,
> + (u32)pDrvRaidMap->ldSpanMap[j].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p/%p\n",
> + instance->unique_id, drv_map, pDrvRaidMap,
> + &fw_map_dyn->ld_span_map[j].ldRaid,
> + &pDrvRaidMap->ldSpanMap[j].ldRaid);
> + }
> +#endif
> + break;
> + default:
> + dev_err(&instance->pdev->dev,
> + "wrong number of desctableElements %d\n",
> + fw_map_dyn->desc_table_num_elements);
> + }
> + ++desc_table;
> + }
> +
> + } else if (instance->supportmax256vd) {
> + fw_map_ext =
> + (struct MR_FW_RAID_MAP_EXT *) fusion->ld_map[(instance->map_id & 1)];
> + ld_count = (u16)le16_to_cpu(fw_map_ext->ldCount);
> + if (ld_count > MAX_LOGICAL_DRIVES_EXT) {
> + printk(KERN_DEBUG "megaraid_sas: LD count exposed in RAID map in not valid\n");
> + return;
> + }
> +#if VD_EXT_DEBUG
> + for (i = 0; i < ld_count; i++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) :Index 0x%x Target Id 0x%x Seq Num 0x%x Size 0/%llx\n",
> + instance->unique_id,
> + i, fw_map_ext->ldSpanMap[i].ldRaid.targetId,
> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
> + fw_map_ext->ldSpanMap[i].ldRaid.size);
> + }
> +#endif
> +
> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> + pDrvRaidMap->fpPdIoTimeoutSec =
> + fw_map_ext->fpPdIoTimeoutSec;
> + for (i = 0; i < (MAX_LOGICAL_DRIVES_EXT); i++)
> + pDrvRaidMap->ldTgtIdToLd[i] =
> + (u16)fw_map_ext->ldTgtIdToLd[i];
> + memcpy(pDrvRaidMap->ldSpanMap,
> + fw_map_ext->ldSpanMap,
> + sizeof(struct MR_LD_SPAN_MAP) *
> + ld_count);
> +#if VD_EXT_DEBUG
> + for (i = 0; i < ld_count; i++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) : fw_map_ext->ldSpanMap[%d].ldRaid.targetId 0x%x fw_map_ext->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + i, i, fw_map_ext->ldSpanMap[i].ldRaid.targetId, i,
> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
> + (u32)fw_map_ext->ldSpanMap[i].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) : pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x"
> + "pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + i, i, pDrvRaidMap->ldSpanMap[i].ldRaid.targetId, i,
> + pDrvRaidMap->ldSpanMap[i].ldRaid.seqNum,
> + (u32)pDrvRaidMap->ldSpanMap[i].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p %p\n",
> + instance->unique_id, drv_map, pDrvRaidMap,
> + &fw_map_ext->ldSpanMap[i].ldRaid,
> + &pDrvRaidMap->ldSpanMap[i].ldRaid);
> + }
> +#endif
> + memcpy(pDrvRaidMap->arMapInfo, fw_map_ext->arMapInfo,
> + sizeof(struct MR_ARRAY_INFO) * MAX_API_ARRAYS_EXT);
> + memcpy(pDrvRaidMap->devHndlInfo, fw_map_ext->devHndlInfo,
> + sizeof(struct MR_DEV_HANDLE_INFO) *
> + MAX_RAIDMAP_PHYSICAL_DEVICES);
>
> - if (instance->supportmax256vd) {
> - memcpy(fusion->ld_drv_map[instance->map_id & 1],
> - fusion->ld_map[instance->map_id & 1],
> - fusion->current_map_sz);
> /* New Raid map will not set totalSize, so keep expected value
> * for legacy code in ValidateMapInfo
> */
> @@ -213,16 +399,12 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
> }
> #endif
>
> - memset(drv_map, 0, fusion->drv_map_sz);
> pDrvRaidMap->totalSize = pFwRaidMap->totalSize;
> pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> pDrvRaidMap->fpPdIoTimeoutSec = pFwRaidMap->fpPdIoTimeoutSec;
> for (i = 0; i < MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS; i++)
> pDrvRaidMap->ldTgtIdToLd[i] =
> (u8)pFwRaidMap->ldTgtIdToLd[i];
> - for (i = (MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS);
> - i < MAX_LOGICAL_DRIVES_EXT; i++)
> - pDrvRaidMap->ldTgtIdToLd[i] = 0xff;
> for (i = 0; i < ld_count; i++) {
> pDrvRaidMap->ldSpanMap[i] = pFwRaidMap->ldSpanMap[i];
> #if VD_EXT_DEBUG
> @@ -279,7 +461,9 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance)
> lbInfo = fusion->load_balance_info;
> ldSpanInfo = fusion->log_to_span;
>
> - if (instance->supportmax256vd)
> + if (instance->max_raid_mapsize)
> + expected_size = sizeof(struct MR_DRV_RAID_MAP_ALL);
> + else if (instance->supportmax256vd)
> expected_size = sizeof(struct MR_FW_RAID_MAP_EXT);
> else
> expected_size =
> @@ -287,8 +471,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance)
> (sizeof(struct MR_LD_SPAN_MAP) * le16_to_cpu(pDrvRaidMap->ldCount)));
>
> if (le32_to_cpu(pDrvRaidMap->totalSize) != expected_size) {
> - dev_err(&instance->pdev->dev, "map info structure size 0x%x is not matching with ld count\n",
> - (unsigned int) expected_size);
> + dev_err(&instance->pdev->dev, "megasas: map info structure"
> + " size 0x%x is not matching expected size 0x%x\n",
> + le32_to_cpu(pDrvRaidMap->totalSize),
> + (unsigned int) expected_size);
> dev_err(&instance->pdev->dev, "megasas: span map %x, pDrvRaidMap->totalSize : %x\n",
> (unsigned int)sizeof(struct MR_LD_SPAN_MAP),
> le32_to_cpu(pDrvRaidMap->totalSize));
> @@ -787,7 +973,7 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
> ((fusion->adapter_type == INVADER_SERIES) &&
> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
> - pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
> + pRAID_Context->reg_lock_flags = REGION_TYPE_EXCLUSIVE;
> else if (raid->level == 1) {
> physArm = physArm + 1;
> pd = MR_ArPdGet(arRef, physArm, map);
> @@ -797,9 +983,16 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
> }
>
> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span, map)->startBlk);
> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> - physArm;
> - io_info->span_arm = pRAID_Context->spanArm;
> + if (instance->is_ventura) {
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + } else {
> + pRAID_Context->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm = pRAID_Context->span_arm;
> + }
> return retval;
> }
>
> @@ -891,7 +1084,7 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
> ((fusion->adapter_type == INVADER_SERIES) &&
> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
> - pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
> + pRAID_Context->reg_lock_flags = REGION_TYPE_EXCLUSIVE;
> else if (raid->level == 1) {
> /* Get alternate Pd. */
> physArm = physArm + 1;
> @@ -903,9 +1096,16 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
> }
>
> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span, map)->startBlk);
> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> - physArm;
> - io_info->span_arm = pRAID_Context->spanArm;
> + if (instance->is_ventura) {
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + } else {
> + pRAID_Context->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm = pRAID_Context->span_arm;
> + }
> return retval;
> }
>
> @@ -1109,20 +1309,20 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
> regSize += stripSize;
> }
>
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16(raid->fpIoTimeoutForLd ?
> raid->fpIoTimeoutForLd :
> map->raidMap.fpPdIoTimeoutSec);
> if (fusion->adapter_type == INVADER_SERIES)
> - pRAID_Context->regLockFlags = (isRead) ?
> + pRAID_Context->reg_lock_flags = (isRead) ?
> raid->regTypeReqOnRead : raid->regTypeReqOnWrite;
> - else
> - pRAID_Context->regLockFlags = (isRead) ?
> + else if (!instance->is_ventura)
> + pRAID_Context->reg_lock_flags = (isRead) ?
> REGION_TYPE_SHARED_READ : raid->regTypeReqOnWrite;
> - pRAID_Context->VirtualDiskTgtId = raid->targetId;
> - pRAID_Context->regLockRowLBA = cpu_to_le64(regStart);
> - pRAID_Context->regLockLength = cpu_to_le32(regSize);
> - pRAID_Context->configSeqNum = raid->seqNum;
> + pRAID_Context->virtual_disk_tgt_id = raid->targetId;
> + pRAID_Context->reg_lock_row_lba = cpu_to_le64(regStart);
> + pRAID_Context->reg_lock_length = cpu_to_le32(regSize);
> + pRAID_Context->config_seq_num = raid->seqNum;
> /* save pointer to raid->LUN array */
> *raidLUN = raid->LUN;
>
> @@ -1140,6 +1340,14 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
> /* If IO on an invalid Pd, then FP is not possible.*/
> if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
> io_info->fpOkForIo = FALSE;
> + /* if FP possible, set the SLUD bit in
> + * regLockFlags for ventura
> + */
> + else if ((instance->is_ventura) && !isRead &&
> + (raid->writeMode == MR_RL_WRITE_BACK_MODE) &&
> + raid->capability.fp_cache_bypass_capable)
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->routing_flags.bits.sld
> + = 1;
> /* set raid 1/10 fast path write capable bit in io_info */
> if (io_info->fpOkForIo &&
> (io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
> @@ -1319,6 +1527,7 @@ u8 megasas_get_best_arm_pd(struct megasas_instance *instance,
> struct fusion_context *fusion;
> struct MR_LD_RAID *raid;
> struct MR_DRV_RAID_MAP_ALL *drv_map;
> + u16 pd1_dev_handle;
> u16 pend0, pend1, ld;
> u64 diff0, diff1;
> u8 bestArm, pd0, pd1, span, arm;
> @@ -1344,23 +1553,37 @@ u8 megasas_get_best_arm_pd(struct megasas_instance *instance,
> pd1 = MR_ArPdGet(arRef, (arm + 1) >= span_row_size ?
> (arm + 1 - span_row_size) : arm + 1, drv_map);
>
> - /* get the pending cmds for the data and mirror arms */
> - pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
> - pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
> + /* Get PD1 Dev Handle */
>
> - /* Determine the disk whose head is nearer to the req. block */
> - diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
> - diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
> - bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
> + pd1_dev_handle = MR_PdDevHandleGet(pd1, drv_map);
>
> - if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
> + if (pd1_dev_handle == MR_PD_INVALID) {
> + bestArm = arm;
> + } else {
> + /* get the pending cmds for the data and mirror arms */
> + pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
> + pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
> +
> + /* Determine the disk whose head is nearer to the req. block */
> + diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
> + diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
> + /*bestArm = diff0<=diff1 ? arm : arm ^ 1;*/
> + bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
The above comment is useless and the parentheses not needed,
again please clean it up in a next series.
tomash
> +
> + /* Make balance count from 16 to 4 to
> + * keep driver in sync with Firmware
> + */
> + if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
> (bestArm != arm && pend1 > pend0 + lb_pending_cmds))
> - bestArm ^= 1;
> + bestArm ^= 1;
> +
> + /* Update the last accessed block on the correct pd */
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
> + io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
> + }
>
> - /* Update the last accessed block on the correct pd */
> - io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
> lbInfo->last_accessed_block[io_info->pd_after_lb] = block + count - 1;
> - io_info->span_arm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
> #if SPAN_DEBUG
> if (arm != bestArm)
> dev_dbg(&instance->pdev->dev, "LSI Debug R1 Load balance "
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 2fcd5cd..58f86aa 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -1834,7 +1834,7 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> struct megasas_cmd_fusion *cmd)
> {
> u8 fp_possible;
> - u32 start_lba_lo, start_lba_hi, device_id, datalength = 0;
> + u32 start_lba_lo, start_lba_hi, device_id, datalength = 0, ld;
> struct MPI2_RAID_SCSI_IO_REQUEST *io_request;
> union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
> struct IO_REQUEST_INFO io_info;
> @@ -1842,16 +1842,18 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> u8 *raidLUN;
> unsigned long spinlock_flags;
> + union RAID_CONTEXT_UNION *praid_context;
> + struct MR_LD_RAID *raid;
>
> device_id = MEGASAS_DEV_INDEX(scp);
>
> fusion = instance->ctrl_context;
>
> io_request = cmd->io_request;
> - io_request->RaidContext.raid_context.VirtualDiskTgtId =
> + io_request->RaidContext.raid_context.virtual_disk_tgt_id =
> cpu_to_le16(device_id);
> io_request->RaidContext.raid_context.status = 0;
> - io_request->RaidContext.raid_context.exStatus = 0;
> + io_request->RaidContext.raid_context.ex_status = 0;
>
> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION *)cmd->request_desc;
>
> @@ -1920,10 +1922,12 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> io_info.isRead = 1;
>
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
> + raid = MR_LdRaidGet(ld, local_map_ptr);
>
> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
> instance->fw_supported_vd_count) || (!fusion->fast_path_io)) {
> - io_request->RaidContext.raid_context.regLockFlags = 0;
> + io_request->RaidContext.raid_context.reg_lock_flags = 0;
> fp_possible = 0;
> } else {
> if (MR_BuildRaidContext(instance, &io_info,
> @@ -1950,6 +1954,8 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> fp_possible = false;
> }
>
> + praid_context = &io_request->RaidContext;
> +
> if (fp_possible) {
> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info, scp,
> local_map_ptr, start_lba_lo);
> @@ -1958,18 +1964,26 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> - if (io_request->RaidContext.raid_context.regLockFlags ==
> + if (io_request->RaidContext.raid_context.reg_lock_flags ==
> REGION_TYPE_UNUSED)
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.raid_context.Type
> + io_request->RaidContext.raid_context.type
> = MPI2_TYPE_CUDA;
> io_request->RaidContext.raid_context.nseg = 0x1;
> io_request->IoFlags |= cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> - io_request->RaidContext.raid_context.regLockFlags |=
> + io_request->RaidContext.raid_context.reg_lock_flags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> + } else if (instance->is_ventura) {
> + io_request->RaidContext.raid_context_g35.type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context_g35.nseg = 0x1;
> + io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + io_request->IoFlags |=
> + cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> }
> if ((fusion->load_balance_info[device_id].loadBalanceFlag) &&
> (io_info.isRead)) {
> @@ -1979,6 +1993,13 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> &io_info);
> scp->SCp.Status |= MEGASAS_LOAD_BALANCE_FLAG;
> cmd->pd_r1_lb = io_info.pd_after_lb;
> + if (instance->is_ventura)
> + io_request->RaidContext.raid_context_g35.span_arm
> + = io_info.span_arm;
> + else
> + io_request->RaidContext.raid_context.span_arm
> + = io_info.span_arm;
> +
> } else
> scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
>
> @@ -1997,28 +2018,98 @@ static void megasas_stream_detect(struct megasas_instance *instance,
> io_request->DevHandle = io_info.devHandle;
> /* populate the LUN field */
> memcpy(io_request->LUN, raidLUN, 8);
> + if (instance->is_ventura) {
> + if (io_info.isRead) {
> + if ((raid->cpuAffinity.pdRead.cpu0) &&
> + (raid->cpuAffinity.pdRead.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.pdRead.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.pdWrite.cpu0)
> + && (raid->cpuAffinity.pdWrite.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.pdWrite.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + if (praid_context->raid_context_g35.routing_flags.bits.sld) {
> + praid_context->raid_context_g35.raid_flags
> + = (MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
> + << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
> + }
> + }
> + }
> } else {
> - io_request->RaidContext.raid_context.timeoutValue =
> + io_request->RaidContext.raid_context.timeout_value =
> cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> if (io_info.do_fp_rlbypass ||
> - (io_request->RaidContext.raid_context.regLockFlags
> + (io_request->RaidContext.raid_context.reg_lock_flags
> == REGION_TYPE_UNUSED))
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.raid_context.Type
> + io_request->RaidContext.raid_context.type
> = MPI2_TYPE_CUDA;
> - io_request->RaidContext.raid_context.regLockFlags |=
> + io_request->RaidContext.raid_context.reg_lock_flags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> io_request->RaidContext.raid_context.nseg = 0x1;
> + } else if (instance->is_ventura) {
> + io_request->RaidContext.raid_context_g35.type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + io_request->RaidContext.raid_context_g35.nseg = 0x1;
> }
> io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> +
> + if (instance->is_ventura) {
> + if (io_info.isRead) {
> + if ((raid->cpuAffinity.ldRead.cpu0)
> + && (raid->cpuAffinity.ldRead.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldRead.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.ldWrite.cpu0) &&
> + (raid->cpuAffinity.ldWrite.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldWrite.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> +
> + if (io_request->RaidContext.raid_context_g35.stream_detected
> + && (raid->level == 5)
> + && (raid->writeMode == MR_RL_WRITE_THROUGH_MODE)) {
> + if (praid_context->raid_context_g35.routing_flags.bits.cpu_sel == MR_RAID_CTX_CPUSEL_FCFS)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + }
> + }
> + }
> } /* Not FP */
> }
>
> @@ -2053,9 +2144,9 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> /* get RAID_Context pointer */
> pRAID_Context = &io_request->RaidContext.raid_context;
> /* Check with FW team */
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->regLockRowLBA = 0;
> - pRAID_Context->regLockLength = 0;
> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
> + pRAID_Context->reg_lock_row_lba = 0;
> + pRAID_Context->reg_lock_length = 0;
>
> if (fusion->fast_path_io && (
> device_id < instance->fw_supported_vd_count)) {
> @@ -2074,7 +2165,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> io_request->Function = MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> io_request->LUN[1] = scmd->device->lun;
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16 (scmd->request->timeout / HZ);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
> @@ -2082,9 +2173,10 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> } else {
>
> /* set RAID context values */
> - pRAID_Context->configSeqNum = raid->seqNum;
> - pRAID_Context->regLockFlags = REGION_TYPE_SHARED_READ;
> - pRAID_Context->timeoutValue = cpu_to_le16(raid->fpIoTimeoutForLd);
> + pRAID_Context->config_seq_num = raid->seqNum;
> + if (!instance->is_ventura)
> + pRAID_Context->reg_lock_flags = REGION_TYPE_SHARED_READ;
> + pRAID_Context->timeout_value = cpu_to_le16(raid->fpIoTimeoutForLd);
>
> /* get the DevHandle for the PD (since this is
> fpNonRWCapable, this is a single disk RAID0) */
> @@ -2139,12 +2231,12 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> io_request = cmd->io_request;
> /* get RAID_Context pointer */
> pRAID_Context = &io_request->RaidContext.raid_context;
> - pRAID_Context->regLockFlags = 0;
> - pRAID_Context->regLockRowLBA = 0;
> - pRAID_Context->regLockLength = 0;
> + pRAID_Context->reg_lock_flags = 0;
> + pRAID_Context->reg_lock_row_lba = 0;
> + pRAID_Context->reg_lock_length = 0;
> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
> io_request->LUN[1] = scmd->device->lun;
> - pRAID_Context->RAIDFlags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
> + pRAID_Context->raid_flags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
> << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
>
> /* If FW supports PD sequence number */
> @@ -2153,24 +2245,28 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> /* TgtId must be incremented by 255 as jbod seq number is index
> * below raid map
> */
> - pRAID_Context->VirtualDiskTgtId =
> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id + (MAX_PHYSICAL_DEVICES - 1));
> - pRAID_Context->configSeqNum = pd_sync->seq[pd_index].seqNum;
> + pRAID_Context->config_seq_num = pd_sync->seq[pd_index].seqNum;
> io_request->DevHandle = pd_sync->seq[pd_index].devHandle;
> - pRAID_Context->regLockFlags |=
> + if (instance->is_ventura)
> + io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + else
> + pRAID_Context->reg_lock_flags |=
> (MR_RL_FLAGS_SEQ_NUM_ENABLE|MR_RL_FLAGS_GRANT_DESTINATION_CUDA);
> - pRAID_Context->Type = MPI2_TYPE_CUDA;
> + pRAID_Context->type = MPI2_TYPE_CUDA;
> pRAID_Context->nseg = 0x1;
> } else if (fusion->fast_path_io) {
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->configSeqNum = 0;
> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
> + pRAID_Context->config_seq_num = 0;
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> io_request->DevHandle =
> local_map_ptr->raidMap.devHndlInfo[device_id].curDevHdl;
> } else {
> /* Want to send all IO via FW path */
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->configSeqNum = 0;
> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
> + pRAID_Context->config_seq_num = 0;
> io_request->DevHandle = cpu_to_le16(0xFFFF);
> }
>
> @@ -2186,14 +2282,14 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> cmd->request_desc->SCSIIO.RequestFlags =
> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - pRAID_Context->timeoutValue = cpu_to_le16(os_timeout_value);
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> + pRAID_Context->timeout_value = cpu_to_le16(os_timeout_value);
> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
> } else {
> /* system pd Fast Path */
> io_request->Function = MPI2_FUNCTION_SCSI_IO_REQUEST;
> timeout_limit = (scmd->device->type == TYPE_DISK) ?
> 255 : 0xFFFF;
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16((os_timeout_value > timeout_limit) ?
> timeout_limit : os_timeout_value);
> if (fusion->adapter_type == INVADER_SERIES)
> @@ -2232,8 +2328,8 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> io_request->Control = 0;
> io_request->EEDPBlockSize = 0;
> io_request->ChainOffset = 0;
> - io_request->RaidContext.raid_context.RAIDFlags = 0;
> - io_request->RaidContext.raid_context.Type = 0;
> + io_request->RaidContext.raid_context.raid_flags = 0;
> + io_request->RaidContext.raid_context.type = 0;
> io_request->RaidContext.raid_context.nseg = 0;
>
> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
> @@ -2278,11 +2374,16 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> return 1;
> }
>
> - /* numSGE store lower 8 bit of sge_count.
> - * numSGEExt store higher 8 bit of sge_count
> - */
> - io_request->RaidContext.raid_context.numSGE = sge_count;
> - io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >> 8);
> + if (instance->is_ventura)
> + io_request->RaidContext.raid_context_g35.num_sge = sge_count;
> + else {
> + /* numSGE store lower 8 bit of sge_count.
> + * numSGEExt store higher 8 bit of sge_count
> + */
> + io_request->RaidContext.raid_context.num_sge = sge_count;
> + io_request->RaidContext.raid_context.num_sge_ext =
> + (u8)(sge_count >> 8);
> + }
>
> io_request->SGLFlags = cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>
> @@ -2331,6 +2432,10 @@ void megasas_fpio_to_ldio(struct megasas_instance *instance,
> struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
> {
> struct fusion_context *fusion;
> + union RAID_CONTEXT_UNION *praid_context;
> + struct MR_LD_RAID *raid;
> + struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> + u32 device_id, ld;
> fusion = instance->ctrl_context;
>
> cmd->request_desc->SCSIIO.RequestFlags =
> @@ -2354,6 +2459,35 @@ void megasas_fpio_to_ldio(struct megasas_instance *instance,
> cmd->io_request->Control = 0;
> cmd->io_request->EEDPBlockSize = 0;
> cmd->is_raid_1_fp_write = 0;
> +
> + device_id = MEGASAS_DEV_INDEX(cmd->scmd);
> + local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
> + raid = MR_LdRaidGet(ld, local_map_ptr);
> + praid_context = &cmd->io_request->RaidContext;
> + if (cmd->scmd->sc_data_direction == PCI_DMA_FROMDEVICE) {
> + if ((raid->cpuAffinity.ldRead.cpu0)
> + && (raid->cpuAffinity.ldRead.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldRead.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.ldWrite.cpu0)
> + && (raid->cpuAffinity.ldWrite.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldWrite.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + }
> }
> /*megasas_prepate_secondRaid1_IO
> * It prepares the raid 1 second IO
> @@ -2491,6 +2625,7 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
> * corresponds to single R1/10 LD are always same
> *
> */
> +
> /* driver side count always should be less than max_fw_cmds
> * to get new command
> */
> @@ -2588,7 +2723,7 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
>
> scmd_local = cmd_fusion->scmd;
> status = scsi_io_req->RaidContext.raid_context.status;
> - extStatus = scsi_io_req->RaidContext.raid_context.exStatus;
> + extStatus = scsi_io_req->RaidContext.raid_context.ex_status;
> sense = cmd_fusion->sense;
> data_length = scsi_io_req->DataLength;
>
> @@ -2656,13 +2791,13 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
> status =
> r1_cmd->io_request->RaidContext.raid_context.status;
> extStatus =
> - r1_cmd->io_request->RaidContext.raid_context.exStatus;
> + r1_cmd->io_request->RaidContext.raid_context.ex_status;
> data_length =
> r1_cmd->io_request->DataLength;
> sense = r1_cmd->sense;
> }
> r1_cmd->io_request->RaidContext.raid_context.status = 0;
> - r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
> + r1_cmd->io_request->RaidContext.raid_context.ex_status = 0;
> cmd_fusion->is_raid_1_fp_write = 0;
> r1_cmd->is_raid_1_fp_write = 0;
> r1_cmd->cmd_completed = false;
> @@ -2674,7 +2809,7 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
> extStatus, data_length, sense);
> scsi_io_req->RaidContext.raid_context.status
> = 0;
> - scsi_io_req->RaidContext.raid_context.exStatus
> + scsi_io_req->RaidContext.raid_context.ex_status
> = 0;
> megasas_return_cmd_fusion(instance, cmd_fusion);
> scsi_dma_unmap(scmd_local);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index 5590c1d..cb42655 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -59,6 +59,8 @@
> #define MR_RL_FLAGS_GRANT_DESTINATION_CPU1 0x10
> #define MR_RL_FLAGS_GRANT_DESTINATION_CUDA 0x80
> #define MR_RL_FLAGS_SEQ_NUM_ENABLE 0x8
> +#define MR_RL_WRITE_THROUGH_MODE 0x00
> +#define MR_RL_WRITE_BACK_MODE 0x01
>
> /* T10 PI defines */
> #define MR_PROT_INFO_TYPE_CONTROLLER 0x8
> @@ -81,6 +83,11 @@
> enum MR_RAID_FLAGS_IO_SUB_TYPE {
> MR_RAID_FLAGS_IO_SUB_TYPE_NONE = 0,
> MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD = 1,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_DATA = 2,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_P = 3,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_Q = 4,
> + MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS = 6,
> + MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT = 7
> };
>
> /*
> @@ -109,29 +116,29 @@ enum MR_FUSION_ADAPTER_TYPE {
>
> struct RAID_CONTEXT {
> #if defined(__BIG_ENDIAN_BITFIELD)
> - u8 nseg:4;
> - u8 Type:4;
> + u8 nseg:4;
> + u8 type:4;
> #else
> - u8 Type:4;
> - u8 nseg:4;
> + u8 type:4;
> + u8 nseg:4;
> #endif
> - u8 resvd0;
> - __le16 timeoutValue;
> - u8 regLockFlags;
> - u8 resvd1;
> - __le16 VirtualDiskTgtId;
> - __le64 regLockRowLBA;
> - __le32 regLockLength;
> - __le16 nextLMId;
> - u8 exStatus;
> - u8 status;
> - u8 RAIDFlags;
> - u8 numSGE;
> - __le16 configSeqNum;
> - u8 spanArm;
> - u8 priority;
> - u8 numSGEExt;
> - u8 resvd2;
> + u8 resvd0;
> + __le16 timeout_value;
> + u8 reg_lock_flags;
> + u8 resvd1;
> + __le16 virtual_disk_tgt_id;
> + __le64 reg_lock_row_lba;
> + __le32 reg_lock_length;
> + __le16 next_lmid;
> + u8 ex_status;
> + u8 status;
> + u8 raid_flags;
> + u8 num_sge;
> + __le16 config_seq_num;
> + u8 span_arm;
> + u8 priority;
> + u8 num_sge_ext;
> + u8 resvd2;
> };
>
> /*
> @@ -187,7 +194,7 @@ struct RAID_CONTEXT_G35 {
> } smid;
> u8 ex_status; /* 0x16 : OUT */
> u8 status; /* 0x17 status */
> - u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
> + u8 raid_flags; /* 0x18 resvd[7:6], ioSubType[5:4],
> * resvd[3:1], preferredCpu[0]
> */
> u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
> @@ -672,14 +679,17 @@ struct MPI2_IOC_INIT_REQUEST {
> #define MAX_RAIDMAP_ROW_SIZE (MAX_ROW_SIZE)
> #define MAX_LOGICAL_DRIVES 64
> #define MAX_LOGICAL_DRIVES_EXT 256
> +#define MAX_LOGICAL_DRIVES_DYN 512
> #define MAX_RAIDMAP_LOGICAL_DRIVES (MAX_LOGICAL_DRIVES)
> #define MAX_RAIDMAP_VIEWS (MAX_LOGICAL_DRIVES)
> #define MAX_ARRAYS 128
> #define MAX_RAIDMAP_ARRAYS (MAX_ARRAYS)
> #define MAX_ARRAYS_EXT 256
> #define MAX_API_ARRAYS_EXT (MAX_ARRAYS_EXT)
> +#define MAX_API_ARRAYS_DYN 512
> #define MAX_PHYSICAL_DEVICES 256
> #define MAX_RAIDMAP_PHYSICAL_DEVICES (MAX_PHYSICAL_DEVICES)
> +#define MAX_RAIDMAP_PHYSICAL_DEVICES_DYN 512
> #define MR_DCMD_LD_MAP_GET_INFO 0x0300e101
> #define MR_DCMD_SYSTEM_PD_MAP_GET_INFO 0x0200e102
> #define MR_DCMD_CTRL_SHARED_HOST_MEM_ALLOC 0x010e8485 /* SR-IOV HB alloc*/
> @@ -726,12 +736,56 @@ struct MR_SPAN_BLOCK_INFO {
> struct MR_SPAN_INFO block_span_info;
> };
>
> +#define MR_RAID_CTX_CPUSEL_0 0
> +#define MR_RAID_CTX_CPUSEL_1 1
> +#define MR_RAID_CTX_CPUSEL_2 2
> +#define MR_RAID_CTX_CPUSEL_3 3
> +#define MR_RAID_CTX_CPUSEL_FCFS 0xF
> +
> +struct MR_CPU_AFFINITY_MASK {
> + union {
> + struct {
> +#ifndef MFI_BIG_ENDIAN
> + u8 hw_path:1;
> + u8 cpu0:1;
> + u8 cpu1:1;
> + u8 cpu2:1;
> + u8 cpu3:1;
> + u8 reserved:3;
> +#else
> + u8 reserved:3;
> + u8 cpu3:1;
> + u8 cpu2:1;
> + u8 cpu1:1;
> + u8 cpu0:1;
> + u8 hw_path:1;
> +#endif
> + };
> + u8 core_mask;
> + };
> +};
> +
> +struct MR_IO_AFFINITY {
> + union {
> + struct {
> + struct MR_CPU_AFFINITY_MASK pdRead;
> + struct MR_CPU_AFFINITY_MASK pdWrite;
> + struct MR_CPU_AFFINITY_MASK ldRead;
> + struct MR_CPU_AFFINITY_MASK ldWrite;
> + };
> + u32 word;
> + };
> + u8 maxCores; /* Total cores + HW Path in ROC */
> + u8 reserved[3];
> +};
> +
> struct MR_LD_RAID {
> struct {
> #if defined(__BIG_ENDIAN_BITFIELD)
> - u32 reserved4:3;
> - u32 fp_cache_bypass_capable:1;
> - u32 fp_rmw_capable:1;
> + u32 reserved4:2;
> + u32 fp_cache_bypass_capable:1;
> + u32 fp_rmw_capable:1;
> + u32 disable_coalescing:1;
> u32 fpBypassRegionLock:1;
> u32 tmCapable:1;
> u32 fpNonRWCapable:1;
> @@ -759,9 +813,10 @@ struct MR_LD_RAID {
> u32 fpNonRWCapable:1;
> u32 tmCapable:1;
> u32 fpBypassRegionLock:1;
> - u32 fp_rmw_capable:1;
> - u32 fp_cache_bypass_capable:1;
> - u32 reserved4:3;
> + u32 disable_coalescing:1;
> + u32 fp_rmw_capable:1;
> + u32 fp_cache_bypass_capable:1;
> + u32 reserved4:2;
> #endif
> } capability;
> __le32 reserved6;
> @@ -788,7 +843,36 @@ struct MR_LD_RAID {
>
> u8 LUN[8]; /* 0x24 8 byte LUN field used for SCSI IO's */
> u8 fpIoTimeoutForLd;/*0x2C timeout value used by driver in FP IO*/
> - u8 reserved3[0x80-0x2D]; /* 0x2D */
> + /* Ox2D This LD accept priority boost of this type */
> + u8 ld_accept_priority_type;
> + u8 reserved2[2]; /* 0x2E - 0x2F */
> + /* 0x30 - 0x33, Logical block size for the LD */
> + u32 logical_block_length;
> + struct {
> +#ifndef MFI_BIG_ENDIAN
> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
> + u32 ld_pi_exp:4;
> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
> + * BLOCK EXPONENT from READ CAPACITY 16
> + */
> + u32 ld_logical_block_exp:4;
> + u32 reserved1:24; /* 0x34 */
> +#else
> + u32 reserved1:24; /* 0x34 */
> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
> + * BLOCK EXPONENT from READ CAPACITY 16
> + */
> + u32 ld_logical_block_exp:4;
> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
> + u32 ld_pi_exp:4;
> +#endif
> + }; /* 0x34 - 0x37 */
> + /* 0x38 - 0x3f, This will determine which
> + * core will process LD IO and PD IO.
> + */
> + struct MR_IO_AFFINITY cpuAffinity;
> + /* Bit definiations are specified by MR_IO_AFFINITY */
> + u8 reserved3[0x80-0x40]; /* 0x40 - 0x7f */
> };
>
> struct MR_LD_SPAN_MAP {
> @@ -846,6 +930,91 @@ struct MR_LD_TARGET_SYNC {
> __le16 seqNum;
> };
>
> +/*
> +* RAID Map descriptor Types.
> +* Each element should uniquely idetify one data structure in the RAID map
> +*/
> +enum MR_RAID_MAP_DESC_TYPE {
> + /* MR_DEV_HANDLE_INFO data */
> + RAID_MAP_DESC_TYPE_DEVHDL_INFO = 0x0,
> + /* target to Ld num Index map */
> + RAID_MAP_DESC_TYPE_TGTID_INFO = 0x1,
> + /* MR_ARRAY_INFO data */
> + RAID_MAP_DESC_TYPE_ARRAY_INFO = 0x2,
> + /* MR_LD_SPAN_MAP data */
> + RAID_MAP_DESC_TYPE_SPAN_INFO = 0x3,
> + RAID_MAP_DESC_TYPE_COUNT,
> +};
> +
> +/*
> +* This table defines the offset, size and num elements of each descriptor
> +* type in the RAID Map buffer
> +*/
> +struct MR_RAID_MAP_DESC_TABLE {
> + /* Raid map descriptor type */
> + u32 raid_map_desc_type;
> + /* Offset into the RAID map buffer where
> + * descriptor data is saved
> + */
> + u32 raid_map_desc_offset;
> + /* total size of the
> + * descriptor buffer
> + */
> + u32 raid_map_desc_buffer_size;
> + /* Number of elements contained in the
> + * descriptor buffer
> + */
> + u32 raid_map_desc_elements;
> +};
> +
> +/*
> +* Dynamic Raid Map Structure.
> +*/
> +struct MR_FW_RAID_MAP_DYNAMIC {
> + u32 raid_map_size; /* total size of RAID Map structure */
> + u32 desc_table_offset;/* Offset of desc table into RAID map*/
> + u32 desc_table_size; /* Total Size of desc table */
> + /* Total Number of elements in the desc table */
> + u32 desc_table_num_elements;
> + u64 reserved1;
> + u32 reserved2[3]; /*future use */
> + /* timeout value used by driver in FP IOs */
> + u8 fp_pd_io_timeout_sec;
> + u8 reserved3[3];
> + /* when this seqNum increments, driver needs to
> + * release RMW buffers asap
> + */
> + u32 rmw_fp_seq_num;
> + u16 ld_count; /* count of lds. */
> + u16 ar_count; /* count of arrays */
> + u16 span_count; /* count of spans */
> + u16 reserved4[3];
> +/*
> +* The below structure of pointers is only to be used by the driver.
> +* This is added in the ,API to reduce the amount of code changes
> +* needed in the driver to support dynamic RAID map Firmware should
> +* not update these pointers while preparing the raid map
> +*/
> + union {
> + struct {
> + struct MR_DEV_HANDLE_INFO *dev_hndl_info;
> + u16 *ld_tgt_id_to_ld;
> + struct MR_ARRAY_INFO *ar_map_info;
> + struct MR_LD_SPAN_MAP *ld_span_map;
> + };
> + u64 ptr_structure_size[RAID_MAP_DESC_TYPE_COUNT];
> + };
> +/*
> +* RAID Map descriptor table defines the layout of data in the RAID Map.
> +* The size of the descriptor table itself could change.
> +*/
> + /* Variable Size descriptor Table. */
> + struct MR_RAID_MAP_DESC_TABLE
> + raid_map_desc_table[RAID_MAP_DESC_TYPE_COUNT];
> + /* Variable Size buffer containing all data */
> + u32 raid_map_desc_data[1];
> +}; /* Dynamicaly sized RAID MAp structure */
> +
> #define IEEE_SGE_FLAGS_ADDR_MASK (0x03)
> #define IEEE_SGE_FLAGS_SYSTEM_ADDR (0x00)
> #define IEEE_SGE_FLAGS_IOCDDR_ADDR (0x01)
> @@ -955,9 +1124,10 @@ struct MR_DRV_RAID_MAP {
> __le16 spanCount;
> __le16 reserve3;
>
> - struct MR_DEV_HANDLE_INFO devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES];
> - u8 ldTgtIdToLd[MAX_LOGICAL_DRIVES_EXT];
> - struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_EXT];
> + struct MR_DEV_HANDLE_INFO
> + devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES_DYN];
> + u16 ldTgtIdToLd[MAX_LOGICAL_DRIVES_DYN];
> + struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_DYN];
> struct MR_LD_SPAN_MAP ldSpanMap[1];
>
> };
> @@ -969,7 +1139,7 @@ struct MR_DRV_RAID_MAP {
> struct MR_DRV_RAID_MAP_ALL {
>
> struct MR_DRV_RAID_MAP raidMap;
> - struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_EXT - 1];
> + struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_DYN - 1];
> } __packed;
>
>
> @@ -1088,7 +1258,7 @@ struct fusion_context {
> u8 chain_offset_io_request;
> u8 chain_offset_mfi_pthru;
>
> - struct MR_FW_RAID_MAP_ALL *ld_map[2];
> + struct MR_FW_RAID_MAP_DYNAMIC *ld_map[2];
> dma_addr_t ld_map_phys[2];
>
> /*Non dma-able memory. Driver local copy.*/
> @@ -1096,6 +1266,8 @@ struct fusion_context {
>
> u32 max_map_sz;
> u32 current_map_sz;
> + u32 old_map_sz;
> + u32 new_map_sz;
> u32 drv_map_sz;
> u32 drv_map_pages;
> struct MR_PD_CFG_SEQ_NUM_SYNC *pd_seq_sync[JBOD_MAPS_COUNT];
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
2016-12-09 12:55 ` Tomas Henzl
@ 2016-12-14 21:49 ` Sasikumar PC
2016-12-20 1:51 ` Sasikumar PC
1 sibling, 0 replies; 40+ messages in thread
From: Sasikumar PC @ 2016-12-14 21:49 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Friday, December 09, 2016 7:55 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
SAS3.5 Generic Megaraid Controllers
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap
to have different
> sizes for different number of supported VDs.
>
> This patch is depending on patch 5
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 7 +
> drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++++--
> drivers/scsi/megaraid/megaraid_sas_fp.c | 303
++++++++++++++++++++++++----
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 223 ++++++++++++++++----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 240
++++++++++++++++++----
> 5 files changed, 699 insertions(+), 135 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
> index f4d6a94..3e087ab 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -1434,6 +1434,12 @@ enum FW_BOOT_CONTEXT {
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
> #define MR_MAX_MSIX_REG_ARRAY 16
> #define MR_RDPQ_MODE_OFFSET 0X00800000
> +
> +#define MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT 16
> +#define MR_MAX_RAID_MAP_SIZE_MASK 0x1FF
> +#define MR_MIN_MAP_SIZE 0x10000
> +/* 64k */
> +
> #define MR_CAN_HANDLE_SYNC_CACHE_OFFSET 0X01000000
>
> /*
> @@ -2152,6 +2158,7 @@ struct megasas_instance {
> bool fw_sync_cache_support;
> bool is_ventura;
> bool msix_combined;
> + u16 max_raid_mapsize;
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
> index c52f7be..3f06b57 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -4424,8 +4424,7 @@ int megasas_alloc_cmds(struct megasas_instance
*instance)
> static void megasas_update_ext_vd_details(struct megasas_instance
*instance)
> {
> struct fusion_context *fusion;
> - u32 old_map_sz;
> - u32 new_map_sz;
> + u32 ventura_map_sz = 0;
>
> fusion = instance->ctrl_context;
> /* For MFI based controllers return dummy success */
> @@ -4455,21 +4454,39 @@ static void megasas_update_ext_vd_details(struct
megasas_instance *instance)
> instance->supportmax256vd ? "Extended VD(240 VD)firmware"
:
> "Legacy(64 VD) firmware");
>
> - old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
> - (sizeof(struct MR_LD_SPAN_MAP) *
> - (instance->fw_supported_vd_count - 1));
> - new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
> - fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
> - (sizeof(struct MR_LD_SPAN_MAP) *
> - (instance->drv_supported_vd_count - 1));
> -
> - fusion->max_map_sz = max(old_map_sz, new_map_sz);
> + if (instance->max_raid_mapsize) {
> + ventura_map_sz = instance->max_raid_mapsize *
> + MR_MIN_MAP_SIZE; /* 64k */
> + fusion->current_map_sz = ventura_map_sz;
> + fusion->max_map_sz = ventura_map_sz;
> + } else {
> + fusion->old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
> + (sizeof(struct MR_LD_SPAN_MAP) *
> + (instance->fw_supported_vd_count -
1));
> + fusion->new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>
> + fusion->max_map_sz =
> + max(fusion->old_map_sz, fusion->new_map_sz);
>
> - if (instance->supportmax256vd)
> - fusion->current_map_sz = new_map_sz;
> - else
> - fusion->current_map_sz = old_map_sz;
> + if (instance->supportmax256vd)
> + fusion->current_map_sz = fusion->new_map_sz;
> + else
> + fusion->current_map_sz = fusion->old_map_sz;
> + }
> + /* irrespective of FW raid maps, driver raid map is constant */
> + fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP_ALL);
> +#if VD_EXT_DEBUG
> + dev_info(&instance->pdev->dev, "instance->max_raid_mapsize 0x%x \n
",
> + instance->max_raid_mapsize);
> + dev_info(&instance->pdev->dev,
> + "new_map_sz = 0x%x, old_map_sz = 0x%x, "
> + "ventura_map_sz = 0x%x, current_map_sz = 0x%x "
> + "fusion->drv_map_sz =0x%x, size of driver raid map 0x%lx\n",
> + fusion->new_map_sz, fusion->old_map_sz,
> + ventura_map_sz, fusion->current_map_sz,
> + fusion->drv_map_sz,
> + sizeof(struct MR_DRV_RAID_MAP_ALL));
> +#endif
> }
>
> /**
> @@ -5010,7 +5027,7 @@ static int megasas_init_fw(struct megasas_instance
*instance)
> {
> u32 max_sectors_1;
> u32 max_sectors_2;
> - u32 tmp_sectors, msix_enable, scratch_pad_2;
> + u32 tmp_sectors, msix_enable, scratch_pad_2, scratch_pad_3;
> resource_size_t base_addr;
> struct megasas_register_set __iomem *reg_set;
> struct megasas_ctrl_info *ctrl_info = NULL;
> @@ -5086,7 +5103,17 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> goto fail_ready_state;
> }
>
> -
> + if (instance->is_ventura) {
> + scratch_pad_3 =
> + readl(&instance->reg_set->outbound_scratch_pad_3);
> +#if VD_EXT_DEBUG
> + dev_info(&instance->pdev->dev, "scratch_pad3 0x%x\n",
> + scratch_pad_3);
> +#endif
> + instance->max_raid_mapsize = ((scratch_pad_3 >>
> + MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT) &
> + MR_MAX_RAID_MAP_SIZE_MASK);
> + }
>
> /* Check if MSI-X is supported while in ready state */
> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index eb9ff44..a6957a3 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -179,18 +179,204 @@ void MR_PopulateDrvRaidMap(struct
megasas_instance *instance)
> struct fusion_context *fusion = instance->ctrl_context;
> struct MR_FW_RAID_MAP_ALL *fw_map_old = NULL;
> struct MR_FW_RAID_MAP *pFwRaidMap = NULL;
> - int i;
> + int i, j;
> u16 ld_count;
> + struct MR_FW_RAID_MAP_DYNAMIC *fw_map_dyn;
> + struct MR_FW_RAID_MAP_EXT *fw_map_ext;
> + struct MR_RAID_MAP_DESC_TABLE *desc_table;
>
>
> struct MR_DRV_RAID_MAP_ALL *drv_map =
> fusion->ld_drv_map[(instance->map_id & 1)];
> struct MR_DRV_RAID_MAP *pDrvRaidMap = &drv_map->raidMap;
> + void *raid_map_data = NULL;
> +
> + memset(drv_map, 0, fusion->drv_map_sz);
> + memset(pDrvRaidMap->ldTgtIdToLd,
> + 0xff, (sizeof(u16) * MAX_LOGICAL_DRIVES_DYN));
> +
> + if (instance->max_raid_mapsize) {
> + fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
> +#if VD_EXT_DEBUG
> + dev_dbg(&instance->pdev->dev,
> + " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
> + " descTableSize 0x%x descTableNumElements 0x%x\n",
> + le32_to_cpu(fw_map_dyn->raid_map_size),
> + le32_to_cpu(fw_map_dyn->desc_table_offset),
> + le32_to_cpu(fw_map_dyn->desc_table_size),
> + le32_to_cpu(fw_map_dyn->desc_table_num_elements));
> + dev_dbg(&instance->pdev->dev,
> + "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
> +#endif
> + desc_table =
> + (struct MR_RAID_MAP_DESC_TABLE *)((void *)fw_map_dyn +
> + le32_to_cpu(fw_map_dyn->desc_table_offset));
> + if (desc_table != fw_map_dyn->raid_map_desc_table) {
> + dev_err(&instance->pdev->dev,
> + "offsets of desc table are not matching returning
"
> + " FW raid map has been changed: desc %p original
%p\n",
> + desc_table, fw_map_dyn->raid_map_desc_table);
> + }
> + ld_count = (u16)le16_to_cpu(fw_map_dyn->ld_count);
> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> + pDrvRaidMap->fpPdIoTimeoutSec =
fw_map_dyn->fp_pd_io_timeout_sec;
> + pDrvRaidMap->totalSize = sizeof(struct
MR_DRV_RAID_MAP_ALL);
> + /* point to actual data starting point*/
> + raid_map_data = (void *)fw_map_dyn +
> + le32_to_cpu(fw_map_dyn->desc_table_offset) +
> + le32_to_cpu(fw_map_dyn->desc_table_size);
> +
> + for (i = 0; i <
le32_to_cpu(fw_map_dyn->desc_table_num_elements); ++i) {
> + if (!desc_table) {
> + dev_err(&instance->pdev->dev,
> + "desc table is null, coming out %p \n",
desc_table);
> + return;
> + }
Is it possible that desc_table ever happens to NULL? It looks
like a test something else was intended here ?
Sasi - I am working on this and will be posting the update soon
Also all the VD_EXT_DEBUG macros make with bad indentation added
make the code hard to read. Please fix it later in a follow up patch.
Sasi - This shall be fixed in V5 patch
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "desc table %p \n", desc_table);
> + dev_err(&instance->pdev->dev,
> + "raidmap type %d, raidmapOffset 0x%x, "
> + " raid map number of elements 0%x, raidmapsize
0x%x\n",
> + desc_table->raid_map_desc_type,
> + desc_table->raid_map_desc_offset,
> + desc_table->raid_map_desc_elements,
> + desc_table->raid_map_desc_buffer_size);
> +#endif
> + switch
(le32_to_cpu(desc_table->raid_map_desc_type)) {
> + case RAID_MAP_DESC_TYPE_DEVHDL_INFO:
> + fw_map_dyn->dev_hndl_info = (struct
MR_DEV_HANDLE_INFO *)
> + (raid_map_data +
> +
le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "devHndlInfo address %p\n",
> + fw_map_dyn->dev_hndl_info);
> +#endif
> + memcpy(pDrvRaidMap->devHndlInfo,
fw_map_dyn->dev_hndl_info,
> + sizeof(struct MR_DEV_HANDLE_INFO)
*
> +
le32_to_cpu(desc_table->raid_map_desc_elements));
> + break;
> + case RAID_MAP_DESC_TYPE_TGTID_INFO:
> + fw_map_dyn->ld_tgt_id_to_ld = (u16
*) (raid_map_data +
> +
le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "ldTgtIdToLd address %p\n",
> + fw_map_dyn->ld_tgt_id_to_ld);
> +#endif
> + for (j = 0; j <
le32_to_cpu(desc_table->raid_map_desc_elements); j++) {
> + pDrvRaidMap->ldTgtIdToLd[j] =
> + fw_map_dyn->ld_tgt_id_to_ld[j];
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + " %d drv ldTgtIdToLd %d\n",
> + j,
pDrvRaidMap->ldTgtIdToLd[j]);
> +#endif
> + }
> + break;
> + case RAID_MAP_DESC_TYPE_ARRAY_INFO:
> + fw_map_dyn->ar_map_info = (struct
MR_ARRAY_INFO *)
> + (raid_map_data +
le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "arMapInfo address %p\n",
> + fw_map_dyn->ar_map_info);
> +#endif
> +
> + memcpy(pDrvRaidMap->arMapInfo,
> + fw_map_dyn->ar_map_info,
> + sizeof(struct MR_ARRAY_INFO) *
> +
le32_to_cpu(desc_table->raid_map_desc_elements));
> + break;
> + case RAID_MAP_DESC_TYPE_SPAN_INFO:
> + fw_map_dyn->ld_span_map = (struct
MR_LD_SPAN_MAP *)
> + (raid_map_data +
le32_to_cpu(desc_table->raid_map_desc_offset));
> + memcpy(pDrvRaidMap->ldSpanMap,
> + fw_map_dyn->ld_span_map,
> + sizeof(struct MR_LD_SPAN_MAP) *
> +
le32_to_cpu(desc_table->raid_map_desc_elements));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "ldSpanMap address %p\n",
> + fw_map_dyn->ld_span_map);
> + dev_err(&instance->pdev->dev,
> + "MR_LD_SPAN_MAP size 0x%lx\n",
sizeof(struct MR_LD_SPAN_MAP));
> + for (j = 0; j < ld_count; j++) {
> + printk(KERN_DEBUG
"megaraid_sas(%d) : fw_map_dyn->ldSpanMap[%d].ldRaid.targetId 0x%x
fw_map_dyn->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + j, j,
fw_map_dyn->ld_span_map[j].ldRaid.targetId, j,
> +
fw_map_dyn->ld_span_map[j].ldRaid.seqNum,
> +
(u32)fw_map_dyn->ld_span_map[j].ldRaid.rowSize);
> + printk(KERN_DEBUG
"megaraid_sas(%d) :pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x
pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + j, j,
pDrvRaidMap->ldSpanMap[j].ldRaid.targetId, j,
> +
pDrvRaidMap->ldSpanMap[j].ldRaid.seqNum,
> +
(u32)pDrvRaidMap->ldSpanMap[j].ldRaid.rowSize);
> + printk(KERN_DEBUG
"megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p/%p\n",
> + instance->unique_id, drv_map,
pDrvRaidMap,
> +
&fw_map_dyn->ld_span_map[j].ldRaid,
> +
&pDrvRaidMap->ldSpanMap[j].ldRaid);
> + }
> +#endif
> + break;
> + default:
> + dev_err(&instance->pdev->dev,
> + "wrong number of desctableElements
%d\n",
> +
fw_map_dyn->desc_table_num_elements);
> + }
> + ++desc_table;
> + }
> +
> + } else if (instance->supportmax256vd) {
> + fw_map_ext =
> + (struct MR_FW_RAID_MAP_EXT *)
fusion->ld_map[(instance->map_id & 1)];
> + ld_count = (u16)le16_to_cpu(fw_map_ext->ldCount);
> + if (ld_count > MAX_LOGICAL_DRIVES_EXT) {
> + printk(KERN_DEBUG "megaraid_sas: LD count exposed
in RAID map in not valid\n");
> + return;
> + }
> +#if VD_EXT_DEBUG
> + for (i = 0; i < ld_count; i++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) :Index 0x%x
Target Id 0x%x Seq Num 0x%x Size 0/%llx\n",
> + instance->unique_id,
> + i,
fw_map_ext->ldSpanMap[i].ldRaid.targetId,
> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
> + fw_map_ext->ldSpanMap[i].ldRaid.size);
> + }
> +#endif
> +
> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> + pDrvRaidMap->fpPdIoTimeoutSec =
> +
fw_map_ext->fpPdIoTimeoutSec;
> + for (i = 0; i < (MAX_LOGICAL_DRIVES_EXT); i++)
> + pDrvRaidMap->ldTgtIdToLd[i] =
> + (u16)fw_map_ext->ldTgtIdToLd[i];
> + memcpy(pDrvRaidMap->ldSpanMap,
> + fw_map_ext->ldSpanMap,
> + sizeof(struct MR_LD_SPAN_MAP) *
> + ld_count);
> +#if VD_EXT_DEBUG
> + for (i = 0; i < ld_count; i++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) :
fw_map_ext->ldSpanMap[%d].ldRaid.targetId 0x%x
fw_map_ext->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + i, i, fw_map_ext->ldSpanMap[i].ldRaid.targetId, i,
> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
> + (u32)fw_map_ext->ldSpanMap[i].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) :
pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x"
> + "pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x
size 0x%x\n",
> + i, i, pDrvRaidMap->ldSpanMap[i].ldRaid.targetId,
i,
> + pDrvRaidMap->ldSpanMap[i].ldRaid.seqNum,
> + (u32)pDrvRaidMap->ldSpanMap[i].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map
all %p raid map %p LD RAID MAP %p %p\n",
> + instance->unique_id, drv_map, pDrvRaidMap,
> + &fw_map_ext->ldSpanMap[i].ldRaid,
> + &pDrvRaidMap->ldSpanMap[i].ldRaid);
> + }
> +#endif
> + memcpy(pDrvRaidMap->arMapInfo, fw_map_ext->arMapInfo,
> + sizeof(struct MR_ARRAY_INFO) *
MAX_API_ARRAYS_EXT);
> + memcpy(pDrvRaidMap->devHndlInfo, fw_map_ext->devHndlInfo,
> + sizeof(struct MR_DEV_HANDLE_INFO) *
> + MAX_RAIDMAP_PHYSICAL_DEVICES);
>
> - if (instance->supportmax256vd) {
> - memcpy(fusion->ld_drv_map[instance->map_id & 1],
> - fusion->ld_map[instance->map_id & 1],
> - fusion->current_map_sz);
> /* New Raid map will not set totalSize, so keep expected
value
> * for legacy code in ValidateMapInfo
> */
> @@ -213,16 +399,12 @@ void MR_PopulateDrvRaidMap(struct megasas_instance
*instance)
> }
> #endif
>
> - memset(drv_map, 0, fusion->drv_map_sz);
> pDrvRaidMap->totalSize = pFwRaidMap->totalSize;
> pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> pDrvRaidMap->fpPdIoTimeoutSec =
pFwRaidMap->fpPdIoTimeoutSec;
> for (i = 0; i < MAX_RAIDMAP_LOGICAL_DRIVES +
MAX_RAIDMAP_VIEWS; i++)
> pDrvRaidMap->ldTgtIdToLd[i] =
> (u8)pFwRaidMap->ldTgtIdToLd[i];
> - for (i = (MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS);
> - i < MAX_LOGICAL_DRIVES_EXT; i++)
> - pDrvRaidMap->ldTgtIdToLd[i] = 0xff;
> for (i = 0; i < ld_count; i++) {
> pDrvRaidMap->ldSpanMap[i] =
pFwRaidMap->ldSpanMap[i];
> #if VD_EXT_DEBUG
> @@ -279,7 +461,9 @@ u8 MR_ValidateMapInfo(struct megasas_instance
*instance)
> lbInfo = fusion->load_balance_info;
> ldSpanInfo = fusion->log_to_span;
>
> - if (instance->supportmax256vd)
> + if (instance->max_raid_mapsize)
> + expected_size = sizeof(struct MR_DRV_RAID_MAP_ALL);
> + else if (instance->supportmax256vd)
> expected_size = sizeof(struct MR_FW_RAID_MAP_EXT);
> else
> expected_size =
> @@ -287,8 +471,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance
*instance)
> (sizeof(struct MR_LD_SPAN_MAP) *
le16_to_cpu(pDrvRaidMap->ldCount)));
>
> if (le32_to_cpu(pDrvRaidMap->totalSize) != expected_size) {
> - dev_err(&instance->pdev->dev, "map info structure size
0x%x is not matching with ld count\n",
> - (unsigned int) expected_size);
> + dev_err(&instance->pdev->dev, "megasas: map info
structure"
> + " size 0x%x is not matching expected size 0x%x\n",
> + le32_to_cpu(pDrvRaidMap->totalSize),
> + (unsigned int) expected_size);
> dev_err(&instance->pdev->dev, "megasas: span map %x,
pDrvRaidMap->totalSize : %x\n",
> (unsigned int)sizeof(struct MR_LD_SPAN_MAP),
> le32_to_cpu(pDrvRaidMap->totalSize));
> @@ -787,7 +973,7 @@ static u8 mr_spanset_get_phy_params(struct
megasas_instance *instance, u32 ld,
> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
> ((fusion->adapter_type == INVADER_SERIES) &&
> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
> - pRAID_Context->regLockFlags =
REGION_TYPE_EXCLUSIVE;
> + pRAID_Context->reg_lock_flags =
REGION_TYPE_EXCLUSIVE;
> else if (raid->level == 1) {
> physArm = physArm + 1;
> pd = MR_ArPdGet(arRef, physArm, map);
> @@ -797,9 +983,16 @@ static u8 mr_spanset_get_phy_params(struct
megasas_instance *instance, u32 ld,
> }
>
> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
map)->startBlk);
> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> - physArm;
> - io_info->span_arm = pRAID_Context->spanArm;
> + if (instance->is_ventura) {
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + } else {
> + pRAID_Context->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm = pRAID_Context->span_arm;
> + }
> return retval;
> }
>
> @@ -891,7 +1084,7 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
> ((fusion->adapter_type == INVADER_SERIES) &&
> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
> - pRAID_Context->regLockFlags =
REGION_TYPE_EXCLUSIVE;
> + pRAID_Context->reg_lock_flags =
REGION_TYPE_EXCLUSIVE;
> else if (raid->level == 1) {
> /* Get alternate Pd. */
> physArm = physArm + 1;
> @@ -903,9 +1096,16 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> }
>
> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
map)->startBlk);
> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> - physArm;
> - io_info->span_arm = pRAID_Context->spanArm;
> + if (instance->is_ventura) {
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
physArm;
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
physArm;
> + } else {
> + pRAID_Context->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm = pRAID_Context->span_arm;
> + }
> return retval;
> }
>
> @@ -1109,20 +1309,20 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> regSize += stripSize;
> }
>
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16(raid->fpIoTimeoutForLd ?
> raid->fpIoTimeoutForLd :
> map->raidMap.fpPdIoTimeoutSec);
> if (fusion->adapter_type == INVADER_SERIES)
> - pRAID_Context->regLockFlags = (isRead) ?
> + pRAID_Context->reg_lock_flags = (isRead) ?
> raid->regTypeReqOnRead : raid->regTypeReqOnWrite;
> - else
> - pRAID_Context->regLockFlags = (isRead) ?
> + else if (!instance->is_ventura)
> + pRAID_Context->reg_lock_flags = (isRead) ?
> REGION_TYPE_SHARED_READ : raid->regTypeReqOnWrite;
> - pRAID_Context->VirtualDiskTgtId = raid->targetId;
> - pRAID_Context->regLockRowLBA = cpu_to_le64(regStart);
> - pRAID_Context->regLockLength = cpu_to_le32(regSize);
> - pRAID_Context->configSeqNum = raid->seqNum;
> + pRAID_Context->virtual_disk_tgt_id = raid->targetId;
> + pRAID_Context->reg_lock_row_lba = cpu_to_le64(regStart);
> + pRAID_Context->reg_lock_length = cpu_to_le32(regSize);
> + pRAID_Context->config_seq_num = raid->seqNum;
> /* save pointer to raid->LUN array */
> *raidLUN = raid->LUN;
>
> @@ -1140,6 +1340,14 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> /* If IO on an invalid Pd, then FP is not possible.*/
> if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
> io_info->fpOkForIo = FALSE;
> + /* if FP possible, set the SLUD bit in
> + * regLockFlags for ventura
> + */
> + else if ((instance->is_ventura) && !isRead &&
> + (raid->writeMode == MR_RL_WRITE_BACK_MODE)
&&
> + raid->capability.fp_cache_bypass_capable)
> + ((struct RAID_CONTEXT_G35 *)
pRAID_Context)->routing_flags.bits.sld
> + = 1;
> /* set raid 1/10 fast path write capable bit in io_info */
> if (io_info->fpOkForIo &&
> (io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
> @@ -1319,6 +1527,7 @@ u8 megasas_get_best_arm_pd(struct megasas_instance
*instance,
> struct fusion_context *fusion;
> struct MR_LD_RAID *raid;
> struct MR_DRV_RAID_MAP_ALL *drv_map;
> + u16 pd1_dev_handle;
> u16 pend0, pend1, ld;
> u64 diff0, diff1;
> u8 bestArm, pd0, pd1, span, arm;
> @@ -1344,23 +1553,37 @@ u8 megasas_get_best_arm_pd(struct
megasas_instance *instance,
> pd1 = MR_ArPdGet(arRef, (arm + 1) >= span_row_size ?
> (arm + 1 - span_row_size) : arm + 1, drv_map);
>
> - /* get the pending cmds for the data and mirror arms */
> - pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
> - pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
> + /* Get PD1 Dev Handle */
>
> - /* Determine the disk whose head is nearer to the req. block */
> - diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
> - diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
> - bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
> + pd1_dev_handle = MR_PdDevHandleGet(pd1, drv_map);
>
> - if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
> + if (pd1_dev_handle == MR_PD_INVALID) {
> + bestArm = arm;
> + } else {
> + /* get the pending cmds for the data and mirror arms */
> + pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
> + pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
> +
> + /* Determine the disk whose head is nearer to the req.
block */
> + diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
> + diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
> + /*bestArm = diff0<=diff1 ? arm : arm ^ 1;*/
> + bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
The above comment is useless and the parentheses not needed,
again please clean it up in a next series.
Sasi - This shall be fixed in V5 patch
tomash
> +
> + /* Make balance count from 16 to 4 to
> + * keep driver in sync with Firmware
> + */
> + if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds)
||
> (bestArm != arm && pend1 > pend0 +
lb_pending_cmds))
> - bestArm ^= 1;
> + bestArm ^= 1;
> +
> + /* Update the last accessed block on the correct pd */
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
> + io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
> + }
>
> - /* Update the last accessed block on the correct pd */
> - io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
> lbInfo->last_accessed_block[io_info->pd_after_lb] = block + count
- 1;
> - io_info->span_arm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
bestArm;
> #if SPAN_DEBUG
> if (arm != bestArm)
> dev_dbg(&instance->pdev->dev, "LSI Debug R1 Load balance "
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 2fcd5cd..58f86aa 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -1834,7 +1834,7 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> struct megasas_cmd_fusion *cmd)
> {
> u8 fp_possible;
> - u32 start_lba_lo, start_lba_hi, device_id, datalength = 0;
> + u32 start_lba_lo, start_lba_hi, device_id, datalength = 0, ld;
> struct MPI2_RAID_SCSI_IO_REQUEST *io_request;
> union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
> struct IO_REQUEST_INFO io_info;
> @@ -1842,16 +1842,18 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> u8 *raidLUN;
> unsigned long spinlock_flags;
> + union RAID_CONTEXT_UNION *praid_context;
> + struct MR_LD_RAID *raid;
>
> device_id = MEGASAS_DEV_INDEX(scp);
>
> fusion = instance->ctrl_context;
>
> io_request = cmd->io_request;
> - io_request->RaidContext.raid_context.VirtualDiskTgtId =
> + io_request->RaidContext.raid_context.virtual_disk_tgt_id =
> cpu_to_le16(device_id);
> io_request->RaidContext.raid_context.status = 0;
> - io_request->RaidContext.raid_context.exStatus = 0;
> + io_request->RaidContext.raid_context.ex_status = 0;
>
> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION
*)cmd->request_desc;
>
> @@ -1920,10 +1922,12 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> io_info.isRead = 1;
>
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
> + raid = MR_LdRaidGet(ld, local_map_ptr);
>
> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
> instance->fw_supported_vd_count) ||
(!fusion->fast_path_io)) {
> - io_request->RaidContext.raid_context.regLockFlags = 0;
> + io_request->RaidContext.raid_context.reg_lock_flags = 0;
> fp_possible = 0;
> } else {
> if (MR_BuildRaidContext(instance, &io_info,
> @@ -1950,6 +1954,8 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> fp_possible = false;
> }
>
> + praid_context = &io_request->RaidContext;
> +
> if (fp_possible) {
> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info,
scp,
> local_map_ptr, start_lba_lo);
> @@ -1958,18 +1964,26 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> - if
(io_request->RaidContext.raid_context.regLockFlags ==
> + if
(io_request->RaidContext.raid_context.reg_lock_flags ==
> REGION_TYPE_UNUSED)
> cmd->request_desc->SCSIIO.RequestFlags =
>
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
>
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.raid_context.Type
> + io_request->RaidContext.raid_context.type
> = MPI2_TYPE_CUDA;
> io_request->RaidContext.raid_context.nseg = 0x1;
> io_request->IoFlags |=
cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> - io_request->RaidContext.raid_context.regLockFlags
|=
> +
io_request->RaidContext.raid_context.reg_lock_flags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> + } else if (instance->is_ventura) {
> + io_request->RaidContext.raid_context_g35.type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context_g35.nseg =
0x1;
> +
io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + io_request->IoFlags |=
> +
cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> }
> if ((fusion->load_balance_info[device_id].loadBalanceFlag)
&&
> (io_info.isRead)) {
> @@ -1979,6 +1993,13 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> &io_info);
> scp->SCp.Status |= MEGASAS_LOAD_BALANCE_FLAG;
> cmd->pd_r1_lb = io_info.pd_after_lb;
> + if (instance->is_ventura)
> +
io_request->RaidContext.raid_context_g35.span_arm
> + = io_info.span_arm;
> + else
> +
io_request->RaidContext.raid_context.span_arm
> + = io_info.span_arm;
> +
> } else
> scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
>
> @@ -1997,28 +2018,98 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> io_request->DevHandle = io_info.devHandle;
> /* populate the LUN field */
> memcpy(io_request->LUN, raidLUN, 8);
> + if (instance->is_ventura) {
> + if (io_info.isRead) {
> + if ((raid->cpuAffinity.pdRead.cpu0) &&
> + (raid->cpuAffinity.pdRead.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.pdRead.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.pdWrite.cpu0)
> + && (raid->cpuAffinity.pdWrite.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.pdWrite.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + if
(praid_context->raid_context_g35.routing_flags.bits.sld) {
> +
praid_context->raid_context_g35.raid_flags
> + =
(MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
> + <<
MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
> + }
> + }
> + }
> } else {
> - io_request->RaidContext.raid_context.timeoutValue =
> + io_request->RaidContext.raid_context.timeout_value =
>
cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> if (io_info.do_fp_rlbypass ||
> - (io_request->RaidContext.raid_context.regLockFlags
> +
(io_request->RaidContext.raid_context.reg_lock_flags
> == REGION_TYPE_UNUSED))
> cmd->request_desc->SCSIIO.RequestFlags =
>
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
>
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.raid_context.Type
> + io_request->RaidContext.raid_context.type
> = MPI2_TYPE_CUDA;
> - io_request->RaidContext.raid_context.regLockFlags
|=
> +
io_request->RaidContext.raid_context.reg_lock_flags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> io_request->RaidContext.raid_context.nseg = 0x1;
> + } else if (instance->is_ventura) {
> + io_request->RaidContext.raid_context_g35.type
> + = MPI2_TYPE_CUDA;
> +
io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + io_request->RaidContext.raid_context_g35.nseg =
0x1;
> }
> io_request->Function =
MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> +
> + if (instance->is_ventura) {
> + if (io_info.isRead) {
> + if ((raid->cpuAffinity.ldRead.cpu0)
> + && (raid->cpuAffinity.ldRead.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldRead.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.ldWrite.cpu0) &&
> + (raid->cpuAffinity.ldWrite.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + =
MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldWrite.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> +
> + if
(io_request->RaidContext.raid_context_g35.stream_detected
> + && (raid->level == 5)
> + && (raid->writeMode ==
MR_RL_WRITE_THROUGH_MODE)) {
> + if
(praid_context->raid_context_g35.routing_flags.bits.cpu_sel ==
MR_RAID_CTX_CPUSEL_FCFS)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + =
MR_RAID_CTX_CPUSEL_0;
> + }
> + }
> + }
> } /* Not FP */
> }
>
> @@ -2053,9 +2144,9 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> /* get RAID_Context pointer */
> pRAID_Context = &io_request->RaidContext.raid_context;
> /* Check with FW team */
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->regLockRowLBA = 0;
> - pRAID_Context->regLockLength = 0;
> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
> + pRAID_Context->reg_lock_row_lba = 0;
> + pRAID_Context->reg_lock_length = 0;
>
> if (fusion->fast_path_io && (
> device_id < instance->fw_supported_vd_count)) {
> @@ -2074,7 +2165,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> io_request->Function =
MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> io_request->LUN[1] = scmd->device->lun;
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16 (scmd->request->timeout / HZ);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
> @@ -2082,9 +2173,10 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> } else {
>
> /* set RAID context values */
> - pRAID_Context->configSeqNum = raid->seqNum;
> - pRAID_Context->regLockFlags = REGION_TYPE_SHARED_READ;
> - pRAID_Context->timeoutValue =
cpu_to_le16(raid->fpIoTimeoutForLd);
> + pRAID_Context->config_seq_num = raid->seqNum;
> + if (!instance->is_ventura)
> + pRAID_Context->reg_lock_flags =
REGION_TYPE_SHARED_READ;
> + pRAID_Context->timeout_value =
cpu_to_le16(raid->fpIoTimeoutForLd);
>
> /* get the DevHandle for the PD (since this is
> fpNonRWCapable, this is a single disk RAID0) */
> @@ -2139,12 +2231,12 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> io_request = cmd->io_request;
> /* get RAID_Context pointer */
> pRAID_Context = &io_request->RaidContext.raid_context;
> - pRAID_Context->regLockFlags = 0;
> - pRAID_Context->regLockRowLBA = 0;
> - pRAID_Context->regLockLength = 0;
> + pRAID_Context->reg_lock_flags = 0;
> + pRAID_Context->reg_lock_row_lba = 0;
> + pRAID_Context->reg_lock_length = 0;
> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
> io_request->LUN[1] = scmd->device->lun;
> - pRAID_Context->RAIDFlags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
> + pRAID_Context->raid_flags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
> << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
>
> /* If FW supports PD sequence number */
> @@ -2153,24 +2245,28 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> /* TgtId must be incremented by 255 as jbod seq number is
index
> * below raid map
> */
> - pRAID_Context->VirtualDiskTgtId =
> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id + (MAX_PHYSICAL_DEVICES -
1));
> - pRAID_Context->configSeqNum =
pd_sync->seq[pd_index].seqNum;
> + pRAID_Context->config_seq_num =
pd_sync->seq[pd_index].seqNum;
> io_request->DevHandle = pd_sync->seq[pd_index].devHandle;
> - pRAID_Context->regLockFlags |=
> + if (instance->is_ventura)
> +
io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + else
> + pRAID_Context->reg_lock_flags |=
>
(MR_RL_FLAGS_SEQ_NUM_ENABLE|MR_RL_FLAGS_GRANT_DESTINATION_CUDA);
> - pRAID_Context->Type = MPI2_TYPE_CUDA;
> + pRAID_Context->type = MPI2_TYPE_CUDA;
> pRAID_Context->nseg = 0x1;
> } else if (fusion->fast_path_io) {
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->configSeqNum = 0;
> + pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id);
> + pRAID_Context->config_seq_num = 0;
> local_map_ptr = fusion->ld_drv_map[(instance->map_id &
1)];
> io_request->DevHandle =
>
local_map_ptr->raidMap.devHndlInfo[device_id].curDevHdl;
> } else {
> /* Want to send all IO via FW path */
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->configSeqNum = 0;
> + pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id);
> + pRAID_Context->config_seq_num = 0;
> io_request->DevHandle = cpu_to_le16(0xFFFF);
> }
>
> @@ -2186,14 +2282,14 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> cmd->request_desc->SCSIIO.RequestFlags =
> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - pRAID_Context->timeoutValue =
cpu_to_le16(os_timeout_value);
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> + pRAID_Context->timeout_value =
cpu_to_le16(os_timeout_value);
> + pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id);
> } else {
> /* system pd Fast Path */
> io_request->Function = MPI2_FUNCTION_SCSI_IO_REQUEST;
> timeout_limit = (scmd->device->type == TYPE_DISK) ?
> 255 : 0xFFFF;
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16((os_timeout_value > timeout_limit) ?
> timeout_limit : os_timeout_value);
> if (fusion->adapter_type == INVADER_SERIES)
> @@ -2232,8 +2328,8 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> io_request->Control = 0;
> io_request->EEDPBlockSize = 0;
> io_request->ChainOffset = 0;
> - io_request->RaidContext.raid_context.RAIDFlags = 0;
> - io_request->RaidContext.raid_context.Type = 0;
> + io_request->RaidContext.raid_context.raid_flags = 0;
> + io_request->RaidContext.raid_context.type = 0;
> io_request->RaidContext.raid_context.nseg = 0;
>
> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
> @@ -2278,11 +2374,16 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> return 1;
> }
>
> - /* numSGE store lower 8 bit of sge_count.
> - * numSGEExt store higher 8 bit of sge_count
> - */
> - io_request->RaidContext.raid_context.numSGE = sge_count;
> - io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >>
8);
> + if (instance->is_ventura)
> + io_request->RaidContext.raid_context_g35.num_sge =
sge_count;
> + else {
> + /* numSGE store lower 8 bit of sge_count.
> + * numSGEExt store higher 8 bit of sge_count
> + */
> + io_request->RaidContext.raid_context.num_sge = sge_count;
> + io_request->RaidContext.raid_context.num_sge_ext =
> + (u8)(sge_count >> 8);
> + }
>
> io_request->SGLFlags =
cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>
> @@ -2331,6 +2432,10 @@ void megasas_fpio_to_ldio(struct megasas_instance
*instance,
> struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
> {
> struct fusion_context *fusion;
> + union RAID_CONTEXT_UNION *praid_context;
> + struct MR_LD_RAID *raid;
> + struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> + u32 device_id, ld;
> fusion = instance->ctrl_context;
>
> cmd->request_desc->SCSIIO.RequestFlags =
> @@ -2354,6 +2459,35 @@ void megasas_fpio_to_ldio(struct megasas_instance
*instance,
> cmd->io_request->Control = 0;
> cmd->io_request->EEDPBlockSize = 0;
> cmd->is_raid_1_fp_write = 0;
> +
> + device_id = MEGASAS_DEV_INDEX(cmd->scmd);
> + local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
> + raid = MR_LdRaidGet(ld, local_map_ptr);
> + praid_context = &cmd->io_request->RaidContext;
> + if (cmd->scmd->sc_data_direction == PCI_DMA_FROMDEVICE) {
> + if ((raid->cpuAffinity.ldRead.cpu0)
> + && (raid->cpuAffinity.ldRead.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldRead.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.ldWrite.cpu0)
> + && (raid->cpuAffinity.ldWrite.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldWrite.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + }
> }
> /*megasas_prepate_secondRaid1_IO
> * It prepares the raid 1 second IO
> @@ -2491,6 +2625,7 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> * corresponds to single R1/10 LD are always same
> *
> */
> +
> /* driver side count always should be less than max_fw_cmds
> * to get new command
> */
> @@ -2588,7 +2723,7 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
>
> scmd_local = cmd_fusion->scmd;
> status = scsi_io_req->RaidContext.raid_context.status;
> - extStatus =
scsi_io_req->RaidContext.raid_context.exStatus;
> + extStatus =
scsi_io_req->RaidContext.raid_context.ex_status;
> sense = cmd_fusion->sense;
> data_length = scsi_io_req->DataLength;
>
> @@ -2656,13 +2791,13 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> status =
>
r1_cmd->io_request->RaidContext.raid_context.status;
> extStatus =
> -
r1_cmd->io_request->RaidContext.raid_context.exStatus;
> +
r1_cmd->io_request->RaidContext.raid_context.ex_status;
> data_length =
>
r1_cmd->io_request->DataLength;
> sense = r1_cmd->sense;
> }
>
r1_cmd->io_request->RaidContext.raid_context.status = 0;
> -
r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
> +
r1_cmd->io_request->RaidContext.raid_context.ex_status = 0;
> cmd_fusion->is_raid_1_fp_write = 0;
> r1_cmd->is_raid_1_fp_write = 0;
> r1_cmd->cmd_completed = false;
> @@ -2674,7 +2809,7 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> extStatus, data_length, sense);
>
scsi_io_req->RaidContext.raid_context.status
> = 0;
> -
scsi_io_req->RaidContext.raid_context.exStatus
> +
scsi_io_req->RaidContext.raid_context.ex_status
> = 0;
> megasas_return_cmd_fusion(instance,
cmd_fusion);
> scsi_dma_unmap(scmd_local);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index 5590c1d..cb42655 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -59,6 +59,8 @@
> #define MR_RL_FLAGS_GRANT_DESTINATION_CPU1 0x10
> #define MR_RL_FLAGS_GRANT_DESTINATION_CUDA 0x80
> #define MR_RL_FLAGS_SEQ_NUM_ENABLE 0x8
> +#define MR_RL_WRITE_THROUGH_MODE 0x00
> +#define MR_RL_WRITE_BACK_MODE 0x01
>
> /* T10 PI defines */
> #define MR_PROT_INFO_TYPE_CONTROLLER 0x8
> @@ -81,6 +83,11 @@
> enum MR_RAID_FLAGS_IO_SUB_TYPE {
> MR_RAID_FLAGS_IO_SUB_TYPE_NONE = 0,
> MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD = 1,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_DATA = 2,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_P = 3,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_Q = 4,
> + MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS = 6,
> + MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT = 7
> };
>
> /*
> @@ -109,29 +116,29 @@ enum MR_FUSION_ADAPTER_TYPE {
>
> struct RAID_CONTEXT {
> #if defined(__BIG_ENDIAN_BITFIELD)
> - u8 nseg:4;
> - u8 Type:4;
> + u8 nseg:4;
> + u8 type:4;
> #else
> - u8 Type:4;
> - u8 nseg:4;
> + u8 type:4;
> + u8 nseg:4;
> #endif
> - u8 resvd0;
> - __le16 timeoutValue;
> - u8 regLockFlags;
> - u8 resvd1;
> - __le16 VirtualDiskTgtId;
> - __le64 regLockRowLBA;
> - __le32 regLockLength;
> - __le16 nextLMId;
> - u8 exStatus;
> - u8 status;
> - u8 RAIDFlags;
> - u8 numSGE;
> - __le16 configSeqNum;
> - u8 spanArm;
> - u8 priority;
> - u8 numSGEExt;
> - u8 resvd2;
> + u8 resvd0;
> + __le16 timeout_value;
> + u8 reg_lock_flags;
> + u8 resvd1;
> + __le16 virtual_disk_tgt_id;
> + __le64 reg_lock_row_lba;
> + __le32 reg_lock_length;
> + __le16 next_lmid;
> + u8 ex_status;
> + u8 status;
> + u8 raid_flags;
> + u8 num_sge;
> + __le16 config_seq_num;
> + u8 span_arm;
> + u8 priority;
> + u8 num_sge_ext;
> + u8 resvd2;
> };
>
> /*
> @@ -187,7 +194,7 @@ struct RAID_CONTEXT_G35 {
> } smid;
> u8 ex_status; /* 0x16 : OUT */
> u8 status; /* 0x17 status */
> - u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
> + u8 raid_flags; /* 0x18 resvd[7:6], ioSubType[5:4],
> * resvd[3:1],
preferredCpu[0]
> */
> u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
> @@ -672,14 +679,17 @@ struct MPI2_IOC_INIT_REQUEST {
> #define MAX_RAIDMAP_ROW_SIZE (MAX_ROW_SIZE)
> #define MAX_LOGICAL_DRIVES 64
> #define MAX_LOGICAL_DRIVES_EXT 256
> +#define MAX_LOGICAL_DRIVES_DYN 512
> #define MAX_RAIDMAP_LOGICAL_DRIVES (MAX_LOGICAL_DRIVES)
> #define MAX_RAIDMAP_VIEWS (MAX_LOGICAL_DRIVES)
> #define MAX_ARRAYS 128
> #define MAX_RAIDMAP_ARRAYS (MAX_ARRAYS)
> #define MAX_ARRAYS_EXT 256
> #define MAX_API_ARRAYS_EXT (MAX_ARRAYS_EXT)
> +#define MAX_API_ARRAYS_DYN 512
> #define MAX_PHYSICAL_DEVICES 256
> #define MAX_RAIDMAP_PHYSICAL_DEVICES (MAX_PHYSICAL_DEVICES)
> +#define MAX_RAIDMAP_PHYSICAL_DEVICES_DYN 512
> #define MR_DCMD_LD_MAP_GET_INFO 0x0300e101
> #define MR_DCMD_SYSTEM_PD_MAP_GET_INFO 0x0200e102
> #define MR_DCMD_CTRL_SHARED_HOST_MEM_ALLOC 0x010e8485 /* SR-IOV HB
alloc*/
> @@ -726,12 +736,56 @@ struct MR_SPAN_BLOCK_INFO {
> struct MR_SPAN_INFO block_span_info;
> };
>
> +#define MR_RAID_CTX_CPUSEL_0 0
> +#define MR_RAID_CTX_CPUSEL_1 1
> +#define MR_RAID_CTX_CPUSEL_2 2
> +#define MR_RAID_CTX_CPUSEL_3 3
> +#define MR_RAID_CTX_CPUSEL_FCFS 0xF
> +
> +struct MR_CPU_AFFINITY_MASK {
> + union {
> + struct {
> +#ifndef MFI_BIG_ENDIAN
> + u8 hw_path:1;
> + u8 cpu0:1;
> + u8 cpu1:1;
> + u8 cpu2:1;
> + u8 cpu3:1;
> + u8 reserved:3;
> +#else
> + u8 reserved:3;
> + u8 cpu3:1;
> + u8 cpu2:1;
> + u8 cpu1:1;
> + u8 cpu0:1;
> + u8 hw_path:1;
> +#endif
> + };
> + u8 core_mask;
> + };
> +};
> +
> +struct MR_IO_AFFINITY {
> + union {
> + struct {
> + struct MR_CPU_AFFINITY_MASK pdRead;
> + struct MR_CPU_AFFINITY_MASK pdWrite;
> + struct MR_CPU_AFFINITY_MASK ldRead;
> + struct MR_CPU_AFFINITY_MASK ldWrite;
> + };
> + u32 word;
> + };
> + u8 maxCores; /* Total cores + HW Path in ROC */
> + u8 reserved[3];
> +};
> +
> struct MR_LD_RAID {
> struct {
> #if defined(__BIG_ENDIAN_BITFIELD)
> - u32 reserved4:3;
> - u32 fp_cache_bypass_capable:1;
> - u32 fp_rmw_capable:1;
> + u32 reserved4:2;
> + u32 fp_cache_bypass_capable:1;
> + u32 fp_rmw_capable:1;
> + u32 disable_coalescing:1;
> u32 fpBypassRegionLock:1;
> u32 tmCapable:1;
> u32 fpNonRWCapable:1;
> @@ -759,9 +813,10 @@ struct MR_LD_RAID {
> u32 fpNonRWCapable:1;
> u32 tmCapable:1;
> u32 fpBypassRegionLock:1;
> - u32 fp_rmw_capable:1;
> - u32 fp_cache_bypass_capable:1;
> - u32 reserved4:3;
> + u32 disable_coalescing:1;
> + u32 fp_rmw_capable:1;
> + u32 fp_cache_bypass_capable:1;
> + u32 reserved4:2;
> #endif
> } capability;
> __le32 reserved6;
> @@ -788,7 +843,36 @@ struct MR_LD_RAID {
>
> u8 LUN[8]; /* 0x24 8 byte LUN field used for SCSI IO's */
> u8 fpIoTimeoutForLd;/*0x2C timeout value used by driver in FP
IO*/
> - u8 reserved3[0x80-0x2D]; /* 0x2D */
> + /* Ox2D This LD accept priority boost of this type */
> + u8 ld_accept_priority_type;
> + u8 reserved2[2]; /* 0x2E - 0x2F */
> + /* 0x30 - 0x33, Logical block size for the LD */
> + u32 logical_block_length;
> + struct {
> +#ifndef MFI_BIG_ENDIAN
> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
> + u32 ld_pi_exp:4;
> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
> + * BLOCK EXPONENT from READ CAPACITY 16
> + */
> + u32 ld_logical_block_exp:4;
> + u32 reserved1:24; /* 0x34 */
> +#else
> + u32 reserved1:24; /* 0x34 */
> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
> + * BLOCK EXPONENT from READ CAPACITY 16
> + */
> + u32 ld_logical_block_exp:4;
> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
> + u32 ld_pi_exp:4;
> +#endif
> + }; /* 0x34 - 0x37 */
> + /* 0x38 - 0x3f, This will determine which
> + * core will process LD IO and PD IO.
> + */
> + struct MR_IO_AFFINITY cpuAffinity;
> + /* Bit definiations are specified by MR_IO_AFFINITY */
> + u8 reserved3[0x80-0x40]; /* 0x40 - 0x7f */
> };
>
> struct MR_LD_SPAN_MAP {
> @@ -846,6 +930,91 @@ struct MR_LD_TARGET_SYNC {
> __le16 seqNum;
> };
>
> +/*
> +* RAID Map descriptor Types.
> +* Each element should uniquely idetify one data structure in the RAID
map
> +*/
> +enum MR_RAID_MAP_DESC_TYPE {
> + /* MR_DEV_HANDLE_INFO data */
> + RAID_MAP_DESC_TYPE_DEVHDL_INFO = 0x0,
> + /* target to Ld num Index map */
> + RAID_MAP_DESC_TYPE_TGTID_INFO = 0x1,
> + /* MR_ARRAY_INFO data */
> + RAID_MAP_DESC_TYPE_ARRAY_INFO = 0x2,
> + /* MR_LD_SPAN_MAP data */
> + RAID_MAP_DESC_TYPE_SPAN_INFO = 0x3,
> + RAID_MAP_DESC_TYPE_COUNT,
> +};
> +
> +/*
> +* This table defines the offset, size and num elements of each
descriptor
> +* type in the RAID Map buffer
> +*/
> +struct MR_RAID_MAP_DESC_TABLE {
> + /* Raid map descriptor type */
> + u32 raid_map_desc_type;
> + /* Offset into the RAID map buffer where
> + * descriptor data is saved
> + */
> + u32 raid_map_desc_offset;
> + /* total size of the
> + * descriptor buffer
> + */
> + u32 raid_map_desc_buffer_size;
> + /* Number of elements contained in the
> + * descriptor buffer
> + */
> + u32 raid_map_desc_elements;
> +};
> +
> +/*
> +* Dynamic Raid Map Structure.
> +*/
> +struct MR_FW_RAID_MAP_DYNAMIC {
> + u32 raid_map_size; /* total size of RAID Map structure */
> + u32 desc_table_offset;/* Offset of desc table into RAID map*/
> + u32 desc_table_size; /* Total Size of desc table */
> + /* Total Number of elements in the desc table */
> + u32 desc_table_num_elements;
> + u64 reserved1;
> + u32 reserved2[3]; /*future use */
> + /* timeout value used by driver in FP IOs */
> + u8 fp_pd_io_timeout_sec;
> + u8 reserved3[3];
> + /* when this seqNum increments, driver needs to
> + * release RMW buffers asap
> + */
> + u32 rmw_fp_seq_num;
> + u16 ld_count; /* count of lds. */
> + u16 ar_count; /* count of arrays */
> + u16 span_count; /* count of spans */
> + u16 reserved4[3];
> +/*
> +* The below structure of pointers is only to be used by the driver.
> +* This is added in the ,API to reduce the amount of code changes
> +* needed in the driver to support dynamic RAID map Firmware should
> +* not update these pointers while preparing the raid map
> +*/
> + union {
> + struct {
> + struct MR_DEV_HANDLE_INFO *dev_hndl_info;
> + u16 *ld_tgt_id_to_ld;
> + struct MR_ARRAY_INFO *ar_map_info;
> + struct MR_LD_SPAN_MAP *ld_span_map;
> + };
> + u64 ptr_structure_size[RAID_MAP_DESC_TYPE_COUNT];
> + };
> +/*
> +* RAID Map descriptor table defines the layout of data in the RAID Map.
> +* The size of the descriptor table itself could change.
> +*/
> + /* Variable Size descriptor Table. */
> + struct MR_RAID_MAP_DESC_TABLE
> + raid_map_desc_table[RAID_MAP_DESC_TYPE_COUNT];
> + /* Variable Size buffer containing all data */
> + u32 raid_map_desc_data[1];
> +}; /* Dynamicaly sized RAID MAp structure */
> +
> #define IEEE_SGE_FLAGS_ADDR_MASK (0x03)
> #define IEEE_SGE_FLAGS_SYSTEM_ADDR (0x00)
> #define IEEE_SGE_FLAGS_IOCDDR_ADDR (0x01)
> @@ -955,9 +1124,10 @@ struct MR_DRV_RAID_MAP {
> __le16 spanCount;
> __le16 reserve3;
>
> - struct MR_DEV_HANDLE_INFO
devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES];
> - u8 ldTgtIdToLd[MAX_LOGICAL_DRIVES_EXT];
> - struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_EXT];
> + struct MR_DEV_HANDLE_INFO
> + devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES_DYN];
> + u16 ldTgtIdToLd[MAX_LOGICAL_DRIVES_DYN];
> + struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_DYN];
> struct MR_LD_SPAN_MAP ldSpanMap[1];
>
> };
> @@ -969,7 +1139,7 @@ struct MR_DRV_RAID_MAP {
> struct MR_DRV_RAID_MAP_ALL {
>
> struct MR_DRV_RAID_MAP raidMap;
> - struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_EXT - 1];
> + struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_DYN - 1];
> } __packed;
>
>
> @@ -1088,7 +1258,7 @@ struct fusion_context {
> u8 chain_offset_io_request;
> u8 chain_offset_mfi_pthru;
>
> - struct MR_FW_RAID_MAP_ALL *ld_map[2];
> + struct MR_FW_RAID_MAP_DYNAMIC *ld_map[2];
> dma_addr_t ld_map_phys[2];
>
> /*Non dma-able memory. Driver local copy.*/
> @@ -1096,6 +1266,8 @@ struct fusion_context {
>
> u32 max_map_sz;
> u32 current_map_sz;
> + u32 old_map_sz;
> + u32 new_map_sz;
> u32 drv_map_sz;
> u32 drv_map_pages;
> struct MR_PD_CFG_SEQ_NUM_SYNC *pd_seq_sync[JBOD_MAPS_COUNT];
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
2016-12-09 12:55 ` Tomas Henzl
2016-12-14 21:49 ` Sasikumar PC
@ 2016-12-20 1:51 ` Sasikumar PC
2016-12-20 14:20 ` Tomas Henzl
1 sibling, 1 reply; 40+ messages in thread
From: Sasikumar PC @ 2016-12-20 1:51 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Sasikumar PC [mailto:sasikumar.pc@broadcom.com]
Sent: Wednesday, December 14, 2016 4:49 PM
To: 'Tomas Henzl'; 'jejb@kernel.org'; 'hch@infradead.org'
Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;
'linux-kernel@vger.kernel.org'; Christopher Owens; Kiran Kumar Kasturi
Subject: RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
SAS3.5 Generic Megaraid Controllers
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Friday, December 09, 2016 7:55 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
SAS3.5 Generic Megaraid Controllers
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap
to have different
> sizes for different number of supported VDs.
>
> This patch is depending on patch 5
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 7 +
> drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++++--
> drivers/scsi/megaraid/megaraid_sas_fp.c | 303
++++++++++++++++++++++++----
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 223 ++++++++++++++++----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 240
++++++++++++++++++----
> 5 files changed, 699 insertions(+), 135 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
> index f4d6a94..3e087ab 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -1434,6 +1434,12 @@ enum FW_BOOT_CONTEXT {
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
> #define MR_MAX_MSIX_REG_ARRAY 16
> #define MR_RDPQ_MODE_OFFSET 0X00800000
> +
> +#define MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT 16
> +#define MR_MAX_RAID_MAP_SIZE_MASK 0x1FF
> +#define MR_MIN_MAP_SIZE 0x10000
> +/* 64k */
> +
> #define MR_CAN_HANDLE_SYNC_CACHE_OFFSET 0X01000000
>
> /*
> @@ -2152,6 +2158,7 @@ struct megasas_instance {
> bool fw_sync_cache_support;
> bool is_ventura;
> bool msix_combined;
> + u16 max_raid_mapsize;
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
> index c52f7be..3f06b57 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -4424,8 +4424,7 @@ int megasas_alloc_cmds(struct megasas_instance
*instance)
> static void megasas_update_ext_vd_details(struct megasas_instance
*instance)
> {
> struct fusion_context *fusion;
> - u32 old_map_sz;
> - u32 new_map_sz;
> + u32 ventura_map_sz = 0;
>
> fusion = instance->ctrl_context;
> /* For MFI based controllers return dummy success */
> @@ -4455,21 +4454,39 @@ static void megasas_update_ext_vd_details(struct
megasas_instance *instance)
> instance->supportmax256vd ? "Extended VD(240 VD)firmware"
:
> "Legacy(64 VD) firmware");
>
> - old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
> - (sizeof(struct MR_LD_SPAN_MAP) *
> - (instance->fw_supported_vd_count - 1));
> - new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
> - fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
> - (sizeof(struct MR_LD_SPAN_MAP) *
> - (instance->drv_supported_vd_count - 1));
> -
> - fusion->max_map_sz = max(old_map_sz, new_map_sz);
> + if (instance->max_raid_mapsize) {
> + ventura_map_sz = instance->max_raid_mapsize *
> + MR_MIN_MAP_SIZE; /* 64k */
> + fusion->current_map_sz = ventura_map_sz;
> + fusion->max_map_sz = ventura_map_sz;
> + } else {
> + fusion->old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
> + (sizeof(struct MR_LD_SPAN_MAP) *
> + (instance->fw_supported_vd_count -
1));
> + fusion->new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>
> + fusion->max_map_sz =
> + max(fusion->old_map_sz, fusion->new_map_sz);
>
> - if (instance->supportmax256vd)
> - fusion->current_map_sz = new_map_sz;
> - else
> - fusion->current_map_sz = old_map_sz;
> + if (instance->supportmax256vd)
> + fusion->current_map_sz = fusion->new_map_sz;
> + else
> + fusion->current_map_sz = fusion->old_map_sz;
> + }
> + /* irrespective of FW raid maps, driver raid map is constant */
> + fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP_ALL);
> +#if VD_EXT_DEBUG
> + dev_info(&instance->pdev->dev, "instance->max_raid_mapsize 0x%x \n
",
> + instance->max_raid_mapsize);
> + dev_info(&instance->pdev->dev,
> + "new_map_sz = 0x%x, old_map_sz = 0x%x, "
> + "ventura_map_sz = 0x%x, current_map_sz = 0x%x "
> + "fusion->drv_map_sz =0x%x, size of driver raid map 0x%lx\n",
> + fusion->new_map_sz, fusion->old_map_sz,
> + ventura_map_sz, fusion->current_map_sz,
> + fusion->drv_map_sz,
> + sizeof(struct MR_DRV_RAID_MAP_ALL));
> +#endif
> }
>
> /**
> @@ -5010,7 +5027,7 @@ static int megasas_init_fw(struct megasas_instance
*instance)
> {
> u32 max_sectors_1;
> u32 max_sectors_2;
> - u32 tmp_sectors, msix_enable, scratch_pad_2;
> + u32 tmp_sectors, msix_enable, scratch_pad_2, scratch_pad_3;
> resource_size_t base_addr;
> struct megasas_register_set __iomem *reg_set;
> struct megasas_ctrl_info *ctrl_info = NULL;
> @@ -5086,7 +5103,17 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> goto fail_ready_state;
> }
>
> -
> + if (instance->is_ventura) {
> + scratch_pad_3 =
> + readl(&instance->reg_set->outbound_scratch_pad_3);
> +#if VD_EXT_DEBUG
> + dev_info(&instance->pdev->dev, "scratch_pad3 0x%x\n",
> + scratch_pad_3);
> +#endif
> + instance->max_raid_mapsize = ((scratch_pad_3 >>
> + MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT) &
> + MR_MAX_RAID_MAP_SIZE_MASK);
> + }
>
> /* Check if MSI-X is supported while in ready state */
> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index eb9ff44..a6957a3 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -179,18 +179,204 @@ void MR_PopulateDrvRaidMap(struct
megasas_instance *instance)
> struct fusion_context *fusion = instance->ctrl_context;
> struct MR_FW_RAID_MAP_ALL *fw_map_old = NULL;
> struct MR_FW_RAID_MAP *pFwRaidMap = NULL;
> - int i;
> + int i, j;
> u16 ld_count;
> + struct MR_FW_RAID_MAP_DYNAMIC *fw_map_dyn;
> + struct MR_FW_RAID_MAP_EXT *fw_map_ext;
> + struct MR_RAID_MAP_DESC_TABLE *desc_table;
>
>
> struct MR_DRV_RAID_MAP_ALL *drv_map =
> fusion->ld_drv_map[(instance->map_id & 1)];
> struct MR_DRV_RAID_MAP *pDrvRaidMap = &drv_map->raidMap;
> + void *raid_map_data = NULL;
> +
> + memset(drv_map, 0, fusion->drv_map_sz);
> + memset(pDrvRaidMap->ldTgtIdToLd,
> + 0xff, (sizeof(u16) * MAX_LOGICAL_DRIVES_DYN));
> +
> + if (instance->max_raid_mapsize) {
> + fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
> +#if VD_EXT_DEBUG
> + dev_dbg(&instance->pdev->dev,
> + " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
> + " descTableSize 0x%x descTableNumElements 0x%x\n",
> + le32_to_cpu(fw_map_dyn->raid_map_size),
> + le32_to_cpu(fw_map_dyn->desc_table_offset),
> + le32_to_cpu(fw_map_dyn->desc_table_size),
> + le32_to_cpu(fw_map_dyn->desc_table_num_elements));
> + dev_dbg(&instance->pdev->dev,
> + "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
> +#endif
> + desc_table =
> + (struct MR_RAID_MAP_DESC_TABLE *)((void *)fw_map_dyn +
> + le32_to_cpu(fw_map_dyn->desc_table_offset));
> + if (desc_table != fw_map_dyn->raid_map_desc_table) {
> + dev_err(&instance->pdev->dev,
> + "offsets of desc table are not matching returning
"
> + " FW raid map has been changed: desc %p original
%p\n",
> + desc_table, fw_map_dyn->raid_map_desc_table);
> + }
> + ld_count = (u16)le16_to_cpu(fw_map_dyn->ld_count);
> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> + pDrvRaidMap->fpPdIoTimeoutSec =
fw_map_dyn->fp_pd_io_timeout_sec;
> + pDrvRaidMap->totalSize = sizeof(struct
MR_DRV_RAID_MAP_ALL);
> + /* point to actual data starting point*/
> + raid_map_data = (void *)fw_map_dyn +
> + le32_to_cpu(fw_map_dyn->desc_table_offset) +
> + le32_to_cpu(fw_map_dyn->desc_table_size);
> +
> + for (i = 0; i <
le32_to_cpu(fw_map_dyn->desc_table_num_elements); ++i) {
> + if (!desc_table) {
> + dev_err(&instance->pdev->dev,
> + "desc table is null, coming out %p \n",
desc_table);
> + return;
> + }
Is it possible that desc_table ever happens to NULL? It looks
like a test something else was intended here ?
It is a defensive check. yes can never be true and can be removed
Sasi
Also all the VD_EXT_DEBUG macros make with bad indentation added
make the code hard to read. Please fix it later in a follow up patch.
Sasi - This shall be fixed in V5 patch
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "desc table %p \n", desc_table);
> + dev_err(&instance->pdev->dev,
> + "raidmap type %d, raidmapOffset 0x%x, "
> + " raid map number of elements 0%x, raidmapsize
0x%x\n",
> + desc_table->raid_map_desc_type,
> + desc_table->raid_map_desc_offset,
> + desc_table->raid_map_desc_elements,
> + desc_table->raid_map_desc_buffer_size);
> +#endif
> + switch
(le32_to_cpu(desc_table->raid_map_desc_type)) {
> + case RAID_MAP_DESC_TYPE_DEVHDL_INFO:
> + fw_map_dyn->dev_hndl_info = (struct
MR_DEV_HANDLE_INFO *)
> + (raid_map_data +
> +
le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "devHndlInfo address %p\n",
> + fw_map_dyn->dev_hndl_info);
> +#endif
> + memcpy(pDrvRaidMap->devHndlInfo,
fw_map_dyn->dev_hndl_info,
> + sizeof(struct MR_DEV_HANDLE_INFO)
*
> +
le32_to_cpu(desc_table->raid_map_desc_elements));
> + break;
> + case RAID_MAP_DESC_TYPE_TGTID_INFO:
> + fw_map_dyn->ld_tgt_id_to_ld = (u16
*) (raid_map_data +
> +
le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "ldTgtIdToLd address %p\n",
> + fw_map_dyn->ld_tgt_id_to_ld);
> +#endif
> + for (j = 0; j <
le32_to_cpu(desc_table->raid_map_desc_elements); j++) {
> + pDrvRaidMap->ldTgtIdToLd[j] =
> + fw_map_dyn->ld_tgt_id_to_ld[j];
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + " %d drv ldTgtIdToLd %d\n",
> + j,
pDrvRaidMap->ldTgtIdToLd[j]);
> +#endif
> + }
> + break;
> + case RAID_MAP_DESC_TYPE_ARRAY_INFO:
> + fw_map_dyn->ar_map_info = (struct
MR_ARRAY_INFO *)
> + (raid_map_data +
le32_to_cpu(desc_table->raid_map_desc_offset));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "arMapInfo address %p\n",
> + fw_map_dyn->ar_map_info);
> +#endif
> +
> + memcpy(pDrvRaidMap->arMapInfo,
> + fw_map_dyn->ar_map_info,
> + sizeof(struct MR_ARRAY_INFO) *
> +
le32_to_cpu(desc_table->raid_map_desc_elements));
> + break;
> + case RAID_MAP_DESC_TYPE_SPAN_INFO:
> + fw_map_dyn->ld_span_map = (struct
MR_LD_SPAN_MAP *)
> + (raid_map_data +
le32_to_cpu(desc_table->raid_map_desc_offset));
> + memcpy(pDrvRaidMap->ldSpanMap,
> + fw_map_dyn->ld_span_map,
> + sizeof(struct MR_LD_SPAN_MAP) *
> +
le32_to_cpu(desc_table->raid_map_desc_elements));
> +#if VD_EXT_DEBUG
> + dev_err(&instance->pdev->dev,
> + "ldSpanMap address %p\n",
> + fw_map_dyn->ld_span_map);
> + dev_err(&instance->pdev->dev,
> + "MR_LD_SPAN_MAP size 0x%lx\n",
sizeof(struct MR_LD_SPAN_MAP));
> + for (j = 0; j < ld_count; j++) {
> + printk(KERN_DEBUG
"megaraid_sas(%d) : fw_map_dyn->ldSpanMap[%d].ldRaid.targetId 0x%x
fw_map_dyn->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + j, j,
fw_map_dyn->ld_span_map[j].ldRaid.targetId, j,
> +
fw_map_dyn->ld_span_map[j].ldRaid.seqNum,
> +
(u32)fw_map_dyn->ld_span_map[j].ldRaid.rowSize);
> + printk(KERN_DEBUG
"megaraid_sas(%d) :pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x
pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + j, j,
pDrvRaidMap->ldSpanMap[j].ldRaid.targetId, j,
> +
pDrvRaidMap->ldSpanMap[j].ldRaid.seqNum,
> +
(u32)pDrvRaidMap->ldSpanMap[j].ldRaid.rowSize);
> + printk(KERN_DEBUG
"megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p/%p\n",
> + instance->unique_id, drv_map,
pDrvRaidMap,
> +
&fw_map_dyn->ld_span_map[j].ldRaid,
> +
&pDrvRaidMap->ldSpanMap[j].ldRaid);
> + }
> +#endif
> + break;
> + default:
> + dev_err(&instance->pdev->dev,
> + "wrong number of desctableElements
%d\n",
> +
fw_map_dyn->desc_table_num_elements);
> + }
> + ++desc_table;
> + }
> +
> + } else if (instance->supportmax256vd) {
> + fw_map_ext =
> + (struct MR_FW_RAID_MAP_EXT *)
fusion->ld_map[(instance->map_id & 1)];
> + ld_count = (u16)le16_to_cpu(fw_map_ext->ldCount);
> + if (ld_count > MAX_LOGICAL_DRIVES_EXT) {
> + printk(KERN_DEBUG "megaraid_sas: LD count exposed
in RAID map in not valid\n");
> + return;
> + }
> +#if VD_EXT_DEBUG
> + for (i = 0; i < ld_count; i++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) :Index 0x%x
Target Id 0x%x Seq Num 0x%x Size 0/%llx\n",
> + instance->unique_id,
> + i,
fw_map_ext->ldSpanMap[i].ldRaid.targetId,
> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
> + fw_map_ext->ldSpanMap[i].ldRaid.size);
> + }
> +#endif
> +
> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> + pDrvRaidMap->fpPdIoTimeoutSec =
> +
fw_map_ext->fpPdIoTimeoutSec;
> + for (i = 0; i < (MAX_LOGICAL_DRIVES_EXT); i++)
> + pDrvRaidMap->ldTgtIdToLd[i] =
> + (u16)fw_map_ext->ldTgtIdToLd[i];
> + memcpy(pDrvRaidMap->ldSpanMap,
> + fw_map_ext->ldSpanMap,
> + sizeof(struct MR_LD_SPAN_MAP) *
> + ld_count);
> +#if VD_EXT_DEBUG
> + for (i = 0; i < ld_count; i++) {
> + printk(KERN_DEBUG "megaraid_sas(%d) :
fw_map_ext->ldSpanMap[%d].ldRaid.targetId 0x%x
fw_map_ext->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
> + i, i, fw_map_ext->ldSpanMap[i].ldRaid.targetId, i,
> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
> + (u32)fw_map_ext->ldSpanMap[i].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) :
pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x"
> + "pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x
size 0x%x\n",
> + i, i, pDrvRaidMap->ldSpanMap[i].ldRaid.targetId,
i,
> + pDrvRaidMap->ldSpanMap[i].ldRaid.seqNum,
> + (u32)pDrvRaidMap->ldSpanMap[i].ldRaid.rowSize);
> + printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map
all %p raid map %p LD RAID MAP %p %p\n",
> + instance->unique_id, drv_map, pDrvRaidMap,
> + &fw_map_ext->ldSpanMap[i].ldRaid,
> + &pDrvRaidMap->ldSpanMap[i].ldRaid);
> + }
> +#endif
> + memcpy(pDrvRaidMap->arMapInfo, fw_map_ext->arMapInfo,
> + sizeof(struct MR_ARRAY_INFO) *
MAX_API_ARRAYS_EXT);
> + memcpy(pDrvRaidMap->devHndlInfo, fw_map_ext->devHndlInfo,
> + sizeof(struct MR_DEV_HANDLE_INFO) *
> + MAX_RAIDMAP_PHYSICAL_DEVICES);
>
> - if (instance->supportmax256vd) {
> - memcpy(fusion->ld_drv_map[instance->map_id & 1],
> - fusion->ld_map[instance->map_id & 1],
> - fusion->current_map_sz);
> /* New Raid map will not set totalSize, so keep expected
value
> * for legacy code in ValidateMapInfo
> */
> @@ -213,16 +399,12 @@ void MR_PopulateDrvRaidMap(struct megasas_instance
*instance)
> }
> #endif
>
> - memset(drv_map, 0, fusion->drv_map_sz);
> pDrvRaidMap->totalSize = pFwRaidMap->totalSize;
> pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
> pDrvRaidMap->fpPdIoTimeoutSec =
pFwRaidMap->fpPdIoTimeoutSec;
> for (i = 0; i < MAX_RAIDMAP_LOGICAL_DRIVES +
MAX_RAIDMAP_VIEWS; i++)
> pDrvRaidMap->ldTgtIdToLd[i] =
> (u8)pFwRaidMap->ldTgtIdToLd[i];
> - for (i = (MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS);
> - i < MAX_LOGICAL_DRIVES_EXT; i++)
> - pDrvRaidMap->ldTgtIdToLd[i] = 0xff;
> for (i = 0; i < ld_count; i++) {
> pDrvRaidMap->ldSpanMap[i] =
pFwRaidMap->ldSpanMap[i];
> #if VD_EXT_DEBUG
> @@ -279,7 +461,9 @@ u8 MR_ValidateMapInfo(struct megasas_instance
*instance)
> lbInfo = fusion->load_balance_info;
> ldSpanInfo = fusion->log_to_span;
>
> - if (instance->supportmax256vd)
> + if (instance->max_raid_mapsize)
> + expected_size = sizeof(struct MR_DRV_RAID_MAP_ALL);
> + else if (instance->supportmax256vd)
> expected_size = sizeof(struct MR_FW_RAID_MAP_EXT);
> else
> expected_size =
> @@ -287,8 +471,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance
*instance)
> (sizeof(struct MR_LD_SPAN_MAP) *
le16_to_cpu(pDrvRaidMap->ldCount)));
>
> if (le32_to_cpu(pDrvRaidMap->totalSize) != expected_size) {
> - dev_err(&instance->pdev->dev, "map info structure size
0x%x is not matching with ld count\n",
> - (unsigned int) expected_size);
> + dev_err(&instance->pdev->dev, "megasas: map info
structure"
> + " size 0x%x is not matching expected size 0x%x\n",
> + le32_to_cpu(pDrvRaidMap->totalSize),
> + (unsigned int) expected_size);
> dev_err(&instance->pdev->dev, "megasas: span map %x,
pDrvRaidMap->totalSize : %x\n",
> (unsigned int)sizeof(struct MR_LD_SPAN_MAP),
> le32_to_cpu(pDrvRaidMap->totalSize));
> @@ -787,7 +973,7 @@ static u8 mr_spanset_get_phy_params(struct
megasas_instance *instance, u32 ld,
> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
> ((fusion->adapter_type == INVADER_SERIES) &&
> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
> - pRAID_Context->regLockFlags =
REGION_TYPE_EXCLUSIVE;
> + pRAID_Context->reg_lock_flags =
REGION_TYPE_EXCLUSIVE;
> else if (raid->level == 1) {
> physArm = physArm + 1;
> pd = MR_ArPdGet(arRef, physArm, map);
> @@ -797,9 +983,16 @@ static u8 mr_spanset_get_phy_params(struct
megasas_instance *instance, u32 ld,
> }
>
> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
map)->startBlk);
> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> - physArm;
> - io_info->span_arm = pRAID_Context->spanArm;
> + if (instance->is_ventura) {
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + } else {
> + pRAID_Context->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm = pRAID_Context->span_arm;
> + }
> return retval;
> }
>
> @@ -891,7 +1084,7 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
> ((fusion->adapter_type == INVADER_SERIES) &&
> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
> - pRAID_Context->regLockFlags =
REGION_TYPE_EXCLUSIVE;
> + pRAID_Context->reg_lock_flags =
REGION_TYPE_EXCLUSIVE;
> else if (raid->level == 1) {
> /* Get alternate Pd. */
> physArm = physArm + 1;
> @@ -903,9 +1096,16 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> }
>
> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
map)->startBlk);
> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> - physArm;
> - io_info->span_arm = pRAID_Context->spanArm;
> + if (instance->is_ventura) {
> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
physArm;
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
physArm;
> + } else {
> + pRAID_Context->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
> + io_info->span_arm = pRAID_Context->span_arm;
> + }
> return retval;
> }
>
> @@ -1109,20 +1309,20 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> regSize += stripSize;
> }
>
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16(raid->fpIoTimeoutForLd ?
> raid->fpIoTimeoutForLd :
> map->raidMap.fpPdIoTimeoutSec);
> if (fusion->adapter_type == INVADER_SERIES)
> - pRAID_Context->regLockFlags = (isRead) ?
> + pRAID_Context->reg_lock_flags = (isRead) ?
> raid->regTypeReqOnRead : raid->regTypeReqOnWrite;
> - else
> - pRAID_Context->regLockFlags = (isRead) ?
> + else if (!instance->is_ventura)
> + pRAID_Context->reg_lock_flags = (isRead) ?
> REGION_TYPE_SHARED_READ : raid->regTypeReqOnWrite;
> - pRAID_Context->VirtualDiskTgtId = raid->targetId;
> - pRAID_Context->regLockRowLBA = cpu_to_le64(regStart);
> - pRAID_Context->regLockLength = cpu_to_le32(regSize);
> - pRAID_Context->configSeqNum = raid->seqNum;
> + pRAID_Context->virtual_disk_tgt_id = raid->targetId;
> + pRAID_Context->reg_lock_row_lba = cpu_to_le64(regStart);
> + pRAID_Context->reg_lock_length = cpu_to_le32(regSize);
> + pRAID_Context->config_seq_num = raid->seqNum;
> /* save pointer to raid->LUN array */
> *raidLUN = raid->LUN;
>
> @@ -1140,6 +1340,14 @@ u8 MR_GetPhyParams(struct megasas_instance
*instance, u32 ld, u64 stripRow,
> /* If IO on an invalid Pd, then FP is not possible.*/
> if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
> io_info->fpOkForIo = FALSE;
> + /* if FP possible, set the SLUD bit in
> + * regLockFlags for ventura
> + */
> + else if ((instance->is_ventura) && !isRead &&
> + (raid->writeMode == MR_RL_WRITE_BACK_MODE)
&&
> + raid->capability.fp_cache_bypass_capable)
> + ((struct RAID_CONTEXT_G35 *)
pRAID_Context)->routing_flags.bits.sld
> + = 1;
> /* set raid 1/10 fast path write capable bit in io_info */
> if (io_info->fpOkForIo &&
> (io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
> @@ -1319,6 +1527,7 @@ u8 megasas_get_best_arm_pd(struct megasas_instance
*instance,
> struct fusion_context *fusion;
> struct MR_LD_RAID *raid;
> struct MR_DRV_RAID_MAP_ALL *drv_map;
> + u16 pd1_dev_handle;
> u16 pend0, pend1, ld;
> u64 diff0, diff1;
> u8 bestArm, pd0, pd1, span, arm;
> @@ -1344,23 +1553,37 @@ u8 megasas_get_best_arm_pd(struct
megasas_instance *instance,
> pd1 = MR_ArPdGet(arRef, (arm + 1) >= span_row_size ?
> (arm + 1 - span_row_size) : arm + 1, drv_map);
>
> - /* get the pending cmds for the data and mirror arms */
> - pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
> - pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
> + /* Get PD1 Dev Handle */
>
> - /* Determine the disk whose head is nearer to the req. block */
> - diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
> - diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
> - bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
> + pd1_dev_handle = MR_PdDevHandleGet(pd1, drv_map);
>
> - if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
> + if (pd1_dev_handle == MR_PD_INVALID) {
> + bestArm = arm;
> + } else {
> + /* get the pending cmds for the data and mirror arms */
> + pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
> + pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
> +
> + /* Determine the disk whose head is nearer to the req.
block */
> + diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
> + diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
> + /*bestArm = diff0<=diff1 ? arm : arm ^ 1;*/
> + bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
The above comment is useless and the parentheses not needed,
again please clean it up in a next series.
Sasi - This shall be fixed in V5 patch
tomash
> +
> + /* Make balance count from 16 to 4 to
> + * keep driver in sync with Firmware
> + */
> + if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds)
||
> (bestArm != arm && pend1 > pend0 +
lb_pending_cmds))
> - bestArm ^= 1;
> + bestArm ^= 1;
> +
> + /* Update the last accessed block on the correct pd */
> + io_info->span_arm =
> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
> + io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
> + }
>
> - /* Update the last accessed block on the correct pd */
> - io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
> lbInfo->last_accessed_block[io_info->pd_after_lb] = block + count
- 1;
> - io_info->span_arm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
bestArm;
> #if SPAN_DEBUG
> if (arm != bestArm)
> dev_dbg(&instance->pdev->dev, "LSI Debug R1 Load balance "
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 2fcd5cd..58f86aa 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -1834,7 +1834,7 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> struct megasas_cmd_fusion *cmd)
> {
> u8 fp_possible;
> - u32 start_lba_lo, start_lba_hi, device_id, datalength = 0;
> + u32 start_lba_lo, start_lba_hi, device_id, datalength = 0, ld;
> struct MPI2_RAID_SCSI_IO_REQUEST *io_request;
> union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
> struct IO_REQUEST_INFO io_info;
> @@ -1842,16 +1842,18 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> u8 *raidLUN;
> unsigned long spinlock_flags;
> + union RAID_CONTEXT_UNION *praid_context;
> + struct MR_LD_RAID *raid;
>
> device_id = MEGASAS_DEV_INDEX(scp);
>
> fusion = instance->ctrl_context;
>
> io_request = cmd->io_request;
> - io_request->RaidContext.raid_context.VirtualDiskTgtId =
> + io_request->RaidContext.raid_context.virtual_disk_tgt_id =
> cpu_to_le16(device_id);
> io_request->RaidContext.raid_context.status = 0;
> - io_request->RaidContext.raid_context.exStatus = 0;
> + io_request->RaidContext.raid_context.ex_status = 0;
>
> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION
*)cmd->request_desc;
>
> @@ -1920,10 +1922,12 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> io_info.isRead = 1;
>
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
> + raid = MR_LdRaidGet(ld, local_map_ptr);
>
> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
> instance->fw_supported_vd_count) ||
(!fusion->fast_path_io)) {
> - io_request->RaidContext.raid_context.regLockFlags = 0;
> + io_request->RaidContext.raid_context.reg_lock_flags = 0;
> fp_possible = 0;
> } else {
> if (MR_BuildRaidContext(instance, &io_info,
> @@ -1950,6 +1954,8 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> fp_possible = false;
> }
>
> + praid_context = &io_request->RaidContext;
> +
> if (fp_possible) {
> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info,
scp,
> local_map_ptr, start_lba_lo);
> @@ -1958,18 +1964,26 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> - if
(io_request->RaidContext.raid_context.regLockFlags ==
> + if
(io_request->RaidContext.raid_context.reg_lock_flags ==
> REGION_TYPE_UNUSED)
> cmd->request_desc->SCSIIO.RequestFlags =
>
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
>
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.raid_context.Type
> + io_request->RaidContext.raid_context.type
> = MPI2_TYPE_CUDA;
> io_request->RaidContext.raid_context.nseg = 0x1;
> io_request->IoFlags |=
cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> - io_request->RaidContext.raid_context.regLockFlags
|=
> +
io_request->RaidContext.raid_context.reg_lock_flags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> + } else if (instance->is_ventura) {
> + io_request->RaidContext.raid_context_g35.type
> + = MPI2_TYPE_CUDA;
> + io_request->RaidContext.raid_context_g35.nseg =
0x1;
> +
io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + io_request->IoFlags |=
> +
cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
> }
> if ((fusion->load_balance_info[device_id].loadBalanceFlag)
&&
> (io_info.isRead)) {
> @@ -1979,6 +1993,13 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> &io_info);
> scp->SCp.Status |= MEGASAS_LOAD_BALANCE_FLAG;
> cmd->pd_r1_lb = io_info.pd_after_lb;
> + if (instance->is_ventura)
> +
io_request->RaidContext.raid_context_g35.span_arm
> + = io_info.span_arm;
> + else
> +
io_request->RaidContext.raid_context.span_arm
> + = io_info.span_arm;
> +
> } else
> scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
>
> @@ -1997,28 +2018,98 @@ static void megasas_stream_detect(struct
megasas_instance *instance,
> io_request->DevHandle = io_info.devHandle;
> /* populate the LUN field */
> memcpy(io_request->LUN, raidLUN, 8);
> + if (instance->is_ventura) {
> + if (io_info.isRead) {
> + if ((raid->cpuAffinity.pdRead.cpu0) &&
> + (raid->cpuAffinity.pdRead.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.pdRead.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.pdWrite.cpu0)
> + && (raid->cpuAffinity.pdWrite.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.pdWrite.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + if
(praid_context->raid_context_g35.routing_flags.bits.sld) {
> +
praid_context->raid_context_g35.raid_flags
> + =
(MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
> + <<
MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
> + }
> + }
> + }
> } else {
> - io_request->RaidContext.raid_context.timeoutValue =
> + io_request->RaidContext.raid_context.timeout_value =
>
cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> if (fusion->adapter_type == INVADER_SERIES) {
> if (io_info.do_fp_rlbypass ||
> - (io_request->RaidContext.raid_context.regLockFlags
> +
(io_request->RaidContext.raid_context.reg_lock_flags
> == REGION_TYPE_UNUSED))
> cmd->request_desc->SCSIIO.RequestFlags =
>
(MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
>
MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - io_request->RaidContext.raid_context.Type
> + io_request->RaidContext.raid_context.type
> = MPI2_TYPE_CUDA;
> - io_request->RaidContext.raid_context.regLockFlags
|=
> +
io_request->RaidContext.raid_context.reg_lock_flags |=
> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
> MR_RL_FLAGS_SEQ_NUM_ENABLE);
> io_request->RaidContext.raid_context.nseg = 0x1;
> + } else if (instance->is_ventura) {
> + io_request->RaidContext.raid_context_g35.type
> + = MPI2_TYPE_CUDA;
> +
io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + io_request->RaidContext.raid_context_g35.nseg =
0x1;
> }
> io_request->Function =
MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> +
> + if (instance->is_ventura) {
> + if (io_info.isRead) {
> + if ((raid->cpuAffinity.ldRead.cpu0)
> + && (raid->cpuAffinity.ldRead.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldRead.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.ldWrite.cpu0) &&
> + (raid->cpuAffinity.ldWrite.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + =
MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldWrite.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> +
> + if
(io_request->RaidContext.raid_context_g35.stream_detected
> + && (raid->level == 5)
> + && (raid->writeMode ==
MR_RL_WRITE_THROUGH_MODE)) {
> + if
(praid_context->raid_context_g35.routing_flags.bits.cpu_sel ==
MR_RAID_CTX_CPUSEL_FCFS)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + =
MR_RAID_CTX_CPUSEL_0;
> + }
> + }
> + }
> } /* Not FP */
> }
>
> @@ -2053,9 +2144,9 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> /* get RAID_Context pointer */
> pRAID_Context = &io_request->RaidContext.raid_context;
> /* Check with FW team */
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->regLockRowLBA = 0;
> - pRAID_Context->regLockLength = 0;
> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
> + pRAID_Context->reg_lock_row_lba = 0;
> + pRAID_Context->reg_lock_length = 0;
>
> if (fusion->fast_path_io && (
> device_id < instance->fw_supported_vd_count)) {
> @@ -2074,7 +2165,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> io_request->Function =
MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
> io_request->DevHandle = cpu_to_le16(device_id);
> io_request->LUN[1] = scmd->device->lun;
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16 (scmd->request->timeout / HZ);
> cmd->request_desc->SCSIIO.RequestFlags =
> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
> @@ -2082,9 +2173,10 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> } else {
>
> /* set RAID context values */
> - pRAID_Context->configSeqNum = raid->seqNum;
> - pRAID_Context->regLockFlags = REGION_TYPE_SHARED_READ;
> - pRAID_Context->timeoutValue =
cpu_to_le16(raid->fpIoTimeoutForLd);
> + pRAID_Context->config_seq_num = raid->seqNum;
> + if (!instance->is_ventura)
> + pRAID_Context->reg_lock_flags =
REGION_TYPE_SHARED_READ;
> + pRAID_Context->timeout_value =
cpu_to_le16(raid->fpIoTimeoutForLd);
>
> /* get the DevHandle for the PD (since this is
> fpNonRWCapable, this is a single disk RAID0) */
> @@ -2139,12 +2231,12 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> io_request = cmd->io_request;
> /* get RAID_Context pointer */
> pRAID_Context = &io_request->RaidContext.raid_context;
> - pRAID_Context->regLockFlags = 0;
> - pRAID_Context->regLockRowLBA = 0;
> - pRAID_Context->regLockLength = 0;
> + pRAID_Context->reg_lock_flags = 0;
> + pRAID_Context->reg_lock_row_lba = 0;
> + pRAID_Context->reg_lock_length = 0;
> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
> io_request->LUN[1] = scmd->device->lun;
> - pRAID_Context->RAIDFlags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
> + pRAID_Context->raid_flags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
> << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
>
> /* If FW supports PD sequence number */
> @@ -2153,24 +2245,28 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> /* TgtId must be incremented by 255 as jbod seq number is
index
> * below raid map
> */
> - pRAID_Context->VirtualDiskTgtId =
> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id + (MAX_PHYSICAL_DEVICES -
1));
> - pRAID_Context->configSeqNum =
pd_sync->seq[pd_index].seqNum;
> + pRAID_Context->config_seq_num =
pd_sync->seq[pd_index].seqNum;
> io_request->DevHandle = pd_sync->seq[pd_index].devHandle;
> - pRAID_Context->regLockFlags |=
> + if (instance->is_ventura)
> +
io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
> + = 1;
> + else
> + pRAID_Context->reg_lock_flags |=
>
(MR_RL_FLAGS_SEQ_NUM_ENABLE|MR_RL_FLAGS_GRANT_DESTINATION_CUDA);
> - pRAID_Context->Type = MPI2_TYPE_CUDA;
> + pRAID_Context->type = MPI2_TYPE_CUDA;
> pRAID_Context->nseg = 0x1;
> } else if (fusion->fast_path_io) {
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->configSeqNum = 0;
> + pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id);
> + pRAID_Context->config_seq_num = 0;
> local_map_ptr = fusion->ld_drv_map[(instance->map_id &
1)];
> io_request->DevHandle =
>
local_map_ptr->raidMap.devHndlInfo[device_id].curDevHdl;
> } else {
> /* Want to send all IO via FW path */
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> - pRAID_Context->configSeqNum = 0;
> + pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id);
> + pRAID_Context->config_seq_num = 0;
> io_request->DevHandle = cpu_to_le16(0xFFFF);
> }
>
> @@ -2186,14 +2282,14 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> cmd->request_desc->SCSIIO.RequestFlags =
> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
> - pRAID_Context->timeoutValue =
cpu_to_le16(os_timeout_value);
> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
> + pRAID_Context->timeout_value =
cpu_to_le16(os_timeout_value);
> + pRAID_Context->virtual_disk_tgt_id =
cpu_to_le16(device_id);
> } else {
> /* system pd Fast Path */
> io_request->Function = MPI2_FUNCTION_SCSI_IO_REQUEST;
> timeout_limit = (scmd->device->type == TYPE_DISK) ?
> 255 : 0xFFFF;
> - pRAID_Context->timeoutValue =
> + pRAID_Context->timeout_value =
> cpu_to_le16((os_timeout_value > timeout_limit) ?
> timeout_limit : os_timeout_value);
> if (fusion->adapter_type == INVADER_SERIES)
> @@ -2232,8 +2328,8 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> io_request->Control = 0;
> io_request->EEDPBlockSize = 0;
> io_request->ChainOffset = 0;
> - io_request->RaidContext.raid_context.RAIDFlags = 0;
> - io_request->RaidContext.raid_context.Type = 0;
> + io_request->RaidContext.raid_context.raid_flags = 0;
> + io_request->RaidContext.raid_context.type = 0;
> io_request->RaidContext.raid_context.nseg = 0;
>
> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
> @@ -2278,11 +2374,16 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> return 1;
> }
>
> - /* numSGE store lower 8 bit of sge_count.
> - * numSGEExt store higher 8 bit of sge_count
> - */
> - io_request->RaidContext.raid_context.numSGE = sge_count;
> - io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >>
8);
> + if (instance->is_ventura)
> + io_request->RaidContext.raid_context_g35.num_sge =
sge_count;
> + else {
> + /* numSGE store lower 8 bit of sge_count.
> + * numSGEExt store higher 8 bit of sge_count
> + */
> + io_request->RaidContext.raid_context.num_sge = sge_count;
> + io_request->RaidContext.raid_context.num_sge_ext =
> + (u8)(sge_count >> 8);
> + }
>
> io_request->SGLFlags =
cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>
> @@ -2331,6 +2432,10 @@ void megasas_fpio_to_ldio(struct megasas_instance
*instance,
> struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
> {
> struct fusion_context *fusion;
> + union RAID_CONTEXT_UNION *praid_context;
> + struct MR_LD_RAID *raid;
> + struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
> + u32 device_id, ld;
> fusion = instance->ctrl_context;
>
> cmd->request_desc->SCSIIO.RequestFlags =
> @@ -2354,6 +2459,35 @@ void megasas_fpio_to_ldio(struct megasas_instance
*instance,
> cmd->io_request->Control = 0;
> cmd->io_request->EEDPBlockSize = 0;
> cmd->is_raid_1_fp_write = 0;
> +
> + device_id = MEGASAS_DEV_INDEX(cmd->scmd);
> + local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
> + raid = MR_LdRaidGet(ld, local_map_ptr);
> + praid_context = &cmd->io_request->RaidContext;
> + if (cmd->scmd->sc_data_direction == PCI_DMA_FROMDEVICE) {
> + if ((raid->cpuAffinity.ldRead.cpu0)
> + && (raid->cpuAffinity.ldRead.cpu1))
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldRead.cpu1)
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> +
praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + } else {
> + if ((raid->cpuAffinity.ldWrite.cpu0)
> + && (raid->cpuAffinity.ldWrite.cpu1))
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_FCFS;
> + else if (raid->cpuAffinity.ldWrite.cpu1)
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_1;
> + else
> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
> + = MR_RAID_CTX_CPUSEL_0;
> + }
> }
> /*megasas_prepate_secondRaid1_IO
> * It prepares the raid 1 second IO
> @@ -2491,6 +2625,7 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> * corresponds to single R1/10 LD are always same
> *
> */
> +
> /* driver side count always should be less than max_fw_cmds
> * to get new command
> */
> @@ -2588,7 +2723,7 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
>
> scmd_local = cmd_fusion->scmd;
> status = scsi_io_req->RaidContext.raid_context.status;
> - extStatus =
scsi_io_req->RaidContext.raid_context.exStatus;
> + extStatus =
scsi_io_req->RaidContext.raid_context.ex_status;
> sense = cmd_fusion->sense;
> data_length = scsi_io_req->DataLength;
>
> @@ -2656,13 +2791,13 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> status =
>
r1_cmd->io_request->RaidContext.raid_context.status;
> extStatus =
> -
r1_cmd->io_request->RaidContext.raid_context.exStatus;
> +
r1_cmd->io_request->RaidContext.raid_context.ex_status;
> data_length =
>
r1_cmd->io_request->DataLength;
> sense = r1_cmd->sense;
> }
>
r1_cmd->io_request->RaidContext.raid_context.status = 0;
> -
r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
> +
r1_cmd->io_request->RaidContext.raid_context.ex_status = 0;
> cmd_fusion->is_raid_1_fp_write = 0;
> r1_cmd->is_raid_1_fp_write = 0;
> r1_cmd->cmd_completed = false;
> @@ -2674,7 +2809,7 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> extStatus, data_length, sense);
>
scsi_io_req->RaidContext.raid_context.status
> = 0;
> -
scsi_io_req->RaidContext.raid_context.exStatus
> +
scsi_io_req->RaidContext.raid_context.ex_status
> = 0;
> megasas_return_cmd_fusion(instance,
cmd_fusion);
> scsi_dma_unmap(scmd_local);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index 5590c1d..cb42655 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -59,6 +59,8 @@
> #define MR_RL_FLAGS_GRANT_DESTINATION_CPU1 0x10
> #define MR_RL_FLAGS_GRANT_DESTINATION_CUDA 0x80
> #define MR_RL_FLAGS_SEQ_NUM_ENABLE 0x8
> +#define MR_RL_WRITE_THROUGH_MODE 0x00
> +#define MR_RL_WRITE_BACK_MODE 0x01
>
> /* T10 PI defines */
> #define MR_PROT_INFO_TYPE_CONTROLLER 0x8
> @@ -81,6 +83,11 @@
> enum MR_RAID_FLAGS_IO_SUB_TYPE {
> MR_RAID_FLAGS_IO_SUB_TYPE_NONE = 0,
> MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD = 1,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_DATA = 2,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_P = 3,
> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_Q = 4,
> + MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS = 6,
> + MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT = 7
> };
>
> /*
> @@ -109,29 +116,29 @@ enum MR_FUSION_ADAPTER_TYPE {
>
> struct RAID_CONTEXT {
> #if defined(__BIG_ENDIAN_BITFIELD)
> - u8 nseg:4;
> - u8 Type:4;
> + u8 nseg:4;
> + u8 type:4;
> #else
> - u8 Type:4;
> - u8 nseg:4;
> + u8 type:4;
> + u8 nseg:4;
> #endif
> - u8 resvd0;
> - __le16 timeoutValue;
> - u8 regLockFlags;
> - u8 resvd1;
> - __le16 VirtualDiskTgtId;
> - __le64 regLockRowLBA;
> - __le32 regLockLength;
> - __le16 nextLMId;
> - u8 exStatus;
> - u8 status;
> - u8 RAIDFlags;
> - u8 numSGE;
> - __le16 configSeqNum;
> - u8 spanArm;
> - u8 priority;
> - u8 numSGEExt;
> - u8 resvd2;
> + u8 resvd0;
> + __le16 timeout_value;
> + u8 reg_lock_flags;
> + u8 resvd1;
> + __le16 virtual_disk_tgt_id;
> + __le64 reg_lock_row_lba;
> + __le32 reg_lock_length;
> + __le16 next_lmid;
> + u8 ex_status;
> + u8 status;
> + u8 raid_flags;
> + u8 num_sge;
> + __le16 config_seq_num;
> + u8 span_arm;
> + u8 priority;
> + u8 num_sge_ext;
> + u8 resvd2;
> };
>
> /*
> @@ -187,7 +194,7 @@ struct RAID_CONTEXT_G35 {
> } smid;
> u8 ex_status; /* 0x16 : OUT */
> u8 status; /* 0x17 status */
> - u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
> + u8 raid_flags; /* 0x18 resvd[7:6], ioSubType[5:4],
> * resvd[3:1],
preferredCpu[0]
> */
> u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
> @@ -672,14 +679,17 @@ struct MPI2_IOC_INIT_REQUEST {
> #define MAX_RAIDMAP_ROW_SIZE (MAX_ROW_SIZE)
> #define MAX_LOGICAL_DRIVES 64
> #define MAX_LOGICAL_DRIVES_EXT 256
> +#define MAX_LOGICAL_DRIVES_DYN 512
> #define MAX_RAIDMAP_LOGICAL_DRIVES (MAX_LOGICAL_DRIVES)
> #define MAX_RAIDMAP_VIEWS (MAX_LOGICAL_DRIVES)
> #define MAX_ARRAYS 128
> #define MAX_RAIDMAP_ARRAYS (MAX_ARRAYS)
> #define MAX_ARRAYS_EXT 256
> #define MAX_API_ARRAYS_EXT (MAX_ARRAYS_EXT)
> +#define MAX_API_ARRAYS_DYN 512
> #define MAX_PHYSICAL_DEVICES 256
> #define MAX_RAIDMAP_PHYSICAL_DEVICES (MAX_PHYSICAL_DEVICES)
> +#define MAX_RAIDMAP_PHYSICAL_DEVICES_DYN 512
> #define MR_DCMD_LD_MAP_GET_INFO 0x0300e101
> #define MR_DCMD_SYSTEM_PD_MAP_GET_INFO 0x0200e102
> #define MR_DCMD_CTRL_SHARED_HOST_MEM_ALLOC 0x010e8485 /* SR-IOV HB
alloc*/
> @@ -726,12 +736,56 @@ struct MR_SPAN_BLOCK_INFO {
> struct MR_SPAN_INFO block_span_info;
> };
>
> +#define MR_RAID_CTX_CPUSEL_0 0
> +#define MR_RAID_CTX_CPUSEL_1 1
> +#define MR_RAID_CTX_CPUSEL_2 2
> +#define MR_RAID_CTX_CPUSEL_3 3
> +#define MR_RAID_CTX_CPUSEL_FCFS 0xF
> +
> +struct MR_CPU_AFFINITY_MASK {
> + union {
> + struct {
> +#ifndef MFI_BIG_ENDIAN
> + u8 hw_path:1;
> + u8 cpu0:1;
> + u8 cpu1:1;
> + u8 cpu2:1;
> + u8 cpu3:1;
> + u8 reserved:3;
> +#else
> + u8 reserved:3;
> + u8 cpu3:1;
> + u8 cpu2:1;
> + u8 cpu1:1;
> + u8 cpu0:1;
> + u8 hw_path:1;
> +#endif
> + };
> + u8 core_mask;
> + };
> +};
> +
> +struct MR_IO_AFFINITY {
> + union {
> + struct {
> + struct MR_CPU_AFFINITY_MASK pdRead;
> + struct MR_CPU_AFFINITY_MASK pdWrite;
> + struct MR_CPU_AFFINITY_MASK ldRead;
> + struct MR_CPU_AFFINITY_MASK ldWrite;
> + };
> + u32 word;
> + };
> + u8 maxCores; /* Total cores + HW Path in ROC */
> + u8 reserved[3];
> +};
> +
> struct MR_LD_RAID {
> struct {
> #if defined(__BIG_ENDIAN_BITFIELD)
> - u32 reserved4:3;
> - u32 fp_cache_bypass_capable:1;
> - u32 fp_rmw_capable:1;
> + u32 reserved4:2;
> + u32 fp_cache_bypass_capable:1;
> + u32 fp_rmw_capable:1;
> + u32 disable_coalescing:1;
> u32 fpBypassRegionLock:1;
> u32 tmCapable:1;
> u32 fpNonRWCapable:1;
> @@ -759,9 +813,10 @@ struct MR_LD_RAID {
> u32 fpNonRWCapable:1;
> u32 tmCapable:1;
> u32 fpBypassRegionLock:1;
> - u32 fp_rmw_capable:1;
> - u32 fp_cache_bypass_capable:1;
> - u32 reserved4:3;
> + u32 disable_coalescing:1;
> + u32 fp_rmw_capable:1;
> + u32 fp_cache_bypass_capable:1;
> + u32 reserved4:2;
> #endif
> } capability;
> __le32 reserved6;
> @@ -788,7 +843,36 @@ struct MR_LD_RAID {
>
> u8 LUN[8]; /* 0x24 8 byte LUN field used for SCSI IO's */
> u8 fpIoTimeoutForLd;/*0x2C timeout value used by driver in FP
IO*/
> - u8 reserved3[0x80-0x2D]; /* 0x2D */
> + /* Ox2D This LD accept priority boost of this type */
> + u8 ld_accept_priority_type;
> + u8 reserved2[2]; /* 0x2E - 0x2F */
> + /* 0x30 - 0x33, Logical block size for the LD */
> + u32 logical_block_length;
> + struct {
> +#ifndef MFI_BIG_ENDIAN
> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
> + u32 ld_pi_exp:4;
> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
> + * BLOCK EXPONENT from READ CAPACITY 16
> + */
> + u32 ld_logical_block_exp:4;
> + u32 reserved1:24; /* 0x34 */
> +#else
> + u32 reserved1:24; /* 0x34 */
> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
> + * BLOCK EXPONENT from READ CAPACITY 16
> + */
> + u32 ld_logical_block_exp:4;
> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
> + u32 ld_pi_exp:4;
> +#endif
> + }; /* 0x34 - 0x37 */
> + /* 0x38 - 0x3f, This will determine which
> + * core will process LD IO and PD IO.
> + */
> + struct MR_IO_AFFINITY cpuAffinity;
> + /* Bit definiations are specified by MR_IO_AFFINITY */
> + u8 reserved3[0x80-0x40]; /* 0x40 - 0x7f */
> };
>
> struct MR_LD_SPAN_MAP {
> @@ -846,6 +930,91 @@ struct MR_LD_TARGET_SYNC {
> __le16 seqNum;
> };
>
> +/*
> +* RAID Map descriptor Types.
> +* Each element should uniquely idetify one data structure in the RAID
map
> +*/
> +enum MR_RAID_MAP_DESC_TYPE {
> + /* MR_DEV_HANDLE_INFO data */
> + RAID_MAP_DESC_TYPE_DEVHDL_INFO = 0x0,
> + /* target to Ld num Index map */
> + RAID_MAP_DESC_TYPE_TGTID_INFO = 0x1,
> + /* MR_ARRAY_INFO data */
> + RAID_MAP_DESC_TYPE_ARRAY_INFO = 0x2,
> + /* MR_LD_SPAN_MAP data */
> + RAID_MAP_DESC_TYPE_SPAN_INFO = 0x3,
> + RAID_MAP_DESC_TYPE_COUNT,
> +};
> +
> +/*
> +* This table defines the offset, size and num elements of each
descriptor
> +* type in the RAID Map buffer
> +*/
> +struct MR_RAID_MAP_DESC_TABLE {
> + /* Raid map descriptor type */
> + u32 raid_map_desc_type;
> + /* Offset into the RAID map buffer where
> + * descriptor data is saved
> + */
> + u32 raid_map_desc_offset;
> + /* total size of the
> + * descriptor buffer
> + */
> + u32 raid_map_desc_buffer_size;
> + /* Number of elements contained in the
> + * descriptor buffer
> + */
> + u32 raid_map_desc_elements;
> +};
> +
> +/*
> +* Dynamic Raid Map Structure.
> +*/
> +struct MR_FW_RAID_MAP_DYNAMIC {
> + u32 raid_map_size; /* total size of RAID Map structure */
> + u32 desc_table_offset;/* Offset of desc table into RAID map*/
> + u32 desc_table_size; /* Total Size of desc table */
> + /* Total Number of elements in the desc table */
> + u32 desc_table_num_elements;
> + u64 reserved1;
> + u32 reserved2[3]; /*future use */
> + /* timeout value used by driver in FP IOs */
> + u8 fp_pd_io_timeout_sec;
> + u8 reserved3[3];
> + /* when this seqNum increments, driver needs to
> + * release RMW buffers asap
> + */
> + u32 rmw_fp_seq_num;
> + u16 ld_count; /* count of lds. */
> + u16 ar_count; /* count of arrays */
> + u16 span_count; /* count of spans */
> + u16 reserved4[3];
> +/*
> +* The below structure of pointers is only to be used by the driver.
> +* This is added in the ,API to reduce the amount of code changes
> +* needed in the driver to support dynamic RAID map Firmware should
> +* not update these pointers while preparing the raid map
> +*/
> + union {
> + struct {
> + struct MR_DEV_HANDLE_INFO *dev_hndl_info;
> + u16 *ld_tgt_id_to_ld;
> + struct MR_ARRAY_INFO *ar_map_info;
> + struct MR_LD_SPAN_MAP *ld_span_map;
> + };
> + u64 ptr_structure_size[RAID_MAP_DESC_TYPE_COUNT];
> + };
> +/*
> +* RAID Map descriptor table defines the layout of data in the RAID Map.
> +* The size of the descriptor table itself could change.
> +*/
> + /* Variable Size descriptor Table. */
> + struct MR_RAID_MAP_DESC_TABLE
> + raid_map_desc_table[RAID_MAP_DESC_TYPE_COUNT];
> + /* Variable Size buffer containing all data */
> + u32 raid_map_desc_data[1];
> +}; /* Dynamicaly sized RAID MAp structure */
> +
> #define IEEE_SGE_FLAGS_ADDR_MASK (0x03)
> #define IEEE_SGE_FLAGS_SYSTEM_ADDR (0x00)
> #define IEEE_SGE_FLAGS_IOCDDR_ADDR (0x01)
> @@ -955,9 +1124,10 @@ struct MR_DRV_RAID_MAP {
> __le16 spanCount;
> __le16 reserve3;
>
> - struct MR_DEV_HANDLE_INFO
devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES];
> - u8 ldTgtIdToLd[MAX_LOGICAL_DRIVES_EXT];
> - struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_EXT];
> + struct MR_DEV_HANDLE_INFO
> + devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES_DYN];
> + u16 ldTgtIdToLd[MAX_LOGICAL_DRIVES_DYN];
> + struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_DYN];
> struct MR_LD_SPAN_MAP ldSpanMap[1];
>
> };
> @@ -969,7 +1139,7 @@ struct MR_DRV_RAID_MAP {
> struct MR_DRV_RAID_MAP_ALL {
>
> struct MR_DRV_RAID_MAP raidMap;
> - struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_EXT - 1];
> + struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_DYN - 1];
> } __packed;
>
>
> @@ -1088,7 +1258,7 @@ struct fusion_context {
> u8 chain_offset_io_request;
> u8 chain_offset_mfi_pthru;
>
> - struct MR_FW_RAID_MAP_ALL *ld_map[2];
> + struct MR_FW_RAID_MAP_DYNAMIC *ld_map[2];
> dma_addr_t ld_map_phys[2];
>
> /*Non dma-able memory. Driver local copy.*/
> @@ -1096,6 +1266,8 @@ struct fusion_context {
>
> u32 max_map_sz;
> u32 current_map_sz;
> + u32 old_map_sz;
> + u32 new_map_sz;
> u32 drv_map_sz;
> u32 drv_map_pages;
> struct MR_PD_CFG_SEQ_NUM_SYNC *pd_seq_sync[JBOD_MAPS_COUNT];
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
2016-12-20 1:51 ` Sasikumar PC
@ 2016-12-20 14:20 ` Tomas Henzl
2016-12-20 14:22 ` Sasikumar PC
0 siblings, 1 reply; 40+ messages in thread
From: Tomas Henzl @ 2016-12-20 14:20 UTC (permalink / raw)
To: Sasikumar PC, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
On 20.12.2016 02:51, Sasikumar PC wrote:
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Sasikumar PC [mailto:sasikumar.pc@broadcom.com]
> Sent: Wednesday, December 14, 2016 4:49 PM
> To: 'Tomas Henzl'; 'jejb@kernel.org'; 'hch@infradead.org'
> Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;
> 'linux-kernel@vger.kernel.org'; Christopher Owens; Kiran Kumar Kasturi
> Subject: RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
> SAS3.5 Generic Megaraid Controllers
>
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Friday, December 09, 2016 7:55 AM
> To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
> Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
> linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
> kiran-kumar.kasturi@broadcom.com
> Subject: Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
> SAS3.5 Generic Megaraid Controllers
>
> On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
>> SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap
> to have different
>> sizes for different number of supported VDs.
>>
>> This patch is depending on patch 5
>>
>> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
>> ---
>> drivers/scsi/megaraid/megaraid_sas.h | 7 +
>> drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++++--
>> drivers/scsi/megaraid/megaraid_sas_fp.c | 303
> ++++++++++++++++++++++++----
>> drivers/scsi/megaraid/megaraid_sas_fusion.c | 223 ++++++++++++++++----
>> drivers/scsi/megaraid/megaraid_sas_fusion.h | 240
> ++++++++++++++++++----
>> 5 files changed, 699 insertions(+), 135 deletions(-)
>>
>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
>> index f4d6a94..3e087ab 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>> @@ -1434,6 +1434,12 @@ enum FW_BOOT_CONTEXT {
>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
>> #define MR_MAX_MSIX_REG_ARRAY 16
>> #define MR_RDPQ_MODE_OFFSET 0X00800000
>> +
>> +#define MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT 16
>> +#define MR_MAX_RAID_MAP_SIZE_MASK 0x1FF
>> +#define MR_MIN_MAP_SIZE 0x10000
>> +/* 64k */
>> +
>> #define MR_CAN_HANDLE_SYNC_CACHE_OFFSET 0X01000000
>>
>> /*
>> @@ -2152,6 +2158,7 @@ struct megasas_instance {
>> bool fw_sync_cache_support;
>> bool is_ventura;
>> bool msix_combined;
>> + u16 max_raid_mapsize;
>> };
>> struct MR_LD_VF_MAP {
>> u32 size;
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
>> index c52f7be..3f06b57 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>> @@ -4424,8 +4424,7 @@ int megasas_alloc_cmds(struct megasas_instance
> *instance)
>> static void megasas_update_ext_vd_details(struct megasas_instance
> *instance)
>> {
>> struct fusion_context *fusion;
>> - u32 old_map_sz;
>> - u32 new_map_sz;
>> + u32 ventura_map_sz = 0;
>>
>> fusion = instance->ctrl_context;
>> /* For MFI based controllers return dummy success */
>> @@ -4455,21 +4454,39 @@ static void megasas_update_ext_vd_details(struct
> megasas_instance *instance)
>> instance->supportmax256vd ? "Extended VD(240 VD)firmware"
> :
>> "Legacy(64 VD) firmware");
>>
>> - old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
>> - (sizeof(struct MR_LD_SPAN_MAP) *
>> - (instance->fw_supported_vd_count - 1));
>> - new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>> - fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
>> - (sizeof(struct MR_LD_SPAN_MAP) *
>> - (instance->drv_supported_vd_count - 1));
>> -
>> - fusion->max_map_sz = max(old_map_sz, new_map_sz);
>> + if (instance->max_raid_mapsize) {
>> + ventura_map_sz = instance->max_raid_mapsize *
>> + MR_MIN_MAP_SIZE; /* 64k */
>> + fusion->current_map_sz = ventura_map_sz;
>> + fusion->max_map_sz = ventura_map_sz;
>> + } else {
>> + fusion->old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
>> + (sizeof(struct MR_LD_SPAN_MAP) *
>> + (instance->fw_supported_vd_count -
> 1));
>> + fusion->new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>>
>> + fusion->max_map_sz =
>> + max(fusion->old_map_sz, fusion->new_map_sz);
>>
>> - if (instance->supportmax256vd)
>> - fusion->current_map_sz = new_map_sz;
>> - else
>> - fusion->current_map_sz = old_map_sz;
>> + if (instance->supportmax256vd)
>> + fusion->current_map_sz = fusion->new_map_sz;
>> + else
>> + fusion->current_map_sz = fusion->old_map_sz;
>> + }
>> + /* irrespective of FW raid maps, driver raid map is constant */
>> + fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP_ALL);
>> +#if VD_EXT_DEBUG
>> + dev_info(&instance->pdev->dev, "instance->max_raid_mapsize 0x%x \n
> ",
>> + instance->max_raid_mapsize);
>> + dev_info(&instance->pdev->dev,
>> + "new_map_sz = 0x%x, old_map_sz = 0x%x, "
>> + "ventura_map_sz = 0x%x, current_map_sz = 0x%x "
>> + "fusion->drv_map_sz =0x%x, size of driver raid map 0x%lx\n",
>> + fusion->new_map_sz, fusion->old_map_sz,
>> + ventura_map_sz, fusion->current_map_sz,
>> + fusion->drv_map_sz,
>> + sizeof(struct MR_DRV_RAID_MAP_ALL));
>> +#endif
>> }
>>
>> /**
>> @@ -5010,7 +5027,7 @@ static int megasas_init_fw(struct megasas_instance
> *instance)
>> {
>> u32 max_sectors_1;
>> u32 max_sectors_2;
>> - u32 tmp_sectors, msix_enable, scratch_pad_2;
>> + u32 tmp_sectors, msix_enable, scratch_pad_2, scratch_pad_3;
>> resource_size_t base_addr;
>> struct megasas_register_set __iomem *reg_set;
>> struct megasas_ctrl_info *ctrl_info = NULL;
>> @@ -5086,7 +5103,17 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>> goto fail_ready_state;
>> }
>>
>> -
>> + if (instance->is_ventura) {
>> + scratch_pad_3 =
>> + readl(&instance->reg_set->outbound_scratch_pad_3);
>> +#if VD_EXT_DEBUG
>> + dev_info(&instance->pdev->dev, "scratch_pad3 0x%x\n",
>> + scratch_pad_3);
>> +#endif
>> + instance->max_raid_mapsize = ((scratch_pad_3 >>
>> + MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT) &
>> + MR_MAX_RAID_MAP_SIZE_MASK);
>> + }
>>
>> /* Check if MSI-X is supported while in ready state */
>> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
> b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> index eb9ff44..a6957a3 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> @@ -179,18 +179,204 @@ void MR_PopulateDrvRaidMap(struct
> megasas_instance *instance)
>> struct fusion_context *fusion = instance->ctrl_context;
>> struct MR_FW_RAID_MAP_ALL *fw_map_old = NULL;
>> struct MR_FW_RAID_MAP *pFwRaidMap = NULL;
>> - int i;
>> + int i, j;
>> u16 ld_count;
>> + struct MR_FW_RAID_MAP_DYNAMIC *fw_map_dyn;
>> + struct MR_FW_RAID_MAP_EXT *fw_map_ext;
>> + struct MR_RAID_MAP_DESC_TABLE *desc_table;
>>
>>
>> struct MR_DRV_RAID_MAP_ALL *drv_map =
>> fusion->ld_drv_map[(instance->map_id & 1)];
>> struct MR_DRV_RAID_MAP *pDrvRaidMap = &drv_map->raidMap;
>> + void *raid_map_data = NULL;
>> +
>> + memset(drv_map, 0, fusion->drv_map_sz);
>> + memset(pDrvRaidMap->ldTgtIdToLd,
>> + 0xff, (sizeof(u16) * MAX_LOGICAL_DRIVES_DYN));
>> +
>> + if (instance->max_raid_mapsize) {
>> + fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
>> +#if VD_EXT_DEBUG
>> + dev_dbg(&instance->pdev->dev,
>> + " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
>> + " descTableSize 0x%x descTableNumElements 0x%x\n",
>> + le32_to_cpu(fw_map_dyn->raid_map_size),
>> + le32_to_cpu(fw_map_dyn->desc_table_offset),
>> + le32_to_cpu(fw_map_dyn->desc_table_size),
>> + le32_to_cpu(fw_map_dyn->desc_table_num_elements));
>> + dev_dbg(&instance->pdev->dev,
>> + "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
>> +#endif
>> + desc_table =
>> + (struct MR_RAID_MAP_DESC_TABLE *)((void *)fw_map_dyn +
>> + le32_to_cpu(fw_map_dyn->desc_table_offset));
>> + if (desc_table != fw_map_dyn->raid_map_desc_table) {
>> + dev_err(&instance->pdev->dev,
>> + "offsets of desc table are not matching returning
> "
>> + " FW raid map has been changed: desc %p original
> %p\n",
>> + desc_table, fw_map_dyn->raid_map_desc_table);
>> + }
>> + ld_count = (u16)le16_to_cpu(fw_map_dyn->ld_count);
>> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
>> + pDrvRaidMap->fpPdIoTimeoutSec =
> fw_map_dyn->fp_pd_io_timeout_sec;
>> + pDrvRaidMap->totalSize = sizeof(struct
> MR_DRV_RAID_MAP_ALL);
>> + /* point to actual data starting point*/
>> + raid_map_data = (void *)fw_map_dyn +
>> + le32_to_cpu(fw_map_dyn->desc_table_offset) +
>> + le32_to_cpu(fw_map_dyn->desc_table_size);
>> +
>> + for (i = 0; i <
> le32_to_cpu(fw_map_dyn->desc_table_num_elements); ++i) {
>> + if (!desc_table) {
>> + dev_err(&instance->pdev->dev,
>> + "desc table is null, coming out %p \n",
> desc_table);
>> + return;
>> + }
> Is it possible that desc_table ever happens to NULL? It looks
> like a test something else was intended here ?
>
> It is a defensive check. yes can never be true and can be removed
Thanks, does it mean that you are going to post a v6 with this part removed or that
you'd post an additional patch that removes the test?
> Sasi
>
>
> Also all the VD_EXT_DEBUG macros make with bad indentation added
> make the code hard to read. Please fix it later in a follow up patch.
>
>
> Sasi - This shall be fixed in V5 patch
>
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "desc table %p \n", desc_table);
>> + dev_err(&instance->pdev->dev,
>> + "raidmap type %d, raidmapOffset 0x%x, "
>> + " raid map number of elements 0%x, raidmapsize
> 0x%x\n",
>> + desc_table->raid_map_desc_type,
>> + desc_table->raid_map_desc_offset,
>> + desc_table->raid_map_desc_elements,
>> + desc_table->raid_map_desc_buffer_size);
>> +#endif
>> + switch
> (le32_to_cpu(desc_table->raid_map_desc_type)) {
>> + case RAID_MAP_DESC_TYPE_DEVHDL_INFO:
>> + fw_map_dyn->dev_hndl_info = (struct
> MR_DEV_HANDLE_INFO *)
>> + (raid_map_data +
>> +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "devHndlInfo address %p\n",
>> + fw_map_dyn->dev_hndl_info);
>> +#endif
>> + memcpy(pDrvRaidMap->devHndlInfo,
> fw_map_dyn->dev_hndl_info,
>> + sizeof(struct MR_DEV_HANDLE_INFO)
> *
>> +
> le32_to_cpu(desc_table->raid_map_desc_elements));
>> + break;
>> + case RAID_MAP_DESC_TYPE_TGTID_INFO:
>> + fw_map_dyn->ld_tgt_id_to_ld = (u16
> *) (raid_map_data +
>> +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "ldTgtIdToLd address %p\n",
>> + fw_map_dyn->ld_tgt_id_to_ld);
>> +#endif
>> + for (j = 0; j <
> le32_to_cpu(desc_table->raid_map_desc_elements); j++) {
>> + pDrvRaidMap->ldTgtIdToLd[j] =
>> + fw_map_dyn->ld_tgt_id_to_ld[j];
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + " %d drv ldTgtIdToLd %d\n",
>> + j,
> pDrvRaidMap->ldTgtIdToLd[j]);
>> +#endif
>> + }
>> + break;
>> + case RAID_MAP_DESC_TYPE_ARRAY_INFO:
>> + fw_map_dyn->ar_map_info = (struct
> MR_ARRAY_INFO *)
>> + (raid_map_data +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "arMapInfo address %p\n",
>> + fw_map_dyn->ar_map_info);
>> +#endif
>> +
>> + memcpy(pDrvRaidMap->arMapInfo,
>> + fw_map_dyn->ar_map_info,
>> + sizeof(struct MR_ARRAY_INFO) *
>> +
> le32_to_cpu(desc_table->raid_map_desc_elements));
>> + break;
>> + case RAID_MAP_DESC_TYPE_SPAN_INFO:
>> + fw_map_dyn->ld_span_map = (struct
> MR_LD_SPAN_MAP *)
>> + (raid_map_data +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> + memcpy(pDrvRaidMap->ldSpanMap,
>> + fw_map_dyn->ld_span_map,
>> + sizeof(struct MR_LD_SPAN_MAP) *
>> +
> le32_to_cpu(desc_table->raid_map_desc_elements));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "ldSpanMap address %p\n",
>> + fw_map_dyn->ld_span_map);
>> + dev_err(&instance->pdev->dev,
>> + "MR_LD_SPAN_MAP size 0x%lx\n",
> sizeof(struct MR_LD_SPAN_MAP));
>> + for (j = 0; j < ld_count; j++) {
>> + printk(KERN_DEBUG
> "megaraid_sas(%d) : fw_map_dyn->ldSpanMap[%d].ldRaid.targetId 0x%x
> fw_map_dyn->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
>> + j, j,
> fw_map_dyn->ld_span_map[j].ldRaid.targetId, j,
>> +
> fw_map_dyn->ld_span_map[j].ldRaid.seqNum,
>> +
> (u32)fw_map_dyn->ld_span_map[j].ldRaid.rowSize);
>> + printk(KERN_DEBUG
> "megaraid_sas(%d) :pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x
> pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
>> + j, j,
> pDrvRaidMap->ldSpanMap[j].ldRaid.targetId, j,
>> +
> pDrvRaidMap->ldSpanMap[j].ldRaid.seqNum,
>> +
> (u32)pDrvRaidMap->ldSpanMap[j].ldRaid.rowSize);
>> + printk(KERN_DEBUG
> "megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p/%p\n",
>> + instance->unique_id, drv_map,
> pDrvRaidMap,
>> +
> &fw_map_dyn->ld_span_map[j].ldRaid,
>> +
> &pDrvRaidMap->ldSpanMap[j].ldRaid);
>> + }
>> +#endif
>> + break;
>> + default:
>> + dev_err(&instance->pdev->dev,
>> + "wrong number of desctableElements
> %d\n",
>> +
> fw_map_dyn->desc_table_num_elements);
>> + }
>> + ++desc_table;
>> + }
>> +
>> + } else if (instance->supportmax256vd) {
>> + fw_map_ext =
>> + (struct MR_FW_RAID_MAP_EXT *)
> fusion->ld_map[(instance->map_id & 1)];
>> + ld_count = (u16)le16_to_cpu(fw_map_ext->ldCount);
>> + if (ld_count > MAX_LOGICAL_DRIVES_EXT) {
>> + printk(KERN_DEBUG "megaraid_sas: LD count exposed
> in RAID map in not valid\n");
>> + return;
>> + }
>> +#if VD_EXT_DEBUG
>> + for (i = 0; i < ld_count; i++) {
>> + printk(KERN_DEBUG "megaraid_sas(%d) :Index 0x%x
> Target Id 0x%x Seq Num 0x%x Size 0/%llx\n",
>> + instance->unique_id,
>> + i,
> fw_map_ext->ldSpanMap[i].ldRaid.targetId,
>> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
>> + fw_map_ext->ldSpanMap[i].ldRaid.size);
>> + }
>> +#endif
>> +
>> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
>> + pDrvRaidMap->fpPdIoTimeoutSec =
>> +
> fw_map_ext->fpPdIoTimeoutSec;
>> + for (i = 0; i < (MAX_LOGICAL_DRIVES_EXT); i++)
>> + pDrvRaidMap->ldTgtIdToLd[i] =
>> + (u16)fw_map_ext->ldTgtIdToLd[i];
>> + memcpy(pDrvRaidMap->ldSpanMap,
>> + fw_map_ext->ldSpanMap,
>> + sizeof(struct MR_LD_SPAN_MAP) *
>> + ld_count);
>> +#if VD_EXT_DEBUG
>> + for (i = 0; i < ld_count; i++) {
>> + printk(KERN_DEBUG "megaraid_sas(%d) :
> fw_map_ext->ldSpanMap[%d].ldRaid.targetId 0x%x
> fw_map_ext->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
>> + i, i, fw_map_ext->ldSpanMap[i].ldRaid.targetId, i,
>> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
>> + (u32)fw_map_ext->ldSpanMap[i].ldRaid.rowSize);
>> + printk(KERN_DEBUG "megaraid_sas(%d) :
> pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x"
>> + "pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x
> size 0x%x\n",
>> + i, i, pDrvRaidMap->ldSpanMap[i].ldRaid.targetId,
> i,
>> + pDrvRaidMap->ldSpanMap[i].ldRaid.seqNum,
>> + (u32)pDrvRaidMap->ldSpanMap[i].ldRaid.rowSize);
>> + printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map
> all %p raid map %p LD RAID MAP %p %p\n",
>> + instance->unique_id, drv_map, pDrvRaidMap,
>> + &fw_map_ext->ldSpanMap[i].ldRaid,
>> + &pDrvRaidMap->ldSpanMap[i].ldRaid);
>> + }
>> +#endif
>> + memcpy(pDrvRaidMap->arMapInfo, fw_map_ext->arMapInfo,
>> + sizeof(struct MR_ARRAY_INFO) *
> MAX_API_ARRAYS_EXT);
>> + memcpy(pDrvRaidMap->devHndlInfo, fw_map_ext->devHndlInfo,
>> + sizeof(struct MR_DEV_HANDLE_INFO) *
>> + MAX_RAIDMAP_PHYSICAL_DEVICES);
>>
>> - if (instance->supportmax256vd) {
>> - memcpy(fusion->ld_drv_map[instance->map_id & 1],
>> - fusion->ld_map[instance->map_id & 1],
>> - fusion->current_map_sz);
>> /* New Raid map will not set totalSize, so keep expected
> value
>> * for legacy code in ValidateMapInfo
>> */
>> @@ -213,16 +399,12 @@ void MR_PopulateDrvRaidMap(struct megasas_instance
> *instance)
>> }
>> #endif
>>
>> - memset(drv_map, 0, fusion->drv_map_sz);
>> pDrvRaidMap->totalSize = pFwRaidMap->totalSize;
>> pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
>> pDrvRaidMap->fpPdIoTimeoutSec =
> pFwRaidMap->fpPdIoTimeoutSec;
>> for (i = 0; i < MAX_RAIDMAP_LOGICAL_DRIVES +
> MAX_RAIDMAP_VIEWS; i++)
>> pDrvRaidMap->ldTgtIdToLd[i] =
>> (u8)pFwRaidMap->ldTgtIdToLd[i];
>> - for (i = (MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS);
>> - i < MAX_LOGICAL_DRIVES_EXT; i++)
>> - pDrvRaidMap->ldTgtIdToLd[i] = 0xff;
>> for (i = 0; i < ld_count; i++) {
>> pDrvRaidMap->ldSpanMap[i] =
> pFwRaidMap->ldSpanMap[i];
>> #if VD_EXT_DEBUG
>> @@ -279,7 +461,9 @@ u8 MR_ValidateMapInfo(struct megasas_instance
> *instance)
>> lbInfo = fusion->load_balance_info;
>> ldSpanInfo = fusion->log_to_span;
>>
>> - if (instance->supportmax256vd)
>> + if (instance->max_raid_mapsize)
>> + expected_size = sizeof(struct MR_DRV_RAID_MAP_ALL);
>> + else if (instance->supportmax256vd)
>> expected_size = sizeof(struct MR_FW_RAID_MAP_EXT);
>> else
>> expected_size =
>> @@ -287,8 +471,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance
> *instance)
>> (sizeof(struct MR_LD_SPAN_MAP) *
> le16_to_cpu(pDrvRaidMap->ldCount)));
>> if (le32_to_cpu(pDrvRaidMap->totalSize) != expected_size) {
>> - dev_err(&instance->pdev->dev, "map info structure size
> 0x%x is not matching with ld count\n",
>> - (unsigned int) expected_size);
>> + dev_err(&instance->pdev->dev, "megasas: map info
> structure"
>> + " size 0x%x is not matching expected size 0x%x\n",
>> + le32_to_cpu(pDrvRaidMap->totalSize),
>> + (unsigned int) expected_size);
>> dev_err(&instance->pdev->dev, "megasas: span map %x,
> pDrvRaidMap->totalSize : %x\n",
>> (unsigned int)sizeof(struct MR_LD_SPAN_MAP),
>> le32_to_cpu(pDrvRaidMap->totalSize));
>> @@ -787,7 +973,7 @@ static u8 mr_spanset_get_phy_params(struct
> megasas_instance *instance, u32 ld,
>> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
>> ((fusion->adapter_type == INVADER_SERIES) &&
>> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
>> - pRAID_Context->regLockFlags =
> REGION_TYPE_EXCLUSIVE;
>> + pRAID_Context->reg_lock_flags =
> REGION_TYPE_EXCLUSIVE;
>> else if (raid->level == 1) {
>> physArm = physArm + 1;
>> pd = MR_ArPdGet(arRef, physArm, map);
>> @@ -797,9 +983,16 @@ static u8 mr_spanset_get_phy_params(struct
> megasas_instance *instance, u32 ld,
>> }
>>
>> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
> map)->startBlk);
>> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
>> - physArm;
>> - io_info->span_arm = pRAID_Context->spanArm;
>> + if (instance->is_ventura) {
>> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + io_info->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + } else {
>> + pRAID_Context->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + io_info->span_arm = pRAID_Context->span_arm;
>> + }
>> return retval;
>> }
>>
>> @@ -891,7 +1084,7 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
>> ((fusion->adapter_type == INVADER_SERIES) &&
>> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
>> - pRAID_Context->regLockFlags =
> REGION_TYPE_EXCLUSIVE;
>> + pRAID_Context->reg_lock_flags =
> REGION_TYPE_EXCLUSIVE;
>> else if (raid->level == 1) {
>> /* Get alternate Pd. */
>> physArm = physArm + 1;
>> @@ -903,9 +1096,16 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> }
>>
>> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
> map)->startBlk);
>> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
>> - physArm;
>> - io_info->span_arm = pRAID_Context->spanArm;
>> + if (instance->is_ventura) {
>> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> physArm;
>> + io_info->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> physArm;
>> + } else {
>> + pRAID_Context->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + io_info->span_arm = pRAID_Context->span_arm;
>> + }
>> return retval;
>> }
>>
>> @@ -1109,20 +1309,20 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> regSize += stripSize;
>> }
>>
>> - pRAID_Context->timeoutValue =
>> + pRAID_Context->timeout_value =
>> cpu_to_le16(raid->fpIoTimeoutForLd ?
>> raid->fpIoTimeoutForLd :
>> map->raidMap.fpPdIoTimeoutSec);
>> if (fusion->adapter_type == INVADER_SERIES)
>> - pRAID_Context->regLockFlags = (isRead) ?
>> + pRAID_Context->reg_lock_flags = (isRead) ?
>> raid->regTypeReqOnRead : raid->regTypeReqOnWrite;
>> - else
>> - pRAID_Context->regLockFlags = (isRead) ?
>> + else if (!instance->is_ventura)
>> + pRAID_Context->reg_lock_flags = (isRead) ?
>> REGION_TYPE_SHARED_READ : raid->regTypeReqOnWrite;
>> - pRAID_Context->VirtualDiskTgtId = raid->targetId;
>> - pRAID_Context->regLockRowLBA = cpu_to_le64(regStart);
>> - pRAID_Context->regLockLength = cpu_to_le32(regSize);
>> - pRAID_Context->configSeqNum = raid->seqNum;
>> + pRAID_Context->virtual_disk_tgt_id = raid->targetId;
>> + pRAID_Context->reg_lock_row_lba = cpu_to_le64(regStart);
>> + pRAID_Context->reg_lock_length = cpu_to_le32(regSize);
>> + pRAID_Context->config_seq_num = raid->seqNum;
>> /* save pointer to raid->LUN array */
>> *raidLUN = raid->LUN;
>>
>> @@ -1140,6 +1340,14 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> /* If IO on an invalid Pd, then FP is not possible.*/
>> if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
>> io_info->fpOkForIo = FALSE;
>> + /* if FP possible, set the SLUD bit in
>> + * regLockFlags for ventura
>> + */
>> + else if ((instance->is_ventura) && !isRead &&
>> + (raid->writeMode == MR_RL_WRITE_BACK_MODE)
> &&
>> + raid->capability.fp_cache_bypass_capable)
>> + ((struct RAID_CONTEXT_G35 *)
> pRAID_Context)->routing_flags.bits.sld
>> + = 1;
>> /* set raid 1/10 fast path write capable bit in io_info */
>> if (io_info->fpOkForIo &&
>> (io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
>> @@ -1319,6 +1527,7 @@ u8 megasas_get_best_arm_pd(struct megasas_instance
> *instance,
>> struct fusion_context *fusion;
>> struct MR_LD_RAID *raid;
>> struct MR_DRV_RAID_MAP_ALL *drv_map;
>> + u16 pd1_dev_handle;
>> u16 pend0, pend1, ld;
>> u64 diff0, diff1;
>> u8 bestArm, pd0, pd1, span, arm;
>> @@ -1344,23 +1553,37 @@ u8 megasas_get_best_arm_pd(struct
> megasas_instance *instance,
>> pd1 = MR_ArPdGet(arRef, (arm + 1) >= span_row_size ?
>> (arm + 1 - span_row_size) : arm + 1, drv_map);
>>
>> - /* get the pending cmds for the data and mirror arms */
>> - pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
>> - pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
>> + /* Get PD1 Dev Handle */
>>
>> - /* Determine the disk whose head is nearer to the req. block */
>> - diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
>> - diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
>> - bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
>> + pd1_dev_handle = MR_PdDevHandleGet(pd1, drv_map);
>>
>> - if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
>> + if (pd1_dev_handle == MR_PD_INVALID) {
>> + bestArm = arm;
>> + } else {
>> + /* get the pending cmds for the data and mirror arms */
>> + pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
>> + pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
>> +
>> + /* Determine the disk whose head is nearer to the req.
> block */
>> + diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
>> + diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
>> + /*bestArm = diff0<=diff1 ? arm : arm ^ 1;*/
>> + bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
> The above comment is useless and the parentheses not needed,
> again please clean it up in a next series.
> Sasi - This shall be fixed in V5 patch
>
> tomash
>
>> +
>> + /* Make balance count from 16 to 4 to
>> + * keep driver in sync with Firmware
>> + */
>> + if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds)
> ||
>> (bestArm != arm && pend1 > pend0 +
> lb_pending_cmds))
>> - bestArm ^= 1;
>> + bestArm ^= 1;
>> +
>> + /* Update the last accessed block on the correct pd */
>> + io_info->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
>> + io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
>> + }
>>
>> - /* Update the last accessed block on the correct pd */
>> - io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
>> lbInfo->last_accessed_block[io_info->pd_after_lb] = block + count
> - 1;
>> - io_info->span_arm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> bestArm;
>> #if SPAN_DEBUG
>> if (arm != bestArm)
>> dev_dbg(&instance->pdev->dev, "LSI Debug R1 Load balance "
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> index 2fcd5cd..58f86aa 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> @@ -1834,7 +1834,7 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> struct megasas_cmd_fusion *cmd)
>> {
>> u8 fp_possible;
>> - u32 start_lba_lo, start_lba_hi, device_id, datalength = 0;
>> + u32 start_lba_lo, start_lba_hi, device_id, datalength = 0, ld;
>> struct MPI2_RAID_SCSI_IO_REQUEST *io_request;
>> union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
>> struct IO_REQUEST_INFO io_info;
>> @@ -1842,16 +1842,18 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
>> u8 *raidLUN;
>> unsigned long spinlock_flags;
>> + union RAID_CONTEXT_UNION *praid_context;
>> + struct MR_LD_RAID *raid;
>>
>> device_id = MEGASAS_DEV_INDEX(scp);
>>
>> fusion = instance->ctrl_context;
>>
>> io_request = cmd->io_request;
>> - io_request->RaidContext.raid_context.VirtualDiskTgtId =
>> + io_request->RaidContext.raid_context.virtual_disk_tgt_id =
>> cpu_to_le16(device_id);
>> io_request->RaidContext.raid_context.status = 0;
>> - io_request->RaidContext.raid_context.exStatus = 0;
>> + io_request->RaidContext.raid_context.ex_status = 0;
>>
>> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION
> *)cmd->request_desc;
>> @@ -1920,10 +1922,12 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> io_info.isRead = 1;
>>
>> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
>> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
>> + raid = MR_LdRaidGet(ld, local_map_ptr);
>>
>> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
>> instance->fw_supported_vd_count) ||
> (!fusion->fast_path_io)) {
>> - io_request->RaidContext.raid_context.regLockFlags = 0;
>> + io_request->RaidContext.raid_context.reg_lock_flags = 0;
>> fp_possible = 0;
>> } else {
>> if (MR_BuildRaidContext(instance, &io_info,
>> @@ -1950,6 +1954,8 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> fp_possible = false;
>> }
>>
>> + praid_context = &io_request->RaidContext;
>> +
>> if (fp_possible) {
>> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info,
> scp,
>> local_map_ptr, start_lba_lo);
>> @@ -1958,18 +1964,26 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
>> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> if (fusion->adapter_type == INVADER_SERIES) {
>> - if
> (io_request->RaidContext.raid_context.regLockFlags ==
>> + if
> (io_request->RaidContext.raid_context.reg_lock_flags ==
>> REGION_TYPE_UNUSED)
>> cmd->request_desc->SCSIIO.RequestFlags =
>>
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> - io_request->RaidContext.raid_context.Type
>> + io_request->RaidContext.raid_context.type
>> = MPI2_TYPE_CUDA;
>> io_request->RaidContext.raid_context.nseg = 0x1;
>> io_request->IoFlags |=
> cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
>> - io_request->RaidContext.raid_context.regLockFlags
> |=
>> +
> io_request->RaidContext.raid_context.reg_lock_flags |=
>> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
>> MR_RL_FLAGS_SEQ_NUM_ENABLE);
>> + } else if (instance->is_ventura) {
>> + io_request->RaidContext.raid_context_g35.type
>> + = MPI2_TYPE_CUDA;
>> + io_request->RaidContext.raid_context_g35.nseg =
> 0x1;
>> +
> io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
>> + = 1;
>> + io_request->IoFlags |=
>> +
> cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
>> }
>> if ((fusion->load_balance_info[device_id].loadBalanceFlag)
> &&
>> (io_info.isRead)) {
>> @@ -1979,6 +1993,13 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> &io_info);
>> scp->SCp.Status |= MEGASAS_LOAD_BALANCE_FLAG;
>> cmd->pd_r1_lb = io_info.pd_after_lb;
>> + if (instance->is_ventura)
>> +
> io_request->RaidContext.raid_context_g35.span_arm
>> + = io_info.span_arm;
>> + else
>> +
> io_request->RaidContext.raid_context.span_arm
>> + = io_info.span_arm;
>> +
>> } else
>> scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
>>
>> @@ -1997,28 +2018,98 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> io_request->DevHandle = io_info.devHandle;
>> /* populate the LUN field */
>> memcpy(io_request->LUN, raidLUN, 8);
>> + if (instance->is_ventura) {
>> + if (io_info.isRead) {
>> + if ((raid->cpuAffinity.pdRead.cpu0) &&
>> + (raid->cpuAffinity.pdRead.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.pdRead.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + } else {
>> + if ((raid->cpuAffinity.pdWrite.cpu0)
>> + && (raid->cpuAffinity.pdWrite.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.pdWrite.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + if
> (praid_context->raid_context_g35.routing_flags.bits.sld) {
>> +
> praid_context->raid_context_g35.raid_flags
>> + =
> (MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
>> + <<
> MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
>> + }
>> + }
>> + }
>> } else {
>> - io_request->RaidContext.raid_context.timeoutValue =
>> + io_request->RaidContext.raid_context.timeout_value =
>>
> cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
>> cmd->request_desc->SCSIIO.RequestFlags =
>> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
>> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> if (fusion->adapter_type == INVADER_SERIES) {
>> if (io_info.do_fp_rlbypass ||
>> - (io_request->RaidContext.raid_context.regLockFlags
>> +
> (io_request->RaidContext.raid_context.reg_lock_flags
>> == REGION_TYPE_UNUSED))
>> cmd->request_desc->SCSIIO.RequestFlags =
>>
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> - io_request->RaidContext.raid_context.Type
>> + io_request->RaidContext.raid_context.type
>> = MPI2_TYPE_CUDA;
>> - io_request->RaidContext.raid_context.regLockFlags
> |=
>> +
> io_request->RaidContext.raid_context.reg_lock_flags |=
>> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
>> MR_RL_FLAGS_SEQ_NUM_ENABLE);
>> io_request->RaidContext.raid_context.nseg = 0x1;
>> + } else if (instance->is_ventura) {
>> + io_request->RaidContext.raid_context_g35.type
>> + = MPI2_TYPE_CUDA;
>> +
> io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
>> + = 1;
>> + io_request->RaidContext.raid_context_g35.nseg =
> 0x1;
>> }
>> io_request->Function =
> MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
>> io_request->DevHandle = cpu_to_le16(device_id);
>> +
>> + if (instance->is_ventura) {
>> + if (io_info.isRead) {
>> + if ((raid->cpuAffinity.ldRead.cpu0)
>> + && (raid->cpuAffinity.ldRead.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldRead.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + } else {
>> + if ((raid->cpuAffinity.ldWrite.cpu0) &&
>> + (raid->cpuAffinity.ldWrite.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + =
> MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldWrite.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> +
>> + if
> (io_request->RaidContext.raid_context_g35.stream_detected
>> + && (raid->level == 5)
>> + && (raid->writeMode ==
> MR_RL_WRITE_THROUGH_MODE)) {
>> + if
> (praid_context->raid_context_g35.routing_flags.bits.cpu_sel ==
> MR_RAID_CTX_CPUSEL_FCFS)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + =
> MR_RAID_CTX_CPUSEL_0;
>> + }
>> + }
>> + }
>> } /* Not FP */
>> }
>>
>> @@ -2053,9 +2144,9 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> /* get RAID_Context pointer */
>> pRAID_Context = &io_request->RaidContext.raid_context;
>> /* Check with FW team */
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> - pRAID_Context->regLockRowLBA = 0;
>> - pRAID_Context->regLockLength = 0;
>> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
>> + pRAID_Context->reg_lock_row_lba = 0;
>> + pRAID_Context->reg_lock_length = 0;
>>
>> if (fusion->fast_path_io && (
>> device_id < instance->fw_supported_vd_count)) {
>> @@ -2074,7 +2165,7 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> io_request->Function =
> MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
>> io_request->DevHandle = cpu_to_le16(device_id);
>> io_request->LUN[1] = scmd->device->lun;
>> - pRAID_Context->timeoutValue =
>> + pRAID_Context->timeout_value =
>> cpu_to_le16 (scmd->request->timeout / HZ);
>> cmd->request_desc->SCSIIO.RequestFlags =
>> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
>> @@ -2082,9 +2173,10 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> } else {
>>
>> /* set RAID context values */
>> - pRAID_Context->configSeqNum = raid->seqNum;
>> - pRAID_Context->regLockFlags = REGION_TYPE_SHARED_READ;
>> - pRAID_Context->timeoutValue =
> cpu_to_le16(raid->fpIoTimeoutForLd);
>> + pRAID_Context->config_seq_num = raid->seqNum;
>> + if (!instance->is_ventura)
>> + pRAID_Context->reg_lock_flags =
> REGION_TYPE_SHARED_READ;
>> + pRAID_Context->timeout_value =
> cpu_to_le16(raid->fpIoTimeoutForLd);
>> /* get the DevHandle for the PD (since this is
>> fpNonRWCapable, this is a single disk RAID0) */
>> @@ -2139,12 +2231,12 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> io_request = cmd->io_request;
>> /* get RAID_Context pointer */
>> pRAID_Context = &io_request->RaidContext.raid_context;
>> - pRAID_Context->regLockFlags = 0;
>> - pRAID_Context->regLockRowLBA = 0;
>> - pRAID_Context->regLockLength = 0;
>> + pRAID_Context->reg_lock_flags = 0;
>> + pRAID_Context->reg_lock_row_lba = 0;
>> + pRAID_Context->reg_lock_length = 0;
>> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
>> io_request->LUN[1] = scmd->device->lun;
>> - pRAID_Context->RAIDFlags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
>> + pRAID_Context->raid_flags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
>> << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
>>
>> /* If FW supports PD sequence number */
>> @@ -2153,24 +2245,28 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> /* TgtId must be incremented by 255 as jbod seq number is
> index
>> * below raid map
>> */
>> - pRAID_Context->VirtualDiskTgtId =
>> + pRAID_Context->virtual_disk_tgt_id =
>> cpu_to_le16(device_id + (MAX_PHYSICAL_DEVICES -
> 1));
>> - pRAID_Context->configSeqNum =
> pd_sync->seq[pd_index].seqNum;
>> + pRAID_Context->config_seq_num =
> pd_sync->seq[pd_index].seqNum;
>> io_request->DevHandle = pd_sync->seq[pd_index].devHandle;
>> - pRAID_Context->regLockFlags |=
>> + if (instance->is_ventura)
>> +
> io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
>> + = 1;
>> + else
>> + pRAID_Context->reg_lock_flags |=
>>
> (MR_RL_FLAGS_SEQ_NUM_ENABLE|MR_RL_FLAGS_GRANT_DESTINATION_CUDA);
>> - pRAID_Context->Type = MPI2_TYPE_CUDA;
>> + pRAID_Context->type = MPI2_TYPE_CUDA;
>> pRAID_Context->nseg = 0x1;
>> } else if (fusion->fast_path_io) {
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> - pRAID_Context->configSeqNum = 0;
>> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id);
>> + pRAID_Context->config_seq_num = 0;
>> local_map_ptr = fusion->ld_drv_map[(instance->map_id &
> 1)];
>> io_request->DevHandle =
>>
> local_map_ptr->raidMap.devHndlInfo[device_id].curDevHdl;
>> } else {
>> /* Want to send all IO via FW path */
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> - pRAID_Context->configSeqNum = 0;
>> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id);
>> + pRAID_Context->config_seq_num = 0;
>> io_request->DevHandle = cpu_to_le16(0xFFFF);
>> }
>>
>> @@ -2186,14 +2282,14 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> cmd->request_desc->SCSIIO.RequestFlags =
>> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
>> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> - pRAID_Context->timeoutValue =
> cpu_to_le16(os_timeout_value);
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> + pRAID_Context->timeout_value =
> cpu_to_le16(os_timeout_value);
>> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id);
>> } else {
>> /* system pd Fast Path */
>> io_request->Function = MPI2_FUNCTION_SCSI_IO_REQUEST;
>> timeout_limit = (scmd->device->type == TYPE_DISK) ?
>> 255 : 0xFFFF;
>> - pRAID_Context->timeoutValue =
>> + pRAID_Context->timeout_value =
>> cpu_to_le16((os_timeout_value > timeout_limit) ?
>> timeout_limit : os_timeout_value);
>> if (fusion->adapter_type == INVADER_SERIES)
>> @@ -2232,8 +2328,8 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> io_request->Control = 0;
>> io_request->EEDPBlockSize = 0;
>> io_request->ChainOffset = 0;
>> - io_request->RaidContext.raid_context.RAIDFlags = 0;
>> - io_request->RaidContext.raid_context.Type = 0;
>> + io_request->RaidContext.raid_context.raid_flags = 0;
>> + io_request->RaidContext.raid_context.type = 0;
>> io_request->RaidContext.raid_context.nseg = 0;
>>
>> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
>> @@ -2278,11 +2374,16 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> return 1;
>> }
>>
>> - /* numSGE store lower 8 bit of sge_count.
>> - * numSGEExt store higher 8 bit of sge_count
>> - */
>> - io_request->RaidContext.raid_context.numSGE = sge_count;
>> - io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >>
> 8);
>> + if (instance->is_ventura)
>> + io_request->RaidContext.raid_context_g35.num_sge =
> sge_count;
>> + else {
>> + /* numSGE store lower 8 bit of sge_count.
>> + * numSGEExt store higher 8 bit of sge_count
>> + */
>> + io_request->RaidContext.raid_context.num_sge = sge_count;
>> + io_request->RaidContext.raid_context.num_sge_ext =
>> + (u8)(sge_count >> 8);
>> + }
>>
>> io_request->SGLFlags =
> cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>> @@ -2331,6 +2432,10 @@ void megasas_fpio_to_ldio(struct megasas_instance
> *instance,
>> struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
>> {
>> struct fusion_context *fusion;
>> + union RAID_CONTEXT_UNION *praid_context;
>> + struct MR_LD_RAID *raid;
>> + struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
>> + u32 device_id, ld;
>> fusion = instance->ctrl_context;
>>
>> cmd->request_desc->SCSIIO.RequestFlags =
>> @@ -2354,6 +2459,35 @@ void megasas_fpio_to_ldio(struct megasas_instance
> *instance,
>> cmd->io_request->Control = 0;
>> cmd->io_request->EEDPBlockSize = 0;
>> cmd->is_raid_1_fp_write = 0;
>> +
>> + device_id = MEGASAS_DEV_INDEX(cmd->scmd);
>> + local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
>> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
>> + raid = MR_LdRaidGet(ld, local_map_ptr);
>> + praid_context = &cmd->io_request->RaidContext;
>> + if (cmd->scmd->sc_data_direction == PCI_DMA_FROMDEVICE) {
>> + if ((raid->cpuAffinity.ldRead.cpu0)
>> + && (raid->cpuAffinity.ldRead.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldRead.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + } else {
>> + if ((raid->cpuAffinity.ldWrite.cpu0)
>> + && (raid->cpuAffinity.ldWrite.cpu1))
>> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldWrite.cpu1)
>> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + }
>> }
>> /*megasas_prepate_secondRaid1_IO
>> * It prepares the raid 1 second IO
>> @@ -2491,6 +2625,7 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> * corresponds to single R1/10 LD are always same
>> *
>> */
>> +
>> /* driver side count always should be less than max_fw_cmds
>> * to get new command
>> */
>> @@ -2588,7 +2723,7 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> scmd_local = cmd_fusion->scmd;
>> status = scsi_io_req->RaidContext.raid_context.status;
>> - extStatus =
> scsi_io_req->RaidContext.raid_context.exStatus;
>> + extStatus =
> scsi_io_req->RaidContext.raid_context.ex_status;
>> sense = cmd_fusion->sense;
>> data_length = scsi_io_req->DataLength;
>>
>> @@ -2656,13 +2791,13 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> status =
>>
> r1_cmd->io_request->RaidContext.raid_context.status;
>> extStatus =
>> -
> r1_cmd->io_request->RaidContext.raid_context.exStatus;
>> +
> r1_cmd->io_request->RaidContext.raid_context.ex_status;
>> data_length =
>>
> r1_cmd->io_request->DataLength;
>> sense = r1_cmd->sense;
>> }
>>
> r1_cmd->io_request->RaidContext.raid_context.status = 0;
>> -
> r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
>> +
> r1_cmd->io_request->RaidContext.raid_context.ex_status = 0;
>> cmd_fusion->is_raid_1_fp_write = 0;
>> r1_cmd->is_raid_1_fp_write = 0;
>> r1_cmd->cmd_completed = false;
>> @@ -2674,7 +2809,7 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> extStatus, data_length, sense);
>>
> scsi_io_req->RaidContext.raid_context.status
>> = 0;
>> -
> scsi_io_req->RaidContext.raid_context.exStatus
>> +
> scsi_io_req->RaidContext.raid_context.ex_status
>> = 0;
>> megasas_return_cmd_fusion(instance,
> cmd_fusion);
>> scsi_dma_unmap(scmd_local);
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> index 5590c1d..cb42655 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> @@ -59,6 +59,8 @@
>> #define MR_RL_FLAGS_GRANT_DESTINATION_CPU1 0x10
>> #define MR_RL_FLAGS_GRANT_DESTINATION_CUDA 0x80
>> #define MR_RL_FLAGS_SEQ_NUM_ENABLE 0x8
>> +#define MR_RL_WRITE_THROUGH_MODE 0x00
>> +#define MR_RL_WRITE_BACK_MODE 0x01
>>
>> /* T10 PI defines */
>> #define MR_PROT_INFO_TYPE_CONTROLLER 0x8
>> @@ -81,6 +83,11 @@
>> enum MR_RAID_FLAGS_IO_SUB_TYPE {
>> MR_RAID_FLAGS_IO_SUB_TYPE_NONE = 0,
>> MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD = 1,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_DATA = 2,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_P = 3,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_Q = 4,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS = 6,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT = 7
>> };
>>
>> /*
>> @@ -109,29 +116,29 @@ enum MR_FUSION_ADAPTER_TYPE {
>>
>> struct RAID_CONTEXT {
>> #if defined(__BIG_ENDIAN_BITFIELD)
>> - u8 nseg:4;
>> - u8 Type:4;
>> + u8 nseg:4;
>> + u8 type:4;
>> #else
>> - u8 Type:4;
>> - u8 nseg:4;
>> + u8 type:4;
>> + u8 nseg:4;
>> #endif
>> - u8 resvd0;
>> - __le16 timeoutValue;
>> - u8 regLockFlags;
>> - u8 resvd1;
>> - __le16 VirtualDiskTgtId;
>> - __le64 regLockRowLBA;
>> - __le32 regLockLength;
>> - __le16 nextLMId;
>> - u8 exStatus;
>> - u8 status;
>> - u8 RAIDFlags;
>> - u8 numSGE;
>> - __le16 configSeqNum;
>> - u8 spanArm;
>> - u8 priority;
>> - u8 numSGEExt;
>> - u8 resvd2;
>> + u8 resvd0;
>> + __le16 timeout_value;
>> + u8 reg_lock_flags;
>> + u8 resvd1;
>> + __le16 virtual_disk_tgt_id;
>> + __le64 reg_lock_row_lba;
>> + __le32 reg_lock_length;
>> + __le16 next_lmid;
>> + u8 ex_status;
>> + u8 status;
>> + u8 raid_flags;
>> + u8 num_sge;
>> + __le16 config_seq_num;
>> + u8 span_arm;
>> + u8 priority;
>> + u8 num_sge_ext;
>> + u8 resvd2;
>> };
>>
>> /*
>> @@ -187,7 +194,7 @@ struct RAID_CONTEXT_G35 {
>> } smid;
>> u8 ex_status; /* 0x16 : OUT */
>> u8 status; /* 0x17 status */
>> - u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
>> + u8 raid_flags; /* 0x18 resvd[7:6], ioSubType[5:4],
>> * resvd[3:1],
> preferredCpu[0]
>> */
>> u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
>> @@ -672,14 +679,17 @@ struct MPI2_IOC_INIT_REQUEST {
>> #define MAX_RAIDMAP_ROW_SIZE (MAX_ROW_SIZE)
>> #define MAX_LOGICAL_DRIVES 64
>> #define MAX_LOGICAL_DRIVES_EXT 256
>> +#define MAX_LOGICAL_DRIVES_DYN 512
>> #define MAX_RAIDMAP_LOGICAL_DRIVES (MAX_LOGICAL_DRIVES)
>> #define MAX_RAIDMAP_VIEWS (MAX_LOGICAL_DRIVES)
>> #define MAX_ARRAYS 128
>> #define MAX_RAIDMAP_ARRAYS (MAX_ARRAYS)
>> #define MAX_ARRAYS_EXT 256
>> #define MAX_API_ARRAYS_EXT (MAX_ARRAYS_EXT)
>> +#define MAX_API_ARRAYS_DYN 512
>> #define MAX_PHYSICAL_DEVICES 256
>> #define MAX_RAIDMAP_PHYSICAL_DEVICES (MAX_PHYSICAL_DEVICES)
>> +#define MAX_RAIDMAP_PHYSICAL_DEVICES_DYN 512
>> #define MR_DCMD_LD_MAP_GET_INFO 0x0300e101
>> #define MR_DCMD_SYSTEM_PD_MAP_GET_INFO 0x0200e102
>> #define MR_DCMD_CTRL_SHARED_HOST_MEM_ALLOC 0x010e8485 /* SR-IOV HB
> alloc*/
>> @@ -726,12 +736,56 @@ struct MR_SPAN_BLOCK_INFO {
>> struct MR_SPAN_INFO block_span_info;
>> };
>>
>> +#define MR_RAID_CTX_CPUSEL_0 0
>> +#define MR_RAID_CTX_CPUSEL_1 1
>> +#define MR_RAID_CTX_CPUSEL_2 2
>> +#define MR_RAID_CTX_CPUSEL_3 3
>> +#define MR_RAID_CTX_CPUSEL_FCFS 0xF
>> +
>> +struct MR_CPU_AFFINITY_MASK {
>> + union {
>> + struct {
>> +#ifndef MFI_BIG_ENDIAN
>> + u8 hw_path:1;
>> + u8 cpu0:1;
>> + u8 cpu1:1;
>> + u8 cpu2:1;
>> + u8 cpu3:1;
>> + u8 reserved:3;
>> +#else
>> + u8 reserved:3;
>> + u8 cpu3:1;
>> + u8 cpu2:1;
>> + u8 cpu1:1;
>> + u8 cpu0:1;
>> + u8 hw_path:1;
>> +#endif
>> + };
>> + u8 core_mask;
>> + };
>> +};
>> +
>> +struct MR_IO_AFFINITY {
>> + union {
>> + struct {
>> + struct MR_CPU_AFFINITY_MASK pdRead;
>> + struct MR_CPU_AFFINITY_MASK pdWrite;
>> + struct MR_CPU_AFFINITY_MASK ldRead;
>> + struct MR_CPU_AFFINITY_MASK ldWrite;
>> + };
>> + u32 word;
>> + };
>> + u8 maxCores; /* Total cores + HW Path in ROC */
>> + u8 reserved[3];
>> +};
>> +
>> struct MR_LD_RAID {
>> struct {
>> #if defined(__BIG_ENDIAN_BITFIELD)
>> - u32 reserved4:3;
>> - u32 fp_cache_bypass_capable:1;
>> - u32 fp_rmw_capable:1;
>> + u32 reserved4:2;
>> + u32 fp_cache_bypass_capable:1;
>> + u32 fp_rmw_capable:1;
>> + u32 disable_coalescing:1;
>> u32 fpBypassRegionLock:1;
>> u32 tmCapable:1;
>> u32 fpNonRWCapable:1;
>> @@ -759,9 +813,10 @@ struct MR_LD_RAID {
>> u32 fpNonRWCapable:1;
>> u32 tmCapable:1;
>> u32 fpBypassRegionLock:1;
>> - u32 fp_rmw_capable:1;
>> - u32 fp_cache_bypass_capable:1;
>> - u32 reserved4:3;
>> + u32 disable_coalescing:1;
>> + u32 fp_rmw_capable:1;
>> + u32 fp_cache_bypass_capable:1;
>> + u32 reserved4:2;
>> #endif
>> } capability;
>> __le32 reserved6;
>> @@ -788,7 +843,36 @@ struct MR_LD_RAID {
>>
>> u8 LUN[8]; /* 0x24 8 byte LUN field used for SCSI IO's */
>> u8 fpIoTimeoutForLd;/*0x2C timeout value used by driver in FP
> IO*/
>> - u8 reserved3[0x80-0x2D]; /* 0x2D */
>> + /* Ox2D This LD accept priority boost of this type */
>> + u8 ld_accept_priority_type;
>> + u8 reserved2[2]; /* 0x2E - 0x2F */
>> + /* 0x30 - 0x33, Logical block size for the LD */
>> + u32 logical_block_length;
>> + struct {
>> +#ifndef MFI_BIG_ENDIAN
>> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
>> + u32 ld_pi_exp:4;
>> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
>> + * BLOCK EXPONENT from READ CAPACITY 16
>> + */
>> + u32 ld_logical_block_exp:4;
>> + u32 reserved1:24; /* 0x34 */
>> +#else
>> + u32 reserved1:24; /* 0x34 */
>> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
>> + * BLOCK EXPONENT from READ CAPACITY 16
>> + */
>> + u32 ld_logical_block_exp:4;
>> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
>> + u32 ld_pi_exp:4;
>> +#endif
>> + }; /* 0x34 - 0x37 */
>> + /* 0x38 - 0x3f, This will determine which
>> + * core will process LD IO and PD IO.
>> + */
>> + struct MR_IO_AFFINITY cpuAffinity;
>> + /* Bit definiations are specified by MR_IO_AFFINITY */
>> + u8 reserved3[0x80-0x40]; /* 0x40 - 0x7f */
>> };
>>
>> struct MR_LD_SPAN_MAP {
>> @@ -846,6 +930,91 @@ struct MR_LD_TARGET_SYNC {
>> __le16 seqNum;
>> };
>>
>> +/*
>> +* RAID Map descriptor Types.
>> +* Each element should uniquely idetify one data structure in the RAID
> map
>> +*/
>> +enum MR_RAID_MAP_DESC_TYPE {
>> + /* MR_DEV_HANDLE_INFO data */
>> + RAID_MAP_DESC_TYPE_DEVHDL_INFO = 0x0,
>> + /* target to Ld num Index map */
>> + RAID_MAP_DESC_TYPE_TGTID_INFO = 0x1,
>> + /* MR_ARRAY_INFO data */
>> + RAID_MAP_DESC_TYPE_ARRAY_INFO = 0x2,
>> + /* MR_LD_SPAN_MAP data */
>> + RAID_MAP_DESC_TYPE_SPAN_INFO = 0x3,
>> + RAID_MAP_DESC_TYPE_COUNT,
>> +};
>> +
>> +/*
>> +* This table defines the offset, size and num elements of each
> descriptor
>> +* type in the RAID Map buffer
>> +*/
>> +struct MR_RAID_MAP_DESC_TABLE {
>> + /* Raid map descriptor type */
>> + u32 raid_map_desc_type;
>> + /* Offset into the RAID map buffer where
>> + * descriptor data is saved
>> + */
>> + u32 raid_map_desc_offset;
>> + /* total size of the
>> + * descriptor buffer
>> + */
>> + u32 raid_map_desc_buffer_size;
>> + /* Number of elements contained in the
>> + * descriptor buffer
>> + */
>> + u32 raid_map_desc_elements;
>> +};
>> +
>> +/*
>> +* Dynamic Raid Map Structure.
>> +*/
>> +struct MR_FW_RAID_MAP_DYNAMIC {
>> + u32 raid_map_size; /* total size of RAID Map structure */
>> + u32 desc_table_offset;/* Offset of desc table into RAID map*/
>> + u32 desc_table_size; /* Total Size of desc table */
>> + /* Total Number of elements in the desc table */
>> + u32 desc_table_num_elements;
>> + u64 reserved1;
>> + u32 reserved2[3]; /*future use */
>> + /* timeout value used by driver in FP IOs */
>> + u8 fp_pd_io_timeout_sec;
>> + u8 reserved3[3];
>> + /* when this seqNum increments, driver needs to
>> + * release RMW buffers asap
>> + */
>> + u32 rmw_fp_seq_num;
>> + u16 ld_count; /* count of lds. */
>> + u16 ar_count; /* count of arrays */
>> + u16 span_count; /* count of spans */
>> + u16 reserved4[3];
>> +/*
>> +* The below structure of pointers is only to be used by the driver.
>> +* This is added in the ,API to reduce the amount of code changes
>> +* needed in the driver to support dynamic RAID map Firmware should
>> +* not update these pointers while preparing the raid map
>> +*/
>> + union {
>> + struct {
>> + struct MR_DEV_HANDLE_INFO *dev_hndl_info;
>> + u16 *ld_tgt_id_to_ld;
>> + struct MR_ARRAY_INFO *ar_map_info;
>> + struct MR_LD_SPAN_MAP *ld_span_map;
>> + };
>> + u64 ptr_structure_size[RAID_MAP_DESC_TYPE_COUNT];
>> + };
>> +/*
>> +* RAID Map descriptor table defines the layout of data in the RAID Map.
>> +* The size of the descriptor table itself could change.
>> +*/
>> + /* Variable Size descriptor Table. */
>> + struct MR_RAID_MAP_DESC_TABLE
>> + raid_map_desc_table[RAID_MAP_DESC_TYPE_COUNT];
>> + /* Variable Size buffer containing all data */
>> + u32 raid_map_desc_data[1];
>> +}; /* Dynamicaly sized RAID MAp structure */
>> +
>> #define IEEE_SGE_FLAGS_ADDR_MASK (0x03)
>> #define IEEE_SGE_FLAGS_SYSTEM_ADDR (0x00)
>> #define IEEE_SGE_FLAGS_IOCDDR_ADDR (0x01)
>> @@ -955,9 +1124,10 @@ struct MR_DRV_RAID_MAP {
>> __le16 spanCount;
>> __le16 reserve3;
>>
>> - struct MR_DEV_HANDLE_INFO
> devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES];
>> - u8 ldTgtIdToLd[MAX_LOGICAL_DRIVES_EXT];
>> - struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_EXT];
>> + struct MR_DEV_HANDLE_INFO
>> + devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES_DYN];
>> + u16 ldTgtIdToLd[MAX_LOGICAL_DRIVES_DYN];
>> + struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_DYN];
>> struct MR_LD_SPAN_MAP ldSpanMap[1];
>>
>> };
>> @@ -969,7 +1139,7 @@ struct MR_DRV_RAID_MAP {
>> struct MR_DRV_RAID_MAP_ALL {
>>
>> struct MR_DRV_RAID_MAP raidMap;
>> - struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_EXT - 1];
>> + struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_DYN - 1];
>> } __packed;
>>
>>
>> @@ -1088,7 +1258,7 @@ struct fusion_context {
>> u8 chain_offset_io_request;
>> u8 chain_offset_mfi_pthru;
>>
>> - struct MR_FW_RAID_MAP_ALL *ld_map[2];
>> + struct MR_FW_RAID_MAP_DYNAMIC *ld_map[2];
>> dma_addr_t ld_map_phys[2];
>>
>> /*Non dma-able memory. Driver local copy.*/
>> @@ -1096,6 +1266,8 @@ struct fusion_context {
>>
>> u32 max_map_sz;
>> u32 current_map_sz;
>> + u32 old_map_sz;
>> + u32 new_map_sz;
>> u32 drv_map_sz;
>> u32 drv_map_pages;
>> struct MR_PD_CFG_SEQ_NUM_SYNC *pd_seq_sync[JBOD_MAPS_COUNT];
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
2016-12-20 14:20 ` Tomas Henzl
@ 2016-12-20 14:22 ` Sasikumar PC
0 siblings, 0 replies; 40+ messages in thread
From: Sasikumar PC @ 2016-12-20 14:22 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Tuesday, December 20, 2016 9:20 AM
To: Sasikumar PC; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya Prakash Veerichetty;
linux-kernel@vger.kernel.org; Christopher Owens; Kiran Kumar Kasturi
Subject: Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
SAS3.5 Generic Megaraid Controllers
On 20.12.2016 02:51, Sasikumar PC wrote:
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Sasikumar PC [mailto:sasikumar.pc@broadcom.com]
> Sent: Wednesday, December 14, 2016 4:49 PM
> To: 'Tomas Henzl'; 'jejb@kernel.org'; 'hch@infradead.org'
> Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;
> 'linux-kernel@vger.kernel.org'; Christopher Owens; Kiran Kumar Kasturi
> Subject: RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
> SAS3.5 Generic Megaraid Controllers
>
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Friday, December 09, 2016 7:55 AM
> To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
> Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
> linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
> kiran-kumar.kasturi@broadcom.com
> Subject: Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for
> SAS3.5 Generic Megaraid Controllers
>
> On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
>> SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap
> to have different
>> sizes for different number of supported VDs.
>>
>> This patch is depending on patch 5
>>
>> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
>> ---
>> drivers/scsi/megaraid/megaraid_sas.h | 7 +
>> drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++++--
>> drivers/scsi/megaraid/megaraid_sas_fp.c | 303
> ++++++++++++++++++++++++----
>> drivers/scsi/megaraid/megaraid_sas_fusion.c | 223 ++++++++++++++++----
>> drivers/scsi/megaraid/megaraid_sas_fusion.h | 240
> ++++++++++++++++++----
>> 5 files changed, 699 insertions(+), 135 deletions(-)
>>
>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
>> index f4d6a94..3e087ab 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>> @@ -1434,6 +1434,12 @@ enum FW_BOOT_CONTEXT {
>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
>> #define MR_MAX_MSIX_REG_ARRAY 16
>> #define MR_RDPQ_MODE_OFFSET 0X00800000
>> +
>> +#define MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT 16
>> +#define MR_MAX_RAID_MAP_SIZE_MASK 0x1FF
>> +#define MR_MIN_MAP_SIZE 0x10000
>> +/* 64k */
>> +
>> #define MR_CAN_HANDLE_SYNC_CACHE_OFFSET 0X01000000
>>
>> /*
>> @@ -2152,6 +2158,7 @@ struct megasas_instance {
>> bool fw_sync_cache_support;
>> bool is_ventura;
>> bool msix_combined;
>> + u16 max_raid_mapsize;
>> };
>> struct MR_LD_VF_MAP {
>> u32 size;
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
>> index c52f7be..3f06b57 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>> @@ -4424,8 +4424,7 @@ int megasas_alloc_cmds(struct megasas_instance
> *instance)
>> static void megasas_update_ext_vd_details(struct megasas_instance
> *instance)
>> {
>> struct fusion_context *fusion;
>> - u32 old_map_sz;
>> - u32 new_map_sz;
>> + u32 ventura_map_sz = 0;
>>
>> fusion = instance->ctrl_context;
>> /* For MFI based controllers return dummy success */
>> @@ -4455,21 +4454,39 @@ static void megasas_update_ext_vd_details(struct
> megasas_instance *instance)
>> instance->supportmax256vd ? "Extended VD(240 VD)firmware"
> :
>> "Legacy(64 VD) firmware");
>>
>> - old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
>> - (sizeof(struct MR_LD_SPAN_MAP) *
>> - (instance->fw_supported_vd_count - 1));
>> - new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>> - fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP) +
>> - (sizeof(struct MR_LD_SPAN_MAP) *
>> - (instance->drv_supported_vd_count - 1));
>> -
>> - fusion->max_map_sz = max(old_map_sz, new_map_sz);
>> + if (instance->max_raid_mapsize) {
>> + ventura_map_sz = instance->max_raid_mapsize *
>> + MR_MIN_MAP_SIZE; /* 64k */
>> + fusion->current_map_sz = ventura_map_sz;
>> + fusion->max_map_sz = ventura_map_sz;
>> + } else {
>> + fusion->old_map_sz = sizeof(struct MR_FW_RAID_MAP) +
>> + (sizeof(struct MR_LD_SPAN_MAP) *
>> + (instance->fw_supported_vd_count -
> 1));
>> + fusion->new_map_sz = sizeof(struct MR_FW_RAID_MAP_EXT);
>>
>> + fusion->max_map_sz =
>> + max(fusion->old_map_sz, fusion->new_map_sz);
>>
>> - if (instance->supportmax256vd)
>> - fusion->current_map_sz = new_map_sz;
>> - else
>> - fusion->current_map_sz = old_map_sz;
>> + if (instance->supportmax256vd)
>> + fusion->current_map_sz = fusion->new_map_sz;
>> + else
>> + fusion->current_map_sz = fusion->old_map_sz;
>> + }
>> + /* irrespective of FW raid maps, driver raid map is constant */
>> + fusion->drv_map_sz = sizeof(struct MR_DRV_RAID_MAP_ALL);
>> +#if VD_EXT_DEBUG
>> + dev_info(&instance->pdev->dev, "instance->max_raid_mapsize 0x%x \n
> ",
>> + instance->max_raid_mapsize);
>> + dev_info(&instance->pdev->dev,
>> + "new_map_sz = 0x%x, old_map_sz = 0x%x, "
>> + "ventura_map_sz = 0x%x, current_map_sz = 0x%x "
>> + "fusion->drv_map_sz =0x%x, size of driver raid map 0x%lx\n",
>> + fusion->new_map_sz, fusion->old_map_sz,
>> + ventura_map_sz, fusion->current_map_sz,
>> + fusion->drv_map_sz,
>> + sizeof(struct MR_DRV_RAID_MAP_ALL));
>> +#endif
>> }
>>
>> /**
>> @@ -5010,7 +5027,7 @@ static int megasas_init_fw(struct megasas_instance
> *instance)
>> {
>> u32 max_sectors_1;
>> u32 max_sectors_2;
>> - u32 tmp_sectors, msix_enable, scratch_pad_2;
>> + u32 tmp_sectors, msix_enable, scratch_pad_2, scratch_pad_3;
>> resource_size_t base_addr;
>> struct megasas_register_set __iomem *reg_set;
>> struct megasas_ctrl_info *ctrl_info = NULL;
>> @@ -5086,7 +5103,17 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>> goto fail_ready_state;
>> }
>>
>> -
>> + if (instance->is_ventura) {
>> + scratch_pad_3 =
>> + readl(&instance->reg_set->outbound_scratch_pad_3);
>> +#if VD_EXT_DEBUG
>> + dev_info(&instance->pdev->dev, "scratch_pad3 0x%x\n",
>> + scratch_pad_3);
>> +#endif
>> + instance->max_raid_mapsize = ((scratch_pad_3 >>
>> + MR_MAX_RAID_MAP_SIZE_OFFSET_SHIFT) &
>> + MR_MAX_RAID_MAP_SIZE_MASK);
>> + }
>>
>> /* Check if MSI-X is supported while in ready state */
>> msix_enable = (instance->instancet->read_fw_status_reg(reg_set) &
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
> b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> index eb9ff44..a6957a3 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> @@ -179,18 +179,204 @@ void MR_PopulateDrvRaidMap(struct
> megasas_instance *instance)
>> struct fusion_context *fusion = instance->ctrl_context;
>> struct MR_FW_RAID_MAP_ALL *fw_map_old = NULL;
>> struct MR_FW_RAID_MAP *pFwRaidMap = NULL;
>> - int i;
>> + int i, j;
>> u16 ld_count;
>> + struct MR_FW_RAID_MAP_DYNAMIC *fw_map_dyn;
>> + struct MR_FW_RAID_MAP_EXT *fw_map_ext;
>> + struct MR_RAID_MAP_DESC_TABLE *desc_table;
>>
>>
>> struct MR_DRV_RAID_MAP_ALL *drv_map =
>> fusion->ld_drv_map[(instance->map_id & 1)];
>> struct MR_DRV_RAID_MAP *pDrvRaidMap = &drv_map->raidMap;
>> + void *raid_map_data = NULL;
>> +
>> + memset(drv_map, 0, fusion->drv_map_sz);
>> + memset(pDrvRaidMap->ldTgtIdToLd,
>> + 0xff, (sizeof(u16) * MAX_LOGICAL_DRIVES_DYN));
>> +
>> + if (instance->max_raid_mapsize) {
>> + fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
>> +#if VD_EXT_DEBUG
>> + dev_dbg(&instance->pdev->dev,
>> + " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
>> + " descTableSize 0x%x descTableNumElements 0x%x\n",
>> + le32_to_cpu(fw_map_dyn->raid_map_size),
>> + le32_to_cpu(fw_map_dyn->desc_table_offset),
>> + le32_to_cpu(fw_map_dyn->desc_table_size),
>> + le32_to_cpu(fw_map_dyn->desc_table_num_elements));
>> + dev_dbg(&instance->pdev->dev,
>> + "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
>> +#endif
>> + desc_table =
>> + (struct MR_RAID_MAP_DESC_TABLE *)((void *)fw_map_dyn +
>> + le32_to_cpu(fw_map_dyn->desc_table_offset));
>> + if (desc_table != fw_map_dyn->raid_map_desc_table) {
>> + dev_err(&instance->pdev->dev,
>> + "offsets of desc table are not matching returning
> "
>> + " FW raid map has been changed: desc %p original
> %p\n",
>> + desc_table, fw_map_dyn->raid_map_desc_table);
>> + }
>> + ld_count = (u16)le16_to_cpu(fw_map_dyn->ld_count);
>> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
>> + pDrvRaidMap->fpPdIoTimeoutSec =
> fw_map_dyn->fp_pd_io_timeout_sec;
>> + pDrvRaidMap->totalSize = sizeof(struct
> MR_DRV_RAID_MAP_ALL);
>> + /* point to actual data starting point*/
>> + raid_map_data = (void *)fw_map_dyn +
>> + le32_to_cpu(fw_map_dyn->desc_table_offset) +
>> + le32_to_cpu(fw_map_dyn->desc_table_size);
>> +
>> + for (i = 0; i <
> le32_to_cpu(fw_map_dyn->desc_table_num_elements); ++i) {
>> + if (!desc_table) {
>> + dev_err(&instance->pdev->dev,
>> + "desc table is null, coming out %p \n",
> desc_table);
>> + return;
>> + }
> Is it possible that desc_table ever happens to NULL? It looks
> like a test something else was intended here ?
>
> It is a defensive check. yes can never be true and can be removed
Thanks, does it mean that you are going to post a v6 with this part removed
or that
you'd post an additional patch that removes the test?
It shall be removed in V6 patch
> Sasi
>
>
> Also all the VD_EXT_DEBUG macros make with bad indentation added
> make the code hard to read. Please fix it later in a follow up patch.
>
>
> Sasi - This shall be fixed in V5 patch
>
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "desc table %p \n", desc_table);
>> + dev_err(&instance->pdev->dev,
>> + "raidmap type %d, raidmapOffset 0x%x, "
>> + " raid map number of elements 0%x, raidmapsize
> 0x%x\n",
>> + desc_table->raid_map_desc_type,
>> + desc_table->raid_map_desc_offset,
>> + desc_table->raid_map_desc_elements,
>> + desc_table->raid_map_desc_buffer_size);
>> +#endif
>> + switch
> (le32_to_cpu(desc_table->raid_map_desc_type)) {
>> + case RAID_MAP_DESC_TYPE_DEVHDL_INFO:
>> + fw_map_dyn->dev_hndl_info = (struct
> MR_DEV_HANDLE_INFO *)
>> + (raid_map_data +
>> +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "devHndlInfo address %p\n",
>> + fw_map_dyn->dev_hndl_info);
>> +#endif
>> + memcpy(pDrvRaidMap->devHndlInfo,
> fw_map_dyn->dev_hndl_info,
>> + sizeof(struct MR_DEV_HANDLE_INFO)
> *
>> +
> le32_to_cpu(desc_table->raid_map_desc_elements));
>> + break;
>> + case RAID_MAP_DESC_TYPE_TGTID_INFO:
>> + fw_map_dyn->ld_tgt_id_to_ld = (u16
> *) (raid_map_data +
>> +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "ldTgtIdToLd address %p\n",
>> + fw_map_dyn->ld_tgt_id_to_ld);
>> +#endif
>> + for (j = 0; j <
> le32_to_cpu(desc_table->raid_map_desc_elements); j++) {
>> + pDrvRaidMap->ldTgtIdToLd[j] =
>> + fw_map_dyn->ld_tgt_id_to_ld[j];
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + " %d drv ldTgtIdToLd %d\n",
>> + j,
> pDrvRaidMap->ldTgtIdToLd[j]);
>> +#endif
>> + }
>> + break;
>> + case RAID_MAP_DESC_TYPE_ARRAY_INFO:
>> + fw_map_dyn->ar_map_info = (struct
> MR_ARRAY_INFO *)
>> + (raid_map_data +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "arMapInfo address %p\n",
>> + fw_map_dyn->ar_map_info);
>> +#endif
>> +
>> + memcpy(pDrvRaidMap->arMapInfo,
>> + fw_map_dyn->ar_map_info,
>> + sizeof(struct MR_ARRAY_INFO) *
>> +
> le32_to_cpu(desc_table->raid_map_desc_elements));
>> + break;
>> + case RAID_MAP_DESC_TYPE_SPAN_INFO:
>> + fw_map_dyn->ld_span_map = (struct
> MR_LD_SPAN_MAP *)
>> + (raid_map_data +
> le32_to_cpu(desc_table->raid_map_desc_offset));
>> + memcpy(pDrvRaidMap->ldSpanMap,
>> + fw_map_dyn->ld_span_map,
>> + sizeof(struct MR_LD_SPAN_MAP) *
>> +
> le32_to_cpu(desc_table->raid_map_desc_elements));
>> +#if VD_EXT_DEBUG
>> + dev_err(&instance->pdev->dev,
>> + "ldSpanMap address %p\n",
>> + fw_map_dyn->ld_span_map);
>> + dev_err(&instance->pdev->dev,
>> + "MR_LD_SPAN_MAP size 0x%lx\n",
> sizeof(struct MR_LD_SPAN_MAP));
>> + for (j = 0; j < ld_count; j++) {
>> + printk(KERN_DEBUG
> "megaraid_sas(%d) : fw_map_dyn->ldSpanMap[%d].ldRaid.targetId 0x%x
> fw_map_dyn->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
>> + j, j,
> fw_map_dyn->ld_span_map[j].ldRaid.targetId, j,
>> +
> fw_map_dyn->ld_span_map[j].ldRaid.seqNum,
>> +
> (u32)fw_map_dyn->ld_span_map[j].ldRaid.rowSize);
>> + printk(KERN_DEBUG
> "megaraid_sas(%d) :pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x
> pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
>> + j, j,
> pDrvRaidMap->ldSpanMap[j].ldRaid.targetId, j,
>> +
> pDrvRaidMap->ldSpanMap[j].ldRaid.seqNum,
>> +
> (u32)pDrvRaidMap->ldSpanMap[j].ldRaid.rowSize);
>> + printk(KERN_DEBUG
> "megaraid_sas(%d) : drv raid map all %p raid map %p LD RAID MAP %p/%p\n",
>> + instance->unique_id, drv_map,
> pDrvRaidMap,
>> +
> &fw_map_dyn->ld_span_map[j].ldRaid,
>> +
> &pDrvRaidMap->ldSpanMap[j].ldRaid);
>> + }
>> +#endif
>> + break;
>> + default:
>> + dev_err(&instance->pdev->dev,
>> + "wrong number of desctableElements
> %d\n",
>> +
> fw_map_dyn->desc_table_num_elements);
>> + }
>> + ++desc_table;
>> + }
>> +
>> + } else if (instance->supportmax256vd) {
>> + fw_map_ext =
>> + (struct MR_FW_RAID_MAP_EXT *)
> fusion->ld_map[(instance->map_id & 1)];
>> + ld_count = (u16)le16_to_cpu(fw_map_ext->ldCount);
>> + if (ld_count > MAX_LOGICAL_DRIVES_EXT) {
>> + printk(KERN_DEBUG "megaraid_sas: LD count exposed
> in RAID map in not valid\n");
>> + return;
>> + }
>> +#if VD_EXT_DEBUG
>> + for (i = 0; i < ld_count; i++) {
>> + printk(KERN_DEBUG "megaraid_sas(%d) :Index 0x%x
> Target Id 0x%x Seq Num 0x%x Size 0/%llx\n",
>> + instance->unique_id,
>> + i,
> fw_map_ext->ldSpanMap[i].ldRaid.targetId,
>> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
>> + fw_map_ext->ldSpanMap[i].ldRaid.size);
>> + }
>> +#endif
>> +
>> + pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
>> + pDrvRaidMap->fpPdIoTimeoutSec =
>> +
> fw_map_ext->fpPdIoTimeoutSec;
>> + for (i = 0; i < (MAX_LOGICAL_DRIVES_EXT); i++)
>> + pDrvRaidMap->ldTgtIdToLd[i] =
>> + (u16)fw_map_ext->ldTgtIdToLd[i];
>> + memcpy(pDrvRaidMap->ldSpanMap,
>> + fw_map_ext->ldSpanMap,
>> + sizeof(struct MR_LD_SPAN_MAP) *
>> + ld_count);
>> +#if VD_EXT_DEBUG
>> + for (i = 0; i < ld_count; i++) {
>> + printk(KERN_DEBUG "megaraid_sas(%d) :
> fw_map_ext->ldSpanMap[%d].ldRaid.targetId 0x%x
> fw_map_ext->ldSpanMap[%d].ldRaid.seqNum 0x%x size 0x%x\n",
>> + i, i, fw_map_ext->ldSpanMap[i].ldRaid.targetId, i,
>> + fw_map_ext->ldSpanMap[i].ldRaid.seqNum,
>> + (u32)fw_map_ext->ldSpanMap[i].ldRaid.rowSize);
>> + printk(KERN_DEBUG "megaraid_sas(%d) :
> pDrvRaidMap->ldSpanMap[%d].ldRaid.targetId 0x%x"
>> + "pDrvRaidMap->ldSpanMap[%d].ldRaid.seqNum 0x%x
> size 0x%x\n",
>> + i, i, pDrvRaidMap->ldSpanMap[i].ldRaid.targetId,
> i,
>> + pDrvRaidMap->ldSpanMap[i].ldRaid.seqNum,
>> + (u32)pDrvRaidMap->ldSpanMap[i].ldRaid.rowSize);
>> + printk(KERN_DEBUG "megaraid_sas(%d) : drv raid map
> all %p raid map %p LD RAID MAP %p %p\n",
>> + instance->unique_id, drv_map, pDrvRaidMap,
>> + &fw_map_ext->ldSpanMap[i].ldRaid,
>> + &pDrvRaidMap->ldSpanMap[i].ldRaid);
>> + }
>> +#endif
>> + memcpy(pDrvRaidMap->arMapInfo, fw_map_ext->arMapInfo,
>> + sizeof(struct MR_ARRAY_INFO) *
> MAX_API_ARRAYS_EXT);
>> + memcpy(pDrvRaidMap->devHndlInfo, fw_map_ext->devHndlInfo,
>> + sizeof(struct MR_DEV_HANDLE_INFO) *
>> + MAX_RAIDMAP_PHYSICAL_DEVICES);
>>
>> - if (instance->supportmax256vd) {
>> - memcpy(fusion->ld_drv_map[instance->map_id & 1],
>> - fusion->ld_map[instance->map_id & 1],
>> - fusion->current_map_sz);
>> /* New Raid map will not set totalSize, so keep expected
> value
>> * for legacy code in ValidateMapInfo
>> */
>> @@ -213,16 +399,12 @@ void MR_PopulateDrvRaidMap(struct megasas_instance
> *instance)
>> }
>> #endif
>>
>> - memset(drv_map, 0, fusion->drv_map_sz);
>> pDrvRaidMap->totalSize = pFwRaidMap->totalSize;
>> pDrvRaidMap->ldCount = (__le16)cpu_to_le16(ld_count);
>> pDrvRaidMap->fpPdIoTimeoutSec =
> pFwRaidMap->fpPdIoTimeoutSec;
>> for (i = 0; i < MAX_RAIDMAP_LOGICAL_DRIVES +
> MAX_RAIDMAP_VIEWS; i++)
>> pDrvRaidMap->ldTgtIdToLd[i] =
>> (u8)pFwRaidMap->ldTgtIdToLd[i];
>> - for (i = (MAX_RAIDMAP_LOGICAL_DRIVES + MAX_RAIDMAP_VIEWS);
>> - i < MAX_LOGICAL_DRIVES_EXT; i++)
>> - pDrvRaidMap->ldTgtIdToLd[i] = 0xff;
>> for (i = 0; i < ld_count; i++) {
>> pDrvRaidMap->ldSpanMap[i] =
> pFwRaidMap->ldSpanMap[i];
>> #if VD_EXT_DEBUG
>> @@ -279,7 +461,9 @@ u8 MR_ValidateMapInfo(struct megasas_instance
> *instance)
>> lbInfo = fusion->load_balance_info;
>> ldSpanInfo = fusion->log_to_span;
>>
>> - if (instance->supportmax256vd)
>> + if (instance->max_raid_mapsize)
>> + expected_size = sizeof(struct MR_DRV_RAID_MAP_ALL);
>> + else if (instance->supportmax256vd)
>> expected_size = sizeof(struct MR_FW_RAID_MAP_EXT);
>> else
>> expected_size =
>> @@ -287,8 +471,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance
> *instance)
>> (sizeof(struct MR_LD_SPAN_MAP) *
> le16_to_cpu(pDrvRaidMap->ldCount)));
>> if (le32_to_cpu(pDrvRaidMap->totalSize) != expected_size) {
>> - dev_err(&instance->pdev->dev, "map info structure size
> 0x%x is not matching with ld count\n",
>> - (unsigned int) expected_size);
>> + dev_err(&instance->pdev->dev, "megasas: map info
> structure"
>> + " size 0x%x is not matching expected size 0x%x\n",
>> + le32_to_cpu(pDrvRaidMap->totalSize),
>> + (unsigned int) expected_size);
>> dev_err(&instance->pdev->dev, "megasas: span map %x,
> pDrvRaidMap->totalSize : %x\n",
>> (unsigned int)sizeof(struct MR_LD_SPAN_MAP),
>> le32_to_cpu(pDrvRaidMap->totalSize));
>> @@ -787,7 +973,7 @@ static u8 mr_spanset_get_phy_params(struct
> megasas_instance *instance, u32 ld,
>> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
>> ((fusion->adapter_type == INVADER_SERIES) &&
>> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
>> - pRAID_Context->regLockFlags =
> REGION_TYPE_EXCLUSIVE;
>> + pRAID_Context->reg_lock_flags =
> REGION_TYPE_EXCLUSIVE;
>> else if (raid->level == 1) {
>> physArm = physArm + 1;
>> pd = MR_ArPdGet(arRef, physArm, map);
>> @@ -797,9 +983,16 @@ static u8 mr_spanset_get_phy_params(struct
> megasas_instance *instance, u32 ld,
>> }
>>
>> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
> map)->startBlk);
>> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
>> - physArm;
>> - io_info->span_arm = pRAID_Context->spanArm;
>> + if (instance->is_ventura) {
>> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + io_info->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + } else {
>> + pRAID_Context->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + io_info->span_arm = pRAID_Context->span_arm;
>> + }
>> return retval;
>> }
>>
>> @@ -891,7 +1084,7 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> ((fusion->adapter_type == THUNDERBOLT_SERIES) ||
>> ((fusion->adapter_type == INVADER_SERIES) &&
>> (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
>> - pRAID_Context->regLockFlags =
> REGION_TYPE_EXCLUSIVE;
>> + pRAID_Context->reg_lock_flags =
> REGION_TYPE_EXCLUSIVE;
>> else if (raid->level == 1) {
>> /* Get alternate Pd. */
>> physArm = physArm + 1;
>> @@ -903,9 +1096,16 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> }
>>
>> *pdBlock += stripRef + le64_to_cpu(MR_LdSpanPtrGet(ld, span,
> map)->startBlk);
>> - pRAID_Context->spanArm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
>> - physArm;
>> - io_info->span_arm = pRAID_Context->spanArm;
>> + if (instance->is_ventura) {
>> + ((struct RAID_CONTEXT_G35 *) pRAID_Context)->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> physArm;
>> + io_info->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> physArm;
>> + } else {
>> + pRAID_Context->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | physArm;
>> + io_info->span_arm = pRAID_Context->span_arm;
>> + }
>> return retval;
>> }
>>
>> @@ -1109,20 +1309,20 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> regSize += stripSize;
>> }
>>
>> - pRAID_Context->timeoutValue =
>> + pRAID_Context->timeout_value =
>> cpu_to_le16(raid->fpIoTimeoutForLd ?
>> raid->fpIoTimeoutForLd :
>> map->raidMap.fpPdIoTimeoutSec);
>> if (fusion->adapter_type == INVADER_SERIES)
>> - pRAID_Context->regLockFlags = (isRead) ?
>> + pRAID_Context->reg_lock_flags = (isRead) ?
>> raid->regTypeReqOnRead : raid->regTypeReqOnWrite;
>> - else
>> - pRAID_Context->regLockFlags = (isRead) ?
>> + else if (!instance->is_ventura)
>> + pRAID_Context->reg_lock_flags = (isRead) ?
>> REGION_TYPE_SHARED_READ : raid->regTypeReqOnWrite;
>> - pRAID_Context->VirtualDiskTgtId = raid->targetId;
>> - pRAID_Context->regLockRowLBA = cpu_to_le64(regStart);
>> - pRAID_Context->regLockLength = cpu_to_le32(regSize);
>> - pRAID_Context->configSeqNum = raid->seqNum;
>> + pRAID_Context->virtual_disk_tgt_id = raid->targetId;
>> + pRAID_Context->reg_lock_row_lba = cpu_to_le64(regStart);
>> + pRAID_Context->reg_lock_length = cpu_to_le32(regSize);
>> + pRAID_Context->config_seq_num = raid->seqNum;
>> /* save pointer to raid->LUN array */
>> *raidLUN = raid->LUN;
>>
>> @@ -1140,6 +1340,14 @@ u8 MR_GetPhyParams(struct megasas_instance
> *instance, u32 ld, u64 stripRow,
>> /* If IO on an invalid Pd, then FP is not possible.*/
>> if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
>> io_info->fpOkForIo = FALSE;
>> + /* if FP possible, set the SLUD bit in
>> + * regLockFlags for ventura
>> + */
>> + else if ((instance->is_ventura) && !isRead &&
>> + (raid->writeMode == MR_RL_WRITE_BACK_MODE)
> &&
>> + raid->capability.fp_cache_bypass_capable)
>> + ((struct RAID_CONTEXT_G35 *)
> pRAID_Context)->routing_flags.bits.sld
>> + = 1;
>> /* set raid 1/10 fast path write capable bit in io_info */
>> if (io_info->fpOkForIo &&
>> (io_info->r1_alt_dev_handle != MR_PD_INVALID) &&
>> @@ -1319,6 +1527,7 @@ u8 megasas_get_best_arm_pd(struct megasas_instance
> *instance,
>> struct fusion_context *fusion;
>> struct MR_LD_RAID *raid;
>> struct MR_DRV_RAID_MAP_ALL *drv_map;
>> + u16 pd1_dev_handle;
>> u16 pend0, pend1, ld;
>> u64 diff0, diff1;
>> u8 bestArm, pd0, pd1, span, arm;
>> @@ -1344,23 +1553,37 @@ u8 megasas_get_best_arm_pd(struct
> megasas_instance *instance,
>> pd1 = MR_ArPdGet(arRef, (arm + 1) >= span_row_size ?
>> (arm + 1 - span_row_size) : arm + 1, drv_map);
>>
>> - /* get the pending cmds for the data and mirror arms */
>> - pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
>> - pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
>> + /* Get PD1 Dev Handle */
>>
>> - /* Determine the disk whose head is nearer to the req. block */
>> - diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
>> - diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
>> - bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
>> + pd1_dev_handle = MR_PdDevHandleGet(pd1, drv_map);
>>
>> - if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds) ||
>> + if (pd1_dev_handle == MR_PD_INVALID) {
>> + bestArm = arm;
>> + } else {
>> + /* get the pending cmds for the data and mirror arms */
>> + pend0 = atomic_read(&lbInfo->scsi_pending_cmds[pd0]);
>> + pend1 = atomic_read(&lbInfo->scsi_pending_cmds[pd1]);
>> +
>> + /* Determine the disk whose head is nearer to the req.
> block */
>> + diff0 = ABS_DIFF(block, lbInfo->last_accessed_block[pd0]);
>> + diff1 = ABS_DIFF(block, lbInfo->last_accessed_block[pd1]);
>> + /*bestArm = diff0<=diff1 ? arm : arm ^ 1;*/
>> + bestArm = (diff0 <= diff1 ? arm : arm ^ 1);
> The above comment is useless and the parentheses not needed,
> again please clean it up in a next series.
> Sasi - This shall be fixed in V5 patch
>
> tomash
>
>> +
>> + /* Make balance count from 16 to 4 to
>> + * keep driver in sync with Firmware
>> + */
>> + if ((bestArm == arm && pend0 > pend1 + lb_pending_cmds)
> ||
>> (bestArm != arm && pend1 > pend0 +
> lb_pending_cmds))
>> - bestArm ^= 1;
>> + bestArm ^= 1;
>> +
>> + /* Update the last accessed block on the correct pd */
>> + io_info->span_arm =
>> + (span << RAID_CTX_SPANARM_SPAN_SHIFT) | bestArm;
>> + io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
>> + }
>>
>> - /* Update the last accessed block on the correct pd */
>> - io_info->pd_after_lb = (bestArm == arm) ? pd0 : pd1;
>> lbInfo->last_accessed_block[io_info->pd_after_lb] = block + count
> - 1;
>> - io_info->span_arm = (span << RAID_CTX_SPANARM_SPAN_SHIFT) |
> bestArm;
>> #if SPAN_DEBUG
>> if (arm != bestArm)
>> dev_dbg(&instance->pdev->dev, "LSI Debug R1 Load balance "
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> index 2fcd5cd..58f86aa 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> @@ -1834,7 +1834,7 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> struct megasas_cmd_fusion *cmd)
>> {
>> u8 fp_possible;
>> - u32 start_lba_lo, start_lba_hi, device_id, datalength = 0;
>> + u32 start_lba_lo, start_lba_hi, device_id, datalength = 0, ld;
>> struct MPI2_RAID_SCSI_IO_REQUEST *io_request;
>> union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc;
>> struct IO_REQUEST_INFO io_info;
>> @@ -1842,16 +1842,18 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
>> u8 *raidLUN;
>> unsigned long spinlock_flags;
>> + union RAID_CONTEXT_UNION *praid_context;
>> + struct MR_LD_RAID *raid;
>>
>> device_id = MEGASAS_DEV_INDEX(scp);
>>
>> fusion = instance->ctrl_context;
>>
>> io_request = cmd->io_request;
>> - io_request->RaidContext.raid_context.VirtualDiskTgtId =
>> + io_request->RaidContext.raid_context.virtual_disk_tgt_id =
>> cpu_to_le16(device_id);
>> io_request->RaidContext.raid_context.status = 0;
>> - io_request->RaidContext.raid_context.exStatus = 0;
>> + io_request->RaidContext.raid_context.ex_status = 0;
>>
>> req_desc = (union MEGASAS_REQUEST_DESCRIPTOR_UNION
> *)cmd->request_desc;
>> @@ -1920,10 +1922,12 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> io_info.isRead = 1;
>>
>> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
>> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
>> + raid = MR_LdRaidGet(ld, local_map_ptr);
>>
>> if ((MR_TargetIdToLdGet(device_id, local_map_ptr) >=
>> instance->fw_supported_vd_count) ||
> (!fusion->fast_path_io)) {
>> - io_request->RaidContext.raid_context.regLockFlags = 0;
>> + io_request->RaidContext.raid_context.reg_lock_flags = 0;
>> fp_possible = 0;
>> } else {
>> if (MR_BuildRaidContext(instance, &io_info,
>> @@ -1950,6 +1954,8 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> fp_possible = false;
>> }
>>
>> + praid_context = &io_request->RaidContext;
>> +
>> if (fp_possible) {
>> megasas_set_pd_lba(io_request, scp->cmd_len, &io_info,
> scp,
>> local_map_ptr, start_lba_lo);
>> @@ -1958,18 +1964,26 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> (MPI2_REQ_DESCRIPT_FLAGS_FP_IO
>> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> if (fusion->adapter_type == INVADER_SERIES) {
>> - if
> (io_request->RaidContext.raid_context.regLockFlags ==
>> + if
> (io_request->RaidContext.raid_context.reg_lock_flags ==
>> REGION_TYPE_UNUSED)
>> cmd->request_desc->SCSIIO.RequestFlags =
>>
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> - io_request->RaidContext.raid_context.Type
>> + io_request->RaidContext.raid_context.type
>> = MPI2_TYPE_CUDA;
>> io_request->RaidContext.raid_context.nseg = 0x1;
>> io_request->IoFlags |=
> cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
>> - io_request->RaidContext.raid_context.regLockFlags
> |=
>> +
> io_request->RaidContext.raid_context.reg_lock_flags |=
>> (MR_RL_FLAGS_GRANT_DESTINATION_CUDA |
>> MR_RL_FLAGS_SEQ_NUM_ENABLE);
>> + } else if (instance->is_ventura) {
>> + io_request->RaidContext.raid_context_g35.type
>> + = MPI2_TYPE_CUDA;
>> + io_request->RaidContext.raid_context_g35.nseg =
> 0x1;
>> +
> io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
>> + = 1;
>> + io_request->IoFlags |=
>> +
> cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
>> }
>> if ((fusion->load_balance_info[device_id].loadBalanceFlag)
> &&
>> (io_info.isRead)) {
>> @@ -1979,6 +1993,13 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> &io_info);
>> scp->SCp.Status |= MEGASAS_LOAD_BALANCE_FLAG;
>> cmd->pd_r1_lb = io_info.pd_after_lb;
>> + if (instance->is_ventura)
>> +
> io_request->RaidContext.raid_context_g35.span_arm
>> + = io_info.span_arm;
>> + else
>> +
> io_request->RaidContext.raid_context.span_arm
>> + = io_info.span_arm;
>> +
>> } else
>> scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
>>
>> @@ -1997,28 +2018,98 @@ static void megasas_stream_detect(struct
> megasas_instance *instance,
>> io_request->DevHandle = io_info.devHandle;
>> /* populate the LUN field */
>> memcpy(io_request->LUN, raidLUN, 8);
>> + if (instance->is_ventura) {
>> + if (io_info.isRead) {
>> + if ((raid->cpuAffinity.pdRead.cpu0) &&
>> + (raid->cpuAffinity.pdRead.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.pdRead.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + } else {
>> + if ((raid->cpuAffinity.pdWrite.cpu0)
>> + && (raid->cpuAffinity.pdWrite.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.pdWrite.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + if
> (praid_context->raid_context_g35.routing_flags.bits.sld) {
>> +
> praid_context->raid_context_g35.raid_flags
>> + =
> (MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
>> + <<
> MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
>> + }
>> + }
>> + }
>> } else {
>> - io_request->RaidContext.raid_context.timeoutValue =
>> + io_request->RaidContext.raid_context.timeout_value =
>>
> cpu_to_le16(local_map_ptr->raidMap.fpPdIoTimeoutSec);
>> cmd->request_desc->SCSIIO.RequestFlags =
>> (MEGASAS_REQ_DESCRIPT_FLAGS_LD_IO
>> << MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> if (fusion->adapter_type == INVADER_SERIES) {
>> if (io_info.do_fp_rlbypass ||
>> - (io_request->RaidContext.raid_context.regLockFlags
>> +
> (io_request->RaidContext.raid_context.reg_lock_flags
>> == REGION_TYPE_UNUSED))
>> cmd->request_desc->SCSIIO.RequestFlags =
>>
> (MEGASAS_REQ_DESCRIPT_FLAGS_NO_LOCK <<
> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> - io_request->RaidContext.raid_context.Type
>> + io_request->RaidContext.raid_context.type
>> = MPI2_TYPE_CUDA;
>> - io_request->RaidContext.raid_context.regLockFlags
> |=
>> +
> io_request->RaidContext.raid_context.reg_lock_flags |=
>> (MR_RL_FLAGS_GRANT_DESTINATION_CPU0 |
>> MR_RL_FLAGS_SEQ_NUM_ENABLE);
>> io_request->RaidContext.raid_context.nseg = 0x1;
>> + } else if (instance->is_ventura) {
>> + io_request->RaidContext.raid_context_g35.type
>> + = MPI2_TYPE_CUDA;
>> +
> io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
>> + = 1;
>> + io_request->RaidContext.raid_context_g35.nseg =
> 0x1;
>> }
>> io_request->Function =
> MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
>> io_request->DevHandle = cpu_to_le16(device_id);
>> +
>> + if (instance->is_ventura) {
>> + if (io_info.isRead) {
>> + if ((raid->cpuAffinity.ldRead.cpu0)
>> + && (raid->cpuAffinity.ldRead.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldRead.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + } else {
>> + if ((raid->cpuAffinity.ldWrite.cpu0) &&
>> + (raid->cpuAffinity.ldWrite.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + =
> MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldWrite.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> +
>> + if
> (io_request->RaidContext.raid_context_g35.stream_detected
>> + && (raid->level == 5)
>> + && (raid->writeMode ==
> MR_RL_WRITE_THROUGH_MODE)) {
>> + if
> (praid_context->raid_context_g35.routing_flags.bits.cpu_sel ==
> MR_RAID_CTX_CPUSEL_FCFS)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + =
> MR_RAID_CTX_CPUSEL_0;
>> + }
>> + }
>> + }
>> } /* Not FP */
>> }
>>
>> @@ -2053,9 +2144,9 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> /* get RAID_Context pointer */
>> pRAID_Context = &io_request->RaidContext.raid_context;
>> /* Check with FW team */
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> - pRAID_Context->regLockRowLBA = 0;
>> - pRAID_Context->regLockLength = 0;
>> + pRAID_Context->virtual_disk_tgt_id = cpu_to_le16(device_id);
>> + pRAID_Context->reg_lock_row_lba = 0;
>> + pRAID_Context->reg_lock_length = 0;
>>
>> if (fusion->fast_path_io && (
>> device_id < instance->fw_supported_vd_count)) {
>> @@ -2074,7 +2165,7 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> io_request->Function =
> MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST;
>> io_request->DevHandle = cpu_to_le16(device_id);
>> io_request->LUN[1] = scmd->device->lun;
>> - pRAID_Context->timeoutValue =
>> + pRAID_Context->timeout_value =
>> cpu_to_le16 (scmd->request->timeout / HZ);
>> cmd->request_desc->SCSIIO.RequestFlags =
>> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
>> @@ -2082,9 +2173,10 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> } else {
>>
>> /* set RAID context values */
>> - pRAID_Context->configSeqNum = raid->seqNum;
>> - pRAID_Context->regLockFlags = REGION_TYPE_SHARED_READ;
>> - pRAID_Context->timeoutValue =
> cpu_to_le16(raid->fpIoTimeoutForLd);
>> + pRAID_Context->config_seq_num = raid->seqNum;
>> + if (!instance->is_ventura)
>> + pRAID_Context->reg_lock_flags =
> REGION_TYPE_SHARED_READ;
>> + pRAID_Context->timeout_value =
> cpu_to_le16(raid->fpIoTimeoutForLd);
>> /* get the DevHandle for the PD (since this is
>> fpNonRWCapable, this is a single disk RAID0) */
>> @@ -2139,12 +2231,12 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> io_request = cmd->io_request;
>> /* get RAID_Context pointer */
>> pRAID_Context = &io_request->RaidContext.raid_context;
>> - pRAID_Context->regLockFlags = 0;
>> - pRAID_Context->regLockRowLBA = 0;
>> - pRAID_Context->regLockLength = 0;
>> + pRAID_Context->reg_lock_flags = 0;
>> + pRAID_Context->reg_lock_row_lba = 0;
>> + pRAID_Context->reg_lock_length = 0;
>> io_request->DataLength = cpu_to_le32(scsi_bufflen(scmd));
>> io_request->LUN[1] = scmd->device->lun;
>> - pRAID_Context->RAIDFlags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
>> + pRAID_Context->raid_flags = MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD
>> << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
>>
>> /* If FW supports PD sequence number */
>> @@ -2153,24 +2245,28 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> /* TgtId must be incremented by 255 as jbod seq number is
> index
>> * below raid map
>> */
>> - pRAID_Context->VirtualDiskTgtId =
>> + pRAID_Context->virtual_disk_tgt_id =
>> cpu_to_le16(device_id + (MAX_PHYSICAL_DEVICES -
> 1));
>> - pRAID_Context->configSeqNum =
> pd_sync->seq[pd_index].seqNum;
>> + pRAID_Context->config_seq_num =
> pd_sync->seq[pd_index].seqNum;
>> io_request->DevHandle = pd_sync->seq[pd_index].devHandle;
>> - pRAID_Context->regLockFlags |=
>> + if (instance->is_ventura)
>> +
> io_request->RaidContext.raid_context_g35.routing_flags.bits.sqn
>> + = 1;
>> + else
>> + pRAID_Context->reg_lock_flags |=
>>
> (MR_RL_FLAGS_SEQ_NUM_ENABLE|MR_RL_FLAGS_GRANT_DESTINATION_CUDA);
>> - pRAID_Context->Type = MPI2_TYPE_CUDA;
>> + pRAID_Context->type = MPI2_TYPE_CUDA;
>> pRAID_Context->nseg = 0x1;
>> } else if (fusion->fast_path_io) {
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> - pRAID_Context->configSeqNum = 0;
>> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id);
>> + pRAID_Context->config_seq_num = 0;
>> local_map_ptr = fusion->ld_drv_map[(instance->map_id &
> 1)];
>> io_request->DevHandle =
>>
> local_map_ptr->raidMap.devHndlInfo[device_id].curDevHdl;
>> } else {
>> /* Want to send all IO via FW path */
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> - pRAID_Context->configSeqNum = 0;
>> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id);
>> + pRAID_Context->config_seq_num = 0;
>> io_request->DevHandle = cpu_to_le16(0xFFFF);
>> }
>>
>> @@ -2186,14 +2282,14 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> cmd->request_desc->SCSIIO.RequestFlags =
>> (MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO <<
>> MEGASAS_REQ_DESCRIPT_FLAGS_TYPE_SHIFT);
>> - pRAID_Context->timeoutValue =
> cpu_to_le16(os_timeout_value);
>> - pRAID_Context->VirtualDiskTgtId = cpu_to_le16(device_id);
>> + pRAID_Context->timeout_value =
> cpu_to_le16(os_timeout_value);
>> + pRAID_Context->virtual_disk_tgt_id =
> cpu_to_le16(device_id);
>> } else {
>> /* system pd Fast Path */
>> io_request->Function = MPI2_FUNCTION_SCSI_IO_REQUEST;
>> timeout_limit = (scmd->device->type == TYPE_DISK) ?
>> 255 : 0xFFFF;
>> - pRAID_Context->timeoutValue =
>> + pRAID_Context->timeout_value =
>> cpu_to_le16((os_timeout_value > timeout_limit) ?
>> timeout_limit : os_timeout_value);
>> if (fusion->adapter_type == INVADER_SERIES)
>> @@ -2232,8 +2328,8 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> io_request->Control = 0;
>> io_request->EEDPBlockSize = 0;
>> io_request->ChainOffset = 0;
>> - io_request->RaidContext.raid_context.RAIDFlags = 0;
>> - io_request->RaidContext.raid_context.Type = 0;
>> + io_request->RaidContext.raid_context.raid_flags = 0;
>> + io_request->RaidContext.raid_context.type = 0;
>> io_request->RaidContext.raid_context.nseg = 0;
>>
>> memcpy(io_request->CDB.CDB32, scp->cmnd, scp->cmd_len);
>> @@ -2278,11 +2374,16 @@ static void megasas_build_ld_nonrw_fusion(struct
> megasas_instance *instance,
>> return 1;
>> }
>>
>> - /* numSGE store lower 8 bit of sge_count.
>> - * numSGEExt store higher 8 bit of sge_count
>> - */
>> - io_request->RaidContext.raid_context.numSGE = sge_count;
>> - io_request->RaidContext.raid_context.numSGEExt = (u8)(sge_count >>
> 8);
>> + if (instance->is_ventura)
>> + io_request->RaidContext.raid_context_g35.num_sge =
> sge_count;
>> + else {
>> + /* numSGE store lower 8 bit of sge_count.
>> + * numSGEExt store higher 8 bit of sge_count
>> + */
>> + io_request->RaidContext.raid_context.num_sge = sge_count;
>> + io_request->RaidContext.raid_context.num_sge_ext =
>> + (u8)(sge_count >> 8);
>> + }
>>
>> io_request->SGLFlags =
> cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>> @@ -2331,6 +2432,10 @@ void megasas_fpio_to_ldio(struct megasas_instance
> *instance,
>> struct megasas_cmd_fusion *cmd, struct scsi_cmnd *scmd)
>> {
>> struct fusion_context *fusion;
>> + union RAID_CONTEXT_UNION *praid_context;
>> + struct MR_LD_RAID *raid;
>> + struct MR_DRV_RAID_MAP_ALL *local_map_ptr;
>> + u32 device_id, ld;
>> fusion = instance->ctrl_context;
>>
>> cmd->request_desc->SCSIIO.RequestFlags =
>> @@ -2354,6 +2459,35 @@ void megasas_fpio_to_ldio(struct megasas_instance
> *instance,
>> cmd->io_request->Control = 0;
>> cmd->io_request->EEDPBlockSize = 0;
>> cmd->is_raid_1_fp_write = 0;
>> +
>> + device_id = MEGASAS_DEV_INDEX(cmd->scmd);
>> + local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
>> + ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
>> + raid = MR_LdRaidGet(ld, local_map_ptr);
>> + praid_context = &cmd->io_request->RaidContext;
>> + if (cmd->scmd->sc_data_direction == PCI_DMA_FROMDEVICE) {
>> + if ((raid->cpuAffinity.ldRead.cpu0)
>> + && (raid->cpuAffinity.ldRead.cpu1))
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldRead.cpu1)
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> +
> praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + } else {
>> + if ((raid->cpuAffinity.ldWrite.cpu0)
>> + && (raid->cpuAffinity.ldWrite.cpu1))
>> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_FCFS;
>> + else if (raid->cpuAffinity.ldWrite.cpu1)
>> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_1;
>> + else
>> + praid_context->raid_context_g35.routing_flags.bits.cpu_sel
>> + = MR_RAID_CTX_CPUSEL_0;
>> + }
>> }
>> /*megasas_prepate_secondRaid1_IO
>> * It prepares the raid 1 second IO
>> @@ -2491,6 +2625,7 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> * corresponds to single R1/10 LD are always same
>> *
>> */
>> +
>> /* driver side count always should be less than max_fw_cmds
>> * to get new command
>> */
>> @@ -2588,7 +2723,7 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> scmd_local = cmd_fusion->scmd;
>> status = scsi_io_req->RaidContext.raid_context.status;
>> - extStatus =
> scsi_io_req->RaidContext.raid_context.exStatus;
>> + extStatus =
> scsi_io_req->RaidContext.raid_context.ex_status;
>> sense = cmd_fusion->sense;
>> data_length = scsi_io_req->DataLength;
>>
>> @@ -2656,13 +2791,13 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> status =
>>
> r1_cmd->io_request->RaidContext.raid_context.status;
>> extStatus =
>> -
> r1_cmd->io_request->RaidContext.raid_context.exStatus;
>> +
> r1_cmd->io_request->RaidContext.raid_context.ex_status;
>> data_length =
>>
> r1_cmd->io_request->DataLength;
>> sense = r1_cmd->sense;
>> }
>>
> r1_cmd->io_request->RaidContext.raid_context.status = 0;
>> -
> r1_cmd->io_request->RaidContext.raid_context.exStatus = 0;
>> +
> r1_cmd->io_request->RaidContext.raid_context.ex_status = 0;
>> cmd_fusion->is_raid_1_fp_write = 0;
>> r1_cmd->is_raid_1_fp_write = 0;
>> r1_cmd->cmd_completed = false;
>> @@ -2674,7 +2809,7 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> extStatus, data_length, sense);
>>
> scsi_io_req->RaidContext.raid_context.status
>> = 0;
>> -
> scsi_io_req->RaidContext.raid_context.exStatus
>> +
> scsi_io_req->RaidContext.raid_context.ex_status
>> = 0;
>> megasas_return_cmd_fusion(instance,
> cmd_fusion);
>> scsi_dma_unmap(scmd_local);
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> index 5590c1d..cb42655 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> @@ -59,6 +59,8 @@
>> #define MR_RL_FLAGS_GRANT_DESTINATION_CPU1 0x10
>> #define MR_RL_FLAGS_GRANT_DESTINATION_CUDA 0x80
>> #define MR_RL_FLAGS_SEQ_NUM_ENABLE 0x8
>> +#define MR_RL_WRITE_THROUGH_MODE 0x00
>> +#define MR_RL_WRITE_BACK_MODE 0x01
>>
>> /* T10 PI defines */
>> #define MR_PROT_INFO_TYPE_CONTROLLER 0x8
>> @@ -81,6 +83,11 @@
>> enum MR_RAID_FLAGS_IO_SUB_TYPE {
>> MR_RAID_FLAGS_IO_SUB_TYPE_NONE = 0,
>> MR_RAID_FLAGS_IO_SUB_TYPE_SYSTEM_PD = 1,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_DATA = 2,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_P = 3,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_RMW_Q = 4,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS = 6,
>> + MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT = 7
>> };
>>
>> /*
>> @@ -109,29 +116,29 @@ enum MR_FUSION_ADAPTER_TYPE {
>>
>> struct RAID_CONTEXT {
>> #if defined(__BIG_ENDIAN_BITFIELD)
>> - u8 nseg:4;
>> - u8 Type:4;
>> + u8 nseg:4;
>> + u8 type:4;
>> #else
>> - u8 Type:4;
>> - u8 nseg:4;
>> + u8 type:4;
>> + u8 nseg:4;
>> #endif
>> - u8 resvd0;
>> - __le16 timeoutValue;
>> - u8 regLockFlags;
>> - u8 resvd1;
>> - __le16 VirtualDiskTgtId;
>> - __le64 regLockRowLBA;
>> - __le32 regLockLength;
>> - __le16 nextLMId;
>> - u8 exStatus;
>> - u8 status;
>> - u8 RAIDFlags;
>> - u8 numSGE;
>> - __le16 configSeqNum;
>> - u8 spanArm;
>> - u8 priority;
>> - u8 numSGEExt;
>> - u8 resvd2;
>> + u8 resvd0;
>> + __le16 timeout_value;
>> + u8 reg_lock_flags;
>> + u8 resvd1;
>> + __le16 virtual_disk_tgt_id;
>> + __le64 reg_lock_row_lba;
>> + __le32 reg_lock_length;
>> + __le16 next_lmid;
>> + u8 ex_status;
>> + u8 status;
>> + u8 raid_flags;
>> + u8 num_sge;
>> + __le16 config_seq_num;
>> + u8 span_arm;
>> + u8 priority;
>> + u8 num_sge_ext;
>> + u8 resvd2;
>> };
>>
>> /*
>> @@ -187,7 +194,7 @@ struct RAID_CONTEXT_G35 {
>> } smid;
>> u8 ex_status; /* 0x16 : OUT */
>> u8 status; /* 0x17 status */
>> - u8 RAIDFlags; /* 0x18 resvd[7:6], ioSubType[5:4],
>> + u8 raid_flags; /* 0x18 resvd[7:6], ioSubType[5:4],
>> * resvd[3:1],
> preferredCpu[0]
>> */
>> u8 span_arm; /* 0x1C span[7:5], arm[4:0] */
>> @@ -672,14 +679,17 @@ struct MPI2_IOC_INIT_REQUEST {
>> #define MAX_RAIDMAP_ROW_SIZE (MAX_ROW_SIZE)
>> #define MAX_LOGICAL_DRIVES 64
>> #define MAX_LOGICAL_DRIVES_EXT 256
>> +#define MAX_LOGICAL_DRIVES_DYN 512
>> #define MAX_RAIDMAP_LOGICAL_DRIVES (MAX_LOGICAL_DRIVES)
>> #define MAX_RAIDMAP_VIEWS (MAX_LOGICAL_DRIVES)
>> #define MAX_ARRAYS 128
>> #define MAX_RAIDMAP_ARRAYS (MAX_ARRAYS)
>> #define MAX_ARRAYS_EXT 256
>> #define MAX_API_ARRAYS_EXT (MAX_ARRAYS_EXT)
>> +#define MAX_API_ARRAYS_DYN 512
>> #define MAX_PHYSICAL_DEVICES 256
>> #define MAX_RAIDMAP_PHYSICAL_DEVICES (MAX_PHYSICAL_DEVICES)
>> +#define MAX_RAIDMAP_PHYSICAL_DEVICES_DYN 512
>> #define MR_DCMD_LD_MAP_GET_INFO 0x0300e101
>> #define MR_DCMD_SYSTEM_PD_MAP_GET_INFO 0x0200e102
>> #define MR_DCMD_CTRL_SHARED_HOST_MEM_ALLOC 0x010e8485 /* SR-IOV HB
> alloc*/
>> @@ -726,12 +736,56 @@ struct MR_SPAN_BLOCK_INFO {
>> struct MR_SPAN_INFO block_span_info;
>> };
>>
>> +#define MR_RAID_CTX_CPUSEL_0 0
>> +#define MR_RAID_CTX_CPUSEL_1 1
>> +#define MR_RAID_CTX_CPUSEL_2 2
>> +#define MR_RAID_CTX_CPUSEL_3 3
>> +#define MR_RAID_CTX_CPUSEL_FCFS 0xF
>> +
>> +struct MR_CPU_AFFINITY_MASK {
>> + union {
>> + struct {
>> +#ifndef MFI_BIG_ENDIAN
>> + u8 hw_path:1;
>> + u8 cpu0:1;
>> + u8 cpu1:1;
>> + u8 cpu2:1;
>> + u8 cpu3:1;
>> + u8 reserved:3;
>> +#else
>> + u8 reserved:3;
>> + u8 cpu3:1;
>> + u8 cpu2:1;
>> + u8 cpu1:1;
>> + u8 cpu0:1;
>> + u8 hw_path:1;
>> +#endif
>> + };
>> + u8 core_mask;
>> + };
>> +};
>> +
>> +struct MR_IO_AFFINITY {
>> + union {
>> + struct {
>> + struct MR_CPU_AFFINITY_MASK pdRead;
>> + struct MR_CPU_AFFINITY_MASK pdWrite;
>> + struct MR_CPU_AFFINITY_MASK ldRead;
>> + struct MR_CPU_AFFINITY_MASK ldWrite;
>> + };
>> + u32 word;
>> + };
>> + u8 maxCores; /* Total cores + HW Path in ROC */
>> + u8 reserved[3];
>> +};
>> +
>> struct MR_LD_RAID {
>> struct {
>> #if defined(__BIG_ENDIAN_BITFIELD)
>> - u32 reserved4:3;
>> - u32 fp_cache_bypass_capable:1;
>> - u32 fp_rmw_capable:1;
>> + u32 reserved4:2;
>> + u32 fp_cache_bypass_capable:1;
>> + u32 fp_rmw_capable:1;
>> + u32 disable_coalescing:1;
>> u32 fpBypassRegionLock:1;
>> u32 tmCapable:1;
>> u32 fpNonRWCapable:1;
>> @@ -759,9 +813,10 @@ struct MR_LD_RAID {
>> u32 fpNonRWCapable:1;
>> u32 tmCapable:1;
>> u32 fpBypassRegionLock:1;
>> - u32 fp_rmw_capable:1;
>> - u32 fp_cache_bypass_capable:1;
>> - u32 reserved4:3;
>> + u32 disable_coalescing:1;
>> + u32 fp_rmw_capable:1;
>> + u32 fp_cache_bypass_capable:1;
>> + u32 reserved4:2;
>> #endif
>> } capability;
>> __le32 reserved6;
>> @@ -788,7 +843,36 @@ struct MR_LD_RAID {
>>
>> u8 LUN[8]; /* 0x24 8 byte LUN field used for SCSI IO's */
>> u8 fpIoTimeoutForLd;/*0x2C timeout value used by driver in FP
> IO*/
>> - u8 reserved3[0x80-0x2D]; /* 0x2D */
>> + /* Ox2D This LD accept priority boost of this type */
>> + u8 ld_accept_priority_type;
>> + u8 reserved2[2]; /* 0x2E - 0x2F */
>> + /* 0x30 - 0x33, Logical block size for the LD */
>> + u32 logical_block_length;
>> + struct {
>> +#ifndef MFI_BIG_ENDIAN
>> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
>> + u32 ld_pi_exp:4;
>> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
>> + * BLOCK EXPONENT from READ CAPACITY 16
>> + */
>> + u32 ld_logical_block_exp:4;
>> + u32 reserved1:24; /* 0x34 */
>> +#else
>> + u32 reserved1:24; /* 0x34 */
>> + /* 0x34, LOGICAL BLOCKS PER PHYSICAL
>> + * BLOCK EXPONENT from READ CAPACITY 16
>> + */
>> + u32 ld_logical_block_exp:4;
>> + /* 0x34, P_I_EXPONENT from READ CAPACITY 16 */
>> + u32 ld_pi_exp:4;
>> +#endif
>> + }; /* 0x34 - 0x37 */
>> + /* 0x38 - 0x3f, This will determine which
>> + * core will process LD IO and PD IO.
>> + */
>> + struct MR_IO_AFFINITY cpuAffinity;
>> + /* Bit definiations are specified by MR_IO_AFFINITY */
>> + u8 reserved3[0x80-0x40]; /* 0x40 - 0x7f */
>> };
>>
>> struct MR_LD_SPAN_MAP {
>> @@ -846,6 +930,91 @@ struct MR_LD_TARGET_SYNC {
>> __le16 seqNum;
>> };
>>
>> +/*
>> +* RAID Map descriptor Types.
>> +* Each element should uniquely idetify one data structure in the RAID
> map
>> +*/
>> +enum MR_RAID_MAP_DESC_TYPE {
>> + /* MR_DEV_HANDLE_INFO data */
>> + RAID_MAP_DESC_TYPE_DEVHDL_INFO = 0x0,
>> + /* target to Ld num Index map */
>> + RAID_MAP_DESC_TYPE_TGTID_INFO = 0x1,
>> + /* MR_ARRAY_INFO data */
>> + RAID_MAP_DESC_TYPE_ARRAY_INFO = 0x2,
>> + /* MR_LD_SPAN_MAP data */
>> + RAID_MAP_DESC_TYPE_SPAN_INFO = 0x3,
>> + RAID_MAP_DESC_TYPE_COUNT,
>> +};
>> +
>> +/*
>> +* This table defines the offset, size and num elements of each
> descriptor
>> +* type in the RAID Map buffer
>> +*/
>> +struct MR_RAID_MAP_DESC_TABLE {
>> + /* Raid map descriptor type */
>> + u32 raid_map_desc_type;
>> + /* Offset into the RAID map buffer where
>> + * descriptor data is saved
>> + */
>> + u32 raid_map_desc_offset;
>> + /* total size of the
>> + * descriptor buffer
>> + */
>> + u32 raid_map_desc_buffer_size;
>> + /* Number of elements contained in the
>> + * descriptor buffer
>> + */
>> + u32 raid_map_desc_elements;
>> +};
>> +
>> +/*
>> +* Dynamic Raid Map Structure.
>> +*/
>> +struct MR_FW_RAID_MAP_DYNAMIC {
>> + u32 raid_map_size; /* total size of RAID Map structure */
>> + u32 desc_table_offset;/* Offset of desc table into RAID map*/
>> + u32 desc_table_size; /* Total Size of desc table */
>> + /* Total Number of elements in the desc table */
>> + u32 desc_table_num_elements;
>> + u64 reserved1;
>> + u32 reserved2[3]; /*future use */
>> + /* timeout value used by driver in FP IOs */
>> + u8 fp_pd_io_timeout_sec;
>> + u8 reserved3[3];
>> + /* when this seqNum increments, driver needs to
>> + * release RMW buffers asap
>> + */
>> + u32 rmw_fp_seq_num;
>> + u16 ld_count; /* count of lds. */
>> + u16 ar_count; /* count of arrays */
>> + u16 span_count; /* count of spans */
>> + u16 reserved4[3];
>> +/*
>> +* The below structure of pointers is only to be used by the driver.
>> +* This is added in the ,API to reduce the amount of code changes
>> +* needed in the driver to support dynamic RAID map Firmware should
>> +* not update these pointers while preparing the raid map
>> +*/
>> + union {
>> + struct {
>> + struct MR_DEV_HANDLE_INFO *dev_hndl_info;
>> + u16 *ld_tgt_id_to_ld;
>> + struct MR_ARRAY_INFO *ar_map_info;
>> + struct MR_LD_SPAN_MAP *ld_span_map;
>> + };
>> + u64 ptr_structure_size[RAID_MAP_DESC_TYPE_COUNT];
>> + };
>> +/*
>> +* RAID Map descriptor table defines the layout of data in the RAID Map.
>> +* The size of the descriptor table itself could change.
>> +*/
>> + /* Variable Size descriptor Table. */
>> + struct MR_RAID_MAP_DESC_TABLE
>> + raid_map_desc_table[RAID_MAP_DESC_TYPE_COUNT];
>> + /* Variable Size buffer containing all data */
>> + u32 raid_map_desc_data[1];
>> +}; /* Dynamicaly sized RAID MAp structure */
>> +
>> #define IEEE_SGE_FLAGS_ADDR_MASK (0x03)
>> #define IEEE_SGE_FLAGS_SYSTEM_ADDR (0x00)
>> #define IEEE_SGE_FLAGS_IOCDDR_ADDR (0x01)
>> @@ -955,9 +1124,10 @@ struct MR_DRV_RAID_MAP {
>> __le16 spanCount;
>> __le16 reserve3;
>>
>> - struct MR_DEV_HANDLE_INFO
> devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES];
>> - u8 ldTgtIdToLd[MAX_LOGICAL_DRIVES_EXT];
>> - struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_EXT];
>> + struct MR_DEV_HANDLE_INFO
>> + devHndlInfo[MAX_RAIDMAP_PHYSICAL_DEVICES_DYN];
>> + u16 ldTgtIdToLd[MAX_LOGICAL_DRIVES_DYN];
>> + struct MR_ARRAY_INFO arMapInfo[MAX_API_ARRAYS_DYN];
>> struct MR_LD_SPAN_MAP ldSpanMap[1];
>>
>> };
>> @@ -969,7 +1139,7 @@ struct MR_DRV_RAID_MAP {
>> struct MR_DRV_RAID_MAP_ALL {
>>
>> struct MR_DRV_RAID_MAP raidMap;
>> - struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_EXT - 1];
>> + struct MR_LD_SPAN_MAP ldSpanMap[MAX_LOGICAL_DRIVES_DYN - 1];
>> } __packed;
>>
>>
>> @@ -1088,7 +1258,7 @@ struct fusion_context {
>> u8 chain_offset_io_request;
>> u8 chain_offset_mfi_pthru;
>>
>> - struct MR_FW_RAID_MAP_ALL *ld_map[2];
>> + struct MR_FW_RAID_MAP_DYNAMIC *ld_map[2];
>> dma_addr_t ld_map_phys[2];
>>
>> /*Non dma-able memory. Driver local copy.*/
>> @@ -1096,6 +1266,8 @@ struct fusion_context {
>>
>> u32 max_map_sz;
>> u32 current_map_sz;
>> + u32 old_map_sz;
>> + u32 new_map_sz;
>> u32 drv_map_sz;
>> u32 drv_map_pages;
>> struct MR_PD_CFG_SEQ_NUM_SYNC *pd_seq_sync[JBOD_MAPS_COUNT];
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (5 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 13:05 ` Tomas Henzl
2016-12-09 13:13 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran
` (4 subsequent siblings)
11 siblings, 2 replies; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality.
This patch is depending on patch 6
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 53 ++++++++++++++---------------
drivers/scsi/megaraid/megaraid_sas_fusion.c | 19 ++++++-----
drivers/scsi/megaraid/megaraid_sas_fusion.h | 1 +
3 files changed, 37 insertions(+), 36 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 3f06b57..8aafb59 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5057,34 +5057,29 @@ static int megasas_init_fw(struct megasas_instance *instance)
reg_set = instance->reg_set;
- switch (instance->pdev->device) {
- case PCI_DEVICE_ID_LSI_FUSION:
- case PCI_DEVICE_ID_LSI_PLASMA:
- case PCI_DEVICE_ID_LSI_INVADER:
- case PCI_DEVICE_ID_LSI_FURY:
- case PCI_DEVICE_ID_LSI_INTRUDER:
- case PCI_DEVICE_ID_LSI_INTRUDER_24:
- case PCI_DEVICE_ID_LSI_CUTLASS_52:
- case PCI_DEVICE_ID_LSI_CUTLASS_53:
+ if (fusion)
instance->instancet = &megasas_instance_template_fusion;
- break;
- case PCI_DEVICE_ID_LSI_SAS1078R:
- case PCI_DEVICE_ID_LSI_SAS1078DE:
- instance->instancet = &megasas_instance_template_ppc;
- break;
- case PCI_DEVICE_ID_LSI_SAS1078GEN2:
- case PCI_DEVICE_ID_LSI_SAS0079GEN2:
- instance->instancet = &megasas_instance_template_gen2;
- break;
- case PCI_DEVICE_ID_LSI_SAS0073SKINNY:
- case PCI_DEVICE_ID_LSI_SAS0071SKINNY:
- instance->instancet = &megasas_instance_template_skinny;
- break;
- case PCI_DEVICE_ID_LSI_SAS1064R:
- case PCI_DEVICE_ID_DELL_PERC5:
- default:
- instance->instancet = &megasas_instance_template_xscale;
- break;
+ else {
+ switch (instance->pdev->device) {
+ case PCI_DEVICE_ID_LSI_SAS1078R:
+ case PCI_DEVICE_ID_LSI_SAS1078DE:
+ instance->instancet = &megasas_instance_template_ppc;
+ break;
+ case PCI_DEVICE_ID_LSI_SAS1078GEN2:
+ case PCI_DEVICE_ID_LSI_SAS0079GEN2:
+ instance->instancet = &megasas_instance_template_gen2;
+ break;
+ case PCI_DEVICE_ID_LSI_SAS0073SKINNY:
+ case PCI_DEVICE_ID_LSI_SAS0071SKINNY:
+ instance->instancet = &megasas_instance_template_skinny;
+ break;
+ case PCI_DEVICE_ID_LSI_SAS1064R:
+ case PCI_DEVICE_ID_DELL_PERC5:
+ default:
+ instance->instancet = &megasas_instance_template_xscale;
+ instance->pd_list_not_supported = 1;
+ break;
+ }
}
if (megasas_transition_to_ready(instance, 0)) {
@@ -5828,7 +5823,9 @@ static int megasas_probe_one(struct pci_dev *pdev,
if ((instance->pdev->device == PCI_DEVICE_ID_LSI_FUSION) ||
(instance->pdev->device == PCI_DEVICE_ID_LSI_PLASMA))
fusion->adapter_type = THUNDERBOLT_SERIES;
- else if (!instance->is_ventura)
+ else if (instance->is_ventura)
+ fusion->adapter_type = VENTURA_SERIES;
+ else
fusion->adapter_type = INVADER_SERIES;
}
break;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 58f86aa..f968a23 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -244,7 +244,10 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
reg_set = instance->reg_set;
- cur_max_fw_cmds = readl(&instance->reg_set->outbound_scratch_pad_3) & 0x00FFFF;
+ /* ventura FW does not fill outbound_scratch_pad_3 with queue depth */
+ if (!instance->is_ventura)
+ cur_max_fw_cmds =
+ readl(&instance->reg_set->outbound_scratch_pad_3) & 0x00FFFF;
if (dual_qdepth_disable || !cur_max_fw_cmds)
cur_max_fw_cmds = instance->instancet->read_fw_status_reg(reg_set) & 0x00FFFF;
@@ -843,7 +846,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
drv_ops = (MFI_CAPABILITIES *) &(init_frame->driver_operations);
/* driver support Extended MSIX */
- if (fusion->adapter_type == INVADER_SERIES)
+ if (fusion->adapter_type >= INVADER_SERIES)
drv_ops->mfi_capabilities.support_additional_msix = 1;
/* driver supports HA / Remote LUN over Fast Path interface */
drv_ops->mfi_capabilities.support_fp_remote_lun = 1;
@@ -1497,7 +1500,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
fusion = instance->ctrl_context;
- if (fusion->adapter_type == INVADER_SERIES) {
+ if (fusion->adapter_type >= INVADER_SERIES) {
struct MPI25_IEEE_SGE_CHAIN64 *sgl_ptr_end = sgl_ptr;
sgl_ptr_end += fusion->max_sge_in_main_msg - 1;
sgl_ptr_end->Flags = 0;
@@ -1514,7 +1517,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
sgl_ptr->Length = cpu_to_le32(sg_dma_len(os_sgl));
sgl_ptr->Address = cpu_to_le64(sg_dma_address(os_sgl));
sgl_ptr->Flags = 0;
- if (fusion->adapter_type == INVADER_SERIES)
+ if (fusion->adapter_type >= INVADER_SERIES)
if (i == sge_count - 1)
sgl_ptr->Flags = IEEE_SGE_FLAGS_END_OF_LIST;
sgl_ptr++;
@@ -1525,7 +1528,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
(sge_count > fusion->max_sge_in_main_msg)) {
struct MPI25_IEEE_SGE_CHAIN64 *sg_chain;
- if (fusion->adapter_type == INVADER_SERIES) {
+ if (fusion->adapter_type >= INVADER_SERIES) {
if ((le16_to_cpu(cmd->io_request->IoFlags) &
MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH) !=
MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH)
@@ -1541,7 +1544,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
sg_chain = sgl_ptr;
/* Prepare chain element */
sg_chain->NextChainOffset = 0;
- if (fusion->adapter_type == INVADER_SERIES)
+ if (fusion->adapter_type >= INVADER_SERIES)
sg_chain->Flags = IEEE_SGE_FLAGS_CHAIN_ELEMENT;
else
sg_chain->Flags =
@@ -2292,7 +2295,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
pRAID_Context->timeout_value =
cpu_to_le16((os_timeout_value > timeout_limit) ?
timeout_limit : os_timeout_value);
- if (fusion->adapter_type == INVADER_SERIES)
+ if (fusion->adapter_type >= INVADER_SERIES)
io_request->IoFlags |=
cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
@@ -3005,7 +3008,7 @@ irqreturn_t megasas_isr_fusion(int irq, void *devp)
io_req = cmd->io_request;
- if (fusion->adapter_type == INVADER_SERIES) {
+ if (fusion->adapter_type >= INVADER_SERIES) {
struct MPI25_IEEE_SGE_CHAIN64 *sgl_ptr_end =
(struct MPI25_IEEE_SGE_CHAIN64 *)&io_req->SGL;
sgl_ptr_end += fusion->max_sge_in_main_msg - 1;
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index cb42655..c39c4ed 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -107,6 +107,7 @@ enum MR_RAID_FLAGS_IO_SUB_TYPE {
enum MR_FUSION_ADAPTER_TYPE {
THUNDERBOLT_SERIES = 0,
INVADER_SERIES = 1,
+ VENTURA_SERIES = 2,
};
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities
2016-12-06 23:00 ` [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
@ 2016-12-09 13:05 ` Tomas Henzl
2016-12-09 13:13 ` Tomas Henzl
1 sibling, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-09 13:05 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality.
>
> This patch is depending on patch 6
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities
2016-12-06 23:00 ` [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
2016-12-09 13:05 ` Tomas Henzl
@ 2016-12-09 13:13 ` Tomas Henzl
2016-12-14 21:52 ` Sasikumar PC
1 sibling, 1 reply; 40+ messages in thread
From: Tomas Henzl @ 2016-12-09 13:13 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality.
>
> This patch is depending on patch 6
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 53 ++++++++++++++---------------
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 19 ++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 1 +
> 3 files changed, 37 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 3f06b57..8aafb59 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5057,34 +5057,29 @@ static int megasas_init_fw(struct megasas_instance *instance)
>
> reg_set = instance->reg_set;
>
> - switch (instance->pdev->device) {
> - case PCI_DEVICE_ID_LSI_FUSION:
> - case PCI_DEVICE_ID_LSI_PLASMA:
> - case PCI_DEVICE_ID_LSI_INVADER:
> - case PCI_DEVICE_ID_LSI_FURY:
> - case PCI_DEVICE_ID_LSI_INTRUDER:
> - case PCI_DEVICE_ID_LSI_INTRUDER_24:
> - case PCI_DEVICE_ID_LSI_CUTLASS_52:
> - case PCI_DEVICE_ID_LSI_CUTLASS_53:
> + if (fusion)
> instance->instancet = &megasas_instance_template_fusion;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS1078R:
> - case PCI_DEVICE_ID_LSI_SAS1078DE:
> - instance->instancet = &megasas_instance_template_ppc;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS1078GEN2:
> - case PCI_DEVICE_ID_LSI_SAS0079GEN2:
> - instance->instancet = &megasas_instance_template_gen2;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS0073SKINNY:
> - case PCI_DEVICE_ID_LSI_SAS0071SKINNY:
> - instance->instancet = &megasas_instance_template_skinny;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS1064R:
> - case PCI_DEVICE_ID_DELL_PERC5:
> - default:
> - instance->instancet = &megasas_instance_template_xscale;
> - break;
> + else {
> + switch (instance->pdev->device) {
> + case PCI_DEVICE_ID_LSI_SAS1078R:
> + case PCI_DEVICE_ID_LSI_SAS1078DE:
> + instance->instancet = &megasas_instance_template_ppc;
> + break;
> + case PCI_DEVICE_ID_LSI_SAS1078GEN2:
> + case PCI_DEVICE_ID_LSI_SAS0079GEN2:
> + instance->instancet = &megasas_instance_template_gen2;
> + break;
> + case PCI_DEVICE_ID_LSI_SAS0073SKINNY:
> + case PCI_DEVICE_ID_LSI_SAS0071SKINNY:
> + instance->instancet = &megasas_instance_template_skinny;
> + break;
> + case PCI_DEVICE_ID_LSI_SAS1064R:
> + case PCI_DEVICE_ID_DELL_PERC5:
> + default:
> + instance->instancet = &megasas_instance_template_xscale;
> + instance->pd_list_not_supported = 1;
> + break;
> + }
> }
>
> if (megasas_transition_to_ready(instance, 0)) {
> @@ -5828,7 +5823,9 @@ static int megasas_probe_one(struct pci_dev *pdev,
> if ((instance->pdev->device == PCI_DEVICE_ID_LSI_FUSION) ||
> (instance->pdev->device == PCI_DEVICE_ID_LSI_PLASMA))
> fusion->adapter_type = THUNDERBOLT_SERIES;
> - else if (!instance->is_ventura)
> + else if (instance->is_ventura)
> + fusion->adapter_type = VENTURA_SERIES;
> + else
> fusion->adapter_type = INVADER_SERIES;
> }
> break;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 58f86aa..f968a23 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -244,7 +244,10 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
>
> reg_set = instance->reg_set;
>
> - cur_max_fw_cmds = readl(&instance->reg_set->outbound_scratch_pad_3) & 0x00FFFF;
> + /* ventura FW does not fill outbound_scratch_pad_3 with queue depth */
> + if (!instance->is_ventura)
> + cur_max_fw_cmds =
> + readl(&instance->reg_set->outbound_scratch_pad_3) & 0x00FFFF;
>
> if (dual_qdepth_disable || !cur_max_fw_cmds)
This test connected with the fact that ventura skips reading cur_max_fw_cmds
makes using ventura equal to "dual_qdepth_disable == 1" so ldio_threshold is not set.
Is that intentional?
tomash
> cur_max_fw_cmds = instance->instancet->read_fw_status_reg(reg_set) & 0x00FFFF;
> @@ -843,7 +846,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> drv_ops = (MFI_CAPABILITIES *) &(init_frame->driver_operations);
>
> /* driver support Extended MSIX */
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> drv_ops->mfi_capabilities.support_additional_msix = 1;
> /* driver supports HA / Remote LUN over Fast Path interface */
> drv_ops->mfi_capabilities.support_fp_remote_lun = 1;
> @@ -1497,7 +1500,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
>
> fusion = instance->ctrl_context;
>
> - if (fusion->adapter_type == INVADER_SERIES) {
> + if (fusion->adapter_type >= INVADER_SERIES) {
> struct MPI25_IEEE_SGE_CHAIN64 *sgl_ptr_end = sgl_ptr;
> sgl_ptr_end += fusion->max_sge_in_main_msg - 1;
> sgl_ptr_end->Flags = 0;
> @@ -1514,7 +1517,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> sgl_ptr->Length = cpu_to_le32(sg_dma_len(os_sgl));
> sgl_ptr->Address = cpu_to_le64(sg_dma_address(os_sgl));
> sgl_ptr->Flags = 0;
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> if (i == sge_count - 1)
> sgl_ptr->Flags = IEEE_SGE_FLAGS_END_OF_LIST;
> sgl_ptr++;
> @@ -1525,7 +1528,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> (sge_count > fusion->max_sge_in_main_msg)) {
>
> struct MPI25_IEEE_SGE_CHAIN64 *sg_chain;
> - if (fusion->adapter_type == INVADER_SERIES) {
> + if (fusion->adapter_type >= INVADER_SERIES) {
> if ((le16_to_cpu(cmd->io_request->IoFlags) &
> MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH) !=
> MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH)
> @@ -1541,7 +1544,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> sg_chain = sgl_ptr;
> /* Prepare chain element */
> sg_chain->NextChainOffset = 0;
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> sg_chain->Flags = IEEE_SGE_FLAGS_CHAIN_ELEMENT;
> else
> sg_chain->Flags =
> @@ -2292,7 +2295,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> pRAID_Context->timeout_value =
> cpu_to_le16((os_timeout_value > timeout_limit) ?
> timeout_limit : os_timeout_value);
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> io_request->IoFlags |=
> cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
>
> @@ -3005,7 +3008,7 @@ irqreturn_t megasas_isr_fusion(int irq, void *devp)
>
> io_req = cmd->io_request;
>
> - if (fusion->adapter_type == INVADER_SERIES) {
> + if (fusion->adapter_type >= INVADER_SERIES) {
> struct MPI25_IEEE_SGE_CHAIN64 *sgl_ptr_end =
> (struct MPI25_IEEE_SGE_CHAIN64 *)&io_req->SGL;
> sgl_ptr_end += fusion->max_sge_in_main_msg - 1;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index cb42655..c39c4ed 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -107,6 +107,7 @@ enum MR_RAID_FLAGS_IO_SUB_TYPE {
> enum MR_FUSION_ADAPTER_TYPE {
> THUNDERBOLT_SERIES = 0,
> INVADER_SERIES = 1,
> + VENTURA_SERIES = 2,
> };
>
> /*
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities
2016-12-09 13:13 ` Tomas Henzl
@ 2016-12-14 21:52 ` Sasikumar PC
0 siblings, 0 replies; 40+ messages in thread
From: Sasikumar PC @ 2016-12-14 21:52 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Friday, December 09, 2016 8:14 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5
Generic Megaraid Controllers Capabilities
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> The Megaraid driver has to support the SAS3.5 Generic Megaraid
Controllers Firmware functionality.
>
> This patch is depending on patch 6
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 53
++++++++++++++---------------
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 19 ++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 1 +
> 3 files changed, 37 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 3f06b57..8aafb59 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5057,34 +5057,29 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>
> reg_set = instance->reg_set;
>
> - switch (instance->pdev->device) {
> - case PCI_DEVICE_ID_LSI_FUSION:
> - case PCI_DEVICE_ID_LSI_PLASMA:
> - case PCI_DEVICE_ID_LSI_INVADER:
> - case PCI_DEVICE_ID_LSI_FURY:
> - case PCI_DEVICE_ID_LSI_INTRUDER:
> - case PCI_DEVICE_ID_LSI_INTRUDER_24:
> - case PCI_DEVICE_ID_LSI_CUTLASS_52:
> - case PCI_DEVICE_ID_LSI_CUTLASS_53:
> + if (fusion)
> instance->instancet = &megasas_instance_template_fusion;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS1078R:
> - case PCI_DEVICE_ID_LSI_SAS1078DE:
> - instance->instancet = &megasas_instance_template_ppc;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS1078GEN2:
> - case PCI_DEVICE_ID_LSI_SAS0079GEN2:
> - instance->instancet = &megasas_instance_template_gen2;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS0073SKINNY:
> - case PCI_DEVICE_ID_LSI_SAS0071SKINNY:
> - instance->instancet = &megasas_instance_template_skinny;
> - break;
> - case PCI_DEVICE_ID_LSI_SAS1064R:
> - case PCI_DEVICE_ID_DELL_PERC5:
> - default:
> - instance->instancet = &megasas_instance_template_xscale;
> - break;
> + else {
> + switch (instance->pdev->device) {
> + case PCI_DEVICE_ID_LSI_SAS1078R:
> + case PCI_DEVICE_ID_LSI_SAS1078DE:
> + instance->instancet =
&megasas_instance_template_ppc;
> + break;
> + case PCI_DEVICE_ID_LSI_SAS1078GEN2:
> + case PCI_DEVICE_ID_LSI_SAS0079GEN2:
> + instance->instancet =
&megasas_instance_template_gen2;
> + break;
> + case PCI_DEVICE_ID_LSI_SAS0073SKINNY:
> + case PCI_DEVICE_ID_LSI_SAS0071SKINNY:
> + instance->instancet =
&megasas_instance_template_skinny;
> + break;
> + case PCI_DEVICE_ID_LSI_SAS1064R:
> + case PCI_DEVICE_ID_DELL_PERC5:
> + default:
> + instance->instancet =
&megasas_instance_template_xscale;
> + instance->pd_list_not_supported = 1;
> + break;
> + }
> }
>
> if (megasas_transition_to_ready(instance, 0)) { @@ -5828,7 +5823,9
> @@ static int megasas_probe_one(struct pci_dev *pdev,
> if ((instance->pdev->device == PCI_DEVICE_ID_LSI_FUSION)
||
> (instance->pdev->device ==
PCI_DEVICE_ID_LSI_PLASMA))
> fusion->adapter_type = THUNDERBOLT_SERIES;
> - else if (!instance->is_ventura)
> + else if (instance->is_ventura)
> + fusion->adapter_type = VENTURA_SERIES;
> + else
> fusion->adapter_type = INVADER_SERIES;
> }
> break;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 58f86aa..f968a23 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -244,7 +244,10 @@ inline void megasas_return_cmd_fusion(struct
> megasas_instance *instance,
>
> reg_set = instance->reg_set;
>
> - cur_max_fw_cmds =
readl(&instance->reg_set->outbound_scratch_pad_3) & 0x00FFFF;
> + /* ventura FW does not fill outbound_scratch_pad_3 with queue
depth */
> + if (!instance->is_ventura)
> + cur_max_fw_cmds =
> + readl(&instance->reg_set->outbound_scratch_pad_3) &
0x00FFFF;
>
> if (dual_qdepth_disable || !cur_max_fw_cmds)
This test connected with the fact that ventura skips reading
cur_max_fw_cmds makes using ventura equal to "dual_qdepth_disable == 1" so
ldio_threshold is not set.
Is that intentional?
Sasi - Yes , ldio_threshold is not applicable for Ventura
tomash
> cur_max_fw_cmds =
instance->instancet->read_fw_status_reg(reg_set)
> & 0x00FFFF; @@ -843,7 +846,7 @@ static int
megasas_create_sg_sense_fusion(struct megasas_instance *instance)
> drv_ops = (MFI_CAPABILITIES *) &(init_frame->driver_operations);
>
> /* driver support Extended MSIX */
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> drv_ops->mfi_capabilities.support_additional_msix = 1;
> /* driver supports HA / Remote LUN over Fast Path interface */
> drv_ops->mfi_capabilities.support_fp_remote_lun = 1; @@ -1497,7
> +1500,7 @@ static int megasas_create_sg_sense_fusion(struct
> megasas_instance *instance)
>
> fusion = instance->ctrl_context;
>
> - if (fusion->adapter_type == INVADER_SERIES) {
> + if (fusion->adapter_type >= INVADER_SERIES) {
> struct MPI25_IEEE_SGE_CHAIN64 *sgl_ptr_end = sgl_ptr;
> sgl_ptr_end += fusion->max_sge_in_main_msg - 1;
> sgl_ptr_end->Flags = 0;
> @@ -1514,7 +1517,7 @@ static int megasas_create_sg_sense_fusion(struct
megasas_instance *instance)
> sgl_ptr->Length = cpu_to_le32(sg_dma_len(os_sgl));
> sgl_ptr->Address = cpu_to_le64(sg_dma_address(os_sgl));
> sgl_ptr->Flags = 0;
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> if (i == sge_count - 1)
> sgl_ptr->Flags =
IEEE_SGE_FLAGS_END_OF_LIST;
> sgl_ptr++;
> @@ -1525,7 +1528,7 @@ static int megasas_create_sg_sense_fusion(struct
megasas_instance *instance)
> (sge_count > fusion->max_sge_in_main_msg)) {
>
> struct MPI25_IEEE_SGE_CHAIN64 *sg_chain;
> - if (fusion->adapter_type == INVADER_SERIES) {
> + if (fusion->adapter_type >= INVADER_SERIES) {
> if ((le16_to_cpu(cmd->io_request->IoFlags)
&
>
MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH) !=
>
MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH)
> @@ -1541,7 +1544,7 @@ static int megasas_create_sg_sense_fusion(struct
megasas_instance *instance)
> sg_chain = sgl_ptr;
> /* Prepare chain element */
> sg_chain->NextChainOffset = 0;
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> sg_chain->Flags =
IEEE_SGE_FLAGS_CHAIN_ELEMENT;
> else
> sg_chain->Flags =
> @@ -2292,7 +2295,7 @@ static void megasas_build_ld_nonrw_fusion(struct
megasas_instance *instance,
> pRAID_Context->timeout_value =
> cpu_to_le16((os_timeout_value > timeout_limit) ?
> timeout_limit : os_timeout_value);
> - if (fusion->adapter_type == INVADER_SERIES)
> + if (fusion->adapter_type >= INVADER_SERIES)
> io_request->IoFlags |=
>
cpu_to_le16(MPI25_SAS_DEVICE0_FLAGS_ENABLED_FAST_PATH);
>
> @@ -3005,7 +3008,7 @@ irqreturn_t megasas_isr_fusion(int irq, void
> *devp)
>
> io_req = cmd->io_request;
>
> - if (fusion->adapter_type == INVADER_SERIES) {
> + if (fusion->adapter_type >= INVADER_SERIES) {
> struct MPI25_IEEE_SGE_CHAIN64 *sgl_ptr_end =
> (struct MPI25_IEEE_SGE_CHAIN64 *)&io_req->SGL;
> sgl_ptr_end += fusion->max_sge_in_main_msg - 1; diff --git
> a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index cb42655..c39c4ed 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -107,6 +107,7 @@ enum MR_RAID_FLAGS_IO_SUB_TYPE { enum
> MR_FUSION_ADAPTER_TYPE {
> THUNDERBOLT_SERIES = 0,
> INVADER_SERIES = 1,
> + VENTURA_SERIES = 2,
> };
>
> /*
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (6 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 13:58 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path Sasikumar Chandrasekaran
` (3 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
Large SEQ IO workload should sent as non fast path commands
This patch is depending on patch 7
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 8 +++++
drivers/scsi/megaraid/megaraid_sas_base.c | 48 +++++++++++++++++++++++++++++
drivers/scsi/megaraid/megaraid_sas_fp.c | 11 +++++--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 +++++++-----
drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 +-
5 files changed, 78 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 3e087ab..eb5be2b 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -1429,6 +1429,8 @@ enum FW_BOOT_CONTEXT {
#define MFI_1068_FW_HANDSHAKE_OFFSET 0x64
#define MFI_1068_FW_READY 0xDDDD0000
+#define MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL HZ
+
#define MR_MAX_REPLY_QUEUES_OFFSET 0X0000001F
#define MR_MAX_REPLY_QUEUES_EXT_OFFSET 0X003FC000
#define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
@@ -2101,6 +2103,10 @@ struct megasas_instance {
atomic_t ldio_outstanding;
atomic_t fw_reset_no_pci_access;
+ atomic64_t bytes_wrote; /* used for raid1 fast path enable or disable */
+ atomic_t r1_write_fp_capable;
+
+
struct megasas_instance_template *instancet;
struct tasklet_struct isr_tasklet;
struct work_struct work_init;
@@ -2143,6 +2149,7 @@ struct megasas_instance {
long reset_flags;
struct mutex reset_mutex;
struct timer_list sriov_heartbeat_timer;
+ struct timer_list r1_fp_hold_timer;
char skip_heartbeat_timer_del;
u8 requestorId;
char PlasmaFW111;
@@ -2159,6 +2166,7 @@ struct megasas_instance {
bool is_ventura;
bool msix_combined;
u16 max_raid_mapsize;
+ u64 pci_threshold_bandwidth; /* used to control the fp writes */
};
struct MR_LD_VF_MAP {
u32 size;
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 8aafb59..899d25c 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -1940,6 +1940,9 @@ void megaraid_sas_kill_hba(struct megasas_instance *instance)
}
/* Complete outstanding ioctls when adapter is killed */
megasas_complete_outstanding_ioctls(instance);
+ if (instance->is_ventura)
+ del_timer_sync(&instance->r1_fp_hold_timer);
+
}
/**
@@ -2438,6 +2441,24 @@ void megasas_sriov_heartbeat_handler(unsigned long instance_addr)
}
}
+/*Handler for disabling/enabling raid 1 fast paths*/
+void megasas_change_r1_fp_status(unsigned long instance_addr)
+{
+ struct megasas_instance *instance =
+ (struct megasas_instance *)instance_addr;
+ if (atomic64_read(&instance->bytes_wrote) >=
+ instance->pci_threshold_bandwidth) {
+
+ atomic64_set(&instance->bytes_wrote, 0);
+ atomic_set(&instance->r1_write_fp_capable, 0);
+ } else {
+ atomic64_set(&instance->bytes_wrote, 0);
+ atomic_set(&instance->r1_write_fp_capable, 1);
+ }
+ mod_timer(&instance->r1_fp_hold_timer,
+ jiffies + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
+}
+
/**
* megasas_wait_for_outstanding - Wait for all outstanding cmds
* @instance: Adapter soft state
@@ -5371,6 +5392,17 @@ static int megasas_init_fw(struct megasas_instance *instance)
instance->skip_heartbeat_timer_del = 1;
}
+ if (instance->is_ventura) {
+ atomic64_set(&instance->bytes_wrote, 0);
+ atomic_set(&instance->r1_write_fp_capable, 1);
+ megasas_start_timer(instance,
+ &instance->r1_fp_hold_timer,
+ megasas_change_r1_fp_status,
+ MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
+ dev_info(&instance->pdev->dev, "starting the raid 1 fp timer with interval %d\n",
+ MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
+ }
+
return 0;
fail_get_ld_pd_list:
@@ -6161,6 +6193,9 @@ static void megasas_shutdown_controller(struct megasas_instance *instance,
if (instance->requestorId && !instance->skip_heartbeat_timer_del)
del_timer_sync(&instance->sriov_heartbeat_timer);
+ if (instance->is_ventura)
+ del_timer_sync(&instance->r1_fp_hold_timer);
+
megasas_flush_cache(instance);
megasas_shutdown_controller(instance, MR_DCMD_HIBERNATE_SHUTDOWN);
@@ -6280,6 +6315,16 @@ static void megasas_shutdown_controller(struct megasas_instance *instance,
megasas_setup_jbod_map(instance);
instance->unload = 0;
+ if (instance->is_ventura) {
+ atomic64_set(&instance->bytes_wrote, 0);
+ atomic_set(&instance->r1_write_fp_capable, 1);
+ megasas_start_timer(instance,
+ &instance->r1_fp_hold_timer,
+ megasas_change_r1_fp_status,
+ MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
+ }
+
+
/*
* Initiate AEN (Asynchronous Event Notification)
*/
@@ -6368,6 +6413,9 @@ static void megasas_detach_one(struct pci_dev *pdev)
if (instance->requestorId && !instance->skip_heartbeat_timer_del)
del_timer_sync(&instance->sriov_heartbeat_timer);
+ if (instance->is_ventura)
+ del_timer_sync(&instance->r1_fp_hold_timer);
+
if (instance->fw_crash_state != UNAVAILABLE)
megasas_free_host_crash_buffer(instance);
scsi_remove_host(instance->host);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
index a6957a3..7da4685 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fp.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
@@ -197,14 +197,19 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
if (instance->max_raid_mapsize) {
fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
+ if (fw_map_dyn->pci_threshold_bandwidth)
+ instance->pci_threshold_bandwidth =
+ le64_to_cpu(fw_map_dyn->pci_threshold_bandwidth);
#if VD_EXT_DEBUG
dev_dbg(&instance->pdev->dev,
" raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
- " descTableSize 0x%x descTableNumElements 0x%x\n",
+ " descTableSize 0x%x descTableNumElements 0x%x, "
+ " PCIThreasholdBandwidth %llu\n",
le32_to_cpu(fw_map_dyn->raid_map_size),
le32_to_cpu(fw_map_dyn->desc_table_offset),
le32_to_cpu(fw_map_dyn->desc_table_size),
- le32_to_cpu(fw_map_dyn->desc_table_num_elements));
+ le32_to_cpu(fw_map_dyn->desc_table_num_elements),
+ instance->pci_threshold_bandwidth);
dev_dbg(&instance->pdev->dev,
"drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
#endif
@@ -434,6 +439,8 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
sizeof(struct MR_DEV_HANDLE_INFO) *
MAX_RAIDMAP_PHYSICAL_DEVICES);
}
+ if (instance->is_ventura && !instance->pci_threshold_bandwidth)
+ instance->pci_threshold_bandwidth = ULLONG_MAX;
}
/*
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index f968a23..5992153 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -95,6 +95,7 @@ void megasas_start_timer(struct megasas_instance *instance,
extern unsigned int dual_qdepth_disable;
static void megasas_free_rdpq_fusion(struct megasas_instance *instance);
static void megasas_free_reply_fusion(struct megasas_instance *instance);
+void megasas_change_r1_fp_status(unsigned long instance_addr);
@@ -2633,8 +2634,9 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
* to get new command
*/
if (cmd->is_raid_1_fp_write &&
- atomic_inc_return(&instance->fw_outstanding) >
- (instance->host->can_queue)) {
+ (atomic_inc_return(&instance->fw_outstanding) >
+ (instance->host->can_queue) ||
+ (!atomic_read(&instance->r1_write_fp_capable)))) {
megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
atomic_dec(&instance->fw_outstanding);
} else if (cmd->is_raid_1_fp_write) {
@@ -2643,17 +2645,19 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
}
-
/*
- * Issue the command to the FW
- */
+ * Issue the command to the FW
+ */
+ if (scmd->sc_data_direction == PCI_DMA_TODEVICE && instance->is_ventura)
+ atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
- if (r1_cmd)
+ if (r1_cmd) {
+ atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
- instance->is_ventura);
-
+ instance->is_ventura);
+ }
return 0;
}
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index c39c4ed..da05790 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -977,7 +977,7 @@ struct MR_FW_RAID_MAP_DYNAMIC {
u32 desc_table_size; /* Total Size of desc table */
/* Total Number of elements in the desc table */
u32 desc_table_num_elements;
- u64 reserved1;
+ u64 pci_threshold_bandwidth;
u32 reserved2[3]; /*future use */
/* timeout value used by driver in FP IOs */
u8 fp_pd_io_timeout_sec;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth
2016-12-06 23:00 ` [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran
@ 2016-12-09 13:58 ` Tomas Henzl
2016-12-14 21:54 ` Sasikumar PC
0 siblings, 1 reply; 40+ messages in thread
From: Tomas Henzl @ 2016-12-09 13:58 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> Large SEQ IO workload should sent as non fast path commands
>
> This patch is depending on patch 7
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 8 +++++
> drivers/scsi/megaraid/megaraid_sas_base.c | 48 +++++++++++++++++++++++++++++
> drivers/scsi/megaraid/megaraid_sas_fp.c | 11 +++++--
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 +++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 +-
> 5 files changed, 78 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index 3e087ab..eb5be2b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -1429,6 +1429,8 @@ enum FW_BOOT_CONTEXT {
> #define MFI_1068_FW_HANDSHAKE_OFFSET 0x64
> #define MFI_1068_FW_READY 0xDDDD0000
>
> +#define MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL HZ
> +
> #define MR_MAX_REPLY_QUEUES_OFFSET 0X0000001F
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET 0X003FC000
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
> @@ -2101,6 +2103,10 @@ struct megasas_instance {
> atomic_t ldio_outstanding;
> atomic_t fw_reset_no_pci_access;
>
> + atomic64_t bytes_wrote; /* used for raid1 fast path enable or disable */
> + atomic_t r1_write_fp_capable;
Is a an atomic variable needed for a just boolean variable?
> +
> +
> struct megasas_instance_template *instancet;
> struct tasklet_struct isr_tasklet;
> struct work_struct work_init;
> @@ -2143,6 +2149,7 @@ struct megasas_instance {
> long reset_flags;
> struct mutex reset_mutex;
> struct timer_list sriov_heartbeat_timer;
> + struct timer_list r1_fp_hold_timer;
> char skip_heartbeat_timer_del;
> u8 requestorId;
> char PlasmaFW111;
> @@ -2159,6 +2166,7 @@ struct megasas_instance {
> bool is_ventura;
> bool msix_combined;
> u16 max_raid_mapsize;
> + u64 pci_threshold_bandwidth; /* used to control the fp writes */
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 8aafb59..899d25c 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -1940,6 +1940,9 @@ void megaraid_sas_kill_hba(struct megasas_instance *instance)
> }
> /* Complete outstanding ioctls when adapter is killed */
> megasas_complete_outstanding_ioctls(instance);
> + if (instance->is_ventura)
> + del_timer_sync(&instance->r1_fp_hold_timer);
> +
> }
>
> /**
> @@ -2438,6 +2441,24 @@ void megasas_sriov_heartbeat_handler(unsigned long instance_addr)
> }
> }
>
> +/*Handler for disabling/enabling raid 1 fast paths*/
> +void megasas_change_r1_fp_status(unsigned long instance_addr)
> +{
> + struct megasas_instance *instance =
> + (struct megasas_instance *)instance_addr;
> + if (atomic64_read(&instance->bytes_wrote) >=
> + instance->pci_threshold_bandwidth) {
> +
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 0);
> + } else {
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 1);
> + }
> + mod_timer(&instance->r1_fp_hold_timer,
> + jiffies + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> +}
> +
> /**
> * megasas_wait_for_outstanding - Wait for all outstanding cmds
> * @instance: Adapter soft state
> @@ -5371,6 +5392,17 @@ static int megasas_init_fw(struct megasas_instance *instance)
> instance->skip_heartbeat_timer_del = 1;
> }
>
> + if (instance->is_ventura) {
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 1);
> + megasas_start_timer(instance,
> + &instance->r1_fp_hold_timer,
> + megasas_change_r1_fp_status,
> + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> + dev_info(&instance->pdev->dev, "starting the raid 1 fp timer with interval %d\n",
> + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> + }
> +
> return 0;
>
> fail_get_ld_pd_list:
> @@ -6161,6 +6193,9 @@ static void megasas_shutdown_controller(struct megasas_instance *instance,
> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
> del_timer_sync(&instance->sriov_heartbeat_timer);
>
> + if (instance->is_ventura)
> + del_timer_sync(&instance->r1_fp_hold_timer);
> +
> megasas_flush_cache(instance);
> megasas_shutdown_controller(instance, MR_DCMD_HIBERNATE_SHUTDOWN);
>
> @@ -6280,6 +6315,16 @@ static void megasas_shutdown_controller(struct megasas_instance *instance,
> megasas_setup_jbod_map(instance);
> instance->unload = 0;
>
> + if (instance->is_ventura) {
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 1);
> + megasas_start_timer(instance,
> + &instance->r1_fp_hold_timer,
> + megasas_change_r1_fp_status,
> + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> + }
> +
> +
> /*
> * Initiate AEN (Asynchronous Event Notification)
> */
> @@ -6368,6 +6413,9 @@ static void megasas_detach_one(struct pci_dev *pdev)
> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
> del_timer_sync(&instance->sriov_heartbeat_timer);
>
> + if (instance->is_ventura)
> + del_timer_sync(&instance->r1_fp_hold_timer);
> +
> if (instance->fw_crash_state != UNAVAILABLE)
> megasas_free_host_crash_buffer(instance);
> scsi_remove_host(instance->host);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index a6957a3..7da4685 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -197,14 +197,19 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
>
> if (instance->max_raid_mapsize) {
> fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
> + if (fw_map_dyn->pci_threshold_bandwidth)
> + instance->pci_threshold_bandwidth =
> + le64_to_cpu(fw_map_dyn->pci_threshold_bandwidth);
> #if VD_EXT_DEBUG
> dev_dbg(&instance->pdev->dev,
> " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
> - " descTableSize 0x%x descTableNumElements 0x%x\n",
> + " descTableSize 0x%x descTableNumElements 0x%x, "
> + " PCIThreasholdBandwidth %llu\n",
> le32_to_cpu(fw_map_dyn->raid_map_size),
> le32_to_cpu(fw_map_dyn->desc_table_offset),
> le32_to_cpu(fw_map_dyn->desc_table_size),
> - le32_to_cpu(fw_map_dyn->desc_table_num_elements));
> + le32_to_cpu(fw_map_dyn->desc_table_num_elements),
> + instance->pci_threshold_bandwidth);
> dev_dbg(&instance->pdev->dev,
> "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
> #endif
> @@ -434,6 +439,8 @@ void MR_PopulateDrvRaidMap(struct megasas_instance *instance)
> sizeof(struct MR_DEV_HANDLE_INFO) *
> MAX_RAIDMAP_PHYSICAL_DEVICES);
> }
> + if (instance->is_ventura && !instance->pci_threshold_bandwidth)
> + instance->pci_threshold_bandwidth = ULLONG_MAX;
> }
>
> /*
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index f968a23..5992153 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -95,6 +95,7 @@ void megasas_start_timer(struct megasas_instance *instance,
> extern unsigned int dual_qdepth_disable;
> static void megasas_free_rdpq_fusion(struct megasas_instance *instance);
> static void megasas_free_reply_fusion(struct megasas_instance *instance);
> +void megasas_change_r1_fp_status(unsigned long instance_addr);
>
>
>
> @@ -2633,8 +2634,9 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
> * to get new command
> */
> if (cmd->is_raid_1_fp_write &&
> - atomic_inc_return(&instance->fw_outstanding) >
> - (instance->host->can_queue)) {
> + (atomic_inc_return(&instance->fw_outstanding) >
> + (instance->host->can_queue) ||
> + (!atomic_read(&instance->r1_write_fp_capable)))) {
> megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
> atomic_dec(&instance->fw_outstanding);
> } else if (cmd->is_raid_1_fp_write) {
> @@ -2643,17 +2645,19 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
> megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
> }
>
> -
> /*
> - * Issue the command to the FW
> - */
> + * Issue the command to the FW
> + */
> + if (scmd->sc_data_direction == PCI_DMA_TODEVICE && instance->is_ventura)
> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
You count the bytes written to the ventura card and based on that it is
asynchronously decided whether the r1_write_fp_capable bit is set in a timer function.
Please explain what should be achieved with this.
Thanks,
Tomas
>
> megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
>
> - if (r1_cmd)
> + if (r1_cmd) {
> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
> megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
> - instance->is_ventura);
> -
> + instance->is_ventura);
> + }
>
> return 0;
> }
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index c39c4ed..da05790 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -977,7 +977,7 @@ struct MR_FW_RAID_MAP_DYNAMIC {
> u32 desc_table_size; /* Total Size of desc table */
> /* Total Number of elements in the desc table */
> u32 desc_table_num_elements;
> - u64 reserved1;
> + u64 pci_threshold_bandwidth;
> u32 reserved2[3]; /*future use */
> /* timeout value used by driver in FP IOs */
> u8 fp_pd_io_timeout_sec;
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth
2016-12-09 13:58 ` Tomas Henzl
@ 2016-12-14 21:54 ` Sasikumar PC
2016-12-15 15:10 ` Tomas Henzl
0 siblings, 1 reply; 40+ messages in thread
From: Sasikumar PC @ 2016-12-14 21:54 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Friday, December 09, 2016 8:59 AM
To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path
based on the PCI Threshold Bandwidth
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> Large SEQ IO workload should sent as non fast path commands
>
> This patch is depending on patch 7
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 8 +++++
> drivers/scsi/megaraid/megaraid_sas_base.c | 48
+++++++++++++++++++++++++++++
> drivers/scsi/megaraid/megaraid_sas_fp.c | 11 +++++--
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 +++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 +-
> 5 files changed, 78 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
> b/drivers/scsi/megaraid/megaraid_sas.h
> index 3e087ab..eb5be2b 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -1429,6 +1429,8 @@ enum FW_BOOT_CONTEXT {
> #define MFI_1068_FW_HANDSHAKE_OFFSET 0x64
> #define MFI_1068_FW_READY 0xDDDD0000
>
> +#define MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL HZ
> +
> #define MR_MAX_REPLY_QUEUES_OFFSET 0X0000001F
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET 0X003FC000
> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
> @@ -2101,6 +2103,10 @@ struct megasas_instance {
> atomic_t ldio_outstanding;
> atomic_t fw_reset_no_pci_access;
>
> + atomic64_t bytes_wrote; /* used for raid1 fast path enable or
disable */
> + atomic_t r1_write_fp_capable;
Is a an atomic variable needed for a just boolean variable?
Sasi - As we need to synchronize timer thread and IO issue threads,
With atomic, at any point of time the value will be definitive.
With boolean, it depends, the value could be in transit while
one thread is reading and other is writing.
> +
> +
> struct megasas_instance_template *instancet;
> struct tasklet_struct isr_tasklet;
> struct work_struct work_init;
> @@ -2143,6 +2149,7 @@ struct megasas_instance {
> long reset_flags;
> struct mutex reset_mutex;
> struct timer_list sriov_heartbeat_timer;
> + struct timer_list r1_fp_hold_timer;
> char skip_heartbeat_timer_del;
> u8 requestorId;
> char PlasmaFW111;
> @@ -2159,6 +2166,7 @@ struct megasas_instance {
> bool is_ventura;
> bool msix_combined;
> u16 max_raid_mapsize;
> + u64 pci_threshold_bandwidth; /* used to control the fp writes */
> };
> struct MR_LD_VF_MAP {
> u32 size;
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 8aafb59..899d25c 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -1940,6 +1940,9 @@ void megaraid_sas_kill_hba(struct megasas_instance
*instance)
> }
> /* Complete outstanding ioctls when adapter is killed */
> megasas_complete_outstanding_ioctls(instance);
> + if (instance->is_ventura)
> + del_timer_sync(&instance->r1_fp_hold_timer);
> +
> }
>
> /**
> @@ -2438,6 +2441,24 @@ void megasas_sriov_heartbeat_handler(unsigned
long instance_addr)
> }
> }
>
> +/*Handler for disabling/enabling raid 1 fast paths*/ void
> +megasas_change_r1_fp_status(unsigned long instance_addr) {
> + struct megasas_instance *instance =
> + (struct megasas_instance *)instance_addr;
> + if (atomic64_read(&instance->bytes_wrote) >=
> + instance->pci_threshold_bandwidth)
{
> +
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 0);
> + } else {
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 1);
> + }
> + mod_timer(&instance->r1_fp_hold_timer,
> + jiffies + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> +}
> +
> /**
> * megasas_wait_for_outstanding - Wait for all outstanding cmds
> * @instance: Adapter soft state
> @@ -5371,6 +5392,17 @@ static int megasas_init_fw(struct
megasas_instance *instance)
> instance->skip_heartbeat_timer_del = 1;
> }
>
> + if (instance->is_ventura) {
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 1);
> + megasas_start_timer(instance,
> + &instance->r1_fp_hold_timer,
> + megasas_change_r1_fp_status,
> +
MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> + dev_info(&instance->pdev->dev, "starting
the raid 1 fp timer with interval %d\n",
> +
MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> + }
> +
> return 0;
>
> fail_get_ld_pd_list:
> @@ -6161,6 +6193,9 @@ static void megasas_shutdown_controller(struct
megasas_instance *instance,
> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
> del_timer_sync(&instance->sriov_heartbeat_timer);
>
> + if (instance->is_ventura)
> + del_timer_sync(&instance->r1_fp_hold_timer);
> +
> megasas_flush_cache(instance);
> megasas_shutdown_controller(instance, MR_DCMD_HIBERNATE_SHUTDOWN);
>
> @@ -6280,6 +6315,16 @@ static void megasas_shutdown_controller(struct
megasas_instance *instance,
> megasas_setup_jbod_map(instance);
> instance->unload = 0;
>
> + if (instance->is_ventura) {
> + atomic64_set(&instance->bytes_wrote, 0);
> + atomic_set(&instance->r1_write_fp_capable, 1);
> + megasas_start_timer(instance,
> + &instance->r1_fp_hold_timer,
> + megasas_change_r1_fp_status,
> +
MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
> + }
> +
> +
> /*
> * Initiate AEN (Asynchronous Event Notification)
> */
> @@ -6368,6 +6413,9 @@ static void megasas_detach_one(struct pci_dev
*pdev)
> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
> del_timer_sync(&instance->sriov_heartbeat_timer);
>
> + if (instance->is_ventura)
> + del_timer_sync(&instance->r1_fp_hold_timer);
> +
> if (instance->fw_crash_state != UNAVAILABLE)
> megasas_free_host_crash_buffer(instance);
> scsi_remove_host(instance->host);
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
> b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index a6957a3..7da4685 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -197,14 +197,19 @@ void MR_PopulateDrvRaidMap(struct
> megasas_instance *instance)
>
> if (instance->max_raid_mapsize) {
> fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
> + if (fw_map_dyn->pci_threshold_bandwidth)
> + instance->pci_threshold_bandwidth =
> + le64_to_cpu(fw_map_dyn->pci_threshold_bandwidth);
> #if VD_EXT_DEBUG
> dev_dbg(&instance->pdev->dev,
> " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
> - " descTableSize 0x%x descTableNumElements 0x%x\n",
> + " descTableSize 0x%x descTableNumElements 0x%x, "
> + " PCIThreasholdBandwidth %llu\n",
> le32_to_cpu(fw_map_dyn->raid_map_size),
> le32_to_cpu(fw_map_dyn->desc_table_offset),
> le32_to_cpu(fw_map_dyn->desc_table_size),
> - le32_to_cpu(fw_map_dyn->desc_table_num_elements));
> + le32_to_cpu(fw_map_dyn->desc_table_num_elements),
> + instance->pci_threshold_bandwidth);
> dev_dbg(&instance->pdev->dev,
> "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
#endif
> @@ -434,6 +439,8 @@ void MR_PopulateDrvRaidMap(struct megasas_instance
*instance)
> sizeof(struct MR_DEV_HANDLE_INFO) *
> MAX_RAIDMAP_PHYSICAL_DEVICES);
> }
> + if (instance->is_ventura && !instance->pci_threshold_bandwidth)
> + instance->pci_threshold_bandwidth = ULLONG_MAX;
> }
>
> /*
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index f968a23..5992153 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -95,6 +95,7 @@ void megasas_start_timer(struct megasas_instance
> *instance, extern unsigned int dual_qdepth_disable; static void
> megasas_free_rdpq_fusion(struct megasas_instance *instance); static
> void megasas_free_reply_fusion(struct megasas_instance *instance);
> +void megasas_change_r1_fp_status(unsigned long instance_addr);
>
>
>
> @@ -2633,8 +2634,9 @@ void megasas_prepare_secondRaid1_IO(struct
megasas_instance *instance,
> * to get new command
> */
> if (cmd->is_raid_1_fp_write &&
> - atomic_inc_return(&instance->fw_outstanding) >
> - (instance->host->can_queue)) {
> + (atomic_inc_return(&instance->fw_outstanding) >
> + (instance->host->can_queue) ||
> + (!atomic_read(&instance->r1_write_fp_capable)))) {
> megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
> atomic_dec(&instance->fw_outstanding);
> } else if (cmd->is_raid_1_fp_write) { @@ -2643,17 +2645,19 @@ void
> megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
> megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
> }
>
> -
> /*
> - * Issue the command to the FW
> - */
> + * Issue the command to the FW
> + */
> + if (scmd->sc_data_direction == PCI_DMA_TODEVICE &&
instance->is_ventura)
> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
You count the bytes written to the ventura card and based on that it is
asynchronously decided whether the r1_write_fp_capable bit is set in a
timer function.
Please explain what should be achieved with this.
Sasi - I am working on this and will be posting the update soon
Thanks,
Tomas
>
> megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
>
> - if (r1_cmd)
> + if (r1_cmd) {
> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
> megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
> - instance->is_ventura);
> -
> + instance->is_ventura);
> + }
>
> return 0;
> }
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> index c39c4ed..da05790 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
> @@ -977,7 +977,7 @@ struct MR_FW_RAID_MAP_DYNAMIC {
> u32 desc_table_size; /* Total Size of desc table */
> /* Total Number of elements in the desc table */
> u32 desc_table_num_elements;
> - u64 reserved1;
> + u64 pci_threshold_bandwidth;
> u32 reserved2[3]; /*future use */
> /* timeout value used by driver in FP IOs */
> u8 fp_pd_io_timeout_sec;
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth
2016-12-14 21:54 ` Sasikumar PC
@ 2016-12-15 15:10 ` Tomas Henzl
2016-12-20 1:51 ` Sasikumar PC
0 siblings, 1 reply; 40+ messages in thread
From: Tomas Henzl @ 2016-12-15 15:10 UTC (permalink / raw)
To: Sasikumar PC, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
On 14.12.2016 22:54, Sasikumar PC wrote:
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Friday, December 09, 2016 8:59 AM
> To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
> Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
> linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
> kiran-kumar.kasturi@broadcom.com
> Subject: Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path
> based on the PCI Threshold Bandwidth
>
> On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
>> Large SEQ IO workload should sent as non fast path commands
>>
>> This patch is depending on patch 7
>>
>> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
>> ---
>> drivers/scsi/megaraid/megaraid_sas.h | 8 +++++
>> drivers/scsi/megaraid/megaraid_sas_base.c | 48
> +++++++++++++++++++++++++++++
>> drivers/scsi/megaraid/megaraid_sas_fp.c | 11 +++++--
>> drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 +++++++-----
>> drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 +-
>> 5 files changed, 78 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
>> b/drivers/scsi/megaraid/megaraid_sas.h
>> index 3e087ab..eb5be2b 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>> @@ -1429,6 +1429,8 @@ enum FW_BOOT_CONTEXT {
>> #define MFI_1068_FW_HANDSHAKE_OFFSET 0x64
>> #define MFI_1068_FW_READY 0xDDDD0000
>>
>> +#define MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL HZ
>> +
>> #define MR_MAX_REPLY_QUEUES_OFFSET 0X0000001F
>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET 0X003FC000
>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
>> @@ -2101,6 +2103,10 @@ struct megasas_instance {
>> atomic_t ldio_outstanding;
>> atomic_t fw_reset_no_pci_access;
>>
>> + atomic64_t bytes_wrote; /* used for raid1 fast path enable or
> disable */
>> + atomic_t r1_write_fp_capable;
> Is a an atomic variable needed for a just boolean variable?
> Sasi - As we need to synchronize timer thread and IO issue threads,
> With atomic, at any point of time the value will be definitive.
> With boolean, it depends, the value could be in transit while
> one thread is reading and other is writing.
This explanation is I think not good enough, as a write of a char value
is atomic on all architectures. If you need synchronisation you probably
need a spinlock.
tomash
>
>> +
>> +
>> struct megasas_instance_template *instancet;
>> struct tasklet_struct isr_tasklet;
>> struct work_struct work_init;
>> @@ -2143,6 +2149,7 @@ struct megasas_instance {
>> long reset_flags;
>> struct mutex reset_mutex;
>> struct timer_list sriov_heartbeat_timer;
>> + struct timer_list r1_fp_hold_timer;
>> char skip_heartbeat_timer_del;
>> u8 requestorId;
>> char PlasmaFW111;
>> @@ -2159,6 +2166,7 @@ struct megasas_instance {
>> bool is_ventura;
>> bool msix_combined;
>> u16 max_raid_mapsize;
>> + u64 pci_threshold_bandwidth; /* used to control the fp writes */
>> };
>> struct MR_LD_VF_MAP {
>> u32 size;
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>> b/drivers/scsi/megaraid/megaraid_sas_base.c
>> index 8aafb59..899d25c 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>> @@ -1940,6 +1940,9 @@ void megaraid_sas_kill_hba(struct megasas_instance
> *instance)
>> }
>> /* Complete outstanding ioctls when adapter is killed */
>> megasas_complete_outstanding_ioctls(instance);
>> + if (instance->is_ventura)
>> + del_timer_sync(&instance->r1_fp_hold_timer);
>> +
>> }
>>
>> /**
>> @@ -2438,6 +2441,24 @@ void megasas_sriov_heartbeat_handler(unsigned
> long instance_addr)
>> }
>> }
>>
>> +/*Handler for disabling/enabling raid 1 fast paths*/ void
>> +megasas_change_r1_fp_status(unsigned long instance_addr) {
>> + struct megasas_instance *instance =
>> + (struct megasas_instance *)instance_addr;
>> + if (atomic64_read(&instance->bytes_wrote) >=
>> + instance->pci_threshold_bandwidth)
> {
>> +
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 0);
>> + } else {
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 1);
>> + }
>> + mod_timer(&instance->r1_fp_hold_timer,
>> + jiffies + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> +}
>> +
>> /**
>> * megasas_wait_for_outstanding - Wait for all outstanding cmds
>> * @instance: Adapter soft state
>> @@ -5371,6 +5392,17 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>> instance->skip_heartbeat_timer_del = 1;
>> }
>>
>> + if (instance->is_ventura) {
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 1);
>> + megasas_start_timer(instance,
>> + &instance->r1_fp_hold_timer,
>> + megasas_change_r1_fp_status,
>> +
> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> + dev_info(&instance->pdev->dev, "starting
> the raid 1 fp timer with interval %d\n",
>> +
> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> + }
>> +
>> return 0;
>>
>> fail_get_ld_pd_list:
>> @@ -6161,6 +6193,9 @@ static void megasas_shutdown_controller(struct
> megasas_instance *instance,
>> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
>> del_timer_sync(&instance->sriov_heartbeat_timer);
>>
>> + if (instance->is_ventura)
>> + del_timer_sync(&instance->r1_fp_hold_timer);
>> +
>> megasas_flush_cache(instance);
>> megasas_shutdown_controller(instance, MR_DCMD_HIBERNATE_SHUTDOWN);
>>
>> @@ -6280,6 +6315,16 @@ static void megasas_shutdown_controller(struct
> megasas_instance *instance,
>> megasas_setup_jbod_map(instance);
>> instance->unload = 0;
>>
>> + if (instance->is_ventura) {
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 1);
>> + megasas_start_timer(instance,
>> + &instance->r1_fp_hold_timer,
>> + megasas_change_r1_fp_status,
>> +
> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> + }
>> +
>> +
>> /*
>> * Initiate AEN (Asynchronous Event Notification)
>> */
>> @@ -6368,6 +6413,9 @@ static void megasas_detach_one(struct pci_dev
> *pdev)
>> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
>> del_timer_sync(&instance->sriov_heartbeat_timer);
>>
>> + if (instance->is_ventura)
>> + del_timer_sync(&instance->r1_fp_hold_timer);
>> +
>> if (instance->fw_crash_state != UNAVAILABLE)
>> megasas_free_host_crash_buffer(instance);
>> scsi_remove_host(instance->host);
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
>> b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> index a6957a3..7da4685 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> @@ -197,14 +197,19 @@ void MR_PopulateDrvRaidMap(struct
>> megasas_instance *instance)
>>
>> if (instance->max_raid_mapsize) {
>> fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
>> + if (fw_map_dyn->pci_threshold_bandwidth)
>> + instance->pci_threshold_bandwidth =
>> + le64_to_cpu(fw_map_dyn->pci_threshold_bandwidth);
>> #if VD_EXT_DEBUG
>> dev_dbg(&instance->pdev->dev,
>> " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
>> - " descTableSize 0x%x descTableNumElements 0x%x\n",
>> + " descTableSize 0x%x descTableNumElements 0x%x, "
>> + " PCIThreasholdBandwidth %llu\n",
>> le32_to_cpu(fw_map_dyn->raid_map_size),
>> le32_to_cpu(fw_map_dyn->desc_table_offset),
>> le32_to_cpu(fw_map_dyn->desc_table_size),
>> - le32_to_cpu(fw_map_dyn->desc_table_num_elements));
>> + le32_to_cpu(fw_map_dyn->desc_table_num_elements),
>> + instance->pci_threshold_bandwidth);
>> dev_dbg(&instance->pdev->dev,
>> "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
> #endif
>> @@ -434,6 +439,8 @@ void MR_PopulateDrvRaidMap(struct megasas_instance
> *instance)
>> sizeof(struct MR_DEV_HANDLE_INFO) *
>> MAX_RAIDMAP_PHYSICAL_DEVICES);
>> }
>> + if (instance->is_ventura && !instance->pci_threshold_bandwidth)
>> + instance->pci_threshold_bandwidth = ULLONG_MAX;
>> }
>>
>> /*
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> index f968a23..5992153 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> @@ -95,6 +95,7 @@ void megasas_start_timer(struct megasas_instance
>> *instance, extern unsigned int dual_qdepth_disable; static void
>> megasas_free_rdpq_fusion(struct megasas_instance *instance); static
>> void megasas_free_reply_fusion(struct megasas_instance *instance);
>> +void megasas_change_r1_fp_status(unsigned long instance_addr);
>>
>>
>>
>> @@ -2633,8 +2634,9 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> * to get new command
>> */
>> if (cmd->is_raid_1_fp_write &&
>> - atomic_inc_return(&instance->fw_outstanding) >
>> - (instance->host->can_queue)) {
>> + (atomic_inc_return(&instance->fw_outstanding) >
>> + (instance->host->can_queue) ||
>> + (!atomic_read(&instance->r1_write_fp_capable)))) {
>> megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
>> atomic_dec(&instance->fw_outstanding);
>> } else if (cmd->is_raid_1_fp_write) { @@ -2643,17 +2645,19 @@ void
>> megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
>> megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
>> }
>>
>> -
>> /*
>> - * Issue the command to the FW
>> - */
>> + * Issue the command to the FW
>> + */
>> + if (scmd->sc_data_direction == PCI_DMA_TODEVICE &&
> instance->is_ventura)
>> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
> You count the bytes written to the ventura card and based on that it is
> asynchronously decided whether the r1_write_fp_capable bit is set in a
> timer function.
> Please explain what should be achieved with this.
>
> Sasi - I am working on this and will be posting the update soon
>
> Thanks,
> Tomas
>
>
>
>
>> megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
>>
>> - if (r1_cmd)
>> + if (r1_cmd) {
>> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
>> megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
>> - instance->is_ventura);
>> -
>> + instance->is_ventura);
>> + }
>>
>> return 0;
>> }
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> index c39c4ed..da05790 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> @@ -977,7 +977,7 @@ struct MR_FW_RAID_MAP_DYNAMIC {
>> u32 desc_table_size; /* Total Size of desc table */
>> /* Total Number of elements in the desc table */
>> u32 desc_table_num_elements;
>> - u64 reserved1;
>> + u64 pci_threshold_bandwidth;
>> u32 reserved2[3]; /*future use */
>> /* timeout value used by driver in FP IOs */
>> u8 fp_pd_io_timeout_sec;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth
2016-12-15 15:10 ` Tomas Henzl
@ 2016-12-20 1:51 ` Sasikumar PC
2016-12-20 15:12 ` Tomas Henzl
0 siblings, 1 reply; 40+ messages in thread
From: Sasikumar PC @ 2016-12-20 1:51 UTC (permalink / raw)
To: Tomas Henzl, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
Hi Tomas,
Please see my response inline
Thanks
sasi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Thursday, December 15, 2016 10:10 AM
To: Sasikumar PC; jejb@kernel.org; hch@infradead.org
Cc: linux-scsi@vger.kernel.org; Sathya Prakash Veerichetty;
linux-kernel@vger.kernel.org; Christopher Owens; Kiran Kumar Kasturi
Subject: Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path
based on the PCI Threshold Bandwidth
On 14.12.2016 22:54, Sasikumar PC wrote:
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Friday, December 09, 2016 8:59 AM
> To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
> Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
> linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
> kiran-kumar.kasturi@broadcom.com
> Subject: Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast
> path based on the PCI Threshold Bandwidth
>
> On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
>> Large SEQ IO workload should sent as non fast path commands
>>
>> This patch is depending on patch 7
>>
>> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
>> ---
>> drivers/scsi/megaraid/megaraid_sas.h | 8 +++++
>> drivers/scsi/megaraid/megaraid_sas_base.c | 48
> +++++++++++++++++++++++++++++
>> drivers/scsi/megaraid/megaraid_sas_fp.c | 11 +++++--
>> drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 +++++++-----
>> drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 +-
>> 5 files changed, 78 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
>> b/drivers/scsi/megaraid/megaraid_sas.h
>> index 3e087ab..eb5be2b 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>> @@ -1429,6 +1429,8 @@ enum FW_BOOT_CONTEXT {
>> #define MFI_1068_FW_HANDSHAKE_OFFSET 0x64
>> #define MFI_1068_FW_READY 0xDDDD0000
>>
>> +#define MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL HZ
>> +
>> #define MR_MAX_REPLY_QUEUES_OFFSET 0X0000001F
>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET 0X003FC000
>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
>> @@ -2101,6 +2103,10 @@ struct megasas_instance {
>> atomic_t ldio_outstanding;
>> atomic_t fw_reset_no_pci_access;
>>
>> + atomic64_t bytes_wrote; /* used for raid1 fast path enable or
> disable */
>> + atomic_t r1_write_fp_capable;
> Is a an atomic variable needed for a just boolean variable?
> Sasi - As we need to synchronize timer thread and IO issue threads,
> With atomic, at any point of time the value will be definitive.
> With boolean, it depends, the value could be in transit while one
> thread is reading and other is writing.
This explanation is I think not good enough, as a write of a char value is
atomic on all architectures. If you need synchronisation you probably need a
spinlock.
Tomash
boolean may not be a char in all architectures/implementations. It could be
implementation specific isn't it ?
Spin_Lock is heavier as the check is in IO path.We need it to be consistent
non-transient value, not an exact synchronization.
There could be more values that we may set this variable to, to make
different decisions and value can be set in more places in future.
Atomic will help it keep consistent and extensible.
sasi
>
>> +
>> +
>> struct megasas_instance_template *instancet;
>> struct tasklet_struct isr_tasklet;
>> struct work_struct work_init;
>> @@ -2143,6 +2149,7 @@ struct megasas_instance {
>> long reset_flags;
>> struct mutex reset_mutex;
>> struct timer_list sriov_heartbeat_timer;
>> + struct timer_list r1_fp_hold_timer;
>> char skip_heartbeat_timer_del;
>> u8 requestorId;
>> char PlasmaFW111;
>> @@ -2159,6 +2166,7 @@ struct megasas_instance {
>> bool is_ventura;
>> bool msix_combined;
>> u16 max_raid_mapsize;
>> + u64 pci_threshold_bandwidth; /* used to control the fp writes */
>> };
>> struct MR_LD_VF_MAP {
>> u32 size;
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>> b/drivers/scsi/megaraid/megaraid_sas_base.c
>> index 8aafb59..899d25c 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>> @@ -1940,6 +1940,9 @@ void megaraid_sas_kill_hba(struct
>> megasas_instance
> *instance)
>> }
>> /* Complete outstanding ioctls when adapter is killed */
>> megasas_complete_outstanding_ioctls(instance);
>> + if (instance->is_ventura)
>> + del_timer_sync(&instance->r1_fp_hold_timer);
>> +
>> }
>>
>> /**
>> @@ -2438,6 +2441,24 @@ void megasas_sriov_heartbeat_handler(unsigned
> long instance_addr)
>> }
>> }
>>
>> +/*Handler for disabling/enabling raid 1 fast paths*/ void
>> +megasas_change_r1_fp_status(unsigned long instance_addr) {
>> + struct megasas_instance *instance =
>> + (struct megasas_instance *)instance_addr;
>> + if (atomic64_read(&instance->bytes_wrote) >=
>> + instance->pci_threshold_bandwidth)
> {
>> +
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 0);
>> + } else {
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 1);
>> + }
>> + mod_timer(&instance->r1_fp_hold_timer,
>> + jiffies + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> +}
>> +
>> /**
>> * megasas_wait_for_outstanding - Wait for all outstanding cmds
>> * @instance: Adapter soft state
>> @@ -5371,6 +5392,17 @@ static int megasas_init_fw(struct
> megasas_instance *instance)
>> instance->skip_heartbeat_timer_del = 1;
>> }
>>
>> + if (instance->is_ventura) {
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 1);
>> + megasas_start_timer(instance,
>> + &instance->r1_fp_hold_timer,
>> + megasas_change_r1_fp_status,
>> +
> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> + dev_info(&instance->pdev->dev, "starting
> the raid 1 fp timer with interval %d\n",
>> +
> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> + }
>> +
>> return 0;
>>
>> fail_get_ld_pd_list:
>> @@ -6161,6 +6193,9 @@ static void megasas_shutdown_controller(struct
> megasas_instance *instance,
>> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
>> del_timer_sync(&instance->sriov_heartbeat_timer);
>>
>> + if (instance->is_ventura)
>> + del_timer_sync(&instance->r1_fp_hold_timer);
>> +
>> megasas_flush_cache(instance);
>> megasas_shutdown_controller(instance, MR_DCMD_HIBERNATE_SHUTDOWN);
>>
>> @@ -6280,6 +6315,16 @@ static void megasas_shutdown_controller(struct
> megasas_instance *instance,
>> megasas_setup_jbod_map(instance);
>> instance->unload = 0;
>>
>> + if (instance->is_ventura) {
>> + atomic64_set(&instance->bytes_wrote, 0);
>> + atomic_set(&instance->r1_write_fp_capable, 1);
>> + megasas_start_timer(instance,
>> + &instance->r1_fp_hold_timer,
>> + megasas_change_r1_fp_status,
>> +
> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>> + }
>> +
>> +
>> /*
>> * Initiate AEN (Asynchronous Event Notification)
>> */
>> @@ -6368,6 +6413,9 @@ static void megasas_detach_one(struct pci_dev
> *pdev)
>> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
>> del_timer_sync(&instance->sriov_heartbeat_timer);
>>
>> + if (instance->is_ventura)
>> + del_timer_sync(&instance->r1_fp_hold_timer);
>> +
>> if (instance->fw_crash_state != UNAVAILABLE)
>> megasas_free_host_crash_buffer(instance);
>> scsi_remove_host(instance->host);
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
>> b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> index a6957a3..7da4685 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
>> @@ -197,14 +197,19 @@ void MR_PopulateDrvRaidMap(struct
>> megasas_instance *instance)
>>
>> if (instance->max_raid_mapsize) {
>> fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
>> + if (fw_map_dyn->pci_threshold_bandwidth)
>> + instance->pci_threshold_bandwidth =
>> + le64_to_cpu(fw_map_dyn->pci_threshold_bandwidth);
>> #if VD_EXT_DEBUG
>> dev_dbg(&instance->pdev->dev,
>> " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
>> - " descTableSize 0x%x descTableNumElements 0x%x\n",
>> + " descTableSize 0x%x descTableNumElements 0x%x, "
>> + " PCIThreasholdBandwidth %llu\n",
>> le32_to_cpu(fw_map_dyn->raid_map_size),
>> le32_to_cpu(fw_map_dyn->desc_table_offset),
>> le32_to_cpu(fw_map_dyn->desc_table_size),
>> - le32_to_cpu(fw_map_dyn->desc_table_num_elements));
>> + le32_to_cpu(fw_map_dyn->desc_table_num_elements),
>> + instance->pci_threshold_bandwidth);
>> dev_dbg(&instance->pdev->dev,
>> "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
> #endif
>> @@ -434,6 +439,8 @@ void MR_PopulateDrvRaidMap(struct
>> megasas_instance
> *instance)
>> sizeof(struct MR_DEV_HANDLE_INFO) *
>> MAX_RAIDMAP_PHYSICAL_DEVICES);
>> }
>> + if (instance->is_ventura && !instance->pci_threshold_bandwidth)
>> + instance->pci_threshold_bandwidth = ULLONG_MAX;
>> }
>>
>> /*
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> index f968a23..5992153 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>> @@ -95,6 +95,7 @@ void megasas_start_timer(struct megasas_instance
>> *instance, extern unsigned int dual_qdepth_disable; static void
>> megasas_free_rdpq_fusion(struct megasas_instance *instance); static
>> void megasas_free_reply_fusion(struct megasas_instance *instance);
>> +void megasas_change_r1_fp_status(unsigned long instance_addr);
>>
>>
>>
>> @@ -2633,8 +2634,9 @@ void megasas_prepare_secondRaid1_IO(struct
> megasas_instance *instance,
>> * to get new command
>> */
>> if (cmd->is_raid_1_fp_write &&
>> - atomic_inc_return(&instance->fw_outstanding) >
>> - (instance->host->can_queue)) {
>> + (atomic_inc_return(&instance->fw_outstanding) >
>> + (instance->host->can_queue) ||
>> + (!atomic_read(&instance->r1_write_fp_capable)))) {
>> megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
>> atomic_dec(&instance->fw_outstanding);
>> } else if (cmd->is_raid_1_fp_write) { @@ -2643,17 +2645,19 @@ void
>> megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
>> megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
>> }
>>
>> -
>> /*
>> - * Issue the command to the FW
>> - */
>> + * Issue the command to the FW
>> + */
>> + if (scmd->sc_data_direction == PCI_DMA_TODEVICE &&
> instance->is_ventura)
>> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
> You count the bytes written to the ventura card and based on that it
> is asynchronously decided whether the r1_write_fp_capable bit is set
> in a timer function.
> Please explain what should be achieved with this.
Certain write IOs can be sent to Firmware on ventura adapter or bypass
Firmware and sent to drives, through hardware.
When the driver sends write IOs in the second path, it needs to send two
such IOs one for each physical drive, in case RAID 1 logical devices.
When two IOs are sent with the same payload, the payload need to cross PCI
twice consuming twice the bandwidth for the same payload which affects the
performance.
The idea here is to make a decision of when to bypass firmware and when not,
based on write bandwidth that can be handled by adapter and to meet
performance goals.
That's the reason write payload is monitored.
Sasi
>
> Sasi - I am working on this and will be posting the update soon
>
> Thanks,
> Tomas
>
>
>
>
>> megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
>>
>> - if (r1_cmd)
>> + if (r1_cmd) {
>> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
>> megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
>> - instance->is_ventura);
>> -
>> + instance->is_ventura);
>> + }
>>
>> return 0;
>> }
>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> index c39c4ed..da05790 100644
>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>> @@ -977,7 +977,7 @@ struct MR_FW_RAID_MAP_DYNAMIC {
>> u32 desc_table_size; /* Total Size of desc table */
>> /* Total Number of elements in the desc table */
>> u32 desc_table_num_elements;
>> - u64 reserved1;
>> + u64 pci_threshold_bandwidth;
>> u32 reserved2[3]; /*future use */
>> /* timeout value used by driver in FP IOs */
>> u8 fp_pd_io_timeout_sec;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in the body of a message to majordomo@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth
2016-12-20 1:51 ` Sasikumar PC
@ 2016-12-20 15:12 ` Tomas Henzl
0 siblings, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-20 15:12 UTC (permalink / raw)
To: Sasikumar PC, jejb, hch
Cc: linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi
On 20.12.2016 02:51, Sasikumar PC wrote:
> Hi Tomas,
>
> Please see my response inline
>
> Thanks
> sasi
>
> -----Original Message-----
> From: Tomas Henzl [mailto:thenzl@redhat.com]
> Sent: Thursday, December 15, 2016 10:10 AM
> To: Sasikumar PC; jejb@kernel.org; hch@infradead.org
> Cc: linux-scsi@vger.kernel.org; Sathya Prakash Veerichetty;
> linux-kernel@vger.kernel.org; Christopher Owens; Kiran Kumar Kasturi
> Subject: Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path
> based on the PCI Threshold Bandwidth
>
> On 14.12.2016 22:54, Sasikumar PC wrote:
>> Hi Tomas,
>>
>> Please see my response inline
>>
>> Thanks
>> sasi
>>
>> -----Original Message-----
>> From: Tomas Henzl [mailto:thenzl@redhat.com]
>> Sent: Friday, December 09, 2016 8:59 AM
>> To: Sasikumar Chandrasekaran; jejb@kernel.org; hch@infradead.org
>> Cc: linux-scsi@vger.kernel.org; Sathya.Prakash@broadcom.com;
>> linux-kernel@vger.kernel.org; christopher.owens@broadcom.com;
>> kiran-kumar.kasturi@broadcom.com
>> Subject: Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast
>> path based on the PCI Threshold Bandwidth
>>
>> On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
>>> Large SEQ IO workload should sent as non fast path commands
>>>
>>> This patch is depending on patch 7
>>>
>>> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
>>> ---
>>> drivers/scsi/megaraid/megaraid_sas.h | 8 +++++
>>> drivers/scsi/megaraid/megaraid_sas_base.c | 48
>> +++++++++++++++++++++++++++++
>>> drivers/scsi/megaraid/megaraid_sas_fp.c | 11 +++++--
>>> drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 +++++++-----
>>> drivers/scsi/megaraid/megaraid_sas_fusion.h | 2 +-
>>> 5 files changed, 78 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h
>>> b/drivers/scsi/megaraid/megaraid_sas.h
>>> index 3e087ab..eb5be2b 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas.h
>>> +++ b/drivers/scsi/megaraid/megaraid_sas.h
>>> @@ -1429,6 +1429,8 @@ enum FW_BOOT_CONTEXT {
>>> #define MFI_1068_FW_HANDSHAKE_OFFSET 0x64
>>> #define MFI_1068_FW_READY 0xDDDD0000
>>>
>>> +#define MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL HZ
>>> +
>>> #define MR_MAX_REPLY_QUEUES_OFFSET 0X0000001F
>>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET 0X003FC000
>>> #define MR_MAX_REPLY_QUEUES_EXT_OFFSET_SHIFT 14
>>> @@ -2101,6 +2103,10 @@ struct megasas_instance {
>>> atomic_t ldio_outstanding;
>>> atomic_t fw_reset_no_pci_access;
>>>
>>> + atomic64_t bytes_wrote; /* used for raid1 fast path enable or
>> disable */
>>> + atomic_t r1_write_fp_capable;
>> Is a an atomic variable needed for a just boolean variable?
>> Sasi - As we need to synchronize timer thread and IO issue threads,
>> With atomic, at any point of time the value will be definitive.
>> With boolean, it depends, the value could be in transit while one
>> thread is reading and other is writing.
> This explanation is I think not good enough, as a write of a char value is
> atomic on all architectures. If you need synchronisation you probably need a
> spinlock.
> Tomash
>
> boolean may not be a char in all architectures/implementations. It could be
> implementation specific isn't it ?
On which arch?
> Spin_Lock is heavier as the check is in IO path.
Lightest form of atomic variable for isolated write and read is probably a char - so why can't
you use that plain basic type to store a boolean value?
> We need it to be consistent
> non-transient value, not an exact synchronization.
Could you be please more specific - what exactly is the transient value other than true or false ?
> There could be more values that we may set this variable to, to make
> different decisions and value can be set in more places in future.
> Atomic will help it keep consistent and extensible.
And then you'll rename the variable and use bit operations or may use
different state values and for that a char or int which is atomic per se
are the best option.
You've tested the whole series so you try to not change anything in the series,
I'm trying to understand.
You wrote earlier here that an explicit synchronisation is not needed,
that means, that there is no race condition possible and the
code is just a bit less then ideal. ok, fine, i'll this pass.
>
> sasi
>
>>> +
>>> +
>>> struct megasas_instance_template *instancet;
>>> struct tasklet_struct isr_tasklet;
>>> struct work_struct work_init;
>>> @@ -2143,6 +2149,7 @@ struct megasas_instance {
>>> long reset_flags;
>>> struct mutex reset_mutex;
>>> struct timer_list sriov_heartbeat_timer;
>>> + struct timer_list r1_fp_hold_timer;
>>> char skip_heartbeat_timer_del;
>>> u8 requestorId;
>>> char PlasmaFW111;
>>> @@ -2159,6 +2166,7 @@ struct megasas_instance {
>>> bool is_ventura;
>>> bool msix_combined;
>>> u16 max_raid_mapsize;
>>> + u64 pci_threshold_bandwidth; /* used to control the fp writes */
>>> };
>>> struct MR_LD_VF_MAP {
>>> u32 size;
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>>> b/drivers/scsi/megaraid/megaraid_sas_base.c
>>> index 8aafb59..899d25c 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
>>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>>> @@ -1940,6 +1940,9 @@ void megaraid_sas_kill_hba(struct
>>> megasas_instance
>> *instance)
>>> }
>>> /* Complete outstanding ioctls when adapter is killed */
>>> megasas_complete_outstanding_ioctls(instance);
>>> + if (instance->is_ventura)
>>> + del_timer_sync(&instance->r1_fp_hold_timer);
>>> +
>>> }
>>>
>>> /**
>>> @@ -2438,6 +2441,24 @@ void megasas_sriov_heartbeat_handler(unsigned
>> long instance_addr)
>>> }
>>> }
>>>
>>> +/*Handler for disabling/enabling raid 1 fast paths*/ void
>>> +megasas_change_r1_fp_status(unsigned long instance_addr) {
>>> + struct megasas_instance *instance =
>>> + (struct megasas_instance *)instance_addr;
>>> + if (atomic64_read(&instance->bytes_wrote) >=
>>> + instance->pci_threshold_bandwidth)
>> {
>>> +
>>> + atomic64_set(&instance->bytes_wrote, 0);
>>> + atomic_set(&instance->r1_write_fp_capable, 0);
>>> + } else {
>>> + atomic64_set(&instance->bytes_wrote, 0);
>>> + atomic_set(&instance->r1_write_fp_capable, 1);
>>> + }
>>> + mod_timer(&instance->r1_fp_hold_timer,
>>> + jiffies + MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>>> +}
>>> +
>>> /**
>>> * megasas_wait_for_outstanding - Wait for all outstanding cmds
>>> * @instance: Adapter soft state
>>> @@ -5371,6 +5392,17 @@ static int megasas_init_fw(struct
>> megasas_instance *instance)
>>> instance->skip_heartbeat_timer_del = 1;
>>> }
>>>
>>> + if (instance->is_ventura) {
>>> + atomic64_set(&instance->bytes_wrote, 0);
>>> + atomic_set(&instance->r1_write_fp_capable, 1);
>>> + megasas_start_timer(instance,
>>> + &instance->r1_fp_hold_timer,
>>> + megasas_change_r1_fp_status,
>>> +
>> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>>> + dev_info(&instance->pdev->dev, "starting
>> the raid 1 fp timer with interval %d\n",
>>> +
>> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>>> + }
>>> +
>>> return 0;
>>>
>>> fail_get_ld_pd_list:
>>> @@ -6161,6 +6193,9 @@ static void megasas_shutdown_controller(struct
>> megasas_instance *instance,
>>> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
>>> del_timer_sync(&instance->sriov_heartbeat_timer);
>>>
>>> + if (instance->is_ventura)
>>> + del_timer_sync(&instance->r1_fp_hold_timer);
>>> +
>>> megasas_flush_cache(instance);
>>> megasas_shutdown_controller(instance, MR_DCMD_HIBERNATE_SHUTDOWN);
>>>
>>> @@ -6280,6 +6315,16 @@ static void megasas_shutdown_controller(struct
>> megasas_instance *instance,
>>> megasas_setup_jbod_map(instance);
>>> instance->unload = 0;
>>>
>>> + if (instance->is_ventura) {
>>> + atomic64_set(&instance->bytes_wrote, 0);
>>> + atomic_set(&instance->r1_write_fp_capable, 1);
>>> + megasas_start_timer(instance,
>>> + &instance->r1_fp_hold_timer,
>>> + megasas_change_r1_fp_status,
>>> +
>> MEGASAS_RAID1_FAST_PATH_STATUS_CHECK_INTERVAL);
>>> + }
>>> +
>>> +
>>> /*
>>> * Initiate AEN (Asynchronous Event Notification)
>>> */
>>> @@ -6368,6 +6413,9 @@ static void megasas_detach_one(struct pci_dev
>> *pdev)
>>> if (instance->requestorId && !instance->skip_heartbeat_timer_del)
>>> del_timer_sync(&instance->sriov_heartbeat_timer);
>>>
>>> + if (instance->is_ventura)
>>> + del_timer_sync(&instance->r1_fp_hold_timer);
>>> +
>>> if (instance->fw_crash_state != UNAVAILABLE)
>>> megasas_free_host_crash_buffer(instance);
>>> scsi_remove_host(instance->host);
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
>>> b/drivers/scsi/megaraid/megaraid_sas_fp.c
>>> index a6957a3..7da4685 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
>>> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
>>> @@ -197,14 +197,19 @@ void MR_PopulateDrvRaidMap(struct
>>> megasas_instance *instance)
>>>
>>> if (instance->max_raid_mapsize) {
>>> fw_map_dyn = fusion->ld_map[(instance->map_id & 1)];
>>> + if (fw_map_dyn->pci_threshold_bandwidth)
>>> + instance->pci_threshold_bandwidth =
>>> + le64_to_cpu(fw_map_dyn->pci_threshold_bandwidth);
>>> #if VD_EXT_DEBUG
>>> dev_dbg(&instance->pdev->dev,
>>> " raidMapSize 0x%x fw_map_dyn->descTableOffset 0x%x, "
>>> - " descTableSize 0x%x descTableNumElements 0x%x\n",
>>> + " descTableSize 0x%x descTableNumElements 0x%x, "
>>> + " PCIThreasholdBandwidth %llu\n",
>>> le32_to_cpu(fw_map_dyn->raid_map_size),
>>> le32_to_cpu(fw_map_dyn->desc_table_offset),
>>> le32_to_cpu(fw_map_dyn->desc_table_size),
>>> - le32_to_cpu(fw_map_dyn->desc_table_num_elements));
>>> + le32_to_cpu(fw_map_dyn->desc_table_num_elements),
>>> + instance->pci_threshold_bandwidth);
>>> dev_dbg(&instance->pdev->dev,
>>> "drv map %p ldCount %d\n", drv_map, fw_map_dyn->ld_count);
>> #endif
>>> @@ -434,6 +439,8 @@ void MR_PopulateDrvRaidMap(struct
>>> megasas_instance
>> *instance)
>>> sizeof(struct MR_DEV_HANDLE_INFO) *
>>> MAX_RAIDMAP_PHYSICAL_DEVICES);
>>> }
>>> + if (instance->is_ventura && !instance->pci_threshold_bandwidth)
>>> + instance->pci_threshold_bandwidth = ULLONG_MAX;
>>> }
>>>
>>> /*
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>>> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>>> index f968a23..5992153 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>>> @@ -95,6 +95,7 @@ void megasas_start_timer(struct megasas_instance
>>> *instance, extern unsigned int dual_qdepth_disable; static void
>>> megasas_free_rdpq_fusion(struct megasas_instance *instance); static
>>> void megasas_free_reply_fusion(struct megasas_instance *instance);
>>> +void megasas_change_r1_fp_status(unsigned long instance_addr);
>>>
>>>
>>>
>>> @@ -2633,8 +2634,9 @@ void megasas_prepare_secondRaid1_IO(struct
>> megasas_instance *instance,
>>> * to get new command
>>> */
>>> if (cmd->is_raid_1_fp_write &&
>>> - atomic_inc_return(&instance->fw_outstanding) >
>>> - (instance->host->can_queue)) {
>>> + (atomic_inc_return(&instance->fw_outstanding) >
>>> + (instance->host->can_queue) ||
>>> + (!atomic_read(&instance->r1_write_fp_capable)))) {
>>> megasas_fpio_to_ldio(instance, cmd, cmd->scmd);
>>> atomic_dec(&instance->fw_outstanding);
>>> } else if (cmd->is_raid_1_fp_write) { @@ -2643,17 +2645,19 @@ void
>>> megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
>>> megasas_prepare_secondRaid1_IO(instance, cmd, r1_cmd);
>>> }
>>>
>>> -
>>> /*
>>> - * Issue the command to the FW
>>> - */
>>> + * Issue the command to the FW
>>> + */
>>> + if (scmd->sc_data_direction == PCI_DMA_TODEVICE &&
>> instance->is_ventura)
>>> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
>> You count the bytes written to the ventura card and based on that it
>> is asynchronously decided whether the r1_write_fp_capable bit is set
>> in a timer function.
>> Please explain what should be achieved with this.
> Certain write IOs can be sent to Firmware on ventura adapter or bypass
> Firmware and sent to drives, through hardware.
> When the driver sends write IOs in the second path, it needs to send two
> such IOs one for each physical drive, in case RAID 1 logical devices.
> When two IOs are sent with the same payload, the payload need to cross PCI
> twice consuming twice the bandwidth for the same payload which affects the
> performance.
> The idea here is to make a decision of when to bypass firmware and when not,
> based on write bandwidth that can be handled by adapter and to meet
> performance goals.
> That's the reason write payload is monitored.
With the explanation makes sense now. Thanks.
>
> Sasi
>> Sasi - I am working on this and will be posting the update soon
>>
>> Thanks,
>> Tomas
>>
>>
>>
>>
>>> megasas_fire_cmd_fusion(instance, req_desc, instance->is_ventura);
>>>
>>> - if (r1_cmd)
>>> + if (r1_cmd) {
>>> + atomic64_add(scsi_bufflen(scmd), &instance->bytes_wrote);
>>> megasas_fire_cmd_fusion(instance, r1_cmd->request_desc,
>>> - instance->is_ventura);
>>> -
>>> + instance->is_ventura);
>>> + }
>>>
>>> return 0;
>>> }
>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>>> b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>>> index c39c4ed..da05790 100644
>>> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>>> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>>> @@ -977,7 +977,7 @@ struct MR_FW_RAID_MAP_DYNAMIC {
>>> u32 desc_table_size; /* Total Size of desc table */
>>> /* Total Number of elements in the desc table */
>>> u32 desc_table_num_elements;
>>> - u64 reserved1;
>>> + u64 pci_threshold_bandwidth;
>>> u32 reserved2[3]; /*future use */
>>> /* timeout value used by driver in FP IOs */
>>> u8 fp_pd_io_timeout_sec;
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
>> in the body of a message to majordomo@vger.kernel.org More majordomo
>> info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (7 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 14:01 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
` (2 subsequent siblings)
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
ldio outstanding variable needs to be decremented in io completion path for
iMR dual queue depth
This patch is depending on patch 8
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 5992153..3598590 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2584,7 +2584,6 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
if (atomic_inc_return(&instance->fw_outstanding) >
instance->host->can_queue) {
- dev_err(&instance->pdev->dev, "Throttle IOs beyond Controller queue depth\n");
atomic_dec(&instance->fw_outstanding);
return SCSI_MLQUEUE_HOST_BUSY;
}
@@ -2818,6 +2817,10 @@ void megasas_prepare_secondRaid1_IO(struct megasas_instance *instance,
= 0;
scsi_io_req->RaidContext.raid_context.ex_status
= 0;
+ if (instance->ldio_threshold
+ && megasas_cmd_type(scmd_local)
+ == READ_WRITE_LDIO)
+ atomic_dec(&instance->ldio_outstanding);
megasas_return_cmd_fusion(instance, cmd_fusion);
scsi_dma_unmap(scmd_local);
scmd_local->scsi_done(scmd_local);
@@ -3966,7 +3969,9 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
scmd_local->result =
megasas_check_mpio_paths(instance,
scmd_local);
- if (megasas_cmd_type(scmd_local) == READ_WRITE_LDIO)
+ if (instance->ldio_threshold &&
+ megasas_cmd_type(scmd_local)
+ == READ_WRITE_LDIO)
atomic_dec(&instance->ldio_outstanding);
megasas_return_cmd_fusion(instance, cmd_fusion);
scsi_dma_unmap(scmd_local);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (8 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 14:07 ` Tomas Henzl
2016-12-06 23:00 ` [PATCH V4 11/11] megaraid_sas: driver version upgrade Sasikumar Chandrasekaran
2016-12-07 7:31 ` [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Christoph Hellwig
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
Update Linux driver to use new pdTargetId field for JBOD target ID
This patch is depending on patch 9
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 105 +++++++++++++++++++++-------
drivers/scsi/megaraid/megaraid_sas_base.c | 3 +
drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
drivers/scsi/megaraid/megaraid_sas_fusion.h | 3 +-
4 files changed, 84 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index eb5be2b..7334e07 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -1317,7 +1317,55 @@ struct megasas_ctrl_info {
#endif
} adapterOperations3;
- u8 pad[0x800-0x7EC];
+ struct {
+#if defined(__BIG_ENDIAN_BITFIELD)
+ u8 reserved:7;
+ /* Indicates whether the CPLD image is part of
+ * the package and stored in flash
+ */
+ u8 cpld_in_flash:1;
+#else
+ u8 cpld_in_flash:1;
+ u8 reserved:7;
+#endif
+ u8 reserved1[3];
+ /* Null terminated string. Has the version
+ * information if cpld_in_flash = FALSE
+ */
+ u8 userCodeDefinition[12];
+ } cpld; /* Valid only if upgradableCPLD is TRUE */
+
+ struct {
+ #if defined(__BIG_ENDIAN_BITFIELD)
+ u16 reserved:8;
+ u16 fw_swaps_bbu_vpd_info:1;
+ u16 support_pd_map_target_id:1;
+ u16 support_ses_ctrl_in_multipathcfg:1;
+ u16 image_upload_supported:1;
+ u16 support_encrypted_mfc:1;
+ u16 supported_enc_algo:1;
+ u16 support_ibutton_less:1;
+ u16 ctrl_info_ext_supported:1;
+ #else
+
+ u16 ctrl_info_ext_supported:1;
+ u16 support_ibutton_less:1;
+ u16 supported_enc_algo:1;
+ u16 support_encrypted_mfc:1;
+ u16 image_upload_supported:1;
+ /* FW supports LUN based association and target port based */
+ u16 support_ses_ctrl_in_multipathcfg:1;
+ /* association for the SES device connected in multipath mode */
+ /* FW defines Jbod target Id within MR_PD_CFG_SEQ */
+ u16 support_pd_map_target_id:1;
+ /* FW swaps relevant fields in MR_BBU_VPD_INFO_FIXED to
+ * provide the data in little endian order
+ */
+ u16 fw_swaps_bbu_vpd_info:1;
+ u16 reserved:8;
+ #endif
+ } adapter_operations4;
+ u8 pad[0x800-0x7FE]; /* 0x7FE pad to 2K for expansion */
} __packed;
/*
@@ -1557,33 +1605,35 @@ struct megasas_header {
typedef union _MFI_CAPABILITIES {
struct {
#if defined(__BIG_ENDIAN_BITFIELD)
- u32 reserved:20;
- u32 support_qd_throttling:1;
- u32 support_fp_rlbypass:1;
- u32 support_vfid_in_ioframe:1;
- u32 support_ext_io_size:1;
- u32 support_ext_queue_depth:1;
- u32 security_protocol_cmds_fw:1;
- u32 support_core_affinity:1;
- u32 support_ndrive_r1_lb:1;
- u32 support_max_255lds:1;
- u32 support_fastpath_wb:1;
- u32 support_additional_msix:1;
- u32 support_fp_remote_lun:1;
+ u32 reserved:19;
+ u32 support_pd_map_target_id:1;
+ u32 support_qd_throttling:1;
+ u32 support_fp_rlbypass:1;
+ u32 support_vfid_in_ioframe:1;
+ u32 support_ext_io_size:1;
+ u32 support_ext_queue_depth:1;
+ u32 security_protocol_cmds_fw:1;
+ u32 support_core_affinity:1;
+ u32 support_ndrive_r1_lb:1;
+ u32 support_max_255lds:1;
+ u32 support_fastpath_wb:1;
+ u32 support_additional_msix:1;
+ u32 support_fp_remote_lun:1;
#else
- u32 support_fp_remote_lun:1;
- u32 support_additional_msix:1;
- u32 support_fastpath_wb:1;
- u32 support_max_255lds:1;
- u32 support_ndrive_r1_lb:1;
- u32 support_core_affinity:1;
- u32 security_protocol_cmds_fw:1;
- u32 support_ext_queue_depth:1;
- u32 support_ext_io_size:1;
- u32 support_vfid_in_ioframe:1;
- u32 support_fp_rlbypass:1;
- u32 support_qd_throttling:1;
- u32 reserved:20;
+ u32 support_fp_remote_lun:1;
+ u32 support_additional_msix:1;
+ u32 support_fastpath_wb:1;
+ u32 support_max_255lds:1;
+ u32 support_ndrive_r1_lb:1;
+ u32 support_core_affinity:1;
+ u32 security_protocol_cmds_fw:1;
+ u32 support_ext_queue_depth:1;
+ u32 support_ext_io_size:1;
+ u32 support_vfid_in_ioframe:1;
+ u32 support_fp_rlbypass:1;
+ u32 support_qd_throttling:1;
+ u32 support_pd_map_target_id:1;
+ u32 reserved:19;
#endif
} mfi_capabilities;
__le32 reg;
@@ -2052,6 +2102,7 @@ struct megasas_instance {
u32 crash_dump_drv_support;
u32 crash_dump_app_support;
u32 secure_jbod_support;
+ u32 support_morethan256jbod; /* FW support for more than 256 PD/JBOD */
bool use_seqnum_jbod_fp; /* Added for PD sequence */
spinlock_t crashdump_lock;
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 899d25c..9e24d18 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4577,6 +4577,7 @@ static void megasas_update_ext_vd_details(struct megasas_instance *instance)
le32_to_cpus((u32 *)&ctrl_info->properties.OnOffProperties);
le32_to_cpus((u32 *)&ctrl_info->adapterOperations2);
le32_to_cpus((u32 *)&ctrl_info->adapterOperations3);
+ le16_to_cpus((u16 *)&ctrl_info->adapter_operations4);
/* Update the latest Ext VD info.
* From Init path, store current firmware details.
@@ -4586,6 +4587,8 @@ static void megasas_update_ext_vd_details(struct megasas_instance *instance)
megasas_update_ext_vd_details(instance);
instance->use_seqnum_jbod_fp =
ctrl_info->adapterOperations3.useSeqNumJbodFP;
+ instance->support_morethan256jbod =
+ ctrl_info->adapter_operations4.support_pd_map_target_id;
/*Check whether controller is iMR or MR */
instance->is_imr = (ctrl_info->memory_size ? 0 : 1);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 3598590..dc56dd8 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -864,6 +864,7 @@ static int megasas_create_sg_sense_fusion(struct megasas_instance *instance)
drv_ops->mfi_capabilities.support_ext_queue_depth = 1;
drv_ops->mfi_capabilities.support_qd_throttling = 1;
+ drv_ops->mfi_capabilities.support_pd_map_target_id = 1;
/* Convert capability to LE32 */
cpu_to_le32s((u32 *)&init_frame->driver_operations.mfi_capabilities);
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index da05790..3b66727 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -1189,7 +1189,8 @@ struct MR_PD_CFG_SEQ {
u8 reserved:7;
#endif
} capability;
- u8 reserved[3];
+ u8 reserved;
+ u16 pd_target_id;
} __packed;
struct MR_PD_CFG_SEQ_NUM_SYNC {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH V4 11/11] megaraid_sas: driver version upgrade
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (9 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
@ 2016-12-06 23:00 ` Sasikumar Chandrasekaran
2016-12-09 14:07 ` Tomas Henzl
2016-12-07 7:31 ` [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Christoph Hellwig
11 siblings, 1 reply; 40+ messages in thread
From: Sasikumar Chandrasekaran @ 2016-12-06 23:00 UTC (permalink / raw)
To: jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi, thenzl, sasikumar.pc
Upgrade driver version.
This patch is depending on patch 10
Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
index 7334e07..310555a 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -35,8 +35,8 @@
/*
* MegaRAID SAS Driver meta data
*/
-#define MEGASAS_VERSION "06.812.07.00-rc1"
-#define MEGASAS_RELDATE "August 22, 2016"
+#define MEGASAS_VERSION "07.700.00.00-rc1"
+#define MEGASAS_RELDATE "November 29, 2016"
/*
* Device IDs
--
1.8.3.1
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH V4 11/11] megaraid_sas: driver version upgrade
2016-12-06 23:00 ` [PATCH V4 11/11] megaraid_sas: driver version upgrade Sasikumar Chandrasekaran
@ 2016-12-09 14:07 ` Tomas Henzl
0 siblings, 0 replies; 40+ messages in thread
From: Tomas Henzl @ 2016-12-09 14:07 UTC (permalink / raw)
To: Sasikumar Chandrasekaran, jejb, hch
Cc: linux-scsi, Sathya.Prakash, linux-kernel, christopher.owens,
kiran-kumar.kasturi
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote:
> Upgrade driver version.
>
> This patch is depending on patch 10
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index 7334e07..310555a 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -35,8 +35,8 @@
> /*
> * MegaRAID SAS Driver meta data
> */
> -#define MEGASAS_VERSION "06.812.07.00-rc1"
> -#define MEGASAS_RELDATE "August 22, 2016"
> +#define MEGASAS_VERSION "07.700.00.00-rc1"
> +#define MEGASAS_RELDATE "November 29, 2016"
>
> /*
> * Device IDs
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next
2016-12-06 23:00 [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
` (10 preceding siblings ...)
2016-12-06 23:00 ` [PATCH V4 11/11] megaraid_sas: driver version upgrade Sasikumar Chandrasekaran
@ 2016-12-07 7:31 ` Christoph Hellwig
2016-12-11 14:04 ` Sasikumar PC
11 siblings, 1 reply; 40+ messages in thread
From: Christoph Hellwig @ 2016-12-07 7:31 UTC (permalink / raw)
To: Sasikumar Chandrasekaran
Cc: jejb, hch, linux-scsi, Sathya.Prakash, linux-kernel,
christopher.owens, kiran-kumar.kasturi, thenzl
This seems to be missing the pci_alloc_irq_vectors conversion from
Hannes?
^ permalink raw reply [flat|nested] 40+ messages in thread* RE: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next
2016-12-07 7:31 ` [PATCH V4 00/11] megaraid_sas: Updates for scsi-next Christoph Hellwig
@ 2016-12-11 14:04 ` Sasikumar PC
0 siblings, 0 replies; 40+ messages in thread
From: Sasikumar PC @ 2016-12-11 14:04 UTC (permalink / raw)
To: Christoph Hellwig
Cc: jejb, linux-scsi, Sathya Prakash Veerichetty, linux-kernel,
Christopher Owens, Kiran Kumar Kasturi, thenzl
Hi Chris,
I will be rebasing to include " pci_alloc_irq_vectors conversion from
Hannes" in the next version of the patch
Thanks
sasi
-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Wednesday, December 07, 2016 2:31 AM
To: Sasikumar Chandrasekaran
Cc: jejb@kernel.org; hch@infradead.org; linux-scsi@vger.kernel.org;
Sathya.Prakash@broadcom.com; linux-kernel@vger.kernel.org;
christopher.owens@broadcom.com; kiran-kumar.kasturi@broadcom.com;
thenzl@redhat.com
Subject: Re: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next
This seems to be missing the pci_alloc_irq_vectors conversion from Hannes?
^ permalink raw reply [flat|nested] 40+ messages in thread