* [PATCH] Documentation: ti-syscon-reset: fix header path
@ 2016-12-09 10:11 yegorslists
2016-12-12 18:40 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: yegorslists @ 2016-12-09 10:11 UTC (permalink / raw)
To: linux-kernel; +Cc: p.zabel, robh+dt, devicetree, mark.rutland, Yegor Yefremov
From: Yegor Yefremov <yegorslists@googlemail.com>
'include' was missing from path.
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
index 164c7f3..5b20e20 100644
--- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
+++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
@@ -44,7 +44,7 @@ Required properties:
reset status register
Cell #7 : Flags used to control reset behavior,
availible flags defined in the DT include
- file <dt-bindings/reset/ti-syscon.h>
+ file <include/dt-bindings/reset/ti-syscon.h>
SysCon Reset Consumer Nodes
===========================
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: ti-syscon-reset: fix header path
2016-12-09 10:11 [PATCH] Documentation: ti-syscon-reset: fix header path yegorslists
@ 2016-12-12 18:40 ` Rob Herring
2016-12-12 19:52 ` Yegor Yefremov
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2016-12-12 18:40 UTC (permalink / raw)
To: yegorslists; +Cc: linux-kernel, p.zabel, devicetree, mark.rutland
On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> 'include' was missing from path.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> index 164c7f3..5b20e20 100644
> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> @@ -44,7 +44,7 @@ Required properties:
> reset status register
> Cell #7 : Flags used to control reset behavior,
> availible flags defined in the DT include
> - file <dt-bindings/reset/ti-syscon.h>
> + file <include/dt-bindings/reset/ti-syscon.h>
There's pretty much equal mixture of include or not. Not really much
point in fixing 1 instance if there's no clear correct way. Given it is
written with <...>, that matches how you write the include statement.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: ti-syscon-reset: fix header path
2016-12-12 18:40 ` Rob Herring
@ 2016-12-12 19:52 ` Yegor Yefremov
0 siblings, 0 replies; 3+ messages in thread
From: Yegor Yefremov @ 2016-12-12 19:52 UTC (permalink / raw)
To: Rob Herring; +Cc: kernel list, p.zabel, devicetree, mark.rutland
On Mon, Dec 12, 2016 at 7:40 PM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> 'include' was missing from path.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> index 164c7f3..5b20e20 100644
>> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> @@ -44,7 +44,7 @@ Required properties:
>> reset status register
>> Cell #7 : Flags used to control reset behavior,
>> availible flags defined in the DT include
>> - file <dt-bindings/reset/ti-syscon.h>
>> + file <include/dt-bindings/reset/ti-syscon.h>
>
> There's pretty much equal mixture of include or not. Not really much
> point in fixing 1 instance if there's no clear correct way. Given it is
> written with <...>, that matches how you write the include statement.
OK I see the point of omitting include now. I was looking at this from
VIM point of view. I cannot automatically jump to the file via 'gf'.
Yegor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-12 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-09 10:11 [PATCH] Documentation: ti-syscon-reset: fix header path yegorslists
2016-12-12 18:40 ` Rob Herring
2016-12-12 19:52 ` Yegor Yefremov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).