linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	James Smart <james.smart@broadcom.com>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] nvme-fabrics: correct some printk information
Date: Sat, 10 Dec 2016 03:27:50 -0800	[thread overview]
Message-ID: <1481369270.5946.51.camel@perches.com> (raw)
In-Reply-To: <20161210090618.GA11680@elgon.mountain>

On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> We really don't care where "ctrl" is on the stack since we're just
> returning soon what we want is the actual ctrl pointer itself.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
[]
> @@ -2402,7 +2402,7 @@ enum blk_eh_timer_return
>  
>  	dev_info(ctrl->ctrl.device,
>  		"NVME-FC{%d}: new ctrl: NQN \"%s\" (%p)\n",
> -		ctrl->cnum, ctrl->ctrl.opts->subsysnqn, &ctrl);
> +		ctrl->cnum, ctrl->ctrl.opts->subsysnqn, ctrl);

Found by script or inspection?

If by script, it seems unlikely there's only 1 instance
where an address of an automatic pointer type is used
incorrectly.

  reply	other threads:[~2016-12-10 11:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10  9:06 [patch] nvme-fabrics: correct some printk information Dan Carpenter
2016-12-10 11:27 ` Joe Perches [this message]
2016-12-10 18:55   ` Dan Carpenter
2016-12-10 20:06     ` Julia Lawall
2016-12-10 20:24       ` Dan Carpenter
2016-12-10 20:54       ` Joe Perches
2016-12-10 21:07         ` Dan Carpenter
2016-12-10 22:24           ` Joe Perches
2016-12-12  9:33             ` Dan Carpenter
2016-12-12 15:47               ` Julia Lawall
2016-12-12 15:55                 ` Joe Perches
2016-12-10 22:07         ` Julia Lawall
2016-12-10 22:27           ` Joe Perches
2016-12-11  0:36       ` Joe Perches
2016-12-20  0:40 ` James Smart
2016-12-20  9:16   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481369270.5946.51.camel@perches.com \
    --to=joe@perches.com \
    --cc=axboe@fb.com \
    --cc=dan.carpenter@oracle.com \
    --cc=james.smart@broadcom.com \
    --cc=keith.busch@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).