From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Smart <james.smart@broadcom.com>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] nvme-fabrics: correct some printk information
Date: Mon, 12 Dec 2016 07:55:30 -0800 [thread overview]
Message-ID: <1481558130.1764.21.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1612121646460.3156@hadrien>
On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote:
>
> On Mon, 12 Dec 2016, Dan Carpenter wrote:
>
> > On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> > > On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > > > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > > > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > > > > --- drivers//dma/pxa_dma.c
> > > > > +++ /tmp/nothing//dma/pxa_dma.c
> > > > > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc
> > > > > dcsr = phy_readl_relaxed(phy, DCSR);
> > > > > phy_writel(phy, dcsr, DCSR);
> > > > > if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))
> > > > > - dev_warn(&phy->vchan->vc.chan.dev->device,
> > > > > - "%s(chan=%p): PXA_DCSR_BUSERR\n",
> > > > > - __func__, &phy->vchan);
> > > >
> > > > That's not a defect. We're getting the address of vchan. I don't get
> > > > it?
> > >
> > > $ git grep -n -w vchan drivers/dma/pxa*
> > > drivers/dma/pxa_dma.c:103: struct pxad_chan *vchan;
> >
> > I'm not sure what you're saying here still. This code works as
> > intended. We're not printing a stack address.
>
> I guess that the point is that one would like to print the channel, not
> the address of the channel?
Generally, printing the address of a pointer
_can_ be useful, but it's likely a defect with
a low false positive rate.
next prev parent reply other threads:[~2016-12-12 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 9:06 [patch] nvme-fabrics: correct some printk information Dan Carpenter
2016-12-10 11:27 ` Joe Perches
2016-12-10 18:55 ` Dan Carpenter
2016-12-10 20:06 ` Julia Lawall
2016-12-10 20:24 ` Dan Carpenter
2016-12-10 20:54 ` Joe Perches
2016-12-10 21:07 ` Dan Carpenter
2016-12-10 22:24 ` Joe Perches
2016-12-12 9:33 ` Dan Carpenter
2016-12-12 15:47 ` Julia Lawall
2016-12-12 15:55 ` Joe Perches [this message]
2016-12-10 22:07 ` Julia Lawall
2016-12-10 22:27 ` Joe Perches
2016-12-11 0:36 ` Joe Perches
2016-12-20 0:40 ` James Smart
2016-12-20 9:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481558130.1764.21.camel@perches.com \
--to=joe@perches.com \
--cc=axboe@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=james.smart@broadcom.com \
--cc=julia.lawall@lip6.fr \
--cc=keith.busch@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).