* [PATCH 1/2] crypto: asymmetric_keys: set error code on failure
@ 2016-12-12 16:16 David Howells
2016-12-12 21:53 ` James Morris
0 siblings, 1 reply; 5+ messages in thread
From: David Howells @ 2016-12-12 16:16 UTC (permalink / raw)
To: jmorris; +Cc: dhowells, Pan Bian, keyrings, linux-kernel, linux-kernel-module
From: Pan Bian <bianpan2016@163.com>
In function public_key_verify_signature(), returns variable ret on
error paths. When the call to kmalloc() fails, the value of ret is 0,
and it is not set to an errno before returning. This patch fixes the
bug.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
crypto/asymmetric_keys/public_key.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index fd76b5fc3b3a..d3a989e718f5 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
if (ret)
goto error_free_req;
+ ret = -ENOMEM;
outlen = crypto_akcipher_maxsize(tfm);
output = kmalloc(outlen, GFP_KERNEL);
if (!output)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure
2016-12-12 16:16 [PATCH 1/2] crypto: asymmetric_keys: set error code on failure David Howells
@ 2016-12-12 21:53 ` James Morris
2016-12-13 3:45 ` Herbert Xu
0 siblings, 1 reply; 5+ messages in thread
From: James Morris @ 2016-12-12 21:53 UTC (permalink / raw)
To: David Howells
Cc: Pan Bian, keyrings, linux-kernel, linux-kernel-module, Herbert Xu
On Mon, 12 Dec 2016, David Howells wrote:
> From: Pan Bian <bianpan2016@163.com>
>
> In function public_key_verify_signature(), returns variable ret on
> error paths. When the call to kmalloc() fails, the value of ret is 0,
> and it is not set to an errno before returning. This patch fixes the
> bug.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
These crypto patches should probably go via Herbert's tree.
>
> crypto/asymmetric_keys/public_key.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
> index fd76b5fc3b3a..d3a989e718f5 100644
> --- a/crypto/asymmetric_keys/public_key.c
> +++ b/crypto/asymmetric_keys/public_key.c
> @@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
> if (ret)
> goto error_free_req;
>
> + ret = -ENOMEM;
> outlen = crypto_akcipher_maxsize(tfm);
> output = kmalloc(outlen, GFP_KERNEL);
> if (!output)
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure
2016-12-12 21:53 ` James Morris
@ 2016-12-13 3:45 ` Herbert Xu
0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2016-12-13 3:45 UTC (permalink / raw)
To: James Morris
Cc: David Howells, Pan Bian, keyrings, linux-kernel, linux-kernel-module
On Tue, Dec 13, 2016 at 08:53:11AM +1100, James Morris wrote:
> On Mon, 12 Dec 2016, David Howells wrote:
>
> > From: Pan Bian <bianpan2016@163.com>
> >
> > In function public_key_verify_signature(), returns variable ret on
> > error paths. When the call to kmalloc() fails, the value of ret is 0,
> > and it is not set to an errno before returning. This patch fixes the
> > bug.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
> >
> > Signed-off-by: Pan Bian <bianpan2016@163.com>
> > Signed-off-by: David Howells <dhowells@redhat.com>
> > ---
>
> These crypto patches should probably go via Herbert's tree.
OK but someone will need to post them to linux-crypto first.
I know the originals went that way but David's repost doesn't
seem to be in patchwork.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure
2016-12-13 9:26 David Howells
@ 2016-12-14 10:38 ` Herbert Xu
0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2016-12-14 10:38 UTC (permalink / raw)
To: David Howells; +Cc: Pan Bian, keyrings, linux-crypto, linux-kernel
On Tue, Dec 13, 2016 at 09:26:18AM +0000, David Howells wrote:
> From: Pan Bian <bianpan2016@163.com>
>
> In function public_key_verify_signature(), returns variable ret on
> error paths. When the call to kmalloc() fails, the value of ret is 0,
> and it is not set to an errno before returning. This patch fixes the
> bug.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
Both patches applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] crypto: asymmetric_keys: set error code on failure
@ 2016-12-13 9:26 David Howells
2016-12-14 10:38 ` Herbert Xu
0 siblings, 1 reply; 5+ messages in thread
From: David Howells @ 2016-12-13 9:26 UTC (permalink / raw)
To: herbert; +Cc: dhowells, Pan Bian, keyrings, linux-crypto, linux-kernel
From: Pan Bian <bianpan2016@163.com>
In function public_key_verify_signature(), returns variable ret on
error paths. When the call to kmalloc() fails, the value of ret is 0,
and it is not set to an errno before returning. This patch fixes the
bug.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
crypto/asymmetric_keys/public_key.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index fd76b5fc3b3a..d3a989e718f5 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
if (ret)
goto error_free_req;
+ ret = -ENOMEM;
outlen = crypto_akcipher_maxsize(tfm);
output = kmalloc(outlen, GFP_KERNEL);
if (!output)
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-14 10:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-12 16:16 [PATCH 1/2] crypto: asymmetric_keys: set error code on failure David Howells
2016-12-12 21:53 ` James Morris
2016-12-13 3:45 ` Herbert Xu
2016-12-13 9:26 David Howells
2016-12-14 10:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).