* [Patch] 9p: fix a potential acl leak
@ 2016-12-13 18:33 Cong Wang
2016-12-14 8:57 ` [V9fs-developer] " Greg Kurz
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2016-12-13 18:33 UTC (permalink / raw)
To: linux-kernel
Cc: v9fs-developer, salyzyn, jack, Cong Wang, Eric Van Hensbergen,
Ron Minnich, Latchesar Ionkov
posix_acl_update_mode() could possibly clear 'acl', if so
we leak the memory pointed by 'acl'. Save this pointer
before calling posix_acl_update_mode() and release the memory
if 'acl' really gets cleared.
Reported-by: Mark Salyzyn <salyzyn@android.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
fs/9p/acl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index b3c2cc7..082d227 100644
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
case ACL_TYPE_ACCESS:
if (acl) {
struct iattr iattr;
+ struct posix_acl *old_acl = acl;
retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);
if (retval)
@@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
* by the mode bits. So don't
* update ACL.
*/
+ posix_acl_release(old_acl);
value = NULL;
size = 0;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [V9fs-developer] [Patch] 9p: fix a potential acl leak
2016-12-13 18:33 [Patch] 9p: fix a potential acl leak Cong Wang
@ 2016-12-14 8:57 ` Greg Kurz
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kurz @ 2016-12-14 8:57 UTC (permalink / raw)
To: Cong Wang
Cc: linux-kernel, Latchesar Ionkov, Ron Minnich, jack,
Eric Van Hensbergen, salyzyn, v9fs-developer
On Tue, 13 Dec 2016 10:33:34 -0800
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> posix_acl_update_mode() could possibly clear 'acl', if so
> we leak the memory pointed by 'acl'. Save this pointer
> before calling posix_acl_update_mode() and release the memory
> if 'acl' really gets cleared.
>
> Reported-by: Mark Salyzyn <salyzyn@android.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Cc: Eric Van Hensbergen <ericvh@gmail.com>
> Cc: Ron Minnich <rminnich@sandia.gov>
> Cc: Latchesar Ionkov <lucho@ionkov.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> fs/9p/acl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/9p/acl.c b/fs/9p/acl.c
> index b3c2cc7..082d227 100644
> --- a/fs/9p/acl.c
> +++ b/fs/9p/acl.c
> @@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
> case ACL_TYPE_ACCESS:
> if (acl) {
> struct iattr iattr;
> + struct posix_acl *old_acl = acl;
>
> retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);
> if (retval)
> @@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
> * by the mode bits. So don't
> * update ACL.
> */
> + posix_acl_release(old_acl);
> value = NULL;
> size = 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-14 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-13 18:33 [Patch] 9p: fix a potential acl leak Cong Wang
2016-12-14 8:57 ` [V9fs-developer] " Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).