linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: fix typos in ooblayout comment blocks
@ 2016-12-14  0:31 Masahiro Yamada
  2016-12-14  7:06 ` Boris Brezillon
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2016-12-14  0:31 UTC (permalink / raw)
  To: linux-mtd
  Cc: Masahiro Yamada, linux-kernel, Boris Brezillon, Marek Vasut,
	Brian Norris, Richard Weinberger, David Woodhouse,
	Cyrille Pitchen

 - "This functions return ..." -> "This function returns ..."
 - "I you want ..." -> "If you want ..."

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/mtd/mtdcore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index ca661ce..d64e61b 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -1129,7 +1129,7 @@ EXPORT_SYMBOL_GPL(mtd_write_oob);
  * @oobecc: OOB region struct filled with the appropriate ECC position
  *	    information
  *
- * This functions return ECC section information in the OOB area. I you want
+ * This function returns ECC section information in the OOB area. If you want
  * to get all the ECC bytes information, then you should call
  * mtd_ooblayout_ecc(mtd, section++, oobecc) until it returns -ERANGE.
  *
@@ -1161,7 +1161,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_ecc);
  * @oobfree: OOB region struct filled with the appropriate free position
  *	     information
  *
- * This functions return free bytes position in the OOB area. I you want
+ * This function returns free bytes position in the OOB area. If you want
  * to get all the free bytes information, then you should call
  * mtd_ooblayout_free(mtd, section++, oobfree) until it returns -ERANGE.
  *
@@ -1191,7 +1191,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_free);
  * @iter: iterator function. Should be either mtd_ooblayout_free or
  *	  mtd_ooblayout_ecc depending on the region type you're searching for
  *
- * This functions returns the section id and oobregion information of a
+ * This function returns the section id and oobregion information of a
  * specific byte. For example, say you want to know where the 4th ECC byte is
  * stored, you'll use:
  *
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: fix typos in ooblayout comment blocks
  2016-12-14  0:31 [PATCH] mtd: fix typos in ooblayout comment blocks Masahiro Yamada
@ 2016-12-14  7:06 ` Boris Brezillon
  2017-02-07  4:58   ` Masahiro Yamada
  0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2016-12-14  7:06 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-mtd, Marek Vasut, Richard Weinberger, linux-kernel,
	Cyrille Pitchen, Brian Norris, David Woodhouse

On Wed, 14 Dec 2016 09:31:01 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

>  - "This functions return ..." -> "This function returns ..."
>  - "I you want ..." -> "If you want ..."
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> 
>  drivers/mtd/mtdcore.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index ca661ce..d64e61b 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1129,7 +1129,7 @@ EXPORT_SYMBOL_GPL(mtd_write_oob);
>   * @oobecc: OOB region struct filled with the appropriate ECC position
>   *	    information
>   *
> - * This functions return ECC section information in the OOB area. I you want
> + * This function returns ECC section information in the OOB area. If you want
>   * to get all the ECC bytes information, then you should call
>   * mtd_ooblayout_ecc(mtd, section++, oobecc) until it returns -ERANGE.
>   *
> @@ -1161,7 +1161,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_ecc);
>   * @oobfree: OOB region struct filled with the appropriate free position
>   *	     information
>   *
> - * This functions return free bytes position in the OOB area. I you want
> + * This function returns free bytes position in the OOB area. If you want
>   * to get all the free bytes information, then you should call
>   * mtd_ooblayout_free(mtd, section++, oobfree) until it returns -ERANGE.
>   *
> @@ -1191,7 +1191,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_free);
>   * @iter: iterator function. Should be either mtd_ooblayout_free or
>   *	  mtd_ooblayout_ecc depending on the region type you're searching for
>   *
> - * This functions returns the section id and oobregion information of a
> + * This function returns the section id and oobregion information of a
>   * specific byte. For example, say you want to know where the 4th ECC byte is
>   * stored, you'll use:
>   *

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: fix typos in ooblayout comment blocks
  2016-12-14  7:06 ` Boris Brezillon
@ 2017-02-07  4:58   ` Masahiro Yamada
  2017-02-08 21:32     ` Brian Norris
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2017-02-07  4:58 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: linux-mtd, Marek Vasut, Richard Weinberger,
	Linux Kernel Mailing List, Cyrille Pitchen, Brian Norris,
	David Woodhouse

Hi Boris,

2016-12-14 16:06 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> On Wed, 14 Dec 2016 09:31:01 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
>>  - "This functions return ..." -> "This function returns ..."
>>  - "I you want ..." -> "If you want ..."
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>


Is this patch applicable?



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: fix typos in ooblayout comment blocks
  2017-02-07  4:58   ` Masahiro Yamada
@ 2017-02-08 21:32     ` Brian Norris
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2017-02-08 21:32 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Boris Brezillon, linux-mtd, Marek Vasut, Richard Weinberger,
	Linux Kernel Mailing List, Cyrille Pitchen, David Woodhouse

On Tue, Feb 07, 2017 at 01:58:03PM +0900, Masahiro Yamada wrote:
> 2016-12-14 16:06 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> > On Wed, 14 Dec 2016 09:31:01 +0900
> > Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> >
> >>  - "This functions return ..." -> "This function returns ..."
> >>  - "I you want ..." -> "If you want ..."
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> 
> Is this patch applicable?

Sure. Applied to l2-mtd.git.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-08 21:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14  0:31 [PATCH] mtd: fix typos in ooblayout comment blocks Masahiro Yamada
2016-12-14  7:06 ` Boris Brezillon
2017-02-07  4:58   ` Masahiro Yamada
2017-02-08 21:32     ` Brian Norris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).