* [PATCH] usb: storage: ene_ub6250: remove unused variable
@ 2016-12-18 22:34 Sudip Mukherjee
2017-01-05 18:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2016-12-18 22:34 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: linux-kernel, linux-usb, usb-storage, Sudip Mukherjee
The variable Newblk was only being assigned some value but was never
used after that.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/usb/storage/ene_ub6250.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 02bdaa9..369f3c2 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -1364,7 +1364,6 @@ static int ms_lib_read_extra(struct us_data *us, u32 PhyBlock,
static int ms_libsearch_block_from_physical(struct us_data *us, u16 phyblk)
{
- u16 Newblk;
u16 blk;
struct ms_lib_type_extdat extdat; /* need check */
struct ene_ub6250_info *info = (struct ene_ub6250_info *) us->extra;
@@ -1377,7 +1376,6 @@ static int ms_libsearch_block_from_physical(struct us_data *us, u16 phyblk)
if ((blk & MS_PHYSICAL_BLOCKS_PER_SEGMENT_MASK) == 0)
blk -= MS_PHYSICAL_BLOCKS_PER_SEGMENT;
- Newblk = info->MS_Lib.Phy2LogMap[blk];
if (info->MS_Lib.Phy2LogMap[blk] == MS_LB_NOT_USED_ERASED) {
return blk;
} else if (info->MS_Lib.Phy2LogMap[blk] == MS_LB_NOT_USED) {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: storage: ene_ub6250: remove unused variable
2016-12-18 22:34 [PATCH] usb: storage: ene_ub6250: remove unused variable Sudip Mukherjee
@ 2017-01-05 18:36 ` Greg Kroah-Hartman
2017-01-07 23:28 ` Sudip Mukherjee
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-01-05 18:36 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Alan Stern, linux-kernel, linux-usb, usb-storage
On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> The variable Newblk was only being assigned some value but was never
> used after that.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/usb/storage/ene_ub6250.c | 2 --
> 1 file changed, 2 deletions(-)
from and signed-off-by does not match :(
Same with your other usb patch...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: storage: ene_ub6250: remove unused variable
2017-01-05 18:36 ` Greg Kroah-Hartman
@ 2017-01-07 23:28 ` Sudip Mukherjee
2017-01-08 11:31 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2017-01-07 23:28 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Alan Stern, linux-kernel, linux-usb, usb-storage
On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
>> The variable Newblk was only being assigned some value but was never
>> used after that.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>> drivers/usb/storage/ene_ub6250.c | 2 --
>> 1 file changed, 2 deletions(-)
>
> from and signed-off-by does not match :(
>
> Same with your other usb patch...
>
I can add the From: tag in the patch. But this is from the last time we
had this same conversation.
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html
Regards
Sudip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: storage: ene_ub6250: remove unused variable
2017-01-07 23:28 ` Sudip Mukherjee
@ 2017-01-08 11:31 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-01-08 11:31 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Alan Stern, linux-kernel, linux-usb, usb-storage
On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote:
> On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> > > The variable Newblk was only being assigned some value but was never
> > > used after that.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > > ---
> > > drivers/usb/storage/ene_ub6250.c | 2 --
> > > 1 file changed, 2 deletions(-)
> >
> > from and signed-off-by does not match :(
> >
> > Same with your other usb patch...
> >
>
> I can add the From: tag in the patch. But this is from the last time we had
> this same conversation.
>
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html
I can't remember an email thread from last week, or even yesterday, let
alone from almost a year ago.
I suggest you fix your email server so we don't have the same
conversation next week, or use the From: line in the patch which is what
I am expecting people to do for crappy email servers like this. :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-08 11:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-18 22:34 [PATCH] usb: storage: ene_ub6250: remove unused variable Sudip Mukherjee
2017-01-05 18:36 ` Greg Kroah-Hartman
2017-01-07 23:28 ` Sudip Mukherjee
2017-01-08 11:31 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).