* [PATCH] staging: comedi: ni_670x: using the BIT(x) macro
@ 2017-01-03 14:55 Saber Rezvani
0 siblings, 0 replies; 3+ messages in thread
From: Saber Rezvani @ 2017-01-03 14:55 UTC (permalink / raw)
To: greg; +Cc: devel, linux-kernel, abbotti, Saber Rezvani
Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro
replacing bit shifting on 1 with the BIT(x) macro.
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
drivers/staging/comedi/drivers/ni_670x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
index 74911db..1d3ff60 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -141,7 +141,7 @@ static int ni_670x_dio_insn_config(struct comedi_device *dev,
/* ripped from mite.h and mite_setup2() to avoid mite dependency */
#define MITE_IODWBSR 0xc0 /* IO Device Window Base Size Register */
-#define WENAB (1 << 7) /* window enable */
+#define WENAB BIT(7) /* window enable */
static int ni_670x_mite_init(struct pci_dev *pcidev)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: comedi: ni_670x: using the BIT(x) macro
2016-12-16 20:20 Saber Rezvani
@ 2016-12-19 17:42 ` Ian Abbott
0 siblings, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2016-12-19 17:42 UTC (permalink / raw)
To: Saber Rezvani; +Cc: gregkh, devel, linux-kernel
On 16/12/2016 20:20, Saber Rezvani wrote:
> Fix the checkpatch.pl issue:
> CHECK: Prefer using the BIT macro
> replacing bit shifting on 1 with the BIT(x) macro.
>
> Signed-off-by: Saber Rezvani <irsaber@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_670x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: comedi: ni_670x: using the BIT(x) macro
@ 2016-12-16 20:20 Saber Rezvani
2016-12-19 17:42 ` Ian Abbott
0 siblings, 1 reply; 3+ messages in thread
From: Saber Rezvani @ 2016-12-16 20:20 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, abbotti, Saber Rezvani
Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro
replacing bit shifting on 1 with the BIT(x) macro.
Signed-off-by: Saber Rezvani <irsaber@gmail.com>
---
drivers/staging/comedi/drivers/ni_670x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
index 74911db..1d3ff60 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -141,7 +141,7 @@ static int ni_670x_dio_insn_config(struct comedi_device *dev,
/* ripped from mite.h and mite_setup2() to avoid mite dependency */
#define MITE_IODWBSR 0xc0 /* IO Device Window Base Size Register */
-#define WENAB (1 << 7) /* window enable */
+#define WENAB BIT(7) /* window enable */
static int ni_670x_mite_init(struct pci_dev *pcidev)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-03 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-03 14:55 [PATCH] staging: comedi: ni_670x: using the BIT(x) macro Saber Rezvani
-- strict thread matches above, loose matches on Subject: below --
2016-12-16 20:20 Saber Rezvani
2016-12-19 17:42 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).