* [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
2017-01-04 8:57 [PATCH 0/3] QorIQ TMU bindings and device tree update Jia Hongtao
@ 2017-01-04 8:57 ` Jia Hongtao
2017-01-04 10:37 ` Scott Wood
2017-01-04 8:57 ` [PATCH 2/3] powerpc/mpc85xx: Update TMU device tree node for T1040/T1042 Jia Hongtao
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Jia Hongtao @ 2017-01-04 8:57 UTC (permalink / raw)
To: oss, rui.zhang, edubezval, yuantian.tang, robh+dt
Cc: linux-pm, devicetree, linux-kernel, hongtao.jia
For different types of SoC the sensor id and endianness may vary.
"#thermal-sensor-cells" is used to provide sensor id information.
"little-endian" property is to tell the endianness of TMU.
Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
index 66223d5..20ca4ef 100644
--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
@@ -17,6 +17,12 @@ Required properties:
calibration data, as specified by the SoC reference manual.
The first cell of each pair is the value to be written to TTCFGR,
and the second is the value to be written to TSCFGR.
+- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
+ site ID, and represents the "n" in TRITSRn and TRATSRn.
+
+Optional property:
+- little-endian : If present, the TMU registers are little endian. If absent,
+ the default is big endian.
Example:
@@ -60,4 +66,5 @@ tmu@f0000 {
0x00030000 0x00000012
0x00030001 0x0000001d>;
+ #thermal-sensor-cells = <1>;
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
2017-01-04 8:57 ` [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
@ 2017-01-04 10:37 ` Scott Wood
2017-01-05 2:28 ` Troy Jia
0 siblings, 1 reply; 8+ messages in thread
From: Scott Wood @ 2017-01-04 10:37 UTC (permalink / raw)
To: Jia Hongtao, rui.zhang, edubezval, yuantian.tang, robh+dt
Cc: linux-pm, devicetree, linux-kernel
On Wed, 2017-01-04 at 16:57 +0800, Jia Hongtao wrote:
> For different types of SoC the sensor id and endianness may vary.
> "#thermal-sensor-cells" is used to provide sensor id information.
> "little-endian" property is to tell the endianness of TMU.
>
> Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> index 66223d5..20ca4ef 100644
> --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> @@ -17,6 +17,12 @@ Required properties:
> calibration data, as specified by the SoC reference manual.
> The first cell of each pair is the value to be written to TTCFGR,
> and the second is the value to be written to TSCFGR.
> +- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
> + site ID, and represents the "n" in TRITSRn and TRATSRn.
I assume the driver will continue to work with existing device trees where
this information is absent? If so, ACK for the whole series.
-Scott
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
2017-01-04 10:37 ` Scott Wood
@ 2017-01-05 2:28 ` Troy Jia
2017-01-06 6:56 ` Y.T. Tang
0 siblings, 1 reply; 8+ messages in thread
From: Troy Jia @ 2017-01-05 2:28 UTC (permalink / raw)
To: Scott Wood, rui.zhang, edubezval, Y.T. Tang, robh+dt
Cc: linux-pm, devicetree, linux-kernel
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Wednesday, January 04, 2017 6:38 PM
> To: Troy Jia <hongtao.jia@nxp.com>; rui.zhang@intel.com; edubezval@gmail.com;
> Y.T. Tang <yuantian.tang@nxp.com>; robh+dt@kernel.org
> Cc: linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
>
> On Wed, 2017-01-04 at 16:57 +0800, Jia Hongtao wrote:
> > For different types of SoC the sensor id and endianness may vary.
> > "#thermal-sensor-cells" is used to provide sensor id information.
> > "little-endian" property is to tell the endianness of TMU.
> >
> > Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7
> > +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > index 66223d5..20ca4ef 100644
> > --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > @@ -17,6 +17,12 @@ Required properties:
> > calibration data, as specified by the SoC reference manual.
> > The first cell of each pair is the value to be written to TTCFGR,
> > and the second is the value to be written to TSCFGR.
> > +- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
> > + site ID, and represents the "n" in TRITSRn and TRATSRn.
>
> I assume the driver will continue to work with existing device trees where this
> information is absent? If so, ACK for the whole series.
Yes. The driver works for all existing device trees.
Thanks for the ACK.
>
> -Scott
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
2017-01-05 2:28 ` Troy Jia
@ 2017-01-06 6:56 ` Y.T. Tang
0 siblings, 0 replies; 8+ messages in thread
From: Y.T. Tang @ 2017-01-06 6:56 UTC (permalink / raw)
To: Troy Jia, Scott Wood, rui.zhang, edubezval, robh+dt
Cc: linux-pm, devicetree, linux-kernel
Seems like Troy's email client has issues which causes his reply is unreadable in patchwork.
Please ignore it in patchwork.
Regards,
Yuantian
> -----Original Message-----
> From: Troy Jia
> Sent: Thursday, January 05, 2017 10:29 AM
> To: Scott Wood <oss@buserror.net>; rui.zhang@intel.com;
> edubezval@gmail.com; Y.T. Tang <yuantian.tang@nxp.com>;
> robh+dt@kernel.org
> Cc: linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
>
>
>
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Wednesday, January 04, 2017 6:38 PM
> > To: Troy Jia <hongtao.jia@nxp.com>; rui.zhang@intel.com;
> > edubezval@gmail.com; Y.T. Tang <yuantian.tang@nxp.com>;
> > robh+dt@kernel.org
> > Cc: linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal
> > bindings
> >
> > On Wed, 2017-01-04 at 16:57 +0800, Jia Hongtao wrote:
> > > For different types of SoC the sensor id and endianness may vary.
> > > "#thermal-sensor-cells" is used to provide sensor id information.
> > > "little-endian" property is to tell the endianness of TMU.
> > >
> > > Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > ---
> > > Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7
> > > +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > > b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > > index 66223d5..20ca4ef 100644
> > > --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > > +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > > @@ -17,6 +17,12 @@ Required properties:
> > > calibration data, as specified by the SoC reference manual.
> > > The first cell of each pair is the value to be written to TTCFGR,
> > > and the second is the value to be written to TSCFGR.
> > > +- #thermal-sensor-cells : Must be 1. The sensor specifier is the
> monitoring
> > > + site ID, and represents the "n" in TRITSRn and TRATSRn.
> >
> > I assume the driver will continue to work with existing device trees
> > where this information is absent? If so, ACK for the whole series.
>
> Yes. The driver works for all existing device trees.
>
> Thanks for the ACK.
>
> >
> > -Scott
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] powerpc/mpc85xx: Update TMU device tree node for T1040/T1042
2017-01-04 8:57 [PATCH 0/3] QorIQ TMU bindings and device tree update Jia Hongtao
2017-01-04 8:57 ` [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
@ 2017-01-04 8:57 ` Jia Hongtao
2017-01-04 8:57 ` [PATCH 3/3] powerpc/mpc85xx: Update TMU device tree node for T1023/T1024 Jia Hongtao
2017-01-04 9:19 ` [PATCH 0/3] QorIQ TMU bindings and device tree update Y.T. Tang
3 siblings, 0 replies; 8+ messages in thread
From: Jia Hongtao @ 2017-01-04 8:57 UTC (permalink / raw)
To: oss, rui.zhang, edubezval, yuantian.tang, robh+dt
Cc: linux-pm, devicetree, linux-kernel, hongtao.jia
From: Hongtao Jia <hongtao.jia@nxp.com>
Update #thermal-sensor-cells from 0 to 1 according to the new binding. The
sensor specifier added is the monitoring site ID, and represents the "n" in
TRITSRn and TRATSRn.
Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
---
arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
index 44e399b..145c7f4 100644
--- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -526,7 +526,7 @@
0x00030000 0x00000012
0x00030001 0x0000001d>;
- #thermal-sensor-cells = <0>;
+ #thermal-sensor-cells = <1>;
};
thermal-zones {
@@ -534,7 +534,7 @@
polling-delay-passive = <1000>;
polling-delay = <5000>;
- thermal-sensors = <&tmu>;
+ thermal-sensors = <&tmu 2>;
trips {
cpu_alert: cpu-alert {
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/3] powerpc/mpc85xx: Update TMU device tree node for T1023/T1024
2017-01-04 8:57 [PATCH 0/3] QorIQ TMU bindings and device tree update Jia Hongtao
2017-01-04 8:57 ` [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
2017-01-04 8:57 ` [PATCH 2/3] powerpc/mpc85xx: Update TMU device tree node for T1040/T1042 Jia Hongtao
@ 2017-01-04 8:57 ` Jia Hongtao
2017-01-04 9:19 ` [PATCH 0/3] QorIQ TMU bindings and device tree update Y.T. Tang
3 siblings, 0 replies; 8+ messages in thread
From: Jia Hongtao @ 2017-01-04 8:57 UTC (permalink / raw)
To: oss, rui.zhang, edubezval, yuantian.tang, robh+dt
Cc: linux-pm, devicetree, linux-kernel, hongtao.jia
From: Hongtao Jia <hongtao.jia@nxp.com>
Update #thermal-sensor-cells from 0 to 1 according to the new binding. The
sensor specifier added is the monitoring site ID, and represents the "n" in
TRITSRn and TRATSRn.
Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
---
arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
index da2894c..4908af5 100644
--- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
@@ -422,7 +422,7 @@
0x00030001 0x0000000d
0x00030002 0x00000019
0x00030003 0x00000024>;
- #thermal-sensor-cells = <0>;
+ #thermal-sensor-cells = <1>;
};
thermal-zones {
@@ -430,7 +430,7 @@
polling-delay-passive = <1000>;
polling-delay = <5000>;
- thermal-sensors = <&tmu>;
+ thermal-sensors = <&tmu 0>;
trips {
cpu_alert: cpu-alert {
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 8+ messages in thread* RE: [PATCH 0/3] QorIQ TMU bindings and device tree update
2017-01-04 8:57 [PATCH 0/3] QorIQ TMU bindings and device tree update Jia Hongtao
` (2 preceding siblings ...)
2017-01-04 8:57 ` [PATCH 3/3] powerpc/mpc85xx: Update TMU device tree node for T1023/T1024 Jia Hongtao
@ 2017-01-04 9:19 ` Y.T. Tang
3 siblings, 0 replies; 8+ messages in thread
From: Y.T. Tang @ 2017-01-04 9:19 UTC (permalink / raw)
To: Troy Jia, oss, rui.zhang, edubezval, robh+dt, Scott Wood
Cc: linux-pm, devicetree, linux-kernel, Troy Jia
++Scott NXP email address.
Hi Scott,
Could you please give these patch set a little higher priority as Troy's last day is Friday?
We want those get ACKed or address all the major issues before Friday.
Thanks,
Yuantian
> -----Original Message-----
> From: Jia Hongtao [mailto:hongtao.jia@nxp.com]
> Sent: Wednesday, January 04, 2017 4:58 PM
> To: oss@buserror.net; rui.zhang@intel.com; edubezval@gmail.com; Y.T.
> Tang <yuantian.tang@nxp.com>; robh+dt@kernel.org
> Cc: linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Troy Jia <hongtao.jia@nxp.com>
> Subject: [PATCH 0/3] QorIQ TMU bindings and device tree update
>
> As Rui Zhang suggested I combine TMU binding patch and two device tree
> patchset together. He will take all of them after the device tree patchset got
> ACK.
>
> @Scott please help to review the device tree patchset.
> Thanks.
>
> Jia Hongtao (3):
> dt-bindings: Update QorIQ TMU thermal bindings
> powerpc/mpc85xx: Update TMU device tree node for T1040/T1042
> powerpc/mpc85xx: Update TMU device tree node for T1023/T1024
>
> Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7
> +++++++
> arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 4 ++--
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 4 ++--
> 3 files changed, 11 insertions(+), 4 deletions(-)
>
> --
> 2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 8+ messages in thread