* [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases
@ 2017-01-16 15:50 Javier Martinez Canillas
2017-01-16 15:50 ` [PATCH 2/3] iio: potentiometer: mcp4531: " Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-01-16 15:50 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-iio, Hartmut Knaack,
Gregor Boirie, Lars-Peter Clausen, Michael Hornung,
Jonathan Cameron, Peter Meerwald-Stadler, Alexander Koch
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/iio/light/opt3001.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
index 78c9b3a6453a..b91ebc3483ce 100644
--- a/drivers/iio/light/opt3001.c
+++ b/drivers/iio/light/opt3001.c
@@ -840,6 +840,7 @@ static const struct of_device_id opt3001_of_match[] = {
{ .compatible = "ti,opt3001" },
{ }
};
+MODULE_DEVICE_TABLE(of, opt3001_of_match);
static struct i2c_driver opt3001_driver = {
.probe = opt3001_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] iio: potentiometer: mcp4531: Export OF device ID table as module aliases
2017-01-16 15:50 [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases Javier Martinez Canillas
@ 2017-01-16 15:50 ` Javier Martinez Canillas
2017-01-21 14:22 ` Jonathan Cameron
2017-01-16 15:50 ` [PATCH 3/3] iio: adc: max1363: " Javier Martinez Canillas
2017-01-21 14:22 ` [PATCH 1/3] iio: light: opt3001: " Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-01-16 15:50 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-iio, Peter Meerwald-Stadler,
Lars-Peter Clausen, Peter Rosin, Jonathan Cameron,
Hartmut Knaack
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/iio/potentiometer/mcp4531.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/potentiometer/mcp4531.c b/drivers/iio/potentiometer/mcp4531.c
index 0d1bcf89ae17..314353d7ab59 100644
--- a/drivers/iio/potentiometer/mcp4531.c
+++ b/drivers/iio/potentiometer/mcp4531.c
@@ -284,6 +284,7 @@ static const struct of_device_id mcp4531_of_match[] = {
MCP4531_COMPATIBLE("microchip,mcp4662-104", MCP466x_104),
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, mcp4531_of_match);
#endif
static int mcp4531_probe(struct i2c_client *client,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] iio: adc: max1363: Export OF device ID table as module aliases
2017-01-16 15:50 [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases Javier Martinez Canillas
2017-01-16 15:50 ` [PATCH 2/3] iio: potentiometer: mcp4531: " Javier Martinez Canillas
@ 2017-01-16 15:50 ` Javier Martinez Canillas
2017-01-21 14:22 ` Jonathan Cameron
2017-01-21 14:22 ` [PATCH 1/3] iio: light: opt3001: " Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-01-16 15:50 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Matt Ranostay, linux-iio,
Hartmut Knaack, Gregor Boirie, Stefan Eichenberger,
Sanchayan Maity, Lars-Peter Clausen, Florian Vaussard,
Jonathan Cameron, Peter Meerwald-Stadler
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/iio/adc/max1363.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index 841a13c9b6ea..c6c12feb4a08 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -1567,6 +1567,7 @@ static const struct of_device_id max1363_of_match[] = {
MAX1363_COMPATIBLE("maxim,max11647", max11647),
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, max1363_of_match);
#endif
static int max1363_probe(struct i2c_client *client,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases
2017-01-16 15:50 [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases Javier Martinez Canillas
2017-01-16 15:50 ` [PATCH 2/3] iio: potentiometer: mcp4531: " Javier Martinez Canillas
2017-01-16 15:50 ` [PATCH 3/3] iio: adc: max1363: " Javier Martinez Canillas
@ 2017-01-21 14:22 ` Jonathan Cameron
2 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-01-21 14:22 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-iio, Hartmut Knaack, Gregor Boirie, Lars-Peter Clausen,
Michael Hornung, Peter Meerwald-Stadler, Alexander Koch
On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
>
> drivers/iio/light/opt3001.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
> index 78c9b3a6453a..b91ebc3483ce 100644
> --- a/drivers/iio/light/opt3001.c
> +++ b/drivers/iio/light/opt3001.c
> @@ -840,6 +840,7 @@ static const struct of_device_id opt3001_of_match[] = {
> { .compatible = "ti,opt3001" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, opt3001_of_match);
>
> static struct i2c_driver opt3001_driver = {
> .probe = opt3001_probe,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] iio: potentiometer: mcp4531: Export OF device ID table as module aliases
2017-01-16 15:50 ` [PATCH 2/3] iio: potentiometer: mcp4531: " Javier Martinez Canillas
@ 2017-01-21 14:22 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-01-21 14:22 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-iio, Peter Meerwald-Stadler, Lars-Peter Clausen,
Peter Rosin, Hartmut Knaack
On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied.
> ---
>
> drivers/iio/potentiometer/mcp4531.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/potentiometer/mcp4531.c b/drivers/iio/potentiometer/mcp4531.c
> index 0d1bcf89ae17..314353d7ab59 100644
> --- a/drivers/iio/potentiometer/mcp4531.c
> +++ b/drivers/iio/potentiometer/mcp4531.c
> @@ -284,6 +284,7 @@ static const struct of_device_id mcp4531_of_match[] = {
> MCP4531_COMPATIBLE("microchip,mcp4662-104", MCP466x_104),
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, mcp4531_of_match);
> #endif
>
> static int mcp4531_probe(struct i2c_client *client,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] iio: adc: max1363: Export OF device ID table as module aliases
2017-01-16 15:50 ` [PATCH 3/3] iio: adc: max1363: " Javier Martinez Canillas
@ 2017-01-21 14:22 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2017-01-21 14:22 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Matt Ranostay, linux-iio, Hartmut Knaack, Gregor Boirie,
Stefan Eichenberger, Sanchayan Maity, Lars-Peter Clausen,
Florian Vaussard, Peter Meerwald-Stadler
On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied.
Thanks,
Jonathan
> ---
>
> drivers/iio/adc/max1363.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index 841a13c9b6ea..c6c12feb4a08 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -1567,6 +1567,7 @@ static const struct of_device_id max1363_of_match[] = {
> MAX1363_COMPATIBLE("maxim,max11647", max11647),
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, max1363_of_match);
> #endif
>
> static int max1363_probe(struct i2c_client *client,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-21 14:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16 15:50 [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases Javier Martinez Canillas
2017-01-16 15:50 ` [PATCH 2/3] iio: potentiometer: mcp4531: " Javier Martinez Canillas
2017-01-21 14:22 ` Jonathan Cameron
2017-01-16 15:50 ` [PATCH 3/3] iio: adc: max1363: " Javier Martinez Canillas
2017-01-21 14:22 ` Jonathan Cameron
2017-01-21 14:22 ` [PATCH 1/3] iio: light: opt3001: " Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).