From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v5 2/4] device property: constify property arrays values
Date: Fri, 03 Feb 2017 13:43:03 +0200 [thread overview]
Message-ID: <1486122183.2133.373.camel@linux.intel.com> (raw)
In-Reply-To: <20170203014128.317-3-dmitry.torokhov@gmail.com>
On Thu, 2017-02-02 at 17:41 -0800, Dmitry Torokhov wrote:
> Data that is fed into property arrays should not be modified, so let's
> mark
> relevant pointers as const. This will allow us making source arrays as
> const/__initconst.
>
> @@ -718,7 +718,8 @@ static void pset_free_set(struct property_set
> *pset)
> static int pset_copy_entry(struct property_entry *dst,
> const struct property_entry *src)
> {
> - const char **d, **s;
> + const char * const *s;
> + char **d;
You removed const here
> size_t i, nval;
>
> dst->name = kstrdup(src->name, GFP_KERNEL);
> @@ -731,12 +732,11 @@ static int pset_copy_entry(struct property_entry
> *dst,
>
> if (src->is_string) {
> nval = src->length / sizeof(const char *);
> - dst->pointer.str = kcalloc(nval, sizeof(const
> char *),
> - GFP_KERNEL);
> - if (!dst->pointer.str)
> + d = kcalloc(nval, sizeof(const char *),
> GFP_KERNEL);
But left it here. Do we need to remove const?
> + if (!d)
> return -ENOMEM;
>
> - d = dst->pointer.str;
> + dst->pointer.raw_data = d;
> s = src->pointer.str;
So, overall, do we need these changes at all? Nothing in commit message
sheds a light on it.
> for (i = 0; i < nval; i++) {
> d[i] = kstrdup(s[i], GFP_KERNEL);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-02-03 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 1:41 [PATCH v5 0/4] Export APIs to copy device properties & more Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 1/4] device property: allow to constify properties Dmitry Torokhov
2017-02-03 11:40 ` Andy Shevchenko
2017-02-03 15:09 ` Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 2/4] device property: constify property arrays values Dmitry Torokhov
2017-02-03 11:43 ` Andy Shevchenko [this message]
2017-02-03 15:12 ` Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 3/4] device property: export code duplicating array of property entries Dmitry Torokhov
2017-02-03 11:45 ` Andy Shevchenko
2017-02-03 15:15 ` Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 4/4] i2c: allow specify device properties in i2c_board_info Dmitry Torokhov
2017-02-03 11:46 ` Andy Shevchenko
2017-02-07 12:44 ` Rafael J. Wysocki
2017-02-07 13:25 ` Wolfram Sang
2017-02-09 13:52 ` [PATCH v5 0/4] Export APIs to copy device properties & more Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486122183.2133.373.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).