* [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error
@ 2017-02-04 4:42 Youngdo Lee
2017-02-05 10:39 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Youngdo Lee @ 2017-02-04 4:42 UTC (permalink / raw)
To: gregkh, thomas.petazzoni, noralf; +Cc: devel, linux-kernel, Youngdo Lee
Fix checkpatch error:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Youngdo Lee <paul.ydlee@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index ec45043..3ce265d 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -10,6 +10,7 @@
*
*****************************************************************************/
+#define nop_modifier(expr) (expr)
#define define_fbtft_write_reg(func, type, modifier) \
void func(struct fbtft_par *par, int len, ...) \
{ \
@@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...) \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier)
define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, nop_modifier)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error
2017-02-04 4:42 [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error Youngdo Lee
@ 2017-02-05 10:39 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-02-05 10:39 UTC (permalink / raw)
To: Youngdo Lee; +Cc: thomas.petazzoni, noralf, devel, linux-kernel
On Sat, Feb 04, 2017 at 01:42:48PM +0900, Youngdo Lee wrote:
> Fix checkpatch error:
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Youngdo Lee <paul.ydlee@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index ec45043..3ce265d 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -10,6 +10,7 @@
> *
> *****************************************************************************/
>
> +#define nop_modifier(expr) (expr)
What?
> #define define_fbtft_write_reg(func, type, modifier) \
> void func(struct fbtft_par *par, int len, ...) \
> { \
> @@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...) \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier)
That's really odd. Don't do crazy things like this to fix odd code.
Fix up the code to not do such looney things in the first place.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-05 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-04 4:42 [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error Youngdo Lee
2017-02-05 10:39 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).