linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: use is_vmalloc_addr
@ 2017-02-09 11:45 Miles Chen
  2017-02-13  5:20 ` Andreas Färber
  0 siblings, 1 reply; 3+ messages in thread
From: Miles Chen @ 2017-02-09 11:45 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: linux-arm-kernel, linux-kernel, linux-mediatek, wsd_upstream, Miles Chen

To is_vmalloc_addr() to check if an address is a vmalloc address
instead of checking VMALLOC_START and VMALLOC_END manually.

Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
 arch/arm64/mm/ioremap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
index 01e88c8..c4c8cd4 100644
--- a/arch/arm64/mm/ioremap.c
+++ b/arch/arm64/mm/ioremap.c
@@ -88,7 +88,7 @@ void __iounmap(volatile void __iomem *io_addr)
 	 * We could get an address outside vmalloc range in case
 	 * of ioremap_cache() reusing a RAM mapping.
 	 */
-	if (VMALLOC_START <= addr && addr < VMALLOC_END)
+	if (is_vmalloc_addr((void *)addr))
 		vunmap((void *)addr);
 }
 EXPORT_SYMBOL(__iounmap);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: use is_vmalloc_addr
  2017-02-09 11:45 [PATCH v2] arm64: use is_vmalloc_addr Miles Chen
@ 2017-02-13  5:20 ` Andreas Färber
  2017-02-13 12:52   ` Miles Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2017-02-13  5:20 UTC (permalink / raw)
  To: Miles Chen, Catalin Marinas, Will Deacon
  Cc: linux-mediatek, linux-kernel, linux-arm-kernel, wsd_upstream

Hi,

Am 09.02.2017 um 12:45 schrieb Miles Chen:
> To is_vmalloc_addr() to check if an address is a vmalloc address

"Use ..."?

Regards,
Andreas

> instead of checking VMALLOC_START and VMALLOC_END manually.
> 
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: use is_vmalloc_addr
  2017-02-13  5:20 ` Andreas Färber
@ 2017-02-13 12:52   ` Miles Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Miles Chen @ 2017-02-13 12:52 UTC (permalink / raw)
  To: Andreas Färber
  Cc: Catalin Marinas, Will Deacon, linux-mediatek, linux-kernel,
	linux-arm-kernel, wsd_upstream

On Mon, 2017-02-13 at 06:20 +0100, Andreas Färber wrote:
> Hi,
> 
> Am 09.02.2017 um 12:45 schrieb Miles Chen:
> > To is_vmalloc_addr() to check if an address is a vmalloc address
> 
> "Use ..."?

Yes, it should be "Use". I'll send another patch to fix this.

> 
> Regards,
> Andreas
> 
> > instead of checking VMALLOC_START and VMALLOC_END manually.
> > 
> > Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-13 12:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 11:45 [PATCH v2] arm64: use is_vmalloc_addr Miles Chen
2017-02-13  5:20 ` Andreas Färber
2017-02-13 12:52   ` Miles Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).