linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Nelson <shannon.nelson@oracle.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sowmini Varadhan <sowmini.varadhan@oracle.com>,
	Shannon Nelson <shannon.nelson@oracle.com>
Subject: [PATCH v4 net-next 2/8] sunvnet: remove unused variable in maybe_tx_wakeup
Date: Mon, 13 Feb 2017 10:56:58 -0800	[thread overview]
Message-ID: <1487012224-403399-3-git-send-email-shannon.nelson@oracle.com> (raw)
In-Reply-To: <1487012224-403399-1-git-send-email-shannon.nelson@oracle.com>

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>

The vio_dring_state *dr variable is unused in maybe_tx_wakeup().
As the comments indicate, we call maybe_tx_wakeup() whenever we
get a STOPPED LDC message on the port. If the queue is stopped,
we want to wake it up so that we will send another START message
at the next TX and trigger the consumer to drain the dring.

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 drivers/net/ethernet/sun/sunvnet_common.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c
index c71f000..0f940f0 100644
--- a/drivers/net/ethernet/sun/sunvnet_common.c
+++ b/drivers/net/ethernet/sun/sunvnet_common.c
@@ -719,12 +719,8 @@ static void maybe_tx_wakeup(struct vnet_port *port)
 	txq = netdev_get_tx_queue(VNET_PORT_TO_NET_DEVICE(port),
 				  port->q_index);
 	__netif_tx_lock(txq, smp_processor_id());
-	if (likely(netif_tx_queue_stopped(txq))) {
-		struct vio_dring_state *dr;
-
-		dr = &port->vio.drings[VIO_DRIVER_TX_RING];
+	if (likely(netif_tx_queue_stopped(txq)))
 		netif_tx_wake_queue(txq);
-	}
 	__netif_tx_unlock(txq);
 }
 
-- 
1.7.1

  parent reply	other threads:[~2017-02-13 19:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 18:56 [PATCH v4 net-next 0/8] sunvnet driver updates Shannon Nelson
2017-02-13 18:56 ` [PATCH v4 net-next 1/8] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson
2017-02-13 18:56 ` Shannon Nelson [this message]
2017-02-13 18:56 ` [PATCH v4 net-next 3/8] sunvnet: update version and version printing Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 4/8] sunvnet: add memory barrier before check for tx enable Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic Shannon Nelson
2017-02-13 19:06   ` Joe Perches
2017-02-13 19:18     ` Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 6/8] sunvnet: remove extra rcu_read_unlocks Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 7/8] ldmvsw: update and simplify version string Shannon Nelson
2017-02-13 18:57 ` [PATCH v4 net-next 8/8] ldmvsw: disable tso and gso for bridge operations Shannon Nelson
2017-02-14 18:04 ` [PATCH v4 net-next 0/8] sunvnet driver updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487012224-403399-3-git-send-email-shannon.nelson@oracle.com \
    --to=shannon.nelson@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sowmini.varadhan@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).