* [PATCH 0/5] Add Spreadtrum SP9860G support
@ 2017-02-14 9:19 Chunyan Zhang
2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang
` (4 more replies)
0 siblings, 5 replies; 17+ messages in thread
From: Chunyan Zhang @ 2017-02-14 9:19 UTC (permalink / raw)
To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd
Cc: orson.zhai, linux-kernel, devicetree, linux-arm-kernel
SC9860 is a Spreadtrum SoC with eight Cortex A53, which are divided
into 4 Big cores and 4 little cores.
In this patch-set, patch-1/5 only provides a basic configuration for SC9860
in device tree to make it run to console. After this we will continue
to submit other drivers step by step, which are using on Spreadtrum's SoCs.
This patch-set also adjusted the compatible string of sprd_serial from
'sc9836-uart' to 'sc-uart', because this serial driver is not only for
SC9836 but for all Spreadtrum SoCs so far.
Thanks,
Chunyan
Chunyan Zhang (3):
Documentation: sprd: Add bindings for SP9860G
devicetree: bindings: revise compatible string of sprd uart
sprd_serial: switch comptible string to sc-uart
Orson Zhai (1):
arm64: dts: Add basic DT to support Spreadtrum's SP9860G
Wei Qiao (1):
serial: sprd: adjust TIMEOUT to a big value
Documentation/devicetree/bindings/arm/sprd.txt | 13 +-
.../devicetree/bindings/serial/sprd-uart.txt | 2 +-
arch/arm64/boot/dts/sprd/Makefile | 3 +-
arch/arm64/boot/dts/sprd/sc9860.dtsi | 534 +++++++++++++++++++++
arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 58 +++
arch/arm64/boot/dts/sprd/whale2.dtsi | 66 +++
drivers/tty/serial/sprd_serial.c | 6 +-
7 files changed, 672 insertions(+), 10 deletions(-)
create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi
create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi
--
2.7.4
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang @ 2017-02-14 9:19 ` Chunyan Zhang 2017-02-14 15:57 ` Mark Rutland 2017-02-14 16:44 ` Sudeep Holla 2017-02-14 9:19 ` [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang ` (3 subsequent siblings) 4 siblings, 2 replies; 17+ messages in thread From: Chunyan Zhang @ 2017-02-14 9:19 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, linux-kernel, devicetree, linux-arm-kernel From: Orson Zhai <orson.zhai@spreadtrum.com> SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. According to regular hierarchy of sprd dts, whale2.dtsi contains SoC peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff and sp9860g dts is for the board level. Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- arch/arm64/boot/dts/sprd/Makefile | 3 +- arch/arm64/boot/dts/sprd/sc9860.dtsi | 534 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 58 ++++ arch/arm64/boot/dts/sprd/whale2.dtsi | 66 ++++ 4 files changed, 660 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile index b658c5e..f0535e6 100644 --- a/arch/arm64/boot/dts/sprd/Makefile +++ b/arch/arm64/boot/dts/sprd/Makefile @@ -1,4 +1,5 @@ -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ + sp9860g-1h10.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi new file mode 100644 index 0000000..604a8c9 --- /dev/null +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi @@ -0,0 +1,534 @@ +/* + * Spreadtrum SP9860 SoC DTS file + * + * Copyright (C) 2016, Spreadtrum Communications Inc. + * + * This file is licensed under a dual GPLv2 or X11 license. + */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include "whale2.dtsi" + +/ { + cpus { + #address-cells = <2>; + #size-cells = <0>; + + cpu-map { + cluster0 { + core0 { + cpu = <&CPU0>; + }; + core1 { + cpu = <&CPU1>; + }; + core2 { + cpu = <&CPU2>; + }; + core3 { + cpu = <&CPU3>; + }; + }; + + cluster1 { + core0 { + cpu = <&CPU4>; + }; + core1 { + cpu = <&CPU5>; + }; + core2 { + cpu = <&CPU6>; + }; + core3 { + cpu = <&CPU7>; + }; + }; + }; + + CPU0: cpu@530000 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530000>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU1: cpu@530001 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530001>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU2: cpu@530002 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530002>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU3: cpu@530003 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530003>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU4: cpu@530100 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530100>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU5: cpu@530101 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530101>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU6: cpu@530102 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530102>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + + CPU7: cpu@530103 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530103>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD &DEEP_SLEEP>; + }; + }; + + idle-states{ + entry-method = "arm,psci"; + + CORE_PD: core_pd { + compatible = "arm,idle-state"; + entry-latency-us = <1000>; + exit-latency-us = <700>; + min-residency-us = <2500>; + local-timer-stop; + arm,psci-suspend-param = <0x00010002>; + }; + + CLUSTER_PD: cluster_pd { + compatible = "arm,idle-state"; + entry-latency-us = <1000>; + exit-latency-us = <1000>; + min-residency-us = <3000>; + local-timer-stop; + arm,psci-suspend-param = <0x01010003>; + }; + + DEEP_SLEEP: deep_sleep { + compatible = "arm,idle-state"; + wakeup-latency-us = <0xffffffff>; + entry-latency-us = <1500>; + exit-latency-us = <1500>; + min-residency-us = <0xffffffff>; + local-timer-stop; + arm,psci-suspend-param = <0x01010005>; + }; + }; + + gic: interrupt-controller@12001000 { + compatible = "arm,gic-400"; + reg = <0 0x12001000 0 0x1000>, + <0 0x12002000 0 0x2000>, + <0 0x12004000 0 0x2000>, + <0 0x12006000 0 0x2000>; + #interrupt-cells = <3>; + interrupt-controller; + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_HIGH)>; + }; + + psci { + compatible = "arm,psci-0.2"; + method = "smc"; + }; + + timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>; + clock-frequency = <26000000>; + }; + + pmu { + compatible = "arm,armv8-pmuv3"; + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; + }; + + soc { + soc_funnel:funnel@10001000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x10001000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + soc_funnel_out_port: endpoint { + remote-endpoint = <&etb_in>; + }; + }; + + port@1 { + reg = <0>; + soc_funnel_in_port: endpoint { + slave-mode; + remote-endpoint = + <&main_funnel_out_port>; + }; + }; + }; + }; + + etb@10003000 { + compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0 0x10003000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + port { + etb_in: endpoint { + slave-mode; + remote-endpoint = + <&soc_funnel_out_port>; + }; + }; + }; + + cluster0_funnel:funnel@11001000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x11001000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + cluster0_funnel_out_port: endpoint { + remote-endpoint = + <&cluster0_etf_in>; + }; + }; + + port@1 { + reg = <0>; + cluster0_funnel_in_port0: endpoint { + slave-mode; + remote-endpoint = <&etm0_out>; + }; + }; + + port@2 { + reg = <1>; + cluster0_funnel_in_port1: endpoint { + slave-mode; + remote-endpoint = <&etm1_out>; + }; + }; + + port@3 { + reg = <2>; + cluster0_funnel_in_port2: endpoint { + slave-mode; + remote-endpoint = <&etm2_out>; + }; + }; + + port@4 { + reg = <4>; + cluster0_funnel_in_port3: endpoint { + slave-mode; + remote-endpoint = <&etm3_out>; + }; + }; + }; + }; + + cluster1_funnel:funnel@11002000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x11002000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + cluster1_funnel_out_port: endpoint { + remote-endpoint = + <&cluster1_etf_in>; + }; + }; + + port@1 { + reg = <0>; + cluster1_funnel_in_port0: endpoint { + slave-mode; + remote-endpoint = <&etm4_out>; + }; + }; + + port@2 { + reg = <1>; + cluster1_funnel_in_port1: endpoint { + slave-mode; + remote-endpoint = <&etm5_out>; + }; + }; + + port@3 { + reg = <2>; + cluster1_funnel_in_port2: endpoint { + slave-mode; + remote-endpoint = <&etm6_out>; + }; + }; + + port@4 { + reg = <3>; + cluster1_funnel_in_port3: endpoint { + slave-mode; + remote-endpoint = <&etm7_out>; + }; + }; + }; + }; + + cluster0_etf:etf@11003000 { + compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0 0x11003000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port@0 { + cluster0_etf_out: endpoint { + remote-endpoint = + <&main_funnel_in_port0>; + }; + }; + + port@1 { + cluster0_etf_in: endpoint { + slave-mode; + remote-endpoint = + <&cluster0_funnel_out_port>; + }; + }; + }; + + cluster1_etf:etf@11004000 { + compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0 0x11004000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port@0 { + cluster1_etf_out: endpoint { + remote-endpoint = + <&main_funnel_in_port1>; + }; + }; + + port@1 { + cluster1_etf_in: endpoint { + slave-mode; + remote-endpoint = + <&cluster1_funnel_out_port>; + }; + }; + }; + + main_funnel:funnel@11005000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x11005000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + main_funnel_out_port: endpoint { + remote-endpoint = + <&soc_funnel_in_port>; + }; + }; + + port@1 { + reg = <0>; + main_funnel_in_port0: endpoint { + slave-mode; + remote-endpoint = + <&cluster0_etf_out>; + }; + }; + + port@2 { + reg = <1>; + main_funnel_in_port1: endpoint { + slave-mode; + remote-endpoint = + <&cluster1_etf_out>; + }; + }; + }; + }; + + etm@11440000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11440000 0 0x1000>; + cpu = <&CPU0>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm0_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port0>; + }; + }; + }; + + etm@11540000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11540000 0 0x1000>; + cpu = <&CPU1>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm1_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port1>; + }; + }; + }; + + etm@11640000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11640000 0 0x1000>; + cpu = <&CPU2>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm2_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port2>; + }; + }; + }; + + etm@11740000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11740000 0 0x1000>; + cpu = <&CPU3>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm3_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port3>; + }; + }; + }; + + etm@11840000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11840000 0 0x1000>; + cpu = <&CPU4>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm4_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port0>; + }; + }; + }; + + etm@11940000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11940000 0 0x1000>; + cpu = <&CPU5>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm5_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port1>; + }; + }; + }; + + etm@11a40000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11a40000 0 0x1000>; + cpu = <&CPU6>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm6_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port2>; + }; + }; + }; + + etm@11b40000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11b40000 0 0x1000>; + cpu = <&CPU7>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm7_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port3>; + }; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts new file mode 100644 index 0000000..59390fc --- /dev/null +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts @@ -0,0 +1,58 @@ +/* + * Spreadtrum SP9860g board DTS file + * + * Copyright (C) 2017, Spreadtrum Communications Inc. + * + * This file is licensed under a dual GPLv2 or X11 license. + */ + +/dts-v1/; + +#include "sc9860.dtsi" + +/ { + model = "Spreadtrum SP9860G 3GFHD Board"; + + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; + + sprd,sc-id = <9860 1 0x20000>; + + aliases { + serial0 = &uart0; /* for Bluetooth */ + serial1 = &uart1; /* UART console */ + serial2 = &uart2; /* Reserved */ + serial3 = &uart3; /* for GPS */ + }; + + memory{ + device_type = "memory"; + reg = <0x0 0x80000000 0 0x60000000>, + <0x1 0x80000000 0 0x60000000>; + }; + + chosen { + stdout-path = "serial1:115200n8"; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + }; +}; + +&uart0 { + status = "okay"; +}; + +&uart1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi new file mode 100644 index 0000000..16a0b9ea --- /dev/null +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi @@ -0,0 +1,66 @@ +/* + * Spreadtrum Whale2 SoC platform peripherals DTS file + * + * Copyright (C) 2016, Spreadtrum Communications Inc. + * + * This file is licensed under a dual GPLv2 or X11 license. + */ + +/ { + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + soc: soc { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + ap-apb { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x0 0x70000000 0x10000000>; + + uart0: serial@70000000 { + compatible = "sprd,sc-uart"; + reg = <0x000000 0x100>; + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + + uart1: serial@70100000 { + compatible = "sprd,sc-uart"; + reg = <0x100000 0x100>; + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + + uart2: serial@70200000 { + compatible = "sprd,sc-uart"; + reg = <0x200000 0x100>; + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + + uart3: serial@70300000 { + compatible = "sprd,sc-uart"; + reg = <0x300000 0x100>; + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + }; + + ext_26m: ext-26m { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <26000000>; + clock-output-names = "ext_26m"; + }; + }; +}; -- 2.7.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang @ 2017-02-14 15:57 ` Mark Rutland 2017-02-16 7:57 ` Chunyan Zhang 2017-02-14 16:44 ` Sudeep Holla 1 sibling, 1 reply; 17+ messages in thread From: Mark Rutland @ 2017-02-14 15:57 UTC (permalink / raw) To: Chunyan Zhang Cc: robh+dt, gregkh, catalin.marinas, will.deacon, arnd, orson.zhai, linux-kernel, devicetree, linux-arm-kernel, nd Hi, On Tue, Feb 14, 2017 at 05:19:08PM +0800, Chunyan Zhang wrote: > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <26000000>; > + }; Your FW should program CNTFRQ on all CPUs, and this clock-frequency property should not be necessary. Please remove it. > + > + pmu { > + compatible = "arm,armv8-pmuv3"; Please list "arm,cortex-a53-pmu" first. > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; > + }; As you are using SPIs, please add an interrupt-affinity property, per Documentation/devicetree/bindings/arm/pmu.txt. > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > new file mode 100644 > index 0000000..59390fc > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > @@ -0,0 +1,58 @@ > +/* > + * Spreadtrum SP9860g board DTS file > + * > + * Copyright (C) 2017, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +/dts-v1/; > + > +#include "sc9860.dtsi" > + > +/ { > + model = "Spreadtrum SP9860G 3GFHD Board"; > + > + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; > + > + sprd,sc-id = <9860 1 0x20000>; What is this? I can't see any documentation or user of this property in mainline. Thanks, Mark. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-14 15:57 ` Mark Rutland @ 2017-02-16 7:57 ` Chunyan Zhang 0 siblings, 0 replies; 17+ messages in thread From: Chunyan Zhang @ 2017-02-16 7:57 UTC (permalink / raw) To: Mark Rutland Cc: robh+dt, gregkh, catalin.marinas, will.deacon, arnd, orson.zhai, linux-kernel, devicetree, linux-arm-kernel, nd On 二, 2月 14, 2017 at 03:57:43下午 +0000, Mark Rutland wrote: > Hi, > > On Tue, Feb 14, 2017 at 05:19:08PM +0800, Chunyan Zhang wrote: > > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>; > > + clock-frequency = <26000000>; > > + }; > > Your FW should program CNTFRQ on all CPUs, and this clock-frequency > property should not be necessary. Please remove it. > Will remove it. > > + > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > Please list "arm,cortex-a53-pmu" first. > > > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > As you are using SPIs, please add an interrupt-affinity property, per > Documentation/devicetree/bindings/arm/pmu.txt. Added, would appear in the next revision. > > > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > new file mode 100644 > > index 0000000..59390fc > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > @@ -0,0 +1,58 @@ > > +/* > > + * Spreadtrum SP9860g board DTS file > > + * > > + * Copyright (C) 2017, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sc9860.dtsi" > > + > > +/ { > > + model = "Spreadtrum SP9860G 3GFHD Board"; > > + > > + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; > > + > > + sprd,sc-id = <9860 1 0x20000>; > > What is this? I can't see any documentation or user of this property in > mainline. > I will remove this property in the next iteration, actually this is for Spreadtrum's dtb tools only, I just forgot to remove it before sending this patch out. Thanks, Chunyan > > Thanks, > Mark. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-14 15:57 ` Mark Rutland @ 2017-02-14 16:44 ` Sudeep Holla 2017-02-17 7:28 ` Chunyan Zhang 1 sibling, 1 reply; 17+ messages in thread From: Sudeep Holla @ 2017-02-14 16:44 UTC (permalink / raw) To: Chunyan Zhang Cc: Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, devicetree, orson.zhai, open list, linux-arm, Sudeep Holla On Tue, Feb 14, 2017 at 9:19 AM, Chunyan Zhang <chunyan.zhang@spreadtrum.com> wrote: > From: Orson Zhai <orson.zhai@spreadtrum.com> > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > and sp9860g dts is for the board level. > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > arch/arm64/boot/dts/sprd/Makefile | 3 +- > arch/arm64/boot/dts/sprd/sc9860.dtsi | 534 ++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 58 ++++ > arch/arm64/boot/dts/sprd/whale2.dtsi | 66 ++++ > 4 files changed, 660 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile > index b658c5e..f0535e6 100644 > --- a/arch/arm64/boot/dts/sprd/Makefile > +++ b/arch/arm64/boot/dts/sprd/Makefile > @@ -1,4 +1,5 @@ > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ > + sp9860g-1h10.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > new file mode 100644 > index 0000000..604a8c9 > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > @@ -0,0 +1,534 @@ [...] > + idle-states{ > + entry-method = "arm,psci"; > + > + CORE_PD: core_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <700>; > + min-residency-us = <2500>; > + local-timer-stop; > + arm,psci-suspend-param = <0x00010002>; > + }; > + > + CLUSTER_PD: cluster_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <1000>; > + min-residency-us = <3000>; > + local-timer-stop; > + arm,psci-suspend-param = <0x01010003>; > + }; > + > + DEEP_SLEEP: deep_sleep { > + compatible = "arm,idle-state"; > + wakeup-latency-us = <0xffffffff>; A value > 4294 seconds(i.e >1 hour) seems suspicious. Are you working around the firmware issue with high latency value so that it's never entered ? Why not remove advertising the state from DT. Can you get me the dump of: grep "" /sys/devices/system/cpu/cpu*/cpuidle/state*/{time,usage} IIUC, you might have seen boot issue without this values and workaround the issue with such high values ? If so please drop this state. > + entry-latency-us = <1500>; > + exit-latency-us = <1500>; > + min-residency-us = <0xffffffff>; > + local-timer-stop; > + arm,psci-suspend-param = <0x01010005>; > + }; > + }; > -- Regards, Sudeep ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-14 16:44 ` Sudeep Holla @ 2017-02-17 7:28 ` Chunyan Zhang 2017-02-17 10:28 ` Sudeep Holla 0 siblings, 1 reply; 17+ messages in thread From: Chunyan Zhang @ 2017-02-17 7:28 UTC (permalink / raw) To: Sudeep Holla Cc: Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, devicetree, orson.zhai, open list, linux-arm Hi Sudeep, On 二, 2月 14, 2017 at 04:44:53下午 +0000, Sudeep Holla wrote: > On Tue, Feb 14, 2017 at 9:19 AM, Chunyan Zhang > <chunyan.zhang@spreadtrum.com> wrote: > > From: Orson Zhai <orson.zhai@spreadtrum.com> > > > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > > and sp9860g dts is for the board level. > > > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > > --- > > arch/arm64/boot/dts/sprd/Makefile | 3 +- > > arch/arm64/boot/dts/sprd/sc9860.dtsi | 534 ++++++++++++++++++++++++++++++ > > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 58 ++++ > > arch/arm64/boot/dts/sprd/whale2.dtsi | 66 ++++ > > 4 files changed, 660 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > > > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile > > index b658c5e..f0535e6 100644 > > --- a/arch/arm64/boot/dts/sprd/Makefile > > +++ b/arch/arm64/boot/dts/sprd/Makefile > > @@ -1,4 +1,5 @@ > > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb > > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ > > + sp9860g-1h10.dtb > > > > always := $(dtb-y) > > subdir-y := $(dts-dirs) > > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > > new file mode 100644 > > index 0000000..604a8c9 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > > @@ -0,0 +1,534 @@ > > [...] > > > + idle-states{ > > + entry-method = "arm,psci"; > > + > > + CORE_PD: core_pd { > > + compatible = "arm,idle-state"; > > + entry-latency-us = <1000>; > > + exit-latency-us = <700>; > > + min-residency-us = <2500>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x00010002>; > > + }; > > + > > + CLUSTER_PD: cluster_pd { > > + compatible = "arm,idle-state"; > > + entry-latency-us = <1000>; > > + exit-latency-us = <1000>; > > + min-residency-us = <3000>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x01010003>; > > + }; > > + > > + DEEP_SLEEP: deep_sleep { > > + compatible = "arm,idle-state"; > > + wakeup-latency-us = <0xffffffff>; > > A value > 4294 seconds(i.e >1 hour) seems suspicious. > Are you working around the firmware issue with high latency value so > that it's never entered ? Why not remove advertising the state from DT. > Haved checked with related colleagues, this node 'deep_sleep' was not for working around any firmware issue, but was a trick utilization of idle subsystem, and that was definitely not elegant, the author indeed intendly didn't want CPU entered this state, I will remove this node therefore. > Can you get me the dump of: > grep "" /sys/devices/system/cpu/cpu*/cpuidle/state*/{time,usage} > FYI: https://www.irccloud.com/pastebin/XyEMLzfq/ Thanks, Chunyan > IIUC, you might have seen boot issue without this values and workaround > the issue with such high values ? If so please drop this state. > > > + entry-latency-us = <1500>; > > + exit-latency-us = <1500>; > > + min-residency-us = <0xffffffff>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x01010005>; > > + }; > > + }; > > > > -- > Regards, > Sudeep ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-17 7:28 ` Chunyan Zhang @ 2017-02-17 10:28 ` Sudeep Holla 2017-02-20 9:37 ` Chunyan Zhang 0 siblings, 1 reply; 17+ messages in thread From: Sudeep Holla @ 2017-02-17 10:28 UTC (permalink / raw) To: devicetree, orson.zhai, open list, linux-arm, Chunyan Zhang Cc: Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Sudeep Holla On 17/02/17 07:28, Chunyan Zhang wrote: > Hi Sudeep, > > On 二, 2月 14, 2017 at 04:44:53下午 +0000, Sudeep Holla wrote: >> On Tue, Feb 14, 2017 at 9:19 AM, Chunyan Zhang >> <chunyan.zhang@spreadtrum.com> wrote: [..] >> >>> + idle-states{ >>> + entry-method = "arm,psci"; >>> + >>> + CORE_PD: core_pd { >>> + compatible = "arm,idle-state"; >>> + entry-latency-us = <1000>; >>> + exit-latency-us = <700>; >>> + min-residency-us = <2500>; >>> + local-timer-stop; >>> + arm,psci-suspend-param = <0x00010002>; >>> + }; >>> + >>> + CLUSTER_PD: cluster_pd { >>> + compatible = "arm,idle-state"; >>> + entry-latency-us = <1000>; >>> + exit-latency-us = <1000>; >>> + min-residency-us = <3000>; >>> + local-timer-stop; >>> + arm,psci-suspend-param = <0x01010003>; >>> + }; >>> + >>> + DEEP_SLEEP: deep_sleep { >>> + compatible = "arm,idle-state"; >>> + wakeup-latency-us = <0xffffffff>; >> >> A value > 4294 seconds(i.e >1 hour) seems suspicious. >> Are you working around the firmware issue with high latency value so >> that it's never entered ? Why not remove advertising the state from DT. >> > > Haved checked with related colleagues, this node 'deep_sleep' was not for working > around any firmware issue, but was a trick utilization of idle subsystem, and that Really ? Any latency greater few milliseconds are sounds useless. I still don't understand what you mean by "trick utilization of idle subsystem". > was definitely not elegant, the author indeed intendly didn't want CPU entered this > state, I will remove this node therefore. It's quick and dirty "HACK* to retain and advertise the state but ensure it's never entered and obstruct the boot. It's not a trick to exploit any idle subsystem utilization. > >> Can you get me the dump of: >> grep "" /sys/devices/system/cpu/cpu*/cpuidle/state*/{time,usage} >> > > FYI: https://www.irccloud.com/pastebin/XyEMLzfq/ > As expected, state3(deep_sleep) is never entered. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-17 10:28 ` Sudeep Holla @ 2017-02-20 9:37 ` Chunyan Zhang 2017-02-20 10:47 ` Sudeep Holla 0 siblings, 1 reply; 17+ messages in thread From: Chunyan Zhang @ 2017-02-20 9:37 UTC (permalink / raw) To: Sudeep Holla Cc: devicetree, orson.zhai, open list, linux-arm, Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann Hi Sudeep, On 五, 2月 17, 2017 at 10:28:00上午 +0000, Sudeep Holla wrote: > > > On 17/02/17 07:28, Chunyan Zhang wrote: > > Hi Sudeep, > > > > On 二, 2月 14, 2017 at 04:44:53下午 +0000, Sudeep Holla wrote: > >> On Tue, Feb 14, 2017 at 9:19 AM, Chunyan Zhang > >> <chunyan.zhang@spreadtrum.com> wrote: > > [..] > > >> > >>> + idle-states{ > >>> + entry-method = "arm,psci"; > >>> + > >>> + CORE_PD: core_pd { > >>> + compatible = "arm,idle-state"; > >>> + entry-latency-us = <1000>; > >>> + exit-latency-us = <700>; > >>> + min-residency-us = <2500>; > >>> + local-timer-stop; > >>> + arm,psci-suspend-param = <0x00010002>; > >>> + }; > >>> + > >>> + CLUSTER_PD: cluster_pd { > >>> + compatible = "arm,idle-state"; > >>> + entry-latency-us = <1000>; > >>> + exit-latency-us = <1000>; > >>> + min-residency-us = <3000>; > >>> + local-timer-stop; > >>> + arm,psci-suspend-param = <0x01010003>; > >>> + }; > >>> + > >>> + DEEP_SLEEP: deep_sleep { > >>> + compatible = "arm,idle-state"; > >>> + wakeup-latency-us = <0xffffffff>; > >> > >> A value > 4294 seconds(i.e >1 hour) seems suspicious. > >> Are you working around the firmware issue with high latency value so > >> that it's never entered ? Why not remove advertising the state from DT. > >> > > > > Haved checked with related colleagues, this node 'deep_sleep' was not for working > > around any firmware issue, but was a trick utilization of idle subsystem, and that > > Really ? Any latency greater few milliseconds are sounds useless. I > still don't understand what you mean by "trick utilization of idle > subsystem". > Sorry for confused expression, I meant it was not a right way to utilize idle mechanism and shouldn't be upstreamed. > > was definitely not elegant, the author indeed intendly didn't want CPU entered this > > state, I will remove this node therefore. > > It's quick and dirty "HACK* to retain and advertise the state but > ensure it's never entered and obstruct the boot. It's not a trick to > exploit any idle subsystem utilization. > Right, actually deep_sleep was for 'suspend' (forces idleness upon the OS until a wake-up event resumes the OS from suspend), for example when users press power key on mobile phone to turn off the screen. So the author implemented 'suspend' using cpu_psci_ops::cpu_suspend I figure that this way is not correct, I will remove this state from DT. I would appreciate any suggestion for how to implement this kind of function properly. Thanks, Chunyan > > > >> Can you get me the dump of: > >> grep "" /sys/devices/system/cpu/cpu*/cpuidle/state*/{time,usage} > >> > > > > FYI: https://www.irccloud.com/pastebin/XyEMLzfq/ > > > > As expected, state3(deep_sleep) is never entered. > > -- > Regards, > Sudeep ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-20 9:37 ` Chunyan Zhang @ 2017-02-20 10:47 ` Sudeep Holla 2017-02-20 12:56 ` Chunyan Zhang 0 siblings, 1 reply; 17+ messages in thread From: Sudeep Holla @ 2017-02-20 10:47 UTC (permalink / raw) To: devicetree, orson.zhai, open list, linux-arm, Chunyan Zhang Cc: Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Sudeep Holla On 20/02/17 09:37, Chunyan Zhang wrote: > Hi Sudeep, > > On 五, 2月 17, 2017 at 10:28:00上午 +0000, Sudeep Holla wrote: >> >> >> On 17/02/17 07:28, Chunyan Zhang wrote: >>> Hi Sudeep, >>> >>> On 二, 2月 14, 2017 at 04:44:53下午 +0000, Sudeep Holla wrote: >>>> On Tue, Feb 14, 2017 at 9:19 AM, Chunyan Zhang >>>> <chunyan.zhang@spreadtrum.com> wrote: >> >> [..] >> >>>> >>>>> + idle-states{ >>>>> + entry-method = "arm,psci"; >>>>> + >>>>> + CORE_PD: core_pd { >>>>> + compatible = "arm,idle-state"; >>>>> + entry-latency-us = <1000>; >>>>> + exit-latency-us = <700>; >>>>> + min-residency-us = <2500>; >>>>> + local-timer-stop; >>>>> + arm,psci-suspend-param = <0x00010002>; >>>>> + }; >>>>> + >>>>> + CLUSTER_PD: cluster_pd { >>>>> + compatible = "arm,idle-state"; >>>>> + entry-latency-us = <1000>; >>>>> + exit-latency-us = <1000>; >>>>> + min-residency-us = <3000>; >>>>> + local-timer-stop; >>>>> + arm,psci-suspend-param = <0x01010003>; >>>>> + }; >>>>> + >>>>> + DEEP_SLEEP: deep_sleep { >>>>> + compatible = "arm,idle-state"; >>>>> + wakeup-latency-us = <0xffffffff>; >>>> >>>> A value > 4294 seconds(i.e >1 hour) seems suspicious. >>>> Are you working around the firmware issue with high latency value so >>>> that it's never entered ? Why not remove advertising the state from DT. >>>> >>> >>> Haved checked with related colleagues, this node 'deep_sleep' was not for working >>> around any firmware issue, but was a trick utilization of idle subsystem, and that >> >> Really ? Any latency greater few milliseconds are sounds useless. I >> still don't understand what you mean by "trick utilization of idle >> subsystem". >> > > Sorry for confused expression, I meant it was not a right way to utilize idle mechanism > and shouldn't be upstreamed. > No problem. >>> was definitely not elegant, the author indeed intendly didn't want CPU entered this >>> state, I will remove this node therefore. >> >> It's quick and dirty "HACK* to retain and advertise the state but >> ensure it's never entered and obstruct the boot. It's not a trick to >> exploit any idle subsystem utilization. >> > > Right, actually deep_sleep was for 'suspend' (forces idleness upon > the OS until a wake-up event resumes the OS from suspend), for > example when users press power key on mobile phone to turn off the > screen. So the author implemented 'suspend' using cpu_psci_ops::cpu_suspend > I figure that this way is not correct, I will remove this state from DT. OK. > I would appreciate any suggestion for how to implement this kind of > function properly. For the 'suspend' functionality you have described above, all you need is the firmware to implement PSCI SYSTEM_SUSPEND API in the firmware. The kernel psci driver detects the presence of the same and registers the suspend ops automatically. You need not add anything in the code or DT for the same. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-20 10:47 ` Sudeep Holla @ 2017-02-20 12:56 ` Chunyan Zhang 0 siblings, 0 replies; 17+ messages in thread From: Chunyan Zhang @ 2017-02-20 12:56 UTC (permalink / raw) To: Sudeep Holla Cc: devicetree, orson.zhai, open list, linux-arm, Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann On 一, 2月 20, 2017 at 10:47:56上午 +0000, Sudeep Holla wrote: > > > On 20/02/17 09:37, Chunyan Zhang wrote: > > Hi Sudeep, > > > > On 五, 2月 17, 2017 at 10:28:00上午 +0000, Sudeep Holla wrote: > >> > >> > >> On 17/02/17 07:28, Chunyan Zhang wrote: > >>> Hi Sudeep, > >>> > >>> On 二, 2月 14, 2017 at 04:44:53下午 +0000, Sudeep Holla wrote: > >>>> On Tue, Feb 14, 2017 at 9:19 AM, Chunyan Zhang > >>>> <chunyan.zhang@spreadtrum.com> wrote: > >> > >> [..] > >> > >>>> > >>>>> + idle-states{ > >>>>> + entry-method = "arm,psci"; > >>>>> + > >>>>> + CORE_PD: core_pd { > >>>>> + compatible = "arm,idle-state"; > >>>>> + entry-latency-us = <1000>; > >>>>> + exit-latency-us = <700>; > >>>>> + min-residency-us = <2500>; > >>>>> + local-timer-stop; > >>>>> + arm,psci-suspend-param = <0x00010002>; > >>>>> + }; > >>>>> + > >>>>> + CLUSTER_PD: cluster_pd { > >>>>> + compatible = "arm,idle-state"; > >>>>> + entry-latency-us = <1000>; > >>>>> + exit-latency-us = <1000>; > >>>>> + min-residency-us = <3000>; > >>>>> + local-timer-stop; > >>>>> + arm,psci-suspend-param = <0x01010003>; > >>>>> + }; > >>>>> + > >>>>> + DEEP_SLEEP: deep_sleep { > >>>>> + compatible = "arm,idle-state"; > >>>>> + wakeup-latency-us = <0xffffffff>; > >>>> > >>>> A value > 4294 seconds(i.e >1 hour) seems suspicious. > >>>> Are you working around the firmware issue with high latency value so > >>>> that it's never entered ? Why not remove advertising the state from DT. > >>>> > >>> > >>> Haved checked with related colleagues, this node 'deep_sleep' was not for working > >>> around any firmware issue, but was a trick utilization of idle subsystem, and that > >> > >> Really ? Any latency greater few milliseconds are sounds useless. I > >> still don't understand what you mean by "trick utilization of idle > >> subsystem". > >> > > > > Sorry for confused expression, I meant it was not a right way to utilize idle mechanism > > and shouldn't be upstreamed. > > > > No problem. > > >>> was definitely not elegant, the author indeed intendly didn't want CPU entered this > >>> state, I will remove this node therefore. > >> > >> It's quick and dirty "HACK* to retain and advertise the state but > >> ensure it's never entered and obstruct the boot. It's not a trick to > >> exploit any idle subsystem utilization. > >> > > > > > Right, actually deep_sleep was for 'suspend' (forces idleness upon > > the OS until a wake-up event resumes the OS from suspend), for > > example when users press power key on mobile phone to turn off the > > screen. So the author implemented 'suspend' using cpu_psci_ops::cpu_suspend > > I figure that this way is not correct, I will remove this state from DT. > > OK. > > > I would appreciate any suggestion for how to implement this kind of > > function properly. > > > For the 'suspend' functionality you have described above, all you need > is the firmware to implement PSCI SYSTEM_SUSPEND API in the firmware. > The kernel psci driver detects the presence of the same and registers > the suspend ops automatically. You need not add anything in the code or > DT for the same. Thank you Sudeep, I will have my colleague to study further according to the direction you provided here. Thanks for your comments, Chunyan > > -- > Regards, > Sudeep ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G 2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang 2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang @ 2017-02-14 9:19 ` Chunyan Zhang 2017-02-14 9:19 ` [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang ` (2 subsequent siblings) 4 siblings, 0 replies; 17+ messages in thread From: Chunyan Zhang @ 2017-02-14 9:19 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, linux-kernel, devicetree, linux-arm-kernel Added support for Spreadtrum SP9860G board and SC9860 SoC. This patch also revised bindings of SC9836 to make the format more clear. Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- Documentation/devicetree/bindings/arm/sprd.txt | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt index 31a629d..3df034b 100644 --- a/Documentation/devicetree/bindings/arm/sprd.txt +++ b/Documentation/devicetree/bindings/arm/sprd.txt @@ -1,11 +1,14 @@ Spreadtrum SoC Platforms Device Tree Bindings ---------------------------------------------------- -Sharkl64 is a Spreadtrum's SoC Platform which is based -on ARM 64-bit processor. +SC9836 openphone Board +Required root node properties: + - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; -SC9836 openphone board with SC9836 SoC based on the -Sharkl64 Platform shall have the following properties. +SC9860 SoC +Required root node properties: + - compatible = "sprd,sc9860" +SP9860G 3GFHD Board Required root node properties: - - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; + - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart 2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang 2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-14 9:19 ` [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang @ 2017-02-14 9:19 ` Chunyan Zhang 2017-02-14 17:02 ` Rob Herring 2017-02-14 9:19 ` [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang 2017-02-14 9:19 ` [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang 4 siblings, 1 reply; 17+ messages in thread From: Chunyan Zhang @ 2017-02-14 9:19 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, linux-kernel, devicetree, linux-arm-kernel This patch revise the compatible string of sprd uart to "sc-uart" since this driver is not only for SC9836, but for all Spreadtrum SoCs so far. Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- Documentation/devicetree/bindings/serial/sprd-uart.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt index 2aff0f2..9b0ad52 100644 --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt @@ -1,7 +1,7 @@ * Spreadtrum serial UART Required properties: -- compatible: must be "sprd,sc9836-uart" +- compatible: must be "sprd,sc-uart" - reg: offset and length of the register set for the device - interrupts: exactly one interrupt specifier - clocks: phandles to input clocks. -- 2.7.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart 2017-02-14 9:19 ` [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang @ 2017-02-14 17:02 ` Rob Herring 0 siblings, 0 replies; 17+ messages in thread From: Rob Herring @ 2017-02-14 17:02 UTC (permalink / raw) To: Chunyan Zhang Cc: Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Orson Zhai(翟京), linux-kernel, devicetree, linux-arm-kernel On Tue, Feb 14, 2017 at 3:19 AM, Chunyan Zhang <chunyan.zhang@spreadtrum.com> wrote: > This patch revise the compatible string of sprd uart to "sc-uart" > since this driver is not only for SC9836, but for all Spreadtrum > SoCs so far. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > index 2aff0f2..9b0ad52 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > @@ -1,7 +1,7 @@ > * Spreadtrum serial UART > > Required properties: > -- compatible: must be "sprd,sc9836-uart" > +- compatible: must be "sprd,sc-uart" You can't just change compatible strings. You don't need a generic-ish compatible if other SoCs have "the same" uart. Then you just do: '"sprd,sc<new soc>-uart", "sprd,sc9836-uart"' in the DT. The existing driver will work matching on sprd,sc9836-uart and if you ever find some difference in the uarts you have the more specific compatible string to handle that. Rob ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/5] sprd_serial: switch comptible string to sc-uart 2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang ` (2 preceding siblings ...) 2017-02-14 9:19 ` [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang @ 2017-02-14 9:19 ` Chunyan Zhang 2017-02-16 13:31 ` Arnd Bergmann 2017-02-14 9:19 ` [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang 4 siblings, 1 reply; 17+ messages in thread From: Chunyan Zhang @ 2017-02-14 9:19 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, linux-kernel, devicetree, linux-arm-kernel This driver sprd_serial is not only for SC9836, but for all Spreadtrum SoCs so far. Signed-off-by: Chunyan Zhang <chunyan.chunyan@spreadtrum.com> --- drivers/tty/serial/sprd_serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 699447a..c0d63c01 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -624,7 +624,7 @@ static int __init sprd_early_console_setup( device->con->write = sprd_early_write; return 0; } -OF_EARLYCON_DECLARE(sprd_serial, "sprd,sc9836-uart", +OF_EARLYCON_DECLARE(sprd_serial, "sprd,sc-uart", sprd_early_console_setup); #else /* !CONFIG_SERIAL_SPRD_CONSOLE */ @@ -777,7 +777,7 @@ static int sprd_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(sprd_pm_ops, sprd_suspend, sprd_resume); static const struct of_device_id serial_ids[] = { - {.compatible = "sprd,sc9836-uart",}, + {.compatible = "sprd,sc-uart",}, {} }; MODULE_DEVICE_TABLE(of, serial_ids); -- 2.7.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart 2017-02-14 9:19 ` [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang @ 2017-02-16 13:31 ` Arnd Bergmann 2017-02-17 7:35 ` Chunyan Zhang 0 siblings, 1 reply; 17+ messages in thread From: Arnd Bergmann @ 2017-02-16 13:31 UTC (permalink / raw) To: linux-arm-kernel Cc: Chunyan Zhang, robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, orson.zhai, linux-kernel, devicetree On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote: > static const struct of_device_id serial_ids[] = { > - {.compatible = "sprd,sc9836-uart",}, > + {.compatible = "sprd,sc-uart",}, > {} We really need this to be specific, in case Spreadtrum ever makes a slightly different UART that is not 100% compatible with this one. Also, you can't remove the string you already have, only add to it. Normally when you have a new chip that is compatible with one we already have a driver for, we mark the device as compatible with the old one and avoid having to change the driver, e.g. compatible = "sprd,sc9995-uart", "sprd,sc9836-uart"; This way, the driver could later be changed to handle anything that is compatible with sc9995 differently from sc9836, but by default it would match the original string. Arnd ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart 2017-02-16 13:31 ` Arnd Bergmann @ 2017-02-17 7:35 ` Chunyan Zhang 0 siblings, 0 replies; 17+ messages in thread From: Chunyan Zhang @ 2017-02-17 7:35 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel, robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, orson.zhai, linux-kernel, devicetree On 四, 2月 16, 2017 at 02:31:38下午 +0100, Arnd Bergmann wrote: > On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote: > > static const struct of_device_id serial_ids[] = { > > - {.compatible = "sprd,sc9836-uart",}, > > + {.compatible = "sprd,sc-uart",}, > > {} > > We really need this to be specific, in case Spreadtrum ever > makes a slightly different UART that is not 100% compatible > with this one. Also, you can't remove the string you already have, > only add to it. > > Normally when you have a new chip that is compatible with one > we already have a driver for, we mark the device as compatible > with the old one and avoid having to change the driver, e.g. > > compatible = "sprd,sc9995-uart", "sprd,sc9836-uart"; > > This way, the driver could later be changed to handle anything > that is compatible with sc9995 differently from sc9836, but > by default it would match the original string. > Right, I've addressed this when I received the same comments from Rob Herring :) Thanks for your comments, Chunyan > Arnd ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value 2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang ` (3 preceding siblings ...) 2017-02-14 9:19 ` [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang @ 2017-02-14 9:19 ` Chunyan Zhang 4 siblings, 0 replies; 17+ messages in thread From: Chunyan Zhang @ 2017-02-14 9:19 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, linux-kernel, devicetree, linux-arm-kernel From: Wei Qiao <wei.qiao@spreadtrum.com> SPRD_TIMEOUT was 256, which is too small to wait until the status switched to workable in a while loop, so that the earlycon could not work correctly. Signed-off-by: Wei Qiao <wei.qiao@spreadtrum.com> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- drivers/tty/serial/sprd_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index c0d63c01..f548e97 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -36,7 +36,7 @@ #define SPRD_FIFO_SIZE 128 #define SPRD_DEF_RATE 26000000 #define SPRD_BAUD_IO_LIMIT 3000000 -#define SPRD_TIMEOUT 256 +#define SPRD_TIMEOUT 256000 /* the offset of serial registers and BITs for them */ /* data registers */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-02-20 12:58 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang 2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-14 15:57 ` Mark Rutland 2017-02-16 7:57 ` Chunyan Zhang 2017-02-14 16:44 ` Sudeep Holla 2017-02-17 7:28 ` Chunyan Zhang 2017-02-17 10:28 ` Sudeep Holla 2017-02-20 9:37 ` Chunyan Zhang 2017-02-20 10:47 ` Sudeep Holla 2017-02-20 12:56 ` Chunyan Zhang 2017-02-14 9:19 ` [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang 2017-02-14 9:19 ` [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang 2017-02-14 17:02 ` Rob Herring 2017-02-14 9:19 ` [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang 2017-02-16 13:31 ` Arnd Bergmann 2017-02-17 7:35 ` Chunyan Zhang 2017-02-14 9:19 ` [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).