[PATCH 0/2] extcon: palmas/usb-gpio: Don't miss events during suspend/resume

[PATCH 0/2] extcon: palmas/usb-gpio: Don't miss events during suspend/resume

[Roger Quadros]

Hi,

This series ensures that we don't miss USB VBUS/ID event
changes across system suspend/resume.

cheers,
-roger

Roger Quadros (2):
  extcon: usb-gpio: Don't miss event during suspend/resume
  extcon: palmas: Don't miss GPIO events during suspend/resume

 drivers/extcon/extcon-palmas.c   | 6 ++++++
 drivers/extcon/extcon-usb-gpio.c | 5 ++---
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
2.7.4

[PATCH 1/2] extcon: usb-gpio: Don't miss event during suspend/resume

[Roger Quadros]

We must check for ID/VBUS changes during resume irrespective
of whether our device wakeup is enabled or not.

Without this we seem to be missing ID/VBUS events after
system suspend/resume.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/extcon/extcon-usb-gpio.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index d589c5f..71ac427 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -275,9 +275,8 @@ static int usb_extcon_resume(struct device *dev)
 	if (info->vbus_gpiod)
 		enable_irq(info->vbus_irq);
 
-	if (!device_may_wakeup(dev))
-		queue_delayed_work(system_power_efficient_wq,
-				   &info->wq_detcable, 0);
+	queue_delayed_work(system_power_efficient_wq,
+			   &info->wq_detcable, 0);
 
 	return ret;
 }
-- 
2.7.4

[PATCH 2/2] extcon: palmas: Don't miss GPIO events during suspend/resume

[Roger Quadros]

The USB cable state can change during suspend/resume
so be sure to check and update the extcon state.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/extcon/extcon-palmas.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 634ba70..97bacb4 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -408,6 +408,12 @@ static int palmas_usb_resume(struct device *dev)
 		if (palmas_usb->enable_gpio_id_detection)
 			disable_irq_wake(palmas_usb->gpio_id_irq);
 	}
+
+	/* check if GPIO states changed while suspend/resume */
+	if (palmas_usb->enable_gpio_vbus_detection)
+		palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
+	palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
+
 	return 0;
 };
 #endif
-- 
2.7.4

Re: [PATCH 0/2] extcon: palmas/usb-gpio: Don't miss events during suspend/resume

[Chanwoo Choi]

On 2017년 02월 15일 21:31, Roger Quadros wrote:
> Hi,
>
> This series ensures that we don't miss USB VBUS/ID event
> changes across system suspend/resume.
>
> cheers,
> -roger
>
> Roger Quadros (2):
>   extcon: usb-gpio: Don't miss event during suspend/resume
>   extcon: palmas: Don't miss GPIO events during suspend/resume
>
>  drivers/extcon/extcon-palmas.c   | 6 ++++++
>  drivers/extcon/extcon-usb-gpio.c | 5 ++---
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
Applied all patches in this series.
Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics