From: "Tobin C. Harding" <me@tobin.cc>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
"Tobin C. Harding" <me@tobin.cc>
Subject: [PATCH v4 2/2] x86/purgatory: Fix sparse warning, symbol not declared
Date: Mon, 20 Feb 2017 10:12:36 +1100 [thread overview]
Message-ID: <1487545956-2547-3-git-send-email-me@tobin.cc> (raw)
In-Reply-To: <1487545956-2547-1-git-send-email-me@tobin.cc>
Sparse emits warning, 'symbol not declared' for a function that has
neither file scope nor a forward declaration. The functions only call
site is an ASM file.
Add a header file with the function declaration. Include the
header file in the C source file defining the function in order
to fix the sparse warning. Include the header file in ASM file
containing the call site to document the usage.
Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
arch/x86/purgatory/purgatory.c | 1 +
arch/x86/purgatory/purgatory.h | 12 ++++++++++++
arch/x86/purgatory/setup-x86_64.S | 4 ++--
3 files changed, 15 insertions(+), 2 deletions(-)
create mode 100644 arch/x86/purgatory/purgatory.h
diff --git a/arch/x86/purgatory/purgatory.c b/arch/x86/purgatory/purgatory.c
index 2a5f437..b6d5c89 100644
--- a/arch/x86/purgatory/purgatory.c
+++ b/arch/x86/purgatory/purgatory.c
@@ -11,6 +11,7 @@
*/
#include "sha256.h"
+#include "purgatory.h"
#include "../boot/string.h"
struct sha_region {
diff --git a/arch/x86/purgatory/purgatory.h b/arch/x86/purgatory/purgatory.h
new file mode 100644
index 0000000..fb8b4f8
--- /dev/null
+++ b/arch/x86/purgatory/purgatory.h
@@ -0,0 +1,12 @@
+#ifndef PURGATORY_H
+#define PURGATORY_H
+
+#ifndef __ASSEMBLY__
+
+extern void purgatory(void);
+
+#endif /* __ASSEMBLY__ */
+
+#endif /* PURGATORY_H */
+
+
diff --git a/arch/x86/purgatory/setup-x86_64.S b/arch/x86/purgatory/setup-x86_64.S
index fe3c91b..8045994 100644
--- a/arch/x86/purgatory/setup-x86_64.S
+++ b/arch/x86/purgatory/setup-x86_64.S
@@ -9,8 +9,8 @@
* This source code is licensed under the GNU General Public License,
* Version 2. See the file COPYING for more details.
*/
-
- .text
+#include "purgatory.h"
+ .text
.globl purgatory_start
.balign 16
purgatory_start:
--
2.7.4
next prev parent reply other threads:[~2017-02-19 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 23:12 [PATCH v4 0/2] x86/purgatory: Fix sparse warning, symbol not declared Tobin C. Harding
2017-02-19 23:12 ` [PATCH v4 1/2] " Tobin C. Harding
2017-03-01 10:31 ` [tip:x86/urgent] x86/purgatory: Make functions and variables static tip-bot for Tobin C. Harding
2017-02-19 23:12 ` Tobin C. Harding [this message]
2017-03-01 10:32 ` [tip:x86/urgent] x86/purgatory: Fix sparse warning, symbol not declared tip-bot for Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487545956-2547-3-git-send-email-me@tobin.cc \
--to=me@tobin.cc \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).