linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "tip-bot for Tobin C. Harding" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: me@tobin.cc, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86/purgatory: Make functions and variables static
Date: Wed, 1 Mar 2017 02:31:27 -0800	[thread overview]
Message-ID: <tip-72042a8c7b01048a36ece216aaf206b7d60ca661@git.kernel.org> (raw)
In-Reply-To: <1487545956-2547-2-git-send-email-me@tobin.cc>

Commit-ID:  72042a8c7b01048a36ece216aaf206b7d60ca661
Gitweb:     http://git.kernel.org/tip/72042a8c7b01048a36ece216aaf206b7d60ca661
Author:     Tobin C. Harding <me@tobin.cc>
AuthorDate: Mon, 20 Feb 2017 10:12:35 +1100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 1 Mar 2017 11:27:26 +0100

x86/purgatory: Make functions and variables static

Sparse emits several 'symbol not declared' warnings for various
functions and variables.

Add static keyword to functions and variables which have file scope
only.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Link: http://lkml.kernel.org/r/1487545956-2547-2-git-send-email-me@tobin.cc
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/purgatory/purgatory.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/purgatory/purgatory.c b/arch/x86/purgatory/purgatory.c
index 25e068b..2a5f437 100644
--- a/arch/x86/purgatory/purgatory.c
+++ b/arch/x86/purgatory/purgatory.c
@@ -18,11 +18,11 @@ struct sha_region {
 	unsigned long len;
 };
 
-unsigned long backup_dest = 0;
-unsigned long backup_src = 0;
-unsigned long backup_sz = 0;
+static unsigned long backup_dest;
+static unsigned long backup_src;
+static unsigned long backup_sz;
 
-u8 sha256_digest[SHA256_DIGEST_SIZE] = { 0 };
+static u8 sha256_digest[SHA256_DIGEST_SIZE] = { 0 };
 
 struct sha_region sha_regions[16] = {};
 
@@ -39,7 +39,7 @@ static int copy_backup_region(void)
 	return 0;
 }
 
-int verify_sha256_digest(void)
+static int verify_sha256_digest(void)
 {
 	struct sha_region *ptr, *end;
 	u8 digest[SHA256_DIGEST_SIZE];

  reply	other threads:[~2017-03-01 10:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-19 23:12 [PATCH v4 0/2] x86/purgatory: Fix sparse warning, symbol not declared Tobin C. Harding
2017-02-19 23:12 ` [PATCH v4 1/2] " Tobin C. Harding
2017-03-01 10:31   ` tip-bot for Tobin C. Harding [this message]
2017-02-19 23:12 ` [PATCH v4 2/2] " Tobin C. Harding
2017-03-01 10:32   ` [tip:x86/urgent] " tip-bot for Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-72042a8c7b01048a36ece216aaf206b7d60ca661@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).