linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@aj.id.au>
To: minyard@acm.org, "Cédric Le Goater" <clg@kaod.org>
Cc: Joel Stanley <joel@jms.id.au>,
	openipmi-developer@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access
Date: Tue, 21 Feb 2017 01:22:59 +1030	[thread overview]
Message-ID: <1487602379.21631.2.camel@aj.id.au> (raw)
In-Reply-To: <1fe8fe1f-e035-8ef1-cecd-d3d29bcda075@acm.org>

[-- Attachment #1: Type: text/plain, Size: 1667 bytes --]

On Mon, 2017-02-20 at 07:35 -0600, Corey Minyard wrote:
> On 02/19/2017 10:45 PM, Andrew Jeffery wrote:
> > Hi Cory,
> > 
> > On Tue, 2016-12-06 at 16:02 +0100, Cédric Le Goater wrote:
> > > [ this is a resend bc of some mailing list issues]
> > > 
> > > On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
> > > > The registers for the bt-bmc device live under the Aspeed LPC
> > > > controller. Devicetree bindings have recently been introduced for the
> > > > LPC controller where the "host" portion of the LPC register space is
> > > > described as a syscon device. Future devicetrees describing the bt-bmc
> > > > device should nest its node under the appropriate "simple-mfd", "syscon"
> > > > compatible node.
> > > > 
> > > > This change allows the bt-bmc driver to function with both syscon and
> > > > non-syscon- based devicetree descriptions by always using a regmap for
> > > > register access, either retrieved from the parent syscon device or
> > > > instantiated if none exists.
> > > > 
> > > > The patch has been tested on an OpenPOWER Palmetto machine, successfully
> > > > booting, rebooting and powering down the host.
> > > > 
> > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > 
> > > It would be nice to have an example of the associated binding.
> > > I did not see it. A part from that :
> > > 
> > > Reviewed-by: Cédric Le Goater <clg@kaod.org>
> > 
> > Will this make it into 4.11?
> 
> I thought you were doing a v2 with a few little fixes.  Get it to me 
> quickly, if you can.

Reading back it was a bit ambiguous. No worries, I'll roll in the small
fixes and send a v2.

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2017-02-20 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06  2:57 [PATCH] ipmi: bt-bmc: Use a regmap for register access Andrew Jeffery
2016-12-06  7:16 ` Cédric Le Goater
2016-12-06 15:02 ` Cédric Le Goater
2016-12-07  0:04   ` Andrew Jeffery
2017-02-20  4:45   ` Andrew Jeffery
2017-02-20 13:35     ` Corey Minyard
2017-02-20 14:52       ` Andrew Jeffery [this message]
2017-02-20 17:06         ` Corey Minyard
2016-12-14  1:29 ` Joel Stanley
2016-12-14  5:43   ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487602379.21631.2.camel@aj.id.au \
    --to=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).