* [PATCH v2 0/1] thermal: mt8173: minor mtk_thermal.c cleanups
@ 2017-02-21 12:26 Dawei Chien
2017-02-21 12:26 ` [PATCH v2 1/1] " Dawei Chien
0 siblings, 1 reply; 2+ messages in thread
From: Dawei Chien @ 2017-02-21 12:26 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Matthias Brugger, linux-pm, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, srv_heupstream,
Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo,
Stable
If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3.
However, currently thermal driver would not read TEMP_MSR3 since mt8173
thermal driver only use 3 sensors on each thermal bank at the same time,
so this patch would not effect temperature.
Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would
read third sensor two times, and lose fourth sensor of vale.
Change since V1:
1. Update commis message
a. Add Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
b. Add tag Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 1/1] thermal: mt8173: minor mtk_thermal.c cleanups
2017-02-21 12:26 [PATCH v2 0/1] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
@ 2017-02-21 12:26 ` Dawei Chien
0 siblings, 0 replies; 2+ messages in thread
From: Dawei Chien @ 2017-02-21 12:26 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Matthias Brugger, linux-pm, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, srv_heupstream,
Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo,
Stable, Dawei Chien
If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3.
However, currently thermal driver would not read TEMP_MSR3 since mt8173
thermal driver only use 3 sensors on each thermal bank at the same time,
so this patch would not effect temperature.
Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would
read third sensor two times, and lose fourth sensor of vale.
cc: stable@vger.kernel.org
Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
---
drivers/thermal/mtk_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 34169c3..c124151 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -191,7 +191,7 @@ struct mtk_thermal {
};
const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
- TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
+ TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
};
const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-21 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-21 12:26 [PATCH v2 0/1] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
2017-02-21 12:26 ` [PATCH v2 1/1] " Dawei Chien
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).