* [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon
@ 2017-02-23 16:24 Nicholas Mc Guire
2017-02-23 16:24 ` [PATCH 2/3] audit: audit_fsnotify: " Nicholas Mc Guire
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Nicholas Mc Guire @ 2017-02-23 16:24 UTC (permalink / raw)
To: Paul Moore; +Cc: Eric Paris, linux-audit, linux-kernel, Nicholas Mc Guire
The excess ; after the closing parenthesis is just code-noise it has no
and can be removed.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
Problem located by coccinelle
./kernel/auditfilter.c:341:2-3: Unneeded semicolon
./kernel/auditfilter.c:415:2-3: Unneeded semicolon
Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
Patch is against 4.10.0 (localversion-next is next-20170222)
kernel/auditfilter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 880519d..239d11c 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -338,7 +338,7 @@ static int audit_field_valid(struct audit_entry *entry, struct audit_field *f)
entry->rule.listnr != AUDIT_FILTER_USER)
return -EINVAL;
break;
- };
+ }
switch(f->type) {
default:
@@ -412,7 +412,7 @@ static int audit_field_valid(struct audit_entry *entry, struct audit_field *f)
if (entry->rule.listnr != AUDIT_FILTER_EXIT)
return -EINVAL;
break;
- };
+ }
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] audit: audit_fsnotify: remove unnecessary semicolon
2017-02-23 16:24 [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon Nicholas Mc Guire
@ 2017-02-23 16:24 ` Nicholas Mc Guire
2017-03-10 22:28 ` Paul Moore
2017-02-23 16:24 ` [PATCH 3/3] audit: audit_watch: " Nicholas Mc Guire
2017-03-10 22:26 ` [PATCH 1/3] audit: auditfilter: " Paul Moore
2 siblings, 1 reply; 6+ messages in thread
From: Nicholas Mc Guire @ 2017-02-23 16:24 UTC (permalink / raw)
To: Paul Moore; +Cc: Eric Paris, linux-audit, linux-kernel, Nicholas Mc Guire
The excess ; after the closing parenthesis is just code-noise it has no
and can be removed.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
Problem located by coccinelle
./kernel/audit_fsnotify.c:190:2-3: Unneeded semicolon
Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
Patch is against 4.10.0 (localversion-next is next-20170222)
kernel/audit_fsnotify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index 7ea57e5..b16a5bd 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -187,7 +187,7 @@ static int audit_mark_handle_event(struct fsnotify_group *group,
default:
BUG();
return 0;
- };
+ }
if (mask & (FS_CREATE|FS_MOVED_TO|FS_DELETE|FS_MOVED_FROM)) {
if (audit_compare_dname_path(dname, audit_mark->path, AUDIT_NAME_FULL))
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] audit: audit_watch: remove unnecessary semicolon
2017-02-23 16:24 [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon Nicholas Mc Guire
2017-02-23 16:24 ` [PATCH 2/3] audit: audit_fsnotify: " Nicholas Mc Guire
@ 2017-02-23 16:24 ` Nicholas Mc Guire
2017-03-10 22:30 ` Paul Moore
2017-03-10 22:26 ` [PATCH 1/3] audit: auditfilter: " Paul Moore
2 siblings, 1 reply; 6+ messages in thread
From: Nicholas Mc Guire @ 2017-02-23 16:24 UTC (permalink / raw)
To: Paul Moore; +Cc: Eric Paris, linux-audit, linux-kernel, Nicholas Mc Guire
The excess ; after the closing parenthesis is just code-noise it has no
and can be removed.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
Problem located by coccinelle
./kernel/audit_watch.c:495:2-3: Unneeded semicolon
Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
Patch is against 4.10.0 (localversion-next is next-20170222)
kernel/audit_watch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
index f79e465..e293165 100644
--- a/kernel/audit_watch.c
+++ b/kernel/audit_watch.c
@@ -492,7 +492,7 @@ static int audit_watch_handle_event(struct fsnotify_group *group,
BUG();
inode = NULL;
break;
- };
+ }
if (mask & (FS_CREATE|FS_MOVED_TO) && inode)
audit_update_watch(parent, dname, inode->i_sb->s_dev, inode->i_ino, 0);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon
2017-02-23 16:24 [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon Nicholas Mc Guire
2017-02-23 16:24 ` [PATCH 2/3] audit: audit_fsnotify: " Nicholas Mc Guire
2017-02-23 16:24 ` [PATCH 3/3] audit: audit_watch: " Nicholas Mc Guire
@ 2017-03-10 22:26 ` Paul Moore
2 siblings, 0 replies; 6+ messages in thread
From: Paul Moore @ 2017-03-10 22:26 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: Eric Paris, linux-audit, linux-kernel
On Thu, Feb 23, 2017 at 11:24 AM, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> The excess ; after the closing parenthesis is just code-noise it has no
> and can be removed.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> Problem located by coccinelle
> ./kernel/auditfilter.c:341:2-3: Unneeded semicolon
> ./kernel/auditfilter.c:415:2-3: Unneeded semicolon
>
> Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
>
> Patch is against 4.10.0 (localversion-next is next-20170222)
>
> kernel/auditfilter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Merged.
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 880519d..239d11c 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -338,7 +338,7 @@ static int audit_field_valid(struct audit_entry *entry, struct audit_field *f)
> entry->rule.listnr != AUDIT_FILTER_USER)
> return -EINVAL;
> break;
> - };
> + }
>
> switch(f->type) {
> default:
> @@ -412,7 +412,7 @@ static int audit_field_valid(struct audit_entry *entry, struct audit_field *f)
> if (entry->rule.listnr != AUDIT_FILTER_EXIT)
> return -EINVAL;
> break;
> - };
> + }
> return 0;
> }
>
> --
> 2.1.4
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] audit: audit_fsnotify: remove unnecessary semicolon
2017-02-23 16:24 ` [PATCH 2/3] audit: audit_fsnotify: " Nicholas Mc Guire
@ 2017-03-10 22:28 ` Paul Moore
0 siblings, 0 replies; 6+ messages in thread
From: Paul Moore @ 2017-03-10 22:28 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: Eric Paris, linux-audit, linux-kernel
On Thu, Feb 23, 2017 at 11:24 AM, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> The excess ; after the closing parenthesis is just code-noise it has no
> and can be removed.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> Problem located by coccinelle
> ./kernel/audit_fsnotify.c:190:2-3: Unneeded semicolon
>
> Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
>
> Patch is against 4.10.0 (localversion-next is next-20170222)
>
> kernel/audit_fsnotify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged.
> diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
> index 7ea57e5..b16a5bd 100644
> --- a/kernel/audit_fsnotify.c
> +++ b/kernel/audit_fsnotify.c
> @@ -187,7 +187,7 @@ static int audit_mark_handle_event(struct fsnotify_group *group,
> default:
> BUG();
> return 0;
> - };
> + }
>
> if (mask & (FS_CREATE|FS_MOVED_TO|FS_DELETE|FS_MOVED_FROM)) {
> if (audit_compare_dname_path(dname, audit_mark->path, AUDIT_NAME_FULL))
> --
> 2.1.4
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] audit: audit_watch: remove unnecessary semicolon
2017-02-23 16:24 ` [PATCH 3/3] audit: audit_watch: " Nicholas Mc Guire
@ 2017-03-10 22:30 ` Paul Moore
0 siblings, 0 replies; 6+ messages in thread
From: Paul Moore @ 2017-03-10 22:30 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: Eric Paris, linux-audit, linux-kernel
On Thu, Feb 23, 2017 at 11:24 AM, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> The excess ; after the closing parenthesis is just code-noise it has no
> and can be removed.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> Problem located by coccinelle
> ./kernel/audit_watch.c:495:2-3: Unneeded semicolon
>
> Patch was compiletested with: x86_64_defconfig (implies CONFIG_AUDIT )
>
> Patch is against 4.10.0 (localversion-next is next-20170222)
>
> kernel/audit_watch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged.
> diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
> index f79e465..e293165 100644
> --- a/kernel/audit_watch.c
> +++ b/kernel/audit_watch.c
> @@ -492,7 +492,7 @@ static int audit_watch_handle_event(struct fsnotify_group *group,
> BUG();
> inode = NULL;
> break;
> - };
> + }
>
> if (mask & (FS_CREATE|FS_MOVED_TO) && inode)
> audit_update_watch(parent, dname, inode->i_sb->s_dev, inode->i_ino, 0);
> --
> 2.1.4
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-10 22:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-23 16:24 [PATCH 1/3] audit: auditfilter: remove unnecessary semicolon Nicholas Mc Guire
2017-02-23 16:24 ` [PATCH 2/3] audit: audit_fsnotify: " Nicholas Mc Guire
2017-03-10 22:28 ` Paul Moore
2017-02-23 16:24 ` [PATCH 3/3] audit: audit_watch: " Nicholas Mc Guire
2017-03-10 22:30 ` Paul Moore
2017-03-10 22:26 ` [PATCH 1/3] audit: auditfilter: " Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).