* [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style
@ 2017-03-02 17:04 Georgios Emmanouil
2017-03-02 17:05 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Georgios Emmanouil
2017-03-04 22:44 ` [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style Julian Calaby
0 siblings, 2 replies; 8+ messages in thread
From: Georgios Emmanouil @ 2017-03-02 17:04 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: linux-wireless, devel, linux-kernel
Fixed comment style to the preferred kernel comment style.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 55d53c3..6bd4047 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -1,11 +1,9 @@
-/* ////////////////////////////////////////////////////////////////////////// */
-/* */
-/* Copyright (c) Atmel Corporation. All rights reserved. */
-/* */
-/* Module Name: wilc_spi.c */
-/* */
-/* */
-/* //////////////////////////////////////////////////////////////////////////// */
+/*
+ * Copyright (c) Atmel Corporation. All rights reserved.
+ *
+ * Module Name: wilc_spi.c
+ */
+
#include <linux/module.h>
#include <linux/init.h>
#include <linux/kernel.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis
2017-03-02 17:04 [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style Georgios Emmanouil
@ 2017-03-02 17:05 ` Georgios Emmanouil
2017-03-02 17:06 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Georgios Emmanouil
2017-03-04 22:45 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Julian Calaby
2017-03-04 22:44 ` [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style Julian Calaby
1 sibling, 2 replies; 8+ messages in thread
From: Georgios Emmanouil @ 2017-03-02 17:05 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: linux-wireless, devel, linux-kernel
Fixed alignment to match parenthesis.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 6bd4047..b48cb1c8 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -408,7 +408,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
if (len2 > ARRAY_SIZE(wb)) {
dev_err(&spi->dev, "spi buffer size too small (%d) (%zu)\n",
- len2, ARRAY_SIZE(wb));
+ len2, ARRAY_SIZE(wb));
return N_FAIL;
}
/* zero spi write buffers. */
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error
2017-03-02 17:05 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Georgios Emmanouil
@ 2017-03-02 17:06 ` Georgios Emmanouil
2017-03-02 17:07 ` [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style Georgios Emmanouil
2017-03-04 22:45 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Julian Calaby
2017-03-04 22:45 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Julian Calaby
1 sibling, 2 replies; 8+ messages in thread
From: Georgios Emmanouil @ 2017-03-02 17:06 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: linux-wireless, devel, linux-kernel
Fixed spelling error. 'unkmown' to 'unknown'.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index b48cb1c8..4f38922 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -963,12 +963,12 @@ static int wilc_spi_read_int(struct wilc *wilc, u32 *int_status)
}
{
- u32 unkmown_mask;
+ u32 unknown_mask;
- unkmown_mask = ~((1ul << g_spi.nint) - 1);
+ unknown_mask = ~((1ul << g_spi.nint) - 1);
- if ((tmp >> IRG_FLAGS_OFFSET) & unkmown_mask) {
- dev_err(&spi->dev, "Unexpected interrupt (2): j=%d, tmp=%x, mask=%x\n", j, tmp, unkmown_mask);
+ if ((tmp >> IRG_FLAGS_OFFSET) & unknown_mask) {
+ dev_err(&spi->dev, "Unexpected interrupt (2): j=%d, tmp=%x, mask=%x\n", j, tmp, unknown_mask);
happended = 1;
}
}
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style
2017-03-02 17:06 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Georgios Emmanouil
@ 2017-03-02 17:07 ` Georgios Emmanouil
2017-03-04 22:46 ` Julian Calaby
2017-03-04 22:45 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Julian Calaby
1 sibling, 1 reply; 8+ messages in thread
From: Georgios Emmanouil @ 2017-03-02 17:07 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: linux-wireless, devel, linux-kernel
Added blank line after function and modified comment style.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 4f38922..33c2f7c 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -1128,11 +1128,8 @@ static int wilc_spi_sync_ext(struct wilc *wilc, int nint)
return 1;
}
-/********************************************
- *
- * Global spi HIF function table
- *
- ********************************************/
+
+/* Global spi HIF function table */
static const struct wilc_hif_func wilc_hif_spi = {
.hif_init = wilc_spi_init,
.hif_deinit = _wilc_spi_deinit,
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style
2017-03-02 17:07 ` [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style Georgios Emmanouil
@ 2017-03-04 22:46 ` Julian Calaby
0 siblings, 0 replies; 8+ messages in thread
From: Julian Calaby @ 2017-03-04 22:46 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: Aditya Shankar, Ganesh Krishna, Greg KH, linux-wireless, devel,
linux-kernel
Hi All,
On Fri, Mar 3, 2017 at 4:07 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Added blank line after function and modified comment style.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error
2017-03-02 17:06 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Georgios Emmanouil
2017-03-02 17:07 ` [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style Georgios Emmanouil
@ 2017-03-04 22:45 ` Julian Calaby
1 sibling, 0 replies; 8+ messages in thread
From: Julian Calaby @ 2017-03-04 22:45 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: Aditya Shankar, Ganesh Krishna, Greg KH, linux-wireless, devel,
linux-kernel
Hi All,
On Fri, Mar 3, 2017 at 4:06 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Fixed spelling error. 'unkmown' to 'unknown'.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis
2017-03-02 17:05 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Georgios Emmanouil
2017-03-02 17:06 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Georgios Emmanouil
@ 2017-03-04 22:45 ` Julian Calaby
1 sibling, 0 replies; 8+ messages in thread
From: Julian Calaby @ 2017-03-04 22:45 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: Aditya Shankar, Ganesh Krishna, Greg KH, linux-wireless, devel,
linux-kernel
Hi All,
On Fri, Mar 3, 2017 at 4:05 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Fixed alignment to match parenthesis.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style
2017-03-02 17:04 [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style Georgios Emmanouil
2017-03-02 17:05 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Georgios Emmanouil
@ 2017-03-04 22:44 ` Julian Calaby
1 sibling, 0 replies; 8+ messages in thread
From: Julian Calaby @ 2017-03-04 22:44 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: Aditya Shankar, Ganesh Krishna, Greg KH, linux-wireless, devel,
linux-kernel
Hi All,
On Fri, Mar 3, 2017 at 4:04 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Fixed comment style to the preferred kernel comment style.
Fixing comment style and other stuff like that are the _least_ of the
problems with this driver, but you've done it, so...
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-03-04 22:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 17:04 [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style Georgios Emmanouil
2017-03-02 17:05 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Georgios Emmanouil
2017-03-02 17:06 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Georgios Emmanouil
2017-03-02 17:07 ` [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style Georgios Emmanouil
2017-03-04 22:46 ` Julian Calaby
2017-03-04 22:45 ` [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error Julian Calaby
2017-03-04 22:45 ` [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis Julian Calaby
2017-03-04 22:44 ` [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style Julian Calaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).