* [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity.
@ 2017-03-09 5:49 Arvind Yadav
2017-03-14 9:28 ` Pali Rohár
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-03-09 5:49 UTC (permalink / raw)
To: mjg59, pali.rohar, dvhart, andy; +Cc: platform-driver-x86, linux-kernel
Here, This patch is to handle a return error from dell_get_intensity.
This change is done using Coccinelle.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index f57dd28..7fcf680 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -2053,11 +2053,17 @@ static int __init dell_init(void)
dell_backlight_device->props.brightness =
dell_get_intensity(dell_backlight_device);
+ if (dell_backlight_device->props.brightness < 0) {
+ ret = dell_backlight_device->props.brightness;
+ goto fail_get_brightness;
+ }
backlight_update_status(dell_backlight_device);
}
return 0;
+fail_get_brightness:
+ backlight_device_unregister(dell_backlight_device);
fail_backlight:
dell_cleanup_rfkill();
fail_rfkill:
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity.
2017-03-09 5:49 [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity Arvind Yadav
@ 2017-03-14 9:28 ` Pali Rohár
0 siblings, 0 replies; 2+ messages in thread
From: Pali Rohár @ 2017-03-14 9:28 UTC (permalink / raw)
To: Arvind Yadav; +Cc: mjg59, dvhart, andy, platform-driver-x86, linux-kernel
On Thursday 09 March 2017 11:19:56 Arvind Yadav wrote:
> Here, This patch is to handle a return error from dell_get_intensity.
> This change is done using Coccinelle.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Ok, seems good. You can add my Acked-By.
> ---
> drivers/platform/x86/dell-laptop.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index f57dd28..7fcf680 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -2053,11 +2053,17 @@ static int __init dell_init(void)
>
> dell_backlight_device->props.brightness =
> dell_get_intensity(dell_backlight_device);
> + if (dell_backlight_device->props.brightness < 0) {
> + ret = dell_backlight_device->props.brightness;
> + goto fail_get_brightness;
> + }
> backlight_update_status(dell_backlight_device);
> }
>
> return 0;
>
> +fail_get_brightness:
> + backlight_device_unregister(dell_backlight_device);
> fail_backlight:
> dell_cleanup_rfkill();
> fail_rfkill:
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-14 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-09 5:49 [PATCH v2] platform/x86: dell-laptop: Handle return error form dell_get_intensity Arvind Yadav
2017-03-14 9:28 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).