Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding

From: Sean Wang <sean.wang@mediatek.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <f.fainelli@gmail.com>, <vivien.didelot@savoirfairelinux.com>,
	<matthias.bgg@gmail.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <davem@davemloft.net>,
	<Landen.Chao@mediatek.com>, <keyhaede@gmail.com>,
	<objelf@gmail.com>
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding
Date: Tue, 14 Mar 2017 14:06:35 +0800	[thread overview]
Message-ID: <1489471595.1870.12.camel@mtkswgap22> (raw)
In-Reply-To: <20170313163624.GD3953@lunn.ch>

On Mon, 2017-03-13 at 17:36 +0100, Andrew Lunn wrote:
> > +- mediatek,reset-pin: Phandle to the pinctrl node used for the reset. Which
> > +	must be required if the property mediatek,mcm of specified as
> > +	"disabled". See
> > +	Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt for
> > +	the mediatek pintcrl setting for the details.
> 
> Hi Sean
> 
> This appears to be a plan GPIO line. Marvell has the same. It would be
> nice to be consistent with the naming. From
> Documentation/devicetree/bindings/net/dsa/marvell.txt
> 
> Optional properties:
> 
> - reset-gpios           : Should be a gpio specifier for a reset line
> 
>   Andrew

Hi Andrew,

I'll change the property into the consistent way, and usage for 

GPIO control be also used in devm_gpiod_* instead as you suggested

for patch 4.

	Sean